civicrm-core.git
2 years agoMerge pull request #26880 from colemanw/jobToJob
Eileen McNaughton [Wed, 19 Jul 2023 23:40:32 +0000 (11:40 +1200)]
Merge pull request #26880 from colemanw/jobToJob

Job - uppercase api entity

2 years agoMerge pull request #26876 from colemanw/scheduleReminderForm
Seamus Lee [Wed, 19 Jul 2023 22:53:56 +0000 (18:53 -0400)]
Merge pull request #26876 from colemanw/scheduleReminderForm

[REF] ScheduleReminders - Cleanup "sublimely stupid" form code

2 years agoJob - uppercase api entity
colemanw [Wed, 19 Jul 2023 18:07:10 +0000 (14:07 -0400)]
Job - uppercase api entity

2 years agoMerge pull request #26877 from colemanw/godHasAnswered
Matthew Wire [Wed, 19 Jul 2023 14:24:42 +0000 (15:24 +0100)]
Merge pull request #26877 from colemanw/godHasAnswered

God has answered

2 years agoGod has answered
colemanw [Wed, 19 Jul 2023 01:24:11 +0000 (21:24 -0400)]
God has answered

2 years agoScheduleReminders - Cleanup awful form code
colemanw [Wed, 19 Jul 2023 00:30:12 +0000 (20:30 -0400)]
ScheduleReminders - Cleanup awful form code

Lots more refactoring to do, this fixes the easy-to-fix things that were obviously wrong.

2 years agoMerge pull request #26867 from eileenmcnaughton/import
colemanw [Tue, 18 Jul 2023 23:34:31 +0000 (16:34 -0700)]
Merge pull request #26867 from eileenmcnaughton/import

Fix js error on CiviImport when csv has additional fields

2 years agoMerge pull request #26875 from civicrm/5.64
Eileen McNaughton [Tue, 18 Jul 2023 23:16:39 +0000 (11:16 +1200)]
Merge pull request #26875 from civicrm/5.64

5.64

2 years agoMerge pull request #26855 from colemanw/actionMappingCleanup
Seamus Lee [Tue, 18 Jul 2023 22:51:23 +0000 (18:51 -0400)]
Merge pull request #26855 from colemanw/actionMappingCleanup

[REF] ActionMapping - Improve class structure

2 years agoMerge pull request #26874 from eileenmcnaughton/property_test
Eileen McNaughton [Tue, 18 Jul 2023 22:50:24 +0000 (10:50 +1200)]
Merge pull request #26874 from eileenmcnaughton/property_test

Cleanup test class, including fix undeclared property

2 years agoMerge pull request #26831 from totten/5.64-icon-path
Seamus Lee [Tue, 18 Jul 2023 22:43:34 +0000 (18:43 -0400)]
Merge pull request #26831 from totten/5.64-icon-path

(dev/core#4414) Greenwich - Fix icon path

2 years agoCleanup test class, including fix undeclared property
Eileen McNaughton [Tue, 18 Jul 2023 20:37:15 +0000 (08:37 +1200)]
Cleanup test class, including fix undeclared property

2 years agoMerge pull request #26871 from demeritcowboy/upg-smarty
demeritcowboy [Tue, 18 Jul 2023 21:45:32 +0000 (17:45 -0400)]
Merge pull request #26871 from demeritcowboy/upg-smarty

Upgrade doesn't work

2 years agoMerge pull request #26872 from eileenmcnaughton/custom
demeritcowboy [Tue, 18 Jul 2023 21:45:16 +0000 (17:45 -0400)]
Merge pull request #26872 from eileenmcnaughton/custom

Remove never set property from previously shared code

2 years agocorrect precedence
demeritcowboy [Tue, 18 Jul 2023 20:04:14 +0000 (16:04 -0400)]
correct precedence

2 years agoRemove never set property from previously shared code
Eileen McNaughton [Tue, 18 Jul 2023 20:01:01 +0000 (08:01 +1200)]
Remove never set property from previously shared code

2 years agobe more literal
demeritcowboy [Tue, 18 Jul 2023 19:49:01 +0000 (15:49 -0400)]
be more literal

2 years agoActionMapping - Clean up obtuse methods of fetching a MappingInterface class
colemanw [Tue, 18 Jul 2023 14:46:14 +0000 (10:46 -0400)]
ActionMapping - Clean up obtuse methods of fetching a MappingInterface class

Changed calls to getMappings to use getMapping if they only needed a single value.
In some cases they could be entirely removed because they weren't using the retrieved class for anything.
Deprecated the use of 'filters' param in getMappings as it was redundant with simply calling getMapping with an id.

2 years agoMerge pull request #26869 from yashodha/add_tpl_class
Seamus Lee [Tue, 18 Jul 2023 07:30:37 +0000 (03:30 -0400)]
Merge pull request #26869 from yashodha/add_tpl_class

fix duplicate id for softCredit

2 years agofix duplicate id for softCredit
yashodha [Tue, 18 Jul 2023 05:19:47 +0000 (10:49 +0530)]
fix duplicate id for softCredit

2 years agoFix js error on CiviImport when csv has additional fields
Eileen McNaughton [Tue, 18 Jul 2023 03:04:55 +0000 (15:04 +1200)]
Fix js error on CiviImport when csv has additional fields

2 years agoActionMapping - Improve class structure
colemanw [Tue, 18 Jul 2023 00:27:51 +0000 (20:27 -0400)]
ActionMapping - Improve class structure

Completes the refactoring that began with https://github.com/civicrm/civicrm-core/pull/6687
Fully migrates from the old model based on the civicrm_action_mapping table
(dropped in https://github.com/civicrm/civicrm-core/pull/26646)
by removing all references to that structure and fully embracing the object-model.
New common base-class added to make it eaiser to implement MappingInterface.

2 years agoMerge pull request #26866 from eileenmcnaughton/logged
Seamus Lee [Tue, 18 Jul 2023 00:05:00 +0000 (20:05 -0400)]
Merge pull request #26866 from eileenmcnaughton/logged

Superficial cleanup in pledge form

2 years agoMerge pull request #26852 from totten/master-s3b
Tim Otten [Mon, 17 Jul 2023 21:58:02 +0000 (14:58 -0700)]
Merge pull request #26852 from totten/master-s3b

Standalone - Web-based installation for PHP built-in server

2 years agoMerge pull request #26864 from colemanw/deleteBoilerplate
Eileen McNaughton [Mon, 17 Jul 2023 21:25:34 +0000 (09:25 +1200)]
Merge pull request #26864 from colemanw/deleteBoilerplate

[NFC] Delete unused boilerplate comments

2 years agoSuperficial cleanup in pledge form
Eileen McNaughton [Mon, 17 Jul 2023 21:05:12 +0000 (09:05 +1200)]
Superficial cleanup in pledge form

2 years agoDelete unused boilerplate comments
colemanw [Mon, 17 Jul 2023 18:17:41 +0000 (14:17 -0400)]
Delete unused boilerplate comments

2 years agoMerge pull request #26863 from aydun/searchui_create
colemanw [Mon, 17 Jul 2023 18:15:01 +0000 (11:15 -0700)]
Merge pull request #26863 from aydun/searchui_create

Create SearchUI extension

2 years agoUpdate AdminUI & SearchUI info.xml
Aidan Saunders [Mon, 17 Jul 2023 17:36:51 +0000 (18:36 +0100)]
Update AdminUI & SearchUI info.xml

2 years agoMove Contact Search from AdminUI to SearchUI
Aidan Saunders [Mon, 17 Jul 2023 17:07:59 +0000 (18:07 +0100)]
Move Contact Search from AdminUI to SearchUI

2 years agoCreate SearchUI extension
Aidan Saunders [Mon, 17 Jul 2023 17:07:33 +0000 (18:07 +0100)]
Create SearchUI extension

2 years agoMerge pull request #26862 from yashodha/add_tpl_class
colemanw [Mon, 17 Jul 2023 16:28:10 +0000 (09:28 -0700)]
Merge pull request #26862 from yashodha/add_tpl_class

Add classes to membership results

2 years agoadd classes to membership results
yashodha [Mon, 17 Jul 2023 15:04:25 +0000 (20:34 +0530)]
add classes to membership results

2 years agoMerge pull request #26860 from eileenmcnaughton/member
Yashodha Chaku [Mon, 17 Jul 2023 11:57:27 +0000 (17:27 +0530)]
Merge pull request #26860 from eileenmcnaughton/member

[PHP8.2] move property declaration form CRM_Member_Form_Membership to parent

2 years agoMerge pull request #26842 from colemanw/isActiveToggle
Aidan Saunders [Mon, 17 Jul 2023 09:44:35 +0000 (10:44 +0100)]
Merge pull request #26842 from colemanw/isActiveToggle

AdminUI - Add toggle for is_active

2 years agoMerge pull request #26857 from eileenmcnaughton/logged
Yashodha Chaku [Mon, 17 Jul 2023 06:32:51 +0000 (12:02 +0530)]
Merge pull request #26857 from eileenmcnaughton/logged

[tests][php8.2] Use function rather than sometimes declared property for loggedInUserID

2 years ago[tests][php8.2] Use function rather than sometimes declared property for loggedInUserID
Eileen McNaughton [Mon, 17 Jul 2023 01:20:56 +0000 (13:20 +1200)]
[tests][php8.2] Use function rather than sometimes declared property for loggedInUserID

2 years agoMerge pull request #26859 from eileenmcnaughton/cust_case
colemanw [Mon, 17 Jul 2023 03:02:23 +0000 (20:02 -0700)]
Merge pull request #26859 from eileenmcnaughton/cust_case

[php8.2] Fix undeclared properties on case custom data form

2 years agoMerge pull request #26858 from eileenmcnaughton/cust_by_type
Seamus Lee [Mon, 17 Jul 2023 03:01:29 +0000 (23:01 -0400)]
Merge pull request #26858 from eileenmcnaughton/cust_by_type

Remove never-true-if

2 years agoMerge pull request #26845 from eileenmcnaughton/subname
demeritcowboy [Mon, 17 Jul 2023 02:39:38 +0000 (22:39 -0400)]
Merge pull request #26845 from eileenmcnaughton/subname

Remove `_subName` property

2 years ago[php8.2] Fix undeclared properties on case custom data form
Eileen McNaughton [Mon, 17 Jul 2023 02:05:24 +0000 (14:05 +1200)]
[php8.2] Fix undeclared properties on case custom data form

2 years ago[PHP8.2] move property declaration form CRM_Member_Form_Membership to parent
Eileen McNaughton [Mon, 17 Jul 2023 02:18:39 +0000 (14:18 +1200)]
[PHP8.2] move property declaration form CRM_Member_Form_Membership to parent

2 years agoRemove never-true-if
Eileen McNaughton [Mon, 17 Jul 2023 01:36:51 +0000 (13:36 +1200)]
Remove never-true-if

2 years agoMerge pull request #26856 from seamuslee001/p82_logged_in_user
Tim Otten [Mon, 17 Jul 2023 00:58:45 +0000 (17:58 -0700)]
Merge pull request #26856 from seamuslee001/p82_logged_in_user

[NFC][PHP8.2] Fix dynamic property _loggedInUser

2 years ago[NFC][PHP8.2] Fix dynamic property _loggedInUser
Seamus Lee [Sun, 16 Jul 2023 22:57:16 +0000 (08:57 +1000)]
[NFC][PHP8.2] Fix dynamic property _loggedInUser

2 years agoActionMapping - Rename ambiguous 'getEntity' function
colemanw [Sun, 16 Jul 2023 21:29:49 +0000 (17:29 -0400)]
ActionMapping - Rename ambiguous 'getEntity' function

Before: function getEntity() actually returns the name of the table, not the entity
After: function getEntityTable() returns table name and getEntityName() returns entity name

2 years agoMerge pull request #26843 from colemanw/searchKitButtons
demeritcowboy [Sun, 16 Jul 2023 15:08:42 +0000 (11:08 -0400)]
Merge pull request #26843 from colemanw/searchKitButtons

SearchKit - fix min-width of buttons

2 years agoMerge pull request #26850 from totten/master-ref-mail
colemanw [Sun, 16 Jul 2023 14:28:52 +0000 (07:28 -0700)]
Merge pull request #26850 from totten/master-ref-mail

(REF) CMSUser::create - Rename misleading parameter

2 years agoMerge pull request #26851 from eileenmcnaughton/unshared
Eileen McNaughton [Sun, 16 Jul 2023 06:35:45 +0000 (18:35 +1200)]
Merge pull request #26851 from eileenmcnaughton/unshared

Follow up fix (master only regression)

2 years agoSetup UI - Use separate "Database" section (on standalone)
Tim Otten [Sun, 16 Jul 2023 06:12:18 +0000 (23:12 -0700)]
Setup UI - Use separate "Database" section (on standalone)

2 years agoSetup UI - Display "Administrator" options (on standalone)
Tim Otten [Sun, 16 Jul 2023 05:55:00 +0000 (22:55 -0700)]
Setup UI - Display "Administrator" options (on standalone)

2 years agoFollow up fix
Eileen McNaughton [Sun, 16 Jul 2023 05:12:13 +0000 (17:12 +1200)]
Follow up fix

2 years agoStandalone - Interpret the $mailParam (same way as everyone else)
Tim Otten [Sun, 16 Jul 2023 04:54:12 +0000 (21:54 -0700)]
Standalone - Interpret the $mailParam (same way as everyone else)

2 years agosetup - Fix php8 warnings when MySQL password is blank
Tim Otten [Sun, 16 Jul 2023 04:11:02 +0000 (21:11 -0700)]
setup - Fix php8 warnings when MySQL password is blank

2 years agoSetupResponse - Fix php8 warning
Tim Otten [Sun, 16 Jul 2023 04:10:02 +0000 (21:10 -0700)]
SetupResponse - Fix php8 warning

2 years agoSelectValues::permissions - Fix php8 warning
Tim Otten [Sun, 16 Jul 2023 04:08:17 +0000 (21:08 -0700)]
SelectValues::permissions - Fix php8 warning

2 years agoDbUtil - Report MySQL failures consistently on php7+php8
Tim Otten [Sun, 16 Jul 2023 04:11:12 +0000 (21:11 -0700)]
DbUtil - Report MySQL failures consistently on php7+php8

2 years agorouter.php - Enable the "civicrm-setup" UI
Tim Otten [Sun, 16 Jul 2023 04:11:38 +0000 (21:11 -0700)]
router.php - Enable the "civicrm-setup" UI

2 years agorouter.php - Fix for php73 compat
Tim Otten [Sun, 16 Jul 2023 03:34:20 +0000 (20:34 -0700)]
router.php - Fix for php73 compat

2 years agoStandalone.civi-setup.php - Fix 'HTTP'/'HTTPS' detection on non-Apache environments
Tim Otten [Sun, 16 Jul 2023 03:32:14 +0000 (20:32 -0700)]
Standalone.civi-setup.php - Fix 'HTTP'/'HTTPS' detection on non-Apache environments

2 years ago(REF) CMSUser::create - Rename misleading parameter
Tim Otten [Sun, 16 Jul 2023 04:36:16 +0000 (21:36 -0700)]
(REF) CMSUser::create - Rename misleading parameter

The second parameter is very confusing:

* The name `$mail` suggests that the parameter is an email address.
* The parameter `$mail` actually contains the name of the *field* which has the email address.

This is a weird contract. It invites misinterpretation -- and now, e.g., some of the `Standalone`
code has misused it.

To confirm that `$mail` is actually the parameter-name, note that:

1. `create()` actually looks for `$params[$mail]`
2. Callers like `CRM/Contact/Form/Task/Useradd.php` actually give a parameter name

2 years agoMerge pull request #26771 from totten/master-s3
Tim Otten [Sun, 16 Jul 2023 04:26:31 +0000 (21:26 -0700)]
Merge pull request #26771 from totten/master-s3

Standalone - Add support for development-friendly file-layouts

2 years agoMerge pull request #26839 from colemanw/searchKitActionLinksCleanup
Eileen McNaughton [Sun, 16 Jul 2023 04:13:03 +0000 (16:13 +1200)]
Merge pull request #26839 from colemanw/searchKitActionLinksCleanup

Search kit action links cleanup

2 years agoMerge pull request #26848 from mlutfy/newEventTR
Eileen McNaughton [Sun, 16 Jul 2023 04:12:11 +0000 (16:12 +1200)]
Merge pull request #26848 from mlutfy/newEventTR

[NFC] New Event: remove empty table row

2 years agoMerge pull request #26846 from eileenmcnaughton/custom
colemanw [Sun, 16 Jul 2023 01:57:42 +0000 (18:57 -0700)]
Merge pull request #26846 from eileenmcnaughton/custom

Notice fix - ensure extends_entity_column_value isset

2 years agoNew Event: remove empty table row
Mathieu Lutfy [Sun, 16 Jul 2023 01:25:34 +0000 (21:25 -0400)]
New Event: remove empty table row

2 years agoMerge pull request #26844 from eileenmcnaughton/unshared
colemanw [Sun, 16 Jul 2023 01:18:09 +0000 (18:18 -0700)]
Merge pull request #26844 from eileenmcnaughton/unshared

Fold private `setGroupTree` function back into caller

2 years agoNotice fix - ensure extends_entity_column_value isset
Eileen McNaughton [Sun, 16 Jul 2023 00:05:59 +0000 (12:05 +1200)]
Notice fix - ensure extends_entity_column_value isset

2 years agoRemove subName property in favour of an internal variable
Eileen McNaughton [Sat, 15 Jul 2023 23:29:51 +0000 (11:29 +1200)]
Remove subName property in favour of an internal variable

This is not used outside the function

2 years agoRemove use of subName property
Eileen McNaughton [Sat, 15 Jul 2023 23:26:18 +0000 (11:26 +1200)]
Remove use of subName property

2 years agoMerge pull request #26791 from jmcclelland/hide-view-only
Eileen McNaughton [Sat, 15 Jul 2023 23:20:23 +0000 (11:20 +1200)]
Merge pull request #26791 from jmcclelland/hide-view-only

hide view only custom fields on merge screen

2 years agoFold private setGroupTree function back into caller
Eileen McNaughton [Sat, 15 Jul 2023 23:17:28 +0000 (11:17 +1200)]
Fold private setGroupTree function back into caller

2 years agoSearchKit - fix min-width of buttons
colemanw [Sat, 15 Jul 2023 20:20:42 +0000 (16:20 -0400)]
SearchKit - fix min-width of buttons

2 years agoAdminUI - Add toggle for is_active
colemanw [Sat, 15 Jul 2023 20:00:33 +0000 (16:00 -0400)]
AdminUI - Add toggle for is_active

2 years agoSearchKit - Ensure task links work with relationships
colemanw [Sat, 15 Jul 2023 16:10:48 +0000 (12:10 -0400)]
SearchKit - Ensure task links work with relationships

2 years agoSearchKit - Make loading task links more efficient
colemanw [Sat, 15 Jul 2023 02:16:32 +0000 (22:16 -0400)]
SearchKit - Make loading task links more efficient

2 years agoMerge pull request #26837 from eileenmcnaughton/no_pre_process
colemanw [Sat, 15 Jul 2023 14:59:28 +0000 (07:59 -0700)]
Merge pull request #26837 from eileenmcnaughton/no_pre_process

Fold `preProcess` into `run`

2 years agoMerge pull request #26836 from eileenmcnaughton/unshared
demeritcowboy [Sat, 15 Jul 2023 14:20:40 +0000 (10:20 -0400)]
Merge pull request #26836 from eileenmcnaughton/unshared

Remove last reference to undefined property `_subType`

2 years agoMerge pull request #26838 from seamuslee001/php82_ssid_dynamic
Eileen McNaughton [Sat, 15 Jul 2023 03:30:55 +0000 (15:30 +1200)]
Merge pull request #26838 from seamuslee001/php82_ssid_dynamic

[REF][PHP8.2] Ref fix deprecation in PHP8.2 about dynamic property _ssID

2 years agoUse internal var for groupID
Eileen McNaughton [Sat, 15 Jul 2023 01:42:25 +0000 (13:42 +1200)]
Use internal var for groupID

2 years agoMerge pull request #26835 from seamuslee001/performance_fix
colemanw [Sat, 15 Jul 2023 02:25:06 +0000 (19:25 -0700)]
Merge pull request #26835 from seamuslee001/performance_fix

Ensure that we only check permissions if we want to in getActions fol…

2 years ago[REF][PHP8.2] Ref fix deprecation in PHP8.2 about dynamic property _ssID
Seamus Lee [Sat, 15 Jul 2023 02:11:54 +0000 (12:11 +1000)]
[REF][PHP8.2] Ref fix deprecation in PHP8.2 about dynamic property _ssID

2 years agoFold preProcess into run
Eileen McNaughton [Sat, 15 Jul 2023 02:01:48 +0000 (14:01 +1200)]
Fold preProcess into run

there are properties that appear to be being set solely to pass variables from preProcess to
run.

preProcess is called from run and that is the only way it is accessed.

There are some forms that use the pageRun hook in the universe but this has no impact on them

2 years agoSearchKit - Break getLinkInfo into 3 smaller functions
colemanw [Sat, 15 Jul 2023 01:49:28 +0000 (21:49 -0400)]
SearchKit - Break getLinkInfo into 3 smaller functions

2 years agoMerge pull request #26834 from eileenmcnaughton/amount
Seamus Lee [Sat, 15 Jul 2023 01:43:08 +0000 (21:43 -0400)]
Merge pull request #26834 from eileenmcnaughton/amount

[REF] Use internal variable rather than property to pass variable

2 years agoRemove last reference to undefined property ->_subType
Eileen McNaughton [Sat, 15 Jul 2023 01:39:02 +0000 (13:39 +1200)]
Remove last reference to undefined property ->_subType

2 years agoEnsure that we only check permissions if we want to in getActions follow up to #26823
Seamus Lee [Sat, 15 Jul 2023 01:15:30 +0000 (11:15 +1000)]
Ensure that we only check permissions if we want to in getActions follow up to #26823

Make it more readable as per coleman

2 years agoMerge pull request #26832 from eileenmcnaughton/unshared
Seamus Lee [Sat, 15 Jul 2023 01:21:13 +0000 (21:21 -0400)]
Merge pull request #26832 from eileenmcnaughton/unshared

[REF] [PHP8.2] Post unshare cleanup

2 years agoUse internal variable rather than property to pass variable
Eileen McNaughton [Sat, 15 Jul 2023 01:11:05 +0000 (13:11 +1200)]
Use internal variable rather than property to pass variable

2 years agoMerge pull request #26833 from eileenmcnaughton/unshared2
colemanw [Sat, 15 Jul 2023 01:05:51 +0000 (18:05 -0700)]
Merge pull request #26833 from eileenmcnaughton/unshared2

[REF] [PHP8.2]Treat subType as a internal varible, not a form property

2 years agoDo not pass in subType as the same value will be calculated
Eileen McNaughton [Sat, 15 Jul 2023 00:25:20 +0000 (12:25 +1200)]
Do not pass in subType as the same value will be calculated

2 years agoAdd deprecation to otherwise deprecated chunk
Eileen McNaughton [Sat, 15 Jul 2023 00:22:20 +0000 (12:22 +1200)]
Add deprecation to otherwise deprecated chunk

2 years agoTreat subType as a internal varible, not a form property
Eileen McNaughton [Sat, 15 Jul 2023 00:20:11 +0000 (12:20 +1200)]
Treat subType as a internal varible, not a form property

2 years agoMerge pull request #26830 from seamuslee001/php82_contribute_history
Seamus Lee [Sat, 15 Jul 2023 00:17:27 +0000 (20:17 -0400)]
Merge pull request #26830 from seamuslee001/php82_contribute_history

[REF][PHP8.2] Fix Deprectation notice due to dynamic properties on th…

2 years agoMerge pull request #26828 from seamuslee001/php82_logging_detail
Seamus Lee [Sat, 15 Jul 2023 00:17:16 +0000 (20:17 -0400)]
Merge pull request #26828 from seamuslee001/php82_logging_detail

[REF][PHP8.2] Fix deprecated dynamic properties in Logging Report Detail

2 years agoPost unshare cleanup
Eileen McNaughton [Sat, 15 Jul 2023 00:12:42 +0000 (12:12 +1200)]
Post unshare cleanup

This stops passing & returning unused values from the previously shared function
& removes a deprecated chunk.

This deprecation was very precautionary IMHO so 6 months is long enough

2 years agoMerge pull request #26829 from eileenmcnaughton/cust_share
Seamus Lee [Fri, 14 Jul 2023 23:55:04 +0000 (19:55 -0400)]
Merge pull request #26829 from eileenmcnaughton/cust_share

[Ref] [php8] Unshare shared function `CRM_Custom_Form_CustomData::setGroupTree` in order to clean-up

2 years agoMerge pull request #26776 from eileenmcnaughton/result
Seamus Lee [Fri, 14 Jul 2023 23:53:11 +0000 (19:53 -0400)]
Merge pull request #26776 from eileenmcnaughton/result

[REF] Stop passing `result` into `getContributionParams` to get one value from it, in one code path

2 years agoMerge pull request #26775 from eileenmcnaughton/cont_recur
Seamus Lee [Fri, 14 Jul 2023 23:51:57 +0000 (19:51 -0400)]
Merge pull request #26775 from eileenmcnaughton/cont_recur

[Ref] Minor cleanup on handling of financial type

2 years ago[REF][PHP8.2] Fix Deprectation notice due to dynamic properties on the Contribute...
Seamus Lee [Fri, 14 Jul 2023 23:39:29 +0000 (09:39 +1000)]
[REF][PHP8.2] Fix Deprectation notice due to dynamic properties on the Contribute History report