civicrm-core.git
2 years agoCiviCampaign - Add labels to field metadata
Coleman Watts [Sat, 12 Nov 2022 20:16:00 +0000 (15:16 -0500)]
CiviCampaign - Add labels to field metadata

2 years agoMerge pull request #24979 from eileenmcnaughton/dao
Seamus Lee [Wed, 16 Nov 2022 07:33:15 +0000 (18:33 +1100)]
Merge pull request #24979 from eileenmcnaughton/dao

Regen DAO

2 years agoRegen DAO
Eileen McNaughton [Wed, 16 Nov 2022 05:51:59 +0000 (18:51 +1300)]
Regen DAO

2 years agoMerge pull request #24976 from colemanw/api4Autocompletes
colemanw [Tue, 15 Nov 2022 19:50:06 +0000 (14:50 -0500)]
Merge pull request #24976 from colemanw/api4Autocompletes

APIv4 Autocomplete - Support searching by ID, customize some entities

2 years agoMerge pull request #24977 from colemanw/exceptions
Matthew Wire [Tue, 15 Nov 2022 19:33:04 +0000 (19:33 +0000)]
Merge pull request #24977 from colemanw/exceptions

APIv3 - Use the Exception rather than the rule

2 years agoAPIv4 Autocomplete improvements - Support searching by ID, customize some entities
Coleman Watts [Tue, 15 Nov 2022 13:18:11 +0000 (08:18 -0500)]
APIv4 Autocomplete improvements - Support searching by ID, customize some entities

Gives parity with the v3-based widget which would search either by id or label
and place the exact match at the top if found.

Also gives parity with the customized output of some v3 entities,
plus a few like Relationship that v3 never was able to handle.

2 years agoAPIv3 - Use the Exception rather than the rule
Coleman Watts [Tue, 15 Nov 2022 15:58:26 +0000 (10:58 -0500)]
APIv3 - Use the Exception rather than the rule

Following up on #19323 this converts APIv3 in Smarty and Ajax to use exceptions instead
of overriding the PEAR exception handler. Now that PEAR throws exceptions there is
no need to do so and it was interfering with try/catch handlers within the api call.

2 years agoMerge pull request #24970 from eileenmcnaughton/enabled_4
colemanw [Tue, 15 Nov 2022 14:13:38 +0000 (09:13 -0500)]
Merge pull request #24970 from eileenmcnaughton/enabled_4

Add html definition to schema for is_active (part 4)

2 years agoMerge pull request #24969 from eileenmcnaughton/enabled_3
colemanw [Tue, 15 Nov 2022 14:13:01 +0000 (09:13 -0500)]
Merge pull request #24969 from eileenmcnaughton/enabled_3

Add html definition to schema for is_active (part 3)

2 years agoMerge pull request #24968 from eileenmcnaughton/enabled_2
colemanw [Tue, 15 Nov 2022 14:12:01 +0000 (09:12 -0500)]
Merge pull request #24968 from eileenmcnaughton/enabled_2

Add html definition to schema for is_active (part 2)

2 years agoMerge pull request #24967 from eileenmcnaughton/enabled
colemanw [Tue, 15 Nov 2022 14:11:38 +0000 (09:11 -0500)]
Merge pull request #24967 from eileenmcnaughton/enabled

Add html definition to schema for is_active (part 1)

2 years agoMerge pull request #24975 from artfulrobot/artfulrobot-support-es6-in-civilint
demeritcowboy [Tue, 15 Nov 2022 05:47:36 +0000 (00:47 -0500)]
Merge pull request #24975 from artfulrobot/artfulrobot-support-es6-in-civilint

Support ES6 (2015) in civilint: jshint config update

2 years agoMerge pull request #24760 from colemanw/adminUiCleanup
colemanw [Mon, 14 Nov 2022 18:22:41 +0000 (13:22 -0500)]
Merge pull request #24760 from colemanw/adminUiCleanup

AdminUI - Always cleanup saved searches during uninstall

2 years agoMerge pull request #24974 from colemanw/api4Autocompletes
Matthew Wire [Mon, 14 Nov 2022 14:32:36 +0000 (14:32 +0000)]
Merge pull request #24974 from colemanw/api4Autocompletes

Use APIv4-based Autocomplete widget throughout SearchKit, Afform & API Explorer

2 years agoSupport ES6 (2015) in civilint: jshint config update
Rich Lott / Artful Robot [Mon, 14 Nov 2022 13:56:16 +0000 (13:56 +0000)]
Support ES6 (2015) in civilint: jshint config update

2 years agoAPIv4 Explorer - Use APIv4 autocomplete instead of v3 entityRef
Coleman Watts [Mon, 14 Nov 2022 02:29:25 +0000 (21:29 -0500)]
APIv4 Explorer - Use APIv4 autocomplete instead of v3 entityRef

2 years agoSearchKit, Afform - Use APIv4-based Autocomplete widget throughout
Coleman Watts [Mon, 14 Nov 2022 01:32:46 +0000 (20:32 -0500)]
SearchKit, Afform - Use APIv4-based Autocomplete widget throughout

2 years agoMerge pull request #24966 from colemanw/afformMultiEntityRef
Eileen McNaughton [Mon, 14 Nov 2022 01:20:57 +0000 (14:20 +1300)]
Merge pull request #24966 from colemanw/afformMultiEntityRef

Afform - Fix multivalue entityRef fields

2 years agoMerge pull request #24973 from civicrm/5.56
Eileen McNaughton [Mon, 14 Nov 2022 00:05:11 +0000 (13:05 +1300)]
Merge pull request #24973 from civicrm/5.56

5.56 to master

2 years agoMerge pull request #24965 from colemanw/afformFieldMetaFix
Eileen McNaughton [Mon, 14 Nov 2022 00:04:09 +0000 (13:04 +1300)]
Merge pull request #24965 from colemanw/afformFieldMetaFix

[PHP 8.1 compat] Afform - Fix display of search filter fields

2 years agoMerge pull request #24950 from MegaphoneJon/better-clean-url-wp-rc
Eileen McNaughton [Sun, 13 Nov 2022 23:59:48 +0000 (12:59 +1300)]
Merge pull request #24950 from MegaphoneJon/better-clean-url-wp-rc

Fix WP Clean Pages check when components are disabled

2 years agoAdd html definition to schema for is_active (part 4)
Eileen McNaughton [Sun, 13 Nov 2022 22:57:42 +0000 (11:57 +1300)]
Add html definition to schema for is_active (part 4)

2 years agoAdd html definition to schema for is_active (part 3)
Eileen McNaughton [Sun, 13 Nov 2022 22:53:55 +0000 (11:53 +1300)]
Add html definition to schema for is_active (part 3)

2 years agoAdd html definition to schema for is_active (part 2)
Eileen McNaughton [Sun, 13 Nov 2022 22:14:59 +0000 (11:14 +1300)]
Add html definition to schema for is_active (part 2)

2 years agoAdd html definition to schema for is_active (1)
Eileen McNaughton [Sun, 13 Nov 2022 22:08:47 +0000 (11:08 +1300)]
Add html definition to schema for is_active (1)

2 years agoMerge pull request #24934 from eileenmcnaughton/remove_replace_com
colemanw [Sun, 13 Nov 2022 21:29:07 +0000 (16:29 -0500)]
Merge pull request #24934 from eileenmcnaughton/remove_replace_com

Remove deprecated token function `replaceComponentTokens`

2 years agoMerge pull request #24935 from eileenmcnaughton/test_nfc
colemanw [Sun, 13 Nov 2022 21:26:08 +0000 (16:26 -0500)]
Merge pull request #24935 from eileenmcnaughton/test_nfc

Further cleanup on JobTest

2 years agoMerge pull request #24960 from mlutfy/fixYeOldUpgrade
colemanw [Sun, 13 Nov 2022 20:47:46 +0000 (15:47 -0500)]
Merge pull request #24960 from mlutfy/fixYeOldUpgrade

FourSeven Upgrade: disable i18nrewrite to avoid multilingual fatal

2 years agoAfform - Fix multivalue entityRef fields
Coleman Watts [Sun, 13 Nov 2022 03:22:14 +0000 (22:22 -0500)]
Afform - Fix multivalue entityRef fields

Apparently 'multiple' is a reserved word and wasn't working as an angular param,
switching it to 'multi' fixes the issue.

2 years agoAfform - Fix display of search filter fields in PHP 8.1+
Coleman Watts [Sun, 13 Nov 2022 01:32:02 +0000 (20:32 -0500)]
Afform - Fix display of search filter fields in PHP 8.1+

In PHP 8.1 Afform search fields stopped working. This is due to an encoding change which broke the parser.

According to https://www.php.net/manual/en/function.htmlspecialchars.php#refsect1-function.htmlspecialchars-changelog
PHP 8.1 changed the default mode for `htmlspecialchars`, the impact of which is to escape straight quotes
instead of leaving them alone.

This ensures the function works the same on all PHP versions by explicitly setting the mode.

2 years agoMerge branch '5.56' to master
Coleman Watts [Sat, 12 Nov 2022 22:44:40 +0000 (17:44 -0500)]
Merge branch '5.56' to master

2 years agoMerge pull request #24962 from colemanw/afformAutoservice
colemanw [Sat, 12 Nov 2022 22:41:02 +0000 (17:41 -0500)]
Merge pull request #24962 from colemanw/afformAutoservice

[REF] Afform - Use autoservice for event subscribers

2 years agoMerge pull request #24958 from colemanw/since
demeritcowboy [Sat, 12 Nov 2022 21:19:59 +0000 (16:19 -0500)]
Merge pull request #24958 from colemanw/since

[NFC] Add @since annotation

2 years agoMerge pull request #24961 from colemanw/psr0Path
demeritcowboy [Sat, 12 Nov 2022 21:19:14 +0000 (16:19 -0500)]
Merge pull request #24961 from colemanw/psr0Path

Update psr0 paths to match current convention

2 years agoAfform - Use autoservice for event subscribers
Coleman Watts [Sat, 12 Nov 2022 15:23:57 +0000 (10:23 -0500)]
Afform - Use autoservice for event subscribers

2 years agoUpdate psr0 paths to match current convention
Coleman Watts [Sat, 12 Nov 2022 15:32:12 +0000 (10:32 -0500)]
Update psr0 paths to match current convention

2 years agoMerge pull request #24832 from colemanw/afformEntityRef
colemanw [Sat, 12 Nov 2022 15:10:21 +0000 (10:10 -0500)]
Merge pull request #24832 from colemanw/afformEntityRef

Afform - Customizable APIv4-based Autocomplete widget for EntityRef fields

2 years agoFourSeven Upgrade: disable i18nrewrite to avoid multilingual fatal
Mathieu Lutfy [Sat, 12 Nov 2022 13:31:14 +0000 (08:31 -0500)]
FourSeven Upgrade: disable i18nrewrite to avoid multilingual fatal

2 years agoAdd @since annotation
Coleman Watts [Sat, 12 Nov 2022 02:55:16 +0000 (21:55 -0500)]
Add @since annotation

2 years agoMerge pull request #24132 from demeritcowboy/eventdispatcher3
colemanw [Fri, 11 Nov 2022 22:17:42 +0000 (17:17 -0500)]
Merge pull request #24132 from demeritcowboy/eventdispatcher3

dev/core#2316 - Symfony EventDispatcher dispatch() signature kerfuffle - try 3

2 years agoMerge pull request #24649 from larssandergreen/clarify-allow-multiple-registrations
demeritcowboy [Fri, 11 Nov 2022 21:25:13 +0000 (16:25 -0500)]
Merge pull request #24649 from larssandergreen/clarify-allow-multiple-registrations

Make it clear that same email for event registrations allows multiple registrations per contact

2 years agouse unoptimized dispatcher
demeritcowboy [Fri, 19 Aug 2022 00:18:29 +0000 (20:18 -0400)]
use unoptimized dispatcher

2 years agounit test updates
demeritcowboy [Wed, 3 Aug 2022 20:20:03 +0000 (16:20 -0400)]
unit test updates

2 years agoconvert SchemaMapBuilder
demeritcowboy [Tue, 19 Apr 2022 02:40:55 +0000 (22:40 -0400)]
convert SchemaMapBuilder

2 years agosymfony Event no longer exists - flexmailer
demeritcowboy [Tue, 19 Apr 2022 00:49:30 +0000 (20:49 -0400)]
symfony Event no longer exists - flexmailer

2 years agosymfony Event no longer exists - afform
demeritcowboy [Tue, 19 Apr 2022 00:46:59 +0000 (20:46 -0400)]
symfony Event no longer exists - afform

2 years agosymfony Event no longer exists - Token
demeritcowboy [Tue, 19 Apr 2022 00:45:10 +0000 (20:45 -0400)]
symfony Event no longer exists - Token

2 years agosymfony Event no longer exists - Core
demeritcowboy [Tue, 19 Apr 2022 00:42:40 +0000 (20:42 -0400)]
symfony Event no longer exists - Core

2 years agosymfony Event no longer exists - DAO
demeritcowboy [Tue, 19 Apr 2022 00:40:16 +0000 (20:40 -0400)]
symfony Event no longer exists - DAO

2 years agosymfony Event no longer exists - API4
demeritcowboy [Tue, 19 Apr 2022 00:37:50 +0000 (20:37 -0400)]
symfony Event no longer exists - API4

2 years agosymfony Event no longer exists - API
demeritcowboy [Tue, 19 Apr 2022 00:37:24 +0000 (20:37 -0400)]
symfony Event no longer exists - API

2 years agosymfony Event no longer exists - ActionSchedule
demeritcowboy [Tue, 19 Apr 2022 00:36:51 +0000 (20:36 -0400)]
symfony Event no longer exists - ActionSchedule

2 years agosymfony Event no longer exists - civisetup
demeritcowboy [Tue, 19 Apr 2022 00:30:30 +0000 (20:30 -0400)]
symfony Event no longer exists - civisetup

2 years agosymfony Event no longer exists
demeritcowboy [Tue, 19 Apr 2022 00:29:34 +0000 (20:29 -0400)]
symfony Event no longer exists

2 years agoHandle different signature in symfony 4.3+
demeritcowboy [Mon, 18 Apr 2022 23:15:40 +0000 (19:15 -0400)]
Handle different signature in symfony 4.3+

2 years agoMerge pull request #24957 from bhahumanists/from-select2-standard
colemanw [Fri, 11 Nov 2022 16:57:16 +0000 (11:57 -0500)]
Merge pull request #24957 from bhahumanists/from-select2-standard

Turn 'From' dropdown in 'Send Email' into a searchable select2

2 years agoMerge pull request #24821 from eileenmcnaughton/validate
colemanw [Fri, 11 Nov 2022 13:58:55 +0000 (08:58 -0500)]
Merge pull request #24821 from eileenmcnaughton/validate

Add Validate and Import search kit actions to import search displays

2 years agoTurn 'From' dropdown in 'Send Email' into a searchable select2
Andrew West [Fri, 11 Nov 2022 13:07:46 +0000 (13:07 +0000)]
Turn 'From' dropdown in 'Send Email' into a searchable select2

2 years agoMerge pull request #24954 from civicrm/5.56
Eileen McNaughton [Fri, 11 Nov 2022 03:30:18 +0000 (16:30 +1300)]
Merge pull request #24954 from civicrm/5.56

5.56 to master

2 years agoMerge pull request #24951 from demeritcowboy/socketio-556
Eileen McNaughton [Fri, 11 Nov 2022 03:29:05 +0000 (16:29 +1300)]
Merge pull request #24951 from demeritcowboy/socketio-556

Backport 24940 (socketio-parser)

2 years agoMerge pull request #24952 from eileenmcnaughton/opt_meta
Eileen McNaughton [Fri, 11 Nov 2022 02:42:26 +0000 (15:42 +1300)]
Merge pull request #24952 from eileenmcnaughton/opt_meta

Remove php8-specific coding pattern

2 years agoRemove php8-specific coding pattern
Eileen McNaughton [Fri, 11 Nov 2022 02:41:13 +0000 (15:41 +1300)]
Remove php8-specific coding pattern

2 years agoMerge pull request #24942 from colemanw/searchKitDescription
Eileen McNaughton [Fri, 11 Nov 2022 02:25:19 +0000 (15:25 +1300)]
Merge pull request #24942 from colemanw/searchKitDescription

SearchKit - Expose SavedSearch descriptions to admins

2 years agoMerge pull request #24927 from artfulrobot/artfulrobot-issue-3918-attempt-3
Eileen McNaughton [Fri, 11 Nov 2022 01:49:58 +0000 (14:49 +1300)]
Merge pull request #24927 from artfulrobot/artfulrobot-issue-3918-attempt-3

dev/core#3977 Handle dodgier calls to setBillingCountry in property bag.

2 years agoMerge pull request #24944 from colemanw/upgradeExt
Eileen McNaughton [Fri, 11 Nov 2022 01:47:18 +0000 (14:47 +1300)]
Merge pull request #24944 from colemanw/upgradeExt

Core extensions - Upgrade to civix 22.10.0

2 years agobackport 24940
demeritcowboy [Thu, 10 Nov 2022 22:33:01 +0000 (17:33 -0500)]
backport 24940

2 years agoMerge pull request #24948 from colemanw/basename
demeritcowboy [Thu, 10 Nov 2022 22:18:47 +0000 (17:18 -0500)]
Merge pull request #24948 from colemanw/basename

Simplify removing file extension when using basename function

2 years agoFix WP Clean Pages check when components are disabled
Jon Goldberg [Thu, 10 Nov 2022 19:10:38 +0000 (14:10 -0500)]
Fix WP Clean Pages check when components are disabled

2 years agoSimplify removing file extension when using basename function
Coleman Watts [Thu, 10 Nov 2022 18:13:46 +0000 (13:13 -0500)]
Simplify removing file extension when using basename function

The basename function has a native way of removing file extensions, so the use of str_replace or preg_replace
is usually unnecessary.

2 years agoMerge pull request #24933 from eileenmcnaughton/dep_token_cont
colemanw [Thu, 10 Nov 2022 17:38:54 +0000 (12:38 -0500)]
Merge pull request #24933 from eileenmcnaughton/dep_token_cont

Add noisy deprecation to unused functions `replaceContactTokens`, `replaceCaseTokens`

2 years agoAfform - Server-side validation of autocomplete field values
Coleman Watts [Wed, 9 Nov 2022 21:26:30 +0000 (16:26 -0500)]
Afform - Server-side validation of autocomplete field values

2 years agoAPIv4 - Add event to customize default SavedSearch for autocompletes
Coleman Watts [Tue, 8 Nov 2022 15:36:15 +0000 (10:36 -0500)]
APIv4 - Add event to customize default SavedSearch for autocompletes

Customize Case autocomplete

2 years agoSearchKit - Add descriptions to search display types
Coleman Watts [Sat, 5 Nov 2022 20:37:54 +0000 (16:37 -0400)]
SearchKit - Add descriptions to search display types

2 years agoSearchKit - Add UI for configuring autocomplete fields
Coleman Watts [Sat, 5 Nov 2022 19:53:26 +0000 (15:53 -0400)]
SearchKit - Add UI for configuring autocomplete fields

2 years agoAfform - Configure SavedSearch, display, autoOpen settings for Autocomplete fields
Coleman Watts [Sat, 5 Nov 2022 02:01:33 +0000 (22:01 -0400)]
Afform - Configure SavedSearch, display, autoOpen settings for Autocomplete fields

2 years agoAfform - Configurable permission checks for all Autocompletes
Coleman Watts [Fri, 4 Nov 2022 22:53:04 +0000 (18:53 -0400)]
Afform - Configurable permission checks for all Autocompletes

2 years agoAPIv4 - Convert Autocomplete action to use SearchDisplay::run
Coleman Watts [Thu, 3 Nov 2022 16:57:26 +0000 (12:57 -0400)]
APIv4 - Convert Autocomplete action to use SearchDisplay::run

This allows Autocomplete fields to be customized as Search Displays,
and expands the SearchDisplay::getDefault action to return default settings
that work for most entities.

2 years agoAfform - support filters in custom contactRef & core entityRef fields
Coleman Watts [Tue, 25 Oct 2022 02:11:50 +0000 (22:11 -0400)]
Afform - support filters in custom contactRef & core entityRef fields

Fixes dev/core#3425
Provides a common format for "filters" in both core and custom entityRef fields.
For example, the `employer_id` field now automatically filters `contact_type=Organization`.
Custom fields use the same format for filters (basically URL encoded format),
and APIv4 now reads them both and applies them when the field is included in an Afform.

2 years agoAfform - Use APIv4 autocomplete for all EntityRef fields
Coleman Watts [Mon, 24 Oct 2022 21:51:39 +0000 (17:51 -0400)]
Afform - Use APIv4 autocomplete for all EntityRef fields

2 years agoMerge pull request #24941 from colemanw/addSearchRunTest
colemanw [Thu, 10 Nov 2022 17:24:23 +0000 (12:24 -0500)]
Merge pull request #24941 from colemanw/addSearchRunTest

SearchKit - Add unit test for multivalued custom fields

2 years agoMerge pull request #24946 from eileenmcnaughton/dao
colemanw [Thu, 10 Nov 2022 16:45:53 +0000 (11:45 -0500)]
Merge pull request #24946 from eileenmcnaughton/dao

Regenerate Country DAO

2 years agoCore extensions - Upgrade to civix 22.10.0
Coleman Watts [Thu, 10 Nov 2022 02:57:37 +0000 (21:57 -0500)]
Core extensions - Upgrade to civix 22.10.0

2 years agoMerge pull request #24945 from eileenmcnaughton/ex_zero
colemanw [Thu, 10 Nov 2022 14:45:45 +0000 (09:45 -0500)]
Merge pull request #24945 from eileenmcnaughton/ex_zero

dev/core#3981 Fix Examples to use 0 rather than a possibly-real contact_id

2 years agoRegenerate Country DAO
Eileen McNaughton [Thu, 10 Nov 2022 08:44:23 +0000 (21:44 +1300)]
Regenerate Country DAO

2 years agoTest updates for example change
Eileen McNaughton [Thu, 10 Nov 2022 08:43:51 +0000 (21:43 +1300)]
Test updates for example change

2 years agodev/core#3981 Fix Examples to use 0 rather than a possibly-real contact_id
Eileen McNaughton [Thu, 10 Nov 2022 07:02:19 +0000 (20:02 +1300)]
dev/core#3981 Fix Examples to use 0 rather than a possibly-real contact_id

Overview
==================================================
dev/core#3981 Fix Examples to use 0 rather than a possibly-real contact_id

https://lab.civicrm.org/dev/core/-/issues/3981

Before
==============================================
When using the Message Admin UI and trying out tokens those that are not
explicitly defined in the sample data are fetched from the database from
the contact whose id has been arbitrarily used.

After
=======================================================================
The contact_id is set to 0. As a result nothing is retrievable from the databse.

Technical Details
=======================================================================
I suspect this was not possible when the example was first written (the
token code has matured a bit) & a stand in number seemed intuitive - but
I think that is arguable even when there are no negative side
effects (for example if a url were in the letter then linking to
a random contact from it is kinda confusing) - but really loses it's potency
as an argument when there ARE negative side effects

Comments
============================================================================
I'm pretty sure there are some tests I need to adjust for this....

2 years agoMerge pull request #24898 from larssandergreen/don't-allow-selecting-deleted-contacts...
Yashodha Chaku [Thu, 10 Nov 2022 05:42:26 +0000 (11:12 +0530)]
Merge pull request #24898 from larssandergreen/don't-allow-selecting-deleted-contacts-to-email

Don't allow selection of deleted contacts as email recipients

2 years agoMerge pull request #24932 from eileenmcnaughton/remove_unused
Yashodha Chaku [Thu, 10 Nov 2022 05:39:32 +0000 (11:09 +0530)]
Merge pull request #24932 from eileenmcnaughton/remove_unused

Remove unused private function `removeNullContactTokens`

2 years agoAfform - Upgrade ext to civix 22.10.0
Coleman Watts [Thu, 10 Nov 2022 02:49:57 +0000 (21:49 -0500)]
Afform - Upgrade ext to civix 22.10.0

2 years agoMerge pull request #24938 from eileenmcnaughton/opt_val
colemanw [Thu, 10 Nov 2022 02:31:22 +0000 (21:31 -0500)]
Merge pull request #24938 from eileenmcnaughton/opt_val

Fix api handling of OptionValue defaults

2 years agoSearchKit - Expose SavedSearch descriptions to admins
Coleman Watts [Thu, 10 Nov 2022 00:21:50 +0000 (19:21 -0500)]
SearchKit - Expose SavedSearch descriptions to admins

2 years agoSearchKit - Add test for multivalued custom fields
Coleman Watts [Wed, 9 Nov 2022 23:32:55 +0000 (18:32 -0500)]
SearchKit - Add test for multivalued custom fields

2 years agoFix api handling of OptionValue defaults
Eileen McNaughton [Tue, 8 Nov 2022 23:41:34 +0000 (12:41 +1300)]
Fix api handling of OptionValue defaults

Overview
----------------------------------------
Fix api handling of OptionValue defaults

Before
----------------------------------------
Some option values (greetings, from_email_address) have
more than one default. For from_email_address it is per domain
and for the others it is per 'filter' (aka contact_type).

The special handling for greetings relies on the form layer - updating
a greeting for 'Individual' and passing 'is_default' will
unset 'is_default' for Household greetings.

For from_email_address the form layer magic-param is set but ultimately
has no bearing as there is duplicate handling in the bao layer

After
----------------------------------------
The default handling is done in the BAO layer & removed from the
form layer

Technical Details
----------------------------------------
I moved the handling to after-update because values are more guarantee there. I
did this by excluding the id from the update query (also prevents flappy updates).
I didn't move all the way to the post hook because I wasn't sure about the interaction
with cache flushing etc (that already happen after save in create) but that could be considered.

2 years agoMerge pull request #24939 from eileenmcnaughton/examples
Eileen McNaughton [Wed, 9 Nov 2022 23:04:00 +0000 (12:04 +1300)]
Merge pull request #24939 from eileenmcnaughton/examples

Add new Organization Example contact (The Daily Bugle)

2 years agoMerge pull request #24919 from eileenmcnaughton/import_county
colemanw [Wed, 9 Nov 2022 22:00:17 +0000 (17:00 -0500)]
Merge pull request #24919 from eileenmcnaughton/import_county

Add tests for importing county (includes adding v4 County api)

2 years agoAdd new Organization Example contact (The Daily Bugle)
Eileen McNaughton [Wed, 9 Nov 2022 21:22:34 +0000 (10:22 +1300)]
Add new Organization Example contact (The Daily Bugle)

2 years agoMerge pull request #24931 from mlutfy/replaceState
colemanw [Wed, 9 Nov 2022 13:49:50 +0000 (08:49 -0500)]
Merge pull request #24931 from mlutfy/replaceState

TabHeader: remove redundant history.replaceState

2 years agoPropertyBag::setBillingCountry - Change from log warning to deprecation messsage
Rich Lott / Artful Robot [Wed, 9 Nov 2022 09:19:51 +0000 (09:19 +0000)]
PropertyBag::setBillingCountry - Change from log warning to deprecation messsage

2 years agoFurther cleanup on JobTest
Eileen McNaughton [Tue, 8 Nov 2022 22:24:30 +0000 (11:24 +1300)]
Further cleanup on JobTest

2 years agoMerge pull request #24930 from alifrumin/backdrop76
Eileen McNaughton [Tue, 8 Nov 2022 21:51:31 +0000 (10:51 +1300)]
Merge pull request #24930 from alifrumin/backdrop76

[dev/backdrop#76] The control buttons in crm pop ups are all X's