civicrm-core.git
3 years agoMerge pull request #20534 from demeritcowboy/dupedao
Eileen McNaughton [Mon, 7 Jun 2021 19:37:41 +0000 (07:37 +1200)]
Merge pull request #20534 from demeritcowboy/dupedao

Dedupe DAO is out of date

3 years agoMerge pull request #20525 from seamuslee001/fix_date_tests
demeritcowboy [Mon, 7 Jun 2021 15:21:54 +0000 (11:21 -0400)]
Merge pull request #20525 from seamuslee001/fix_date_tests

[php8-compat][REF] Fix Date unit tests in php8 by passing in 00 inste…

3 years agofix hash
demeritcowboy [Mon, 7 Jun 2021 14:55:54 +0000 (10:55 -0400)]
fix hash

3 years agoMerge pull request #20528 from colemanw/exportFix2
Seamus Lee [Mon, 7 Jun 2021 06:49:53 +0000 (16:49 +1000)]
Merge pull request #20528 from colemanw/exportFix2

dev/report#67 Fix standalone export classes

3 years agoMerge pull request #20526 from seamuslee001/required_after_optional_more2
Seamus Lee [Mon, 7 Jun 2021 06:34:08 +0000 (16:34 +1000)]
Merge pull request #20526 from seamuslee001/required_after_optional_more2

[php8-compact][REF] Fix another couple of places where by there are r…

3 years agoMerge pull request #20527 from seamuslee001/payment_token_fix
Seamus Lee [Mon, 7 Jun 2021 06:33:59 +0000 (16:33 +1000)]
Merge pull request #20527 from seamuslee001/payment_token_fix

[php8-compact][REF] Fix api_v3_PaymentTokenTest to work on php8

3 years agoMerge pull request #20524 from seamuslee001/fix_case_custom_tests
Seamus Lee [Mon, 7 Jun 2021 06:33:15 +0000 (16:33 +1000)]
Merge pull request #20524 from seamuslee001/fix_case_custom_tests

[php8-compat][REF] Fix Case and Custom data tests by adding guards in…

3 years agoFix standalone export classes
Coleman Watts [Mon, 7 Jun 2021 05:06:31 +0000 (01:06 -0400)]
Fix standalone export classes

This fixes an 'access denied' error on standalone export forms,
caused by renaming the php classes.

Fixes dev/report#67

3 years ago[php8-compact][REF] Fix api_v3_PaymentTokenTest to work on php8
Seamus Lee [Mon, 7 Jun 2021 04:48:49 +0000 (04:48 +0000)]
[php8-compact][REF] Fix api_v3_PaymentTokenTest to work on php8

3 years ago[php8-compact][REF] Fix another couple of places where by there are required variable...
Seamus Lee [Mon, 7 Jun 2021 04:42:55 +0000 (04:42 +0000)]
[php8-compact][REF] Fix another couple of places where by there are required variables in php function declaration after optional ones

3 years ago[php8-compat][REF] Fix Date unit tests in php8 by passing in 00 instead of null for...
Seamus Lee [Mon, 7 Jun 2021 04:38:51 +0000 (04:38 +0000)]
[php8-compat][REF] Fix Date unit tests in php8 by passing in 00 instead of null for hours,minutes and seconds

3 years ago[php8-compat][REF] Fix Case and Custom data tests by adding guards into templates
Seamus Lee [Mon, 7 Jun 2021 04:35:52 +0000 (04:35 +0000)]
[php8-compat][REF] Fix Case and Custom data tests by adding guards into templates

3 years agoMerge pull request #20357 from eileenmcnaughton/tax_add
Monish Deb [Mon, 7 Jun 2021 04:34:28 +0000 (10:04 +0530)]
Merge pull request #20357 from eileenmcnaughton/tax_add

Fix for tax rates being mangled on contribution update

3 years agoMerge pull request #20495 from eileenmcnaughton/lines
Seamus Lee [Mon, 7 Jun 2021 04:34:01 +0000 (14:34 +1000)]
Merge pull request #20495 from eileenmcnaughton/lines

Use line items to look up memberships

3 years agoMerge pull request #20521 from eileenmcnaughton/validate
Seamus Lee [Mon, 7 Jun 2021 04:32:52 +0000 (14:32 +1000)]
Merge pull request #20521 from eileenmcnaughton/validate

Test fix up for AdditionalPaymentTest

3 years agoFix the ContributionPageTest to set up valid memberships
Eileen McNaughton [Mon, 7 Jun 2021 02:20:50 +0000 (14:20 +1200)]
Fix the ContributionPageTest to set up valid memberships

Fix for https://github.com/civicrm/civicrm-core/pull/20495
- resolve invalid test config

3 years agoUse line items to look up memberships
Eileen McNaughton [Thu, 3 Jun 2021 21:30:24 +0000 (09:30 +1200)]
Use line items to look up memberships

This still checks the membership payment but creates some noise if there are validity issues

3 years agoTest fix up for AdditionalPaymentTest
Eileen McNaughton [Mon, 7 Jun 2021 02:04:10 +0000 (14:04 +1200)]
Test fix up for AdditionalPaymentTest

This addresses a poor set up issue where the membership + contribution was being
set up incorrectly &  hence the line items were wrong, along with the ability
to validate the financials. It was blocking https://github.com/civicrm/civicrm-core/pull/20495
along with the efforts to get financial validation on all tests

3 years agoMerge pull request #20507 from colemanw/apiSmartGroups
Eileen McNaughton [Mon, 7 Jun 2021 01:18:19 +0000 (13:18 +1200)]
Merge pull request #20507 from colemanw/apiSmartGroups

SearchKit - Add API filter for contacts in groups and smart groups

3 years agoMerge pull request #20520 from seamuslee001/php8_more_template_guard
Seamus Lee [Mon, 7 Jun 2021 00:38:36 +0000 (10:38 +1000)]
Merge pull request #20520 from seamuslee001/php8_more_template_guard

[php8-compat] Fix api_v3_PaymentTest failures by putting in more guar…

3 years agoMerge pull request #20499 from JMAConsulting/add_permission_fi_api4
Tim Otten [Sun, 6 Jun 2021 23:59:48 +0000 (16:59 -0700)]
Merge pull request #20499 from JMAConsulting/add_permission_fi_api4

dev/core#2486 - Use read-only permissions for FinancialItem API

3 years agoMerge pull request #20513 from demeritcowboy/regen-better
Tim Otten [Sun, 6 Jun 2021 23:50:06 +0000 (16:50 -0700)]
Merge pull request #20513 from demeritcowboy/regen-better

dev/core#1549 - Malleate civicrm_generated so that long lines are split

3 years ago[php8-compat] Fix api_v3_PaymentTest failures by putting in more guards into message...
Seamus Lee [Sun, 6 Jun 2021 22:53:56 +0000 (22:53 +0000)]
[php8-compat] Fix api_v3_PaymentTest failures by putting in more guards into message templates

3 years agoMerge pull request #20516 from seamuslee001/php8_more_test_fixes
Eileen McNaughton [Sun, 6 Jun 2021 21:58:39 +0000 (09:58 +1200)]
Merge pull request #20516 from seamuslee001/php8_more_test_fixes

[php8-compat][REF] Fix some more test failures in php8

3 years agoMerge pull request #20518 from seamuslee001/php8_contribution_page
Eileen McNaughton [Sun, 6 Jun 2021 21:45:52 +0000 (09:45 +1200)]
Merge pull request #20518 from seamuslee001/php8_contribution_page

[php8-compat][REF] Fix api_v3_contributionpagetest on php8

3 years agoAPIv4 - Include child groups in contact group filter
Coleman Watts [Sun, 6 Jun 2021 20:32:11 +0000 (16:32 -0400)]
APIv4 - Include child groups in contact group filter

3 years agoSearchKit - Add API filter for contacts in groups and smart groups
Coleman Watts [Fri, 4 Jun 2021 20:46:05 +0000 (16:46 -0400)]
SearchKit - Add API filter for contacts in groups and smart groups

Adds 'type' property to API getFields to distinguish regular fields
from custom fields, extra fields and filters.

Implements `Contact.groups` as a filter, which internally adds a temp-table
and incorporates it into the query.

3 years ago[php8-compat][REF] Fix api_v3_contributionpagetest on php8
Seamus Lee [Sun, 6 Jun 2021 07:54:13 +0000 (07:54 +0000)]
[php8-compat][REF] Fix api_v3_contributionpagetest on php8

3 years agoMerge pull request #20517 from seamuslee001/php8_more_template_test_fixes
Eileen McNaughton [Sun, 6 Jun 2021 05:57:34 +0000 (17:57 +1200)]
Merge pull request #20517 from seamuslee001/php8_more_template_test_fixes

[php8-compat][REF] Fix more php8 test failures caused by template issues

3 years ago[php8-compat][REF] Fix more php8 test failures caused by template issues
Seamus Lee [Sun, 6 Jun 2021 02:19:23 +0000 (02:19 +0000)]
[php8-compat][REF] Fix more php8 test failures caused by template issues

3 years ago[php8-compat][REF] Fix some more test failures in php8
Seamus Lee [Sun, 6 Jun 2021 02:06:45 +0000 (02:06 +0000)]
[php8-compat][REF] Fix some more test failures in php8

3 years agoMerge pull request #20512 from seamuslee001/php8_contribution_api_tests
Seamus Lee [Sun, 6 Jun 2021 00:59:37 +0000 (10:59 +1000)]
Merge pull request #20512 from seamuslee001/php8_contribution_api_tests

[php8-compat] Update smarty templates and some php files to get the a…

3 years agoMerge pull request #20515 from seamuslee001/php8_required_optional
Seamus Lee [Sun, 6 Jun 2021 00:56:54 +0000 (10:56 +1000)]
Merge pull request #20515 from seamuslee001/php8_required_optional

[php8-compat] Fix some more examples of where required parameters are…

3 years ago[php8-compat] Update smarty templates and some php files to get the api_v3_contributi...
Seamus Lee [Sat, 5 Jun 2021 03:22:24 +0000 (03:22 +0000)]
[php8-compat] Update smarty templates and some php files to get the api_v3_contribution testclass to pass on php8

3 years ago[php8-compat] Fix some more examples of where required parameters are after optional...
Seamus Lee [Sat, 5 Jun 2021 23:13:40 +0000 (23:13 +0000)]
[php8-compat] Fix some more examples of where required parameters are after optional parameters in fucntion declaration

3 years agosplit long lines in civicrm_generated
demeritcowboy [Sat, 5 Jun 2021 03:31:04 +0000 (23:31 -0400)]
split long lines in civicrm_generated

3 years agoMerge pull request #20331 from mattwire/suppresslegacywarnings
Eileen McNaughton [Sat, 5 Jun 2021 01:36:21 +0000 (13:36 +1200)]
Merge pull request #20331 from mattwire/suppresslegacywarnings

Allow legacy warnings to be fully suppressed in PropertyBag

3 years agoMerge pull request #20509 from seamuslee001/fix_beautifier_notice
Seamus Lee [Sat, 5 Jun 2021 00:27:05 +0000 (10:27 +1000)]
Merge pull request #20509 from seamuslee001/fix_beautifier_notice

[php8-compat] Fix php beautifier notice by conditionally assinging dy…

3 years agoMerge pull request #20508 from seamuslee001/product_oddness
Seamus Lee [Sat, 5 Jun 2021 00:24:00 +0000 (10:24 +1000)]
Merge pull request #20508 from seamuslee001/product_oddness

[php8-compat] Fix issue in APIv3 Where by because product has a colum…

3 years agoMerge pull request #20502 from seamuslee001/spaceship
Seamus Lee [Sat, 5 Jun 2021 00:12:11 +0000 (10:12 +1000)]
Merge pull request #20502 from seamuslee001/spaceship

[php8-compat] Fix issue with returning bool from uasort by using the …

3 years agoMerge pull request #20500 from seamuslee001/php8_zip_test
Eileen McNaughton [Sat, 5 Jun 2021 00:11:49 +0000 (12:11 +1200)]
Merge pull request #20500 from seamuslee001/php8_zip_test

[php8-compat][NFC] Fix using ZipArchive::open on an empty file

3 years agoMerge pull request #20504 from JMAConsulting/add_aclrole_api4_entity
Eileen McNaughton [Sat, 5 Jun 2021 00:09:41 +0000 (12:09 +1200)]
Merge pull request #20504 from JMAConsulting/add_aclrole_api4_entity

ACLEntityRole BAO tidy fixes

3 years agoMerge pull request #20503 from seamuslee001/upgrade_fixes
Seamus Lee [Fri, 4 Jun 2021 23:50:58 +0000 (09:50 +1000)]
Merge pull request #20503 from seamuslee001/upgrade_fixes

[php8-compat] fix Upgrade call back issues by making functions static…

3 years ago[php8-compat] Fix issue with returning bool from uasort by using the spaceship operator
Seamus Lee [Fri, 4 Jun 2021 07:20:13 +0000 (17:20 +1000)]
[php8-compat] Fix issue with returning bool from uasort by using the spaceship operator

3 years agoMerge pull request #20498 from seamuslee001/fix_authx_drupal89
demeritcowboy [Fri, 4 Jun 2021 22:48:01 +0000 (18:48 -0400)]
Merge pull request #20498 from seamuslee001/fix_authx_drupal89

[REF] Fix Authx tests on Druapl 8/9 by ensuring that we only return a…

3 years ago[php8-compat] Fix php beautifier notice by conditionally assinging dynamic foreign...
Seamus Lee [Fri, 4 Jun 2021 22:41:45 +0000 (22:41 +0000)]
[php8-compat] Fix php beautifier notice by conditionally assinging dynamic foreign key to the template

3 years ago[php8-compat] Fix issue in APIv3 Where by because product has a column called options...
Seamus Lee [Fri, 4 Jun 2021 22:38:55 +0000 (22:38 +0000)]
[php8-compat] Fix issue in APIv3 Where by because product has a column called options the testCreateSingleValueAlter triggers a cannot access offset of type string on string in php8

3 years ago[php8-compat] fix Upgrade call back issues by making functions static and also fixing...
Seamus Lee [Fri, 4 Jun 2021 07:23:34 +0000 (07:23 +0000)]
[php8-compat] fix Upgrade call back issues by making functions static and also fixing an issue with an array key not existing when checking obsolete extensions

3 years agoMerge pull request #20506 from colemanw/deleteActivityPreCreationSubscriber
Seamus Lee [Fri, 4 Jun 2021 21:54:49 +0000 (07:54 +1000)]
Merge pull request #20506 from colemanw/deleteActivityPreCreationSubscriber

APIv4 - Delete undocumented deprecated activityType lookup

3 years agoMerge pull request #20501 from JMAConsulting/api4_batch_spec
Seamus Lee [Fri, 4 Jun 2021 21:42:33 +0000 (07:42 +1000)]
Merge pull request #20501 from JMAConsulting/api4_batch_spec

Add APIv4 Batch.create spec

3 years agoACLEntityRole tidy fixes
Monish Deb [Fri, 4 Jun 2021 07:48:52 +0000 (13:18 +0530)]
ACLEntityRole tidy fixes

3 years agoAdd APIv4 Batch.create spec
Monish Deb [Fri, 4 Jun 2021 07:12:08 +0000 (12:42 +0530)]
Add APIv4 Batch.create spec

3 years agoAPIv4 - Delete undocumented deprecated pseudoconstant lookup for Activity type
Coleman Watts [Fri, 4 Jun 2021 13:06:09 +0000 (09:06 -0400)]
APIv4 - Delete undocumented deprecated pseudoconstant lookup for Activity type

3 years ago[php8-compat][NFC] Fix using ZipArchive::open on an empty file
Seamus Lee [Fri, 4 Jun 2021 07:14:38 +0000 (17:14 +1000)]
[php8-compat][NFC] Fix using ZipArchive::open on an empty file

3 years agoAdd permissions for financial_item entity
Monish Deb [Fri, 4 Jun 2021 06:35:28 +0000 (12:05 +0530)]
Add permissions for financial_item entity

3 years agoMerge pull request #20496 from seamuslee001/php8_array_key_actionscheduletest
Seamus Lee [Fri, 4 Jun 2021 06:43:54 +0000 (16:43 +1000)]
Merge pull request #20496 from seamuslee001/php8_array_key_actionscheduletest

[php8-compat][NFC] Fix issue where by we are tryiing to access array keys …

3 years ago[php8-compat] Fix issue where by we are tryiing to access array keys that haven't...
Seamus Lee [Fri, 4 Jun 2021 00:36:49 +0000 (00:36 +0000)]
[php8-compat] Fix issue where by we are tryiing to access array keys that haven't been created yet

Add in code comment

3 years agoMerge pull request #20497 from seamuslee001/more_required_after_optional
Eileen McNaughton [Fri, 4 Jun 2021 03:24:49 +0000 (15:24 +1200)]
Merge pull request #20497 from seamuslee001/more_required_after_optional

[REF][php8-compat] Fix more instances of where there is a required pa…

3 years agoMerge pull request #20488 from eileenmcnaughton/cust_strict
Tim Otten [Fri, 4 Jun 2021 02:27:20 +0000 (19:27 -0700)]
Merge pull request #20488 from eileenmcnaughton/cust_strict

Clarify types on `hook_custom` and `hook_customPre`

3 years ago[REF] Fix Authx tests on Druapl 8/9 by ensuring that we only return an id for the...
Seamus Lee [Fri, 4 Jun 2021 01:03:21 +0000 (11:03 +1000)]
[REF] Fix Authx tests on Druapl 8/9 by ensuring that we only return an id for the user id if it is greater than 0

3 years ago[REF][php8-compat] Fix more instances of where there is a required parameter for...
Seamus Lee [Fri, 4 Jun 2021 00:42:47 +0000 (00:42 +0000)]
[REF][php8-compat] Fix more instances of where there is a required parameter for a function after an optional one and fix an issue where by a NULL function property is treated as not exisiting in php8

3 years agoMerge pull request #20479 from demeritcowboy/userload
Seamus Lee [Fri, 4 Jun 2021 00:38:13 +0000 (10:38 +1000)]
Merge pull request #20479 from demeritcowboy/userload

dev/core#2636 - Authx - Undefined function in drupal 9

3 years agoMerge pull request #20375 from JMAConsulting/core-65
colemanw [Thu, 3 Jun 2021 23:47:14 +0000 (19:47 -0400)]
Merge pull request #20375 from JMAConsulting/core-65

Prevent adding duplicate dashlet if present with same name and label

3 years agoMerge pull request #20470 from colemanw/entityGet
Seamus Lee [Thu, 3 Jun 2021 21:48:36 +0000 (07:48 +1000)]
Merge pull request #20470 from colemanw/entityGet

APIv4 Entity.get refactor to be more efficient

3 years agoMerge pull request #20492 from colemanw/dedupeRename
Eileen McNaughton [Thu, 3 Jun 2021 21:46:07 +0000 (09:46 +1200)]
Merge pull request #20492 from colemanw/dedupeRename

Cleanup references to old dedupe class names

3 years agoFix for tax rates being mangled on contribution update
Eileen McNaughton [Thu, 20 May 2021 03:12:42 +0000 (15:12 +1200)]
Fix for tax rates being mangled on contribution update

Update sample code

Handle tax_amount as empty string

m

3 years agoMerge pull request #20474 from JMAConsulting/add_aclrole_api4_entity
colemanw [Thu, 3 Jun 2021 16:32:03 +0000 (12:32 -0400)]
Merge pull request #20474 from JMAConsulting/add_aclrole_api4_entity

dev/core#2486 Add ACLEntityRole APIv4 Entity

3 years agoAdd AclRole Api4 Entity
Monish Deb [Wed, 2 Jun 2021 05:40:36 +0000 (11:10 +0530)]
Add AclRole Api4 Entity

3 years agoCleanup references to old dedupe class names
Coleman Watts [Thu, 3 Jun 2021 13:41:57 +0000 (09:41 -0400)]
Cleanup references to old dedupe class names

3 years agoMerge pull request #20466 from JMAConsulting/add_deduperule_api4
colemanw [Thu, 3 Jun 2021 12:28:48 +0000 (08:28 -0400)]
Merge pull request #20466 from JMAConsulting/add_deduperule_api4

Add DedupeRule, DedupeRuleGroup and DedupeException API4 entity

3 years agoMerge pull request #20491 from seamuslee001/array_cache_undefined
Seamus Lee [Thu, 3 Jun 2021 09:19:22 +0000 (19:19 +1000)]
Merge pull request #20491 from seamuslee001/array_cache_undefined

[php8-compat] Fix undefined property on Array Cache class in wordpres…

3 years ago[php8-compat] Fix undefined property on Array Cache class in wordpress on PHP8
Seamus Lee [Thu, 3 Jun 2021 07:21:44 +0000 (07:21 +0000)]
[php8-compat] Fix undefined property on Array Cache class in wordpress on PHP8

3 years agotest failure fix and add API4 files
Monish Deb [Thu, 3 Jun 2021 06:17:52 +0000 (11:47 +0530)]
test failure fix and add API4 files

3 years agoMerge pull request #20490 from seamuslee001/required_after_optional_fix
Seamus Lee [Thu, 3 Jun 2021 05:56:26 +0000 (15:56 +1000)]
Merge pull request #20490 from seamuslee001/required_after_optional_fix

[REF][php8-compat] Further fixes where there is a required paramater …

3 years agoMerge pull request #20478 from totten/master-translation-table-only
Eileen McNaughton [Thu, 3 Jun 2021 05:00:24 +0000 (17:00 +1200)]
Merge pull request #20478 from totten/master-translation-table-only

dev/translation#67 - Define "Translation" table. Add during installation/upgrade.

3 years agoMerge pull request #20489 from colemanw/getFieldsFix
Eileen McNaughton [Thu, 3 Jun 2021 04:56:38 +0000 (16:56 +1200)]
Merge pull request #20489 from colemanw/getFieldsFix

APIv4 - Cleanup getFields, add @internal flag for non-public field attributes

3 years ago[REF][php8-compat] Further fixes where there is a required paramater after an optiona...
Seamus Lee [Thu, 3 Jun 2021 04:11:02 +0000 (14:11 +1000)]
[REF][php8-compat] Further fixes where there is a required paramater after an optional paramater

3 years agoMerge pull request #20487 from eileenmcnaughton/cust_value
demeritcowboy [Thu, 3 Jun 2021 02:50:46 +0000 (22:50 -0400)]
Merge pull request #20487 from eileenmcnaughton/cust_value

Remove some unused variables

3 years agoAPIv4 - Cleanup getFields, add @internal flag for non-public field attributes
Coleman Watts [Thu, 3 Jun 2021 01:31:54 +0000 (21:31 -0400)]
APIv4 - Cleanup getFields, add @internal flag for non-public field attributes

3 years agoMerge pull request #20485 from seamuslee001/fix_not_always_defined_constant
Eileen McNaughton [Thu, 3 Jun 2021 01:43:26 +0000 (13:43 +1200)]
Merge pull request #20485 from seamuslee001/fix_not_always_defined_constant

[php8-compat][REF] Fix php8 error on undefined constant CIVICRM_DISAB…

3 years agoClarify types on custom hooks
Eileen McNaughton [Thu, 3 Jun 2021 00:56:16 +0000 (12:56 +1200)]
Clarify types on custom hooks

The custom & customPre hooks are not called elsewhere in gituniverse
so we can add type hints and fix casting & comments to make it
clearer what the variables are

3 years ago(NFC) CRM_Utils_Hook::translateFields - Tidy up comments
Tim Otten [Thu, 3 Jun 2021 00:51:05 +0000 (17:51 -0700)]
(NFC) CRM_Utils_Hook::translateFields - Tidy up comments

The previous comments reflected a developmental iteration.

3 years agoRemove some unused variables
Eileen McNaughton [Thu, 3 Jun 2021 00:35:36 +0000 (12:35 +1200)]
Remove some unused variables

3 years agoMerge pull request #20486 from civicrm/5.38
Seamus Lee [Wed, 2 Jun 2021 23:50:20 +0000 (09:50 +1000)]
Merge pull request #20486 from civicrm/5.38

5.38

3 years ago[php8-compat][REF] Fix php8 error on undefined constant CIVICRM_DISABLE_DEFAULT_MENU
Seamus Lee [Wed, 2 Jun 2021 23:37:03 +0000 (09:37 +1000)]
[php8-compat][REF] Fix php8 error on undefined constant CIVICRM_DISABLE_DEFAULT_MENU

3 years agoMerge pull request #20483 from seamuslee001/hash_equals_string
Seamus Lee [Wed, 2 Jun 2021 23:30:06 +0000 (09:30 +1000)]
Merge pull request #20483 from seamuslee001/hash_equals_string

[php8-compat][NFC] Ensure that the 2nd parameter of hash_equals is a …

3 years agoMerge pull request #20484 from agh1/5.38.0-releasenotes-final
colemanw [Wed, 2 Jun 2021 23:25:29 +0000 (19:25 -0400)]
Merge pull request #20484 from agh1/5.38.0-releasenotes-final

5.38.0 release notes: added late changes

3 years agoMerge pull request #20480 from colemanw/afformCustomFields
Eileen McNaughton [Wed, 2 Jun 2021 23:07:12 +0000 (11:07 +1200)]
Merge pull request #20480 from colemanw/afformCustomFields

Afform - Fix custom field handling and add tests

3 years ago5.38.0 release notes: added late changes
Andrew Hunt [Wed, 2 Jun 2021 22:46:41 +0000 (18:46 -0400)]
5.38.0 release notes: added late changes

3 years agoMerge pull request #20458 from eileenmcnaughton/group2
colemanw [Wed, 2 Jun 2021 22:17:08 +0000 (18:17 -0400)]
Merge pull request #20458 from eileenmcnaughton/group2

Extract code that populates temp table for an individual group

3 years ago[php8-compat][NFC] Ensure that the 2nd parameter of hash_equals is a string in authx
Seamus Lee [Wed, 2 Jun 2021 21:48:57 +0000 (07:48 +1000)]
[php8-compat][NFC] Ensure that the 2nd parameter of hash_equals is a string in authx

3 years agoMerge pull request #20481 from colemanw/getFieldsFix
Eileen McNaughton [Wed, 2 Jun 2021 20:59:52 +0000 (08:59 +1200)]
Merge pull request #20481 from colemanw/getFieldsFix

APIv4 - Fix getFields to respect default_value from getFields

3 years agodev/translation#67 - Add titles to XML+DAO
Tim Otten [Wed, 2 Jun 2021 20:27:16 +0000 (13:27 -0700)]
dev/translation#67 - Add titles to XML+DAO

3 years agoAPIv4 - Fix getFields to respect default_value from getFields
Coleman Watts [Wed, 2 Jun 2021 19:09:10 +0000 (15:09 -0400)]
APIv4 - Fix getFields to respect default_value from getFields

GetFields had an odd way of setting defaults for field metadata;
this reuses the default_value property instead for more internal consistency.

3 years agoAfform - Fix custom field handling and add tests
Coleman Watts [Wed, 2 Jun 2021 15:15:02 +0000 (11:15 -0400)]
Afform - Fix custom field handling and add tests

This ensures custom fields are handled properly by Afform,
including multi-record custom field groups & their autogenerated blocks,
and contact reference fields.

3 years agoMerge pull request #20475 from eileenmcnaughton/trigg
Monish Deb [Wed, 2 Jun 2021 14:47:16 +0000 (20:17 +0530)]
Merge pull request #20475 from eileenmcnaughton/trigg

Remove pass-by-ref as param not altered

3 years agoAPIv4 - Refactor Entity.get and deprecate the includeCustom param
Coleman Watts [Wed, 2 Jun 2021 00:23:16 +0000 (20:23 -0400)]
APIv4 - Refactor Entity.get and deprecate the includeCustom param

This makes Entity.get more efficient - it no longer does a file scan when getting one or more entities by name.
Also deprecates the includeCustom param which was redundant with the where clause.
This is the first APIv4 param to be deprecated - added handling to emit a warning when using a deprecated param
and hide deprecated params in the APIv4 explorer.

3 years agodeprecated function
demeritcowboy [Wed, 2 Jun 2021 12:06:19 +0000 (08:06 -0400)]
deprecated function

3 years agoMerge pull request #20477 from seamuslee001/core_ext_phpunit8
Seamus Lee [Wed, 2 Jun 2021 11:08:22 +0000 (21:08 +1000)]
Merge pull request #20477 from seamuslee001/core_ext_phpunit8

[php8-compat][phpunit8][NFC] Fix PHPUnit Warnings and fix a php error on f…

3 years agodev/translation#67 - Define "Translation" entity. Add during installation/upgrade.
Tim Otten [Wed, 28 Apr 2021 06:03:27 +0000 (23:03 -0700)]
dev/translation#67 - Define "Translation" entity. Add during installation/upgrade.

This creates an entity, `Translation` (`civicrm_translation`), to represent a single translated database value. Loosely speaking,
any field in the database can be designated as translatable -- and then it will be permitted to store values like:

```sql
INSERT INTO civicrm_translation (entity_table, entity_id, entity_field, language, string)
VALUES ('civicrm_event', 100, 'title', 'fr_FR', 'La nouvelle chaine')
```

This is based on a `civi-data-translate` strings table, but with some changes:

* Entity names are usually singular, but `String` is conflicted. I previously used hybrid
  String/Strings (depending on context), but we negotiated `Translation` on tcon.
* The language only needs 5 characters (NN_nn).
* Consolidated `bool is_active` and `bool is_default` into one `int status_id`.
* Added indexing
* Mark dynamic foreign key

This commit includes the BAO with some of the backing-methods required for
API exposure.  However, the API won't really work until we have the
validation-values event, so the API has been kicked to a subsequent PR.

The list of translatable entities/fields will be signficant because it will
determine when/how to redirect data in API calls.  This patch does not
commit to specific translatable fields - but it does provide a hook to
determine them.

When the API PR becomes unblocked, it will include test-coverage that hits the API, BAO, and hook.