Eileen McNaughton [Mon, 17 Feb 2020 21:13:27 +0000 (10:13 +1300)]
Merge pull request #16571 from wmortada/over-ride
(NFC) Fix typo - no hyphen in 'override'
Eileen McNaughton [Mon, 17 Feb 2020 20:58:10 +0000 (09:58 +1300)]
Merge pull request #16095 from seamuslee001/dev_core_1450
dev/core#1450 Try reducing the size of the temporary table so it only…
Eileen McNaughton [Mon, 17 Feb 2020 20:52:44 +0000 (09:52 +1300)]
Merge pull request #16574 from civicrm/5.23
5.23
Seamus Lee [Mon, 17 Feb 2020 20:50:10 +0000 (07:50 +1100)]
Merge pull request #16567 from eileenmcnaughton/parti_form
Fix theoretical regression
Seamus Lee [Mon, 17 Feb 2020 20:06:53 +0000 (07:06 +1100)]
Merge pull request #16572 from civicrm/5.23
5.23
William Mortada [Mon, 17 Feb 2020 18:04:18 +0000 (18:04 +0000)]
Fix typo - no hyphen in 'override'
Matthew Wire [Mon, 17 Feb 2020 16:01:31 +0000 (16:01 +0000)]
Merge pull request #16506 from mattwire/invoicedue_countrefunded
Count refunds when calculating amount due for an invoice
colemanw [Mon, 17 Feb 2020 15:20:06 +0000 (10:20 -0500)]
Merge pull request #16009 from jmcclelland/import-match-phone
dev/core#1438 Enable matching on contact phone when importing contributions
Matthew Wire [Mon, 17 Feb 2020 15:16:22 +0000 (15:16 +0000)]
Merge pull request #16035 from demeritcowboy/ang-crmcasetype-list-boolean
dev/core#1451 Incorrect dropdown action choices on case type listing screen
Matthew Wire [Mon, 17 Feb 2020 14:33:57 +0000 (14:33 +0000)]
Merge pull request #16565 from eileenmcnaughton/contview
dev/financial#118 Move source & receive date to the top on contribution view page
Yashodha Chaku [Mon, 17 Feb 2020 13:25:25 +0000 (18:55 +0530)]
Merge pull request #16568 from JGaunt/patch-4
Update 5.23.0.md
Matthew Wire [Mon, 17 Feb 2020 13:11:28 +0000 (13:11 +0000)]
Merge pull request #16491 from mfb/undefined-index
Resolve notices if first donation amount and date columns were disabled
Matthew Wire [Mon, 17 Feb 2020 13:03:11 +0000 (13:03 +0000)]
Merge pull request #16455 from MegaphoneJon/core-1568
core#1568: Show recipientListing to non-admins
Jade Gaunt [Mon, 17 Feb 2020 11:52:39 +0000 (11:52 +0000)]
Update 5.23.0.md
Added organisation name :)
Matthew Wire [Mon, 17 Feb 2020 11:01:19 +0000 (11:01 +0000)]
Merge pull request #14928 from lcdservices/dev-core-1158
dev/core#1158 mailing labels: explicitly set primary flag
Matthew Wire [Mon, 17 Feb 2020 08:46:03 +0000 (08:46 +0000)]
Merge pull request #15856 from agileware/CIVICRM-1368
dev/financial#104 Use rounding and integers to compare monetary values…
eileen [Mon, 17 Feb 2020 08:04:00 +0000 (21:04 +1300)]
Fix theoretical regression
This PR https://github.com/civicrm/civicrm-core/pull/16363/commits/
44237a295dc5eab4f6110fb0556b1af742364f6e
(merged to 5.23) calls self::::getDefaultRoleID() in a way that was always flawed but definitely woudl
not work now. I think it is never reached but better to put this fix into 5.23 & maybe reemove the line in master
later since it assumes participant_status_id is optional - which is not true of the backoffice form
eileen [Mon, 17 Feb 2020 06:28:43 +0000 (19:28 +1300)]
dev/financial#118 Move source & receive date to the top on contribution view page
Per https://lab.civicrm.org/dev/financial/issues/118 this doesn't seem to be controversial - although there is a desire
to take it further & once this is merged I'll look at that
Eileen McNaughton [Mon, 17 Feb 2020 00:34:02 +0000 (13:34 +1300)]
Merge pull request #16557 from eileenmcnaughton/find
[NFC] Preliminary cleanup
Seamus Lee [Sun, 16 Feb 2020 22:50:36 +0000 (09:50 +1100)]
Merge pull request #16498 from seamuslee001/net_smtp_upgrade
Upgrade Net_SMTP Package and remove now unneded patches and mov…
Seamus Lee [Sun, 16 Feb 2020 21:39:24 +0000 (08:39 +1100)]
Update patch URL and remove patch content as per standard now
Seamus Lee [Sat, 8 Feb 2020 03:40:42 +0000 (14:40 +1100)]
[REF] Upgrade Net_SMTP Package and remove now unneded patches and move to using composer patches rather than patching in a script file
eileen [Sun, 16 Feb 2020 21:01:51 +0000 (10:01 +1300)]
[NFC] Preliminary cleanup
Declare exceptions, params, don't declare unused variables
colemanw [Sun, 16 Feb 2020 19:36:56 +0000 (14:36 -0500)]
Merge pull request #16552 from eileenmcnaughton/part_form
[REF] Fix static call to non-static function.
Eileen McNaughton [Sat, 15 Feb 2020 22:37:43 +0000 (11:37 +1300)]
Merge pull request #16551 from totten/master-ext-tags
info.xml - Allow extensions to define a list of tags
colemanw [Sat, 15 Feb 2020 22:28:14 +0000 (17:28 -0500)]
Merge pull request #16554 from demeritcowboy/add-tag-ewarning
dev/core#1593 and dev/core#1536 - Remove unused code causing E_WARNING
Matthew Wire [Tue, 11 Feb 2020 15:18:49 +0000 (15:18 +0000)]
Count refunds when calculating amount due for an invoice
Matthew Wire [Sat, 15 Feb 2020 18:52:06 +0000 (18:52 +0000)]
Merge pull request #16525 from eileenmcnaughton/validate
Allow any casting done in Type::validate to bubble up to Request::retrieveValue
demeritcowboy [Sat, 15 Feb 2020 02:28:46 +0000 (21:28 -0500)]
remove unused code causing E_WARNING
Eileen McNaughton [Sat, 15 Feb 2020 03:29:36 +0000 (16:29 +1300)]
Merge pull request #16468 from mattwire/tokens_activitytokenprocessortrait
REF Refactor ActivityTokens to use a trait that can be shared with other entities
eileen [Sat, 15 Feb 2020 02:45:13 +0000 (15:45 +1300)]
[REF] Fix static call to non-static function.
This non-static function was being called statically. On grepping I found it is only called from this
one place so I moved it to the form
Eileen McNaughton [Sat, 15 Feb 2020 02:39:22 +0000 (15:39 +1300)]
Merge pull request #16515 from mattwire/phpnotice_noteprivacy
Fix a PHP notice for users with limited permissions when loading cont…
Eileen McNaughton [Sat, 15 Feb 2020 02:36:55 +0000 (15:36 +1300)]
Merge pull request #16533 from eileenmcnaughton/ex_angular
Do not fatally fail on angular pages if an extension is missing
Tim Otten [Sat, 15 Feb 2020 01:24:40 +0000 (17:24 -0800)]
info.xml - Allow extensions to define a list of tags
Overview
--------
This adopts a convention by which extensions may use `info.xml` to register tags, e.g.
```xml
<extension key="org.civicrm.foo" type="module">
<tags>
<tag>civicontribute</tag>
<tag>payment-processor</tag>
<tag>install-mandatory</tag>
</tags>
</extension>
```
Before
------
To add *any* metadata to `info.xml` files, you must update the parser and providing
filtering/indexing.
After
-----
If you need to add very simple metadata (tags), you can do that without
extra parsing code. The tag information can be accessed in the following
ways:
* Using the extension mapper
```php
$mapper = CRM_Extension_System::singleton()->getMapper();
$allTags = $mapper->getAllTags();
$mandatoryExts = $mapper->getKeysByTag('install-mandatory');
```
* The `Extension.get` API will return the list of tags for each ext
Seamus Lee [Sat, 15 Feb 2020 00:09:48 +0000 (11:09 +1100)]
Merge pull request #16548 from civicrm/5.23
5.23
Seamus Lee [Sat, 15 Feb 2020 00:07:37 +0000 (11:07 +1100)]
Merge pull request #16547 from seamuslee001/5.23
[NFC] Ensure that annon permissions are correctly assigned when enabl…
Seamus Lee [Sat, 15 Feb 2020 00:07:28 +0000 (11:07 +1100)]
Merge pull request #16549 from seamuslee001/style_fix_property_bag
[NFC] Fix style error
Seamus Lee [Fri, 14 Feb 2020 23:58:14 +0000 (10:58 +1100)]
[NFC] Fix style error
Seamus Lee [Fri, 14 Feb 2020 23:55:02 +0000 (10:55 +1100)]
Merge pull request #16532 from eileenmcnaughton/5.23
dev/core#1588 Fix regression where empty string is passed to PropertyBag
Seamus Lee [Fri, 14 Feb 2020 23:05:34 +0000 (10:05 +1100)]
[NFC] Ensure that annon permissions are correctly assigned when enabling civicrm webtest module in backdrop
Seamus Lee [Fri, 14 Feb 2020 21:16:31 +0000 (08:16 +1100)]
Merge pull request #16544 from seamuslee001/dev_core_1594
dev/core#1594 [TEST] Fix running of unit tests within an extension
Eileen McNaughton [Fri, 14 Feb 2020 20:20:35 +0000 (09:20 +1300)]
Merge pull request #16543 from jmcclelland/issue1589
dev/core#1589 avoid error when merging record with null create date
Eileen McNaughton [Fri, 14 Feb 2020 20:19:16 +0000 (09:19 +1300)]
Merge pull request #15998 from demeritcowboy/case-audit-skip-broken
dev/core#1366 Bypass nonfunctioning case audit interactive screen and go straight to report
Seamus Lee [Fri, 14 Feb 2020 19:51:51 +0000 (06:51 +1100)]
dev/core#1594 [TEST] Fix running of unit tests within an extension
Seamus Lee [Fri, 14 Feb 2020 19:36:03 +0000 (06:36 +1100)]
Merge pull request #16539 from eileenmcnaughton/text
Remove reference to mysql 5.0 & 5.1
Matthew Wire [Fri, 14 Feb 2020 19:18:02 +0000 (19:18 +0000)]
Merge pull request #16542 from JGaunt/patch-3
Update CONTRIBUTORS.txt
Matthew Wire [Fri, 14 Feb 2020 19:17:16 +0000 (19:17 +0000)]
Merge pull request #16540 from eileenmcnaughton/part_pend
[REF] Remove never used property
Jamie McClelland [Fri, 14 Feb 2020 15:57:25 +0000 (10:57 -0500)]
avoid error when merging record with null create date
https://lab.civicrm.org/dev/core/issues/1589
Jade Gaunt [Fri, 14 Feb 2020 15:19:32 +0000 (15:19 +0000)]
Update CONTRIBUTORS.txt
Added in mine and my colleagues name.
Mathieu Lu [Fri, 14 Feb 2020 14:07:45 +0000 (09:07 -0500)]
Merge pull request #16527 from alexymik/added_by
Change "Added By" to "Added by"
eileen [Fri, 14 Feb 2020 12:29:59 +0000 (01:29 +1300)]
Remove never used property
I grepped for _roleId & found it in only these 2 places - removing
Eileen McNaughton [Fri, 14 Feb 2020 11:37:11 +0000 (00:37 +1300)]
Merge pull request #15390 from kewljuice/patch-4
Check email when creating a user in drupal 8
eileen [Fri, 14 Feb 2020 11:22:54 +0000 (00:22 +1300)]
Remove reference to mysql 5.0 & 5.1
Subset of https://github.com/civicrm/civicrm-core/pull/16084
Eileen McNaughton [Fri, 14 Feb 2020 11:12:28 +0000 (00:12 +1300)]
Merge pull request #16516 from colemanw/request
APIv4 - merge ActionUtil with Request::create
Eileen McNaughton [Fri, 14 Feb 2020 11:10:09 +0000 (00:10 +1300)]
Merge pull request #16523 from yashodha/header
add column for report
Eileen McNaughton [Fri, 14 Feb 2020 08:20:14 +0000 (21:20 +1300)]
Merge pull request #16537 from civicrm/5.23
5.23
Eileen McNaughton [Fri, 14 Feb 2020 06:23:09 +0000 (19:23 +1300)]
Merge pull request #15824 from mfb/email-search-speed-boost
Speed boost for civicrm/ajax/checkemail
Eileen McNaughton [Fri, 14 Feb 2020 05:58:36 +0000 (18:58 +1300)]
Merge pull request #16467 from ixiam/dev-1110
fix contribution summary report's statistics when grouping and having
Eileen McNaughton [Fri, 14 Feb 2020 05:51:46 +0000 (18:51 +1300)]
Merge pull request #16451 from mattwire/settingreadonly
Settings Fix setting readonly attribute
Seamus Lee [Fri, 14 Feb 2020 05:51:17 +0000 (16:51 +1100)]
Merge pull request #16535 from eileenmcnaughton/523rel
dev/core#1592 fix regression on relation active period
Eileen McNaughton [Fri, 14 Feb 2020 05:46:25 +0000 (18:46 +1300)]
Merge pull request #15330 from mattwire/paymentprocessor_testmodelivemode
Fix issues with retrieving supportsTestMode/supportsLiveMode for payment processors
Seamus Lee [Fri, 14 Feb 2020 05:26:48 +0000 (16:26 +1100)]
Merge pull request #16534 from eileenmcnaughton/523m
dev/core#1551 regression fix
Seamus Lee [Fri, 14 Feb 2020 05:19:46 +0000 (16:19 +1100)]
Merge pull request #16526 from eileenmcnaughton/valid_calls
Fix calls to Request::retrieve
eileen [Fri, 14 Feb 2020 04:42:17 +0000 (17:42 +1300)]
dev/core#1592 fix regression on relation active period
Per https://lab.civicrm.org/dev/core/issues/1592 the custom query for this field is being
ignored now it's using datepicker with relevant format changes. This causes the
custom function for the field to be called
eileen [Fri, 14 Feb 2020 03:55:08 +0000 (16:55 +1300)]
dev/core#1551 regression fix
Now that mailing_id is defined as field metadata the form main metadata fn is trying to handle it, However
the form is casting it to the wrong array format -https://github.com/civicrm/civicrm-core/blob/
86f20cc17dde028977130f84feaf3b1d760ca57d/CRM/Contact/Form/Search.php#L649
We could fix this & rip it out of Mailing_BAO_Query::where but there is still a gap in that
there is no pseudoconstant recorded for the field so the qill doesn't work & there is a gap in
pre-parsing for the form 'IN'
Hence this seems like a good approach to remove the regression in the immediate term
eileen [Fri, 14 Feb 2020 02:07:08 +0000 (15:07 +1300)]
Do not fatally fail on angular pages if an extension is missing
If an extension is missing trying to create a new mailing will totally fail - on QF pages we just get a
not-very-clear message
eileen [Fri, 14 Feb 2020 01:50:18 +0000 (14:50 +1300)]
dev/core#1588 Fix regression where empty string is passed to SettingsBag
We have a scenario where the checkbox is presented but is optional. This is then in 'params' which is passed through to
PropertyBag. The value is equal to '' so it fails to validate when we use it to set the value on the PropertyBag.
I don't think we lose anything meaningful by not setting an empty string and it avoids this error so we should
merge & release as a regression fix IMHO. If we want to revist then we should do that in master
https://lab.civicrm.org/dev/core/issues/1588
Seamus Lee [Thu, 13 Feb 2020 22:59:31 +0000 (09:59 +1100)]
Merge pull request #16530 from civicrm/5.23
5.23
Eileen McNaughton [Thu, 13 Feb 2020 21:49:32 +0000 (10:49 +1300)]
Merge pull request #16521 from seamuslee001/dev_core_1489_2
dev/core#1489 Include hook_civicrm_managed into the list of upgrade f…
Eileen McNaughton [Thu, 13 Feb 2020 21:05:16 +0000 (10:05 +1300)]
Merge pull request #16477 from demeritcowboy/unit-test-env
[TEST] dev/core#1572 Unit test environment not working on windows after recent CodeGen updates
eileen [Thu, 13 Feb 2020 20:32:54 +0000 (09:32 +1300)]
Fix calls to Request::retrieve
Do not pass in values that are set by default. Use retrieveValue rather than passing inn the NULL object
Alexy Mikhailichenko [Thu, 13 Feb 2020 20:29:43 +0000 (12:29 -0800)]
Change "Added By" to "Added by"
eileen [Thu, 13 Feb 2020 20:18:34 +0000 (09:18 +1300)]
Allow any casting done in Type::validate to bubble up to Request::retrieveValue
The validate function returns
- NULL if the passed in value is not valid
- THe passed in value if valid or
- The passed in value cast to an integer if the value is valid and the type is Int or Integer
By always using the returned value we allow it to be cast, where appropriate
Coleman Watts [Thu, 13 Feb 2020 00:20:53 +0000 (19:20 -0500)]
APIv3 - Handle input errors
yashodha [Thu, 13 Feb 2020 08:36:17 +0000 (14:06 +0530)]
add column for report
Eileen McNaughton [Thu, 13 Feb 2020 04:08:40 +0000 (17:08 +1300)]
Merge pull request #16522 from totten/master-simplecache-patchurl
dev/core#1562 - composer.json - Fix E2E tests run on D8 build (via "patches") #16427
Eileen McNaughton [Thu, 13 Feb 2020 02:11:38 +0000 (15:11 +1300)]
Merge pull request #16512 from yashodha/header
Relationship report - add sort order for end date
Tim Otten [Thu, 13 Feb 2020 02:03:21 +0000 (18:03 -0800)]
(dev/core#1562) composer.json - Fix E2E tests run on D8 build (w/"patches" and URLs)
Seamus Lee [Thu, 13 Feb 2020 01:42:47 +0000 (12:42 +1100)]
dev/core#1489 Include hook_civicrm_managed into the list of upgrade freindly hooks
Tim Otten [Thu, 13 Feb 2020 01:14:17 +0000 (17:14 -0800)]
Remove patch files that are now loaded from URL
The `composer.json` was updated to get these patch files via URL instead of
via local/relative path.
Future maintainers who wish to revise these patches will need to post new
revisions somewhere with a durable URL *before* they can update
`civicrm-core`.
Keeping the files in here wrongly implies that you can revise the files
in-situ - their presence is misleading.
Seamus Lee [Wed, 12 Feb 2020 21:40:30 +0000 (08:40 +1100)]
Merge pull request #16519 from civicrm/5.23
5.23
Seamus Lee [Wed, 12 Feb 2020 21:40:14 +0000 (08:40 +1100)]
Merge pull request #16520 from agh1/5.23.0-release-notes
5.23.0 release notes
Seamus Lee [Wed, 12 Feb 2020 21:34:55 +0000 (08:34 +1100)]
Merge pull request #16517 from agh1/5.23.0-release-notes
5.23.0 release notes: initial run
Seamus Lee [Wed, 12 Feb 2020 21:34:05 +0000 (08:34 +1100)]
Merge pull request #16518 from greenpeace-cee/fix-xoauth-imap
dev/mail#59 - Fix use of useXOAUTH2 constant instead of var
Patrick Figel [Wed, 12 Feb 2020 20:27:02 +0000 (21:27 +0100)]
dev/mail#59 - Fix use of useXOAUTH2 constant instead of var
This fixes an issue where a missing $ before the useXOAUTH2 variable
prevents IMAP authentication with XOAUTH2 from working.
Andrew Hunt [Wed, 12 Feb 2020 19:18:49 +0000 (14:18 -0500)]
5.23.0 release notes: added boilerplate
colemanw [Wed, 12 Feb 2020 17:43:18 +0000 (12:43 -0500)]
Merge pull request #16513 from eileenmcnaughton/credit_note_setting
Move settings definition on contribution settings form to metadata.
Coleman Watts [Wed, 12 Feb 2020 16:24:13 +0000 (11:24 -0500)]
APIv4 - merge ActionUtil with Request::create
The Request::create function was broken for v4, and ActionUtil had been serving the same purpose but in a non-broken way.
Andrew Hunt [Wed, 12 Feb 2020 15:58:17 +0000 (10:58 -0500)]
5.23.0 release notes: raw from script
Matthew Wire [Wed, 12 Feb 2020 15:41:48 +0000 (15:41 +0000)]
Fix a PHP notice for users with limited permissions when loading contact summary
eileen [Thu, 30 Jan 2020 23:32:21 +0000 (12:32 +1300)]
Move credit_note_definition on contribution settings form to metadata.
This moves the code that allows settings to be added to forms by metadata from the Generic setting form to the setting trait.
This means many more forms will support injecting settings by metadata. Specifically we switch across the Contribution preferences form,
making credit_note_prefix a metadata-added field. This is preliminary to moving that to an extension & allows us to inject it
in by simply defining the metadata in a hook
yashodha [Wed, 12 Feb 2020 12:21:24 +0000 (17:51 +0530)]
add sort order for end date
Seamus Lee [Wed, 12 Feb 2020 06:46:57 +0000 (17:46 +1100)]
Merge pull request #16511 from colemanw/kernel
API Kernel - cleanup deprecated fn & unused param
Yashodha Chaku [Wed, 12 Feb 2020 02:34:01 +0000 (08:04 +0530)]
Merge pull request #15859 from jitendrapurohit/dev-mem-17
dev/mem#17 - Deleting memberships does not delete its related line item
Coleman Watts [Tue, 11 Feb 2020 22:29:06 +0000 (17:29 -0500)]
API Kernel - cleanup deprecated fn & unused param
Seamus Lee [Wed, 12 Feb 2020 00:39:07 +0000 (11:39 +1100)]
Merge pull request #16510 from colemanw/ws
crmSelect2 - fix whitespace in tooltip
Coleman Watts [Tue, 11 Feb 2020 22:06:21 +0000 (17:06 -0500)]
crmSelect2 - fix whitespace in tooltip
colemanw [Tue, 11 Feb 2020 21:50:02 +0000 (16:50 -0500)]
Merge pull request #16508 from colemanw/escape
Common.js - remove duplicate function
Seamus Lee [Tue, 11 Feb 2020 20:44:47 +0000 (07:44 +1100)]
Merge pull request #16507 from colemanw/title
dev/core#1587 Select2 - Use description as title for each option
Coleman Watts [Tue, 11 Feb 2020 20:43:54 +0000 (15:43 -0500)]
Common.js - remove duplicate function
This function did the same thing as the one in lo-dash