civicrm-core.git
23 months agoSearchKit - Fix crashy-ness when an Afform contains a deleted search
Coleman Watts [Wed, 30 Nov 2022 22:21:01 +0000 (17:21 -0500)]
SearchKit - Fix crashy-ness when an Afform contains a deleted search

23 months agoMerge pull request #25070 from MegaphoneJon/search-kit-numfmt
Eileen McNaughton [Wed, 30 Nov 2022 19:51:27 +0000 (08:51 +1300)]
Merge pull request #25070 from MegaphoneJon/search-kit-numfmt

fix numfmt error when pager limit is set in Civi settings

23 months agoMerge pull request #25090 from civicrm/5.56
Eileen McNaughton [Wed, 30 Nov 2022 19:30:33 +0000 (08:30 +1300)]
Merge pull request #25090 from civicrm/5.56

5.56 to master

23 months agoMerge pull request #25089 from agh1/5.56.0-releasenotes-initial
Eileen McNaughton [Wed, 30 Nov 2022 19:29:36 +0000 (08:29 +1300)]
Merge pull request #25089 from agh1/5.56.0-releasenotes-initial

5.56.0 release notes initial run

23 months ago5.56.0 release notes: added boilerplate
Andie Hunt [Wed, 30 Nov 2022 16:43:05 +0000 (11:43 -0500)]
5.56.0 release notes: added boilerplate

23 months ago5.56.0 release notes: raw from script
Andie Hunt [Wed, 30 Nov 2022 15:22:52 +0000 (10:22 -0500)]
5.56.0 release notes: raw from script

23 months agoMerge pull request #25083 from eileenmcnaughton/financial_dep
demeritcowboy [Wed, 30 Nov 2022 15:06:50 +0000 (10:06 -0500)]
Merge pull request #25083 from eileenmcnaughton/financial_dep

Test cleanup, stop using legacy financial bao methods

23 months agoMerge pull request #25086 from eileenmcnaughton/import_menu
Eileen McNaughton [Wed, 30 Nov 2022 06:33:50 +0000 (19:33 +1300)]
Merge pull request #25086 from eileenmcnaughton/import_menu

Add 'my imports' to Reports navigation (in civimport extension)

23 months agoMerge pull request #25084 from colemanw/enableDisableTasks
Eileen McNaughton [Wed, 30 Nov 2022 05:28:53 +0000 (18:28 +1300)]
Merge pull request #25084 from colemanw/enableDisableTasks

SearchKit - Add enable/disable tasks

23 months agoMerge pull request #25075 from eileenmcnaughton/query_ref
Eileen McNaughton [Wed, 30 Nov 2022 04:11:41 +0000 (17:11 +1300)]
Merge pull request #25075 from eileenmcnaughton/query_ref

Fix query to use standard `CRM_Core_DAO::executeQuery`

23 months agoMerge pull request #25072 from eileenmcnaughton/import_form
Eileen McNaughton [Wed, 30 Nov 2022 04:11:25 +0000 (17:11 +1300)]
Merge pull request #25072 from eileenmcnaughton/import_form

Add FormBuilder forms to Civiimport

23 months agoAdd afform for report listing
Eileen McNaughton [Wed, 30 Nov 2022 01:50:03 +0000 (14:50 +1300)]
Add afform for report listing

23 months agoMerge pull request #25068 from shaneonabike/translation80
Eileen McNaughton [Wed, 30 Nov 2022 01:19:25 +0000 (14:19 +1300)]
Merge pull request #25068 from shaneonabike/translation80

Adding better translation for ThankYou page tpl for recurring messaging

23 months agoAdd FormBuilder forms to Civiimport
Eileen McNaughton [Tue, 29 Nov 2022 02:09:28 +0000 (15:09 +1300)]
Add FormBuilder forms to Civiimport

Co-authored-by: colemanw <coleman@civicrm.org>
23 months agoFix query to use standard CRM_Core_DAO::executeQuery
Eileen McNaughton [Tue, 29 Nov 2022 04:34:22 +0000 (17:34 +1300)]
Fix query to use standard CRM_Core_DAO::executeQuery

23 months agoMerge pull request #25082 from eileenmcnaughton/financial_delete
Eileen McNaughton [Wed, 30 Nov 2022 00:47:40 +0000 (13:47 +1300)]
Merge pull request #25082 from eileenmcnaughton/financial_delete

Follow up on EntityFinancialAccount delete

23 months agoAdding better translation for ThankYou page tpl for recurring messaging
Shane Bill [Mon, 28 Nov 2022 19:30:04 +0000 (15:30 -0400)]
Adding better translation for ThankYou page tpl for recurring messaging

23 months agoTest cleanup, stop using legacy financial bao methods
Eileen McNaughton [Tue, 29 Nov 2022 23:31:04 +0000 (12:31 +1300)]
Test cleanup, stop using legacy financial bao methods

23 months agoSearchKit - Add enable/disable tasks
Coleman Watts [Tue, 29 Nov 2022 23:30:16 +0000 (18:30 -0500)]
SearchKit - Add enable/disable tasks

23 months agoMerge pull request #25073 from eileenmcnaughton/cachey
Tim Otten [Tue, 29 Nov 2022 23:29:25 +0000 (15:29 -0800)]
Merge pull request #25073 from eileenmcnaughton/cachey

Do not `set` cache in cache-bypass mode, since we are bypassing `get`

23 months agoMerge pull request #25081 from eileenmcnaughton/import_jobs
colemanw [Tue, 29 Nov 2022 23:24:31 +0000 (18:24 -0500)]
Merge pull request #25081 from eileenmcnaughton/import_jobs

Add Imports search

23 months agoFollow up on EntityFinancialAccount delete
Eileen McNaughton [Tue, 29 Nov 2022 22:59:45 +0000 (11:59 +1300)]
Follow up on EntityFinancialAccount delete

I decided the test was a waste of space as it was mixing up the entities
& hence checking the wrong id with the wrong entity & meaningless.

Form now uses the right api:

23 months agoMerge pull request #25026 from aydun/bao_del_fta
Eileen McNaughton [Tue, 29 Nov 2022 22:36:25 +0000 (11:36 +1300)]
Merge pull request #25026 from aydun/bao_del_fta

Deprecate `CRM_Financial_BAO_EntityFinancialAccount::del()`

23 months agoMerge pull request #25079 from colemanw/regenDao
colemanw [Tue, 29 Nov 2022 22:32:43 +0000 (17:32 -0500)]
Merge pull request #25079 from colemanw/regenDao

Regenerate ContactType DAO

23 months agoAdd Imports search
Eileen McNaughton [Tue, 29 Nov 2022 21:40:21 +0000 (10:40 +1300)]
Add Imports search

This allows an over-view of a user's searches

23 months agoDeprecate `Financial_BAO_EntityFinancialAccount::del()`
Aidan Saunders [Tue, 22 Nov 2022 16:55:21 +0000 (16:55 +0000)]
Deprecate `Financial_BAO_EntityFinancialAccount::del()`
Change 'setStatus' to exceptions and create status messages at form
layer.

23 months agoMerge pull request #25080 from colemanw/titleSpec
Eileen McNaughton [Tue, 29 Nov 2022 21:07:47 +0000 (10:07 +1300)]
Merge pull request #25080 from colemanw/titleSpec

FieldSpec - Generate better default field titles for DAOs

2 years agoRegenerate ContactType DAO
Coleman Watts [Tue, 29 Nov 2022 19:33:58 +0000 (14:33 -0500)]
Regenerate ContactType DAO

2 years agoFieldSpec - Generate better default field titles for DAOs
Coleman Watts [Tue, 29 Nov 2022 19:37:43 +0000 (14:37 -0500)]
FieldSpec - Generate better default field titles for DAOs

2 years agoMerge pull request #25069 from colemanw/afformContactType
colemanw [Tue, 29 Nov 2022 15:37:25 +0000 (10:37 -0500)]
Merge pull request #25069 from colemanw/afformContactType

Afform - Support ContactType-specific tabs and blocks

2 years agoMerge pull request #25074 from eileenmcnaughton/tok_dep
Seamus Lee [Tue, 29 Nov 2022 06:13:34 +0000 (17:13 +1100)]
Merge pull request #25074 from eileenmcnaughton/tok_dep

Fix test class not to use discouraged function

2 years agoMerge pull request #25048 from eileenmcnaughton/legacy
Yashodha Chaku [Tue, 29 Nov 2022 05:49:39 +0000 (11:19 +0530)]
Merge pull request #25048 from eileenmcnaughton/legacy

Remove legacyCreateMultiple function

2 years agoFix test class not to use deprecated function
Eileen McNaughton [Tue, 29 Nov 2022 04:20:05 +0000 (17:20 +1300)]
Fix test class not to use deprecated function

2 years agoMerge pull request #25071 from colemanw/searchKitNitpick
Eileen McNaughton [Tue, 29 Nov 2022 04:06:34 +0000 (17:06 +1300)]
Merge pull request #25071 from colemanw/searchKitNitpick

SearchKit - Minor wording change

2 years agoMerge pull request #24590 from eileenmcnaughton/cont
Seamus Lee [Tue, 29 Nov 2022 03:33:52 +0000 (14:33 +1100)]
Merge pull request #24590 from eileenmcnaughton/cont

Remove another call to deprecated `CRM_Contribute_PseudoConstant::contributionStatus`

2 years agoDo not set cache in cache-bypass mode
Eileen McNaughton [Tue, 29 Nov 2022 03:12:14 +0000 (16:12 +1300)]
Do not set cache in cache-bypass mode

2 years agoSearchKit - Minor wording change
Coleman Watts [Tue, 29 Nov 2022 01:48:30 +0000 (20:48 -0500)]
SearchKit - Minor wording change

2 years agoAfform - Support ContactType-specific tabs and blocks
Coleman Watts [Mon, 28 Nov 2022 19:50:40 +0000 (14:50 -0500)]
Afform - Support ContactType-specific tabs and blocks

2 years agofix numfmt error when pager limit is set in Civi settings
Jon Goldberg [Mon, 28 Nov 2022 23:14:21 +0000 (18:14 -0500)]
fix numfmt error when pager limit is set in Civi settings

2 years agoMerge pull request #25041 from eileenmcnaughton/import_backgroup
Seamus Lee [Mon, 28 Nov 2022 22:42:18 +0000 (09:42 +1100)]
Merge pull request #25041 from eileenmcnaughton/import_backgroup

Create MVP UI for imports when background queue processing is taking place

2 years agoOver-ride monitor page within the extension
Eileen McNaughton [Thu, 24 Nov 2022 03:43:09 +0000 (16:43 +1300)]
Over-ride monitor page within the extension

This gives us a usable monitoring page for imports, without having to plan
out a solution that covers all potential use cases.

It should be a quick way to get this functionality operational

2 years agoMerge pull request #25059 from colemanw/mailingApi
Eileen McNaughton [Mon, 28 Nov 2022 20:27:55 +0000 (09:27 +1300)]
Merge pull request #25059 from colemanw/mailingApi

dev/core#3965 APIv4 - Add Mailing entities for SearchKit

2 years agoMerge pull request #25030 from mlutfy/logAuthFailed
Matthew Wire [Mon, 28 Nov 2022 17:23:17 +0000 (17:23 +0000)]
Merge pull request #25030 from mlutfy/logAuthFailed

Log API Authorization failed errors

2 years agoMerge pull request #25065 from JKingsnorth/standardise-ip-detection
demeritcowboy [Mon, 28 Nov 2022 16:22:44 +0000 (11:22 -0500)]
Merge pull request #25065 from JKingsnorth/standardise-ip-detection

Use IP address helper method consistently

2 years agoUse IP address helper method consistently
John Kingsnorth [Mon, 28 Nov 2022 13:17:46 +0000 (13:17 +0000)]
Use IP address helper method consistently

2 years agoMerge pull request #24980 from colemanw/alwaysAllowAutocomplete
Seamus Lee [Mon, 28 Nov 2022 07:02:37 +0000 (18:02 +1100)]
Merge pull request #24980 from colemanw/alwaysAllowAutocomplete

APIv4 - Always allow anonymous autocomplete action access

2 years agoMerge pull request #25064 from colemanw/contactTypes
Seamus Lee [Mon, 28 Nov 2022 07:01:43 +0000 (18:01 +1100)]
Merge pull request #25064 from colemanw/contactTypes

[REF] ContactType BAO - Simplify getAllContactTypes

2 years agoContactType BAO - Simplify getAllContactTypes
Coleman Watts [Mon, 28 Nov 2022 05:20:22 +0000 (00:20 -0500)]
ContactType BAO - Simplify getAllContactTypes

Looking up pseudoconstants was silly, the data is already there

2 years agoMerge pull request #25040 from eileenmcnaughton/import_summary
Seamus Lee [Mon, 28 Nov 2022 02:13:20 +0000 (13:13 +1100)]
Merge pull request #25040 from eileenmcnaughton/import_summary

Fix Import summary to differentiate between 'valid' and 'imported'

2 years agoMerge pull request #24987 from colemanw/searchDisplayPagerCountFix
Eileen McNaughton [Sun, 27 Nov 2022 23:07:58 +0000 (12:07 +1300)]
Merge pull request #24987 from colemanw/searchDisplayPagerCountFix

SearchKit - Fix display count when updating items on the last page

2 years agoMerge pull request #25062 from civicrm/5.56
Eileen McNaughton [Sun, 27 Nov 2022 20:24:22 +0000 (09:24 +1300)]
Merge pull request #25062 from civicrm/5.56

5.56 to master

2 years agoMerge pull request #25061 from colemanw/fixAfformFilter
Eileen McNaughton [Sun, 27 Nov 2022 20:23:58 +0000 (09:23 +1300)]
Merge pull request #25061 from colemanw/fixAfformFilter

Afform - fix empty search filters

2 years agoLog API Authorization failed errors
Mathieu Lutfy [Tue, 22 Nov 2022 21:02:04 +0000 (16:02 -0500)]
Log API Authorization failed errors

2 years agoMerge pull request #25056 from aydun/messagetemplate_update
colemanw [Sun, 27 Nov 2022 16:50:41 +0000 (11:50 -0500)]
Merge pull request #25056 from aydun/messagetemplate_update

Make MessageTemplate.master_id fully joinable

2 years agoAfform - fix empty search filters
Coleman Watts [Sun, 27 Nov 2022 16:26:09 +0000 (11:26 -0500)]
Afform - fix empty search filters

Fixes dev/core#3997

2 years agoMailingEventBounce - Rename `create` function to `recordBounce`
Coleman Watts [Sun, 27 Nov 2022 01:29:57 +0000 (20:29 -0500)]
MailingEventBounce - Rename `create` function to `recordBounce`

Because it's not a standard CRUD create function it was messing up the APIv4 syntaxConformanceTest
Best rename it for clarity.

2 years agoMerge pull request #25001 from colemanw/autofillRelationship
colemanw [Sun, 27 Nov 2022 00:48:45 +0000 (19:48 -0500)]
Merge pull request #25001 from colemanw/autofillRelationship

Afform - Autofill contacts by relationship

2 years agodev/core#3965 Add Mailng Events to APIv4
Coleman Watts [Sat, 26 Nov 2022 15:51:50 +0000 (10:51 -0500)]
dev/core#3965 Add Mailng Events to APIv4

2 years agoRemove legacyCreateMultiple function
Eileen McNaughton [Fri, 25 Nov 2022 01:49:06 +0000 (14:49 +1300)]
Remove legacyCreateMultiple function

This was annotated deprecated 7 years ago, is called 'legacy' and was nosily deprecated 10 months
ago. It IS still called from one jma extenion but I think it's OK to remove with a ping

2 years agoTag class aliases as @deprecated
Coleman Watts [Wed, 23 Nov 2022 20:38:04 +0000 (15:38 -0500)]
Tag class aliases as @deprecated

2 years agoMerge pull request #25057 from civicrm/5.56
demeritcowboy [Sat, 26 Nov 2022 00:34:36 +0000 (19:34 -0500)]
Merge pull request #25057 from civicrm/5.56

Merge 5.56 to master

2 years agoMerge pull request #25047 from eileenmcnaughton/rel_except
colemanw [Fri, 25 Nov 2022 22:53:20 +0000 (17:53 -0500)]
Merge pull request #25047 from eileenmcnaughton/rel_except

Fix Relationship to permit disabled relationships as duplicates & fix test

2 years agoMerge pull request #25055 from colemanw/upgraderFix
Eileen McNaughton [Fri, 25 Nov 2022 22:15:54 +0000 (11:15 +1300)]
Merge pull request #25055 from colemanw/upgraderFix

Fix upgrader to safely run multiple times

2 years agoFix upgrader to safely run multiple times
Coleman Watts [Fri, 25 Nov 2022 20:57:43 +0000 (15:57 -0500)]
Fix upgrader to safely run multiple times

2 years agoMake MessageTemplate.master_id fully joinable
Aidan Saunders [Fri, 25 Nov 2022 20:42:03 +0000 (20:42 +0000)]
Make MessageTemplate.master_id fully joinable

Move Calculated Field tests out of BAO tests - they're not BAO
Enhance test to check fields of master_id entity are returned.

2 years agoMerge pull request #25033 from kurund/contribution-fee-fixes
demeritcowboy [Fri, 25 Nov 2022 19:50:54 +0000 (14:50 -0500)]
Merge pull request #25033 from kurund/contribution-fee-fixes

fixes dash line appended to the contribution amounts if label is empty

2 years agoAfform - Autofill contacts by relationship
Coleman Watts [Fri, 18 Nov 2022 19:57:45 +0000 (14:57 -0500)]
Afform - Autofill contacts by relationship

Fixes dev/core#3453

2 years agofixed the typo
Kurund Jalmi [Fri, 25 Nov 2022 17:27:52 +0000 (17:27 +0000)]
fixed the typo

2 years agoMerge pull request #25051 from eileenmcnaughton/tok_org
colemanw [Fri, 25 Nov 2022 14:46:51 +0000 (09:46 -0500)]
Merge pull request #25051 from eileenmcnaughton/tok_org

Remove deprecated, probably long-broken function `replaceOrgTokens`

2 years agoMerge pull request #25050 from eileenmcnaughton/token_noisy
colemanw [Fri, 25 Nov 2022 14:45:02 +0000 (09:45 -0500)]
Merge pull request #25050 from eileenmcnaughton/token_noisy

Add noisy deprecation to deprecated contribution token functions

2 years agoMerge pull request #25049 from eileenmcnaughton/token_custom
Yashodha Chaku [Fri, 25 Nov 2022 11:13:39 +0000 (16:43 +0530)]
Merge pull request #25049 from eileenmcnaughton/token_custom

Remove deprecated token function

2 years agoMerge pull request #25046 from eileenmcnaughton/rel_hook
demeritcowboy [Fri, 25 Nov 2022 03:53:40 +0000 (22:53 -0500)]
Merge pull request #25046 from eileenmcnaughton/rel_hook

Pass correct variable type to the hook

2 years agoRemove deprecated, probably long-broken function
Eileen McNaughton [Fri, 25 Nov 2022 03:49:04 +0000 (16:49 +1300)]
Remove deprecated, probably long-broken function

2 years agoAdd noisy deprecation to deprecated contribution token functions
Eileen McNaughton [Fri, 25 Nov 2022 03:14:52 +0000 (16:14 +1300)]
Add noisy deprecation to deprecated contribution token functions

2 years agoRemove deprecated token function
Eileen McNaughton [Fri, 25 Nov 2022 02:36:21 +0000 (15:36 +1300)]
Remove deprecated token function

2 years agoFix Relationship to permit disabled relationships to work & fix test
Eileen McNaughton [Fri, 25 Nov 2022 01:39:56 +0000 (14:39 +1300)]
Fix Relationship to permit disabled relationships to work & fix test

2 years agodev/cor#3874 Added test cases for failing relationship creation
Shane Bill [Mon, 24 Oct 2022 17:08:08 +0000 (14:08 -0300)]
dev/cor#3874 Added test cases for failing relationship creation

2 years agoMerge pull request #25037 from eileenmcnaughton/test_fix
Seamus Lee [Fri, 25 Nov 2022 00:56:50 +0000 (11:56 +1100)]
Merge pull request #25037 from eileenmcnaughton/test_fix

Test fix - setup is incongruent

2 years agoPass correct variable type to the hook
Eileen McNaughton [Fri, 25 Nov 2022 00:47:48 +0000 (13:47 +1300)]
Pass correct variable type to the hook

The variable type for 'rows' is an array, not null. Fix to pass
an empty array.

I renamed it to 'rows' since that is what the hook
calls it & it is just a dummy variable from the page's
point of view

2 years agoMerge pull request #25045 from mattwire/confirmvarnames
Eileen McNaughton [Thu, 24 Nov 2022 22:26:09 +0000 (11:26 +1300)]
Merge pull request #25045 from mattwire/confirmvarnames

REF: Consistent variables names in formRule for CRM/Event/Form/Register

2 years agoRename variables for consistency with Register form
Matthew Wire [Thu, 24 Nov 2022 20:47:32 +0000 (20:47 +0000)]
Rename variables for consistency with Register form

2 years agoConvert CRM_Utils_Array::value in Event/Form/Confirm
Matthew Wire [Thu, 24 Nov 2022 20:39:12 +0000 (20:39 +0000)]
Convert CRM_Utils_Array::value in Event/Form/Confirm

2 years agoMerge pull request #25043 from demeritcowboy/dao
demeritcowboy [Thu, 24 Nov 2022 19:27:25 +0000 (14:27 -0500)]
Merge pull request #25043 from demeritcowboy/dao

DAOs are stale

2 years agoMerge pull request #25042 from mattwire/registrationarrayvalue
colemanw [Thu, 24 Nov 2022 18:39:39 +0000 (13:39 -0500)]
Merge pull request #25042 from mattwire/registrationarrayvalue

REF: Replace CRM_Utils_Array::value in CRM/Event/Form/Registration

2 years agodao
demeritcowboy [Thu, 24 Nov 2022 18:06:18 +0000 (13:06 -0500)]
dao

2 years agoReplace CRM_Utils_Array::value in Form/Registration
Matthew Wire [Thu, 24 Nov 2022 16:44:09 +0000 (16:44 +0000)]
Replace CRM_Utils_Array::value in Form/Registration

2 years agoMerge pull request #25038 from eileenmcnaughton/civiimport
colemanw [Thu, 24 Nov 2022 04:41:35 +0000 (23:41 -0500)]
Merge pull request #25038 from eileenmcnaughton/civiimport

Use search display to view errors when using Civi-import extension

2 years agoMerge pull request #24947 from colemanw/entityTypesMixin
colemanw [Thu, 24 Nov 2022 04:38:51 +0000 (23:38 -0500)]
Merge pull request #24947 from colemanw/entityTypesMixin

Add entity-types-php mixin

2 years agoFix Import summary to differentiate between 'valid' and 'imported'
Eileen McNaughton [Thu, 24 Nov 2022 02:34:11 +0000 (15:34 +1300)]
Fix Import summary to differentiate between 'valid' and 'imported'

2 years agoUse search display to view errors when using Civi-import extension
Eileen McNaughton [Thu, 24 Nov 2022 00:15:00 +0000 (13:15 +1300)]
Use search display to view errors when using Civi-import extension

This replaces the link to download the csv with a link to view the search
display if civiimport is enabled, allowing re-doing within the UI

2 years agoTest fix - setup is incongruent
Eileen McNaughton [Wed, 23 Nov 2022 23:06:30 +0000 (12:06 +1300)]
Test fix - setup is incongruent

The point of this test is to check that line items are created. However, the test sloppily sets
the value of the contribution to be different to the recurring contribution - which is
something tested elsewhere but which is sloppy here. Fix

2 years agoAdd example+test for 'entity-types-php@1'
Tim Otten [Wed, 23 Nov 2022 22:18:56 +0000 (14:18 -0800)]
Add example+test for 'entity-types-php@1'

To some extent, there's implicit coverage because `search_kit` uses
`entity-types-php@1`.  But this goes a bit further, ensuring that the
entity-type metadata is maintained consistently across different stages of
lifecycle (enable/disable/uninstall) and styles of interaction (eg local-only
phpunit and multi-process cv CLI).

2 years agoMixin LifecycleTest - Add phpCall() helper
Tim Otten [Wed, 23 Nov 2022 22:17:11 +0000 (14:17 -0800)]
Mixin LifecycleTest - Add phpCall() helper

This is similar to the existing phpEval() helper, but it only calls one function, and it handles escaping the params.

Tangentially, relax the return type for `phpEval()` - since it's equally valid to return scalars.

2 years agoMerge pull request #25036 from colemanw/renameFinancialTypeAccount
Eileen McNaughton [Wed, 23 Nov 2022 22:07:06 +0000 (11:07 +1300)]
Merge pull request #25036 from colemanw/renameFinancialTypeAccount

EntityFinancialAccount - A tale of two BAO classes

2 years agoMerge pull request #24992 from aydun/messagetemplate_schema_changes
Eileen McNaughton [Wed, 23 Nov 2022 20:40:48 +0000 (09:40 +1300)]
Merge pull request #24992 from aydun/messagetemplate_schema_changes

Messagetemplate schema changes

2 years agoAPIv3 - Don't use deprecated del() methods
Coleman Watts [Wed, 23 Nov 2022 20:22:45 +0000 (15:22 -0500)]
APIv3 - Don't use deprecated del() methods

This follows the same pattern as the create action - to only use BAO methods if they are not @deprecated.
Note that APIv4 already does this in the DAODeleteAction class.

2 years agoAlias CRM_Financial_BAO_FinancialTypeAccount -> CRM_Financial_BAO_EntityFinancialAccount
Coleman Watts [Wed, 23 Nov 2022 16:58:34 +0000 (11:58 -0500)]
Alias CRM_Financial_BAO_FinancialTypeAccount -> CRM_Financial_BAO_EntityFinancialAccount

This BAO class did not follow the standard naming convention which effectively made it invisible to the API.
Why was named this way in the first place was never explained, I suspect it was simply a mistake.

A BAO class actually did get added before this PR, in 37c608f6e which further added to the confusion.
This consolidates the two classes.

Because it was an "invisible" BAO class, the create and del functions were never used by the API.
For consistency, I've therefore tagged them as @deprecated which keeps them hidden from the API.
We can add business logic back in as needed using hook listeners.

2 years agoMerge pull request #24982 from colemanw/renameMailing
Eileen McNaughton [Wed, 23 Nov 2022 20:10:31 +0000 (09:10 +1300)]
Merge pull request #24982 from colemanw/renameMailing

Mailing - Rename DAO files for better short names

2 years agoMerge pull request #25035 from demeritcowboy/stat
demeritcowboy [Wed, 23 Nov 2022 18:09:56 +0000 (13:09 -0500)]
Merge pull request #25035 from demeritcowboy/stat

afform/oauth-client - don't call stat on null

2 years agoMerge pull request #25034 from civicrm/5.56
demeritcowboy [Wed, 23 Nov 2022 18:09:45 +0000 (13:09 -0500)]
Merge pull request #25034 from civicrm/5.56

5.56