civicrm-core.git
2 years agoREF - Switch to using new `CRM_Core_Component::isEnabled()`
Coleman Watts [Wed, 2 Feb 2022 23:29:30 +0000 (18:29 -0500)]
REF - Switch to using new `CRM_Core_Component::isEnabled()`

Switches more verbose array searches to the new utility function.

2 years agoMerge pull request #22675 from colemanw/customGroupNameIndex
colemanw [Wed, 2 Feb 2022 20:38:56 +0000 (15:38 -0500)]
Merge pull request #22675 from colemanw/customGroupNameIndex

CustomGroup - Ensure 'name' is always unique

2 years agoMerge pull request #22609 from colemanw/contactCleanup
Eileen McNaughton [Wed, 2 Feb 2022 20:29:23 +0000 (09:29 +1300)]
Merge pull request #22609 from colemanw/contactCleanup

[REF] - Cleanup Contact BAO variables

2 years agoMerge pull request #22681 from totten/master-queue-cleanup
Eileen McNaughton [Wed, 2 Feb 2022 20:06:42 +0000 (09:06 +1300)]
Merge pull request #22681 from totten/master-queue-cleanup

(REF) Queues - Expand docblocks. Extract SQL trait.

2 years agoCustomGroup - Ensure 'name' is always unique
Coleman Watts [Tue, 1 Feb 2022 20:03:37 +0000 (15:03 -0500)]
CustomGroup - Ensure 'name' is always unique

Previously, unique 'name' was only enforced in tandem with 'extends'
Now it is required to be unique unconditionally.

2 years agoMerge pull request #22657 from totten/master-queue-facade-c
colemanw [Wed, 2 Feb 2022 15:12:43 +0000 (10:12 -0500)]
Merge pull request #22657 from totten/master-queue-facade-c

Queues - Add support for using persistent queues

2 years agoMerge pull request #22662 from colemanw/softDeleteEntity
demeritcowboy [Wed, 2 Feb 2022 14:34:16 +0000 (09:34 -0500)]
Merge pull request #22662 from colemanw/softDeleteEntity

[REF] APIv4 - Rename trait 'SoftDelete' to 'SoftDeleteEntity'

2 years agoMerge pull request #22647 from mlutfy/translation38ml
demeritcowboy [Wed, 2 Feb 2022 13:48:44 +0000 (08:48 -0500)]
Merge pull request #22647 from mlutfy/translation38ml

dev/translation#38 Fix multilingual triggers for when fields default to an empty string

2 years agoMerge pull request #22632 from eileenmcnaughton/msg_send
demeritcowboy [Wed, 2 Feb 2022 13:48:10 +0000 (08:48 -0500)]
Merge pull request #22632 from eileenmcnaughton/msg_send

dev/core#2866 Generate text version of message at send time if not present

2 years agoCivi::queue() - Tweak prioritization of fields per discussion
Tim Otten [Wed, 2 Feb 2022 10:56:19 +0000 (02:56 -0800)]
Civi::queue() - Tweak prioritization of fields per discussion

2 years ago(REF) CRM_Queue_Queue_Sql* - Dedupe `createItem()` function
Tim Otten [Wed, 2 Feb 2022 06:43:10 +0000 (22:43 -0800)]
(REF) CRM_Queue_Queue_Sql* - Dedupe `createItem()` function

Consolidate duplicate implementations. Move to trait.

2 years agodev/core#2866 Generate text version of message at send time if not present
Eileen McNaughton [Wed, 26 Jan 2022 23:00:19 +0000 (12:00 +1300)]
dev/core#2866 Generate text version of message at send time if not present

2 years ago(REF) CRM_Queue_Queue_Sql* - Extract trait for common functions
Tim Otten [Wed, 2 Feb 2022 01:38:42 +0000 (17:38 -0800)]
(REF) CRM_Queue_Queue_Sql* - Extract trait for common functions

Most of the methods in CRM/Queue/Queue/Sql.php and CRM/Queue/Queue/SqlParallel.php are
identical. Move them to a common trait so that they're easier to patch.

2 years ago(NFC) CRM_Queue_Runner - Expand on comments. Tweak layout.
Tim Otten [Tue, 1 Feb 2022 23:39:52 +0000 (15:39 -0800)]
(NFC) CRM_Queue_Runner - Expand on comments. Tweak layout.

2 years ago(NFC) CRM_Queue_Task - Fix docblock
Tim Otten [Tue, 1 Feb 2022 23:05:48 +0000 (15:05 -0800)]
(NFC) CRM_Queue_Task - Fix docblock

2 years agoMerge pull request #22676 from civicrm/5.46
Seamus Lee [Wed, 2 Feb 2022 01:29:48 +0000 (12:29 +1100)]
Merge pull request #22676 from civicrm/5.46

5.46

2 years agoMerge pull request #22235 from kurund/contribution-import
demeritcowboy [Tue, 1 Feb 2022 23:17:40 +0000 (18:17 -0500)]
Merge pull request #22235 from kurund/contribution-import

dev/core#2989 - validate campaign id for contribution import

2 years agoMerge pull request #22678 from alifrumin/rn5.46
Seamus Lee [Tue, 1 Feb 2022 23:10:34 +0000 (10:10 +1100)]
Merge pull request #22678 from alifrumin/rn5.46

[NFC] 5.46 release notes first pass

2 years ago[NFC] 5.46 release notes first pass
Alice Frumin [Tue, 1 Feb 2022 22:20:00 +0000 (17:20 -0500)]
[NFC] 5.46 release notes first pass

2 years agoCivi::queue() - Optionally accept more `array $params` to auto-initialize queue
Tim Otten [Tue, 1 Feb 2022 01:14:20 +0000 (17:14 -0800)]
Civi::queue() - Optionally accept more `array $params` to auto-initialize queue

2 years agoMerge pull request #22642 from colemanw/fixManagedCrash
Seamus Lee [Tue, 1 Feb 2022 21:23:39 +0000 (08:23 +1100)]
Merge pull request #22642 from colemanw/fixManagedCrash

(dev/core#3045) ManagedEntities - Fix crash during upgrade

2 years agoMerge pull request #22674 from braders/api3-docblock-types
Seamus Lee [Tue, 1 Feb 2022 21:22:08 +0000 (08:22 +1100)]
Merge pull request #22674 from braders/api3-docblock-types

Ensure all api3 functions have documented types

2 years agoEnsure all api3 functions have documented types
Bradley Taylor [Tue, 1 Feb 2022 19:36:08 +0000 (19:36 +0000)]
Ensure all api3 functions have documented types

2 years agoMerge pull request #22673 from agileware/CIVICRM-1924
colemanw [Tue, 1 Feb 2022 12:43:52 +0000 (07:43 -0500)]
Merge pull request #22673 from agileware/CIVICRM-1924

Fix spelling mistake in function name, addMembershipToRealtedContacts should be addMembershipToRelatedContacts

2 years agoMerge pull request #22672 from agileware/CIVICRM-1923
colemanw [Tue, 1 Feb 2022 12:16:29 +0000 (07:16 -0500)]
Merge pull request #22672 from agileware/CIVICRM-1923

Manage Contribution page, the link to "Online Contribution (Test-drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agoCIVICRM-1924 Fix spelling mistake in function name, addMembershipToRealtedContacts...
Justin Freeman [Tue, 1 Feb 2022 06:58:18 +0000 (17:58 +1100)]
CIVICRM-1924 Fix spelling mistake in function name, addMembershipToRealtedContacts should be addMembershipToRelatedContacts

2 years agoCIVICRM-1923 Contribution, the link to "Online Contribution (Test-drive)" is an admin...
Justin Freeman [Tue, 1 Feb 2022 06:47:55 +0000 (17:47 +1100)]
CIVICRM-1923 Contribution, the link to "Online Contribution (Test-drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agoMerge pull request #22648 from colemanw/removeApiv4PreSaveSubscriber
Seamus Lee [Tue, 1 Feb 2022 02:39:21 +0000 (13:39 +1100)]
Merge pull request #22648 from colemanw/removeApiv4PreSaveSubscriber

[REF] APIv4 - Deprecate and stop using PreSaveSubscriber

2 years agoCivi::queue(string $name) - Add facade to load queue by name. Add test.
Tim Otten [Sat, 29 Jan 2022 06:35:30 +0000 (22:35 -0800)]
Civi::queue(string $name) - Add facade to load queue by name. Add test.

The test includes coverage for a couple flows - eg creating the queue
via traditional `CRM_Queue_Service` or with the newer Civi\Api4\Queue.

2 years agoCRM_Queue_Service - Add support for persistent queues
Tim Otten [Sat, 29 Jan 2022 06:17:45 +0000 (22:17 -0800)]
CRM_Queue_Service - Add support for persistent queues

Before:

* `CRM_Queue_Service::create()` traditionally provided support for
  instantiating queue objects.
* `civicrm_queue` was recently added for tracking persistent
  metadata about queues.

After:

* `CRM_Queue_Service::create()` works as before, and it also accepts
   parameters `is_persistent` and `is_autorun`.

2 years agoMerge pull request #22666 from braders/avoid-php-notices-activity-form
colemanw [Tue, 1 Feb 2022 00:31:28 +0000 (19:31 -0500)]
Merge pull request #22666 from braders/avoid-php-notices-activity-form

Avoid PHP notices on activity form

2 years agoMerge pull request #22671 from civicrm/5.46
colemanw [Tue, 1 Feb 2022 00:30:12 +0000 (19:30 -0500)]
Merge pull request #22671 from civicrm/5.46

5.46

2 years ago[REF] - Cleanup Contact BAO variables
Coleman Watts [Sun, 23 Jan 2022 22:29:50 +0000 (17:29 -0500)]
[REF] - Cleanup Contact BAO variables

2 years agoMerge pull request #22619 from demeritcowboy/wrong-tz
Seamus Lee [Mon, 31 Jan 2022 22:37:20 +0000 (09:37 +1100)]
Merge pull request #22619 from demeritcowboy/wrong-tz

dev/core#2122 - Manage event online registration page doesn't determine timezone correctly

2 years agoMerge pull request #22670 from agh1/5.46.0-releasenotes-initial
Seamus Lee [Mon, 31 Jan 2022 22:09:59 +0000 (09:09 +1100)]
Merge pull request #22670 from agh1/5.46.0-releasenotes-initial

5.46.0 release notes initial run

2 years agoMerge pull request #22538 from masetto/pdfletter
Eileen McNaughton [Mon, 31 Jan 2022 22:04:23 +0000 (11:04 +1300)]
Merge pull request #22538 from masetto/pdfletter

add `contact_id` to email params in `emailLetter` function

2 years agoAvoid PHP notices on activity form
Bradley Taylor [Sun, 30 Jan 2022 10:44:07 +0000 (10:44 +0000)]
Avoid PHP notices on activity form

2 years ago5.46.0 release notes: added boilerplate
Andie Hunt [Mon, 31 Jan 2022 16:38:18 +0000 (11:38 -0500)]
5.46.0 release notes: added boilerplate

2 years ago5.46.0 release notes: initial run
Andie Hunt [Mon, 31 Jan 2022 16:29:20 +0000 (11:29 -0500)]
5.46.0 release notes: initial run

2 years agoMerge pull request #22587 from colemanw/apiNull
Monish Deb [Mon, 31 Jan 2022 15:10:16 +0000 (20:40 +0530)]
Merge pull request #22587 from colemanw/apiNull

APIv4 - Use empty string instead of 'null' to pass null values to the db

2 years agoMerge pull request #22634 from eileenmcnaughton/pre_message
Yashodha Chaku [Mon, 31 Jan 2022 13:38:02 +0000 (19:08 +0530)]
Merge pull request #22634 from eileenmcnaughton/pre_message

dev/core#2866 add pre-upgrade warning

2 years agoMerge pull request #22652 from civicrm/5.46
demeritcowboy [Mon, 31 Jan 2022 05:34:00 +0000 (00:34 -0500)]
Merge pull request #22652 from civicrm/5.46

5.46

2 years agoMerge pull request #22669 from agileware/CIVICRM-1921
demeritcowboy [Mon, 31 Jan 2022 05:32:32 +0000 (00:32 -0500)]
Merge pull request #22669 from agileware/CIVICRM-1921

CiviCRM Event, the link to "On-line Registration (Test Drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agoMerge pull request #22668 from braders/profile-preview-template-formatting
colemanw [Sun, 30 Jan 2022 20:32:56 +0000 (15:32 -0500)]
Merge pull request #22668 from braders/profile-preview-template-formatting

[REF] Tidy up group.tpl

2 years agoTidy up group.tpl
Bradley Taylor [Sun, 30 Jan 2022 16:44:59 +0000 (16:44 +0000)]
Tidy up group.tpl

This rationalises the indentation, and removes an extra closing </div> which was causing issues in some contexts.

2 years agoMerge pull request #22653 from colemanw/searchKitOperatorFixes
colemanw [Sat, 29 Jan 2022 21:38:38 +0000 (16:38 -0500)]
Merge pull request #22653 from colemanw/searchKitOperatorFixes

SearchKit - Fix selecting operators and values in clauses

2 years agoMerge pull request #22663 from braders/manage-event-listing-default-values
colemanw [Sat, 29 Jan 2022 21:13:37 +0000 (16:13 -0500)]
Merge pull request #22663 from braders/manage-event-listing-default-values

Set default values to avoid notices when rendering (event templates screen)

2 years agoMerge pull request #22660 from braders/membership-dashboard-smarty-notices
colemanw [Sat, 29 Jan 2022 18:35:44 +0000 (13:35 -0500)]
Merge pull request #22660 from braders/membership-dashboard-smarty-notices

Fix smarty notices in membership dashboard

2 years agoMerge pull request #22661 from braders/contributionpage-php-notice
colemanw [Sat, 29 Jan 2022 18:35:21 +0000 (13:35 -0500)]
Merge pull request #22661 from braders/contributionpage-php-notice

Avoid PHP notice on 'Manage Contribution Pages' screen

2 years agoSet default values to avoid notices when rendering
Bradley Taylor [Sat, 29 Jan 2022 18:25:42 +0000 (18:25 +0000)]
Set default values to avoid notices when rendering

2 years agoAPIv4 - Rename 'SoftDelete' trait => 'SoftDeleteEntity'
Coleman Watts [Sat, 29 Jan 2022 16:25:20 +0000 (11:25 -0500)]
APIv4 - Rename 'SoftDelete' trait => 'SoftDeleteEntity'

2 years agoAvoid PHP notice on 'Manage Contribution Pages' screen
Bradley Taylor [Sat, 29 Jan 2022 15:54:19 +0000 (15:54 +0000)]
Avoid PHP notice on 'Manage Contribution Pages' screen

2 years agoFix smarty notices in membership dashboard
Bradley Taylor [Sat, 29 Jan 2022 12:14:18 +0000 (12:14 +0000)]
Fix smarty notices in membership dashboard

2 years agoMerge pull request #22658 from braders/phpdoc-fixes-3
colemanw [Sat, 29 Jan 2022 15:14:30 +0000 (10:14 -0500)]
Merge pull request #22658 from braders/phpdoc-fixes-3

Another set of PHPdoc corrections

2 years agoMerge pull request #22659 from braders/const-type-hints
colemanw [Sat, 29 Jan 2022 15:12:49 +0000 (10:12 -0500)]
Merge pull request #22659 from braders/const-type-hints

Correctly document types for class consts

2 years agoAnother set of PHPdoc corrections
Bradley Taylor [Sat, 29 Jan 2022 11:46:55 +0000 (11:46 +0000)]
Another set of PHPdoc corrections

2 years agoCorrectly document types for class consts
Bradley Taylor [Sat, 29 Jan 2022 11:56:12 +0000 (11:56 +0000)]
Correctly document types for class consts

2 years ago(NFC) QueueTest - Extra cleanups and assertions.
Tim Otten [Sat, 29 Jan 2022 06:34:46 +0000 (22:34 -0800)]
(NFC) QueueTest - Extra cleanups and assertions.

2 years ago(NFC) CRM_Queue_Service - Fix docblock examples
Tim Otten [Sat, 29 Jan 2022 06:06:18 +0000 (22:06 -0800)]
(NFC) CRM_Queue_Service - Fix docblock examples

2 years agoMerge pull request #22656 from seamuslee001/5.46
Seamus Lee [Fri, 28 Jan 2022 23:30:54 +0000 (10:30 +1100)]
Merge pull request #22656 from seamuslee001/5.46

5.45.1 & 5.45.2 Release Notes

2 years agoAdd release-notes/5.45.2.md
Tim Otten [Fri, 28 Jan 2022 23:23:05 +0000 (15:23 -0800)]
Add release-notes/5.45.2.md

2 years agoAdd release-notes/5.45.1.md
Tim Otten [Tue, 11 Jan 2022 19:34:54 +0000 (11:34 -0800)]
Add release-notes/5.45.1.md

2 years agoSearchKit - Fix selecting operators and values in clauses
Coleman Watts [Fri, 28 Jan 2022 14:54:34 +0000 (09:54 -0500)]
SearchKit - Fix selecting operators and values in clauses

Fixes dev/core#3046 which was caused by incomplete refactoring in
https://github.com/civicrm/civicrm-core/pull/22604

2 years agoMerge pull request #22358 from colemanw/searchKitNotNull
colemanw [Fri, 28 Jan 2022 15:13:32 +0000 (10:13 -0500)]
Merge pull request #22358 from colemanw/searchKitNotNull

SearchKit - Improve editable UX by not allowing required fields to be left blank

2 years agoMerge pull request #22650 from totten/5.46-greeting
demeritcowboy [Fri, 28 Jan 2022 14:46:26 +0000 (09:46 -0500)]
Merge pull request #22650 from totten/5.46-greeting

dev/core#3028 - For invalid greetings, return '' instead of failing

2 years agoCIVICRM-1921 Event, the link to "On-line Registration (Test Drive)" is an admin-only...
Justin Freeman [Fri, 28 Jan 2022 06:48:40 +0000 (17:48 +1100)]
CIVICRM-1921 Event, the link to "On-line Registration (Test Drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agodev/core#3028 - For invalid greetings, return '' instead of failing
Eileen McNaughton [Fri, 28 Jan 2022 05:58:07 +0000 (21:58 -0800)]
dev/core#3028 - For invalid greetings, return '' instead of failing

2 years agoMerge pull request #22649 from colemanw/api4CustomDateFormat
colemanw [Fri, 28 Jan 2022 03:36:26 +0000 (22:36 -0500)]
Merge pull request #22649 from colemanw/api4CustomDateFormat

APIv4 - Correctly return date-only custom field values without the time

2 years agoAPIv4 - Correctly return date-only custom field values without the time
Coleman Watts [Fri, 28 Jan 2022 01:23:33 +0000 (20:23 -0500)]
APIv4 - Correctly return date-only custom field values without the time

2 years agoAPIv4 - Deprecate and stop using PreSaveSubscriber
Coleman Watts [Thu, 27 Jan 2022 21:09:08 +0000 (16:09 -0500)]
APIv4 - Deprecate and stop using PreSaveSubscriber

The PreSaveSubscriber allowed APIs to tweak inputs before saving a record,
but it was unreliable because:
- It would run for Create and Update but not Save actions
- It would run before pseudoconstant suffixes had been resolved
- It would run before any formatting or internal processing had taken place

Meanwhile, a new pattern of overriding the create/save/update actions and sharing a trait
has become more common and while a bit more cumbersome to implement, it does not share
those limitations.

This removes all uses of PreSaveSubscriber, refactors those bits into Save traits, and
adds a deprecation warning in case any extension in the Universe happens to have implemented it.

2 years agoMerge pull request #22646 from braders/feature/tasktrait-issingle-docblock
Eileen McNaughton [Thu, 27 Jan 2022 21:44:51 +0000 (10:44 +1300)]
Merge pull request #22646 from braders/feature/tasktrait-issingle-docblock

Resolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait

2 years agoMerge pull request #22645 from demeritcowboy/event-default-tz
Eileen McNaughton [Thu, 27 Jan 2022 21:44:22 +0000 (10:44 +1300)]
Merge pull request #22645 from demeritcowboy/event-default-tz

dev/core#2122 - Add an event timezone for sample data

2 years agoMerge pull request #22644 from demeritcowboy/fix-add-version
Seamus Lee [Thu, 27 Jan 2022 20:42:03 +0000 (07:42 +1100)]
Merge pull request #22644 from demeritcowboy/fix-add-version

dev/core#2122 - Fix "add" version for event timezone dao field

2 years agotranslation#38 - test for multilingual custom fields
Jon Goldberg [Fri, 2 Jul 2021 19:48:08 +0000 (15:48 -0400)]
translation#38 - test for multilingual custom fields

2 years agodev/translation#38 Fix multilingual triggers for when fields default to an empty...
Mathieu Lutfy [Thu, 27 Jan 2022 20:00:01 +0000 (15:00 -0500)]
dev/translation#38 Fix multilingual triggers for when fields default to an empty string

2 years agoResolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait
Bradley Taylor [Thu, 27 Jan 2022 19:42:42 +0000 (19:42 +0000)]
Resolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait

2 years agodefault event timezone for sample data
demeritcowboy [Thu, 27 Jan 2022 19:19:42 +0000 (14:19 -0500)]
default event timezone for sample data

2 years agofix add version
demeritcowboy [Thu, 27 Jan 2022 19:09:11 +0000 (14:09 -0500)]
fix add version

2 years agoManagedEntities - Fix crash during upgrade
Coleman Watts [Thu, 27 Jan 2022 17:19:08 +0000 (12:19 -0500)]
ManagedEntities - Fix crash during upgrade

This prevents a potential crash when trying to update a column before it has been added by the upgrader

Fixes dev/core#3045

2 years agoMerge pull request #22639 from civicrm/5.46
colemanw [Thu, 27 Jan 2022 12:57:33 +0000 (07:57 -0500)]
Merge pull request #22639 from civicrm/5.46

5.46

2 years agoMerge pull request #22640 from totten/5.46-ext-check
colemanw [Thu, 27 Jan 2022 12:22:38 +0000 (07:22 -0500)]
Merge pull request #22640 from totten/5.46-ext-check

Extensions - Add dependency status check

2 years agoMerge pull request #22638 from totten/master-ext-prose
Eileen McNaughton [Thu, 27 Jan 2022 05:32:05 +0000 (18:32 +1300)]
Merge pull request #22638 from totten/master-ext-prose

Extensions - Revise prose for status check

2 years agoExtensions - Revise prose for status check
Tim Otten [Thu, 27 Jan 2022 02:44:10 +0000 (18:44 -0800)]
Extensions - Revise prose for status check

2 years agoExtensions - Add dependency status check
Coleman Watts [Mon, 10 Jan 2022 22:48:03 +0000 (17:48 -0500)]
Extensions - Add dependency status check

Adds a system status check to ensure extension dependencies are met

2 years agoMerge pull request #22623 from colemanw/extensionUpgrades
Tim Otten [Thu, 27 Jan 2022 04:52:25 +0000 (20:52 -0800)]
Merge pull request #22623 from colemanw/extensionUpgrades

ExtensionUpgrades - Skip trying to upgrade missing dependencies

2 years agoExtensions - Revise prose for status check
Tim Otten [Thu, 27 Jan 2022 02:44:10 +0000 (18:44 -0800)]
Extensions - Revise prose for status check

2 years agoExtensionUpgrades - Skip trying to upgrade missing dependencies
Coleman Watts [Tue, 25 Jan 2022 16:54:40 +0000 (11:54 -0500)]
ExtensionUpgrades - Skip trying to upgrade missing dependencies

Before: Missing dependencies would be added and then the extension upgrader would try and fail to upgrade them
After: They are skipped, as missing extension dependencies are handled elsewhere

This allows the extension upgrade to proceed without error, even if there are missing dependencies.
The user will be prompted to install the missing dependencies afterward.

2 years agoMerge pull request #22626 from colemanw/readOnlyRename
Eileen McNaughton [Thu, 27 Jan 2022 00:59:32 +0000 (13:59 +1300)]
Merge pull request #22626 from colemanw/readOnlyRename

APIv4 - Rename 'ReadOnly' trait to 'ReadOnlyEntity' to avoid PHP error

2 years agoMerge pull request #22631 from braders/calculateBaseScheduleDate-docblock
Eileen McNaughton [Thu, 27 Jan 2022 00:46:45 +0000 (13:46 +1300)]
Merge pull request #22631 from braders/calculateBaseScheduleDate-docblock

Fix inaccuracy in docblock for method calculateBaseScheduleDate

2 years agodev/core#2866 add pre-upgrade warning
Eileen McNaughton [Thu, 27 Jan 2022 00:01:04 +0000 (13:01 +1300)]
dev/core#2866 add pre-upgrade warning

2 years agoMerge pull request #22629 from braders/attachmentInfo-docblock
Seamus Lee [Wed, 26 Jan 2022 22:27:51 +0000 (09:27 +1100)]
Merge pull request #22629 from braders/attachmentInfo-docblock

Resolve inaccuracies in CRM_Core_BAO_File::attachmentInfo docblock

2 years agoMerge pull request #22601 from braders/set-print-functions-tidy
Eileen McNaughton [Wed, 26 Jan 2022 22:02:22 +0000 (11:02 +1300)]
Merge pull request #22601 from braders/set-print-functions-tidy

Tidy up functions related to printing.

2 years agoFix inaccuracy in docblock for method calculateBaseScheduleDate
Bradley Taylor [Wed, 26 Jan 2022 21:57:22 +0000 (21:57 +0000)]
Fix inaccuracy in docblock for method calculateBaseScheduleDate

2 years agoResolve inaccuracies in CRM_Core_BAO_File::attachmentInfo docblock
Bradley Taylor [Wed, 26 Jan 2022 20:24:20 +0000 (20:24 +0000)]
Resolve inaccuracies in CRM_Core_BAO_File::attachmentInfo docblock

2 years agoTidy up functions related to printing.
Bradley Taylor [Sat, 22 Jan 2022 12:04:54 +0000 (12:04 +0000)]
Tidy up functions related to printing.

Calls to setPrint updated to use constant,
and inline documentation updated to reflect the values which are actually expected.

setWord and setExcel methods deprectated as they are not in use,
and they only support the older Microsoft Office formats (doc, not docx)

2 years agoMerge pull request #22625 from eileenmcnaughton/comp
colemanw [Wed, 26 Jan 2022 15:18:59 +0000 (10:18 -0500)]
Merge pull request #22625 from eileenmcnaughton/comp

Do not pass in tablename

2 years agoAPIv4 - Add `nullable` property to getFields; improve SearchKit editable UX
Coleman Watts [Mon, 3 Jan 2022 16:48:37 +0000 (11:48 -0500)]
APIv4 - Add `nullable` property to getFields; improve SearchKit editable UX

Unlike the 'required' field property, which only determines if the API requires a value to Create,
the 'nullable' property tells a UI whether a field is allowed to be set to NULL in Create OR Update.

SearchKit uses this property during in-place edit and bulk edit operations to determine whether a
field can be left blank.

2 years agoMerge pull request #22627 from eileenmcnaughton/config
colemanw [Wed, 26 Jan 2022 14:31:20 +0000 (09:31 -0500)]
Merge pull request #22627 from eileenmcnaughton/config

Remove deprecated language construct

2 years agoAPIv4 - Rename 'ReadOnly' trait to 'ReadOnlyEntity' to avoid PHP fatal error
Coleman Watts [Wed, 26 Jan 2022 02:10:34 +0000 (21:10 -0500)]
APIv4 - Rename 'ReadOnly' trait to 'ReadOnlyEntity' to avoid PHP fatal error

Fixes dev/core#3043
The word 'readonly' is reserved as of php 8.1

2 years agoRemove deprecated language construct
Eileen McNaughton [Wed, 26 Jan 2022 05:10:04 +0000 (18:10 +1300)]
Remove deprecated language construct

Per https://github.com/totten/civix/pull/235 this language construct
appears to be getting more noisy about being bad....