Coleman Watts [Tue, 12 Feb 2019 16:12:34 +0000 (11:12 -0500)]
Bump minimum upgradable ver to 4.2.9
Eileen McNaughton [Tue, 12 Feb 2019 02:23:48 +0000 (15:23 +1300)]
Merge pull request #13576 from civicrm/5.11
5.11 to master
Eileen McNaughton [Tue, 12 Feb 2019 02:23:03 +0000 (15:23 +1300)]
Merge pull request #13575 from seamuslee001/5_10_1_release_notes_11
Release notes for 5.10.1 release
Seamus Lee [Mon, 11 Feb 2019 22:46:38 +0000 (09:46 +1100)]
Merge pull request #13572 from eileenmcnaughton/cc_511
Fix regression whereby making receive_date required breaks back offic…
Seamus Lee [Mon, 11 Feb 2019 21:09:03 +0000 (08:09 +1100)]
Release notes for 5.10.1 release
Eileen McNaughton [Mon, 11 Feb 2019 20:50:13 +0000 (09:50 +1300)]
Merge pull request #13564 from seamuslee001/remove_free_campaign_case
Remove hurty free calls from campaign and case
eileen [Mon, 11 Feb 2019 20:16:22 +0000 (09:16 +1300)]
Fix regression whereby making receive_date required breaks back office cc
Regression from https://lab.civicrm.org/dev/core/issues/680
led to https://civicrm.stackexchange.com/questions/28410/unable-to-take-credit-card-payment-after-civi-update
colemanw [Mon, 11 Feb 2019 16:56:33 +0000 (11:56 -0500)]
Merge pull request #13569 from colemanw/Fix
Fix contact ID help on advanced search
Coleman Watts [Mon, 11 Feb 2019 14:42:06 +0000 (09:42 -0500)]
Fix contact ID help on advanced search
Seamus Lee [Mon, 11 Feb 2019 07:48:39 +0000 (18:48 +1100)]
Remove hurty free calls from campaign and case
Seamus Lee [Mon, 11 Feb 2019 07:46:51 +0000 (18:46 +1100)]
Merge pull request #13558 from eileenmcnaughton/balance_test
Add unit test on getContributionBalance fn (#13187)
Seamus Lee [Mon, 11 Feb 2019 05:57:17 +0000 (16:57 +1100)]
Merge pull request #13560 from seamuslee001/free_activity_member
dev/core#562 Remove free calls from Activity and Member sections of CRM
Eileen McNaughton [Mon, 11 Feb 2019 05:30:19 +0000 (18:30 +1300)]
Merge pull request #13327 from pradpnayak/SerarchView
Used buildoptions function to get all groups
Eileen McNaughton [Mon, 11 Feb 2019 05:11:15 +0000 (18:11 +1300)]
Merge pull request #13404 from pradpnayak/ReportActions
Show Add to group on create new report after refresh of result
eileen [Mon, 11 Feb 2019 04:27:59 +0000 (17:27 +1300)]
Add unit test on getContributionBalance fn (#13187)
Seamus Lee [Mon, 11 Feb 2019 01:20:11 +0000 (12:20 +1100)]
Remove free calls from Activity and Member sections of CRM
Eileen McNaughton [Mon, 11 Feb 2019 00:49:16 +0000 (13:49 +1300)]
Merge pull request #13287 from mattwire/eventregister_rename
(REF) Rename variables and adjust variable definitions for Event Register form
Eileen McNaughton [Sun, 10 Feb 2019 22:14:42 +0000 (11:14 +1300)]
Merge pull request #13187 from JMAConsulting/payment_function
Optimize CRM_Core_BAO_FinancialTrxn::getTotalPayment
colemanw [Sat, 9 Feb 2019 05:26:12 +0000 (00:26 -0500)]
Merge pull request #13555 from colemanw/loadScript
CRM.loadScript improvements
Coleman Watts [Sat, 9 Feb 2019 02:54:40 +0000 (21:54 -0500)]
Add angular util crmLoadScript
Coleman Watts [Sat, 9 Feb 2019 02:54:20 +0000 (21:54 -0500)]
Append cache-buster to dynamically loaded scripts
Seamus Lee [Fri, 8 Feb 2019 03:52:22 +0000 (14:52 +1100)]
Merge pull request #13549 from pradpnayak/Qfill
dev/core/issues/700, Show Qill when searched using contact id
colemanw [Thu, 7 Feb 2019 21:48:24 +0000 (16:48 -0500)]
Merge pull request #13333 from mattwire/buttons_submitOnce
Make submitOnce() button js into a button parameter
Monish Deb [Thu, 7 Feb 2019 13:34:26 +0000 (19:04 +0530)]
Merge pull request #13529 from greenpeace-cee/fix-api-entity-permission
dev/core#690 - Civi\API - Fix entity permission check for trusted calls
CiviCRM [Thu, 7 Feb 2019 01:49:22 +0000 (01:49 +0000)]
Set version to 5.12.alpha1
CiviCRM [Thu, 7 Feb 2019 01:44:56 +0000 (01:44 +0000)]
Set version to 5.11.beta1
Tim Otten [Thu, 7 Feb 2019 01:40:32 +0000 (20:40 -0500)]
Merge pull request #13552 from seamuslee001/master
Update 5.10.0.md
Tim Otten [Thu, 7 Feb 2019 00:30:09 +0000 (19:30 -0500)]
Update 5.10.0.md
Seamus Lee [Wed, 6 Feb 2019 22:10:40 +0000 (09:10 +1100)]
Merge pull request #13550 from civicrm/5.10
5.10
Seamus Lee [Wed, 6 Feb 2019 20:47:11 +0000 (12:47 -0800)]
Merge pull request #13494 from agh1/5.10.0-releasenotes
5.10.0 release notes
colemanw [Wed, 6 Feb 2019 18:01:47 +0000 (13:01 -0500)]
Merge pull request #13544 from pradpnayak/ContactImage
core/issues/698, send correct MIME type for .jpg files
Pradeep Nayak [Wed, 6 Feb 2019 17:50:15 +0000 (17:50 +0000)]
dev/core/issues/700, Show Qill when searched using contact id
Andrew Hunt [Wed, 6 Feb 2019 14:49:40 +0000 (09:49 -0500)]
5.10.0 release notes: late changes, credits, and last-minute fixes
Tim Otten [Wed, 16 Jan 2019 22:12:16 +0000 (14:12 -0800)]
Add release-notes/5.9.1.md
Alice Frumin [Wed, 6 Feb 2019 14:29:08 +0000 (09:29 -0500)]
5.10.0 release notes: bulk of edits
* pulling out misc and organizing lines with gitlab issue numbers
* linking to gitlab issues
* update lines with gitlab issues to have the gitlab titles
* progress
* second pass
* finished first pass of notes
* deleting rows related to merge
* reorganizing sections
Andrew Hunt [Tue, 22 Jan 2019 19:05:14 +0000 (14:05 -0500)]
5.10.0 release notes: added boilerplate
Andrew Hunt [Tue, 22 Jan 2019 19:01:53 +0000 (14:01 -0500)]
5.10.0 release notes: raw from script
Eileen McNaughton [Wed, 6 Feb 2019 04:19:03 +0000 (17:19 +1300)]
Merge pull request #13548 from civicrm/5.10
5.10 to master
Monish Deb [Wed, 6 Feb 2019 04:16:32 +0000 (09:46 +0530)]
Merge pull request #13536 from eileenmcnaughton/export_sc
dev/core#651 Fix group by on export soft credits (possible recent regression, clearly wrong).
Eileen McNaughton [Wed, 6 Feb 2019 02:19:44 +0000 (15:19 +1300)]
Merge pull request #13547 from eileenmcnaughton/master
Re-run gencode for fix on PriceField DAO
eileen [Tue, 5 Feb 2019 22:22:03 +0000 (11:22 +1300)]
Re-run gencode for fix on PriceField DAO
Eileen McNaughton [Tue, 5 Feb 2019 21:42:08 +0000 (10:42 +1300)]
Merge pull request #13546 from civicrm/5.10
5.10 to master
Pradeep Nayak [Tue, 5 Feb 2019 19:40:36 +0000 (19:40 +0000)]
Added few more mime type that needs over-ride
Eileen McNaughton [Tue, 5 Feb 2019 20:27:39 +0000 (09:27 +1300)]
Merge pull request #13403 from pradpnayak/FieldLength
Donot allow to enter more than max length of the field
eileen [Tue, 5 Feb 2019 06:04:21 +0000 (19:04 +1300)]
dev/core#651 Fix group by on export soft credits (possible recent regression, clearly wrong).
As pointed out by the reporter the group by is being calculated as if it were a string but it's an array, this fixes.
This code has been touched recently so it might be a recent regression. 5.10 is the first release in a long time where
export is working in some mysql / output configs after a big refactor to get rid of wide temp tables
Pradeep Nayak [Tue, 5 Feb 2019 18:06:44 +0000 (18:06 +0000)]
core/issues/698, send correct MIME type for .jpg files
Patrick Figel [Tue, 5 Feb 2019 17:04:07 +0000 (18:04 +0100)]
dev/core#690 - Civi\API - Add a check on entity_table existing
This adds a check in DynamicFKAuthorization to verify that the
entity_table in the API request actually exists as a table.
Additionally, this changes a test case in api_v3_AttachmentTest to
enable permission checking. This is necessary because the change to
DynamicFKAuthorization means trusted API calls can now attach files
to *any* entity unless check_permissions is set, in which case it's
only possible for allowed delegates.
Patrick Figel [Tue, 5 Feb 2019 16:58:15 +0000 (17:58 +0100)]
CRM/Core - Fix isCoreTable to check for tables instead of classes
This fixes CRM_Core_DAO_AllCoreTables::isCoreTable to check for the
existence of tables instead of DAO classes. The method is used only
once in core, and the intention there is to look for table names,
so there should not be much risk of breakage.
Pradeep Nayak [Tue, 5 Feb 2019 16:14:33 +0000 (16:14 +0000)]
Use addField to generated form fields on Note form
Monish Deb [Tue, 5 Feb 2019 13:51:09 +0000 (19:21 +0530)]
Merge pull request #13537 from eileenmcnaughton/cont_comp
dev/core#680 make receive_date required on backoffice contribution form
Monish Deb [Tue, 5 Feb 2019 13:50:19 +0000 (19:20 +0530)]
Merge pull request #13390 from MegaphoneJon/core-609
fixes core#609 - view 'Advanced Search' links without 'view all conta…
eileen [Tue, 5 Feb 2019 08:07:16 +0000 (21:07 +1300)]
dev/core#680 make receive_date required on backoffice contribution form
and api
Discussion on https://lab.civicrm.org/dev/core/issues/680#note_13205
Eileen McNaughton [Tue, 5 Feb 2019 04:19:10 +0000 (17:19 +1300)]
Merge pull request #13535 from civicrm/5.10
5.10 to master
Eileen McNaughton [Tue, 5 Feb 2019 04:18:40 +0000 (17:18 +1300)]
Merge pull request #13533 from eileenmcnaughton/prev_next
Prev next
eileen [Tue, 5 Feb 2019 01:58:53 +0000 (14:58 +1300)]
Disable full group by mode whe groupContacts is TRUE
This prevents an error when using the cache and allows us to move
past this without untangling the messy way other tables are joined back in
for now.
Note it became necessary due to query changes off the cache but the query is no
different in accuracy
Aidan Saunders [Mon, 4 Feb 2019 17:50:30 +0000 (17:50 +0000)]
dev/core#695 - Make custom searches slightly less fragile
eileen [Mon, 4 Feb 2019 23:59:51 +0000 (12:59 +1300)]
dev/core#679 fix loss of search results when including tags or groups.
The bug as described was a bit tricksy to replicate as it is inconsistent and the
code is not actually outputting the tags/ groups. I think these are pre-existing issues
I was able to replicate by having 2 search profiles - one with only tags & one one with only groups & switching back & and force on output - once I replicated I found that there was a regression due to
https://github.com/eileenmcnaughton/civicrm-core/commit/
2ca46d4d5a8cd15929ac0939ca2bb380a3de027e#diff-e54381bfdf51e31cab376c71ca0d66ffR4967
whereby the groupBy had been dropped, causing the results to be squashed into a single row
Eileen McNaughton [Mon, 4 Feb 2019 23:55:21 +0000 (12:55 +1300)]
Merge pull request #12834 from pradpnayak/preRelHook
Respect pre hook for relationship to alter id in $params
Eileen McNaughton [Mon, 4 Feb 2019 23:53:11 +0000 (12:53 +1300)]
Merge pull request #13526 from yashodha/number_widget
use number widget for weight and other numeric fields in more forms
Eileen McNaughton [Mon, 4 Feb 2019 23:52:29 +0000 (12:52 +1300)]
Merge pull request #13530 from pradpnayak/FieldLength-Activity
Used field name defined in DAO file for Activity Subject
Eileen McNaughton [Mon, 4 Feb 2019 23:52:07 +0000 (12:52 +1300)]
Merge pull request #13532 from pradpnayak/xmlChanges
Add html type for civicrm_note.privacy field
Eileen McNaughton [Mon, 4 Feb 2019 23:51:31 +0000 (12:51 +1300)]
Merge pull request #13489 from totten/master-ro-cache
(dev/core#635) Deprecate CRM_Core_BAO_Cache for I/O. Optionally redirect I/O to Redis or Memcache.
colemanw [Mon, 4 Feb 2019 22:03:13 +0000 (17:03 -0500)]
Merge pull request #13522 from eileenmcnaughton/activity
Performance fix for alternate getActivity listing function
colemanw [Mon, 4 Feb 2019 21:38:42 +0000 (16:38 -0500)]
Remove redundant css class from activity subject field
This is now being automatically assigned thanks to the change in
6e9c7c7
colemanw [Mon, 4 Feb 2019 21:33:45 +0000 (16:33 -0500)]
Merge pull request #13527 from JMAConsulting/core-693
dev/core#693 : On contact summary page, on submitting a 'New Case' form doesn't redirect to 'Manage Case' screen
Tim Otten [Mon, 4 Feb 2019 21:27:09 +0000 (16:27 -0500)]
CRM_Core_BAO_Cache - When delegating to an adapter, don't expect it to return a reference
This is following up on the code-review comments from
https://github.com/civicrm/civicrm-core/pull/13489#discussion_r252070543
Pradeep Nayak [Mon, 4 Feb 2019 21:04:56 +0000 (21:04 +0000)]
use name and label to retrive ID
Eileen McNaughton [Mon, 4 Feb 2019 20:19:44 +0000 (09:19 +1300)]
Merge pull request #13525 from civicrm/5.10
5.10
Pradeep Nayak [Mon, 4 Feb 2019 19:33:39 +0000 (19:33 +0000)]
Add html type for civicrm_note.privacy field
Pradeep Nayak [Mon, 4 Feb 2019 18:43:24 +0000 (18:43 +0000)]
Donot show group until refresh result
Pradeep Nayak [Fri, 4 Jan 2019 12:56:59 +0000 (12:56 +0000)]
Added api test to support fix
Pradeep Nayak [Wed, 19 Dec 2018 23:55:30 +0000 (23:55 +0000)]
Used buildoptions function to get all groups
Pradeep Nayak [Mon, 4 Feb 2019 16:33:21 +0000 (16:33 +0000)]
Used field name defined in DAO file for Activity Subject
Patrick Figel [Mon, 4 Feb 2019 15:00:03 +0000 (16:00 +0100)]
dev/core#690 - Civi\API - Fix entity permission check for trusted calls
This changes the permission check in DynamicFKAuthorization to
short-circuit on trusted API calls (check_permissions = 0) so that
no exception is thrown when it's used with entities that are not
allowed delegates.
Monish Deb [Mon, 4 Feb 2019 08:42:46 +0000 (14:12 +0530)]
dev/core#693 : On contact summary page, on submitting a 'New Case' form doesn't redirect to 'Manage Case' screen
yashodha [Mon, 4 Feb 2019 08:23:59 +0000 (13:53 +0530)]
use number widget for weight fields in more forms
Seamus Lee [Mon, 4 Feb 2019 07:37:07 +0000 (23:37 -0800)]
Merge pull request #13524 from eileenmcnaughton/search_rc
Revert fix causing unreleased regression
eileen [Mon, 4 Feb 2019 05:03:49 +0000 (18:03 +1300)]
Revert "Assign the translated formValues to itself"
This reverts commit
e8ef090642f0ff5639166b847a31f4e50eec3dd6.
eileen [Mon, 4 Feb 2019 04:39:41 +0000 (17:39 +1300)]
Revert "Rewrite testHiddenSmartGroup"
This reverts commit
7810fa53a7f5d8be82ebda7fde122d0fd349d358.
eileen [Mon, 4 Feb 2019 00:10:44 +0000 (13:10 +1300)]
Performance fix for alternate getActivity listing function
We have an alternate function to render the activiy listing on the contact tab. It is
getActivities whereas the other is deprecatedGetActivities.
It was developed in order to replace the other and we have tests that compare the results of the 2. It is better in that it
1) performs better (on a WMF contact with many activities this is 'snappy' while the current deprecated one gives a white screen time out) and
2) calls the selectWhereClause hook, allowing hook alteration and respecting preferred architecture.
However, we didn't go live with it in core because it
1) has a remnant performance bugs (this PR fixes the last of these)
2) implements ACLs differently - it uses generic functions whereas the deprecated one
applies more limited permissioning. This is something to clarify & resolve separately.
This PR fixes the last remaining performance issue - best described as
'When one of the activities to be displayed has many targets the activity listing is slow to load'
The reason for the slowness is that when 'target_contact_name' is passed to the api
the api does a call for each contact to fetch the contact's sort_name. For a bulk mailing that went to 50,000 people that equates to 50,000 extra queries.
However the actual display shows the first contact name and then gives a number for how many more should be retrieved. This PR hence does not ask the api for the display name, but rather does the check itself, but
only for 1 target contact rather than ALL
Note that a similar logic might be considered for assignee - I left that out of scope as I'm not
aware of situations where a large number of assignees would be assigned to a single activity.
The unit test ensures the output matches the deprecated function.
Eileen McNaughton [Fri, 1 Feb 2019 20:10:31 +0000 (09:10 +1300)]
Merge pull request #13401 from PeaceWorksTechnologySolutions/master
dev/mail#32 - Further checks - making mailing test email non-case-sensitive
Monish Deb [Fri, 30 Nov 2018 09:39:40 +0000 (15:09 +0530)]
Optimize CRM_Core_BAO_FinancialTrxn::getTotalPayment
Martin [Fri, 4 Jan 2019 15:49:08 +0000 (10:49 -0500)]
Merge pull request #1 from civicrm/master
Update master from upstream
colemanw [Fri, 1 Feb 2019 12:37:18 +0000 (07:37 -0500)]
Merge pull request #13520 from yashodha/number_widget
use number widget for weight fields in all forms
yashodha [Fri, 1 Feb 2019 10:01:28 +0000 (15:31 +0530)]
use number wiget for weight fields in all forms
Eileen McNaughton [Fri, 1 Feb 2019 00:59:49 +0000 (13:59 +1300)]
Merge pull request #13518 from colemanw/l10n.js
l10n.js - Reload when logging in as new user
Seamus Lee [Thu, 31 Jan 2019 22:36:26 +0000 (14:36 -0800)]
Merge pull request #13498 from francescbassas/patch-18
dev/core#682 Add basic contact filters to Summary Contributions Report
Coleman Watts [Thu, 31 Jan 2019 19:30:43 +0000 (14:30 -0500)]
l10n.js - Reload when logging in as new user
colemanw [Thu, 31 Jan 2019 19:05:19 +0000 (14:05 -0500)]
Merge pull request #13507 from twomice/lab686_membership_stats_columns
Fix for dev/core#686: Make "amount statistics" columns optional
colemanw [Thu, 31 Jan 2019 18:39:20 +0000 (13:39 -0500)]
Merge pull request #13502 from colemanw/shortcode
Fix shortcode button when popup setting is disabled
colemanw [Thu, 31 Jan 2019 15:03:49 +0000 (10:03 -0500)]
Merge pull request #13488 from colemanw/helpOverride
Allow help text to be overridden from an .extra.hlp file
Eileen McNaughton [Thu, 31 Jan 2019 01:23:58 +0000 (14:23 +1300)]
Merge pull request #13506 from colemanw/profileCreate
Fix permission checks on contact create popups
Joe Murray [Wed, 30 Jan 2019 21:37:25 +0000 (16:37 -0500)]
Merge pull request #13512 from eileenmcnaughton/cont_annual_speed
Speed up loading of contribution tab on contacts with large number of contributions in a large database
Eileen McNaughton [Wed, 30 Jan 2019 20:25:56 +0000 (09:25 +1300)]
Merge pull request #13513 from colemanw/Fix
Fix undefined throwing error in CRM.checkPerm
Eileen McNaughton [Wed, 30 Jan 2019 20:24:56 +0000 (09:24 +1300)]
Merge pull request #13514 from totten/master-nack-rev
(dev/core#635) CRM_Utils_Cache::nack() - Fix format
Tim Otten [Wed, 30 Jan 2019 07:42:06 +0000 (23:42 -0800)]
Merge pull request #13298 from colemanw/extCompat
Add extension compatibility list
Tim Otten [Wed, 30 Jan 2019 05:08:23 +0000 (21:08 -0800)]
(dev/core#635) CRM_Utils_Cache::nack() - Fix format
This is a follow-up to #13500.
Before
------
* `CRM_Utils_Cache::nack()` returns an array with a value named `nack`.
* The value returned is somewhat unique -- a random value is generated once per page-view.
* There is no explicit/direct unit-test.
After
-----
* `CRM_Utils_Cache::nack()` returns a string.
* The value returned is more unique -- combining that random value (per page-view) and an offset (per invocation).
* There is an explicit/direct unit-test.
Comments
--------
* The code was originally written with the intent of returning a string.
However, there was a slight copy-paste error which caused it to return an
array (which contained that string). Functionally, that worked (because
it was serializable and met the same minimum uniqueness constraint),
but it's weird to read/inspect, and we should change quickly before
something else locks-in the odd structure.
* The more unique the nack-value is, the more correct the nack-checking
pattern is. Appending a static-counter is a simple, fast way to provide
stronger uniqueness within a page-view.
* There may be some obscure edge-cases in which the previous pattern was not
sufficiently unique -- e.g. combining tiers-of-tiers or
decorators-of-decorators. I haven't verified that, but it seems
unimportant given that the static-counter is so straightforward.
* In `NaiveHasTrait`, the extra `ht` suffix was an attempt to increase the
uniquness. However, the static-counter seems better.
Tim Otten [Wed, 30 Jan 2019 03:36:08 +0000 (19:36 -0800)]
CRM_Core_BAO_Cache - Make some IDE's happier about inline assignment
Tim Otten [Thu, 24 Jan 2019 00:11:42 +0000 (16:11 -0800)]
CRM_Core_BAO_Cache - Deprecate getItems(), getItem(), setItem(), deleteGroup()
These interfaces predate PSR-16 -- which is more flexible and complete.
PSR-16 supports TTLs, default-values, multi-key operations, etc. PSR-16
drivers can be extended/decorated/replaced. There are third-party
implementations of PSR-16. And (personally) I find the code which consumes
PSR-16 to be more readable+writeable (e.g. `$cache->get($key)` vs
`CRM_Core_BAO_Cache::getItem($group, $item)`).
However, `CRM_Core_BAO_Cache` has been around forever. I currently count
ten distinct cache-groups which rely on it (5 from `civicrm-core` and 5 from
`universe`). So we shouldn't remove it outright.
Tim Otten [Mon, 21 Jan 2019 11:06:50 +0000 (03:06 -0800)]
Allow rerouting CRM_Core_BAO_Cache::{set,get}Item(s) to PSR-16 drivers
Before
----------------------------------------
* Requests for `CRM_Core_BAO_Cache` (`setItem($data,$group,$path)`,
`getItem($group,$path)`, `getItems($group)`, `deleteGroup($group,$path)`)
are *always* served by two tiers: (1) an in-memory array (`static::$cache`) and (2)
an SQL table.
After
----------------------------------------
* There is a config option `define('CIVICRM_BAO_CACHE_ADAPTER',
'CRM_Core_BAO_Cache_Psr16');`.
* When disabled (default), `CRM_Core_BAO_Cache` continues using the old code.
* When enabled, `CRM_Core_BAO_Cache` changes behavior. Each `$group` is mapped to
a PSR-16 object.
* The class/implementation for each `$group` depends on the configuration:
* In a typical (non-Redis/non-Memcache) deployment, the implementation
is `CRM_Utils_Cache_SqlGroup`, which has the same 2-tier structure
(in-memory+SQL).
* In Redis/Memcache deployment, the implementation combines
`FastArrayDecorator` with `CRM_Utils_Cache_Redis` or
`CRM_Utils_Cache_Memcache`. This gives a similar 2-tier structure
(e.g. in-memory+Redis).