colemanw [Thu, 3 Aug 2023 02:41:25 +0000 (22:41 -0400)]
ScheduledReminders - Rewrite form to use metadata
The complexity of the form lies in the fact that various fields have different meanings depending on the selected mapping type.
For example the entity_value field might mean "Activity Type" or "Financial Account" or "Event Type" or "Event ID". The
entity_status field also refers to different option lists, sometimes dependent on the selection of entity_value and it may or
may not allow multiple values and it may or may not be required.
The form also allows those fields to be pre-selected when embedded on an Event page, and the old Quickform HierSelect widget coped
very poorly with all those scenarios. As a result the form employed a lot of javascript to handle specific hard-coded issues, and
a few bespoke ajax callbacks. None of which worked perfectly.
The postProcess & validate functions employed a sub-function called parseActionSchedule which was doing way too much work:
1. to detangle all the overcomplicated form values
2. preprocessing that really belonged in the BAO
3. to save a field-mapping (alarmingly this was happening during form validation AND postProcess!).
This rewrite moves all of that logic into the BAO and getFields, allowing each mapping-type to set metadata appropriately
(e.g. is a particular field required for this mapping type? does it support multiple values? does it have a different
option list depending on another field selection?). This allowed me to delete the bespoke ajax callbacks and just call
api4.getFields from the form. The new metadata also describes the relationship between fields (so when you update one
field it knows which others to reload).
colemanw [Sun, 30 Jul 2023 22:00:28 +0000 (18:00 -0400)]
ActionMapping - Add icons
colemanw [Sun, 30 Jul 2023 02:59:21 +0000 (22:59 -0400)]
ActionMapping - Use APIv4 SpecProviderInterface to alter metadata for each mapping type
colemanw [Sun, 30 Jul 2023 01:07:43 +0000 (21:07 -0400)]
ActionSchedule - Give every ActionMapping a name
Going forward the name should always match the id in new implementations, but for legacy implementations
the old numeric ids are supported.
colemanw [Sat, 29 Jul 2023 04:15:01 +0000 (00:15 -0400)]
ActionSchedule - Add missing field metadata
colemanw [Thu, 27 Jul 2023 23:17:58 +0000 (19:17 -0400)]
ActionMapping - Add checkAccess method to MappingInterface
colemanw [Mon, 24 Jul 2023 19:44:07 +0000 (15:44 -0400)]
APIv4 - Implement checkAccess for CiviEvent
colemanw [Mon, 24 Jul 2023 15:22:06 +0000 (11:22 -0400)]
ScheduleReminders - Update metadata for 'recipient_listing'
colemanw [Mon, 24 Jul 2023 14:57:14 +0000 (10:57 -0400)]
APIv4 - Consistently pass values into pseudoconstant callback
colemanw [Mon, 24 Jul 2023 14:55:03 +0000 (10:55 -0400)]
ScheduleReminders - Sort options
colemanw [Mon, 24 Jul 2023 14:20:44 +0000 (10:20 -0400)]
ScheduleReminders - Update metadata for 'recipient'
colemanw [Mon, 24 Jul 2023 13:34:11 +0000 (09:34 -0400)]
ScheduleReminders - Update metadata for 'limit_to'
Eileen McNaughton [Thu, 3 Aug 2023 23:56:16 +0000 (11:56 +1200)]
Merge pull request #27002 from eileenmcnaughton/enotice
Enotice fix
Seamus Lee [Thu, 3 Aug 2023 23:26:58 +0000 (19:26 -0400)]
Merge pull request #27001 from eileenmcnaughton/participant_test
E-notice fix
Eileen McNaughton [Thu, 3 Aug 2023 22:48:29 +0000 (10:48 +1200)]
Another e-notice fix
Eileen McNaughton [Thu, 3 Aug 2023 22:22:40 +0000 (10:22 +1200)]
Enotice fix
Seamus Lee [Thu, 3 Aug 2023 22:35:30 +0000 (18:35 -0400)]
Merge pull request #26985 from colemanw/recPHPver
Bump recommended PHP version to 8.1, min recommendation to 8.0
Eileen McNaughton [Thu, 3 Aug 2023 22:34:46 +0000 (10:34 +1200)]
Merge pull request #24657 from larssandergreen/always-show-change-selections-for-participant-view
dev/core/#3361 Add Change Selections button when viewing price set registrations with no contribution associated
Eileen McNaughton [Thu, 3 Aug 2023 22:15:43 +0000 (10:15 +1200)]
E-notice fix
CiviCRM [Thu, 3 Aug 2023 22:06:37 +0000 (22:06 +0000)]
Set version to 5.66.alpha1
CiviCRM [Thu, 3 Aug 2023 22:06:24 +0000 (22:06 +0000)]
Set version to 5.65.beta1
Eileen McNaughton [Thu, 3 Aug 2023 22:05:53 +0000 (10:05 +1200)]
Merge pull request #26303 from larssandergreen/Allow-multiple-registrations-from-search-actions
Allow multiple registrations from search actions
Seamus Lee [Thu, 3 Aug 2023 21:56:59 +0000 (17:56 -0400)]
Merge pull request #26957 from eileenmcnaughton/price_field
Notice fixes on CiviEvent Component settings form
Tim Otten [Thu, 3 Aug 2023 21:18:48 +0000 (14:18 -0700)]
Merge pull request #26999 from totten/master-snapshot-b
5.65.alpha1 - Define pre-upgrade snapshots (Option B)
Eileen McNaughton [Thu, 3 Aug 2023 20:53:14 +0000 (08:53 +1200)]
Merge pull request #26996 from colemanw/adminTitle
[REF] CRM_Admin_Form - Use metadata instead of boilerplate to set page title
Tim Otten [Thu, 3 Aug 2023 08:34:29 +0000 (01:34 -0700)]
5.65.alpha1.mysql.tpl - Add pre-upgrade snapshots for existing upgrade-steps
Tim Otten [Thu, 3 Aug 2023 08:47:39 +0000 (01:47 -0700)]
Smarty SQL - Add helper {crmUpgradeSnapshot}
Tim Otten [Thu, 3 Aug 2023 08:29:09 +0000 (01:29 -0700)]
CRM_Upgrade_Snapshot - Add helper `createSingleTask()`
This is an alternative to `createTasks()`. It's suitable for the kinds of small/mid-sized
queries that appear in `*.mysql.tpl` files.
Tim Otten [Thu, 3 Aug 2023 07:38:39 +0000 (00:38 -0700)]
Upgrader - Supply $upgradeRev for Smarty TPLs
colemanw [Thu, 3 Aug 2023 03:35:32 +0000 (23:35 -0400)]
CRM_Admin_Form - Use metadata instead of boilerplate to set page title
Eileen McNaughton [Wed, 2 Aug 2023 22:45:35 +0000 (10:45 +1200)]
Merge pull request #26854 from colemanw/searchKitLinkPerformance
SearchKit - Improve performance of checking link permissions
Seamus Lee [Wed, 2 Aug 2023 22:18:51 +0000 (18:18 -0400)]
Merge pull request #26992 from civicrm/5.64
5.64
Eileen McNaughton [Wed, 2 Aug 2023 22:13:57 +0000 (10:13 +1200)]
Merge pull request #26840 from colemanw/autocompleteById
Api4 Autocomplete - Search by exact id match more effieciently
Seamus Lee [Wed, 2 Aug 2023 21:53:33 +0000 (17:53 -0400)]
Merge pull request #26990 from larssandergreen/Fix-price-field-url-regression
dev/core#4469 - Fix price set field path regression
Seamus Lee [Wed, 2 Aug 2023 21:51:45 +0000 (17:51 -0400)]
Merge pull request #26991 from agh1/5.64.0-releasenotes-final
5.64.0 release notes late changes
Seamus Lee [Wed, 2 Aug 2023 21:49:40 +0000 (07:49 +1000)]
Merge branch '5.64'
Tim Otten [Wed, 26 Jul 2023 07:21:53 +0000 (00:21 -0700)]
Update 5.63.2.md
Tim Otten [Wed, 26 Jul 2023 06:45:42 +0000 (23:45 -0700)]
Add release-notes/5.63.2.md
Tim Otten [Fri, 7 Jul 2023 18:45:16 +0000 (11:45 -0700)]
Add release-notes/5.63.1.md
Tim Otten [Fri, 16 Jun 2023 05:10:13 +0000 (22:10 -0700)]
Add release-notes/5.62.1.md
Tim Otten [Wed, 24 May 2023 06:38:56 +0000 (23:38 -0700)]
Add release-notes/5.61.4.md
Tim Otten [Sat, 20 May 2023 00:44:11 +0000 (17:44 -0700)]
Add release-notes/5.61.3.md
Tim Otten [Mon, 8 May 2023 23:10:10 +0000 (16:10 -0700)]
Add release-notes/5.61.2.md
Seamus Lee [Wed, 2 Aug 2023 21:43:30 +0000 (17:43 -0400)]
Merge pull request #26989 from demeritcowboy/regen
civicrm_generated is out of date in 5.64
Tim Otten [Fri, 5 May 2023 20:49:51 +0000 (13:49 -0700)]
Add release-notes/5.61.1.md
Tim Otten [Mon, 27 Mar 2023 20:35:57 +0000 (13:35 -0700)]
Add release-notes/5.59.4.md
Tim Otten [Thu, 16 Mar 2023 00:23:52 +0000 (17:23 -0700)]
Add release-notes/5.59.3.md
Tim Otten [Sat, 11 Mar 2023 00:29:22 +0000 (16:29 -0800)]
Add release-notes/5.59.2.md
Tim Otten [Sat, 4 Mar 2023 03:42:11 +0000 (19:42 -0800)]
Add release-notes/5.59.1.md
Tim Otten [Wed, 15 Feb 2023 23:58:14 +0000 (15:58 -0800)]
Update 5.58.1.md
Tim Otten [Wed, 15 Feb 2023 21:54:30 +0000 (13:54 -0800)]
Add release-notes/5.58.1.md
Andie Hunt [Wed, 2 Aug 2023 21:40:02 +0000 (17:40 -0400)]
5.64.0 release notes: added late changes
larssandergreen [Wed, 2 Aug 2023 21:24:44 +0000 (15:24 -0600)]
Fix price set field path regression
demeritcowboy [Wed, 2 Aug 2023 20:58:25 +0000 (16:58 -0400)]
Merge pull request #26986 from mattwire/paymentvarsref
REF: Rename variables to make it easier to understand what the code is doing
demeritcowboy [Wed, 2 Aug 2023 20:55:10 +0000 (16:55 -0400)]
regen
demeritcowboy [Wed, 2 Aug 2023 20:49:32 +0000 (16:49 -0400)]
populate another frontend_title
demeritcowboy [Wed, 2 Aug 2023 20:29:28 +0000 (16:29 -0400)]
Merge pull request #26975 from eileenmcnaughton/re-used
E-notice fix (smarty)
demeritcowboy [Wed, 2 Aug 2023 20:17:17 +0000 (16:17 -0400)]
Merge pull request #26984 from colemanw/daoFixeyUppey
DAO - Normalize null values in the writeRecord function to avoid subtle bugs
Matthew Wire [Wed, 2 Aug 2023 19:14:20 +0000 (20:14 +0100)]
Rename variables to make it easier to understand what the code is doing
colemanw [Wed, 2 Aug 2023 17:01:13 +0000 (13:01 -0400)]
Merge pull request #26950 from eileenmcnaughton/deprecate
Deprecate probably never true condition
Eileen McNaughton [Mon, 31 Jul 2023 23:10:12 +0000 (11:10 +1200)]
E-notice fix (smarty)
Eileen McNaughton [Fri, 28 Jul 2023 02:22:01 +0000 (14:22 +1200)]
Fix test set up
Eileen McNaughton [Thu, 27 Jul 2023 23:27:53 +0000 (11:27 +1200)]
Deprecate probably never true condition
If we can clarify that price set is ALWAYS set it will simplify stuff
- comments suggest that the exception has been weird test config
colemanw [Tue, 1 Aug 2023 23:12:17 +0000 (19:12 -0400)]
Bump recommended PHP version to 8.1, min recommendation to 8.0
colemanw [Tue, 1 Aug 2023 23:00:16 +0000 (19:00 -0400)]
DAO - Normalize null values in the writeRecord function to avoid subtle bugs
Passing around the string 'null' was a terrible practice and can lead to bugs when you use
an operator like `empty()` on the value.
Yashodha Chaku [Tue, 1 Aug 2023 06:20:32 +0000 (11:50 +0530)]
Merge pull request #26961 from eileenmcnaughton/quick_config
Use `isQuickConfig()` to determine isQuickConfig (towards php8.x fix)
Seamus Lee [Tue, 1 Aug 2023 01:57:20 +0000 (21:57 -0400)]
Merge pull request #26913 from eileenmcnaughton/subscribe_2
Update Group Subscribe message to use frontend_title
Seamus Lee [Tue, 1 Aug 2023 01:55:43 +0000 (21:55 -0400)]
Merge pull request #26962 from eileenmcnaughton/test_fix_mem
[php8.x] Fix test to use full form flow
Eileen McNaughton [Mon, 31 Jul 2023 23:38:34 +0000 (11:38 +1200)]
Merge pull request #26973 from aydun/adminui_price_paths2
Metadata tweaks for Price Sets, Fields & Values
Aidan Saunders [Mon, 31 Jul 2023 19:09:27 +0000 (20:09 +0100)]
Follow up to https://github.com/civicrm/civicrm-core/pull/26929
- fix unreleased regression relating to adding new price set fields and
values
- add Upgrader
Switch html type from Select to EntityRef for Price Fields and Values
Yashodha Chaku [Mon, 31 Jul 2023 14:52:16 +0000 (20:22 +0530)]
Merge pull request #26972 from civicrm/5.64
5.64
colemanw [Mon, 31 Jul 2023 14:25:02 +0000 (07:25 -0700)]
Merge pull request #25605 from kurund/radio-defaults
dev/core#3777 Afform: fix the setting defaults for radio and checkboxes when values are non-string
Kurund Jalmi [Fri, 17 Feb 2023 22:00:34 +0000 (22:00 +0000)]
fix the setting defaults for radio and checkboxes when values are non-string
Rich Lott [Mon, 31 Jul 2023 10:22:22 +0000 (11:22 +0100)]
Merge pull request #26966 from artfulrobot/standalone-login-redirects
standalone: Redirect to login
Rich Lott / Artful Robot [Mon, 31 Jul 2023 10:19:40 +0000 (11:19 +0100)]
standalone: redirect to login
Seamus Lee [Mon, 31 Jul 2023 03:51:47 +0000 (23:51 -0400)]
Merge pull request #26968 from alifrumin/5.64rn
[NFC] 5.64 release notes
colemanw [Sun, 30 Jul 2023 20:09:36 +0000 (13:09 -0700)]
Merge pull request #26674 from larssandergreen/Show-bounce-history-on-contact-summary
Show Email bounce history on Contact summary
colemanw [Sun, 30 Jul 2023 02:47:37 +0000 (19:47 -0700)]
Merge pull request #26971 from colemanw/colemanw-patch-1
ManagedEntityTest - Simplify reconciliation
colemanw [Sun, 30 Jul 2023 02:00:21 +0000 (22:00 -0400)]
ManagedEntityTest - Simplify reconciliation
Followup to #26970 which solved the problem; this removes the workarounds that are no longer needed.
colemanw [Sun, 30 Jul 2023 01:32:56 +0000 (18:32 -0700)]
Merge pull request #26970 from larssandergreen/Fix-Managed-Entity-test
Limit Managed Entity test reconciliation to the entities in the test
larssandergreen [Sun, 30 Jul 2023 00:20:47 +0000 (18:20 -0600)]
Limit Managed Entity test reconciliation to the entities in the test
colemanw [Fri, 28 Jul 2023 23:47:13 +0000 (16:47 -0700)]
Merge pull request #26960 from eileenmcnaughton/billing
Check `isBackOffice` before checking `billing_profile_id` (e-notice fix)
Eileen McNaughton [Fri, 28 Jul 2023 23:18:02 +0000 (11:18 +1200)]
Merge pull request #26576 from larssandergreen/Don't-allow-also-include-schedule-reminders-for-event
dev/core#4377 Disable broken Also Include for event scheduled reminders
Alice Frumin [Wed, 12 Jul 2023 02:08:01 +0000 (22:08 -0400)]
[NFC] 5.64 release notes
Aidan Saunders [Fri, 28 Jul 2023 18:05:56 +0000 (19:05 +0100)]
Merge pull request #26967 from colemanw/colemanw-patch-1
Add civicrm_search_ui to core-ext.txt
colemanw [Fri, 28 Jul 2023 17:30:48 +0000 (13:30 -0400)]
Add civicrm_search_ui to core-ext.txt
colemanw [Fri, 28 Jul 2023 13:09:43 +0000 (06:09 -0700)]
Merge pull request #26963 from totten/master-service-tags
AutoDefinition - Inherit service-tags from interfaces, traits, and parent classes
Tim Otten [Fri, 28 Jul 2023 09:44:07 +0000 (02:44 -0700)]
AutoDefinition - Inherit service-tags from interfaces, traits, and parent classes
Tim Otten [Fri, 28 Jul 2023 07:06:54 +0000 (00:06 -0700)]
Declare @serviceTags for HookInterface and SpecProviderInterface
Yashodha Chaku [Fri, 28 Jul 2023 10:11:47 +0000 (15:41 +0530)]
Merge pull request #26958 from eileenmcnaughton/smarty_campaign
Define soon as 'in 9 years'
Rich Lott [Fri, 28 Jul 2023 09:45:15 +0000 (10:45 +0100)]
Merge pull request #26942 from artfulrobot/standalone-breadcrumbs-v2
standalone: move breadcrumb rendering into template
Rich Lott / Artful Robot [Fri, 28 Jul 2023 09:00:46 +0000 (10:00 +0100)]
standalone: civilint
Seamus Lee [Fri, 28 Jul 2023 05:55:16 +0000 (01:55 -0400)]
Merge pull request #26954 from larssandergreen/Fix-saved-search-test-where-existing-managed-saved-search-is-present
Fix saved search test when there is an existing managed saved search
colemanw [Thu, 27 Jul 2023 03:57:29 +0000 (23:57 -0400)]
AutoDefinition - Remove never-true condition
The type-hint ensures the variable is never a string.
Eileen McNaughton [Fri, 28 Jul 2023 04:54:34 +0000 (16:54 +1200)]
Stop setting quickConfig for form that doesn't care
Seamus Lee [Fri, 28 Jul 2023 04:53:06 +0000 (00:53 -0400)]
Merge pull request #26959 from civicrm/5.64
5.64
Eileen McNaughton [Fri, 28 Jul 2023 04:49:22 +0000 (16:49 +1200)]
Use isQuickConfig to determine isQuickConfig
Eileen McNaughton [Fri, 28 Jul 2023 04:44:11 +0000 (16:44 +1200)]
[php8.x] Fix test to use full form flow
Eileen McNaughton [Fri, 28 Jul 2023 04:21:00 +0000 (16:21 +1200)]
Check isBackOffice before checking billing_profile_id
It won't be set from back office forms & will e-notice...
Seamus Lee [Fri, 28 Jul 2023 04:11:39 +0000 (00:11 -0400)]
Merge pull request #26953 from eileenmcnaughton/cont_name
dev/core#4453 fix clash over 'name' field on contribution page form