Eileen McNaughton [Wed, 22 Dec 2021 22:45:41 +0000 (11:45 +1300)]
Merge pull request #22300 from colemanw/searchKitExportTweak
SearchKit - Tweak export explorer link icon + format
Eileen McNaughton [Wed, 22 Dec 2021 22:44:54 +0000 (11:44 +1300)]
Merge pull request #22304 from braders/feature/smtp-settings-html-positions
Display label before input elements on SMTP settings page
Seamus Lee [Wed, 22 Dec 2021 22:17:23 +0000 (09:17 +1100)]
Merge pull request #22294 from eileenmcnaughton/esc
Do not apply default escaping to multiselects on currency form
Bradley Taylor [Wed, 22 Dec 2021 21:04:48 +0000 (21:04 +0000)]
Display label before input elements on SMTP settings page
Yashodha Chaku [Wed, 22 Dec 2021 14:11:13 +0000 (19:41 +0530)]
Merge pull request #22290 from eileenmcnaughton/cont
Fix broken links in default modifier mode on manage contributions
Seamus Lee [Wed, 22 Dec 2021 11:01:50 +0000 (22:01 +1100)]
Merge pull request #22297 from civicrm/5.45
Merge 5.45 to master
Seamus Lee [Wed, 22 Dec 2021 08:42:27 +0000 (19:42 +1100)]
Merge pull request #22295 from alifrumin/rn5.45
[NFC] First Pass at Release Notes for 5.45
Seamus Lee [Wed, 22 Dec 2021 08:41:53 +0000 (19:41 +1100)]
Merge pull request #22299 from colemanw/suitcaseIcon
SearchKit - better icon for packaged searches
Seamus Lee [Wed, 22 Dec 2021 08:41:22 +0000 (19:41 +1100)]
Merge pull request #22301 from eileenmcnaughton/recur_data
Follow up fix on recur data
Eileen McNaughton [Wed, 22 Dec 2021 06:10:44 +0000 (19:10 +1300)]
Follow up fix on recur data
Yashodha Chaku [Wed, 22 Dec 2021 05:45:52 +0000 (11:15 +0530)]
Merge pull request #22296 from eileenmcnaughton/recur_data
Add recurring conributions to sample data
Coleman Watts [Wed, 22 Dec 2021 05:42:16 +0000 (00:42 -0500)]
SearchKit - Tweak export explorer link icon + format
Updates the explorer params to use raw strings, as json-encoding
is not necessary.
Coleman Watts [Wed, 22 Dec 2021 05:32:01 +0000 (00:32 -0500)]
SearchKit - better icon for packaged searches
Eileen McNaughton [Wed, 22 Dec 2021 03:10:20 +0000 (16:10 +1300)]
Merge pull request #22293 from colemanw/fixEditableCustom
SearchKit - Fix editable custom fields
Eileen McNaughton [Wed, 22 Dec 2021 03:06:56 +0000 (16:06 +1300)]
Add recurring conributions to sample data
Alice Frumin [Thu, 9 Dec 2021 17:51:34 +0000 (12:51 -0500)]
[NFC] First pass release notes 5.45
colemanw [Wed, 22 Dec 2021 02:17:37 +0000 (21:17 -0500)]
Merge pull request #22288 from eileenmcnaughton/process
[REF] move code into the function
Eileen McNaughton [Wed, 22 Dec 2021 01:23:18 +0000 (14:23 +1300)]
Do not apply default escaping to multiselects on currency form
This is probably an html pattern we have missed in our early returns but
explictly marking the fields not to be escaped is probably better now the bulk is weeded out
colemanw [Wed, 22 Dec 2021 01:18:20 +0000 (20:18 -0500)]
Merge pull request #22281 from colemanw/fixSearchKitConcatWS
SearchKit - Fix "Combine Text" transformation
colemanw [Wed, 22 Dec 2021 01:16:37 +0000 (20:16 -0500)]
Merge pull request #22228 from colemanw/managedGroup
Apiv4 - Make Groups a managed entity, fix 'null' bugs in BAO_Group
Coleman Watts [Wed, 22 Dec 2021 01:09:28 +0000 (20:09 -0500)]
SearchKit - Fix editable custom fields
Eileen McNaughton [Wed, 22 Dec 2021 00:09:23 +0000 (13:09 +1300)]
Merge pull request #22289 from eileenmcnaughton/urls
Enotice fixes on ContributionPage dash
Eileen McNaughton [Tue, 21 Dec 2021 21:17:06 +0000 (10:17 +1300)]
Fix broken links in default modifier mode on manage contributions
Eileen McNaughton [Tue, 21 Dec 2021 21:09:13 +0000 (10:09 +1300)]
Enotice fixes on ContributionPage dash
Eileen McNaughton [Tue, 21 Dec 2021 20:37:06 +0000 (09:37 +1300)]
[REF] move code into the function
Within the if there is some code & then a function call. There doesn't seem
to be much reason for some of the code to be in the function & some
outside - this simplifies
Yashodha Chaku [Tue, 21 Dec 2021 08:51:50 +0000 (14:21 +0530)]
Merge pull request #22287 from eileenmcnaughton/process
[REF] Stop passing this as form, set in function
Eileen McNaughton [Tue, 21 Dec 2021 05:06:41 +0000 (18:06 +1300)]
[REF] Stop passing this as form, set in function
Seamus Lee [Tue, 21 Dec 2021 04:49:56 +0000 (15:49 +1100)]
Merge pull request #21611 from eileenmcnaughton/cancel
Add workflow template for recurring cancelled
colemanw [Tue, 21 Dec 2021 02:24:05 +0000 (21:24 -0500)]
Merge pull request #22229 from colemanw/searchKitExport
SearchKit - Import/Export saved search configuration
colemanw [Tue, 21 Dec 2021 02:21:37 +0000 (21:21 -0500)]
Merge pull request #22284 from eileenmcnaughton/process
[REF] Remove now non-variable variables from previously shared code
Eileen McNaughton [Mon, 20 Dec 2021 21:53:55 +0000 (10:53 +1300)]
Merge pull request #22283 from eileenmcnaughton/notice
Cleanup Smarty e-notices on campaign dashboard
Eileen McNaughton [Mon, 20 Dec 2021 21:52:03 +0000 (10:52 +1300)]
[REF] Remove now non-variable variables from previously shared code
Coleman Watts [Wed, 8 Dec 2021 17:04:36 +0000 (12:04 -0500)]
SearchKit - Add Import dialog
Coleman Watts [Wed, 8 Dec 2021 16:07:28 +0000 (11:07 -0500)]
Move crmDialog angular utility from message_admin extension to core for reusability
Coleman Watts [Wed, 8 Dec 2021 13:03:21 +0000 (08:03 -0500)]
SearchKit - Rename searchList template to match controller, move "New Search" button to top
Coleman Watts [Tue, 7 Dec 2021 21:16:07 +0000 (16:16 -0500)]
SearchKit - Add Export dialog
Coleman Watts [Mon, 6 Dec 2021 16:17:27 +0000 (11:17 -0500)]
Afform - Be more forgiving about input format when saving an afform
Coleman Watts [Mon, 6 Dec 2021 03:06:49 +0000 (22:06 -0500)]
SearchKit - Faster delete/revert actions in search listing
Coleman Watts [Mon, 6 Dec 2021 02:50:30 +0000 (21:50 -0500)]
SearchKit - Use dropdown for actions in search listing
The list of actions is getting too big for a row of buttons...
colemanw [Mon, 20 Dec 2021 21:29:07 +0000 (16:29 -0500)]
Merge pull request #22276 from eileenmcnaughton/process
[REF] Duplicate & unshare processFormContribution
Eileen McNaughton [Mon, 20 Dec 2021 20:04:39 +0000 (09:04 +1300)]
Cleanup Smarty e-notices on campaign dashboard
Eileen McNaughton [Mon, 20 Dec 2021 19:57:02 +0000 (08:57 +1300)]
Merge pull request #22282 from colemanw/cgExtends
CustomGroup - Add pseudoconstant for extends column
Coleman Watts [Mon, 20 Dec 2021 05:54:52 +0000 (00:54 -0500)]
CustomGroup - Add pseudoconstant for extends column
Yashodha Chaku [Mon, 20 Dec 2021 08:55:40 +0000 (14:25 +0530)]
Merge pull request #22265 from eileenmcnaughton/ver
dev/core#2996 Increment php recommndations
Coleman Watts [Mon, 20 Dec 2021 05:31:36 +0000 (00:31 -0500)]
SearchKit - Fix CONCAT_WS & any function that doesn't take a field as 1st arg
Fixes dev/report#88
See https://lab.civicrm.org/dev/report/-/issues/88
Seamus Lee [Mon, 20 Dec 2021 05:18:56 +0000 (16:18 +1100)]
Merge pull request #22275 from eileenmcnaughton/recur_test
dev/core#567 Add test shell
Seamus Lee [Mon, 20 Dec 2021 05:18:47 +0000 (16:18 +1100)]
Merge pull request #22278 from demeritcowboy/unused-function
Remove unused function CRM/Utils/Mail/EmailProcessor::cleanupDir
Seamus Lee [Mon, 20 Dec 2021 05:18:37 +0000 (16:18 +1100)]
Merge pull request #22279 from eileenmcnaughton/refs
Remove unnecessary pass-by-ref
Eileen McNaughton [Sun, 19 Dec 2021 22:40:24 +0000 (11:40 +1300)]
Remove unnecessary pass-by-ref
demeritcowboy [Sun, 19 Dec 2021 22:27:32 +0000 (17:27 -0500)]
unused function
Eileen McNaughton [Sun, 19 Dec 2021 21:56:31 +0000 (10:56 +1300)]
dev/core#567 Add test shell
Eileen McNaughton [Sun, 19 Dec 2021 22:17:57 +0000 (11:17 +1300)]
[REF] Duplicate & unshare processFormContribution
The only way I've managed to break up these big toxic functions is divide & conquer. While it seems
counter-intuitive to not doing things in more than one place in practice much of the
code is form-relevant and the the code before, during and after these functions
does a whole lot of extra work to share stuff that they don't really have in common.
This dates back pre-api when the only copy of the business logic often was on the forms....
demeritcowboy [Sun, 19 Dec 2021 17:56:05 +0000 (12:56 -0500)]
Merge pull request #22272 from eileenmcnaughton/anet
[NFC] Cleanup in Authorize.net test class
demeritcowboy [Sat, 18 Dec 2021 23:34:16 +0000 (18:34 -0500)]
Merge pull request #21927 from eileenmcnaughton/trxn
Move two more functions to financialProcessor
colemanw [Sat, 18 Dec 2021 23:33:33 +0000 (18:33 -0500)]
Merge pull request #22233 from colemanw/apiExplorerArgs
APIv4 Explorer - Make selected language and format bookmarkable
Eileen McNaughton [Sat, 25 Sep 2021 02:10:37 +0000 (14:10 +1200)]
Add workflow template for recurring cancelled
This is a simple template, with a slightly smaller subset of values than the exisiting one.
It pulls out the recurring part to a trait...
Eileen McNaughton [Sat, 18 Dec 2021 21:40:13 +0000 (10:40 +1300)]
[NFC] Cleanup in Authorize.net test class
The main goal in this update is to switch the contribution form to use the full form flow.
Other changes are just code style
Eileen McNaughton [Sat, 18 Dec 2021 21:23:38 +0000 (10:23 +1300)]
Merge pull request #22266 from eileenmcnaughton/cont_tests
Fix test to use full form flow
Eileen McNaughton [Sat, 18 Dec 2021 21:22:11 +0000 (10:22 +1300)]
Merge pull request #22269 from demeritcowboy/make-clean
[NFC] - Try to work around failing tests
Eileen McNaughton [Sat, 18 Dec 2021 21:17:30 +0000 (10:17 +1300)]
Merge pull request #22271 from civicrm/5.45
5.45
demeritcowboy [Sat, 18 Dec 2021 00:19:43 +0000 (19:19 -0500)]
Merge pull request #22270 from colemanw/relatedContactsLabel
Fix related contacts label in search kit
Coleman Watts [Fri, 17 Dec 2021 21:37:06 +0000 (16:37 -0500)]
Fix related contacts label in search kit
demeritcowboy [Fri, 17 Dec 2021 20:37:57 +0000 (15:37 -0500)]
work around previous test fails
Eileen McNaughton [Fri, 17 Dec 2021 04:50:07 +0000 (17:50 +1300)]
Fix test to use full form flow
Eileen McNaughton [Wed, 27 Oct 2021 19:55:04 +0000 (08:55 +1300)]
Move two more functions to financialProcessor
Eileen McNaughton [Thu, 16 Dec 2021 22:44:03 +0000 (11:44 +1300)]
Increment php recommndations
Tim Otten [Thu, 16 Dec 2021 21:27:49 +0000 (13:27 -0800)]
Merge pull request #22107 from demeritcowboy/test-isdir
dev/core#2927 - Avoid warnings for is_dir() when open_basedir is in effect
Tim Otten [Thu, 16 Dec 2021 21:19:29 +0000 (13:19 -0800)]
Merge pull request #22236 from mlutfy/angularCacheCodeLanguage
Resources: set language-specific cacheCode, fixes AngularJS translation with multilingual
Mathieu Lu [Thu, 16 Dec 2021 14:04:11 +0000 (09:04 -0500)]
Merge pull request #21762 from jitendrapurohit/job-alert
Add system status warning to display scheduled job failures
jitendrapurohit [Thu, 9 Dec 2021 11:23:23 +0000 (16:53 +0530)]
add ts
Eileen McNaughton [Thu, 16 Dec 2021 03:37:47 +0000 (16:37 +1300)]
Merge pull request #22261 from eileenmcnaughton/prof
[REF] Remove more params that are unused now function is not shared
Eileen McNaughton [Thu, 16 Dec 2021 01:51:42 +0000 (14:51 +1300)]
[REF] Remove more params that are unused now function is not shared
Seamus Lee [Wed, 15 Dec 2021 23:50:58 +0000 (10:50 +1100)]
Merge pull request #22260 from eileenmcnaughton/prof
Remove handling for always-truthy var being false
Seamus Lee [Wed, 15 Dec 2021 22:44:49 +0000 (09:44 +1100)]
Merge pull request #22259 from eileenmcnaughton/update
Rename protected function
Eileen McNaughton [Wed, 15 Dec 2021 22:19:50 +0000 (11:19 +1300)]
Remove handling for always truthy var being false
In a previous unshared life the code in this function supported contact being null
However, in it's unshared version contactID is always an integer (in the merge context). This strips
out the now-irrelevant code.
Further cleanup to follow ... it's not clear this function is doing
anything of value at all but some unwravelling required
Seamus Lee [Wed, 15 Dec 2021 22:02:49 +0000 (09:02 +1100)]
Merge pull request #22258 from eileenmcnaughton/prof
Remove never passed variables
Eileen McNaughton [Wed, 15 Dec 2021 20:30:43 +0000 (09:30 +1300)]
Rename protected function
This function was originally shared & hence the name made sense but in the context of dedupe
it is only used to do updates so renaming to make that clear & making required nature
of contactID clear too
Eileen McNaughton [Wed, 15 Dec 2021 20:23:39 +0000 (09:23 +1300)]
Remove never passed variables
This function is no longer shared so is only called from one place. That place doesn't use
contactDetails so don't return. Also never sets skipCustom so stop checking
(will remove the other non-passed soon)
colemanw [Wed, 15 Dec 2021 20:06:27 +0000 (15:06 -0500)]
Merge pull request #22254 from eileenmcnaughton/prof
[REF] Duplicate function to allow us to work it out of the code
colemanw [Wed, 15 Dec 2021 19:50:54 +0000 (14:50 -0500)]
Merge pull request #22257 from aydun/mr-info
(NFC) APIv4: Add help info for multi-record custom field sets
Aidan Saunders [Wed, 15 Dec 2021 15:45:12 +0000 (15:45 +0000)]
Add help info for multi-record custom field sets
colemanw [Wed, 15 Dec 2021 13:24:20 +0000 (08:24 -0500)]
Merge pull request #22183 from eileenmcnaughton/smarty9
Smarty variables] Remove another isset - deferredFinancialType
Mathieu Lu [Wed, 15 Dec 2021 12:30:14 +0000 (07:30 -0500)]
Merge pull request #22256 from eileenmcnaughton/order
Do not default-escape weight field on order
Eileen McNaughton [Wed, 15 Dec 2021 09:05:15 +0000 (22:05 +1300)]
Do not default-escape weight field on order
Seamus Lee [Wed, 15 Dec 2021 06:19:19 +0000 (17:19 +1100)]
Merge pull request #22253 from eileenmcnaughton/rel5
[REF] Minor parameter simplification
Eileen McNaughton [Wed, 15 Dec 2021 03:23:11 +0000 (16:23 +1300)]
[REF] Duplicate function to allow us to work it out of the code
demeritcowboy [Wed, 15 Dec 2021 03:53:39 +0000 (22:53 -0500)]
Merge pull request #22251 from eileenmcnaughton/rel3
[NFC] Test cleanup
Eileen McNaughton [Wed, 15 Dec 2021 01:52:58 +0000 (14:52 +1300)]
[REF] Minor parameter simplification
The only value in this array used in the function is 'custom' which should be an array. I think it woul
d only ever be an array or NULL (which would then be an array with this change) but I left
a deprecation notice in case. Pass-by-ref isn't needed
Eileen McNaughton [Wed, 15 Dec 2021 03:06:11 +0000 (16:06 +1300)]
Merge pull request #22249 from eileenmcnaughton/rel
[NFC] Minor cleanup in test class
Eileen McNaughton [Wed, 15 Dec 2021 02:37:41 +0000 (15:37 +1300)]
Merge pull request #22252 from eileenmcnaughton/escapeit
Move require_once for smarty modifier due to order issues
Eileen McNaughton [Tue, 14 Dec 2021 21:13:37 +0000 (10:13 +1300)]
[NFC] Test cleanup
This biggest part of this is relying on the tearDown to do the cleanup more. This is the right
way because if the test fails the cleanup won't happen if it is in the test itsef
colemanw [Tue, 14 Dec 2021 22:10:31 +0000 (17:10 -0500)]
Merge pull request #22243 from demeritcowboy/quickfix-reportedby
dev/core#2825 - Make source contact required for activities on the form
Eileen McNaughton [Tue, 14 Dec 2021 21:27:15 +0000 (10:27 +1300)]
Move require_once for smarty modifier due to order issues
Eileen McNaughton [Tue, 14 Dec 2021 21:07:20 +0000 (10:07 +1300)]
[NFC] Minor cleanup in test class
demeritcowboy [Tue, 14 Dec 2021 21:07:01 +0000 (16:07 -0500)]
Merge pull request #22248 from MattTrim1/patch-1
Contributor key: Add Matt Trim
demeritcowboy [Tue, 14 Dec 2021 21:06:53 +0000 (16:06 -0500)]
Merge pull request #22244 from MattTrim1/flip-default-display-custom-group-options
dev/core#2977 - For custom group creation, flip the default display settings
MattTrim1 [Tue, 14 Dec 2021 19:21:11 +0000 (19:21 +0000)]
Contributor key: Add Matt Trim
demeritcowboy [Tue, 14 Dec 2021 19:18:08 +0000 (14:18 -0500)]
Merge pull request #22246 from mattwire/money0.5
Update Brick/Money to 0.5.3
Mathieu Lu [Tue, 14 Dec 2021 18:36:16 +0000 (13:36 -0500)]
Merge pull request #22247 from mlutfy/fixConfirmRecur545
Contribution Confirm: fix wording on the recurring
Mathieu Lutfy [Tue, 14 Dec 2021 16:23:40 +0000 (11:23 -0500)]
Contribution Confirm: fix wording on the recurring