civicrm-core.git
2 years agoMerge pull request #23823 from eileenmcnaughton/contact_test
Eileen McNaughton [Mon, 20 Jun 2022 00:51:20 +0000 (12:51 +1200)]
Merge pull request #23823 from eileenmcnaughton/contact_test

dev/core#3663 fix output regression on csv output for import

2 years agoMerge pull request #23818 from colemanw/afformDep
Eileen McNaughton [Sun, 19 Jun 2022 21:15:05 +0000 (09:15 +1200)]
Merge pull request #23818 from colemanw/afformDep

Afform - fix dependency injection for autogenerated forms

2 years agoAlways throw exception in tests for pdf out
Eileen McNaughton [Fri, 17 Jun 2022 21:52:00 +0000 (09:52 +1200)]
Always throw exception in tests for pdf out

headers_sent() was always true before and hence the tests were written to expect the
exception would be called. Fixing that caused the tests to fail - but fixing it is good

2 years agoMerge pull request #23827 from eileenmcnaughton/empty_date
Tim Otten [Fri, 17 Jun 2022 06:03:23 +0000 (23:03 -0700)]
Merge pull request #23827 from eileenmcnaughton/empty_date

Handle empty date token gracefully

2 years agoHandle empty date token gracefully
Eileen McNaughton [Fri, 17 Jun 2022 04:15:51 +0000 (16:15 +1200)]
Handle empty date token gracefully

2 years agoOutput to stdErr rather than echo
Eileen McNaughton [Fri, 17 Jun 2022 03:39:02 +0000 (15:39 +1200)]
Output to stdErr rather than echo

2 years agoMerge pull request #23824 from totten/mixin-refresh
colemanw [Fri, 17 Jun 2022 03:08:35 +0000 (23:08 -0400)]
Merge pull request #23824 from totten/mixin-refresh

(dev/core#3660) Ensure that rebuildMenuAndCaches has current mixins+classloaders

2 years agodev/core#3663 fix output regression on csv output
Eileen McNaughton [Fri, 17 Jun 2022 00:11:12 +0000 (12:11 +1200)]
dev/core#3663 fix output regression on csv output

This fixes a very-recent rc regression whereby the file error output was
not correctly referring to the fields to be exported.

Note that in order to make it testable I had to
- remove header-setting that duplicates work done by the csv package
- remove extraneous echos in the GenCode

2 years ago(dev/core#3660) Ensure that rebuildMenuAndCaches has current mixins+classloaders
Tim Otten [Fri, 17 Jun 2022 00:00:48 +0000 (17:00 -0700)]
(dev/core#3660) Ensure that rebuildMenuAndCaches has current mixins+classloaders

Overview
--------

This fixes an issue in transitioning from `hook_managed` to `mixin/mgd-php@1`, wherein
managed-entities are briefly deleted (but later recreated).

Steps to Reproduce
------------------

1. (Web) Install an extension with a revision that uses `hook_managed`
2. (CLI) Switch the extension to a revision that uses `mixin/mgd-php@1`
3. (CLI) View contents of `civicrm_managed`
4. (Web) Run `civicrm/menu/rebuild`
5. (CLI) View contents of `civicrm_managed`
6. (Web) Run `civicrm/menu/rebuild`
7. (CLI) View contents of `civicrm_managed`

Before
------

While processing step 4 (`civicrm/menu/rebuild`), it fails to run the hooks for `mgd-php`.

Consequently, the list of managed-entities is lost and will disappear at step 5.

After
-----

While processing step 4 (`civicrm/menu/rebuild`), it activates the hooks for `mgd-php`.

Technical Details
------------------

When processing `civicrm/menu/rebuild`, there are a couple big substeps:

* `Civi\Core\Container::boot()` - During this process, it loads extensions. As usual,
  this reads cached metadata, sets up classloaders, sets up mixins/hooks, etc.
* `CRM_Core_Invoke::rebuildMenuAndCaches()` - During this process, it clears
  out caches and rebuilds several things (menus, managed-entities, etc).

The problem is this:

* The cache used during `boot()` has stale metadata (specifically,
  `civicrm_cache` has old values of `mixinScan` and `mixinBoot`).
  So it doesn't setup any new mixins/hooks.
* Then `rebuildMenuAndCaches()` depends on the mixins/hooks that are already setup.
  While the function does clear persistent caches, it assumes that the
  PHP runtime environment is up-to-spec. But it's not -- becuase our hooks
  were based on the caches.

The patch uses the same `refresh()` mechanism as the extension-administration subsystem (which
has to reset the classloaders+mixins after enabling or disabling an extension).

2 years agoMerge pull request #23807 from colemanw/fixAfformTitle
Mathieu Lu [Thu, 16 Jun 2022 19:49:15 +0000 (15:49 -0400)]
Merge pull request #23807 from colemanw/fixAfformTitle

SearchKit - Only add filter values to Afform title if passed internally

2 years agoSearchKit - Only add filter values to Afform title if passed internally
Coleman Watts [Wed, 15 Jun 2022 21:49:51 +0000 (17:49 -0400)]
SearchKit - Only add filter values to Afform title if passed internally

This narrows the scope of contextual titles from #22319 to
only those filters passed internally, as used in drilldown forms.

It makes sense to exclude values from exposed filters because that
can lead to a confusing UI.

2 years agoAfform - fix dependency injection for autogenerated forms
Coleman Watts [Thu, 16 Jun 2022 14:21:24 +0000 (10:21 -0400)]
Afform - fix dependency injection for autogenerated forms

2 years agoMerge pull request #23815 from seamuslee001/date_second_customformat
Eileen McNaughton [Thu, 16 Jun 2022 10:47:47 +0000 (22:47 +1200)]
Merge pull request #23815 from seamuslee001/date_second_customformat

[REF] Fix second output in customFormat function and extend unit test

2 years ago[REF] Fix second output in customFormat function and extend unit test
Seamus Lee [Thu, 16 Jun 2022 07:49:51 +0000 (17:49 +1000)]
[REF] Fix second output in customFormat function and extend unit test

2 years agoMerge pull request #23801 from eileenmcnaughton/cont_work
Tim Otten [Thu, 16 Jun 2022 01:03:59 +0000 (18:03 -0700)]
Merge pull request #23801 from eileenmcnaughton/cont_work

Fix breakage in message preview on workflow contributions

2 years agoMerge pull request #23805 from mattwire/devfinancial197alt
Monish Deb [Wed, 15 Jun 2022 14:43:43 +0000 (20:13 +0530)]
Merge pull request #23805 from mattwire/devfinancial197alt

dev/financial#197 Revert freezing on total_amount field on recurring form (alt to #23796)

2 years agoRevert freezing on total_amount field on recurring form
Matthew Wire [Wed, 15 Jun 2022 11:21:39 +0000 (12:21 +0100)]
Revert freezing on total_amount field on recurring form

2 years agoMerge pull request #23798 from seamuslee001/fix_auto_renew_membership
Monish Deb [Wed, 15 Jun 2022 11:19:47 +0000 (16:49 +0530)]
Merge pull request #23798 from seamuslee001/fix_auto_renew_membership

Fix Automatic renewal membership from front end contribution forms

2 years agoFix breakage in message preview on workflow contributions
Eileen McNaughton [Wed, 15 Jun 2022 03:44:52 +0000 (15:44 +1200)]
Fix breakage in message preview on workflow contributions

2 years ago[REF] Fix Automatic renewal membership from front end contribution forms
Seamus Lee [Tue, 14 Jun 2022 23:49:26 +0000 (09:49 +1000)]
[REF] Fix Automatic renewal membership from front end contribution forms

Properly fix regression and update unit tests to match what the form does

2 years agoMerge pull request #23785 from totten/5.51-hook-log
Tim Otten [Tue, 14 Jun 2022 21:11:43 +0000 (14:11 -0700)]
Merge pull request #23785 from totten/5.51-hook-log

dev/core#3502 - CiviEventDispatcher - Softer errors for not-ready. More comments.

2 years agoMerge pull request #23753 from eileenmcnaughton/import_validate_int
colemanw [Tue, 14 Jun 2022 20:13:04 +0000 (16:13 -0400)]
Merge pull request #23753 from eileenmcnaughton/import_validate_int

Add integer validation to import

2 years agoMerge pull request #23763 from eileenmcnaughton/act_test
colemanw [Tue, 14 Jun 2022 20:12:21 +0000 (16:12 -0400)]
Merge pull request #23763 from eileenmcnaughton/act_test

Fix target contact label back to include target

2 years agoMerge pull request #23764 from eileenmcnaughton/activity_update_mutli
colemanw [Tue, 14 Jun 2022 20:11:37 +0000 (16:11 -0400)]
Merge pull request #23764 from eileenmcnaughton/activity_update_mutli

dev/core#2706 dev/core#2308 fix activity import to update multi-select fields

2 years agoMerge pull request #23788 from ufundo/5.51
Eileen McNaughton [Tue, 14 Jun 2022 20:08:40 +0000 (08:08 +1200)]
Merge pull request #23788 from ufundo/5.51

only check batch currency match when adding a financial_trxn

2 years agoMerge pull request #23786 from mattwire/devfinancial199
demeritcowboy [Tue, 14 Jun 2022 17:12:47 +0000 (13:12 -0400)]
Merge pull request #23786 from mattwire/devfinancial199

dev/financial#199 Fix additional details on edit template contribution

2 years agoFix additional details on edit template contribution
Matthew Wire [Tue, 14 Jun 2022 14:45:13 +0000 (15:45 +0100)]
Fix additional details on edit template contribution

2 years agoonly check batch currency match when adding a financial_trxn
ufundo [Thu, 9 Jun 2022 16:29:32 +0000 (16:29 +0000)]
only check batch currency match when adding a financial_trxn

2 years agodev/core#3502 - CiviEventDispatcher - Tune down the warning
Tim Otten [Thu, 9 Jun 2022 04:17:51 +0000 (21:17 -0700)]
dev/core#3502 - CiviEventDispatcher - Tune down the warning

2 years agodev/core#3502 - CiviEventDispatcher - Tweak error message. Add explanation.
Tim Otten [Thu, 9 Jun 2022 02:14:04 +0000 (19:14 -0700)]
dev/core#3502 - CiviEventDispatcher - Tweak error message. Add explanation.

2 years agoMerge pull request #23783 from totten/5.51-snapshots
Eileen McNaughton [Tue, 14 Jun 2022 03:58:59 +0000 (15:58 +1200)]
Merge pull request #23783 from totten/5.51-snapshots

FiveFiftyOne - Enable snapshots for data modified data

2 years agoFiveFiftyOne - Enable snapshots for data modified data
Tim Otten [Tue, 14 Jun 2022 02:06:05 +0000 (19:06 -0700)]
FiveFiftyOne - Enable snapshots for data modified data

Before
------

The 5.51.alpha upgrade modifies a some data-structures (`civicrm_mapping_*`, `civicrm_queue`),
but it doesn't take any snapshots.

After
-----

It does snapshots.

Comments
--------

Both tables should generally be quite small.

Strictly, the `civicrm_mapping_*` updates are more in-place modifications,
so that's more important.  The `civicrm_queue` changes are only adding new
columns.  But the table is so small - it doesn't hurt.

I suppose one could argue that these particular fields aren't likely to have
problems - but it's important to get in the habit of enabling snapshots so
that we have them when they do matter.

2 years agoMerge pull request #23771 from eileenmcnaughton/cont_update
Eileen McNaughton [Tue, 14 Jun 2022 00:00:29 +0000 (12:00 +1200)]
Merge pull request #23771 from eileenmcnaughton/cont_update

dev/core#3651 dev/core#1337 Fix failure to show last column data in output, spaces in names

2 years agoMerge pull request #23780 from totten/5.51-hush
Eileen McNaughton [Mon, 13 Jun 2022 22:19:02 +0000 (10:19 +1200)]
Merge pull request #23780 from totten/5.51-hush

(dev/core#3653) CRM_Queue_Runner - Fix upgrade warnings. Extract disableBackgroundExecution().

2 years agoMerge pull request #23766 from eileenmcnaughton/cont_up
Tim Otten [Mon, 13 Jun 2022 20:34:06 +0000 (13:34 -0700)]
Merge pull request #23766 from eileenmcnaughton/cont_up

dev/core#3513 Remove 'done' from sumary/import monitoring page

2 years agoCRM_Queue_Runner - Fix upgrade warnings. Extract disableBackgroundExecution().
Tim Otten [Mon, 13 Jun 2022 19:55:51 +0000 (12:55 -0700)]
CRM_Queue_Runner - Fix upgrade warnings. Extract disableBackgroundExecution().

This is a revision to #23775.  As before, it prevents a hard error when
upgrading to 5.51.  However, the try-catch produces confusing error messages
in the `CiviCRM.log.*` (ie they indicate a SQL error, but the situation is
actually a normal/expected during upgrade).  This avoids the error messages.

Tested (`r-run`) with `civicrm/upgrade`, `drush civicrm-upgrade-db`, and `cv
upgrade:db` -- for both 5.45=>5.51 and 5.45=>5.49=>5.51.

2 years agoMerge pull request #23777 from darrick/fix_import_disableUSPS
Eileen McNaughton [Mon, 13 Jun 2022 06:01:48 +0000 (18:01 +1200)]
Merge pull request #23777 from darrick/fix_import_disableUSPS

fix disableUSPS since import running in separate context of Queue.

2 years agofix disableUSPS since import running in separate context of Queue.
Darrick Servis [Sat, 11 Jun 2022 22:53:56 +0000 (15:53 -0700)]
fix disableUSPS since import running in separate context of Queue.

2 years agoMerge pull request #23775 from eileenmcnaughton/5.51
demeritcowboy [Mon, 13 Jun 2022 00:54:20 +0000 (20:54 -0400)]
Merge pull request #23775 from eileenmcnaughton/5.51

dev/core#3653 Fix on queue runner not working in upgrade

2 years agodev/core#3653 Fix on queue runner not working in upgrade
Eileen McNaughton [Sun, 12 Jun 2022 22:13:07 +0000 (10:13 +1200)]
dev/core#3653 Fix on queue runner not working in upgrade

2 years agoMerge pull request #23772 from eileenmcnaughton/cont_contact_fields
Eileen McNaughton [Sun, 12 Jun 2022 06:03:38 +0000 (18:03 +1200)]
Merge pull request #23772 from eileenmcnaughton/cont_contact_fields

Fix import regression - contribution import borks on do_not_import

2 years agoMerge pull request #23757 from colemanw/dupeFixAgain
Eileen McNaughton [Sun, 12 Jun 2022 00:29:37 +0000 (12:29 +1200)]
Merge pull request #23757 from colemanw/dupeFixAgain

Deduepe - Fix form buttons (again)

2 years agodev/core#3651 dev/core#1337 Fix failure to show last column data in output, spaces...
Eileen McNaughton [Sat, 11 Jun 2022 23:36:09 +0000 (11:36 +1200)]
dev/core#3651 dev/core#1337 Fix failure to show last column data in output, spaces in names

2 years agoFix import regression - contribution import borks on do_not_import
Eileen McNaughton [Sun, 12 Jun 2022 00:21:18 +0000 (12:21 +1200)]
Fix import regression - contribution import borks on do_not_import

2 years agodev/core#3513 Remove 'done' from sumary/import monitoring page
Eileen McNaughton [Sat, 11 Jun 2022 02:59:20 +0000 (14:59 +1200)]
dev/core#3513 Remove 'done' from sumary/import monitoring page

See dev/core#3513 for why it's confusing

2 years agoMerge pull request #23759 from colemanw/fixTotalCount
demeritcowboy [Sat, 11 Jun 2022 19:38:42 +0000 (15:38 -0400)]
Merge pull request #23759 from colemanw/fixTotalCount

[REGRESSION] SearchKit - Fix angular console error when totalCount is not given

2 years agoMerge pull request #23754 from eileenmcnaughton/act_date
demeritcowboy [Sat, 11 Jun 2022 19:19:38 +0000 (15:19 -0400)]
Merge pull request #23754 from eileenmcnaughton/act_date

dev/core#2325 import second-handling fix

2 years agoMerge pull request #23765 from eileenmcnaughton/guzzle_it
colemanw [Sat, 11 Jun 2022 15:41:21 +0000 (11:41 -0400)]
Merge pull request #23765 from eileenmcnaughton/guzzle_it

Catch & convert Guzzle exception

2 years agoMerge pull request #23758 from colemanw/noCiviGrant
demeritcowboy [Sat, 11 Jun 2022 15:37:01 +0000 (11:37 -0400)]
Merge pull request #23758 from colemanw/noCiviGrant

Setup - Remove CiviGrant from available components

2 years agoMerge pull request #23760 from eileenmcnaughton/validate_fields
colemanw [Sat, 11 Jun 2022 14:11:06 +0000 (10:11 -0400)]
Merge pull request #23760 from eileenmcnaughton/validate_fields

dev/core#3511 Improve handling of invalid saved mapping fields

2 years agoMerge pull request #23761 from eileenmcnaughton/invalid_state_with_country
colemanw [Sat, 11 Jun 2022 13:56:47 +0000 (09:56 -0400)]
Merge pull request #23761 from eileenmcnaughton/invalid_state_with_country

dev/core#3512 fix rc fatal error when state is invalid

2 years agoSetup - Remove CiviGrant from available components
Coleman Watts [Fri, 10 Jun 2022 16:25:32 +0000 (12:25 -0400)]
Setup - Remove CiviGrant from available components

Fixes dev/core#3485

2 years agoSearchKit - Fix angular console error when totalCount is not given
Coleman Watts [Fri, 10 Jun 2022 16:37:56 +0000 (12:37 -0400)]
SearchKit - Fix angular console error when totalCount is not given

Before: Error: [$compile:nonassign] Expression 'undefined' in attribute 'totalCount' used with directive 'crmSearchDisplayTable' is non-assignable!

After: Fixed, and totalCount still functions correctly for its indended purpose with SearchSegments.

2 years agoDeduepe - Fix form buttons (again)
Coleman Watts [Fri, 10 Jun 2022 16:08:52 +0000 (12:08 -0400)]
Deduepe - Fix form buttons (again)

Fixes dev/core#3421
Also see dev/core#3135
And the original cause: a6f2a80

2 years agoCatch & convert Guzzle exception
Eileen McNaughton [Sat, 11 Jun 2022 01:25:36 +0000 (13:25 +1200)]
Catch & convert Guzzle exception

2 years agodev/core#2706 fix activity import to update multi-select fields
Eileen McNaughton [Fri, 10 Jun 2022 23:57:49 +0000 (11:57 +1200)]
dev/core#2706 fix activity import to update multi-select fields

2 years agoFix target contact label back to include target
Eileen McNaughton [Fri, 10 Jun 2022 23:27:53 +0000 (11:27 +1200)]
Fix target contact label back to include target

2 years agodev/core#2325 import second-handling fix
Eileen McNaughton [Fri, 10 Jun 2022 06:50:53 +0000 (18:50 +1200)]
dev/core#2325 import second-handling fix

2 years agodev/core#3512 fix rc fatal error when state is invalid
Eileen McNaughton [Fri, 10 Jun 2022 23:09:20 +0000 (11:09 +1200)]
dev/core#3512 fix rc fatal error when state is invalid

2 years agodev/core#3511 Improve handling of invalid saved mapping fields
Eileen McNaughton [Fri, 10 Jun 2022 22:27:34 +0000 (10:27 +1200)]
dev/core#3511 Improve handling of invalid saved mapping fields

2 years agoMerge pull request #23756 from eileenmcnaughton/import_to_group
Tim Otten [Fri, 10 Jun 2022 22:27:59 +0000 (15:27 -0700)]
Merge pull request #23756 from eileenmcnaughton/import_to_group

dev/core#3160 fix inability to import 'just contactid' and add to group

2 years agoMerge pull request #23755 from eileenmcnaughton/import_ivory_coast
Tim Otten [Fri, 10 Jun 2022 21:58:48 +0000 (14:58 -0700)]
Merge pull request #23755 from eileenmcnaughton/import_ivory_coast

dev/core#3505, dev/core#3506 dev/core#3052 Import fixes for unicode url, Côte d’Ivoire

2 years agodev/core#3160 fix inability to import 'just contactid' and add to group
Eileen McNaughton [Fri, 10 Jun 2022 09:59:25 +0000 (21:59 +1200)]
dev/core#3160 fix inability to import 'just contactid' and add to group

2 years agodev/core#3505, dev/core#3506 Import fixes for unicode url, Côte d’Ivoire
Eileen McNaughton [Fri, 10 Jun 2022 08:32:46 +0000 (20:32 +1200)]
dev/core#3505, dev/core#3506 Import fixes for unicode url, Côte d’Ivoire

2 years agoSet version to 5.51.beta1
CiviCRM [Fri, 10 Jun 2022 07:34:02 +0000 (07:34 +0000)]
Set version to 5.51.beta1

2 years agoMerge pull request #23747 from eileenmcnaughton/import_contribution
Tim Otten [Fri, 10 Jun 2022 07:29:23 +0000 (00:29 -0700)]
Merge pull request #23747 from eileenmcnaughton/import_contribution

Remove some more unused code

2 years agoAdd integer validation to import
Eileen McNaughton [Fri, 10 Jun 2022 07:09:23 +0000 (19:09 +1200)]
Add integer validation to import

2 years agoMerge pull request #23750 from eileenmcnaughton/test_cruft
Seamus Lee [Fri, 10 Jun 2022 06:41:36 +0000 (16:41 +1000)]
Merge pull request #23750 from eileenmcnaughton/test_cruft

Reduce test output spam

2 years agoMerge pull request #23748 from eileenmcnaughton/guzzle
Seamus Lee [Fri, 10 Jun 2022 06:41:18 +0000 (16:41 +1000)]
Merge pull request #23748 from eileenmcnaughton/guzzle

Update guzzle to 6.5.7

2 years agoRemove some more unused code
Eileen McNaughton [Fri, 10 Jun 2022 01:05:36 +0000 (13:05 +1200)]
Remove some more unused code

2 years agoMerge pull request #23751 from eileenmcnaughton/test_member
Eileen McNaughton [Fri, 10 Jun 2022 04:51:53 +0000 (16:51 +1200)]
Merge pull request #23751 from eileenmcnaughton/test_member

Fix for failing test in master

2 years agoMerge pull request #23746 from totten/master-queue-flag
Eileen McNaughton [Fri, 10 Jun 2022 03:31:58 +0000 (15:31 +1200)]
Merge pull request #23746 from totten/master-queue-flag

CRM_Queue_Runner - Add basic/skeletal support for `runAllInteractively()`

2 years agoMerge pull request #23679 from totten/master-queue-tpl-inclusive
Eileen McNaughton [Fri, 10 Jun 2022 03:00:25 +0000 (15:00 +1200)]
Merge pull request #23679 from totten/master-queue-tpl-inclusive

Civi::queue() - Add support for 'template' queues

2 years agoMerge pull request #23744 from eileenmcnaughton/import_csv
Eileen McNaughton [Fri, 10 Jun 2022 02:59:43 +0000 (14:59 +1200)]
Merge pull request #23744 from eileenmcnaughton/import_csv

Fix unrelease regression - malformed MapField without skipColumnHeaders

2 years agoFix for failing test in master
Eileen McNaughton [Fri, 10 Jun 2022 02:06:46 +0000 (14:06 +1200)]
Fix for failing test in master

2 years agoMerge pull request #23745 from eileenmcnaughton/obsolete_activity
Eileen McNaughton [Fri, 10 Jun 2022 01:40:38 +0000 (13:40 +1200)]
Merge pull request #23745 from eileenmcnaughton/obsolete_activity

Remove obsolete/unused code, fix notices - activity import

2 years agoMerge pull request #23743 from totten/master-queue-runas
Eileen McNaughton [Fri, 10 Jun 2022 01:39:57 +0000 (13:39 +1200)]
Merge pull request #23743 from totten/master-queue-runas

CRM_Queue_Task - Track an optional `$runAs` property

2 years agoReduce test output spam
Eileen McNaughton [Fri, 10 Jun 2022 01:25:21 +0000 (13:25 +1200)]
Reduce test output spam

2 years agoUpdate guzzle to 6.5.7
Eileen McNaughton [Fri, 10 Jun 2022 01:08:19 +0000 (13:08 +1200)]
Update guzzle to 6.5.7

2 years agoFix unrelease regression - malformed MapField without skipColumnHeaders
Eileen McNaughton [Thu, 9 Jun 2022 23:01:33 +0000 (11:01 +1200)]
Fix unrelease regression - malformed MapField without skipColumnHeaders

2 years agoRemove obsolete/unused code - activity import
Eileen McNaughton [Thu, 9 Jun 2022 23:17:29 +0000 (11:17 +1200)]
Remove obsolete/unused code - activity import

2 years agoMerge pull request #23742 from eileenmcnaughton/import_remove
Eileen McNaughton [Thu, 9 Jun 2022 23:57:05 +0000 (11:57 +1200)]
Merge pull request #23742 from eileenmcnaughton/import_remove

Remove more obsolete import code

2 years agodemoqueue - Switch from `runAllViaWeb()` to `runAllInteractive()`
Tim Otten [Tue, 7 Jun 2022 10:32:31 +0000 (03:32 -0700)]
demoqueue - Switch from `runAllViaWeb()` to `runAllInteractive()`

2 years agoImplement runAllInteractive and assertRequirements*
Tim Otten [Tue, 7 Jun 2022 06:12:47 +0000 (23:12 -0700)]
Implement runAllInteractive and assertRequirements*

2 years agoCRM_Queue_Runner - runAllViaWeb should run exclusively via web
Tim Otten [Tue, 7 Jun 2022 02:36:12 +0000 (19:36 -0700)]
CRM_Queue_Runner - runAllViaWeb should run exclusively via web

This is a preventative measure.

2 years agocivicrm/queue/monitor - Add skeletal page for monitoring status
Tim Otten [Sat, 4 Jun 2022 08:09:42 +0000 (01:09 -0700)]
civicrm/queue/monitor - Add skeletal page for monitoring status

2 years agocrmQueueMonitor - Skeletal module
Tim Otten [Tue, 7 Jun 2022 00:31:57 +0000 (17:31 -0700)]
crmQueueMonitor - Skeletal module

2 years agoAdd experimental setting `enableBackgroundQueue`
Tim Otten [Sat, 4 Jun 2022 04:44:35 +0000 (21:44 -0700)]
Add experimental setting `enableBackgroundQueue`

2 years agoCRM_Queue_Runner - Conditionally inherit the queue's error-policy
Tim Otten [Tue, 7 Jun 2022 01:36:09 +0000 (18:36 -0700)]
CRM_Queue_Runner - Conditionally inherit the queue's error-policy

2 years agoFix test fatal
Eileen McNaughton [Thu, 9 Jun 2022 23:40:20 +0000 (11:40 +1200)]
Fix test fatal

2 years agoRemove more obsolete import code
Eileen McNaughton [Thu, 9 Jun 2022 22:32:23 +0000 (10:32 +1200)]
Remove more obsolete import code

2 years agoUserJob - Add property `is_template`
Tim Otten [Thu, 9 Jun 2022 23:32:45 +0000 (16:32 -0700)]
UserJob - Add property `is_template`

Eileen requested, and it's easiest to add now, and it seems safe+consistent.

2 years agoCivi::queue() - Add support for 'template' queues
Tim Otten [Fri, 3 Jun 2022 01:14:41 +0000 (18:14 -0700)]
Civi::queue() - Add support for 'template' queues

Overview
--------

Suppose you are in the habit of making separate queue-instances for
different batches of work.  However, you want to allow the sysadmin to
configure options like `type`, `batch_limit`, and `retry_interval`.

Solution: Make a template

After
-----

```php
// Use the API to register a template, eg
\Civi\Api4\Queue::create()->setValues([
  'name' => 'template-name',
  'is_template' => TRUE,
  ...
])->execute();

// Later, create a queue from the template
$q = Civi::queue('new-queue', ['template' => 'template-name']);
```

2 years agoQueue - Add column `is_template`
Tim Otten [Thu, 9 Jun 2022 23:09:43 +0000 (16:09 -0700)]
Queue - Add column `is_template`

2 years agoCRM_Queue_Task - Track an optional `$runAs` property
Tim Otten [Wed, 27 Oct 2021 07:12:50 +0000 (00:12 -0700)]
CRM_Queue_Task - Track an optional `$runAs` property

2 years agoMerge pull request #23740 from eileenmcnaughton/import_unused
Seamus Lee [Thu, 9 Jun 2022 22:46:40 +0000 (08:46 +1000)]
Merge pull request #23740 from eileenmcnaughton/import_unused

Remove unused functions

2 years agoMerge pull request #23737 from eileenmcnaughton/import_up_multi
colemanw [Thu, 9 Jun 2022 21:20:08 +0000 (17:20 -0400)]
Merge pull request #23737 from eileenmcnaughton/import_up_multi

Add upgrade for label to name conversion in `civicrm_mapping_field` for multiple custom imports

2 years agoMerge pull request #23712 from eileenmcnaughton/import_queue
colemanw [Thu, 9 Jun 2022 21:17:31 +0000 (17:17 -0400)]
Merge pull request #23712 from eileenmcnaughton/import_queue

Enable QueueRunner for all imports

2 years agoMerge pull request #23736 from eileenmcnaughton/import_multi
Eileen McNaughton [Thu, 9 Jun 2022 08:45:25 +0000 (20:45 +1200)]
Merge pull request #23736 from eileenmcnaughton/import_multi

dev/core#3498 Fix mishandled option values

2 years agoAdd missing test file
Eileen McNaughton [Thu, 9 Jun 2022 07:13:03 +0000 (19:13 +1200)]
Add missing test file