Tim Otten [Wed, 25 Apr 2018 23:42:58 +0000 (16:42 -0700)]
(NFC) Update version headers in `api/`
This looks like a new file that slipped through because it was roughly
contemporaneous with the previous fixup (
fee14197b427c1781e369e5bfd36816afad6d7ee).
Tim Otten [Wed, 25 Apr 2018 23:40:26 +0000 (16:40 -0700)]
(NFC) Update version headers in `tests/`
This is a simple administrative update to the headers. It's a follow-up to
https://github.com/civicrm/civicrm-core/pull/11999 (
fee14197b427c1781e369e5bfd36816afad6d7ee)
which addresses some files missed by the previous search.
Tim Otten [Wed, 25 Apr 2018 23:39:24 +0000 (16:39 -0700)]
(NFC) Update version headers in `header*`
This is a simple administrative update to the headers. It's a follow-up to
https://github.com/civicrm/civicrm-core/pull/11999 (
fee14197b427c1781e369e5bfd36816afad6d7ee)
which addresses some files missed by the previous search.
Tim Otten [Wed, 25 Apr 2018 23:34:53 +0000 (16:34 -0700)]
(NFC) Update version headers in `tools/`
This is a simple administrative update to the headers. It's a follow-up to
https://github.com/civicrm/civicrm-core/pull/11999 (
fee14197b427c1781e369e5bfd36816afad6d7ee)
which addresses some files missed by the previous search.
Tim Otten [Wed, 25 Apr 2018 23:34:32 +0000 (16:34 -0700)]
(NFC) Update version headers in `sql/`
This is a simple administrative update to the headers. It's a follow-up to
https://github.com/civicrm/civicrm-core/pull/11999 (
fee14197b427c1781e369e5bfd36816afad6d7ee)
which addresses some files missed by the previous search.
Tim Otten [Wed, 25 Apr 2018 23:28:13 +0000 (16:28 -0700)]
(NFC) Update version headers in `xml/`
This is a simple administrative update to the headers. It's a follow-up to
https://github.com/civicrm/civicrm-core/pull/11999 (
fee14197b427c1781e369e5bfd36816afad6d7ee).
This addresses a small discrepancy -- after running GenCode locally, some files would be changed
back to `version 4.7`. Now they'll stay as `version 5`.
Mathieu Lu [Tue, 24 Apr 2018 20:50:24 +0000 (16:50 -0400)]
Merge pull request #12009 from yashodha/translate_strings
Translate strings in "Report" UI, et al
Monish Deb [Tue, 24 Apr 2018 19:10:35 +0000 (00:40 +0530)]
Merge pull request #12023 from compucorp/refactor-case-type-tests
Add missing case type tests
colemanw [Tue, 24 Apr 2018 14:21:13 +0000 (10:21 -0400)]
Fix js lint issues
colemanw [Tue, 24 Apr 2018 14:15:56 +0000 (10:15 -0400)]
Merge pull request #12010 from JMAConsulting/dev-core-70
(dev/core/issues/70) On any custom search 'Print selected rows' action doesn't retain columns/values
René Olivo [Tue, 24 Apr 2018 00:02:04 +0000 (20:02 -0400)]
Add tests for CaseTypeListCtrl's revertCaseType method
René Olivo [Mon, 23 Apr 2018 23:54:34 +0000 (19:54 -0400)]
Add tests for CaseTypeListCtrl's deleteCaseType method
René Olivo [Mon, 23 Apr 2018 23:26:43 +0000 (19:26 -0400)]
Add tests for CaseTypeListCtrl's toggleCaseType method
René Olivo [Mon, 23 Apr 2018 23:15:56 +0000 (19:15 -0400)]
Add test for caseTypeListCtrl case types storage
René Olivo [Mon, 23 Apr 2018 23:09:03 +0000 (19:09 -0400)]
Define common dependencies at the top of the spec file
yashodha [Mon, 23 Apr 2018 05:59:52 +0000 (11:29 +0530)]
more fixes
Monish Deb [Mon, 23 Apr 2018 04:06:46 +0000 (09:36 +0530)]
Merge pull request #12017 from colemanw/Improve
Improve input handling in get-cases AJAX API
Monish Deb [Mon, 23 Apr 2018 03:55:06 +0000 (09:25 +0530)]
Merge pull request #12014 from seamuslee001/dev_core_65
dev/core#65 Fix issue where source for participant could be entered w…
Eileen McNaughton [Mon, 23 Apr 2018 02:38:14 +0000 (14:38 +1200)]
Merge pull request #12018 from civicrm/5.1
5.1
Eileen McNaughton [Mon, 23 Apr 2018 02:37:53 +0000 (14:37 +1200)]
Merge pull request #12008 from totten/5.1-relnote-footer
footer.tpl - Change the URL formula pointing to the release notes
Coleman Watts [Mon, 23 Apr 2018 01:36:07 +0000 (21:36 -0400)]
Improve input handling in get-cases AJAX API
Seamus Lee [Sun, 22 Apr 2018 07:29:05 +0000 (17:29 +1000)]
dev/core#65 Fix issue where source for participant could be entered which is longer than allowable in the databse
Update files to use metadata approach as per monish and Eileen
Eileen McNaughton [Sat, 21 Apr 2018 03:38:45 +0000 (15:38 +1200)]
Merge pull request #11990 from vinuvarshith/entity-unique-fields-api-call
Add New API Call To Get All Unique Fields For Given Entity
Seamus Lee [Fri, 20 Apr 2018 22:09:27 +0000 (08:09 +1000)]
Merge pull request #11972 from eileenmcnaughton/sch
CRM-19885 / dev/core/issues/36 fix fatal error on scheduled reminders due to no default
deb.monish [Fri, 20 Apr 2018 20:40:37 +0000 (02:10 +0530)]
(dev/core/issues/70) On any custom search 'Print selected rows' action doesn't retain columns/values
yashodha [Fri, 20 Apr 2018 09:23:17 +0000 (14:53 +0530)]
translate more strings
yashodha [Fri, 20 Apr 2018 09:16:43 +0000 (14:46 +0530)]
translate more strings
yashodha [Fri, 20 Apr 2018 09:10:43 +0000 (14:40 +0530)]
translate more strings
Tim Otten [Fri, 20 Apr 2018 02:04:09 +0000 (19:04 -0700)]
footer.tpl - The release notes URL should be more maintainable
Overview
----------------------------------------
Change the URL formula pointing to the release notes.
Before
----------------------------------------
The formula was `https://github.com/civicrm/civicrm-core/blob/{$version}/release-notes/{$version}.md`. Because the URL
points to a tag on Github, it's hard to make any corrections if something has changed or gone wrong.
After
----------------------------------------
The formula is `https://download.civicrm.org/about/{$version}`, which corresponds to
[civicrm-dist-manager's AboutController](https://github.com/civicrm/civicrm-dist-manager/blob/master/src/CiviDistManagerBundle/Controller/AboutController.php).
eileen [Fri, 13 Apr 2018 02:52:09 +0000 (14:52 +1200)]
CRM-19885 / dev/core/issues/36 fix fatal error on scheduled reminders due to no default
Eileen McNaughton [Thu, 19 Apr 2018 21:04:06 +0000 (09:04 +1200)]
Merge pull request #11993 from jaapjansma/issue_66
Standardise Address code in Contact summary report & enable links
Eileen McNaughton [Thu, 19 Apr 2018 20:48:56 +0000 (08:48 +1200)]
Merge pull request #11967 from seamuslee001/dev_translation_9
dev/translation#9 Create API Action to rebuild Multilingual Schema
Eileen McNaughton [Thu, 19 Apr 2018 20:46:18 +0000 (08:46 +1200)]
Merge pull request #12006 from civicrm/5.1
5.1 merge to master
Eileen McNaughton [Thu, 19 Apr 2018 20:43:35 +0000 (08:43 +1200)]
Merge pull request #12005 from eileenmcnaughton/5.1
core/issues/64 - In custom searches, column headings are being ignored
Jitendra Purohit [Thu, 19 Apr 2018 12:21:42 +0000 (17:51 +0530)]
core/issues/64 - In custom searches, column headings are being ignored
Eileen McNaughton [Thu, 19 Apr 2018 20:04:42 +0000 (08:04 +1200)]
Merge pull request #12001 from jitendrapurohit/core-64
core/issues/64 - In custom searches, column headings are being ignored
Jaap Jansma [Wed, 18 Apr 2018 09:00:36 +0000 (11:00 +0200)]
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
Work on issue 66 (https://lab.civicrm.org/dev/core/issues/66)
varshith89 [Thu, 19 Apr 2018 12:54:11 +0000 (12:54 +0000)]
Set API Function Name Case To All Lowercase
Jitendra Purohit [Thu, 19 Apr 2018 12:21:42 +0000 (17:51 +0530)]
core/issues/64 - In custom searches, column headings are being ignored
Monish Deb [Thu, 19 Apr 2018 11:13:15 +0000 (16:43 +0530)]
Merge pull request #11992 from mydropwizard/merge-contact
Fix the contact merge form on Drupal 8
Seamus Lee [Tue, 10 Apr 2018 21:31:30 +0000 (07:31 +1000)]
dev/translation#9 Create API Action to rebuild Multilingual Schema
Eileen McNaughton [Thu, 19 Apr 2018 08:21:35 +0000 (20:21 +1200)]
Merge pull request #11999 from totten/master-header
(NFC) Update version in header
Tim Otten [Thu, 19 Apr 2018 05:18:39 +0000 (22:18 -0700)]
(NFC) Update version in header
This is a simple administrative update to the headers. It was generated with the command:
```
rgrep '| CiviCRM version 4.7' CRM/ Civi ang api bin extern install/ settings/ templates -l \
| xargs sed -i'' "s/| CiviCRM version 4.7/| CiviCRM version 5 /g"
```
Tthe inclusion of `|` aimed to avoid matching any non-header text (e.g. inline docs that
mentioned the version incidentally). But then I did a looser search and for just
```
rgrep 'CiviCRM version 4.7'
````
and manually patched the remainder.
Note: I'm not really keen on doing this every month, so I relaxed the header
statement -- instead of `CiviCRM version 5.0`, it's just `CiviCRM version 5`.
colemanw [Thu, 19 Apr 2018 02:39:28 +0000 (22:39 -0400)]
Merge pull request #11991 from totten/5.1-vernum
VersionCheck - Get more nuanced messages from latest.civicrm.org
colemanw [Thu, 19 Apr 2018 01:41:18 +0000 (21:41 -0400)]
Merge pull request #11986 from eileenmcnaughton/test
Namespace exception in test
colemanw [Thu, 19 Apr 2018 01:39:08 +0000 (21:39 -0400)]
Merge pull request #11853 from compucorp/CRM-21849-inline-relationship-type-edit
CRM-21849: Inline Relationship Type Edit
Seamus Lee [Thu, 19 Apr 2018 01:29:41 +0000 (11:29 +1000)]
Merge pull request #11995 from eileenmcnaughton/odd
Fix intermittant test bug
Seamus Lee [Wed, 18 Apr 2018 21:55:54 +0000 (07:55 +1000)]
Merge pull request #11963 from JMAConsulting/dev-mail-8
(dev/mail/8) Using ACL to restrict mailing recipients leads to fatal error
Seamus Lee [Wed, 18 Apr 2018 21:39:39 +0000 (07:39 +1000)]
Merge pull request #11984 from eileenmcnaughton/5.1.1
Fix trigger generation for modified_date on custom data
eileen [Wed, 18 Apr 2018 14:28:39 +0000 (02:28 +1200)]
Fix intermittant test bug
varshith89 [Wed, 18 Apr 2018 19:00:26 +0000 (19:00 +0000)]
Add Unit Tests For getunique API get
varshith89 [Wed, 18 Apr 2018 18:59:39 +0000 (18:59 +0000)]
Use indices Function In DAOs Instead Of SQL Query
Tim Otten [Wed, 18 Apr 2018 00:41:11 +0000 (17:41 -0700)]
VersionCheck - Get more nuanced messages from latest.civicrm.org
Overview
----------------------------------------
Get fully-formed upgrade messages from `latest.civicrm.org`. This allows us to convey more nuanced information about available upgrades.
It also allows us to iterate more quickly on how releases are presented (e.g. adding hyperlinks to the blog/changelog, highlighting
important changes, introducing the in-between status `deprecated`).
Before
----------------------------------------
The `VersionCheck` helper sends a request to `latest.civicrm.org` with `format=json` to get a list of all available versions.
Then it digests the information and presents any messages in the `CRM_Utils_Check` layer.
After
----------------------------------------
The `VersionCheck` helper sends a request to `latest.civicrm.org` with `format=summary` to get a list of displayable messages.
Then it presents any messages in the `CRM_Utils_Check` layer.
Technical Details
----------------------------------------
* Because patch-releases are allowed mid-month, this patch also reduces the TTL from 7 days to 3 days.
* Test coverage is reduced here (`civicrm-core`), but it's improved a lot elsewhere (`latest.civicrm.org`).
* In `VersionCheck`, it makes a few contract changes (which have been evaluated by grepping for stale references circa 4.7.31). Specifically:
* Add `getVersionMessages()`
* Remove unnecessary members `$localMajorVersion`, `getMajorVersion()`, `isNewerVersionAvailable()`, `checkBranchForNewVersion()`
* Change the content of `versionInfo`. It's still a cache of the web-service response, but now it's a list of displayable messages (rather than a list of all versions).
colemanw [Wed, 18 Apr 2018 13:41:07 +0000 (09:41 -0400)]
Merge pull request #11979 from compucorp/fix-crm-add-name-directive
Fix select2 value updation for crmAddName Directive
deb.monish [Wed, 18 Apr 2018 12:21:24 +0000 (17:51 +0530)]
use Civi::static in place of static variable
Eileen McNaughton [Wed, 18 Apr 2018 09:23:33 +0000 (21:23 +1200)]
Merge pull request #11971 from lcdservices/dev-financial-11
dev/financial#11 email invoice fails with validation error
David Snopek [Wed, 18 Apr 2018 03:12:51 +0000 (22:12 -0500)]
Fix the contact merge form on Drupal 8
Eileen McNaughton [Tue, 17 Apr 2018 23:16:37 +0000 (11:16 +1200)]
Merge pull request #11988 from yashodha/translate_strings
translate strings
varshith89 [Tue, 17 Apr 2018 14:18:37 +0000 (14:18 +0000)]
Add New API Call To Get All Unique Fields For Given Entity
yashodha [Tue, 17 Apr 2018 11:34:12 +0000 (17:04 +0530)]
translate strings
Eileen McNaughton [Tue, 17 Apr 2018 09:00:31 +0000 (21:00 +1200)]
Merge pull request #11985 from JMAConsulting/devcore48
dev/core#48 Fix PDF Letter only generates a single letter when multiple contact IDs are specified
Michael Devery [Tue, 17 Apr 2018 08:50:28 +0000 (09:50 +0100)]
CRM-21849: Remove limit on API call
Eileen McNaughton [Tue, 17 Apr 2018 08:27:26 +0000 (20:27 +1200)]
Merge pull request #11973 from lcdservices/master
dev/core#59 scheduled reminder email validation
Eileen McNaughton [Tue, 17 Apr 2018 08:22:09 +0000 (20:22 +1200)]
Merge pull request #11987 from civicrm/5.1
5.1 merge to master
eileen [Tue, 17 Apr 2018 08:08:57 +0000 (20:08 +1200)]
Namespace exception in test
Monish Deb [Tue, 17 Apr 2018 07:12:53 +0000 (12:42 +0530)]
Merge pull request #11976 from eileenmcnaughton/5.1
Fix failure to render dedupe page
deb.monish [Tue, 17 Apr 2018 06:53:51 +0000 (12:23 +0530)]
additional fix
Matthew Wire [Thu, 5 Apr 2018 10:04:08 +0000 (11:04 +0100)]
dev/core/48 Fix PDF Letter only generates a single letter when multiple contact IDs are specified
eileen [Tue, 17 Apr 2018 00:03:00 +0000 (12:03 +1200)]
Fix trigger generation for modified_date on custom data
In 4.7.25 https://github.com/civicrm/civicrm-core/pull/10754/commits introduced
some modifications to the generation of triggers to update the modified date field.
It basically derived the entity being extended by a table and then if that entity had a
modified_date field then a trigger would be created to update that field.
However, a bug in the CRM_Core_BAO_CustomGroup::getAllCustomGroupsByBaseEntity function
meant that incorrect additional tables are also being updated for custom fields.
For entities extending contact the contact table AND the mailing table are updated. e.g
```
CREATE TRIGGER {mycustomtable}...
UPDATE civicrm_contact SET modified_date = CURRENT_TIMESTAMP WHERE id = NEW.entity_id;
UPDATE civicrm_mailing SET modified_date = CURRENT_TIMESTAMP WHERE id = NEW.entity_id;
```
For entities that extend tables that should not attract a trigger ONLY
the mailing table is updated.
The bug in CRM_Core_BAO_CustomGroup::getAllCustomGroupsByBaseEntity is that it adds the
WHERE clause 'AND extends IN ($entityType)' ONLY if $entityType is in a whitelist.
Invalid entities result in no filtering.
As a fix using a whitelist is no longer valid - we support any entity that might
be configured now so simply filtering on the entity makes sense.
Other paths to this function seem unlikely to pass in invalid entities & hence trigger this bug.
Monish Deb [Tue, 17 Apr 2018 05:29:16 +0000 (10:59 +0530)]
Merge pull request #11982 from eileenmcnaughton/enotice
E-notice fix
Herb [Mon, 16 Apr 2018 23:45:37 +0000 (19:45 -0400)]
issue 63 clarify permission descriptions (#11981)
* issue 63 clarify permission descriptions
* fix syntax
eileen [Mon, 16 Apr 2018 22:43:48 +0000 (10:43 +1200)]
E-notice fix
Eileen McNaughton [Mon, 16 Apr 2018 22:27:45 +0000 (10:27 +1200)]
Merge pull request #11887 from eileenmcnaughton/date
CRM-21148 - Refactor two near-identical date functions into one
Eileen McNaughton [Mon, 16 Apr 2018 21:24:53 +0000 (09:24 +1200)]
Merge pull request #11978 from eileenmcnaughton/profile
CRM-20598 Phone ext in profile edit mode is messing up with address
Michael Devery [Mon, 16 Apr 2018 15:33:38 +0000 (16:33 +0100)]
CRM-21849: Load contactTypes in PHP, not JS
Michael Devery [Mon, 16 Apr 2018 15:10:17 +0000 (16:10 +0100)]
CRM-21849: Post-review cleanup
colemanw [Mon, 16 Apr 2018 13:56:00 +0000 (09:56 -0400)]
Merge pull request #11755 from colemanw/AllCoreTables
AllCoreTables - Generate file every time
Michael Devery [Mon, 16 Apr 2018 12:06:05 +0000 (13:06 +0100)]
CRM-21849: Switch loading relationship data from backend to frontend
The formatting of relationship data is a FE related task and can be done
in Javascript. This also allows reloading the data if some options
change after editing relationship types.
Debarshi Bhaumik [Mon, 16 Apr 2018 11:27:37 +0000 (16:57 +0530)]
Fix select2 value updation for crmAddName Directive
Michael Devery [Tue, 27 Mar 2018 15:06:09 +0000 (16:06 +0100)]
CRM-21849: Include data in event after enable/disable
The logic on whether to refresh the available options in CRM.popup
depends on whether the crmPopupFormSuccess returned data. The data
provided here is arbitrary but could be useful in the future for anyone
reacting to the event
Michael Devery [Tue, 27 Mar 2018 13:43:56 +0000 (14:43 +0100)]
CRM-21849: Change to loose comparison
Based on the docblock I expected contact ID to be an int, but this is
not always the case.
Michael Devery [Wed, 21 Mar 2018 16:34:11 +0000 (16:34 +0000)]
CRM-21849: Add getoptions spec params for relationship_type_id
Michael Devery [Wed, 21 Mar 2018 16:33:52 +0000 (16:33 +0000)]
CRM-21849: Allow spec modification for getoptions
Allows to modify spec even if generic getoptions function is used
Michael Devery [Wed, 21 Mar 2018 16:32:58 +0000 (16:32 +0000)]
CRM-21849: Allow adding option_context to elements
This is used when some extra parameters are required when refreshing
option lists after inline editing, i.e. relationship types are
limited to the current contact type
Michael Devery [Wed, 21 Mar 2018 16:31:08 +0000 (16:31 +0000)]
CRM-21849: Cast contact_id_a before comparison
This property will be a string, but it is being compared to $contactID
which should be an int.
Michael Devery [Wed, 21 Mar 2018 16:29:54 +0000 (16:29 +0000)]
CRM-21849: Support fetching options for relationship type
deb.monish [Tue, 10 Apr 2018 13:13:50 +0000 (18:43 +0530)]
(dev/mail/6) Using ACL to restrict mailing recipients leads to fatal error
Seamus Lee [Mon, 16 Apr 2018 06:39:18 +0000 (16:39 +1000)]
Merge pull request #11953 from eileenmcnaughton/section_fail
Prevent hard-fail when section header / group by option chosen on logging report
Monish Deb [Mon, 16 Apr 2018 06:05:51 +0000 (11:35 +0530)]
Merge pull request #11658 from eileenmcnaughton/criteria
CRM-21753 add pass-through support for criteria in urls on dedupe pages
Eileen McNaughton [Mon, 16 Apr 2018 05:24:14 +0000 (17:24 +1200)]
Merge pull request #10988 from jmcclelland/CRM-21194
CRM-21194 - ensure distinct count of clickable URLs works.
Samuel Vanhove [Mon, 16 Apr 2018 04:42:34 +0000 (16:42 +1200)]
CRM-20598 Phone ext in profile edit mode is messing up with address
eileen [Mon, 16 Apr 2018 03:57:30 +0000 (15:57 +1200)]
CRM-21148 revert back to odd handling when NULL passed to getFromTo, deprecate
Jon goldberg [Wed, 28 Mar 2018 08:56:44 +0000 (21:56 +1300)]
CRM-21148 change form function to wrap Date function
Jon goldberg [Wed, 28 Mar 2018 08:30:50 +0000 (21:30 +1300)]
CRM-21148 - Refactor two near-identical functions into one
eileen [Mon, 16 Apr 2018 00:20:37 +0000 (12:20 +1200)]
Fix failure to render dedupe page
Monish Deb [Fri, 13 Apr 2018 13:05:08 +0000 (18:35 +0530)]
Merge pull request #11657 from eileenmcnaughton/more_speed
CRM-19752 Fix slow query on contribution dash.
deb.monish [Fri, 13 Apr 2018 12:43:56 +0000 (18:13 +0530)]
test failure fix
Coleman Watts [Thu, 8 Mar 2018 03:21:43 +0000 (22:21 -0500)]
CRM_Core_CodeGen_Util_Template - simplify beautification param
Tim Otten [Thu, 8 Mar 2018 01:51:59 +0000 (17:51 -0800)]
AllCoreTables.data.php - Don't pass through PHP_Beautifier. Update layout.
Tim Otten [Thu, 8 Mar 2018 01:48:03 +0000 (17:48 -0800)]
CRM_Core_CodeGen_Util_Template - Make PHPBeautifier optional