eileen [Sun, 13 Jan 2019 22:59:15 +0000 (11:59 +1300)]
Replace ->assign with CRM_Core_Smarty::singleton()->assign in preparation for making function shareable
Per PR 1330 there is an intention to make this form receipting function a shared function. Part of making it sharable is making it static.
This is a preparatory refactor towards that end, getting rid of the 'this' in assigning variables to smarty
Seamus Lee [Fri, 11 Jan 2019 20:46:29 +0000 (07:46 +1100)]
Merge pull request #13412 from mattwire/extract_customData
REF Convert forms to standard customData template
Matthew Wire (MJW Consulting) [Fri, 11 Jan 2019 18:55:07 +0000 (18:55 +0000)]
Don't call getEntitySubTypeId if a subType is not defined
colemanw [Fri, 11 Jan 2019 16:10:20 +0000 (11:10 -0500)]
Merge pull request #13134 from agileware/CIVICRM-1006
dev/core#500 Fix user-specific Case filtering on dashboard and searches to exclude cases from inactive relationships
Yashodha Chaku [Fri, 11 Jan 2019 13:22:44 +0000 (18:52 +0530)]
Merge pull request #13433 from colemanw/actSub
Fix undefined index warning
colemanw [Fri, 11 Jan 2019 00:54:50 +0000 (19:54 -0500)]
Merge pull request #13377 from eileenmcnaughton/activity_extract2
Fix activity.getcount function to filter out unpermitted activities.
Seamus Lee [Thu, 10 Jan 2019 20:05:40 +0000 (07:05 +1100)]
Merge pull request #13409 from yashodha/dev-646
(dev/core#646) Event date sorting doesn't work for ical listing
Coleman Watts [Thu, 10 Jan 2019 17:05:23 +0000 (12:05 -0500)]
Fix undefined index warning
Seamus Lee [Thu, 10 Jan 2019 10:08:16 +0000 (21:08 +1100)]
Merge pull request #13430 from civicrm/5.10
5.10
Seamus Lee [Thu, 10 Jan 2019 10:03:41 +0000 (21:03 +1100)]
Merge pull request #13429 from seamuslee001/5.10
Port Test fixes to 5.10
Seamus Lee [Mon, 7 Jan 2019 21:17:13 +0000 (08:17 +1100)]
(NFC) Ensure that when loading in the test data it is done with UTF8 encoding
Seamus Lee [Mon, 7 Jan 2019 23:55:29 +0000 (10:55 +1100)]
(dev/core#647) Fix up Test Class names and file names to ensure all test classes are run by Jenkins
Seamus Lee [Tue, 8 Jan 2019 01:18:10 +0000 (12:18 +1100)]
(dev/core#647) Fix Up Contact Selector Test by changing class name to get test to run and make changes following code changes that affect clauses and calling get rows
CRM_Contact_SelectorTest - Fix escaping
(dev/core#217) CRM_Contact_SelectorTest - Remove stale/unnecessary assertion
The table `civicrm_prevnext_cache` includes three columns (`entity_id1`,
`entity_id2`, `entity_table`). These columns have some use-cases (e.g. for
deduping) and some historical value, but the only one needed for
caching search-results is `entity_id1`.
dev/core#217 introduced an interface `CRM_Core_PrevNextCache_Interface` for
caching search-results. This interface only passes through a list of CID's
(effectively `entity_id1`); because we don't need `entity_id2` and
`entity_table`, it makes no provisions for passing them through, and they're
not saved. This simplifies the interface and makes it more realistic to
implement alternative prevnext storage mechanisms.
colemanw [Thu, 10 Jan 2019 02:39:47 +0000 (21:39 -0500)]
Merge pull request #13211 from eileenmcnaughton/search_grant
dev/core#561 Convert grant search fields to use datepicker
colemanw [Thu, 10 Jan 2019 02:39:27 +0000 (21:39 -0500)]
Merge pull request #13395 from eileenmcnaughton/datepicker-update
Add routine for updating smartgroups, currently handling datepicker conversion
Seamus Lee [Wed, 9 Jan 2019 23:51:10 +0000 (10:51 +1100)]
Merge pull request #13426 from eileenmcnaughton/report_instance_domain
Add default for domain_id for report_instance.
Eileen McNaughton [Wed, 9 Jan 2019 19:55:33 +0000 (08:55 +1300)]
Merge pull request #13428 from mattwire/nfc_membership_function
REF Remove redundant function
Matthew Wire (MJW Consulting) [Wed, 9 Jan 2019 15:27:17 +0000 (15:27 +0000)]
Remove redundant function
Alok Patel [Wed, 9 Jan 2019 07:24:08 +0000 (12:54 +0530)]
CIVICRM-1128: Added Unit Tests to validate the Case counts when case role is active/inactive.
Eileen McNaughton [Wed, 9 Jan 2019 05:13:29 +0000 (18:13 +1300)]
Merge pull request #13416 from seamuslee001/647_selector_test
(dev/core#647) Fix Up Contact Selector Test by changing class name to…
eileen [Wed, 9 Jan 2019 05:11:35 +0000 (18:11 +1300)]
Add default for domain_id for report_instance.
This is consistent with other api like Job, MembershipType, PaymentProcessor
Mathieu Lu [Wed, 9 Jan 2019 00:02:35 +0000 (19:02 -0500)]
Merge pull request #13424 from seamuslee001/dev-drupal-43
dev/drupal#43 Update composer requirement on PSR Log and civicrm-cxn-…
Seamus Lee [Tue, 8 Jan 2019 01:18:10 +0000 (12:18 +1100)]
(dev/core#647) Fix Up Contact Selector Test by changing class name to get test to run and make changes following code changes that affect clauses and calling get rows
CRM_Contact_SelectorTest - Fix escaping
(dev/core#217) CRM_Contact_SelectorTest - Remove stale/unnecessary assertion
The table `civicrm_prevnext_cache` includes three columns (`entity_id1`,
`entity_id2`, `entity_table`). These columns have some use-cases (e.g. for
deduping) and some historical value, but the only one needed for
caching search-results is `entity_id1`.
dev/core#217 introduced an interface `CRM_Core_PrevNextCache_Interface` for
caching search-results. This interface only passes through a list of CID's
(effectively `entity_id1`); because we don't need `entity_id2` and
`entity_table`, it makes no provisions for passing them through, and they're
not saved. This simplifies the interface and makes it more realistic to
implement alternative prevnext storage mechanisms.
Eileen McNaughton [Tue, 8 Jan 2019 23:18:36 +0000 (12:18 +1300)]
Merge pull request #13419 from tschuettler/37-dev-mail
dev/mail#37 - Replace non-supported 4-byte unicode characters in bounce processing
Seamus Lee [Tue, 8 Jan 2019 20:38:21 +0000 (07:38 +1100)]
dev/mail#43 Update composer requirement on PSR Log and civicrm-cxn-rpc to fix compatability issue with psr/log from Drupal8
Seamus Lee [Tue, 8 Jan 2019 22:46:43 +0000 (09:46 +1100)]
Merge pull request #13422 from colemanw/dev/core#561
dev/core#561 - Convert campaign form date fields
Seamus Lee [Tue, 8 Jan 2019 20:31:18 +0000 (07:31 +1100)]
Merge pull request #13423 from colemanw/dev/core#561-followup
dev/core#561 - Convert activity followup form date field
Seamus Lee [Tue, 8 Jan 2019 20:21:46 +0000 (07:21 +1100)]
Merge pull request #13420 from yashodha/dev-649
(dev/core#649) DB error on Find Activities with follow up criteria
Coleman Watts [Tue, 8 Jan 2019 18:18:12 +0000 (13:18 -0500)]
dev/core#561 - Convert activity followup form date field
Coleman Watts [Tue, 8 Jan 2019 17:08:39 +0000 (12:08 -0500)]
dev/core#561 - Convert campaign form date fields
yashodha [Tue, 8 Jan 2019 14:34:15 +0000 (20:04 +0530)]
(dev/core#649) DB error on Find Activities with follow up criteria
colemanw [Tue, 8 Jan 2019 13:34:51 +0000 (08:34 -0500)]
Merge pull request #13394 from totten/master-srchcache
(dev/core#635) Reduce unnecessary SQL writes
Thomas Schüttler [Tue, 8 Jan 2019 12:55:50 +0000 (13:55 +0100)]
Replace 4-byte utf8 characters with unicode replacement character
Thomas Schüttler [Tue, 8 Jan 2019 12:38:07 +0000 (13:38 +0100)]
Add unit test for utf8mb4 unicode character
Seamus Lee [Tue, 8 Jan 2019 07:40:38 +0000 (18:40 +1100)]
Merge pull request #12923 from vinuvarshith/scheduled-reminders-error-fix
dev/core#434: Check If 'absolute_date' Is Used In 'prepareRepetitionEndFilter' To Prevent SQL Error
Seamus Lee [Tue, 8 Jan 2019 05:05:06 +0000 (16:05 +1100)]
Merge pull request #13415 from seamuslee001/nfc_test_file_fixes
(dev/core#647) Fix up Test Class names and file names to ensure all t…
Eileen McNaughton [Tue, 8 Jan 2019 02:33:18 +0000 (15:33 +1300)]
Merge pull request #13417 from civicrm/5.10
5.10
Seamus Lee [Tue, 8 Jan 2019 02:28:30 +0000 (13:28 +1100)]
Merge pull request #13414 from eileenmcnaughton/count
Fix php 7.2 countable warning
Seamus Lee [Mon, 7 Jan 2019 23:55:29 +0000 (10:55 +1100)]
(dev/core#647) Fix up Test Class names and file names to ensure all test classes are run by Jenkins
eileen [Mon, 7 Jan 2019 22:32:03 +0000 (11:32 +1300)]
Fix php 7.2 countable warning
per https://lab.civicrm.org/dev/core/issues/406#note_12393
Warning: count(): Parameter must be an array or an object that implements Countable in CRM_Event_Form_Participant->submit() (line 1722 of .../all/modules/civicrm/CRM/Event/Form/Participant.php).
Eileen McNaughton [Mon, 7 Jan 2019 22:52:26 +0000 (11:52 +1300)]
Merge pull request #13252 from jmcclelland/issue586
PCP report - fix number of donors and total committed.
Eileen McNaughton [Mon, 7 Jan 2019 22:51:44 +0000 (11:51 +1300)]
Merge pull request #13413 from seamuslee001/nfc_test_utf8
(NFC) Ensure that when loading in the test data it is done with UTF8 …
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:55:53 +0000 (17:55 +0000)]
Convert Membership/Membership Renewal forms to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:55:27 +0000 (17:55 +0000)]
Convert Grant form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:55:10 +0000 (17:55 +0000)]
Convert Manage Event Info form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:54:40 +0000 (17:54 +0000)]
Convert UpdateSubscription form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:54:22 +0000 (17:54 +0000)]
Convert contribution form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:53:14 +0000 (17:53 +0000)]
Convert activity form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:51:24 +0000 (17:51 +0000)]
Convert case/case activity forms to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:50:09 +0000 (17:50 +0000)]
Convert Survey/Petition to standard customData template
Seamus Lee [Mon, 7 Jan 2019 21:17:13 +0000 (08:17 +1100)]
(NFC) Ensure that when loading in the test data it is done with UTF8 encoding
Jamie McClelland [Tue, 11 Dec 2018 21:40:58 +0000 (16:40 -0500)]
PCP report - fix number of donors and total committed.
ensure number of donors and committed are properly calculated in the PCP
report.
See: https://lab.civicrm.org/dev/core/issues/586
colemanw [Mon, 7 Jan 2019 19:43:20 +0000 (14:43 -0500)]
Merge pull request #13411 from mattwire/fix_buildCustomDataTwice
Membership custom fields sometimes don't display
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 16:29:06 +0000 (16:29 +0000)]
Fix build custom data twice on edit forms
Monish Deb [Mon, 7 Jan 2019 12:28:43 +0000 (17:58 +0530)]
Merge pull request #13408 from seamuslee001/lab_core_644
(dev/core#644) Add in unit test showing backend able to handle user e…
yashodha [Mon, 7 Jan 2019 09:25:39 +0000 (14:55 +0530)]
(dev/core#646) Event date sorting doesn't work for ical listing
Monish Deb [Mon, 7 Jan 2019 07:27:41 +0000 (12:57 +0530)]
Merge pull request #13407 from MegaphoneJon/core-644
core#644 - extract function to return correct mailbox header
Seamus Lee [Mon, 7 Jan 2019 03:41:25 +0000 (14:41 +1100)]
(dev/core#644) Add in unit test showing backend able to handle user email address as from email sensibly
Seamus Lee [Mon, 7 Jan 2019 00:02:00 +0000 (11:02 +1100)]
Merge pull request #13393 from eileenmcnaughton/free
dev/core#562 remove calls to dao->free() from api folder
Eileen McNaughton [Sun, 6 Jan 2019 21:53:11 +0000 (10:53 +1300)]
Merge pull request #13402 from pradpnayak/ReportDelete
Donot show delete task option on create new report
Jon Goldberg [Sun, 6 Jan 2019 21:02:55 +0000 (16:02 -0500)]
rename function and vars; move fix to common mail sending function
Seamus Lee [Sun, 6 Jan 2019 19:31:56 +0000 (06:31 +1100)]
Merge pull request #13397 from pradpnayak/AddressCustomFieldFix
dev/core/issues/636 - Custom field for Address: The "No" value is not defaulted
Jon Goldberg [Sat, 5 Jan 2019 20:46:25 +0000 (15:46 -0500)]
core#644 - extract function to return correct mailbox header
Seamus Lee [Sat, 5 Jan 2019 20:30:29 +0000 (07:30 +1100)]
Merge pull request #13406 from eileenmcnaughton/api_getsingle
Fix bug where getsingle calls chained actions twice
Seamus Lee [Sat, 5 Jan 2019 20:23:31 +0000 (07:23 +1100)]
Merge pull request #13405 from davejenx/core-640-repeat-activity-permission
Don't require CiviEvent permission to create repeating activity
Eileen McNaughton [Sat, 5 Jan 2019 08:29:49 +0000 (21:29 +1300)]
Merge pull request #13318 from eileenmcnaughton/api_perm
Do not check financial permissions on contribution.create if check_perrmissions is FALSE.
eileen [Fri, 4 Jan 2019 22:24:20 +0000 (11:24 +1300)]
dev/core#643 fix for double delete attempt when chained with getsingle
eileen [Fri, 4 Jan 2019 22:21:24 +0000 (11:21 +1300)]
dev/core#643 Add test for bug with double chaining on getsingle
eileen [Wed, 19 Dec 2018 05:17:40 +0000 (18:17 +1300)]
Do not check financial permissions on contribution.create if check_permissions is FALSE.
Our standard is to only check permissions at the api layer if check_permissions is TRUE
(which is is by default for javascript calls but not in php calls)
Eileen McNaughton [Fri, 4 Jan 2019 21:05:16 +0000 (10:05 +1300)]
Merge pull request #13396 from tschuettler/36-dev-mail
dev/mail#36 - Fix invalid unicode characters in bounce processing
Dave Jenkins [Fri, 4 Jan 2019 17:59:51 +0000 (17:59 +0000)]
dev/core/issues/640: don't require 'access CiviEvent' permission for civicrm/recurringentity/preview.
Pradeep Nayak [Fri, 4 Jan 2019 15:51:08 +0000 (15:51 +0000)]
Donot show delete task option on create new report
Thomas Schüttler [Fri, 4 Jan 2019 12:49:02 +0000 (13:49 +0100)]
Make class name match the filepath make tests run
Pradeep Nayak [Fri, 4 Jan 2019 11:25:37 +0000 (11:25 +0000)]
dev/core/issues/636 - Check if value is isset rather empty
Yashodha Chaku [Fri, 4 Jan 2019 11:01:19 +0000 (16:31 +0530)]
Merge pull request #13382 from seamuslee001/report_cleanup
(dev/core#491) Campaign Cleanup in Activity, Member Contribution Deta…
Thomas Schüttler [Fri, 4 Jan 2019 10:57:27 +0000 (11:57 +0100)]
Replace invalid characters in bounce reason with unicode replacement character
Thomas Schüttler [Fri, 4 Jan 2019 10:43:51 +0000 (11:43 +0100)]
Add unit test for invalid unicode character
eileen [Fri, 4 Jan 2019 05:52:55 +0000 (18:52 +1300)]
Add routine for updating smartgroups, currently handling datepicker conversion
Seamus Lee [Fri, 4 Jan 2019 04:58:47 +0000 (15:58 +1100)]
Merge pull request #13185 from seamuslee001/lab_core_572
dev/core#527 Add in abiity to set translated text for Submit and Canc…
eileen [Tue, 4 Dec 2018 10:15:20 +0000 (23:15 +1300)]
Migrate to a datepicker range
Tim Otten [Fri, 4 Jan 2019 03:31:04 +0000 (19:31 -0800)]
(dev/core#635) Only write extra prevnext cache record if used
This line of code creates an extra record to facilitate clearing the
SQL-based prevnext cache. However, with Redis-based prevnext cache, it's
not needed because the Redis implementation simply uses a TTL -- and (on
Redis deployments) this lines to gratuitous SQL writes.
Tim Otten [Fri, 4 Jan 2019 03:20:28 +0000 (19:20 -0800)]
(dev/core#635) CRM_Contact_Selector - Move count to 'long' cache
The selector was set to specifically store the size of the result set in the
SQL-based cache. For epic:ro-db, we should be able to store these in a
non-SQL location. The `long` cache suffices.
eileen [Sun, 2 Dec 2018 22:25:58 +0000 (11:25 +1300)]
dev/core#561 Convert grant date fields to use datepicker
Eileen McNaughton [Thu, 3 Jan 2019 22:15:10 +0000 (11:15 +1300)]
Merge pull request #13345 from GinkgoFJG/generic-settings-form
Added support to generic settings form for sorting settings by weight.
Eileen McNaughton [Thu, 3 Jan 2019 21:41:46 +0000 (10:41 +1300)]
Merge pull request #13392 from PeaceWorksTechnologySolutions/master
dev/mail#32 - Making mailing test email non-case-sensitive
eileen [Thu, 3 Jan 2019 21:34:56 +0000 (10:34 +1300)]
dev/core#562 remove calls to dao->free() from api folder
Per gitlab
The DAO object since ? 4.7.x? has been freed on _destruct. Using the ->free action has been demonstrated to create some rare bugs - ie. because query sets from the outer loop can be lost. There is no benefit in calling it any more and some harm
https://github.com/civicrm/civicrm-core/pull/13192 was the last one in this series
Seamus Lee [Wed, 2 Jan 2019 20:32:55 +0000 (07:32 +1100)]
(dev/core#491) Campaign Cleanup in Activity, Member Contribution Detail and Member Lapse reports
Martin [Thu, 3 Jan 2019 19:50:31 +0000 (19:50 +0000)]
Making mailing test email non-case-sensitive
https://lab.civicrm.org/dev/mail/issues/32
Seamus Lee [Thu, 3 Jan 2019 15:14:13 +0000 (02:14 +1100)]
Merge pull request #13280 from aydun/tokenrow_fix
Fix \Civi\Token\TokenRow::customToken() failure if field is not set
Seamus Lee [Thu, 3 Jan 2019 15:07:47 +0000 (02:07 +1100)]
Merge pull request #13284 from aydun/evaluate_fix
Prevent \Civi\Token\TokenCompatSubscriber::evaluate() erroring when no contactId is given.
Seamus Lee [Thu, 3 Jan 2019 15:06:50 +0000 (02:06 +1100)]
Merge pull request #13282 from aydun/custom_value_zero
Format token custom fields with value of 0 correctly
Seamus Lee [Thu, 3 Jan 2019 15:05:58 +0000 (02:05 +1100)]
Merge pull request #13286 from aydun/tokenprocessor_schema
(NFC) Add 'schema' to \Civi\Token\TokenProcessor()
Seamus Lee [Thu, 3 Jan 2019 15:05:04 +0000 (02:05 +1100)]
Merge pull request #13279 from aydun/list_tokens
(NFC) Add listTokens() function to return formatted list of tokens for forms
Seamus Lee [Thu, 3 Jan 2019 15:04:30 +0000 (02:04 +1100)]
Merge pull request #13278 from aydun/abstract_token_class_prop
(REF) Make activeTokens a class property of \Civi\Token\AbstractTokenSubscriber
CiviCRM [Thu, 3 Jan 2019 03:28:13 +0000 (03:28 +0000)]
Set version to 5.11.alpha1
CiviCRM [Thu, 3 Jan 2019 03:23:31 +0000 (03:23 +0000)]
Set version to 5.10.beta1
Seamus Lee [Thu, 3 Jan 2019 02:24:38 +0000 (13:24 +1100)]
Merge pull request #13389 from civicrm/5.9
5.9
Seamus Lee [Thu, 3 Jan 2019 02:24:22 +0000 (13:24 +1100)]
Merge pull request #13388 from totten/5.9-msg-tweak
Five Nine - Revise upgrade notice about Money/Int/Float fields
Tim Otten [Thu, 3 Jan 2019 00:36:39 +0000 (16:36 -0800)]
FineNine - Revise upgrade notice to be less alarming
Based on discussion at https://github.com/civicrm/civicrm-core/pull/13384/files#r244890998
Tim Otten [Thu, 3 Jan 2019 00:24:08 +0000 (16:24 -0800)]
(NFC) FiveNine.php - Whitespace