Seamus Lee [Wed, 2 Mar 2022 22:26:33 +0000 (09:26 +1100)]
Merge pull request #22869 from demeritcowboy/contributionview-notices2
php/smarty notices on contribution view part 2
demeritcowboy [Wed, 2 Mar 2022 16:41:48 +0000 (11:41 -0500)]
Merge pull request #22876 from rashedulislam/add-as-a-contributor
added as a contributor
Md Rashedul Islam [Wed, 2 Mar 2022 14:44:12 +0000 (20:44 +0600)]
added as a contributor
demeritcowboy [Wed, 2 Mar 2022 13:52:26 +0000 (08:52 -0500)]
Merge pull request #22872 from rashedulislam/attachment-civicrm_api3_create_error
Call to undefined function civicrm_api3_create_error() in civicrm/civ…
Yashodha Chaku [Wed, 2 Mar 2022 11:41:02 +0000 (17:11 +0530)]
Merge pull request #22438 from eileenmcnaughton/format
Format money on transaction list
Seamus Lee [Wed, 2 Mar 2022 06:16:34 +0000 (17:16 +1100)]
Merge pull request #22873 from civicrm/5.47
5.47
Tim Otten [Wed, 2 Mar 2022 06:04:34 +0000 (22:04 -0800)]
Merge pull request #22871 from totten/5.47-mem-date-test
(NFC) Membership Tests - Update assertions to match behavior circa leap-day
Md Rashedul Islam [Wed, 2 Mar 2022 06:03:33 +0000 (12:03 +0600)]
Call to undefined function civicrm_api3_create_error() in civicrm/civicrm/CRM/Core/Page/AJAX/Attachment.php:65
Tim Otten [Tue, 1 Mar 2022 06:00:03 +0000 (22:00 -0800)]
(NFC) Membership Tests - Update assertions to match behavior circa leap-day
If you run the tests on Mar 2, 2022, then some of the generated memberships
land on the leap-day in 2024. The actual behavior is have the end-date on the
last day of the month (29 Feb 2024), but the test incorrectly asserts that
it comes before (28 Feb 2024).
demeritcowboy [Wed, 2 Mar 2022 03:39:09 +0000 (22:39 -0500)]
Merge pull request #22867 from totten/master-logdetail
(NFC) LoggingDetailTest - Improve reliability of test
demeritcowboy [Wed, 2 Mar 2022 02:46:56 +0000 (21:46 -0500)]
php/smarty notices
Tim Otten [Wed, 2 Mar 2022 02:23:28 +0000 (18:23 -0800)]
Merge pull request #22866 from demeritcowboy/contributionview-notices
php notices on contributionview
Tim Otten [Wed, 2 Mar 2022 01:51:00 +0000 (17:51 -0800)]
(NFC) LoggingDetailTest - Improve reliability of test
Before
-----------------
If you run this test repeatedly, it may alternately pass and fail. The
percentage of passes-vs-fails can vary widely (depending on the computer
where you execute).
To test this, I went to a deployment (on `test-3`) which had a fairly
high probability of failure (*failure in roughly 3/4 invocations*).
After
-----------------
On the same system, it passes consistently (*no failures after 15 invocations*).
Matthew Wire [Wed, 2 Mar 2022 00:04:47 +0000 (00:04 +0000)]
Merge pull request #22859 from civicrm/5.47
5.47
Tim Otten [Tue, 1 Mar 2022 23:54:41 +0000 (15:54 -0800)]
Merge pull request #22860 from totten/master-mem-date-test
(NFC) Membership Tests - Update assertions to match behavior circa leap-day
demeritcowboy [Tue, 1 Mar 2022 23:44:20 +0000 (18:44 -0500)]
php notices
Seamus Lee [Tue, 1 Mar 2022 22:36:50 +0000 (09:36 +1100)]
Merge pull request #22864 from eileenmcnaughton/fin
Add handling for civimember disabled
Eileen McNaughton [Tue, 1 Mar 2022 20:12:04 +0000 (09:12 +1300)]
Add handling for civimember disabled
Tim Otten [Tue, 1 Mar 2022 06:00:03 +0000 (22:00 -0800)]
(NFC) Membership Tests - Update assertions to match behavior circa leap-day
If you run the tests on Mar 2, 2022, then some of the generated memberships
land on the leap-day in 2024. The actual behavior is have the end-date on the
last day of the month (29 Feb 2024), but the test incorrectly asserts that
it comes before (28 Feb 2024).
Tim Otten [Tue, 1 Mar 2022 05:17:02 +0000 (21:17 -0800)]
Merge pull request #22812 from totten/master-queue-schema
(dev/core#1304) Queues - Define schema for runner, run_count, lease_time, et al
Seamus Lee [Tue, 1 Mar 2022 05:01:51 +0000 (16:01 +1100)]
Merge pull request #22858 from seamuslee001/update_contribution_recur_dao
[NFC] Update Contribution Recur DAO following regen
Seamus Lee [Tue, 1 Mar 2022 02:14:07 +0000 (13:14 +1100)]
Update Contribution Recur DAO following regen
Seamus Lee [Tue, 1 Mar 2022 02:21:08 +0000 (13:21 +1100)]
Merge pull request #22857 from seamuslee001/master
5.47
Seamus Lee [Tue, 1 Mar 2022 02:13:02 +0000 (13:13 +1100)]
Merge in 5.47
Tim Otten [Tue, 1 Mar 2022 02:08:29 +0000 (18:08 -0800)]
Queue.retry_limit - Set explicit default to 0. Update comments/docs.
Tim Otten [Tue, 1 Mar 2022 00:45:10 +0000 (16:45 -0800)]
QueueItem - Upgrades from <v4.2 are not supported. Remove special createTable().
demeritcowboy [Tue, 1 Mar 2022 00:53:34 +0000 (19:53 -0500)]
Merge pull request #22855 from demeritcowboy/grant-menu
dev/core#3087- Grant menu appears twice
Tim Otten [Tue, 1 Mar 2022 00:36:29 +0000 (16:36 -0800)]
Queue.batch_limit - Simplify docblock comments
demeritcowboy [Mon, 28 Feb 2022 22:38:02 +0000 (17:38 -0500)]
regen
demeritcowboy [Mon, 28 Feb 2022 22:28:27 +0000 (17:28 -0500)]
fix duplicate menu
demeritcowboy [Mon, 28 Feb 2022 22:25:09 +0000 (17:25 -0500)]
Merge pull request #22242 from MegaphoneJon/reporting-85
fixes report#85 - Don't crash Contact Logging Detail report when viewing a contribution
Eileen McNaughton [Mon, 28 Feb 2022 21:17:13 +0000 (10:17 +1300)]
Merge pull request #20093 from larssandergreen/mailings-AB-test-improvements
dev/core#2100 Improve A/B test report page and API Mailing stats
Jon Goldberg [Mon, 13 Dec 2021 19:14:55 +0000 (14:14 -0500)]
fixes reporting#85 - Don't crash Contact Logging Detail report when viewing a contribution
demeritcowboy [Mon, 28 Feb 2022 18:56:18 +0000 (13:56 -0500)]
Merge pull request #22852 from civicrm/5.47
5.47
Matthew Wire [Mon, 28 Feb 2022 15:30:54 +0000 (15:30 +0000)]
Merge pull request #22732 from braders/ui-45-contrib-participant-links
dev/user-interface#45 Show associated participants on contributionView form
demeritcowboy [Mon, 28 Feb 2022 15:03:13 +0000 (10:03 -0500)]
Merge pull request #22851 from JMAConsulting/civiGrantFields
CiviGrant - Don't return grant fields as contact fields
Monish Deb [Mon, 28 Feb 2022 13:18:11 +0000 (18:48 +0530)]
add grant_id select clause definition
Coleman Watts [Sun, 20 Feb 2022 19:30:07 +0000 (14:30 -0500)]
CiviGrant - Don't return grant fields as contact fields
Fixes dev/core#3069
Seamus Lee [Mon, 28 Feb 2022 04:23:23 +0000 (15:23 +1100)]
Merge pull request #22849 from colemanw/fixApiExplorerError
Fix API4 Explorer undefined variable error
Coleman Watts [Mon, 28 Feb 2022 02:02:16 +0000 (21:02 -0500)]
Fix API4 Explorer undefined variable error
Eileen McNaughton [Sun, 27 Feb 2022 23:06:41 +0000 (12:06 +1300)]
Merge pull request #22848 from braders/extension-manager-notices
Avoid PHP undefined index notices on extension pages
Bradley Taylor [Sun, 27 Feb 2022 17:12:25 +0000 (17:12 +0000)]
Avoid PHP undefined index notices on extension pages
colemanw [Sun, 27 Feb 2022 17:05:42 +0000 (12:05 -0500)]
Merge pull request #22846 from demeritcowboy/testorg
[NFC] Basic case create test with org
demeritcowboy [Sun, 27 Feb 2022 16:31:16 +0000 (11:31 -0500)]
Merge pull request #22842 from mattwire/i18n
Fix issues with PHP GetText and 0 length files
demeritcowboy [Sun, 27 Feb 2022 16:09:01 +0000 (11:09 -0500)]
Merge pull request #22840 from braders/prefered-language-undefined-variable
Remove reference to undefined variable in CRM_Contact_Form_Inline_CommunicationPreferences
demeritcowboy [Sun, 27 Feb 2022 15:28:28 +0000 (10:28 -0500)]
basic test with org
colemanw [Sun, 27 Feb 2022 14:29:26 +0000 (09:29 -0500)]
Merge pull request #22844 from braders/static-methods
Mark methods which are only used statically as static
Bradley Taylor [Sun, 27 Feb 2022 10:22:11 +0000 (10:22 +0000)]
Mark methods which are only used statically as static
Tim Otten [Sun, 27 Feb 2022 05:52:43 +0000 (21:52 -0800)]
Merge pull request #22831 from colemanw/virtualEntityPrefix
APIv4 - Add metadata about class args
Coleman Watts [Fri, 25 Feb 2022 15:42:29 +0000 (10:42 -0500)]
APIv4 - Add entity metadata about class args
The CustomValue API is a virtual API, where multiple entities all get routed to the
same class if they share the prefix "Custom_", and pass a class arg to the
php factory functions e.g. `CustomValue::get('MyCustomGroup')`.
Instead of hard-coding this idea into the now it's part of the entity
metadata so that other APIs, notaby ECK, can use a similar pattern.
Matthew Wire [Sat, 26 Feb 2022 23:14:57 +0000 (23:14 +0000)]
Fix 100% CPU and timeout on some servers
demeritcowboy [Sat, 26 Feb 2022 21:48:49 +0000 (16:48 -0500)]
Merge pull request #22841 from braders/state-class-tidy
Cody tidy in CRM_Core_State
demeritcowboy [Sat, 26 Feb 2022 21:43:11 +0000 (16:43 -0500)]
Merge pull request #22838 from civicrm/5.47
5.47
demeritcowboy [Sat, 26 Feb 2022 21:43:01 +0000 (16:43 -0500)]
Merge pull request #22839 from braders/pricefieldvalue-undefined-var
Remove reference to undefined variable
Bradley Taylor [Sat, 26 Feb 2022 18:23:17 +0000 (18:23 +0000)]
Cody tidy in CRM_Core_State
Bradley Taylor [Sat, 26 Feb 2022 17:04:29 +0000 (17:04 +0000)]
Remove reference to undefined variable
Bradley Taylor [Sat, 26 Feb 2022 17:41:40 +0000 (17:41 +0000)]
Remove reference to undefined variable in CRM_Contact_Form_Inline_CommunicationPreferences
demeritcowboy [Sat, 26 Feb 2022 15:35:35 +0000 (10:35 -0500)]
Merge pull request #22809 from colemanw/afformSearchKitRefresh
SearchKit - Refresh contents after saving a popup when in a block/tab
demeritcowboy [Sat, 26 Feb 2022 15:17:06 +0000 (10:17 -0500)]
Merge pull request #22814 from colemanw/civiCaseRelationshipHooks
CiviCase - Call hooks when creating relationships
demeritcowboy [Sat, 26 Feb 2022 15:15:56 +0000 (10:15 -0500)]
Merge pull request #22836 from civicrm/5.47
5.47
colemanw [Sat, 26 Feb 2022 04:58:40 +0000 (23:58 -0500)]
Merge pull request #22834 from colemanw/hookInterface
Move HookInterface to \Civi\Core namespace
Tim Otten [Sat, 26 Feb 2022 04:58:16 +0000 (20:58 -0800)]
Merge pull request #22829 from colemanw/tableName
APIv4 - Add tableName to Entity.get output
Tim Otten [Sat, 26 Feb 2022 03:16:30 +0000 (19:16 -0800)]
Civi\Test\HookInterface is now an alias for Civi\Core\HookInterface
This means that we don't need to maintain two copies of the docblock.
There's a strong expectation that the interfaces work equivalently.
It will be more forgiving if a consumer mixes up the names.
Seamus Lee [Sat, 26 Feb 2022 00:19:26 +0000 (11:19 +1100)]
Merge pull request #22833 from alifrumin/rn5.47
[NFC] first stab at 5.47 release notes
Coleman Watts [Fri, 25 Feb 2022 21:09:48 +0000 (16:09 -0500)]
Copy \Civi\Test\HookInterface to \Civi\Core namespace
Alice Frumin [Tue, 22 Feb 2022 20:40:21 +0000 (15:40 -0500)]
[NFC] first pass at 5.47 release notes
Coleman Watts [Fri, 25 Feb 2022 05:34:44 +0000 (00:34 -0500)]
APIv4 - Add tableName to Entity.get output
demeritcowboy [Fri, 25 Feb 2022 04:14:11 +0000 (23:14 -0500)]
Merge pull request #22772 from eileenmcnaughton/batch
Fix submit handling of thousands when creating data entry batch
Eileen McNaughton [Fri, 25 Feb 2022 03:06:08 +0000 (16:06 +1300)]
Merge pull request #22827 from colemanw/subType
APIv4 - Add fixme about filtering custom fields by sub-type
Eileen McNaughton [Fri, 25 Feb 2022 02:03:23 +0000 (15:03 +1300)]
Merge pull request #22637 from eileenmcnaughton/dom_flush
Flush the metadata cache when the domain is edited
Coleman Watts [Fri, 25 Feb 2022 00:53:35 +0000 (19:53 -0500)]
APIv4 - Add fixme about filtering custom fields by sub-type
Coleman Watts [Sun, 20 Feb 2022 23:26:46 +0000 (18:26 -0500)]
SearchKit - Refresh contents after saving a popup when in a block/tab
The auto-refresh depends on the search being inside a <form> element.
colemanw [Fri, 25 Feb 2022 00:26:12 +0000 (19:26 -0500)]
Merge pull request #22752 from eileenmcnaughton/grumpit
Fixes for smarty grumpy mode with membership
demeritcowboy [Fri, 25 Feb 2022 00:07:26 +0000 (19:07 -0500)]
Merge pull request #22719 from eileenmcnaughton/notice_page
Enotice fixes
Eileen McNaughton [Thu, 24 Feb 2022 23:17:38 +0000 (12:17 +1300)]
Enotice fix
Eileen McNaughton [Thu, 24 Feb 2022 23:17:21 +0000 (12:17 +1300)]
Call static function statically
Also objects are always references....
Eileen McNaughton [Thu, 27 Jan 2022 03:07:01 +0000 (16:07 +1300)]
Flush the metadata cache when the domain is edited
Domain info is cached in metadata cache for token usage - we should flush out when altering
demeritcowboy [Thu, 24 Feb 2022 14:11:15 +0000 (09:11 -0500)]
Merge pull request #22800 from mlutfy/mailingCleanup
Mailing Report: do not recalculate the recipients when the count is zero
Coleman Watts [Wed, 23 Feb 2022 20:50:05 +0000 (15:50 -0500)]
Temporarily switch to relationship::add function
colemanw [Thu, 24 Feb 2022 02:13:25 +0000 (21:13 -0500)]
Merge pull request #22824 from colemanw/api4Provider
[REF] APIv4 - use entityTypes event to load custom records
Seamus Lee [Thu, 24 Feb 2022 01:55:08 +0000 (12:55 +1100)]
Merge pull request #22823 from demeritcowboy/mailing-since
Fix the "since" version for api v4 Mailing and MailingJob
Coleman Watts [Thu, 24 Feb 2022 00:40:54 +0000 (19:40 -0500)]
APIv4 - use entityTypes event to load custom records
This standardizes things to use the ActionObjectProvider service more like it was intended,
with getEntityNames now returning what it's supposed to, and removing a direct-cache-access hack
from CoreUtil, in favor of using the service.
demeritcowboy [Thu, 24 Feb 2022 00:12:25 +0000 (19:12 -0500)]
fix the since version
Seamus Lee [Thu, 24 Feb 2022 00:09:47 +0000 (11:09 +1100)]
Merge pull request #22822 from civicrm/5.47
5.47
Eileen McNaughton [Wed, 23 Feb 2022 21:34:38 +0000 (10:34 +1300)]
Merge pull request #22821 from demeritcowboy/update-token
Recent update to {receipt_text} token gives warning in system check after upgrade
Tim Otten [Wed, 23 Feb 2022 21:03:19 +0000 (13:03 -0800)]
Merge pull request #22817 from totten/5.47-rest-q
RestTest - Skip `testNotCMSUser_q` when it's not supported
colemanw [Wed, 23 Feb 2022 16:59:19 +0000 (11:59 -0500)]
Merge pull request #22818 from JMAConsulting/add-checkperm
add checkPerm
colemanw [Wed, 23 Feb 2022 16:57:40 +0000 (11:57 -0500)]
Merge pull request #22819 from demeritcowboy/unused-v2
[REF] Remove unused api v2 function
colemanw [Wed, 23 Feb 2022 16:57:03 +0000 (11:57 -0500)]
Merge pull request #22820 from demeritcowboy/recurforms
[NFC] Rename RecurForms test class
demeritcowboy [Wed, 23 Feb 2022 16:03:20 +0000 (11:03 -0500)]
Merge pull request #22665 from colemanw/memberCleanup
[REF] Cleanup docblocks & unused vars in Membership BAO
demeritcowboy [Wed, 23 Feb 2022 15:36:41 +0000 (10:36 -0500)]
update tokens in message template
demeritcowboy [Wed, 23 Feb 2022 14:44:53 +0000 (09:44 -0500)]
convert to trait
demeritcowboy [Wed, 23 Feb 2022 14:37:08 +0000 (09:37 -0500)]
move file
demeritcowboy [Wed, 23 Feb 2022 14:28:10 +0000 (09:28 -0500)]
remove unused v2 function
demeritcowboy [Wed, 23 Feb 2022 12:47:25 +0000 (07:47 -0500)]
Merge pull request #21895 from kartik1000/Test#18196
Added Cancel Recur Subscription test & setter for `supports` on Dummy processor
Monish Deb [Wed, 23 Feb 2022 07:37:11 +0000 (13:07 +0530)]
add checkPerm
Tim Otten [Wed, 23 Feb 2022 04:52:00 +0000 (20:52 -0800)]
Skip `testNotCMSUser_q` in some environments (based on `isOldQSupported()`)
Tim Otten [Wed, 23 Feb 2022 04:21:00 +0000 (20:21 -0800)]
(REF) E2E_Extern_*RestTest - Extract `isOldQSupported()`
This patch changes the way a certain carve-out works, but it doesn't change the outcome.
Background: There are two E2E tests:
* `LegacyRestTest` extends `BaseRestTest` and targets `extern/rest.php`.
It tests `rest.php?entity=ENTITY&action=ACTION`
as well as `rest.php?q=civicrm/ENTITY/ACTION`.
* `AuthxRestTest` extends `BaseRestTest` and targets `civicrm/ajax/rest`.
It only tests `civicrm/ajax/rest?entity=ENTITY&action=ACTION`.
The `q` parameter cannot be used realiably with CMS routing
(`q=civicrm/ajax/rest&q=civicrm/ENTITY/ACTION`). So we skip testing that
combination.
The patch merely changes how the skip works.
Tim Otten [Wed, 23 Feb 2022 03:49:47 +0000 (19:49 -0800)]
Merge pull request #22815 from totten/5.47-rn546-auto
(NFC) release-notes/5.46.0.md - Re-apply auto-cleanups
colemanw [Wed, 23 Feb 2022 00:07:27 +0000 (19:07 -0500)]
Merge pull request #22475 from eileenmcnaughton/ipn
Revert membership debug handling in IPN