civicrm-core.git
4 years agoMerge pull request #17579 from colemanw/menubarSep
Seamus Lee [Fri, 12 Jun 2020 22:24:48 +0000 (08:24 +1000)]
Merge pull request #17579 from colemanw/menubarSep

Update has_separator field in civicrm_navigation

4 years agoMerge pull request #17585 from eileenmcnaughton/anetup
Seamus Lee [Fri, 12 Jun 2020 22:20:30 +0000 (08:20 +1000)]
Merge pull request #17585 from eileenmcnaughton/anetup

[Ref] Convert Authorize.net to use Guzzle for update subscription class, add test

4 years agoMerge pull request #17487 from eileenmcnaughton/date
Mathieu Lu [Fri, 12 Jun 2020 13:07:51 +0000 (09:07 -0400)]
Merge pull request #17487 from eileenmcnaughton/date

[Ref] Mark unused date functions as deprecated

4 years agoMerge pull request #17144 from lcdservices/dev-core-1716
Seamus Lee [Fri, 12 Jun 2020 11:06:15 +0000 (21:06 +1000)]
Merge pull request #17144 from lcdservices/dev-core-1716

dev/core#1716 add customPre hook

4 years agoMerge pull request #17563 from eileenmcnaughton/pending
Seamus Lee [Fri, 12 Jun 2020 11:04:04 +0000 (21:04 +1000)]
Merge pull request #17563 from eileenmcnaughton/pending

Remove unreachable lines

4 years agoMerge pull request #17581 from mlutfy/EventInfoCleanup
Matthew Wire [Fri, 12 Jun 2020 09:32:51 +0000 (10:32 +0100)]
Merge pull request #17581 from mlutfy/EventInfoCleanup

EventInfo template cleanup

4 years agoMerge pull request #17321 from artfulrobot/artfulrobot-identify-request-key
Matthew Wire [Fri, 12 Jun 2020 09:31:38 +0000 (10:31 +0100)]
Merge pull request #17321 from artfulrobot/artfulrobot-identify-request-key

Allow HEAD requests to generate a form key

4 years agoMerge pull request #17587 from civicrm/5.27
Seamus Lee [Fri, 12 Jun 2020 09:29:14 +0000 (19:29 +1000)]
Merge pull request #17587 from civicrm/5.27

5.27

4 years agoMerge pull request #17586 from seamuslee001/wip_56_test_fixes
Seamus Lee [Fri, 12 Jun 2020 05:08:53 +0000 (15:08 +1000)]
Merge pull request #17586 from seamuslee001/wip_56_test_fixes

[REF] Fix unit test failures on MySQL 5.6 due to Custom Field table being created without Dynamic Row Format

4 years agoFix unit test failures on MySQL 5.6 due to Custom Field table being created without...
Seamus Lee [Fri, 12 Jun 2020 03:17:48 +0000 (13:17 +1000)]
Fix unit test failures on MySQL 5.6 due to Custom Field table being created without Dynamic Row Format

4 years ago[Ref] Convert Authorize.net to use Guzzle for update subscription, change subscriptio...
eileen [Thu, 11 Jun 2020 23:50:33 +0000 (11:50 +1200)]
[Ref] Convert Authorize.net to use Guzzle for update subscription, change subscription, add test

This is part of the effort to expand our testing & standardise core processors

4 years agoMerge pull request #17583 from civicrm/5.27
Seamus Lee [Fri, 12 Jun 2020 01:14:29 +0000 (11:14 +1000)]
Merge pull request #17583 from civicrm/5.27

5.27

4 years agoMerge pull request #17584 from eileenmcnaughton/process
Eileen McNaughton [Fri, 12 Jun 2020 00:28:53 +0000 (12:28 +1200)]
Merge pull request #17584 from eileenmcnaughton/process

Fix fatal error regression in master

4 years agoFix fatal error regression in master
eileen [Thu, 11 Jun 2020 23:17:06 +0000 (11:17 +1200)]
Fix fatal error regression in master

Fatal from this line due to pass by reference

https://github.com/civicrm/civicrm-core/pull/16514/files#diff-a8611c9a226a40b585001082b38467b0R207

4 years agoMerge pull request #17582 from colemanw/upgrade
Seamus Lee [Thu, 11 Jun 2020 22:45:20 +0000 (08:45 +1000)]
Merge pull request #17582 from colemanw/upgrade

Fix duplicate upgrade function

4 years agoMerge pull request #17577 from seamuslee001/deprecated_checks_money_value_format
Seamus Lee [Thu, 11 Jun 2020 22:45:03 +0000 (08:45 +1000)]
Merge pull request #17577 from seamuslee001/deprecated_checks_money_value_format

Add in deprecation notice and status check for a money value format co…

4 years agoMerge pull request #17567 from eileenmcnaughton/dupe_speed
Seamus Lee [Thu, 11 Jun 2020 22:06:43 +0000 (08:06 +1000)]
Merge pull request #17567 from eileenmcnaughton/dupe_speed

Dedupe performance - hard-remove financial_item from list of dymnamic  refs to contact table

4 years agoAdd in depreation notice and status check for a money value format configuration...
Seamus Lee [Thu, 11 Jun 2020 02:59:31 +0000 (12:59 +1000)]
Add in depreation notice and status check for a money value format configuration other than the default

Update to include issue link

Update to use CRM_Core_Error::deprecated function and mention deprecation notice on settings page

4 years agoMerge pull request #17565 from eileenmcnaughton/processor
Seamus Lee [Thu, 11 Jun 2020 21:38:10 +0000 (07:38 +1000)]
Merge pull request #17565 from eileenmcnaughton/processor

dev/financial#131 Fix Elavon processor to throw exceptions

4 years agoFix duplicate upgrade function
Coleman Watts [Thu, 11 Jun 2020 21:38:04 +0000 (17:38 -0400)]
Fix duplicate upgrade function

4 years agoMerge pull request #17531 from colemanw/customIcon
Eileen McNaughton [Thu, 11 Jun 2020 21:26:25 +0000 (09:26 +1200)]
Merge pull request #17531 from colemanw/customIcon

Add icons to multi-valued custom groups and display on contact tab

4 years agoMerge pull request #17576 from colemanw/emptyLeaf
Eileen McNaughton [Thu, 11 Jun 2020 21:25:29 +0000 (09:25 +1200)]
Merge pull request #17576 from colemanw/emptyLeaf

APIv4 - Skip empty leaves in WHERE clause

4 years agoEventInfo template cleanup.
Mathieu Lutfy [Thu, 11 Jun 2020 20:00:06 +0000 (16:00 -0400)]
EventInfo template cleanup.

4 years agoMerge pull request #17578 from yashodha/dev_1787
colemanw [Thu, 11 Jun 2020 17:34:50 +0000 (13:34 -0400)]
Merge pull request #17578 from yashodha/dev_1787

(dev/core#1787) Regression : File fields export results in DB error

4 years agoUpdate has_separator field in civicrm_navigation
Coleman Watts [Thu, 11 Jun 2020 15:55:05 +0000 (11:55 -0400)]
Update has_separator field in civicrm_navigation

This field was incorrectly marked as a boolean;
it's actually an int with an option list.

4 years ago(dev/core#1787) Regression : File fields export results in DB error
yashodha [Thu, 11 Jun 2020 14:09:19 +0000 (19:39 +0530)]
(dev/core#1787) Regression : File fields export results in DB error

4 years agoMerge pull request #17573 from seamuslee001/incorrect_use_array_key_exists
Seamus Lee [Thu, 11 Jun 2020 06:46:27 +0000 (16:46 +1000)]
Merge pull request #17573 from seamuslee001/incorrect_use_array_key_exists

[REF] Replace incorrect usages of array_key_exists when the variable …

4 years ago[REF] Replace incorrect usages of array_key_exists when the variable is not an array...
Seamus Lee [Wed, 10 Jun 2020 22:39:44 +0000 (08:39 +1000)]
[REF] Replace incorrect usages of array_key_exists when the variable is not an array with property_exists and also fix the parameter order for an implode statement

4 years agoMerge pull request #15796 from seamuslee001/dev_core_183_requirements
Seamus Lee [Thu, 11 Jun 2020 03:05:52 +0000 (13:05 +1000)]
Merge pull request #15796 from seamuslee001/dev_core_183_requirements

dev/core#183 Use CRM_Utils_SQL_TempTable for generating temp table na…

4 years agoAPIv4 - Skip empty leaves in WHERE clause
Coleman Watts [Thu, 11 Jun 2020 00:41:51 +0000 (20:41 -0400)]
APIv4 - Skip empty leaves in WHERE clause

Fixes an annoying problem with search builder
where the api gives a sql error while building your where clause.
The solution is to skip empty leaves, treating them as WIP.

4 years agoMerge pull request #17574 from seamuslee001/string_offsets_curly
Seamus Lee [Thu, 11 Jun 2020 00:29:28 +0000 (10:29 +1000)]
Merge pull request #17574 from seamuslee001/string_offsets_curly

[REF] Using {} to access string or array offsets has been deprecated …

4 years agoMerge pull request #17440 from eileenmcnaughton/log_summ
Seamus Lee [Thu, 11 Jun 2020 00:26:52 +0000 (10:26 +1000)]
Merge pull request #17440 from eileenmcnaughton/log_summ

dev/core#1749 Fix missing parameter in link to logging detail

4 years agoMerge pull request #15422 from artfulrobot/queue-parallel
Eileen McNaughton [Thu, 11 Jun 2020 00:18:34 +0000 (12:18 +1200)]
Merge pull request #15422 from artfulrobot/queue-parallel

Include a new SqlParallel queue type that enables multiple queue runners to process in parallel

4 years agoMerge pull request #17575 from seamuslee001/php74_deprecations
Seamus Lee [Wed, 10 Jun 2020 23:55:52 +0000 (09:55 +1000)]
Merge pull request #17575 from seamuslee001/php74_deprecations

[REF] Using ternary operation without nesting is deprecated and also …

4 years agoMerge pull request #17570 from seamuslee001/conact_type_populated
Seamus Lee [Wed, 10 Jun 2020 22:46:07 +0000 (08:46 +1000)]
Merge pull request #17570 from seamuslee001/conact_type_populated

[REF] Add in upgrade step to populate missing contact_type.name field

4 years ago[REF] Using ternary operation without nesting is deprecated and also using methods...
Seamus Lee [Wed, 10 Jun 2020 22:45:53 +0000 (08:45 +1000)]
[REF] Using ternary operation without nesting is deprecated and also using methods and properly instanciate the CiviCase Info object in test

4 years ago[REF] Using {} to access string or array offsets has been deprecated in PHP7.4
Seamus Lee [Wed, 10 Jun 2020 22:40:26 +0000 (08:40 +1000)]
[REF] Using {} to access string or array offsets has been deprecated in PHP7.4

4 years ago[REF] Add in upgrade step to populate missing contact_type.name field
Seamus Lee [Wed, 10 Jun 2020 11:07:08 +0000 (21:07 +1000)]
[REF] Add in upgrade step to populate missing contact_type.name field

Make changes to the other columns

4 years agoMerge pull request #17571 from jitendrapurohit/core-1809
Seamus Lee [Wed, 10 Jun 2020 21:05:34 +0000 (07:05 +1000)]
Merge pull request #17571 from jitendrapurohit/core-1809

dev/core#1809 - Add start/end adjustment columns to membership status…

4 years agodev/core#1809 - Add start/end adjustment columns to membership status page
Jitendra Purohit [Wed, 10 Jun 2020 11:58:35 +0000 (17:28 +0530)]
dev/core#1809 - Add start/end adjustment columns to membership status page

4 years agoMerge pull request #17548 from eileenmcnaughton/contacttype
Seamus Lee [Wed, 10 Jun 2020 05:43:13 +0000 (15:43 +1000)]
Merge pull request #17548 from eileenmcnaughton/contacttype

Set ContactType.name as required in the schema.

4 years agoMerge pull request #17566 from eileenmcnaughton/dupe1
Eileen McNaughton [Wed, 10 Jun 2020 03:25:29 +0000 (15:25 +1200)]
Merge pull request #17566 from eileenmcnaughton/dupe1

[NFC] Minor code cleanup

4 years agoSet ContactType.name as required in the schema.
eileen [Mon, 8 Jun 2020 04:50:49 +0000 (16:50 +1200)]
Set ContactType.name as required in the schema.

I came across this weird WHERE clause & I'm pretty sure it's compensating for a mistake in the schema

I also set what I think are sensible defaults on is_reserved & is_active

4 years agodev/financial#131 Fix Elavon processor to throw exceptions
eileen [Wed, 10 Jun 2020 01:32:15 +0000 (13:32 +1200)]
dev/financial#131 Fix Elavon processor to throw exceptions

In line with our goal of modelling 'good behaviour' in core processors

4 years agoDedupe performance - hard-remove financial_item from list of dymnamic refs to contact...
eileen [Wed, 10 Jun 2020 02:30:36 +0000 (14:30 +1200)]
Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact tablge

4 years ago[NFC] Minor code cleanup
eileen [Wed, 10 Jun 2020 02:00:01 +0000 (14:00 +1200)]
[NFC] Minor code cleanup

4 years agoRemove unreachable lines
eileen [Tue, 9 Jun 2020 19:50:31 +0000 (07:50 +1200)]
Remove unreachable lines

4 years agoMerge pull request #17525 from mattwire/baseipnremovebillingid
Seamus Lee [Tue, 9 Jun 2020 12:03:12 +0000 (22:03 +1000)]
Merge pull request #17525 from mattwire/baseipnremovebillingid

Remove deprecated billingID from baseIPN

4 years agoMerge pull request #17556 from eileenmcnaughton/renewline
Seamus Lee [Tue, 9 Jun 2020 12:02:59 +0000 (22:02 +1000)]
Merge pull request #17556 from eileenmcnaughton/renewline

[Ref] Remove never reachable lines.

4 years agoRemove deprecated billingID from baseIPN
Matthew Wire [Sat, 6 Jun 2020 14:30:11 +0000 (15:30 +0100)]
Remove deprecated billingID from baseIPN

4 years agoMerge pull request #17559 from eileenmcnaughton/realex
Seamus Lee [Tue, 9 Jun 2020 03:34:05 +0000 (13:34 +1000)]
Merge pull request #17559 from eileenmcnaughton/realex

dev/financial#131 Fix Realex processor to correctly throw an exception

4 years agoMerge pull request #17557 from ngo360/master
Seamus Lee [Tue, 9 Jun 2020 01:30:41 +0000 (11:30 +1000)]
Merge pull request #17557 from ngo360/master

dev/core#1801 Fix hardcoded activity priority by label

4 years agodev/financial#131 Fix Realex processor to correctly throw an exception
eileen [Tue, 9 Jun 2020 01:16:55 +0000 (13:16 +1200)]
dev/financial#131 Fix Realex processor to correctly throw an exception

4 years agoMerge pull request #17515 from seamuslee001/replace_legacy_rebuild_module_data
Seamus Lee [Tue, 9 Jun 2020 00:29:18 +0000 (10:29 +1000)]
Merge pull request #17515 from seamuslee001/replace_legacy_rebuild_module_data

[REF] Replace the deprecated system_rebuild_module_data function with…

4 years agoMerge pull request #17555 from seamuslee001/dev_core_560_deprecated_function_warning
Seamus Lee [Mon, 8 Jun 2020 23:22:21 +0000 (09:22 +1000)]
Merge pull request #17555 from seamuslee001/dev_core_560_deprecated_function_warning

dev/core#560 Add in deprecated function warning now that fatal is dep…

4 years agodev/core#1801 Fix hardcoded activity priority
marcineqpol [Mon, 8 Jun 2020 22:26:13 +0000 (00:26 +0200)]
dev/core#1801 Fix hardcoded activity priority

4 years agoMerge pull request #17450 from mattwire/activitydefaults
Seamus Lee [Mon, 8 Jun 2020 22:18:36 +0000 (08:18 +1000)]
Merge pull request #17450 from mattwire/activitydefaults

dev/core#1782 Set activity_date_time and created_date to default to current_timestamp

4 years ago[Ref] Remove never reachable lines.
eileen [Fri, 5 Jun 2020 05:40:09 +0000 (17:40 +1200)]
[Ref] Remove never reachable lines.

There is an early return on  so updateStatusId can never be true

4 years agoMerge pull request #17501 from eileenmcnaughton/guzzle3
Seamus Lee [Mon, 8 Jun 2020 21:52:42 +0000 (07:52 +1000)]
Merge pull request #17501 from eileenmcnaughton/guzzle3

[Ref] Convert Authorize.net doDirectPayment to use guzzle & add test

4 years agoMerge pull request #17554 from alifrumin/entryFoundFlag
Eileen McNaughton [Mon, 8 Jun 2020 21:48:27 +0000 (09:48 +1200)]
Merge pull request #17554 from alifrumin/entryFoundFlag

Fix "Undefined variable: entryFound" notice on Bookkeeping report

4 years agoMerge pull request #17506 from mattwire/propertybagremovewarning
Eileen McNaughton [Mon, 8 Jun 2020 21:45:57 +0000 (09:45 +1200)]
Merge pull request #17506 from mattwire/propertybagremovewarning

Payment Propertybag remove warning

4 years agodev/core#560 Add in deprecated function warning now that fatal is deprecated
Seamus Lee [Mon, 8 Jun 2020 21:21:00 +0000 (07:21 +1000)]
dev/core#560 Add in deprecated function warning now that fatal is deprecated

4 years ago[REF] Replace the deprecated system_rebuild_module_data function with equivilant...
Seamus Lee [Fri, 5 Jun 2020 23:11:13 +0000 (09:11 +1000)]
[REF] Replace the deprecated system_rebuild_module_data function with equivilant extension.list.module service function calls to be Drupal 9 compatiable

4 years agoMerge pull request #17552 from mattwire/deprecatedfunctionwarning
Eileen McNaughton [Mon, 8 Jun 2020 20:41:18 +0000 (08:41 +1200)]
Merge pull request #17552 from mattwire/deprecatedfunctionwarning

Support passing old method name into deprecatedFunctionWarning

4 years agoset flag
Alice Frumin [Mon, 8 Jun 2020 20:04:32 +0000 (16:04 -0400)]
set flag

4 years agoMerge pull request #17553 from semseysandor/semseysandor-contributor
Eileen McNaughton [Mon, 8 Jun 2020 19:33:14 +0000 (07:33 +1200)]
Merge pull request #17553 from semseysandor/semseysandor-contributor

Update contributor-key.yml

4 years agoUpdate contributor-key.yml
Sandor Semsey [Mon, 8 Jun 2020 15:14:28 +0000 (17:14 +0200)]
Update contributor-key.yml

4 years agoMerge pull request #17550 from eileenmcnaughton/request
Eileen McNaughton [Mon, 8 Jun 2020 12:35:44 +0000 (00:35 +1200)]
Merge pull request #17550 from eileenmcnaughton/request

Remove last instance of CRM_Core_Error::fatal....

4 years agoMerge pull request #16610 from mattwire/settingstrait_datepicker
Eileen McNaughton [Mon, 8 Jun 2020 12:26:23 +0000 (00:26 +1200)]
Merge pull request #16610 from mattwire/settingstrait_datepicker

Allow adding datepicker to metadata based settings pages

4 years agoSupport passing old method name into deprecatedFunctionWarning
Matthew Wire [Mon, 8 Jun 2020 11:49:30 +0000 (12:49 +0100)]
Support passing old method name into deprecatedFunctionWarning

4 years agoRemove last instance of CRM_Core_Error::fatal....
eileen [Mon, 8 Jun 2020 05:17:50 +0000 (17:17 +1200)]
Remove last instance of CRM_Core_Error::fatal....

4 years agoMerge pull request #16514 from mattwire/phpnotice_ccparams
Eileen McNaughton [Mon, 8 Jun 2020 11:24:07 +0000 (23:24 +1200)]
Merge pull request #16514 from mattwire/phpnotice_ccparams

Fix PHP notice when we don't have credit card params

4 years agoSet activity_date_time and created_date to default to current_timestamp
Matthew Wire [Mon, 1 Jun 2020 12:19:41 +0000 (13:19 +0100)]
Set activity_date_time and created_date to default to current_timestamp

4 years agoMerge pull request #17374 from totten/master-setlocale
Eileen McNaughton [Mon, 8 Jun 2020 11:12:13 +0000 (23:12 +1200)]
Merge pull request #17374 from totten/master-setlocale

CRM_Core_I18n::setLocale() - Fix bug with repeated usage

4 years agoMerge pull request #17179 from mattwire/addpaymentprocessortorecurlist
Eileen McNaughton [Mon, 8 Jun 2020 11:05:22 +0000 (23:05 +1200)]
Merge pull request #17179 from mattwire/addpaymentprocessortorecurlist

Add payment processor to details on list of recurring contributions

4 years agoMerge pull request #17512 from semseysandor/relative-date-filter
Eileen McNaughton [Mon, 8 Jun 2020 10:47:03 +0000 (22:47 +1200)]
Merge pull request #17512 from semseysandor/relative-date-filter

dev/core#1798 - "End of yesterday" Relative Date Filter

4 years agoMerge pull request #17523 from mattwire/customsearchzipcode
Eileen McNaughton [Mon, 8 Jun 2020 10:46:37 +0000 (22:46 +1200)]
Merge pull request #17523 from mattwire/customsearchzipcode

Zip code range search only supports numeric zip codes

4 years agoFix PHP notice when we don't have credit card params
Matthew Wire [Wed, 12 Feb 2020 15:26:37 +0000 (15:26 +0000)]
Fix PHP notice when we don't have credit card params

4 years agoMerge pull request #17549 from eileenmcnaughton/friend
Seamus Lee [Mon, 8 Jun 2020 08:52:31 +0000 (18:52 +1000)]
Merge pull request #17549 from eileenmcnaughton/friend

[Ref] Remove another instance of fatal()

4 years agoMerge pull request #17543 from eileenmcnaughton/dummy
Seamus Lee [Mon, 8 Jun 2020 06:33:15 +0000 (16:33 +1000)]
Merge pull request #17543 from eileenmcnaughton/dummy

[Ref] Readability extraction in Dummy class

4 years agoMerge pull request #17546 from eileenmcnaughton/validate2
Seamus Lee [Mon, 8 Jun 2020 06:32:55 +0000 (16:32 +1000)]
Merge pull request #17546 from eileenmcnaughton/validate2

Remove isThrowException from CRM_Utils_Type::validate() signature

4 years ago[Ref] Remove another instance of fatal()
eileen [Mon, 8 Jun 2020 05:03:38 +0000 (17:03 +1200)]
[Ref] Remove another instance of fatal()

4 years ago[Ref] Readability extraction in Dummy class
eileen [Mon, 8 Jun 2020 00:33:04 +0000 (12:33 +1200)]
[Ref] Readability extraction in Dummy class

4 years agoMerge pull request #17545 from seamuslee001/dev_core_560_fin
Seamus Lee [Mon, 8 Jun 2020 04:37:31 +0000 (14:37 +1000)]
Merge pull request #17545 from seamuslee001/dev_core_560_fin

dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or …

4 years agoRemove isThrowException from CRM_Utils_Type::validate() signature
eileen [Mon, 8 Jun 2020 01:21:14 +0000 (13:21 +1200)]
Remove isThrowException from CRM_Utils_Type::validate() signature

There are no instances in core where FALSE is passed

4 years agoMerge pull request #17544 from eileenmcnaughton/validate
Seamus Lee [Mon, 8 Jun 2020 04:30:36 +0000 (14:30 +1000)]
Merge pull request #17544 from eileenmcnaughton/validate

Fix validateAll to no longer support unused abort param

4 years agodev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or Exceptions
Seamus Lee [Mon, 8 Jun 2020 01:13:26 +0000 (11:13 +1000)]
dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or Exceptions

4 years agoMerge pull request #17542 from eileenmcnaughton/pay_error
Seamus Lee [Mon, 8 Jun 2020 02:48:30 +0000 (12:48 +1000)]
Merge pull request #17542 from eileenmcnaughton/pay_error

dev/financial#131 Fix Eway processor to throw exceptions rather than return errors

4 years agoMerge pull request #17533 from eileenmcnaughton/fatal
Seamus Lee [Mon, 8 Jun 2020 02:47:43 +0000 (12:47 +1000)]
Merge pull request #17533 from eileenmcnaughton/fatal

[REF] Replace some instances of fatal with thrown exceptions.

4 years agoMerge pull request #17540 from colemanw/getActionsPerm
Eileen McNaughton [Mon, 8 Jun 2020 01:59:33 +0000 (13:59 +1200)]
Merge pull request #17540 from colemanw/getActionsPerm

APIv4 - filter getActions results based on user permissions

4 years agoMerge pull request #17491 from eileenmcnaughton/toemail
Seamus Lee [Mon, 8 Jun 2020 01:57:13 +0000 (11:57 +1000)]
Merge pull request #17491 from eileenmcnaughton/toemail

[Ref] Simplify the replacing of the email with the email from the url

4 years agoMerge pull request #17500 from eileenmcnaughton/renew_can
Seamus Lee [Mon, 8 Jun 2020 01:54:11 +0000 (11:54 +1000)]
Merge pull request #17500 from eileenmcnaughton/renew_can

[Ref] Throw exceptions from Authorize.net rather than return errors

4 years agoMerge pull request #17499 from eileenmcnaughton/unhandled
Seamus Lee [Mon, 8 Jun 2020 01:50:20 +0000 (11:50 +1000)]
Merge pull request #17499 from eileenmcnaughton/unhandled

[Ref] Remove calls to, and deprecate, unhandled function

4 years agoMerge pull request #17504 from eileenmcnaughton/renewd
Seamus Lee [Mon, 8 Jun 2020 01:49:37 +0000 (11:49 +1000)]
Merge pull request #17504 from eileenmcnaughton/renewd

[REF] Remove handling for 2 fields not on the form

4 years agoFix validateAll to no longer support unused abort param
eileen [Mon, 8 Jun 2020 01:11:02 +0000 (13:11 +1200)]
Fix validateAll to no longer support unused abort param

Default of TRUE is good here

4 years agoMerge pull request #17539 from eileenmcnaughton/fatal2
Seamus Lee [Mon, 8 Jun 2020 00:53:13 +0000 (10:53 +1000)]
Merge pull request #17539 from eileenmcnaughton/fatal2

Replace calls to fatal with statusBounces

4 years agodev/financial#131 Fix Eway processor to throw exceptions rather than return errors
eileen [Mon, 8 Jun 2020 00:12:04 +0000 (12:12 +1200)]
dev/financial#131 Fix Eway processor to throw exceptions rather than return errors

This is part of a push to model the correct behaviour in processors we can alter. This is safe as CRM_Core_Payment
already converts these

4 years ago[REF] Replace some instances of fatal with thrown exceptions.
eileen [Sun, 7 Jun 2020 04:59:24 +0000 (16:59 +1200)]
[REF] Replace some instances of fatal with thrown exceptions.

This is ongoing cleanup to consisently throw execptions. The only thing notable is in the OG class where
it turned out the exception was thrown if a never-passed-in-parameter was passed in, so I removed the
construct

4 years agoMerge pull request #17541 from seamuslee001/dev_core_560_third_to_last
Seamus Lee [Mon, 8 Jun 2020 00:39:39 +0000 (10:39 +1000)]
Merge pull request #17541 from seamuslee001/dev_core_560_third_to_last

dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions…

4 years agodev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions or status bounc...
Seamus Lee [Sun, 7 Jun 2020 23:33:47 +0000 (09:33 +1000)]
dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions or status bounces as appropriate