civicrm-core.git
3 years agoUpdate defaults for civicrm_contribution_recur table
eileen [Mon, 29 Mar 2021 01:20:50 +0000 (14:20 +1300)]
Update defaults for civicrm_contribution_recur table

3 years agoMerge pull request #19930 from eileenmcnaughton/acl_setting
Seamus Lee [Sun, 28 Mar 2021 22:49:17 +0000 (09:49 +1100)]
Merge pull request #19930 from eileenmcnaughton/acl_setting

dev/core#2477 Add setting to allow opportunistic cache flushing for acls

3 years agoMerge pull request #19929 from demeritcowboy/fake-intl-warning
Eileen McNaughton [Sun, 28 Mar 2021 22:18:15 +0000 (11:18 +1300)]
Merge pull request #19929 from demeritcowboy/fake-intl-warning

dev/financial#171 - False INTL warning when adding a price field

3 years agodev/core#2477 Add setting to allow opportunistic cache flushing for acls
eileen [Sun, 28 Mar 2021 20:37:42 +0000 (09:37 +1300)]
dev/core#2477 Add setting to allow opportunistic cache flushing for acls

This adds the same mechanism as the group contact cache to reduce site contention.
A job api is also added which people can optionally configure.

It would be especially worth setting on sites that do not use ACLs at all

3 years agofalse INTL warning
demeritcowboy [Sun, 28 Mar 2021 19:46:55 +0000 (15:46 -0400)]
false INTL warning

3 years agoMerge pull request #19738 from jitendrapurohit/note-date
Eileen McNaughton [Sun, 28 Mar 2021 09:27:54 +0000 (22:27 +1300)]
Merge pull request #19738 from jitendrapurohit/note-date

dev/core#2243 Add created_date column to the civicrm_note table

3 years agoadd created_date to civicrm_note
Jitendra Purohit [Fri, 5 Mar 2021 09:27:35 +0000 (14:57 +0530)]
add created_date to civicrm_note

3 years agoMerge pull request #19925 from eileenmcnaughton/tear
Seamus Lee [Sat, 27 Mar 2021 23:07:40 +0000 (10:07 +1100)]
Merge pull request #19925 from eileenmcnaughton/tear

PHPUNIT 8 - add void to setup functions

3 years agoPHPUNIT 8 - add void to setup functions
eileen [Sat, 27 Mar 2021 19:22:16 +0000 (08:22 +1300)]
PHPUNIT 8 - add void to setup functions

3 years agoMerge pull request #19863 from eileenmcnaughton/flex
Seamus Lee [Sat, 27 Mar 2021 04:40:17 +0000 (15:40 +1100)]
Merge pull request #19863 from eileenmcnaughton/flex

Update flexmailer default

3 years agoMerge pull request #19921 from eileenmcnaughton/tear
Seamus Lee [Sat, 27 Mar 2021 04:37:51 +0000 (15:37 +1100)]
Merge pull request #19921 from eileenmcnaughton/tear

[PHPunit8] cleanup on setUp functions

3 years ago[PHPunit8] cleanup on tearDown functions
eileen [Thu, 25 Mar 2021 09:58:22 +0000 (22:58 +1300)]
[PHPunit8] cleanup on tearDown functions

3 years agoFlexmailer - Switch defintion of "auto" to "flexmailer"
Tim Otten [Sat, 27 Mar 2021 02:11:54 +0000 (19:11 -0700)]
Flexmailer - Switch defintion of "auto" to "flexmailer"

3 years agoMerge pull request #19893 from eileenmcnaughton/mem_types
Eileen McNaughton [Sat, 27 Mar 2021 00:33:26 +0000 (13:33 +1300)]
Merge pull request #19893 from eileenmcnaughton/mem_types

[REF]  [Towards membership api] Simplify calculation of recurring membership parameters

3 years agoMerge pull request #19919 from eileenmcnaughton/pay2
Eileen McNaughton [Sat, 27 Mar 2021 00:32:55 +0000 (13:32 +1300)]
Merge pull request #19919 from eileenmcnaughton/pay2

Remove deprecated code

3 years agoMerge pull request #19918 from eileenmcnaughton/payment
colemanw [Sat, 27 Mar 2021 00:11:41 +0000 (20:11 -0400)]
Merge pull request #19918 from eileenmcnaughton/payment

Add FinancialTrxn apiv4

3 years agoRemove deprecated code
eileen [Fri, 26 Mar 2021 21:37:36 +0000 (10:37 +1300)]
Remove deprecated code

3 years agoMerge pull request #19806 from eileenmcnaughton/msg_compat
Tim Otten [Fri, 26 Mar 2021 21:26:34 +0000 (14:26 -0700)]
Merge pull request #19806 from eileenmcnaughton/msg_compat

Align most of the tokens in the token processor handling with the legacy handling

3 years agoAdd FinancialTrxn apiv4
eileen [Fri, 26 Mar 2021 21:07:18 +0000 (10:07 +1300)]
Add FinancialTrxn apiv4

3 years agoMerge pull request #19912 from eileenmcnaughton/batch
colemanw [Fri, 26 Mar 2021 21:04:57 +0000 (17:04 -0400)]
Merge pull request #19912 from eileenmcnaughton/batch

[REF] [Towards membership api] Duplicate emailReceipt function rather than silly sharing

3 years ago[REF] Simplify calculation of recurring membership parameters
eileen [Wed, 24 Mar 2021 22:29:47 +0000 (11:29 +1300)]
[REF] Simplify calculation of recurring membership parameters

We need frequency_unit & frequency_interval for the params we pass
to the payment process & those we use to create the recurring -
this simplifies them to be calculated in a function rather than being
passed around

For the legacyProcessRecurringContribution function to be reached
auto_renew must be true

3 years agoMerge pull request #19915 from eileenmcnaughton/mem_end
Monish Deb [Fri, 26 Mar 2021 12:32:06 +0000 (18:02 +0530)]
Merge pull request #19915 from eileenmcnaughton/mem_end

[REF] [Towards membership api] Simplify message functions

3 years agoMerge pull request #19906 from MikeyMJCO/patch-8
Eileen McNaughton [Fri, 26 Mar 2021 09:21:09 +0000 (22:21 +1300)]
Merge pull request #19906 from MikeyMJCO/patch-8

Rebuild the Drupal route cache.

3 years ago[REF] [Towards membership api] Simplify message functions
eileen [Fri, 26 Mar 2021 06:38:23 +0000 (19:38 +1300)]
[REF] [Towards membership api] Simplify message functions

The amount of code confusion to avoid loading the end_date isn't really warranted for the
performance boost....

3 years agoMerge pull request #19910 from eileenmcnaughton/mem_pay
Monish Deb [Fri, 26 Mar 2021 05:38:58 +0000 (11:08 +0530)]
Merge pull request #19910 from eileenmcnaughton/mem_pay

[REF] [Towards membership api] Cleanup access to payment_processor_id

3 years agoMerge pull request #19905 from eileenmcnaughton/tear
Eileen McNaughton [Fri, 26 Mar 2021 04:15:53 +0000 (17:15 +1300)]
Merge pull request #19905 from eileenmcnaughton/tear

[PHPunit8] cleanup on tearDown functions

3 years ago[REF] Duplicate emailReceipt function rather than silly sharing
eileen [Fri, 26 Mar 2021 03:06:27 +0000 (16:06 +1300)]
[REF] Duplicate emailReceipt function rather than silly sharing

3 years ago[PHPunit8] cleanup on tearDown functions
eileen [Thu, 25 Mar 2021 09:58:22 +0000 (22:58 +1300)]
[PHPunit8] cleanup on tearDown functions

3 years ago[REF] Cleanup access to payment_processor_id
eileen [Thu, 25 Mar 2021 23:38:08 +0000 (12:38 +1300)]
[REF] Cleanup access to payment_processor_id

3 years agoMerge pull request #19909 from eileenmcnaughton/setup
Seamus Lee [Thu, 25 Mar 2021 22:37:51 +0000 (09:37 +1100)]
Merge pull request #19909 from eileenmcnaughton/setup

[phpunit8] Add void to some setup() functions

3 years agoMerge pull request #19908 from colemanw/relationshipCacheReadonly
Eileen McNaughton [Thu, 25 Mar 2021 21:19:55 +0000 (10:19 +1300)]
Merge pull request #19908 from colemanw/relationshipCacheReadonly

Schema - Add readonly to all fields in RelationshipCache entity

3 years agoAdd void to some setup() functions
eileen [Thu, 25 Mar 2021 20:27:46 +0000 (09:27 +1300)]
Add void to some setup() functions

3 years agoRebuild the Drupal route cache.
Mikey O'Toole [Thu, 25 Mar 2021 19:32:51 +0000 (19:32 +0000)]
Rebuild the Drupal route cache.

This is linked to [issue 158](https://lab.civicrm.org/dev/drupal/-/issues/158) and [issue 37](https://lab.civicrm.org/dev/drupal/-/issues/37).

It takes an alternative approach, adding a Util hook function to rebuild the route cache which we can then invoke from multiple places.
Trigger `rebuildDrupalRouteCache()` when running `triggerRebuild()`
Fix checkstyle issues
Change function from `protected` to `public`
Update Drupal8.php
Add base for `invalidateRouteCache()`
Add invalidateRouteCache function
Add call to userFramework->invalidateRouteCache
Update Base.php
Correct `userFramework` to `userSystem`
Remove stray whitespace.
Move invalidateRouteCache call to the same place as resetNavigation.
Update Invoke.php
Switch to the `router.builder' option as invalidating the cache doesn't cut it.

3 years agoMerge pull request #19870 from totten/master-psr0
colemanw [Thu, 25 Mar 2021 16:16:10 +0000 (12:16 -0400)]
Merge pull request #19870 from totten/master-psr0

info.xml - Allow PSR-0 style class-loader declarations

3 years agoSchema - Add readonly to all fields in RelationshipCache entity
Coleman Watts [Thu, 25 Mar 2021 15:52:33 +0000 (11:52 -0400)]
Schema - Add readonly to all fields in RelationshipCache entity

This entire entity is readonly. Fields should never be presented to the user as editable.

3 years agoMerge pull request #19901 from eileenmcnaughton/tte
Seamus Lee [Thu, 25 Mar 2021 09:22:45 +0000 (20:22 +1100)]
Merge pull request #19901 from eileenmcnaughton/tte

[phpunit 8] Remove some empty tearDown functions

3 years agoMerge pull request #19898 from eileenmcnaughton/teardown2
Seamus Lee [Thu, 25 Mar 2021 09:21:09 +0000 (20:21 +1100)]
Merge pull request #19898 from eileenmcnaughton/teardown2

More phpunit8 prep

3 years agoMerge pull request #19899 from eileenmcnaughton/tear
Seamus Lee [Thu, 25 Mar 2021 09:20:48 +0000 (20:20 +1100)]
Merge pull request #19899 from eileenmcnaughton/tear

[PHPUNIT8] add void to more teardown()

3 years agoMerge pull request #19900 from eileenmcnaughton/tear2
Seamus Lee [Thu, 25 Mar 2021 09:20:30 +0000 (20:20 +1100)]
Merge pull request #19900 from eileenmcnaughton/tear2

[PHPUNIT 8 ] Add void to more teardowns

3 years agoMerge pull request #19891 from eileenmcnaughton/task1
Monish Deb [Thu, 25 Mar 2021 05:54:16 +0000 (11:24 +0530)]
Merge pull request #19891 from eileenmcnaughton/task1

[REF] Simplify setting of softcredit form options (minor)

3 years agoMerge pull request #19897 from eileenmcnaughton/teardown
Eileen McNaughton [Thu, 25 Mar 2021 04:31:08 +0000 (17:31 +1300)]
Merge pull request #19897 from eileenmcnaughton/teardown

Add :void return type to tearDown on a bunch of unit tests

3 years agoMerge pull request #19639 from eileenmcnaughton/test_test
Monish Deb [Thu, 25 Mar 2021 04:02:09 +0000 (09:32 +0530)]
Merge pull request #19639 from eileenmcnaughton/test_test

[REF] Fix ContributionPage::recurringNotify to use apiv4, simplify params

3 years agoMerge pull request #19896 from colemanw/api4GetActionsFix
Eileen McNaughton [Thu, 25 Mar 2021 02:59:12 +0000 (15:59 +1300)]
Merge pull request #19896 from colemanw/api4GetActionsFix

APIv4 - Fix GetActions function to work with entityNames that don't match className

3 years agoMerge pull request #19895 from eileenmcnaughton/falsefail
Eileen McNaughton [Thu, 25 Mar 2021 02:58:39 +0000 (15:58 +1300)]
Merge pull request #19895 from eileenmcnaughton/falsefail

Skip UFField.field_name on singleValueAlter as flakey

3 years agoRemove some empty tearDown functions
eileen [Thu, 25 Mar 2021 02:25:11 +0000 (15:25 +1300)]
Remove some empty tearDown functions

3 years ago[PHPUNIT 8 ] Add void to more teardowns
eileen [Thu, 25 Mar 2021 02:17:49 +0000 (15:17 +1300)]
[PHPUNIT 8 ] Add void to more teardowns

3 years ago[PHPUNIT8] add void to more teardown()
eileen [Thu, 25 Mar 2021 02:12:59 +0000 (15:12 +1300)]
[PHPUNIT8] add void to more teardown()

3 years agoMore phpunit8 prep
eileen [Thu, 25 Mar 2021 02:03:58 +0000 (15:03 +1300)]
More phpunit8 prep

3 years agoAdd :void return type to tearDown on a bunch of unit tests
eileen [Thu, 25 Mar 2021 01:51:27 +0000 (14:51 +1300)]
Add :void return type to tearDown on a bunch of unit tests

3 years agoAPIv4 - Fix GetActions function to work with entityNames that don't match className
Coleman Watts [Thu, 25 Mar 2021 00:13:57 +0000 (20:13 -0400)]
APIv4 - Fix GetActions function to work with entityNames that don't match className

3 years agoMerge pull request #19892 from colemanw/searchKitCreatedModified
Eileen McNaughton [Wed, 24 Mar 2021 23:54:37 +0000 (12:54 +1300)]
Merge pull request #19892 from colemanw/searchKitCreatedModified

SearchKit - Add created & modified info to SavedSearch listing

3 years agoMerge pull request #19312 from seamuslee001/dev_core_1845
Eileen McNaughton [Wed, 24 Mar 2021 23:24:11 +0000 (12:24 +1300)]
Merge pull request #19312 from seamuslee001/dev_core_1845

dev/core#1845 Change FK on civicrm_group to delete the associated gro…

3 years agoMerge pull request #19885 from eileenmcnaughton/acl_role
Eileen McNaughton [Wed, 24 Mar 2021 23:07:04 +0000 (12:07 +1300)]
Merge pull request #19885 from eileenmcnaughton/acl_role

[REF] Remove redundant toArray() function

3 years agoSearchKit - Add created & modified info to SavedSearch listing
Coleman Watts [Wed, 24 Mar 2021 22:15:08 +0000 (18:15 -0400)]
SearchKit - Add created & modified info to SavedSearch listing

3 years agoSimplify setting of softcredit form options
eileen [Fri, 19 Mar 2021 21:34:42 +0000 (10:34 +1300)]
Simplify setting of softcredit form options

I checked & the empty is just an enotice fix

3 years agoRemove toArray function as it does the same as the parent
eileen [Wed, 24 Mar 2021 03:25:08 +0000 (16:25 +1300)]
Remove toArray function as it does the same as the parent

3 years agoMerge pull request #19881 from eileenmcnaughton/task1
colemanw [Wed, 24 Mar 2021 20:19:25 +0000 (16:19 -0400)]
Merge pull request #19881 from eileenmcnaughton/task1

[REF] Store the getSearchQueryResults so it can be re-accessed

3 years agoMerge pull request #19889 from colemanw/api4EntityNameCleanup
Eileen McNaughton [Wed, 24 Mar 2021 20:12:15 +0000 (09:12 +1300)]
Merge pull request #19889 from colemanw/api4EntityNameCleanup

APIv4 - Standardize generic entity name resolution

3 years agoMerge pull request #19875 from colemanw/contactSummaryCleanup
Eileen McNaughton [Wed, 24 Mar 2021 19:35:34 +0000 (08:35 +1300)]
Merge pull request #19875 from colemanw/contactSummaryCleanup

Reorganize contact summary template to support non-ajax tabs

3 years agoAPIv4 - Standardize generic entity name resolution so that classNames do not have...
Coleman Watts [Wed, 24 Mar 2021 18:22:36 +0000 (14:22 -0400)]
APIv4 - Standardize generic entity name resolution so that classNames do not have to equal entityNames

This will allow the addition of a CiviCase API which cannot have the className "Case" because that is a reserved php keyword

Also cleans up other entities that use `static::class` in place of entityName because it's not a good pattern to replicate.

3 years agoMerge pull request #19801 from eileenmcnaughton/mem_terms
colemanw [Wed, 24 Mar 2021 15:17:12 +0000 (11:17 -0400)]
Merge pull request #19801 from eileenmcnaughton/mem_terms

[REF] Simplify code calculating the number of membership terms

3 years agoMerge pull request #19884 from eileenmcnaughton/unit8less
Seamus Lee [Wed, 24 Mar 2021 05:17:54 +0000 (16:17 +1100)]
Merge pull request #19884 from eileenmcnaughton/unit8less

Updates to ExportTest

3 years agoMerge pull request #19818 from eileenmcnaughton/merge_fix
Eileen McNaughton [Wed, 24 Mar 2021 03:17:03 +0000 (16:17 +1300)]
Merge pull request #19818 from eileenmcnaughton/merge_fix

Fix for dedupe error under some mysql configs

3 years agoUpdates to ExportTest
eileen [Wed, 24 Mar 2021 02:21:10 +0000 (15:21 +1300)]
Updates to ExportTest

3 years agoTest fix to avoid caching issue
eileen [Wed, 24 Mar 2021 02:42:52 +0000 (15:42 +1300)]
Test fix to avoid caching issue

3 years agoMerge pull request #19882 from eileenmcnaughton/acl_role
Seamus Lee [Wed, 24 Mar 2021 01:41:15 +0000 (12:41 +1100)]
Merge pull request #19882 from eileenmcnaughton/acl_role

Fold back in getGroupACLs

3 years agoMerge pull request #19817 from eileenmcnaughton/merge
Seamus Lee [Wed, 24 Mar 2021 01:35:53 +0000 (12:35 +1100)]
Merge pull request #19817 from eileenmcnaughton/merge

Tighten mysql mode in test environment

3 years agoMerge pull request #19880 from demeritcowboy/crmmoney2
Eileen McNaughton [Wed, 24 Mar 2021 01:32:10 +0000 (14:32 +1300)]
Merge pull request #19880 from demeritcowboy/crmmoney2

dev/financial#171 - Don't pass already formatted data to crmMoney on contact summary for custom fields

3 years agoFold back in getGroupACLs
eileen [Tue, 23 Mar 2021 23:30:37 +0000 (12:30 +1300)]
Fold back in getGroupACLs

3 years agoMerge pull request #19879 from eileenmcnaughton/acl_role
Eileen McNaughton [Wed, 24 Mar 2021 00:23:17 +0000 (13:23 +1300)]
Merge pull request #19879 from eileenmcnaughton/acl_role

Remove getACLRoles

3 years ago[REF] Fix the getSearchQueryResults so it can be called multiple times
eileen [Fri, 19 Mar 2021 21:23:31 +0000 (10:23 +1300)]
[REF] Fix the getSearchQueryResults so it can be called multiple times

3 years agodon't pass already formatted data to crmMoney
demeritcowboy [Tue, 23 Mar 2021 23:52:39 +0000 (19:52 -0400)]
don't pass already formatted data to crmMoney

3 years agoMerge pull request #19860 from eileenmcnaughton/task1
colemanw [Tue, 23 Mar 2021 23:49:37 +0000 (19:49 -0400)]
Merge pull request #19860 from eileenmcnaughton/task1

Move setting of _includesSoftCredits out of getQuery

3 years agoMerge pull request #19868 from colemanw/searchKitFixExtraFields
Eileen McNaughton [Tue, 23 Mar 2021 23:40:25 +0000 (12:40 +1300)]
Merge pull request #19868 from colemanw/searchKitFixExtraFields

SearchKit - remove extra irrelevant fields from bridge joins

3 years agoFix token subscriber to format the display of the custom tokens
eileen [Mon, 15 Mar 2021 05:55:33 +0000 (18:55 +1300)]
Fix token subscriber to format the display of the custom tokens

3 years agoAdd fix for enotice when trying to resolve custom data of type array
eileen [Mon, 15 Mar 2021 05:43:53 +0000 (18:43 +1300)]
Add fix for enotice when trying to resolve custom data of type array

3 years agoAdd test cover to check compatsubscriber is in sync with legacy token
eileen [Mon, 15 Mar 2021 05:34:30 +0000 (18:34 +1300)]
Add test cover to check compatsubscriber is in sync with legacy token

3 years agoMerge pull request #19878 from civicrm/5.36
Seamus Lee [Tue, 23 Mar 2021 22:56:32 +0000 (09:56 +1100)]
Merge pull request #19878 from civicrm/5.36

5.36

3 years agoRemove getACLRoles
eileen [Tue, 23 Mar 2021 22:35:04 +0000 (11:35 +1300)]
Remove getACLRoles

We have cleaned up the code to clarify that
1) it returns an empty array if contact id is set and
2) it is only called with contact_id is set

Ergo it does nada

Not called from anywhere else (I made it protected last
cleanup round)

3 years agoMerge pull request #19872 from eileenmcnaughton/acl_role
Seamus Lee [Tue, 23 Mar 2021 22:14:49 +0000 (09:14 +1100)]
Merge pull request #19872 from eileenmcnaughton/acl_role

[REF] Fold getACLs back into the calling function

3 years agoMerge pull request #19867 from colemanw/civiCaseApi
Eileen McNaughton [Tue, 23 Mar 2021 22:14:26 +0000 (11:14 +1300)]
Merge pull request #19867 from colemanw/civiCaseApi

APIv4 - Add function to get api class name

3 years agoMerge pull request #19743 from totten/master-upg
Eileen McNaughton [Tue, 23 Mar 2021 22:07:10 +0000 (11:07 +1300)]
Merge pull request #19743 from totten/master-upg

dev/release#16 - Allow omission of empty upgrade steps

3 years agoMerge pull request #19874 from demeritcowboy/blank-assignee
Seamus Lee [Tue, 23 Mar 2021 21:25:37 +0000 (08:25 +1100)]
Merge pull request #19874 from demeritcowboy/blank-assignee

[WIP] dev/core#2473 - Don't crash when assignee left blank when creating followup on email activity

3 years agoMerge pull request #19877 from eileenmcnaughton/camp
Eileen McNaughton [Tue, 23 Mar 2021 21:03:48 +0000 (10:03 +1300)]
Merge pull request #19877 from eileenmcnaughton/camp

[REF] Stdise campaign_id handling

3 years agoMerge pull request #19876 from demeritcowboy/dont
Eileen McNaughton [Tue, 23 Mar 2021 21:03:31 +0000 (10:03 +1300)]
Merge pull request #19876 from demeritcowboy/dont

dev/financial#171 - Don't

3 years ago[REF] Stdise campaign_id handling
eileen [Tue, 23 Mar 2021 19:44:34 +0000 (08:44 +1300)]
[REF] Stdise campaign_id handling

3 years agodon't
demeritcowboy [Tue, 23 Mar 2021 19:26:05 +0000 (15:26 -0400)]
don't

3 years agoReorganize contact summary template to support non-ajax tabs
Coleman Watts [Tue, 23 Mar 2021 14:44:14 +0000 (10:44 -0400)]
Reorganize contact summary template to support non-ajax tabs

There was some non-functional (due to a typo) code in TabHeader.tpl to allow tabs to load from a .tpl instead of ajax.
This fixes that typo and copies the funcionality into the contact summary tabs as well.
The functionality is demonstrated here by moving the main tab into a sub-tempate.

3 years agoMerge pull request #19757 from eileenmcnaughton/tax_amount
colemanw [Tue, 23 Mar 2021 19:04:16 +0000 (15:04 -0400)]
Merge pull request #19757 from eileenmcnaughton/tax_amount

[REF] Minor simplification around assigning taxAmount to the template

3 years agoMerge pull request #19800 from eileenmcnaughton/gettypes
colemanw [Tue, 23 Mar 2021 18:40:52 +0000 (14:40 -0400)]
Merge pull request #19800 from eileenmcnaughton/gettypes

[REF] Remove setting of unused variables

3 years agocrash when assignee left blank
demeritcowboy [Tue, 23 Mar 2021 17:37:50 +0000 (13:37 -0400)]
crash when assignee left blank

3 years agoMerge pull request #19797 from eileenmcnaughton/super_duper
colemanw [Tue, 23 Mar 2021 12:24:25 +0000 (08:24 -0400)]
Merge pull request #19797 from eileenmcnaughton/super_duper

Add new Super-duper-no-permissions-apply permission

3 years agodev/core#1845 Change FK on civicrm_group to delete the associated group if a saved...
Michael McAndrew [Thu, 11 Mar 2021 15:38:43 +0000 (15:38 +0000)]
dev/core#1845 Change FK on civicrm_group to delete the associated group if a saved search is deleted

Add in delete function on Group BAO to handle deleting associated saved search if appropriate when group is deleted and move upgrade step appropriately

Add unit test and move code to the discard function

3 years agoMerge pull request #19764 from JMAConsulting/core-59
Seamus Lee [Tue, 23 Mar 2021 02:08:09 +0000 (13:08 +1100)]
Merge pull request #19764 from JMAConsulting/core-59

core#59: Address location type search errors when using a search profile

3 years agoMerge pull request #19871 from eileenmcnaughton/acl
Seamus Lee [Tue, 23 Mar 2021 02:04:02 +0000 (13:04 +1100)]
Merge pull request #19871 from eileenmcnaughton/acl

Return from getACLRoles when contactID is not null

3 years ago[REF] Fold getACLs back into the calling function
eileen [Tue, 23 Mar 2021 01:07:16 +0000 (14:07 +1300)]
[REF] Fold getACLs back into the calling function

Not called in the civi universe

3 years agoReturn from getACLRoles when contactID is null
eileen [Tue, 23 Mar 2021 00:29:45 +0000 (13:29 +1300)]
Return from getACLRoles when contactID is null

I've made this patch the least possible code wise to allow brain space to think about the query....

Basically the where is WHERE acl.entity_table='civicrm_acl_role'....

if contact_id is set it becomes AND acl.entity_table = 'civicrm_contact'

Which means that it would only ever return empty results

(once this is merged more cleanup can happen but I wanted to
make this change easy to think through)

3 years agoMerge pull request #19869 from eileenmcnaughton/acl
Eileen McNaughton [Tue, 23 Mar 2021 00:26:10 +0000 (13:26 +1300)]
Merge pull request #19869 from eileenmcnaughton/acl

[REF] Simplify BAO_ACL table references

3 years agoinfo.xml - Allow PSR-0 style class-loader declarations
Tim Otten [Mon, 22 Mar 2021 23:40:39 +0000 (16:40 -0700)]
info.xml - Allow PSR-0 style class-loader declarations

Before
------

If an extension defines a class in the style of `CRM_Foo_Bar`, then it
*must* use `hook_civicrm_config` and modify the `include_path`.

```php
function mymod_civicrm_config(&$config = NULL) {
  $extRoot = dirname(__FILE__) . DIRECTORY_SEPARATOR;
  $include_path = $extRoot . PATH_SEPARATOR . get_include_path();
  set_include_path($include_path);
}
```

Consequently:

* The `include_path` gets rather long.
* Setting up the extension class-loader is not sufficient for loading these classes. You must
  wait until the DB has initialized and the `hook_civicrm_config` has fired.

After
-----

An extension *may* setup classloading in `info.xml`, e.g.

```xml
<classloader>
  <psr0 prefix="CRM_" path="" />
</classloader>
```

If the `<psr0>` style is used, then it is possible to scan the extension
classes without fully booting the extension.  This is a pre-requisite for
using interfaces, annotations, or similar for event-registration.

Comments
--------

* This style closely parallels the `<psr4>` support in `info.xml`, and it parallels the semantics of `composer.json`.
* It is still valid for an extension to set `include_path` -- that works the same as ever.

3 years agoRemove exposure of implied_permissions beyond class
eileen [Sun, 21 Mar 2021 22:16:33 +0000 (11:16 +1300)]
Remove exposure of implied_permissions beyond class