civicrm-core.git
10 years agoCRM-15207 - cherry-pick code changes to fix the Membership separate payment bug....
Dave Greenberg [Wed, 3 Sep 2014 20:32:57 +0000 (13:32 -0700)]
CRM-15207 - cherry-pick code changes to fix the Membership separate payment bug. The modifications to CiviUnitTestCase.php are causing test failures and need to be reworked.

----------------------------------------
* CRM-15207:
  https://issues.civicrm.org/jira/browse/CRM-15207

10 years agoMerge pull request #4036 from colemanw/CRM-15225
Dave Greenberg [Wed, 3 Sep 2014 18:15:04 +0000 (11:15 -0700)]
Merge pull request #4036 from colemanw/CRM-15225

CRM-15225 - Fix handling of chainSelect on billing forms

10 years agoCRM-15225 - Add comment to explain the fix
Coleman Watts [Wed, 3 Sep 2014 11:12:38 +0000 (12:12 +0100)]
CRM-15225 - Add comment to explain the fix

10 years agoCRM-15225 - Fix handling of chainSelect on billing forms
Coleman Watts [Wed, 3 Sep 2014 10:49:26 +0000 (11:49 +0100)]
CRM-15225 - Fix handling of chainSelect on billing forms

10 years agoMinor cleanup
Coleman Watts [Wed, 3 Sep 2014 10:47:22 +0000 (11:47 +0100)]
Minor cleanup

10 years agoComment fix
Coleman Watts [Wed, 3 Sep 2014 10:46:01 +0000 (11:46 +0100)]
Comment fix

10 years agoMerge pull request #4028 from davecivicrm/CRM-15226
Dave Greenberg [Wed, 3 Sep 2014 01:58:09 +0000 (18:58 -0700)]
Merge pull request #4028 from davecivicrm/CRM-15226

CRM-15226 - label improvements.

10 years agoCRM-15226 - label improvements.
Dave Greenberg [Wed, 3 Sep 2014 01:57:16 +0000 (18:57 -0700)]
CRM-15226 - label improvements.

----------------------------------------
* CRM-15226:
  https://issues.civicrm.org/jira/browse/CRM-15226

10 years agoMerge pull request #4025 from pradpnayak/CRM-14853
Dave Greenberg [Wed, 3 Sep 2014 00:11:41 +0000 (17:11 -0700)]
Merge pull request #4025 from pradpnayak/CRM-14853

-- CRM-14853, change payment instrument id when contribution status is c...

10 years agoMerge pull request #4012 from pradpnayak/CRM-15206
Dave Greenberg [Tue, 2 Sep 2014 22:04:18 +0000 (15:04 -0700)]
Merge pull request #4012 from pradpnayak/CRM-15206

-- CRM-15206, fixed display of line item on edit contribution form

10 years agoMerge pull request #4026 from davecivicrm/CRM-15205
Dave Greenberg [Tue, 2 Sep 2014 21:33:23 +0000 (14:33 -0700)]
Merge pull request #4026 from davecivicrm/CRM-15205

CRM-15205 - replaces PR 4001 with rebuilt civicrm_generated.mysql file.

10 years agoCRM-15205 - replaces PR 4001 with rebuilt civicrm_generated.mysql file.
Dave Greenberg [Tue, 2 Sep 2014 21:31:38 +0000 (14:31 -0700)]
CRM-15205 - replaces PR 4001 with rebuilt civicrm_generated.mysql file.

----------------------------------------
* CRM-15205:
  https://issues.civicrm.org/jira/browse/CRM-15205

10 years ago-- CRM-14853, change payment instrument id when contribution status is changed from...
Pradeep Nayak [Tue, 2 Sep 2014 20:35:03 +0000 (02:05 +0530)]
-- CRM-14853, change payment instrument id when contribution status is changed from In-progress/Pending to Completed

----------------------------------------
* CRM-14853: Bookkeeping report represents payment type incorrectly
  https://issues.civicrm.org/jira/browse/CRM-14853

10 years agoMerge pull request #4023 from jitendrapurohit/WebtestFix4.5.0
Kurund Jalmi [Tue, 2 Sep 2014 19:41:16 +0000 (01:11 +0530)]
Merge pull request #4023 from jitendrapurohit/WebtestFix4.5.0

Webtest Fix 4.5.0

10 years agoMerge pull request #4024 from kurund/version-fixes
Kurund Jalmi [Tue, 2 Sep 2014 19:09:43 +0000 (00:39 +0530)]
Merge pull request #4024 from kurund/version-fixes

version fixes for beta9

10 years agofixes for beta9
kurund [Tue, 2 Sep 2014 19:07:33 +0000 (00:37 +0530)]
fixes for beta9

10 years agoMerge pull request #4022 from colemanw/CRM-15220
colemanw [Tue, 2 Sep 2014 14:10:06 +0000 (15:10 +0100)]
Merge pull request #4022 from colemanw/CRM-15220

CRM-15220 - Fix malformed url in grant menu

10 years agoWebtest 4.5.0
Jitendra Purohit [Tue, 2 Sep 2014 13:21:54 +0000 (18:51 +0530)]
Webtest 4.5.0

10 years agoCRM-15220 - Add status options to grant menu
Coleman Watts [Tue, 2 Sep 2014 12:52:09 +0000 (13:52 +0100)]
CRM-15220 - Add status options to grant menu

10 years agoCRM-15220 - Fix malformed url in grant menu
Coleman Watts [Tue, 2 Sep 2014 12:29:31 +0000 (13:29 +0100)]
CRM-15220 - Fix malformed url in grant menu

10 years agoMerge pull request #4021 from colemanw/CRM-15218
colemanw [Tue, 2 Sep 2014 12:20:21 +0000 (13:20 +0100)]
Merge pull request #4021 from colemanw/CRM-15218

CRM-15218 - Update non-standard profile names

10 years agoCRM-15218 - Update non-standard profile names
Coleman Watts [Tue, 2 Sep 2014 11:36:26 +0000 (12:36 +0100)]
CRM-15218 - Update non-standard profile names

10 years agoMerge pull request #3984 from yashodha/CRM-15171
Yashodha Chaku [Tue, 2 Sep 2014 09:43:39 +0000 (15:13 +0530)]
Merge pull request #3984 from yashodha/CRM-15171

CRM-15171: fix variables in Register.php

10 years agoMerge pull request #4017 from demeritcowboy/CRM-15211
Kurund Jalmi [Tue, 2 Sep 2014 08:06:33 +0000 (13:36 +0530)]
Merge pull request #4017 from demeritcowboy/CRM-15211

CRM-15211

10 years agoFix undefined index warning
Coleman Watts [Mon, 1 Sep 2014 21:58:52 +0000 (22:58 +0100)]
Fix undefined index warning

10 years agoCRM-15211 fix outdated permission
DemeritCowboy [Mon, 1 Sep 2014 21:56:57 +0000 (17:56 -0400)]
CRM-15211 fix outdated permission

10 years agoCRM-15211 fix outdated permission
DemeritCowboy [Mon, 1 Sep 2014 21:22:06 +0000 (17:22 -0400)]
CRM-15211 fix outdated permission

10 years agoMerge pull request #4016 from colemanw/Fix
colemanw [Mon, 1 Sep 2014 19:10:19 +0000 (20:10 +0100)]
Merge pull request #4016 from colemanw/Fix

Fix dynamicResourcepath for windows systems (again)

10 years agoFix dynamicResourcepath for windows systems (again)
Coleman Watts [Mon, 1 Sep 2014 19:09:06 +0000 (20:09 +0100)]
Fix dynamicResourcepath for windows systems (again)

10 years agoMerge remote-tracking branch 'upstream/4.4' into 4.4-4.5-2014-09-01-22-48-29
kurund [Mon, 1 Sep 2014 17:19:07 +0000 (22:49 +0530)]
Merge remote-tracking branch 'upstream/4.4' into 4.4-4.5-2014-09-01-22-48-29

10 years agoMerge branch 'fuzionnz-CRM-13113' into 4.5
Coleman Watts [Mon, 1 Sep 2014 15:54:23 +0000 (16:54 +0100)]
Merge branch 'fuzionnz-CRM-13113' into 4.5

10 years agoMerge pull request #4009 from eileenmcnaughton/CRM-15210
colemanw [Mon, 1 Sep 2014 15:49:14 +0000 (16:49 +0100)]
Merge pull request #4009 from eileenmcnaughton/CRM-15210

CRM-15210 fix fatal on merge exports of non primary addresses

10 years agoMerge pull request #4011 from eileenmcnaughton/CRM-15213
colemanw [Mon, 1 Sep 2014 15:46:11 +0000 (16:46 +0100)]
Merge pull request #4011 from eileenmcnaughton/CRM-15213

CRM-15213 fix spelling of renewal

10 years agoMinor cleanup
Coleman Watts [Mon, 1 Sep 2014 15:45:05 +0000 (16:45 +0100)]
Minor cleanup

10 years agoMerge pull request #4014 from jitendrapurohit/WebtestFix4.5.0
Dave Greenberg [Mon, 1 Sep 2014 15:31:00 +0000 (08:31 -0700)]
Merge pull request #4014 from jitendrapurohit/WebtestFix4.5.0

WebTest Fixes 4.5

10 years agoWebTest Fixes 4.5
Jitendra Purohit [Mon, 1 Sep 2014 13:43:04 +0000 (19:13 +0530)]
WebTest Fixes 4.5

10 years agoMerge pull request #4013 from colemanw/CRM-15215
colemanw [Mon, 1 Sep 2014 13:42:37 +0000 (14:42 +0100)]
Merge pull request #4013 from colemanw/CRM-15215

CRM-15215 - Fix api address validation

10 years agoCRM-15215 - Fix api address validation
Coleman Watts [Mon, 1 Sep 2014 12:50:06 +0000 (13:50 +0100)]
CRM-15215 - Fix api address validation

10 years ago-- CRM-15206, fixed display of line item on edit contribution form
Pradeep Nayak [Mon, 1 Sep 2014 10:51:39 +0000 (16:21 +0530)]
-- CRM-15206, fixed display of line item on edit contribution form

----------------------------------------
* CRM-15206: Edit Contribution form for Membership shows wrong line item
  https://issues.civicrm.org/jira/browse/CRM-15206

10 years agoCRM-15213 fix spelling of renewal
Eileen McNaughton [Mon, 1 Sep 2014 04:21:31 +0000 (16:21 +1200)]
CRM-15213 fix spelling of renewal

10 years agoCRM-15210 fix fatal on merge exports of non primary addresses
Eileen McNaughton [Mon, 1 Sep 2014 02:18:11 +0000 (14:18 +1200)]
CRM-15210 fix fatal on merge exports of non primary addresses
The relationship check is preventing the fields from being transformed
to the correct field names in contacts not-to-be-merged
The possibility of the object not existing is adequately handled further down in the
function. The check was added during svn-days but after 4.2.4
I no longer seem to be able to access what commit introduced it

10 years agoFix CRM-13113. Do not try to foreach() an empty array.
Chris Burgess [Mon, 1 Sep 2014 01:39:15 +0000 (13:39 +1200)]
Fix CRM-13113. Do not try to foreach() an empty array.

10 years agoMerge pull request #4006 from colemanw/crmurl
colemanw [Sun, 31 Aug 2014 10:55:07 +0000 (11:55 +0100)]
Merge pull request #4006 from colemanw/crmurl

Fix edge-case handling in CRM.url

10 years agoFix edge-case handling in CRM.url - CLEAR YOUR CACHES FOLKS
Coleman Watts [Sun, 31 Aug 2014 10:33:35 +0000 (11:33 +0100)]
Fix edge-case handling in CRM.url - CLEAR YOUR CACHES FOLKS

This fixes potential collisions between placeholder strings and the site's url,
such as "init" and "placeholder".

10 years agoMerge pull request #4005 from civicrm/4.5
colemanw [Sun, 31 Aug 2014 09:21:21 +0000 (10:21 +0100)]
Merge pull request #4005 from civicrm/4.5

Partially revert 5dac229eb87

10 years agoPartially revert 5dac229eb87
Coleman Watts [Sun, 31 Aug 2014 09:14:15 +0000 (10:14 +0100)]
Partially revert 5dac229eb87

10 years agoMerge pull request #4003 from civicrm/4.5
colemanw [Sun, 31 Aug 2014 09:01:55 +0000 (10:01 +0100)]
Merge pull request #4003 from civicrm/4.5

Merge branch 4.5 into master

10 years agoMerge pull request #4004 from civicrm/4.4
colemanw [Sun, 31 Aug 2014 09:01:26 +0000 (10:01 +0100)]
Merge pull request #4004 from civicrm/4.4

Merge branch 4.4 into 4.5

10 years agoMerge pull request #3997 from totten/4.5-gencode-tmpdir
Tim Otten [Sun, 31 Aug 2014 00:37:25 +0000 (17:37 -0700)]
Merge pull request #3997 from totten/4.5-gencode-tmpdir

GenCode - Create fewer tempdirs, and create them more securely

10 years agoMerge pull request #4002 from davecivicrm/CRM-15197a
Dave Greenberg [Sun, 31 Aug 2014 00:07:33 +0000 (17:07 -0700)]
Merge pull request #4002 from davecivicrm/CRM-15197a

CRM-15197 - Additional Pledge test fixes.

10 years agoCRM-15197 - Additional Pledge test fixes.
Dave Greenberg [Sun, 31 Aug 2014 00:06:56 +0000 (17:06 -0700)]
CRM-15197 - Additional Pledge test fixes.

----------------------------------------
* CRM-15197:
  https://issues.civicrm.org/jira/browse/CRM-15197

10 years agoCRM-15197 - Additional Pledge test fixes.
Dave Greenberg [Sun, 31 Aug 2014 00:02:34 +0000 (17:02 -0700)]
CRM-15197 - Additional Pledge test fixes.

----------------------------------------
* CRM-15197:
  https://issues.civicrm.org/jira/browse/CRM-15197

10 years agoMerge pull request #4000 from davecivicrm/CRM-15197a
Dave Greenberg [Sat, 30 Aug 2014 23:37:12 +0000 (16:37 -0700)]
Merge pull request #4000 from davecivicrm/CRM-15197a

CRM-15197 - Pledge test fixes: disable pop-ups and fix link text for Rec...

10 years agoCRM-15197 - Pledge test fixes: disable pop-ups and fix link text for Record Payment...
Dave Greenberg [Sat, 30 Aug 2014 23:35:31 +0000 (16:35 -0700)]
CRM-15197 - Pledge test fixes: disable pop-ups and fix link text for Record Payment since it was changed in 4.5.

----------------------------------------
* CRM-15197:
  https://issues.civicrm.org/jira/browse/CRM-15197

10 years agoMerge pull request #3883 from eileenmcnaughton/CRM-14398
Dave Greenberg [Sat, 30 Aug 2014 17:18:57 +0000 (10:18 -0700)]
Merge pull request #3883 from eileenmcnaughton/CRM-14398

CRM-14398 fix campaign in exports

10 years agoMerge pull request #3994 from lcdservices/CRM-15201
Dave Greenberg [Sat, 30 Aug 2014 17:02:21 +0000 (10:02 -0700)]
Merge pull request #3994 from lcdservices/CRM-15201

CRM-15201 fix case get related contacts query

10 years agoMerge pull request #3998 from monishdeb/45-webtest-fix
Monish Deb [Sat, 30 Aug 2014 15:17:48 +0000 (20:47 +0530)]
Merge pull request #3998 from monishdeb/45-webtest-fix

4.5 Webtests fixes

10 years ago4.5 Webtests fixes
monishdeb [Sat, 30 Aug 2014 15:16:07 +0000 (20:46 +0530)]
4.5 Webtests fixes

10 years agoCRM_Core_CodeGen_Util_Smarty - Only generate one instance of Smarty (with one temp...
Tim Otten [Sat, 30 Aug 2014 03:27:24 +0000 (20:27 -0700)]
CRM_Core_CodeGen_Util_Smarty - Only generate one instance of Smarty (with one temp dir)

10 years agoCRM_Core_CodeGen_Util_File - Better tempdir creation
Tim Otten [Sat, 30 Aug 2014 03:08:29 +0000 (20:08 -0700)]
CRM_Core_CodeGen_Util_File - Better tempdir creation

10 years agoMerge pull request #3993 from colemanw/CRM-15058
Dave Greenberg [Fri, 29 Aug 2014 20:45:05 +0000 (13:45 -0700)]
Merge pull request #3993 from colemanw/CRM-15058

CRM-15058 - Cleanup and js bug fixes in ScheduleReminder forms

10 years agoCRM-15058 - Remove unneeded code
Coleman Watts [Fri, 29 Aug 2014 16:14:15 +0000 (17:14 +0100)]
CRM-15058 - Remove unneeded code

10 years agoCRM-15058 - Cleanup and js bug fixes in ScheduleReminder forms
Coleman Watts [Fri, 29 Aug 2014 15:38:03 +0000 (16:38 +0100)]
CRM-15058 - Cleanup and js bug fixes in ScheduleReminder forms

10 years agoCRM-15201 fix case get related contacts query
Brian Shaughnessy [Fri, 29 Aug 2014 16:10:47 +0000 (12:10 -0400)]
CRM-15201 fix case get related contacts query

10 years agoCRM-14398 ... export issues
Eileen McNaughton [Fri, 29 Aug 2014 04:55:11 +0000 (16:55 +1200)]
CRM-14398 ... export issues

10 years agoMerge pull request #3991 from colemanw/CRM-13966
Dave Greenberg [Thu, 28 Aug 2014 23:08:28 +0000 (16:08 -0700)]
Merge pull request #3991 from colemanw/CRM-13966

CRM-13966 - Improve event selection in reports

10 years agoMerge pull request #3990 from davecivicrm/CRM-15158
Dave Greenberg [Thu, 28 Aug 2014 22:35:08 +0000 (15:35 -0700)]
Merge pull request #3990 from davecivicrm/CRM-15158

CRM-15158 - Fix handling of payments in Refund workflows.

10 years agoMerge pull request #3983 from totten/4.5-memblock-err
Tim Otten [Thu, 28 Aug 2014 21:19:24 +0000 (14:19 -0700)]
Merge pull request #3983 from totten/4.5-memblock-err

api_v3_SyntaxConformanceTest - Work-around problem with MembershipBlock

10 years agoCRM-13966 - Improve event selection in reports
Coleman Watts [Thu, 28 Aug 2014 20:50:38 +0000 (21:50 +0100)]
CRM-13966 - Improve event selection in reports

10 years agoMerge pull request #3992 from colemanw/Prevent
colemanw [Thu, 28 Aug 2014 20:59:36 +0000 (21:59 +0100)]
Merge pull request #3992 from colemanw/Prevent

Prevent double confirm box when deleting attachments

10 years agoPrevent double confirm box when deleting attachments
Coleman Watts [Thu, 28 Aug 2014 20:59:24 +0000 (21:59 +0100)]
Prevent double confirm box when deleting attachments

10 years agoCRM-15158 - Fix handling of payments in Refund workflows.
Dave Greenberg [Thu, 28 Aug 2014 20:14:49 +0000 (13:14 -0700)]
CRM-15158 - Fix handling of payments in Refund workflows.

----------------------------------------
* CRM-15158:
  https://issues.civicrm.org/jira/browse/CRM-15158

10 years agoMerge pull request #3989 from colemanw/CRM-15198
Dave Greenberg [Thu, 28 Aug 2014 18:48:38 +0000 (11:48 -0700)]
Merge pull request #3989 from colemanw/CRM-15198

CRM-15198 - Fix error messages when unable to delete financial type

10 years agoFix strings and messages
Coleman Watts [Thu, 28 Aug 2014 16:55:13 +0000 (17:55 +0100)]
Fix strings and messages

10 years agoCRM-15198 - Fix error messages when unable to delete financial type
Coleman Watts [Thu, 28 Aug 2014 16:30:04 +0000 (17:30 +0100)]
CRM-15198 - Fix error messages when unable to delete financial type

10 years agoMerge pull request #3987 from colemanw/menuHeight
colemanw [Thu, 28 Aug 2014 15:54:19 +0000 (16:54 +0100)]
Merge pull request #3987 from colemanw/menuHeight

More accurate dialog size calculations

10 years agoMore accurate dialog size calculations
Coleman Watts [Thu, 28 Aug 2014 15:52:34 +0000 (16:52 +0100)]
More accurate dialog size calculations

10 years agoEvent participant form code cleanup
Coleman Watts [Thu, 28 Aug 2014 15:19:08 +0000 (16:19 +0100)]
Event participant form code cleanup

10 years agoMerge pull request #3986 from colemanw/String
colemanw [Thu, 28 Aug 2014 14:50:13 +0000 (15:50 +0100)]
Merge pull request #3986 from colemanw/String

String fixes

10 years agoString fixes
Coleman Watts [Thu, 28 Aug 2014 14:48:55 +0000 (15:48 +0100)]
String fixes

10 years agoMerge pull request #3972 from colemanw/CRM-15193
colemanw [Thu, 28 Aug 2014 14:36:35 +0000 (15:36 +0100)]
Merge pull request #3972 from colemanw/CRM-15193

CRM-15193 - Support front/back end modes in CRM.url

10 years agoCRM-15193 - Ensure profile create links go to the backend
Coleman Watts [Thu, 28 Aug 2014 13:38:34 +0000 (14:38 +0100)]
CRM-15193 - Ensure profile create links go to the backend

10 years agoReset cacheCode when flushing dynamic resources
Coleman Watts [Wed, 27 Aug 2014 22:33:29 +0000 (23:33 +0100)]
Reset cacheCode when flushing dynamic resources

10 years agoAdd cacheCode to dynamic resource urls
Coleman Watts [Wed, 27 Aug 2014 22:22:50 +0000 (23:22 +0100)]
Add cacheCode to dynamic resource urls

10 years agoCRM-15193 - Support front/back end modes in CRM.url
Coleman Watts [Wed, 27 Aug 2014 22:06:34 +0000 (23:06 +0100)]
CRM-15193 - Support front/back end modes in CRM.url

10 years agoMerge pull request #3985 from jitendrapurohit/Webtest-4.5.0
Kurund Jalmi [Thu, 28 Aug 2014 13:31:10 +0000 (19:01 +0530)]
Merge pull request #3985 from jitendrapurohit/Webtest-4.5.0

Webtest Fix 4.5

10 years agoWebtest Fix 4.5
Jitendra Purohit [Thu, 28 Aug 2014 13:24:00 +0000 (18:54 +0530)]
Webtest Fix 4.5

10 years agoCRM-15171: fix variables in Register.php
CiviCRM [Thu, 28 Aug 2014 12:39:09 +0000 (18:09 +0530)]
CRM-15171: fix variables in Register.php

10 years agoAdditional check to see if profileCreate links are empty
Coleman Watts [Thu, 28 Aug 2014 11:35:37 +0000 (12:35 +0100)]
Additional check to see if profileCreate links are empty

10 years agoMerge pull request #3981 from totten/4.5-log-error
Tim Otten [Thu, 28 Aug 2014 07:42:10 +0000 (00:42 -0700)]
Merge pull request #3981 from totten/4.5-log-error

CRM_Core_ErrorTest - Fix local failiure (observed in OS X 10.7, MAMP 2.x)

10 years agoMerge pull request #3982 from yashodha/HR-402
Yashodha Chaku [Thu, 28 Aug 2014 06:47:13 +0000 (12:17 +0530)]
Merge pull request #3982 from yashodha/HR-402

HR-402: fix for notices on case status

10 years agoapi_v3_SyntaxConformanceTest - Work-around problem with MembershipBlock
Tim Otten [Thu, 28 Aug 2014 06:32:51 +0000 (23:32 -0700)]
api_v3_SyntaxConformanceTest - Work-around problem with MembershipBlock

10 years agoMerge pull request #3980 from totten/4.5-component-tests
Tim Otten [Thu, 28 Aug 2014 06:11:09 +0000 (23:11 -0700)]
Merge pull request #3980 from totten/4.5-component-tests

CRM_Core_BAO_SettingTest - Fix setting leakage which breaks CRM_Core_BAO_SettingTest

10 years agoHR-402: fix for notices on case status
CiviCRM [Thu, 28 Aug 2014 05:54:05 +0000 (11:24 +0530)]
HR-402: fix for notices on case status

10 years agoCRM_Core_ErrorTest - Fix local failiure (observed in OS X 10.7, MAMP 2.x)
Tim Otten [Thu, 28 Aug 2014 05:18:52 +0000 (22:18 -0700)]
CRM_Core_ErrorTest - Fix local failiure (observed in OS X 10.7, MAMP 2.x)

10 years agoMerge pull request #3979 from eileenmcnaughton/CRM-15196
Tim Otten [Thu, 28 Aug 2014 05:20:56 +0000 (22:20 -0700)]
Merge pull request #3979 from eileenmcnaughton/CRM-15196

CRM-15196 mysql 5.6 is too strict on altering columns which have fks

10 years agoMerge pull request #3978 from totten/4.5-revert-450a63
Tim Otten [Thu, 28 Aug 2014 04:31:13 +0000 (21:31 -0700)]
Merge pull request #3978 from totten/4.5-revert-450a63

Revert "CRM-14946 add relevant test data set"

10 years agoCRM_Case_PseudoConstantTest - Fix
Tim Otten [Thu, 28 Aug 2014 04:04:50 +0000 (21:04 -0700)]
CRM_Case_PseudoConstantTest - Fix

The old assertion was dependending on the previous test (e.g. the
list of case-types added/removed). By changing the base class
to CiviCaseTestCase, we get a more consistent (but different)
starting point.

10 years agoCRM_Core_BAO_SettingTest - Fix setting leakage which breaks CRM_Core_BAO_SettingTest
Tim Otten [Thu, 28 Aug 2014 03:40:52 +0000 (20:40 -0700)]
CRM_Core_BAO_SettingTest - Fix setting leakage which breaks CRM_Core_BAO_SettingTest

A previous commit fixed the leak out of CRM_Case_BAO_CaseTest, but there appears to be more.
This fix tries to be more aggressive about setting a general baseline.

10 years agoRevert "CRM-14946 add relevant test data set"
Tim Otten [Thu, 28 Aug 2014 03:09:30 +0000 (20:09 -0700)]
Revert "CRM-14946 add relevant test data set"

After interviewing Eileen, Kurund, and Dave, it appears that 450a63c was a
draft that shouldn't have been merged.  The underlying question was how to
handle a change in the smart-group data-structure.  One approach (implicit
in 450a63c) was to maintain runtime compatibility.  Another approach (which
was ultimately chosen) was to define an upgrade that altered the
data-structure.

This fixes the failure in CRM_Contact_BAO_GroupTest::testGroupData.

This reverts commit 450a63cfc27064f2ffc141e76d4662fe612a67a5.