civicrm-core.git
11 months agoAdd 'getLinks' action to phpStorm extension
colemanw [Tue, 2 Jan 2024 14:02:25 +0000 (09:02 -0500)]
Add 'getLinks' action to phpStorm extension

11 months agoMerge pull request #28784 from mlutfy/floatLeftButton
Rich Lott [Tue, 2 Jan 2024 09:33:23 +0000 (09:33 +0000)]
Merge pull request #28784 from mlutfy/floatLeftButton

Merging as no objections

11 months agoMerge pull request #28826 from eileenmcnaughton/act_workflow
Eileen McNaughton [Tue, 2 Jan 2024 06:47:21 +0000 (19:47 +1300)]
Merge pull request #28826 from eileenmcnaughton/act_workflow

Use distinct test workflow message for workflow message tests

11 months agoDisable check temporily for PR juggling
eileen [Tue, 2 Jan 2024 05:13:22 +0000 (18:13 +1300)]
Disable check temporily for PR juggling

11 months agoMerge pull request #27973 from colemanw/getLinks
Eileen McNaughton [Tue, 2 Jan 2024 03:39:09 +0000 (16:39 +1300)]
Merge pull request #27973 from colemanw/getLinks

SearchKit - New getLinks API action for advanced link handling

11 months agoMerge pull request #28789 from eileenmcnaughton/message_template
colemanw [Tue, 2 Jan 2024 03:23:31 +0000 (22:23 -0500)]
Merge pull request #28789 from eileenmcnaughton/message_template

Update `MessageTemplates` generation to work with Smarty3

11 months agoUse distinct test workflow message for workflow message tests
eileen [Tue, 2 Jan 2024 03:10:58 +0000 (16:10 +1300)]
Use distinct test workflow message for workflow message tests

The tests for the workflow message subsystem use an instance of a test
case_activity template attached the real message workflow template. They
test the text version - meaning that removing it, like we have with
others, causes various fails. In addition adding a real template that
does not match the test version causes mayhem.

In this case we want to ensure we keep all the tests for the subsystem
functionality but undo the tethering to a particular
template to allow that template to have updates without
having to go deep into this code

11 months agoMerge pull request #28825 from eileenmcnaughton/no_ref
Eileen McNaughton [Tue, 2 Jan 2024 02:47:28 +0000 (15:47 +1300)]
Merge pull request #28825 from eileenmcnaughton/no_ref

Remove function use of reference

11 months agoMerge pull request #28822 from eileenmcnaughton/date_formats_test
colemanw [Tue, 2 Jan 2024 02:37:13 +0000 (21:37 -0500)]
Merge pull request #28822 from eileenmcnaughton/date_formats_test

Extend date formats being tested

11 months agoMerge pull request #28823 from eileenmcnaughton/date_const
colemanw [Tue, 2 Jan 2024 02:36:43 +0000 (21:36 -0500)]
Merge pull request #28823 from eileenmcnaughton/date_const

Use constants for date formats

11 months agoMerge pull request #28556 from eileenmcnaughton/trait_meta
colemanw [Tue, 2 Jan 2024 02:34:45 +0000 (21:34 -0500)]
Merge pull request #28556 from eileenmcnaughton/trait_meta

Fully deprecate MetadataTrait

11 months agoDeprecate passing in month
eileen [Tue, 2 Jan 2024 01:50:08 +0000 (14:50 +1300)]
Deprecate passing in month

11 months agoRemove pass-by-reference
eileen [Tue, 2 Jan 2024 01:36:54 +0000 (14:36 +1300)]
Remove pass-by-reference

We have removed a bunch of these (added for php4.x support) with no
issues - it's only where there is inheritance we have
hit issues

11 months agoUse constants for date formats
eileen [Mon, 1 Jan 2024 23:34:25 +0000 (12:34 +1300)]
Use constants for date formats

11 months agoExtend date formats to be tested
eileen [Mon, 1 Jan 2024 21:23:03 +0000 (10:23 +1300)]
Extend date formats to be tested

11 months agoMerge pull request #28821 from eileenmcnaughton/add
Eileen McNaughton [Mon, 1 Jan 2024 20:55:58 +0000 (09:55 +1300)]
Merge pull request #28821 from eileenmcnaughton/add

Fix error due to merges co-inciding

11 months agoFix error due to merges co-inciding
eileen [Mon, 1 Jan 2024 20:52:45 +0000 (09:52 +1300)]
Fix error due to merges co-inciding

11 months agoMerge pull request #28808 from colemanw/canAggregate
Eileen McNaughton [Mon, 1 Jan 2024 04:51:26 +0000 (17:51 +1300)]
Merge pull request #28808 from colemanw/canAggregate

SearchKit - Allow aggregate functions to be used without GroupBy

11 months agoMerge pull request #28818 from civicrm/5.69
Eileen McNaughton [Mon, 1 Jan 2024 03:15:06 +0000 (16:15 +1300)]
Merge pull request #28818 from civicrm/5.69

Merge forward (5.69-rc to master)

11 months agoMerge pull request #28718 from eileenmcnaughton/2_term
Tim Otten [Mon, 1 Jan 2024 02:08:50 +0000 (20:08 -0600)]
Merge pull request #28718 from eileenmcnaughton/2_term

dev/core#3810 dev/core#3339 Fix handling of auto renew memberships where frequency_interval > 1

11 months agoMerge pull request #28811 from colemanw/searchDisplayRemoveColFix
Eileen McNaughton [Mon, 1 Jan 2024 01:22:48 +0000 (14:22 +1300)]
Merge pull request #28811 from colemanw/searchDisplayRemoveColFix

SearchKit - Fix wrong column being removed from displays

11 months agoMerge pull request #28812 from colemanw/removeContactTypeField
Eileen McNaughton [Mon, 1 Jan 2024 00:29:42 +0000 (13:29 +1300)]
Merge pull request #28812 from colemanw/removeContactTypeField

APIv4 - Hide 'contact_type' from Individual,Organization,Household getFields

11 months agoMerge pull request #28783 from braders/php8-last-participant
Eileen McNaughton [Sun, 31 Dec 2023 23:59:14 +0000 (12:59 +1300)]
Merge pull request #28783 from braders/php8-last-participant

[REF][PHP8.2] Declare _lastParticipant property

11 months agoMerge pull request #28815 from braders/event-additional-particiapant-properties
Eileen McNaughton [Sun, 31 Dec 2023 23:58:53 +0000 (12:58 +1300)]
Merge pull request #28815 from braders/event-additional-particiapant-properties

[REF][PHP8.2] Declare missing properties on CRM_Event_Form_Registration_AdditionalParticipant

11 months agoMerge pull request #28775 from seamuslee001/dev_core_4841
colemanw [Sun, 31 Dec 2023 13:48:52 +0000 (08:48 -0500)]
Merge pull request #28775 from seamuslee001/dev_core_4841

dev/core#4841 Ensure that APIv4 have same default values which ensureā€¦

11 months agoMerge pull request #28816 from braders/php8-discounts
Seamus Lee [Sun, 31 Dec 2023 05:37:57 +0000 (16:37 +1100)]
Merge pull request #28816 from braders/php8-discounts

[REF][PHP8.2] Cleanup discounts property in eventcart ext

11 months agodev/core#4841 Ensure that APIv4 have same default values which ensures that all requi...
Seamus Lee [Fri, 22 Dec 2023 00:50:49 +0000 (11:50 +1100)]
dev/core#4841 Ensure that APIv4 have same default values which ensures that all required selects are filled out when creating new bulk mailing from Search Kit

Update as per coleman and fix Test fails

Fix calls to defaultComponent to fix test fails

11 months agoMerge pull request #28730 from eileenmcnaughton/recur_cancel_api_2
colemanw [Sat, 30 Dec 2023 22:45:43 +0000 (17:45 -0500)]
Merge pull request #28730 from eileenmcnaughton/recur_cancel_api_2

Stop bypassing hooks on ContributionRecur.cancel

11 months ago[REF][PHP8.2] Cleanup discounts property in eventcart ext
Bradley Taylor [Sat, 30 Dec 2023 20:16:42 +0000 (20:16 +0000)]
[REF][PHP8.2] Cleanup discounts property in eventcart ext

11 months ago[REF][PHP8.2] Declare missing properties on CRM_Event_Form_Registration_AdditionalPar...
Bradley Taylor [Sat, 30 Dec 2023 18:17:50 +0000 (18:17 +0000)]
[REF][PHP8.2] Declare missing properties on CRM_Event_Form_Registration_AdditionalParticipant

11 months agoAPIv4 - Remove 'contact_type' from Individual,Organization,Household
colemanw [Sat, 30 Dec 2023 15:58:44 +0000 (09:58 -0600)]
APIv4 - Remove 'contact_type' from Individual,Organization,Household

This field is irrelevant to these pseudo-entities and shouldn't need to be used at all.

Before: Creating a new SearchKit search for Individual includes Contact Type in the default columns.

After: Now it doesn't, and the field is completely hidden for all but the Contact entity.

11 months agoMerge pull request #28799 from eileenmcnaughton/date_consolidate
colemanw [Sat, 30 Dec 2023 16:16:44 +0000 (10:16 -0600)]
Merge pull request #28799 from eileenmcnaughton/date_consolidate

Consolidate import date handling

11 months agoMerge pull request #28753 from eileenmcnaughton/search_settings
colemanw [Sat, 30 Dec 2023 16:11:25 +0000 (10:11 -0600)]
Merge pull request #28753 from eileenmcnaughton/search_settings

Clean up search settings page, update group cache text

11 months agoMerge pull request #28748 from eileenmcnaughton/dep
colemanw [Sat, 30 Dec 2023 16:05:29 +0000 (10:05 -0600)]
Merge pull request #28748 from eileenmcnaughton/dep

Bubble up deprecation if getVar used to get a deprecated property

11 months agoMerge pull request #28814 from MegaphoneJon/anonymous-acl-cache
colemanw [Sat, 30 Dec 2023 03:06:37 +0000 (21:06 -0600)]
Merge pull request #28814 from MegaphoneJon/anonymous-acl-cache

Don't try to insert 0 as a user_id to ACL contact cache

11 months agoMerge pull request #28813 from colemanw/deletePhantomJsPolyfill
demeritcowboy [Fri, 29 Dec 2023 23:05:54 +0000 (18:05 -0500)]
Merge pull request #28813 from colemanw/deletePhantomJsPolyfill

Remove unused phantomjs-polyfill package

11 months agoRemove unused phantomjs-polyfill package
colemanw [Fri, 29 Dec 2023 21:00:05 +0000 (15:00 -0600)]
Remove unused phantomjs-polyfill package

As of 23051b6 we no longer use PhantomJS so this package should not be needed.

11 months agoDon't try to insert 0 as a user_id to ACL contact cache
Jon Goldberg [Fri, 29 Dec 2023 21:05:49 +0000 (16:05 -0500)]
Don't try to insert 0 as a user_id to ACL contact cache

11 months agoSearchKit - Fix wrong column being removed from displays
colemanw [Fri, 29 Dec 2023 20:24:32 +0000 (14:24 -0600)]
SearchKit - Fix wrong column being removed from displays

Fixes recent regression from 4099cd6 causing the wrong column to be removed from a display.
To reproduce: Create a search display, go back to the main search criteria and delete a column,
then tab back to the display. The deleted column should have been removed but instead the wrong
one is still there.

11 months agoMerge pull request #28776 from eileenmcnaughton/submit
Yashodha Chaku [Fri, 29 Dec 2023 17:22:46 +0000 (22:52 +0530)]
Merge pull request #28776 from eileenmcnaughton/submit

Remove api annotation from getSubmittableFields()

11 months agoMerge pull request #28809 from civicrm/5.69
Eileen McNaughton [Fri, 29 Dec 2023 03:44:16 +0000 (16:44 +1300)]
Merge pull request #28809 from civicrm/5.69

5.69 to master

11 months agoMerge pull request #28807 from alifrumin/5.69rn
Eileen McNaughton [Fri, 29 Dec 2023 03:43:50 +0000 (16:43 +1300)]
Merge pull request #28807 from alifrumin/5.69rn

[NFC] 5.69 Release Notes first pass

11 months agoSearchKit - Allow aggregate functions to be used without GroupBy
colemanw [Fri, 29 Dec 2023 03:19:52 +0000 (21:19 -0600)]
SearchKit - Allow aggregate functions to be used without GroupBy

Fixes https://lab.civicrm.org/dev/core/-/issues/2415

11 months agoMerge pull request #28804 from eileenmcnaughton/regen
demeritcowboy [Fri, 29 Dec 2023 00:28:13 +0000 (19:28 -0500)]
Merge pull request #28804 from eileenmcnaughton/regen

Update regen for event message template

11 months ago[NFC] 5.69 release notes first pass
Alice Frumin [Tue, 12 Dec 2023 19:33:06 +0000 (14:33 -0500)]
[NFC] 5.69 release notes first pass

11 months agoMerge pull request #28803 from eileenmcnaughton/notice
demeritcowboy [Thu, 28 Dec 2023 18:49:24 +0000 (13:49 -0500)]
Merge pull request #28803 from eileenmcnaughton/notice

E-notice fix in membership workflow examples

11 months agoMerge pull request #28798 from eileenmcnaughton/date_test
demeritcowboy [Thu, 28 Dec 2023 18:48:23 +0000 (13:48 -0500)]
Merge pull request #28798 from eileenmcnaughton/date_test

NFC Superficial cleanup in test class

11 months agoMerge pull request #28805 from eileenmcnaughton/code_notes
demeritcowboy [Thu, 28 Dec 2023 18:46:29 +0000 (13:46 -0500)]
Merge pull request #28805 from eileenmcnaughton/code_notes

[NFC] Add todos to the invoice code

11 months agoAdd todos to the invoice code
Eileen McNaughton [Wed, 13 Dec 2023 05:17:40 +0000 (18:17 +1300)]
Add todos to the invoice code

This helps clarify that most of this code is slated for removal
in order to make the forms non-form-dependent

11 months agoUpdate MessageTemplates generation to not use weird old methods
Eileen McNaughton [Sat, 23 Dec 2023 23:00:48 +0000 (12:00 +1300)]
Update MessageTemplates generation to not use weird old methods

11 months agoUpdate regen for event message template
Eileen McNaughton [Thu, 28 Dec 2023 05:15:42 +0000 (18:15 +1300)]
Update regen for event message template

11 months agoMerge pull request #28801 from eileenmcnaughton/fork/mapping-edit-button-fix
Eileen McNaughton [Thu, 28 Dec 2023 03:43:33 +0000 (16:43 +1300)]
Merge pull request #28801 from eileenmcnaughton/fork/mapping-edit-button-fix

Fix edit button for 'Import/Export Mapping'

11 months agoE-notice fix in membership workflow examples
eileen [Thu, 28 Dec 2023 03:13:32 +0000 (16:13 +1300)]
E-notice fix in membership workflow examples

11 months agoFix edit button for 'Import/Export Mapping'
19ATF72 [Wed, 6 Dec 2023 00:05:16 +0000 (16:05 -0800)]
Fix edit button for 'Import/Export Mapping'

11 months agoConsolidate import date handling
eileen [Thu, 28 Dec 2023 01:01:56 +0000 (14:01 +1300)]
Consolidate import date handling

11 months agoNFC Superficial cleanup in test class
eileen [Thu, 28 Dec 2023 00:02:57 +0000 (13:02 +1300)]
NFC Superficial cleanup in test class

11 months agoMerge pull request #28797 from eileenmcnaughton/nfc
demeritcowboy [Wed, 27 Dec 2023 23:11:19 +0000 (18:11 -0500)]
Merge pull request #28797 from eileenmcnaughton/nfc

[NFC] Superficial cleanup

11 months ago[NFC] Superficial cleanup
eileen [Wed, 27 Dec 2023 21:13:35 +0000 (10:13 +1300)]
[NFC] Superficial cleanup

11 months agoMerge pull request #28788 from eileenmcnaughton/assign
Yashodha Chaku [Wed, 27 Dec 2023 08:36:25 +0000 (14:06 +0530)]
Merge pull request #28788 from eileenmcnaughton/assign

Fix codeGen assign to do what it says on the box

11 months agoMerge pull request #28738 from mlutfy/maxSpin
colemanw [Wed, 27 Dec 2023 00:42:33 +0000 (19:42 -0500)]
Merge pull request #28738 from mlutfy/maxSpin

menubar spin: stop after 10 seconds

11 months agoMerge pull request #28794 from demeritcowboy/del
colemanw [Wed, 27 Dec 2023 00:40:57 +0000 (19:40 -0500)]
Merge pull request #28794 from demeritcowboy/del

update deleted files list

11 months agodeleted files list
demeritcowboy [Tue, 26 Dec 2023 16:06:53 +0000 (11:06 -0500)]
deleted files list

11 months agoMerge pull request #28793 from civicrm/5.69
demeritcowboy [Tue, 26 Dec 2023 16:52:27 +0000 (11:52 -0500)]
Merge pull request #28793 from civicrm/5.69

5.69

11 months agoMerge pull request #28781 from vingle/5.69-ux-regressions
demeritcowboy [Tue, 26 Dec 2023 16:03:41 +0000 (11:03 -0500)]
Merge pull request #28781 from vingle/5.69-ux-regressions

Fixes two small accordion UX regressions

11 months agoMerge pull request #28673 from bb/migrate-snappy-to-composer
demeritcowboy [Tue, 26 Dec 2023 15:58:57 +0000 (10:58 -0500)]
Merge pull request #28673 from bb/migrate-snappy-to-composer

Migrate Snappy to composer

11 months agoMerge pull request #28792 from civicrm/5.69
Eileen McNaughton [Tue, 26 Dec 2023 00:09:45 +0000 (13:09 +1300)]
Merge pull request #28792 from civicrm/5.69

5.69 to master

11 months agoMerge pull request #28791 from eileenmcnaughton/569
Eileen McNaughton [Tue, 26 Dec 2023 00:08:42 +0000 (13:08 +1300)]
Merge pull request #28791 from eileenmcnaughton/569

Fix typo in smarty compatibility class

11 months agoMerge pull request #28782 from mlutfy/extList
colemanw [Mon, 25 Dec 2023 00:30:57 +0000 (19:30 -0500)]
Merge pull request #28782 from mlutfy/extList

Manage Extensions: hide the type/module column

11 months agoManage Extensions: hide the type/module column
Mathieu Lu [Fri, 22 Dec 2023 19:45:47 +0000 (14:45 -0500)]
Manage Extensions: hide the type/module column

11 months agoFix typo in smarty compatibility class
Eileen McNaughton [Sun, 24 Dec 2023 04:21:14 +0000 (17:21 +1300)]
Fix typo in smarty compatibility class

11 months agoMerge pull request #28790 from eileenmcnaughton/str_contains
demeritcowboy [Sun, 24 Dec 2023 03:18:55 +0000 (22:18 -0500)]
Merge pull request #28790 from eileenmcnaughton/str_contains

Remove str_contains from civicrm.settings template

11 months agoSearchKit - Show multiple 'create' links in toolbar
colemanw [Fri, 22 Dec 2023 16:36:01 +0000 (11:36 -0500)]
SearchKit - Show multiple 'create' links in toolbar

11 months agoMerge pull request #28787 from eileenmcnaughton/get_template_vars
colemanw [Sun, 24 Dec 2023 00:41:05 +0000 (19:41 -0500)]
Merge pull request #28787 from eileenmcnaughton/get_template_vars

Standardise `getTemplateVars()`

11 months agoAPIv4 - Fix getLinks permission checks
colemanw [Thu, 21 Dec 2023 03:29:23 +0000 (22:29 -0500)]
APIv4 - Fix getLinks permission checks

The getLinks action checks all permissions internally, so should not have any
external gatekeeper checks applied.

11 months agoSearchKit - Use getLinks api in formatLink
colemanw [Thu, 21 Dec 2023 02:55:34 +0000 (21:55 -0500)]
SearchKit - Use getLinks api in formatLink

11 months agoSearchKit - Preprocess links only once; use api getLinks action
colemanw [Tue, 19 Dec 2023 15:33:41 +0000 (10:33 -0500)]
SearchKit - Preprocess links only once; use api getLinks action

Before: Links were being preprocessed by the getLinkInfo() function once-per-link-per-row.

After: Links preprocessed once-per-link. New API action used.

11 months agoAPIv4 - Alter activity links for CiviCase
colemanw [Tue, 28 Nov 2023 03:01:35 +0000 (22:01 -0500)]
APIv4 - Alter activity links for CiviCase

Activities that belong to a case use a differently-structured url.
This adds a handler for it and moves it more appropriately into the
civi_case extension.

11 months agoAPIv4 - Make Activity::getLinks return multiple add links per activity type
colemanw [Mon, 27 Nov 2023 14:37:22 +0000 (09:37 -0500)]
APIv4 - Make Activity::getLinks return multiple add links per activity type

11 months agoSearchKit - Use getLinks API action
colemanw [Tue, 31 Oct 2023 11:57:22 +0000 (07:57 -0400)]
SearchKit - Use getLinks API action

11 months agoAPIv4 - Add getLinks action to CustomValue API
colemanw [Mon, 30 Oct 2023 22:05:34 +0000 (18:05 -0400)]
APIv4 - Add getLinks action to CustomValue API

11 months agoAPIv4 - Add getLinks action
colemanw [Mon, 30 Oct 2023 14:32:40 +0000 (10:32 -0400)]
APIv4 - Add getLinks action

11 months agoRemove str_contains from civicrm.settings template
Eileen McNaughton [Sat, 23 Dec 2023 23:44:27 +0000 (12:44 +1300)]
Remove str_contains from civicrm.settings template

11 months agoFix codeGen assign to do what it says on the box
Eileen McNaughton [Sat, 23 Dec 2023 21:07:22 +0000 (10:07 +1300)]
Fix codeGen assign to do what it says on the box

11 months agoStandardise getTemplateVars()
Eileen McNaughton [Sat, 23 Dec 2023 20:55:43 +0000 (09:55 +1300)]
Standardise getTemplateVars()

11 months agoMerge pull request #28785 from MegaphoneJon/delete-grant-false-error
Eileen McNaughton [Sat, 23 Dec 2023 00:58:55 +0000 (13:58 +1300)]
Merge pull request #28785 from MegaphoneJon/delete-grant-false-error

remove incorrect message that grant could not be deleted

11 months agoremove incorrect message that grant could not be deleted
Jon Goldberg [Fri, 22 Dec 2023 23:15:52 +0000 (18:15 -0500)]
remove incorrect message that grant could not be deleted

11 months agoMerge pull request #28780 from eileenmcnaughton/mut
colemanw [Fri, 22 Dec 2023 21:54:45 +0000 (16:54 -0500)]
Merge pull request #28780 from eileenmcnaughton/mut

Compiance with php8 & Marvel9

11 months agocivicrm.css: replace button float:left by inline-block
Mathieu Lu [Fri, 22 Dec 2023 20:41:12 +0000 (15:41 -0500)]
civicrm.css: replace button float:left by inline-block

11 months ago[REF][PHP8.2] Declare _lastParticipant property
Bradley Taylor [Fri, 22 Dec 2023 20:26:05 +0000 (20:26 +0000)]
[REF][PHP8.2] Declare _lastParticipant property

11 months agoCompiance with php8 & Marvel9
Eileen McNaughton [Fri, 22 Dec 2023 10:33:27 +0000 (23:33 +1300)]
Compiance with php8 & Marvel9

11 months agoMerge pull request #28771 from eileenmcnaughton/blt_cms
colemanw [Fri, 22 Dec 2023 16:11:01 +0000 (11:11 -0500)]
Merge pull request #28771 from eileenmcnaughton/blt_cms

Remove checks to bltID in cms classes

11 months agoMerge pull request #28770 from eileenmcnaughton/blt
colemanw [Fri, 22 Dec 2023 16:06:18 +0000 (11:06 -0500)]
Merge pull request #28770 from eileenmcnaughton/blt

Stop referring to `_bltID` in AbstractEditPayment

11 months agoAdds support for fieldset
Nicol [Fri, 22 Dec 2023 13:07:48 +0000 (14:07 +0100)]
Adds support for fieldset

In this commit: https://github.com/civicrm/civicrm-core/commit/1602ec3e104de40e7bd785496f0cde323fe870ed the `display: none` was narrowed to only target divs with the class '.collapsed'. This excluded a few examples of fieldsets being used (as identified in ThemeTest, Accordion 4 - https://lab.civicrm.org/extensions/themetest/-/blob/main/ang/themetest/snippets/accordion4.html)

11 months agoKeeps search criteria fieldset closed when results found
Nicol [Fri, 22 Dec 2023 12:58:07 +0000 (13:58 +0100)]
Keeps search criteria fieldset closed when results found

Fixes search regression introduced in #28421 and identified in #28661.

11 months agoMerge pull request #28760 from eileenmcnaughton/case_dec
demeritcowboy [Fri, 22 Dec 2023 03:24:56 +0000 (22:24 -0500)]
Merge pull request #28760 from eileenmcnaughton/case_dec

Declare caseId, caseIds as public properties

11 months agoMerge pull request #28773 from eileenmcnaughton/cart_82
colemanw [Fri, 22 Dec 2023 02:53:08 +0000 (21:53 -0500)]
Merge pull request #28773 from eileenmcnaughton/cart_82

[PHP8.2] Fix test fails on event cart

11 months agoRemove api annotation from getSubmittableFields()
Eileen McNaughton [Fri, 22 Dec 2023 01:57:44 +0000 (14:57 +1300)]
Remove api annotation from getSubmittableFields()

This should either be public or api-supported. Perhaps it should be public/api but
at least for now I will resolve by removing the annotation

11 months ago[PHP8.2] Fix test fails on event cart
Eileen McNaughton [Thu, 21 Dec 2023 23:38:15 +0000 (12:38 +1300)]
[PHP8.2] Fix test fails on event cart

11 months agoStop referring to _bltID in AbstractEditPayment
Eileen McNaughton [Thu, 21 Dec 2023 23:20:17 +0000 (12:20 +1300)]
Stop referring to _bltID in AbstractEditPayment

11 months agoMerge pull request #28758 from braders/php8-smsCommonTest
Eileen McNaughton [Thu, 21 Dec 2023 23:28:12 +0000 (12:28 +1300)]
Merge pull request #28758 from braders/php8-smsCommonTest

[REF][PHP8.2] Use correct form object to ensure properties exist