Seamus Lee [Thu, 4 Jun 2020 23:46:18 +0000 (09:46 +1000)]
Merge pull request #17473 from eileenmcnaughton/anet
Convert remaining Authorize.net test to use guzzle
Seamus Lee [Thu, 4 Jun 2020 23:23:24 +0000 (09:23 +1000)]
Merge pull request #17494 from pradpnayak/reminderSetdefault
set boolean fields to false if not set.
Seamus Lee [Thu, 4 Jun 2020 22:52:11 +0000 (08:52 +1000)]
Merge pull request #17490 from eileenmcnaughton/pending
[Ref] remove calls to, and deprecate, pending function
Eileen McNaughton [Thu, 4 Jun 2020 21:46:45 +0000 (09:46 +1200)]
Merge pull request #17426 from mattwire/recaptcha
Make reCAPTCHA settings clearer
Seamus Lee [Thu, 4 Jun 2020 21:14:30 +0000 (07:14 +1000)]
Merge pull request #17492 from eileenmcnaughton/search
[NFC] Fix use of single quotes, strict operator
Seamus Lee [Thu, 4 Jun 2020 21:14:04 +0000 (07:14 +1000)]
Merge pull request #17488 from eileenmcnaughton/memtype
Test fixes to support apiv4 add of MembershipType
colemanw [Thu, 4 Jun 2020 11:59:28 +0000 (07:59 -0400)]
Merge pull request #17493 from pradpnayak/tinyintFixes
dev/core/-/issues/1794, changed int to tinyint for boolean fields
Pradeep Nayak [Thu, 4 Jun 2020 10:15:15 +0000 (11:15 +0100)]
set boolean fields to false if not set.
Pradeep Nayak [Thu, 4 Jun 2020 09:47:34 +0000 (10:47 +0100)]
dev/core/-/issues/1794, changed int to tinyint for boolean fields
eileen [Thu, 4 Jun 2020 07:00:54 +0000 (19:00 +1200)]
[Ref] remove calls to, and deprecate, pending function
eileen [Thu, 4 Jun 2020 06:41:45 +0000 (18:41 +1200)]
Test fixes to support apiv4 add of MembershipType
eileen [Tue, 2 Jun 2020 21:37:28 +0000 (09:37 +1200)]
Convert remaining Authorize.net test to use guzzle
This allows us to remove the handling for when a.net doesn't reply
Seamus Lee [Thu, 4 Jun 2020 05:01:15 +0000 (15:01 +1000)]
Merge pull request #17486 from seamuslee001/master
5.26
Seamus Lee [Thu, 4 Jun 2020 05:00:16 +0000 (15:00 +1000)]
Merge in 5.26
Tim Otten [Thu, 4 Jun 2020 04:58:04 +0000 (21:58 -0700)]
Merge pull request #17485 from totten/5.26-misc
5.26.0 - Small edits
Tim Otten [Thu, 4 Jun 2020 04:47:13 +0000 (21:47 -0700)]
Set version to 5.26.0
Tim Otten [Thu, 4 Jun 2020 04:46:48 +0000 (21:46 -0700)]
release-notes/5.26.0 - Copy-edits
Seamus Lee [Thu, 4 Jun 2020 04:06:04 +0000 (14:06 +1000)]
Merge pull request #17484 from civicrm/5.26
5.26
Seamus Lee [Thu, 4 Jun 2020 02:26:15 +0000 (12:26 +1000)]
Merge pull request #17483 from agh1/5.26.0-release-notes-final
5.26.0 release notes final
Eileen McNaughton [Thu, 4 Jun 2020 01:02:16 +0000 (13:02 +1200)]
Merge pull request #17482 from colemanw/orderBySuffix
APIv4 - Support pseudoconstant suffixes in orderBy clause
Seamus Lee [Thu, 4 Jun 2020 00:39:32 +0000 (10:39 +1000)]
Merge pull request #17481 from eileenmcnaughton/email
[REF] Extract createFollowUpActivities
Andrew Hunt [Wed, 3 Jun 2020 23:51:13 +0000 (19:51 -0400)]
5.26.0 release notes: some final edits
Coleman Watts [Wed, 3 Jun 2020 23:09:34 +0000 (19:09 -0400)]
APIv4 - Support pseudoconstant suffixes in orderBy clause
Seamus Lee [Wed, 3 Jun 2020 23:00:26 +0000 (09:00 +1000)]
Merge pull request #17476 from civicrm/5.26
5.26
Andrew Hunt [Wed, 3 Jun 2020 00:29:30 +0000 (20:29 -0400)]
5.26.0 release notes: added late changes
Seamus Lee [Wed, 3 Jun 2020 21:18:24 +0000 (07:18 +1000)]
Merge pull request #17478 from seamuslee001/document_recent_merge_wordpress_notice
Document recent merge in regards to select fields for export screen a…
Eileen McNaughton [Wed, 3 Jun 2020 21:16:07 +0000 (09:16 +1200)]
Merge pull request #17470 from colemanw/array
NFC - Change array() to short syntax []
eileen [Tue, 26 May 2020 03:48:30 +0000 (15:48 +1200)]
[REF] Extract createFollowUpActivities
Tim Otten [Wed, 3 Jun 2020 19:21:40 +0000 (12:21 -0700)]
Update 5.26.0.md
Matthew Wire [Wed, 3 Jun 2020 09:02:03 +0000 (10:02 +0100)]
Merge pull request #17474 from eileenmcnaughton/processor_name
Remove last reference to Payment->_processorName in core & remove from processors
Matthew Wire [Wed, 3 Jun 2020 09:00:39 +0000 (10:00 +0100)]
Merge pull request #17468 from mattwire/removesingleton
Remove unused singleton from core payment processors
Tim Otten [Wed, 3 Jun 2020 07:05:24 +0000 (00:05 -0700)]
Update 5.26.0.md
Tim Otten [Wed, 3 Jun 2020 07:01:30 +0000 (00:01 -0700)]
Update 5.26.0.md
Seamus Lee [Wed, 3 Jun 2020 04:27:01 +0000 (14:27 +1000)]
Document recent merge in regards to select fields for export screen and add in the notice about WordPress compatability issue
Seamus Lee [Wed, 3 Jun 2020 04:19:34 +0000 (14:19 +1000)]
Merge pull request #17444 from seamuslee001/deb_core_1725
dev/core#1725 Remove groups, tags and notes from the returned data fo…
colemanw [Wed, 3 Jun 2020 00:57:35 +0000 (20:57 -0400)]
Merge pull request #17442 from eileenmcnaughton/email3
[REF] Switch to an api call to get the contact details.
Seamus Lee [Wed, 3 Jun 2020 00:51:06 +0000 (10:51 +1000)]
Merge pull request #17446 from Edzelopez/fix-hideshow-receivedate
Fixed hide show of start date
Seamus Lee [Wed, 3 Jun 2020 00:50:44 +0000 (10:50 +1000)]
Merge pull request #17464 from eileenmcnaughton/renew
[REF] Remove never-passed params from function signature
Eileen McNaughton [Tue, 2 Jun 2020 23:58:19 +0000 (11:58 +1200)]
Merge pull request #17447 from mattwire/repeattransactiondisablerecur
Don't allow Contribution.repeattransaction to be used without a recurring contribution
Eileen McNaughton [Tue, 2 Jun 2020 23:49:04 +0000 (11:49 +1200)]
Merge pull request #17471 from colemanw/customSpec
APIv4 - Improve custom field spec gathering
Seamus Lee [Mon, 1 Jun 2020 08:39:43 +0000 (18:39 +1000)]
dev/core#1725 Remove groups, tags and notes from the returned data for the usage in preview data to speed up loading of the select fields screen
Seamus Lee [Tue, 2 Jun 2020 22:48:48 +0000 (08:48 +1000)]
Merge pull request #17472 from alifrumin/rn-5.26
Annotated 5.26 release notes
eileen [Tue, 2 Jun 2020 21:47:47 +0000 (09:47 +1200)]
Remove last reference to Payment->_processorName in core & remove from processors
I left it on Core_Payment to keep the deprecation notice visible
Alice Frumin [Tue, 2 Jun 2020 02:16:34 +0000 (22:16 -0400)]
release-notes 5.26: annotating release notes
Eileen McNaughton [Tue, 2 Jun 2020 20:43:11 +0000 (08:43 +1200)]
Merge pull request #17469 from colemanw/memberTypeTest
[REF] Fix serialized membership field handling in RelationshipTest
Coleman Watts [Tue, 2 Jun 2020 15:13:56 +0000 (11:13 -0400)]
APIv4 - Improve custom field spec gathering
Uses the basicTypes() function instead of hard-coding contact types,
Includes all the weird variants of Participant.
Coleman Watts [Tue, 2 Jun 2020 14:42:55 +0000 (10:42 -0400)]
NFC - Change array() to short syntax []
Coleman Watts [Tue, 2 Jun 2020 14:16:03 +0000 (10:16 -0400)]
Fix serialized membership field handling in RelationshipTest
These fields were being unnecessarily and incorrectly serialized by the test.
Passing an array is preferred and it will handle the serialization correctly.
colemanw [Tue, 2 Jun 2020 14:06:55 +0000 (10:06 -0400)]
Merge pull request #17372 from eileenmcnaughton/opts
Add more search options
colemanw [Tue, 2 Jun 2020 14:05:10 +0000 (10:05 -0400)]
Merge pull request #17413 from scoobird/assign_relationship_1287
Allow bidirectional assignment of relationships from search results
Matthew Wire [Tue, 2 Jun 2020 13:55:35 +0000 (14:55 +0100)]
Remove unused singleton from core payment processors
Seamus Lee [Tue, 2 Jun 2020 13:38:00 +0000 (23:38 +1000)]
Merge pull request #17467 from civicrm/5.26
5.26
Seamus Lee [Tue, 2 Jun 2020 13:28:06 +0000 (23:28 +1000)]
Merge pull request #17466 from mattwire/subscriptiondetail
Add actual field name for processor_id to getSubscriptionDetails
Seamus Lee [Tue, 2 Jun 2020 13:26:10 +0000 (23:26 +1000)]
Merge pull request #17465 from seamuslee001/upgrde_required_fields
[REF] Implement required fields database changes that have occured du…
Yashodha Chaku [Tue, 2 Jun 2020 11:46:37 +0000 (17:16 +0530)]
Merge pull request #17462 from eileenmcnaughton/526ex
dev/core#1780 Fix bug where non-household merge contacts were being skipped
Seamus Lee [Tue, 2 Jun 2020 11:08:23 +0000 (21:08 +1000)]
Merge pull request #17424 from kcristiano/5.26.upgrade-message
Add Upgrade Warning. Limit to WP Only.
Seamus Lee [Tue, 2 Jun 2020 09:31:56 +0000 (19:31 +1000)]
[REF] Implement required fields database changes that have occured during 5.27.alpha1 development cycle
Matthew Wire [Tue, 2 Jun 2020 09:45:44 +0000 (10:45 +0100)]
Add actual field name for processor_id to getSubscriptionDetails
Kevin Cristiano [Mon, 1 Jun 2020 17:44:38 +0000 (13:44 -0400)]
get link to Blog Post
Kevin Cristiano [Fri, 29 May 2020 18:31:32 +0000 (14:31 -0400)]
Add PostUpgrade Message
Signed-off-by: Kevin Cristiano <kcristiano@kcristiano.com>
Kevin Cristiano [Fri, 29 May 2020 14:26:39 +0000 (10:26 -0400)]
Add Upgrade Warning. Limit to WP Only.
Signed-off-by: Kevin Cristiano <kcristiano@kcristiano.com>
eileen [Tue, 2 Jun 2020 07:53:40 +0000 (19:53 +1200)]
[REF] Remove never-passed params from function signature
These params were used when the code was shared with other forms, but not now it is been
separated onto this form
Seamus Lee [Tue, 2 Jun 2020 06:03:25 +0000 (16:03 +1000)]
Merge pull request #17443 from eileenmcnaughton/renew
[REF] Minor simplification
eileen [Thu, 28 May 2020 21:45:44 +0000 (09:45 +1200)]
Add more search fields for contacts - city, postal_code, street_address
eileen [Thu, 21 May 2020 03:38:34 +0000 (15:38 +1200)]
Add more search options
This adds more fields to the filters on search for individual
- organization_name (Employer Name)
- first_name
- nick_name
- last_name
Note
1) organization_name is populated for individuals with employers - it's handy to be able
to filter by as a quick way to narrow down. I wasn't too worried about declaring it only
for individuals as sort_name covers this for organizations
2) Last name these feels a bit unnecessary as it co-incides with sort_name
but it also feels odd not to add it
3) Ideally for these text fields they would be always or optionally 'like' searches
(respecting the site +wildcard setting). I took a a quick look but decided to leave it
out of scope at this stage.
4) I thought 'email' might have been useful too but given 3 & the fact that the main use I saw
was as a proxy for 1 (employer) and that email is the preferred search for email anyway (
which was the entity I was working on) I excluded it too in the end.
The use case for this is narrowing down in a large database. Take finding Johnathan Smith.
Being able to add 'Johnathan' as a filter helps get past all the Johns quicker.
Lastly - I have a sneaky feeling that users in our org will abuse the nick name filter heavily &
add nicknames to all contacts they frequently email....
Eileen McNaughton [Tue, 2 Jun 2020 05:55:34 +0000 (17:55 +1200)]
Merge pull request #17430 from mattwire/eileenmcnaughton-cancel
Nuance cancel options for processors
Eileen McNaughton [Tue, 2 Jun 2020 05:52:47 +0000 (17:52 +1200)]
Merge pull request #17298 from demeritcowboy/activity-attachment-delete
dev/core#1753 - Attachments aren't deleted when deleting activity
Edsel Lopez [Tue, 2 Jun 2020 05:25:49 +0000 (10:55 +0530)]
Fixed false condition
Seamus Lee [Tue, 2 Jun 2020 04:43:47 +0000 (14:43 +1000)]
Merge pull request #17460 from seamuslee001/pear_log_version_bump
[REF] Bump Pear Log version to fix compatability with Drupal 8 / Drup…
Seamus Lee [Tue, 2 Jun 2020 04:33:37 +0000 (14:33 +1000)]
Merge pull request #17463 from eileenmcnaughton/memtype
Update MembershipType.name to be a required field
Morgan [Wed, 27 May 2020 21:48:57 +0000 (17:48 -0400)]
Allow bidirectional assignment of relationships from search results
eileen [Tue, 2 Jun 2020 01:36:24 +0000 (13:36 +1200)]
Update MembershipType.name to be a required field
Seamus Lee [Tue, 2 Jun 2020 00:43:12 +0000 (10:43 +1000)]
[REF] Bump Pear Log version to fix compatability with Drupal 8 / Drupal 9
eileen [Tue, 2 Jun 2020 01:18:29 +0000 (13:18 +1200)]
dev/core#1780 Fix bug where non-household merge contacts were being skipped
Eileen McNaughton [Tue, 2 Jun 2020 00:41:20 +0000 (12:41 +1200)]
Merge pull request #17459 from civicrm/5.26
5.26 to master
Seamus Lee [Tue, 2 Jun 2020 00:27:38 +0000 (10:27 +1000)]
Merge pull request #17438 from eileenmcnaughton/cust
dev/core#1747 don't drop temp tables on class destruct.
Eileen McNaughton [Tue, 2 Jun 2020 00:03:36 +0000 (12:03 +1200)]
Merge pull request #17457 from agh1/5.26.0-release-notes-initial
5.26.0 release notes initial run
Seamus Lee [Mon, 1 Jun 2020 23:16:05 +0000 (09:16 +1000)]
Merge pull request #17449 from eileenmcnaughton/guzzle
[REF] Convert one of the http calls in Authorize.net class to use guzzle.
Andrew Hunt [Mon, 1 Jun 2020 21:31:24 +0000 (17:31 -0400)]
5.26.0 release notes: added boilerplate
Andrew Hunt [Mon, 1 Jun 2020 20:23:24 +0000 (16:23 -0400)]
5.26.0 release notes: raw from script
eileen [Mon, 1 Jun 2020 12:09:45 +0000 (00:09 +1200)]
[REF] Convert one of the http calls in Authorize.net class to use guzzle.
This achieves the following
1) addresses a cause of intermittent test failures
2) starts the process of modelling how payment processors should be written in a best-practice, tested way in core
3) stops us interacting with A.net during tests
4) starts to reduce curl dependency
Matthew Wire [Sat, 30 May 2020 11:10:59 +0000 (12:10 +0100)]
Make reCAPTCHA settings clearer
Matthew Wire [Mon, 1 Jun 2020 17:00:31 +0000 (18:00 +0100)]
Merge pull request #17451 from mlutfy/navNewSubType
Navigation menu: fix translation of new-subtype entries
Matthew Wire [Mon, 1 Jun 2020 10:13:06 +0000 (11:13 +0100)]
Don't allow Contribution.repeattransaction to be used without a recurring contribution
Mathieu Lutfy [Mon, 1 Jun 2020 12:34:06 +0000 (08:34 -0400)]
Navigation menu: fix translation of new-subtype entries.
Edsel Lopez [Mon, 1 Jun 2020 10:15:44 +0000 (15:45 +0530)]
Fixed hide show of start date
Matthew Wire [Sat, 30 May 2020 17:19:04 +0000 (18:19 +0100)]
Don't set isNotifyProcessorOnCancelRecur if it has not been set - this allows the payment processor to know if the user made a choice or not independently of supportsCancelRecurringNotifyOptional
eileen [Wed, 22 Apr 2020 23:08:05 +0000 (11:08 +1200)]
Nuance cancel options for processors.
This PR addresses an issue where we have insufficient nuance on processor capabilities for cancel.
There are 2 behaviours that we are trying to support with one capability
1) can this processor cope with us cancelling a recurring donation within CiviCRM
2) should we present the option of whether to or not to a user. This option is appropriate
when the processor manages the schedule (e.g Paypal) as the user may just be updating Civi to
match reality. However, for token driven processors it generally doesnt' apply.
This PR adds a new overridable capability - 'supportsOptionalCancelRecurring' which is the same as
supportsCancelRecurring by default. For the manual processor it is FALSE.
Call cancelRecurring for all cancels.
In almost all cases this will be no change as processors would have to implement the new-ish
doCancelRecurring themselves to have any change
Seamus Lee [Mon, 1 Jun 2020 09:08:00 +0000 (19:08 +1000)]
Merge pull request #17425 from colemanw/customLinks
APIv4 - Fix entity name on custom groups in schemaMapper
eileen [Mon, 1 Jun 2020 06:50:07 +0000 (18:50 +1200)]
[REF] Minor simplification
This code used to be shared with other functions. No longer, so we only need to return what is returned for
this form
Seamus Lee [Mon, 1 Jun 2020 06:46:20 +0000 (16:46 +1000)]
Merge pull request #17441 from eileenmcnaughton/email2
[REF] Simplify contributionIDs code
Eileen McNaughton [Mon, 1 Jun 2020 06:45:02 +0000 (18:45 +1200)]
Merge pull request #17439 from seamuslee001/karma_upgrade_162020
[NFC] Update Karma to be latest version
Coleman Watts [Fri, 29 May 2020 18:32:45 +0000 (14:32 -0400)]
APIv4 - Fix entity name on custom groups in schemaMapper
Only multi-record groups are considered an api "entity", so for other groups the entity should be null.
Yashodha Chaku [Mon, 1 Jun 2020 04:38:14 +0000 (10:08 +0530)]
Merge pull request #17436 from eileenmcnaughton/email
[REF] Simplify subject code.
eileen [Tue, 26 May 2020 04:37:27 +0000 (16:37 +1200)]
Switch to an api call to get the contact details.
It's much clearer that it's just a basic get. Using v4 means I have to param wrangle so I stuck with
v3 for now (i.e if I switch to Email.get which I think I need to for v4 since Primary.email is
not a v4 search param I wind up with prefixes on the keys
eileen [Tue, 26 May 2020 03:01:00 +0000 (15:01 +1200)]
[REF] Simplify contributionIDs code
Seamus Lee [Mon, 1 Jun 2020 01:07:12 +0000 (11:07 +1000)]
Merge pull request #17435 from seamuslee001/dev_membership_24_revert
Revert Matt's fix for dev/membership#24 as it is incomplete and add a…
Seamus Lee [Mon, 1 Jun 2020 00:56:23 +0000 (10:56 +1000)]
[NFC] Update Karma to be latest version
Seamus Lee [Mon, 1 Jun 2020 00:09:34 +0000 (10:09 +1000)]
Merge pull request #17420 from seamuslee001/request_guzzle
[REF] Refactor to switch from pear HTTP Request class to using Guzzle
Seamus Lee [Mon, 1 Jun 2020 00:02:23 +0000 (10:02 +1000)]
Merge pull request #17437 from demeritcowboy/tests-for-deleterestore
[NFC/TEST] dev/core#1784 - Unit tests for contact delete/restore