larssandergreen [Wed, 5 Jul 2023 20:23:14 +0000 (14:23 -0600)]
check if existing contact employer matches profile employer
colemanw [Mon, 3 Jul 2023 19:46:30 +0000 (12:46 -0700)]
Merge pull request #26505 from larssandergreen/PHP-warning-on-Contribution
Reduce PHP warnings with paymentBlock
colemanw [Mon, 3 Jul 2023 19:31:58 +0000 (12:31 -0700)]
Merge pull request #26709 from eileenmcnaughton/price_fee
Fix ChangeFeeSelectionTest to use eventCreatePaid
Eileen McNaughton [Mon, 3 Jul 2023 19:31:25 +0000 (12:31 -0700)]
Merge pull request #26710 from colemanw/customType
APIv4 - Add more metadata to CustomValue entities; use AutoService
Eileen McNaughton [Mon, 3 Jul 2023 19:30:21 +0000 (12:30 -0700)]
Merge pull request #26714 from colemanw/codeFixes
[REF] Code cleanup; remove unused vars and remove CRM_Utils_Array::value
Eileen McNaughton [Mon, 3 Jul 2023 19:25:03 +0000 (12:25 -0700)]
Merge pull request #26712 from larssandergreen/Install-SK-on-headless-tests
Install SK as part of headless test baseline
colemanw [Mon, 3 Jul 2023 18:34:29 +0000 (14:34 -0400)]
Code cleanup; remove unused vars and remove CRM_Utils_Array::value
larssandergreen [Mon, 3 Jul 2023 18:14:54 +0000 (12:14 -0600)]
Install SK as part of headless test baseline
demeritcowboy [Mon, 3 Jul 2023 17:43:27 +0000 (13:43 -0400)]
Merge pull request #26696 from mlutfy/cleanupTmpTables
clearTempTables: fix condition for user_job check
colemanw [Mon, 3 Jul 2023 17:10:44 +0000 (10:10 -0700)]
Merge pull request #26713 from reflexive-communications/unsubscribe-properties
CRM_Mailing_Form_Optout, CRM_Mailing_Form_Unsubscribe: change properties to protected from private
colemanw [Mon, 3 Jul 2023 15:38:36 +0000 (08:38 -0700)]
Merge pull request #26711 from larssandergreen/Don't-show-SQL-text-in-SK-if-the-user-doesn't-have-permission
Don't show SQL text in SK if user does not have view debug permission
colemanw [Mon, 3 Jul 2023 13:53:05 +0000 (09:53 -0400)]
APIv4 - Add more metadata to CustomValue entities; use AutoService
There are several places in SearchKit code that check an entity 'type' to see if it contains 'DAOEntity'; they all seem designed
to test if the query will go through (so does it support joins, etc?) and custom entities were getting overlooked.
While I was at it I switch to our new standard 'AutoService' style of event listener
Sandor Semsey [Mon, 3 Jul 2023 14:33:02 +0000 (16:33 +0200)]
make properties protected to get accessed by CRM_Core_Form::getVar()
Aidan Saunders [Mon, 3 Jul 2023 10:18:43 +0000 (11:18 +0100)]
Merge pull request #26698 from colemanw/customJoin
SearchKit - Allow custom fields in join conditions
Eileen McNaughton [Mon, 3 Jul 2023 06:53:12 +0000 (18:53 +1200)]
Fix ChangeFeeSelectionTest to use eventCreatePaid
Seamus Lee [Mon, 3 Jul 2023 05:40:38 +0000 (01:40 -0400)]
Merge pull request #26708 from eileenmcnaughton/part_create
Use eventCreateUnpaid in participantCreate
Eileen McNaughton [Mon, 3 Jul 2023 04:11:35 +0000 (16:11 +1200)]
Use eventCreateUnpaid in participantCreate
Eileen McNaughton [Mon, 3 Jul 2023 04:51:39 +0000 (21:51 -0700)]
Merge pull request #26707 from eileenmcnaughton/event_change
Fix ACLPermissionTrait to use EventTest create function
larssandergreen [Mon, 3 Jul 2023 04:41:36 +0000 (22:41 -0600)]
Don't show SQL text in SK if user does not have view debug permission
Eileen McNaughton [Mon, 3 Jul 2023 03:40:24 +0000 (15:40 +1200)]
Fix ACLPermissionTrait to use EventTest create function
Cleanup in related classes
Seamus Lee [Mon, 3 Jul 2023 03:42:40 +0000 (23:42 -0400)]
Merge pull request #26706 from civicrm/5.63
5.63
Seamus Lee [Mon, 3 Jul 2023 03:01:34 +0000 (23:01 -0400)]
Merge pull request #26695 from alifrumin/rn5.63
[NFC] First pass at 5.63 release notes
Seamus Lee [Mon, 3 Jul 2023 02:59:30 +0000 (22:59 -0400)]
Merge pull request #26703 from larssandergreen/Give-webtest-user-permission-to-view-debug
Allow Drupal webstest user to view debug output
Seamus Lee [Mon, 3 Jul 2023 02:59:12 +0000 (22:59 -0400)]
Merge pull request #26702 from larssandergreen/Fix-debug-permissions-issue-in-API4
Fix debug permissions for API 4 Explorer debug
Eileen McNaughton [Mon, 3 Jul 2023 02:57:53 +0000 (19:57 -0700)]
Merge pull request #26704 from eileenmcnaughton/event_t
Test cleanup in BAO_ParticipantTest
Eileen McNaughton [Mon, 3 Jul 2023 02:05:39 +0000 (14:05 +1200)]
Test cleanup in BAO_ParticipantTest
Fixes to use the trait. Also simplifies the fixEventLevel test
- the fixEventLevel function has a lot of set up with
some legacy function calls. However, the set up is not
relevent the the string-processing function being tested
larssandergreen [Mon, 3 Jul 2023 01:45:41 +0000 (19:45 -0600)]
Fix debug permissions for API 4 Explorer debug
larssandergreen [Mon, 3 Jul 2023 01:40:11 +0000 (19:40 -0600)]
Allow Drupal webstest user to view debug output
Eileen McNaughton [Mon, 3 Jul 2023 01:34:10 +0000 (18:34 -0700)]
Merge pull request #26701 from eileenmcnaughton/event
[Tests] Fix a few more places to use eventTrait & remove `legacyEventCreate`
Eileen McNaughton [Mon, 3 Jul 2023 00:20:34 +0000 (12:20 +1200)]
Fix a few more places to use eventTrait & remove legacyEventCreate
Tim Otten [Sun, 2 Jul 2023 21:26:45 +0000 (14:26 -0700)]
Merge pull request #26672 from totten/master-standalone-obj
Standalone - Track logged-in user object
colemanw [Sun, 2 Jul 2023 20:27:54 +0000 (13:27 -0700)]
Merge pull request #26697 from larssandergreen/Re-order-SearchDisplay-Links-options
Put link first in SearchDisplay Links options
colemanw [Sun, 2 Jul 2023 17:39:34 +0000 (13:39 -0400)]
SearchKit - Allow custom fields in join conditions
Mathieu Lutfy [Sun, 2 Jul 2023 03:25:32 +0000 (23:25 -0400)]
clearTempTables: fix condition for user_job check, move check inside the loop
larssandergreen [Sun, 2 Jul 2023 15:51:55 +0000 (09:51 -0600)]
Put link first in SearchDisplay Links options
demeritcowboy [Sun, 2 Jul 2023 13:49:02 +0000 (09:49 -0400)]
Merge pull request #25224 from braders/casecreation-medium-options-suffixes
APIv4, Case API, configure options and suffixes for medium_id field
Alice Frumin [Mon, 26 Jun 2023 17:29:44 +0000 (13:29 -0400)]
[NFC] 5.63 release notes
colemanw [Sat, 1 Jul 2023 21:24:16 +0000 (14:24 -0700)]
Merge pull request #26694 from larssandergreen/Add-unsub-and-optout-combined-to-mailing-stats
Add calculated optout & unsub mailing stats to API 4
larssandergreen [Sat, 1 Jul 2023 20:48:10 +0000 (14:48 -0600)]
Add calculated optout & unsub mailing stats to API 4
colemanw [Sat, 1 Jul 2023 20:05:44 +0000 (13:05 -0700)]
Merge pull request #26689 from larssandergreen/Calculated-field-for-mailing-successful-deliveries
Add calculated fields to API 4 for total mailing stats
demeritcowboy [Sat, 1 Jul 2023 18:27:12 +0000 (14:27 -0400)]
Merge pull request #26693 from larssandergreen/Remove-PHP5-check
Don't check for PHP 5 on Mapping Settings
larssandergreen [Sat, 1 Jul 2023 17:31:31 +0000 (11:31 -0600)]
Add calculated fields to API 4 for overall mailing stats
larssandergreen [Sat, 1 Jul 2023 16:50:56 +0000 (10:50 -0600)]
Don't check for PHP 5
Eileen McNaughton [Sat, 1 Jul 2023 03:45:38 +0000 (20:45 -0700)]
Merge pull request #26692 from larssandergreen/Correct-type-in-API-mailing-events
Typo correct for MailingEventReply.php
larssandergreen [Fri, 30 Jun 2023 23:41:25 +0000 (17:41 -0600)]
Typo correct for MailingEventReply.php
Bradley Taylor [Tue, 27 Dec 2022 11:37:32 +0000 (11:37 +0000)]
APIv4, Case API, configure options and suffixes for medium_id field
Eileen McNaughton [Fri, 30 Jun 2023 20:19:12 +0000 (13:19 -0700)]
Merge pull request #26691 from MegaphoneJon/replace-deprecated-event-fee-quickform
replace deprecated functions in event fee form
Jon Goldberg [Fri, 30 Jun 2023 19:46:05 +0000 (15:46 -0400)]
replace deprecated functions in event fee form
Eileen McNaughton [Fri, 30 Jun 2023 19:24:54 +0000 (12:24 -0700)]
Merge pull request #26686 from mlutfy/noteEntityId
Note Form: use EntityFormTrait and setEntityId for postProcess hooks
Tim Otten [Fri, 30 Jun 2023 18:57:21 +0000 (11:57 -0700)]
Standalone - Drop extra lookup
Tim Otten [Thu, 29 Jun 2023 23:19:20 +0000 (16:19 -0700)]
Standalone - Fix reference to session-variable
Tim Otten [Tue, 27 Jun 2023 21:36:23 +0000 (14:36 -0700)]
(REF) Invert relation between login functions. Prepare to reduce loads.
Before:
* Civi\Standalone\Security::loginAuthenticatedUserRecord() calls
Civix\Authx\Standalone::loginStateless() and Civix\Authx\Standalone::loginStateful()
* The logged-in user may be loaded twice - e.g. for workflows that
hit `loginAuthenticatedUserRecord()`
After
* Civix\Authx\Standalone::loginStateless() and Civix\Authx\Standalone::loginStateful()
call Civi\Standalone\Security::loginAuthenticatedUserRecord()
* The logged-in user is still loaded twice... but it'll small fix to load only once.
Comments
* The redundancy arose because `loginAuthenticatedUserRecord()` had the full-record,
and it called to `loginStateless()` (etc) with just ID or name - which then loaded
the full-record again.
* One might ask: "Is one orientation conceptually or philosophically better
than the other?" I don't have a good answer to that, but... I think this
patch makes for a nicer symmetry between `Civi\Authx\Standalone` and
`Civi\Authx\{Drupal,WordPress,etc}`. In all cases, they take the
userID/username and then perform a 1-4 SLOC incantation that
populates the global user-record.
Eileen McNaughton [Fri, 30 Jun 2023 17:42:46 +0000 (10:42 -0700)]
Merge pull request #26687 from colemanw/grantAutocomplete
CiviGrant - Support APIv4 autocompletes
Eileen McNaughton [Fri, 30 Jun 2023 17:41:29 +0000 (10:41 -0700)]
Merge pull request #26683 from larssandergreen/Add-Mailing-delivered-to-API4
Add missing Mailing Events to API4: Delivered, Forward, Reply
Eileen McNaughton [Fri, 30 Jun 2023 17:40:30 +0000 (10:40 -0700)]
Merge pull request #26681 from colemanw/isPrettyMuchEqual
crmAutocomplete - Fix endless loop (again)
colemanw [Thu, 29 Jun 2023 17:07:19 +0000 (13:07 -0400)]
crmAutocomplete - Fix endless loop (again)
This regressed in
65a6ae6b9228ad945b0f2dc9b80886468098555f because the comparison
needs to equivocate numbers and numeric strings.
Update ang/crmUi.js
Co-authored-by: Rich Lott <artfulrobot@users.noreply.github.com>
colemanw [Fri, 30 Jun 2023 16:08:00 +0000 (09:08 -0700)]
Merge pull request #26685 from artfulrobot/artfulrobot-add-port-to-FB-redirect
Fix ommitted port when constructing redirect URL
Mathieu Lu [Fri, 30 Jun 2023 15:16:22 +0000 (11:16 -0400)]
Note Form: use EntityFormTrait and setEntityId for postProcess hooks
Rich Lott / Artful Robot [Fri, 30 Jun 2023 15:03:00 +0000 (16:03 +0100)]
Fix ommitted port when constructing redirect URL
Form Builder can be configured to send a redirect after a submission
form has submitted. Before this change it rebuilt URLs with all the
parts except the port, causing failures on sites that use a non standard
port. After this change, a port is used if there is one.
larssandergreen [Fri, 30 Jun 2023 00:25:41 +0000 (18:25 -0600)]
Add missing Mailing Events to API4: Delivered, Forward, Reply
colemanw [Fri, 30 Jun 2023 00:10:48 +0000 (17:10 -0700)]
Merge pull request #26682 from samuelsov/dev/core#4396
dev/core#4396 AdminUI Find contact using sort_name
Tim Otten [Tue, 27 Jun 2023 08:49:36 +0000 (01:49 -0700)]
Standalone - Track logged-in user object
Overview
--------
This is a partial solution for running `E2E_Extern_CliRunnerTest::testPermissionLookup()` on Standalone.
Technical Details
-----------------
The test calls:
```
cv ev --user='admin' 'echo json_encode(CRM_Core_Config::singleton()->userPermissionClass->check("administer CiviCRM", 0));'
```
Internally, this command relies on `CRM_Core_BAO_UFMatch::synchronize()` by way of:
https://github.com/civicrm/cv/blob/
59efd9ffefde8dc500643e048d37db90e0de11b7/src/Util/BootTrait.php#L213-L235
Calls to `UFMatch::synchronize($user)` are expected to pass in a user-record.
Before
------
Standalone logins record the active user-ID.
After
------
Standalone logins record the active user-ID and active user-record (which can be supplied to `UFMatch::synchronize()`).
Samuel Vanhove [Thu, 29 Jun 2023 20:12:03 +0000 (16:12 -0400)]
dev/core#4396
Eileen McNaughton [Thu, 29 Jun 2023 20:10:19 +0000 (13:10 -0700)]
Merge pull request #26680 from demeritcowboy/codegen-php8
[PHP8] Codegen - Don't generate invalid secondary emails
colemanw [Thu, 29 Jun 2023 18:10:01 +0000 (14:10 -0400)]
CiviGrant - Support APIv4 autocompletes
demeritcowboy [Thu, 29 Jun 2023 14:39:15 +0000 (10:39 -0400)]
Merge pull request #26673 from larssandergreen/Rename-dedupe-rules
Clarify dedupe rules as "Name or Email"
demeritcowboy [Thu, 29 Jun 2023 13:57:17 +0000 (09:57 -0400)]
avoid invalid secondary emails
colemanw [Thu, 29 Jun 2023 02:17:35 +0000 (19:17 -0700)]
Merge pull request #26654 from eileenmcnaughton/survey_2
Add workflow message template for sign_petition, confirm petition
colemanw [Thu, 29 Jun 2023 02:17:16 +0000 (19:17 -0700)]
Merge pull request #26655 from eileenmcnaughton/survey_3
Fix test to use created workflow
Eileen McNaughton [Wed, 28 Jun 2023 16:49:13 +0000 (09:49 -0700)]
Merge pull request #26675 from totten/master-data-cleanup
(REF) Simplify some more installation data
Eileen McNaughton [Wed, 28 Jun 2023 16:47:41 +0000 (09:47 -0700)]
Merge pull request #26678 from totten/master-joomla-setup
(dev/core#1615) Setup - Prepare to generate Joomla-style "civicrm.settings.php"
Eileen McNaughton [Wed, 28 Jun 2023 16:46:52 +0000 (09:46 -0700)]
Merge pull request #26677 from totten/master-dist
distmaker - Add some options to speed up frequent rebuilds
Eileen McNaughton [Wed, 28 Jun 2023 16:45:11 +0000 (09:45 -0700)]
Merge pull request #24681 from larssandergreen/force-refresh-cache-for-smart-groups-when-scheduling-mailing
dev/core#3890 Rebuild smart groups included in mailing on scheduling
Eileen McNaughton [Wed, 28 Jun 2023 16:34:13 +0000 (09:34 -0700)]
Merge pull request #26679 from artfulrobot/tidy-ufId-to-ufID
NFC: standardise ufId to ufID to avoid confusion
Rich Lott / Artful Robot [Wed, 28 Jun 2023 13:55:36 +0000 (14:55 +0100)]
NFC: standardise ufId to ufID to avoid confusion
Tim Otten [Wed, 28 Jun 2023 08:41:01 +0000 (01:41 -0700)]
InstallSettingsFile - Split out separate rules for Joomla settings files
Tim Otten [Wed, 28 Jun 2023 08:11:44 +0000 (01:11 -0700)]
SettingsUtil::evaluate - Substitute variables atomically
Iterative substitution allows silliness. It's not a specific problem because
the range of inputs is so narrow here, but it's good cleanup the code-smell.
Tim Otten [Wed, 28 Jun 2023 08:00:21 +0000 (01:00 -0700)]
(REF) InstallSettingsFile - Extract 'createParams()` and `evaluate()`
Tim Otten [Wed, 28 Jun 2023 06:37:01 +0000 (23:37 -0700)]
distmaker - Add option DM_SKIP_EXT
Tim Otten [Wed, 28 Jun 2023 06:28:12 +0000 (23:28 -0700)]
distmaker - Don't print every statement (Joomla build script)
Tim Otten [Wed, 28 Jun 2023 06:27:50 +0000 (23:27 -0700)]
distmaker - Use quieter "rsync"
Tim Otten [Wed, 28 Jun 2023 05:57:12 +0000 (22:57 -0700)]
distmaker - Add options DM_KEEP_GIT, DM_KEEP_DEPS, DM_SKIP_ALT
If you're going through a frequent build/test cycle on Joomla patches, it's nice to cutdown
unnecessary build steps.
Tim Otten [Wed, 28 Jun 2023 00:00:31 +0000 (17:00 -0700)]
(REF) Simplify civicrm_tag.sqldata.php
Tim Otten [Wed, 28 Jun 2023 00:00:24 +0000 (17:00 -0700)]
(REF) Simplify civicrm_membership_status.sqldata.php
Tim Otten [Wed, 28 Jun 2023 00:00:18 +0000 (17:00 -0700)]
(REF) Simplify civicrm_location_type.sqldata.php
Tim Otten [Tue, 27 Jun 2023 23:59:43 +0000 (16:59 -0700)]
(REF) Simplify civicrm_job.sqldata.php
Tim Otten [Tue, 27 Jun 2023 23:59:20 +0000 (16:59 -0700)]
(REF) Simplify civicrm_contact_type.sqldata.php
Tim Otten [Tue, 27 Jun 2023 21:09:41 +0000 (14:09 -0700)]
Merge pull request #26657 from totten/master-standalone-403
Standalone - Generate proper HTTP response code for permission-errors
larssandergreen [Tue, 27 Jun 2023 21:01:37 +0000 (21:01 +0000)]
regenerate civicrm_generated
larssandergreen [Tue, 27 Jun 2023 20:55:53 +0000 (14:55 -0600)]
Rename "Name and Email" dedupe rules to "Name or Email"
demeritcowboy [Tue, 27 Jun 2023 20:53:06 +0000 (16:53 -0400)]
Merge pull request #26604 from christianwach/lab-wp-121
Fix UTC offsets when retrieving timezone string in WordPress
Yashodha Chaku [Tue, 27 Jun 2023 11:31:54 +0000 (17:01 +0530)]
Merge pull request #26671 from colemanw/deleteTpl
Delete unused tpl file
colemanw [Tue, 27 Jun 2023 04:57:52 +0000 (00:57 -0400)]
Delete unused tpl file
This tpl is unused since
b30809e49e9ed5142092f2157877a24ad1df17ee
Eileen McNaughton [Tue, 27 Jun 2023 00:06:38 +0000 (17:06 -0700)]
Merge pull request #26383 from MegaphoneJon/crmmoney-filter
crmMoney filter - allow coercing locale
Eileen McNaughton [Tue, 27 Jun 2023 00:00:09 +0000 (17:00 -0700)]
Merge pull request #25989 from eileenmcnaughton/import_county
Ensure counties are properly imported even if ambiguous
Jamie McClelland [Mon, 5 Dec 2022 21:49:21 +0000 (16:49 -0500)]
ensure counties are properly imported even if ambiguous
If a county has a unique name, you can import it by name.
But, if there is one or more counties with the same name, the county is
not properly converted to an id, and we get a foreign constraint error
and/or a invalid value error.
Tim Otten [Mon, 26 Jun 2023 22:22:28 +0000 (15:22 -0700)]
Merge pull request #26651 from eileenmcnaughton/workflow
Follow up to #26618 - set locale consistently when exporting model
Tim Otten [Sun, 25 Jun 2023 08:13:57 +0000 (01:13 -0700)]
Standalone - Generate proper HTTP response code for permission-errors
`E2E_Core_ErrorTest` checks for HTTP response codes on permission-errors
* Before: Sends HTTP 200. Tests for `frontend_permission` and `backend_permission` fails.
* After: Sends HTTP 403. Tests for `frontend_permission` and `backend_permission` passes.
Tim Otten [Mon, 26 Jun 2023 20:01:07 +0000 (13:01 -0700)]
Merge pull request #26649 from totten/master-standalone-paths
Standalone - Fix some path calculations
Tim Otten [Mon, 26 Jun 2023 19:34:46 +0000 (12:34 -0700)]
Merge pull request #26643 from totten/master-auto-enable
Standalone - Auto-enable user subsystem. Tweak default user.