eileen [Thu, 6 Sep 2018 03:26:22 +0000 (15:26 +1200)]
Do not cache NULL when it is likely a cache miss
eileen [Thu, 6 Sep 2018 02:44:55 +0000 (14:44 +1200)]
Do not treat an empty array as not set in caches.
On testing Redis we found that even after Redis cache had been
built the set function was still being called. It turned out the reason is that
when a value was set to an empty array that was being treated as FALSEY.
In fact the cache function returns NULL if nothing is set & no default is
specified & we should only treat NULL as a cache miss
Eileen McNaughton [Mon, 3 Sep 2018 00:18:04 +0000 (12:18 +1200)]
Merge pull request #12760 from civicrm/5.5
5.5 to master
Eileen McNaughton [Mon, 3 Sep 2018 00:17:39 +0000 (12:17 +1200)]
Merge pull request #12755 from jitendrapurohit/core-368-rc
dev/core#368 - Upgrade changes for reminder entity dates
Eileen McNaughton [Sun, 2 Sep 2018 05:08:49 +0000 (17:08 +1200)]
Merge pull request #12759 from civicrm/5.5
5.5 to master
Eileen McNaughton [Sun, 2 Sep 2018 05:07:34 +0000 (17:07 +1200)]
Merge pull request #12756 from mlutfy/5.5-ops-842
infrastructure/ops#842 Fix Getting Started and Blog dashlets caching.
Eileen McNaughton [Sun, 2 Sep 2018 05:02:58 +0000 (17:02 +1200)]
Merge pull request #12694 from eileenmcnaughton/mem_1
Deduplicate setting of mailSent message
Eileen McNaughton [Fri, 31 Aug 2018 21:21:56 +0000 (09:21 +1200)]
Merge pull request #12745 from jitendrapurohit/core-346
dev/core#346 - Online Pay Now error when used from dashboard checksum…
colemanw [Fri, 31 Aug 2018 19:11:55 +0000 (15:11 -0400)]
Merge pull request #12757 from colemanw/ext
Show ext version status even when directory not writeable
Coleman Watts [Fri, 31 Aug 2018 16:36:53 +0000 (12:36 -0400)]
Show ext version status even when directory not writeable
Mathieu Lutfy [Fri, 31 Aug 2018 01:56:45 +0000 (21:56 -0400)]
infrastructure/ops#842 Fix Getting Started and Blog dashlets caching.
Jitendra Purohit [Fri, 31 Aug 2018 09:24:49 +0000 (14:54 +0530)]
Fix inaccessible links for checksum users
Jitendra Purohit [Fri, 31 Aug 2018 06:38:33 +0000 (12:08 +0530)]
Upgrade changes for reminder entity dates
Eileen McNaughton [Fri, 31 Aug 2018 01:04:35 +0000 (13:04 +1200)]
Merge pull request #12752 from civicrm/5.5
5.5
colemanw [Thu, 30 Aug 2018 23:19:29 +0000 (19:19 -0400)]
Merge pull request #12751 from colemanw/tplExtract
Extract contact summary basic block to its own tpl
Seamus Lee [Thu, 30 Aug 2018 21:28:57 +0000 (07:28 +1000)]
Merge pull request #12744 from eileenmcnaughton/setting_form3
Setting form - function extraction
Coleman Watts [Thu, 30 Aug 2018 15:14:01 +0000 (11:14 -0400)]
Extract contact summary basic block to its own tpl
Eileen McNaughton [Thu, 30 Aug 2018 08:11:15 +0000 (20:11 +1200)]
Merge pull request #12749 from colemanw/public
Fix compatibility problem with CRM_Extendedreport_Form_Report_ExtendedReport
Coleman Watts [Thu, 30 Aug 2018 00:57:47 +0000 (20:57 -0400)]
Fix compatibility problem with CRM_Extendedreport_Form_Report_ExtendedReport
Mathieu Lu [Wed, 29 Aug 2018 15:04:05 +0000 (11:04 -0400)]
Merge pull request #12636 from chamilwijesooriya/issue-311
Upgrading multilingual site causes DB Error
Jitendra Purohit [Wed, 29 Aug 2018 10:50:38 +0000 (16:20 +0530)]
dev/core#346 - Online Pay Now error when used from dashboard checksum link
eileen [Wed, 29 Aug 2018 01:52:42 +0000 (13:52 +1200)]
Function extraction on setting form
eileen [Wed, 29 Aug 2018 01:46:45 +0000 (13:46 +1200)]
Minor code tidy up, clarify readonly status
colemanw [Wed, 29 Aug 2018 01:28:28 +0000 (21:28 -0400)]
Merge pull request #12732 from eileenmcnaughton/setting_form1
Towards rationalising settings form & preferences form (partial of 12731)
Eileen McNaughton [Wed, 29 Aug 2018 00:49:59 +0000 (12:49 +1200)]
Merge pull request #12743 from civicrm/5.5
5.5 to master
Eileen McNaughton [Wed, 29 Aug 2018 00:49:26 +0000 (12:49 +1200)]
Merge pull request #12742 from colemanw/dev/core#353
dev/core#353 fixed Source contact ID clause
colemanw [Wed, 29 Aug 2018 00:23:01 +0000 (20:23 -0400)]
Merge pull request #12723 from colemanw/addressBlock
Improve styling of address block on summary screen
colemanw [Wed, 29 Aug 2018 00:10:46 +0000 (20:10 -0400)]
Merge pull request #12706 from pradpnayak/OptionGroupFK
Foreign key for civicrm_custom_field.option_group_id
colemanw [Wed, 29 Aug 2018 00:08:24 +0000 (20:08 -0400)]
Merge pull request #12733 from eileenmcnaughton/crypt2
Remove mcrypt warning except for affected sites.
Eileen McNaughton [Tue, 28 Aug 2018 22:05:00 +0000 (10:05 +1200)]
Merge pull request #12740 from twomice/lab367_a_to_z_query_performance
dev/core#367: Query optimization for A-Z pager by adding indices to t…
Eileen McNaughton [Tue, 28 Aug 2018 21:55:21 +0000 (09:55 +1200)]
Merge pull request #12660 from pradpnayak/report-error
Fixed fatal error 'DB Error: no such field' on Contribution detail re…
Eileen McNaughton [Tue, 28 Aug 2018 21:44:59 +0000 (09:44 +1200)]
Merge pull request #12691 from andrewpthompson/dev-core-343
dev/core#343 Fix long address lines overflowing label
colemanw [Tue, 28 Aug 2018 21:35:24 +0000 (17:35 -0400)]
Merge pull request #12509 from JMAConsulting/dev-mail-20
dev/mail#20 : Preview screen doesn't open until recipients list is built on mail compose screen
Eileen McNaughton [Tue, 28 Aug 2018 21:30:44 +0000 (09:30 +1200)]
Merge pull request #12684 from mattwire/money_fn_update_payment_details
dev/core#299 Fix mishandling of non decimal currency on update payment details form
Eileen McNaughton [Tue, 28 Aug 2018 21:26:51 +0000 (09:26 +1200)]
Merge pull request #12738 from mattwire/membershiptype_customdata_formsupport
Enable custom data display on MembershipType form
Seamus Lee [Tue, 28 Aug 2018 21:12:32 +0000 (07:12 +1000)]
Merge pull request #12735 from colemanw/dev/core#351
dev/core#351 - Fix $.crmSnippet error with no url args
Eileen McNaughton [Tue, 28 Aug 2018 21:11:43 +0000 (09:11 +1200)]
Merge pull request #12712 from seamuslee001/dev_core_352
dev/core#352 Ensure that contacts that are to be exluded are not adde…
eileen [Mon, 20 Aug 2018 03:17:17 +0000 (15:17 +1200)]
Deduplicate setting of mailSent message
Pradeep Nayak [Wed, 22 Aug 2018 11:22:11 +0000 (12:22 +0100)]
dev/core#353 fixed Source contact ID clause
Allen Shaw [Tue, 28 Aug 2018 16:55:43 +0000 (11:55 -0500)]
dev/core#367: Query optimization for A-Z pager by adding indices to temp table.
Coleman Watts [Tue, 28 Aug 2018 12:24:37 +0000 (08:24 -0400)]
dev/core#351 - Fix $.crmSnippet error with no url args
Matthew Wire (MJW Consulting) [Tue, 24 Jul 2018 10:00:15 +0000 (11:00 +0100)]
Enable custom data display on MembershipType form
Eileen McNaughton [Tue, 28 Aug 2018 10:59:11 +0000 (22:59 +1200)]
Merge pull request #12701 from magnolia61/Scheduled_reminders-default-sort
dev/core#349 correct default sort for scheduled reminders list
Matthew Wire (MJW Consulting) [Fri, 17 Aug 2018 10:23:36 +0000 (11:23 +0100)]
Format money correctly for locale on UpdatePaymentDetails form
Eileen McNaughton [Tue, 28 Aug 2018 09:29:45 +0000 (21:29 +1200)]
Merge pull request #12667 from mlutfy/translation-14
dev/translation#14 Fix InnoDB Advanced Logging
eileen [Mon, 27 Aug 2018 21:48:56 +0000 (09:48 +1200)]
Remove mcrypt warning except for affected sites.
Extensions that wish to have a version of this should implement it themselves as
it is basically pretty trivial & it doesn't make sense to spam non-affected people
colemanw [Mon, 27 Aug 2018 21:37:32 +0000 (17:37 -0400)]
Merge pull request #12704 from colemanw/recent
Fix recent item deduping & call hooks
Seamus Lee [Wed, 22 Aug 2018 03:59:37 +0000 (13:59 +1000)]
dev/core#352 Ensure that contacts that are to be exluded are not added incorrectly when adding recipients of past mailings
Add in DISTINCT clause as per Moonish's comment
colemanw [Mon, 27 Aug 2018 16:08:51 +0000 (12:08 -0400)]
Merge pull request #12729 from mattwire/custom_field_optiongroup_fix2
Further fix for updating custom fields linked to optiongroups.
Coleman Watts [Mon, 27 Aug 2018 15:16:11 +0000 (11:16 -0400)]
Remove unneeded clear
Eileen McNaughton [Mon, 27 Aug 2018 06:31:41 +0000 (18:31 +1200)]
Merge pull request #12662 from eileenmcnaughton/net_amount
Remove net_amount from the Back office contribution form.
Eileen McNaughton [Mon, 27 Aug 2018 06:06:54 +0000 (18:06 +1200)]
Merge pull request #12678 from kewljuice/patch-1
Fix Undefined index: params in CRM_Event_BAO_Event::buildCustomProfile()
Eileen McNaughton [Mon, 27 Aug 2018 05:46:03 +0000 (17:46 +1200)]
Merge pull request #12700 from vinuvarshith/BASW-240-membership-network-error-fix
BASW-240: 'Network Error' when creating membership type from contact membership tab
Eileen McNaughton [Mon, 27 Aug 2018 05:31:13 +0000 (17:31 +1200)]
Merge pull request #12599 from lcdservices/dev-mail-21
dev/mail#21 trim test emails
Eileen McNaughton [Mon, 27 Aug 2018 05:27:27 +0000 (17:27 +1200)]
Merge pull request #12679 from mlutfy/core-334
dev/core#334 Fix Contribution Page with Checksum and multiple Payment Processors
Eileen McNaughton [Mon, 27 Aug 2018 03:28:50 +0000 (15:28 +1200)]
Merge pull request #12699 from chriscant/event-tell-a-friend-title
Get title for event tell a friend mail
Eileen McNaughton [Mon, 27 Aug 2018 03:27:14 +0000 (15:27 +1200)]
Merge pull request #12703 from yashodha/CRM-21677
CRM-21677 - report clean up
colemanw [Mon, 27 Aug 2018 00:53:39 +0000 (20:53 -0400)]
Merge pull request #12716 from calbasi/patch-1
Wrap long labels onto multiple lines to prevent text being cut off
eileen [Sun, 26 Aug 2018 23:54:56 +0000 (11:54 +1200)]
Towards rationalising settings form & preferences form
colemanw [Sun, 26 Aug 2018 13:51:06 +0000 (09:51 -0400)]
Merge pull request #12613 from JMAConsulting/core-issue-297
dev/core#297 : fix broken permission 'access my cases and activities'
calbasi [Wed, 22 Aug 2018 19:59:02 +0000 (21:59 +0200)]
Wrap long labels onto multiple lines to prevent text being cut off
Matthew Wire (MJW Consulting) [Fri, 24 Aug 2018 14:38:37 +0000 (15:38 +0100)]
Follow on to #12718 - Display all non-reserved option groups on update, making sure the existing one is selected.
colemanw [Sat, 25 Aug 2018 00:37:02 +0000 (20:37 -0400)]
Merge pull request #12726 from kainuk/issue-361
Corrected tag_id parameter description to refer cases
colemanw [Fri, 24 Aug 2018 23:58:01 +0000 (19:58 -0400)]
Merge pull request #12727 from pradpnayak/Pseudoconstant
Added Pseudoconstant for phone and website type
Coleman Watts [Thu, 23 Aug 2018 15:38:37 +0000 (11:38 -0400)]
Improve styling of address block on summary screen
Seamus Lee [Fri, 24 Aug 2018 20:42:13 +0000 (06:42 +1000)]
Merge pull request #12725 from civicrm/5.5
5.5
Pradeep Nayak [Fri, 24 Aug 2018 12:03:01 +0000 (13:03 +0100)]
Added Pseudoconstant for phone and website type
Klaas Eikelboom [Fri, 24 Aug 2018 08:29:19 +0000 (10:29 +0200)]
Corrected tag_id parameter description to refer cases instead of activities (See https://lab.civicrm.org/dev/core/issues/361)
Monish Deb [Fri, 24 Aug 2018 06:31:21 +0000 (12:01 +0530)]
Merge pull request #12720 from selwyntcy/patch-1
(NFC) Fix incorrect reference of doTransferCheckout() in comments
Monish Deb [Fri, 24 Aug 2018 06:30:47 +0000 (12:00 +0530)]
Merge pull request #12718 from mattwire/custom_field_optiongroup_fix
Fix for issue editing custom fields with option groups after #12423
Eileen McNaughton [Thu, 23 Aug 2018 21:11:34 +0000 (09:11 +1200)]
Merge pull request #12719 from seamuslee001/update_sql_generated
Update civicrm_generated mysql file following changes to custom mysql…
Monish Deb [Thu, 23 Aug 2018 18:02:47 +0000 (23:32 +0530)]
Merge pull request #12722 from eileenmcnaughton/report_instance
Fix ReportInstance BAO to call post hook after save (instead of calling pre twice).
colemanw [Thu, 23 Aug 2018 14:47:26 +0000 (10:47 -0400)]
Merge pull request #12708 from colemanw/summary
Contact summary - adjust block width when editing
eileen [Thu, 23 Aug 2018 10:41:15 +0000 (22:41 +1200)]
Fix ReportInstance BAO to call post hook after save (instead of calling pre twice).
Also, remove one unused var
Selwyn Tang [Thu, 23 Aug 2018 08:06:42 +0000 (16:06 +0800)]
Fix inconsistent reference to function name
Selwyn Tang [Thu, 23 Aug 2018 08:05:24 +0000 (16:05 +0800)]
Fix inconsistent reference to function name
Selwyn Tang [Thu, 23 Aug 2018 08:03:11 +0000 (16:03 +0800)]
Fix inconsistent reference to function name
Seamus Lee [Wed, 22 Aug 2018 22:09:59 +0000 (08:09 +1000)]
Update civicrm_generated mysql file following changes to custom mysql file
Matthew Wire (MJW Consulting) [Wed, 22 Aug 2018 21:55:10 +0000 (22:55 +0100)]
Fix for issue editing custom fields with option groups after #12423
Coleman Watts [Tue, 21 Aug 2018 20:52:26 +0000 (16:52 -0400)]
Contact summary - adjust block width when editing
colemanw [Wed, 22 Aug 2018 15:49:11 +0000 (11:49 -0400)]
Merge pull request #12715 from mattwire/comments_2
Minor comment and typo cleanup
Matthew Wire (MJW Consulting) [Wed, 22 Aug 2018 13:16:04 +0000 (14:16 +0100)]
Comments
Pradeep Nayak [Wed, 22 Aug 2018 09:27:04 +0000 (10:27 +0100)]
changed version name
andrewpthompson [Wed, 22 Aug 2018 00:57:09 +0000 (10:27 +0930)]
Fixed whitespace
andrewpthompson [Wed, 22 Aug 2018 00:54:49 +0000 (10:24 +0930)]
Added comment explaining paddingLeft
Eileen McNaughton [Tue, 21 Aug 2018 19:59:33 +0000 (07:59 +1200)]
Merge pull request #12705 from pradpnayak/Visibility
Added Pseudoconstant tag for visibility
Pradeep Nayak [Tue, 21 Aug 2018 15:20:35 +0000 (16:20 +0100)]
Foreign key for civicrm_option_group.option_group_id
Pradeep Nayak [Tue, 21 Aug 2018 14:58:22 +0000 (15:58 +0100)]
Added Pseudoconstant tag for visibility
Coleman Watts [Tue, 21 Aug 2018 13:39:03 +0000 (09:39 -0400)]
Call hooks when deleting recent items
Coleman Watts [Tue, 21 Aug 2018 12:43:00 +0000 (08:43 -0400)]
Fix recent item deduping
colemanw [Tue, 21 Aug 2018 11:15:31 +0000 (07:15 -0400)]
Merge pull request #12702 from colemanw/urls
Navigation - Don't reprocess fully-formed urls
yashodha [Tue, 21 Aug 2018 09:46:26 +0000 (15:16 +0530)]
CRM-21677 - report clean up
Eileen McNaughton [Tue, 21 Aug 2018 05:31:31 +0000 (17:31 +1200)]
Merge pull request #12692 from andrewpthompson/dev-joomla-2
dev/joomla#2 Joomla on Windows cli.php & cron.php fail due to incorrect path
Coleman Watts [Mon, 20 Aug 2018 21:52:57 +0000 (17:52 -0400)]
Navigation - Don't reprocess fully-formed urls
Eileen McNaughton [Mon, 20 Aug 2018 20:50:21 +0000 (08:50 +1200)]
Merge pull request #12696 from eileenmcnaughton/matt_1
NFC cleanup to Membership/Renewal form classes.
Eileen McNaughton [Mon, 20 Aug 2018 20:48:16 +0000 (08:48 +1200)]
Merge pull request #12698 from yashodha/CRM-21677
CRM-21677 - report clean up
magnolia61 [Mon, 20 Aug 2018 13:37:37 +0000 (15:37 +0200)]
correct default sort for scheduled reminders list
varshith89 [Mon, 20 Aug 2018 09:48:12 +0000 (09:48 +0000)]
BASW-240: Change Null Strings To Null Values As Null Strings Are Not Actually Null
chriscant [Mon, 20 Aug 2018 09:14:50 +0000 (10:14 +0100)]
Get title for event tell a friend mail
yashodha [Mon, 20 Aug 2018 08:37:34 +0000 (14:07 +0530)]
CRM-21677 - report clean up