Tim Otten [Wed, 25 Jan 2023 04:34:04 +0000 (20:34 -0800)]
Restore execution of CaseActivityTest
Following
eb92dd792c07e0b11ee1561cf00930402345e8b3, the `CaseActivityTest` started to run
only intermittently. Why?
__high-level__: `Civi\Core\ClassScanner` and `phpunit8` both do a scan over the folder `tests/phpunit/CRM/Case/WorkflowMessage`
__low-level__: `Civi\Core\ClassScanner` has caching. Depending on the state of the cache, it may or may not do a scan:
* If the cache is filled, then `ClassScanner` doesn't need to scan.
* When `phpunit8` subsequently does a scan, it will load `CaseActivityTest.php` normally.
* If the cache is empty, then `ClassScanner` does the first scan. It is the one that actually loads `CaseActivityTest.php`.
* Later, `phpunit8` does a scan. Due to a quirk, it doesn't realize the class exists.
The scanner in phpunit works roughly like this:
```php
$tests = [];
foreach (glob('*Test.php') as $file) {
$before = get_declared_classes();
require_once $file;
$after = get_declared_classes();
$tests = array_merge($tests, array_diff($before, $after));
}
```
So if the class was previously loaded, then phpunit doesn't see it.
Tim Otten [Wed, 25 Jan 2023 05:00:34 +0000 (21:00 -0800)]
Merge pull request #25415 from totten/master-scan
(dev/core#4088) ClassScanner - Move test registration
Seamus Lee [Wed, 25 Jan 2023 01:39:16 +0000 (12:39 +1100)]
Merge pull request #25404 from demeritcowboy/activityinfos-static
[REF] Use civi::statics to get activityinfos in case activity view
Tim Otten [Wed, 25 Jan 2023 01:06:57 +0000 (17:06 -0800)]
(dev/core#4088) ClassScanner - Move unit-test registration
Before: The `ClassScanner` includes a special rule to load some
mocks/examples from `tests/phpunit/` which are needed for some core tests.
But (reportedly) it will load even when running other test-suites.
After: The special rule has moved to the `bootstrap.php` for
core tests. It should be inert when running other test-suites.
Technical Details: I believe the reason why the special rule was originally
embedded into `ClassScanner` was that `ClassScanner` has special place in
bootstrap/system-lifecycle. To get around this, the patch adds
`CIVICRM_FORCE_MODULES` as a way to pre-register some hook listeners. (To
wit: `civitest` is a "force-enabled module" defined by `bootstrap.php`.
It's always-on; it can participate in special/pre-boot hooks; and it
doesn't present as a configurable extension. You might also call it
a "ghost module"...)
demeritcowboy [Wed, 25 Jan 2023 00:55:54 +0000 (19:55 -0500)]
Merge pull request #25413 from seamuslee001/regen
[REF] Regen following #25211
Seamus Lee [Wed, 25 Jan 2023 00:10:35 +0000 (11:10 +1100)]
Fix country id in state_provice_data as per Dave and fix the original state abbreviations as well and regen again
Seamus Lee [Tue, 24 Jan 2023 23:51:29 +0000 (10:51 +1100)]
[REF] Regen following #25211
Seamus Lee [Tue, 24 Jan 2023 23:47:30 +0000 (10:47 +1100)]
Merge pull request #25211 from jmacarthur98/luxembourg-provinces
luxembourg-provices added missing provices, updated outdated ISO code…
Tim Otten [Tue, 24 Jan 2023 22:32:08 +0000 (14:32 -0800)]
Merge pull request #25369 from totten/master-smarty-mixin
Smarty Mixin - Allow extensions to enable Smarty via mixin
Tim Otten [Tue, 24 Jan 2023 21:34:12 +0000 (13:34 -0800)]
(NFC) smarty-v2 mixin
Jakub MacArthur [Thu, 19 Jan 2023 09:16:24 +0000 (10:16 +0100)]
luxembourg-provinces added check for country ID
Jakub MacArthur [Tue, 3 Jan 2023 10:27:36 +0000 (11:27 +0100)]
luxembourg-provinces removed one unnecessary comma, added one comma
Jakub MacArthur [Wed, 21 Dec 2022 10:54:33 +0000 (11:54 +0100)]
luxembourg-provices added missing provices, updated outdated ISO codes, renamed one provice
Yashodha Chaku [Mon, 23 Jan 2023 06:14:21 +0000 (11:44 +0530)]
Merge pull request #25397 from colemanw/customFieldTplCleanup
CustomField - Fix smarty notices on field create/edit form
demeritcowboy [Sun, 22 Jan 2023 00:02:53 +0000 (19:02 -0500)]
use civi statics
demeritcowboy [Sat, 21 Jan 2023 13:16:49 +0000 (08:16 -0500)]
Merge pull request #25399 from braders/dynamic-property-report-test
[REF][PHP8.2] Avoid dynamic property in ReportTest
Bradley Taylor [Sat, 21 Jan 2023 12:07:56 +0000 (12:07 +0000)]
[REF][PHP8.2] Avoid dynamic property in ReportTest
demeritcowboy [Sat, 21 Jan 2023 03:50:57 +0000 (22:50 -0500)]
Merge pull request #25229 from braders/core-2985-original-value-displayed-after-setting-blank-balue
dev/core#2985 Original value is displayed after setting custom event field blank
Coleman Watts [Fri, 20 Jan 2023 23:50:49 +0000 (18:50 -0500)]
CustomField - Fix smarty notices on field create/edit form
The structure of the form was changed back in 2020 to stop using a hierarchical quickform select,
so references to `$form.data_type.value.0` etc are no longer valid.
This was resulting in massive smarty notices.
This removes the offending clauses which were not doing anything as the show/hide is now handled by jQuery.
demeritcowboy [Fri, 20 Jan 2023 17:24:43 +0000 (12:24 -0500)]
Merge pull request #25394 from civicrm/5.58
5.58
Yashodha Chaku [Fri, 20 Jan 2023 11:26:57 +0000 (16:56 +0530)]
Merge pull request #25381 from demeritcowboy/case-act-vars
Undefined array keys on case activity view
Tim Otten [Fri, 20 Jan 2023 01:20:30 +0000 (17:20 -0800)]
mixin/smarty-v2 - Update for compatibility with more versions of CiviCRM
Seamus Lee [Fri, 20 Jan 2023 01:18:52 +0000 (12:18 +1100)]
Merge pull request #25380 from demeritcowboy/act-rev
Avoid 5.57 upgrade taking hours on large activity tables
Eileen McNaughton [Fri, 20 Jan 2023 00:43:24 +0000 (13:43 +1300)]
Merge pull request #25393 from seamuslee001/php82_legacy_custom_searches
[REF][PHP8.2] Fix Deprecated Dynamic class properties in Legacy custo…
Seamus Lee [Fri, 20 Jan 2023 00:39:00 +0000 (00:39 +0000)]
[REF][PHP8.2] Fix Deprecated Dynamic class properties in Legacy custom searches extension
demeritcowboy [Fri, 20 Jan 2023 00:12:20 +0000 (19:12 -0500)]
Merge pull request #25389 from eileenmcnaughton/main_pledge
Make otherwise unused form function private
demeritcowboy [Thu, 19 Jan 2023 03:25:23 +0000 (22:25 -0500)]
avoid upgrade taking hours
Seamus Lee [Fri, 20 Jan 2023 00:03:24 +0000 (11:03 +1100)]
Merge pull request #25379 from totten/master-ext-cache
(dev/core#4055) ClassLoader - Use separate cache IDs for different configurations of modules
Eileen McNaughton [Thu, 19 Jan 2023 23:58:29 +0000 (12:58 +1300)]
Merge pull request #25382 from demeritcowboy/case-act-vars2
Undefined `accessKey` on case activity view
Tim Otten [Thu, 19 Jan 2023 22:24:50 +0000 (14:24 -0800)]
Merge pull request #25374 from colemanw/fixChange
Fix dev/core#4083 - Broken autocomplete Afform widget
Eileen McNaughton [Thu, 19 Jan 2023 22:15:51 +0000 (11:15 +1300)]
Merge pull request #25376 from mattwire/paypalcleanup
Paypal cancel/notify/return URLs
Seamus Lee [Thu, 19 Jan 2023 22:03:31 +0000 (09:03 +1100)]
Merge pull request #25388 from braders/dynamic-property-provider-test
[REF][PHP8.2] Avoid dynamic property in CRM_SMS_ProviderTest
Tim Otten [Thu, 19 Jan 2023 21:56:36 +0000 (13:56 -0800)]
(NFC) More type-hints
Tim Otten [Thu, 19 Jan 2023 21:52:05 +0000 (13:52 -0800)]
(NFC) smarty-v2 - Add more explanatory comments
Tim Otten [Wed, 18 Jan 2023 06:13:43 +0000 (22:13 -0800)]
smarty-v2 - Avoid duplicate registrations
Tim Otten [Wed, 18 Jan 2023 05:06:22 +0000 (21:06 -0800)]
search_kit, civigrant - Use mixin 'smarty-v2'
Tim Otten [Wed, 18 Jan 2023 05:05:41 +0000 (21:05 -0800)]
shimmy - Remove old boilerplate for registering Smarty folder
Tim Otten [Wed, 18 Jan 2023 03:13:57 +0000 (19:13 -0800)]
Add mixin/smarty-v2
Eileen McNaughton [Thu, 19 Jan 2023 21:25:23 +0000 (10:25 +1300)]
Make otherwise unused form function private
Bradley Taylor [Thu, 19 Jan 2023 20:41:44 +0000 (20:41 +0000)]
[REF][PHP8.2] Avoid dynamic property in CRM_SMS_ProviderTest
demeritcowboy [Thu, 19 Jan 2023 19:31:57 +0000 (14:31 -0500)]
Merge pull request #25386 from civicrm/5.58
5.58
demeritcowboy [Thu, 19 Jan 2023 18:31:26 +0000 (13:31 -0500)]
Merge pull request #25370 from pradpnayak/waitlist
Waitlist
Pradeep Nayak [Wed, 18 Jan 2023 14:43:44 +0000 (14:43 +0000)]
Do not display waitlist message dev/core/-/issues/4087
colemanw [Thu, 19 Jan 2023 15:14:50 +0000 (10:14 -0500)]
Merge pull request #25188 from aydun/optgroups_meta
Enhance metadata for OptionGroups
Coleman Watts [Thu, 19 Jan 2023 15:11:42 +0000 (10:11 -0500)]
OptionGroup - Add paths metadata
Yashodha Chaku [Thu, 19 Jan 2023 10:27:15 +0000 (15:57 +0530)]
Merge pull request #25384 from totten/master-void
(NFC) Mixin Tests - Add more type-hints
Tim Otten [Thu, 19 Jan 2023 07:49:25 +0000 (23:49 -0800)]
(NFC) Mixin Tests - Add more typehints
demeritcowboy [Thu, 19 Jan 2023 03:54:31 +0000 (22:54 -0500)]
Merge pull request #25378 from eileenmcnaughton/test_base
dev/core#4088 Superficial cleanup on Api4testBase
demeritcowboy [Thu, 19 Jan 2023 01:12:33 +0000 (20:12 -0500)]
undefined array keys
demeritcowboy [Thu, 19 Jan 2023 01:16:02 +0000 (20:16 -0500)]
undefined vars
Eileen McNaughton [Wed, 18 Jan 2023 23:47:39 +0000 (12:47 +1300)]
dev/core#4088 Superficial cleanup on Api4testBase
Tim Otten [Wed, 18 Jan 2023 23:59:18 +0000 (15:59 -0800)]
(dev/core#4055) ClassLoader - Use separate cache IDs for different configurations of modules
Tim Otten [Wed, 18 Jan 2023 21:45:46 +0000 (13:45 -0800)]
Merge pull request #25354 from seamuslee001/fix_ewaysingle_tests
[REF][PHP8.2] Fix Eway Single Payment Processor extension for dynamic…
Tim Otten [Wed, 18 Jan 2023 21:45:00 +0000 (13:45 -0800)]
Merge pull request #25372 from braders/dynamic-properties-contribution-page-test
[REF][PHP8.2] Use const instead of dynamic property: CRM_Contribute_BAO_ContributionPageTest
Tim Otten [Wed, 18 Jan 2023 21:44:08 +0000 (13:44 -0800)]
Merge pull request #25373 from braders/dynamic-properties-ziptest
[REF][PHP8.2] Declare $file property in CRM_Utils_ZipTest
Tim Otten [Wed, 18 Jan 2023 21:43:35 +0000 (13:43 -0800)]
Merge pull request #25375 from braders/dynamic-properties-event-test
[REF][PHP8.2] Avoid dynamic properties in api_v3_EventTest
Matthew Wire [Wed, 18 Jan 2023 20:01:53 +0000 (20:01 +0000)]
Paypal: Use standard functions for cancelUrl / notifyUrl
Matthew Wire [Wed, 18 Jan 2023 20:01:16 +0000 (20:01 +0000)]
Paypal (express): Pass participantID to getCancelUrl() if available
Matthew Wire [Wed, 18 Jan 2023 20:00:33 +0000 (20:00 +0000)]
Payment: getCancelUrl participant default value of NULL
Matthew Wire [Wed, 18 Jan 2023 19:55:05 +0000 (19:55 +0000)]
Paypal: Use getBaseReturnUrl() function
Matthew Wire [Wed, 18 Jan 2023 19:16:46 +0000 (19:16 +0000)]
Paypal: Stop passing component when it exists on the class
Bradley Taylor [Wed, 18 Jan 2023 19:54:27 +0000 (19:54 +0000)]
[REF][PHP8.2] Avoid dynamic properties in api_v3_EventTest
Coleman Watts [Wed, 18 Jan 2023 19:47:05 +0000 (14:47 -0500)]
Fix dev/core#4083 - Broken autocomplete Afform widget
Bradley Taylor [Wed, 18 Jan 2023 19:28:24 +0000 (19:28 +0000)]
[REF][PHP8.2] Declare property in CRM_Utils_ZipTest
Bradley Taylor [Wed, 18 Jan 2023 19:22:36 +0000 (19:22 +0000)]
[REF][PHP8.2] Use const instead of dynamic property: CRM_Contribute_BAO_ContributionPageTest
colemanw [Wed, 18 Jan 2023 15:37:39 +0000 (10:37 -0500)]
Merge pull request #25298 from eileenmcnaughton/import
Php8.2 Contact import Map Field screen - remove undefined property usage (mutliple)
colemanw [Wed, 18 Jan 2023 15:33:07 +0000 (10:33 -0500)]
Merge pull request #25318 from eileenmcnaughton/cust_load
Pass metadata values rather than convoluted array to `processCustomFields`
colemanw [Wed, 18 Jan 2023 15:30:56 +0000 (10:30 -0500)]
Merge pull request #25239 from eileenmcnaughton/cont_mode
Remove a couple of legacy uses of `contributeMode`
colemanw [Wed, 18 Jan 2023 15:29:57 +0000 (10:29 -0500)]
Merge pull request #25259 from eileenmcnaughton/cont_ids
Deprecate meaningless parameter
colemanw [Wed, 18 Jan 2023 15:28:50 +0000 (10:28 -0500)]
Merge pull request #25361 from eileenmcnaughton/ev_cart
Civix upgrade on event cart
Eileen McNaughton [Wed, 18 Jan 2023 06:41:14 +0000 (19:41 +1300)]
Merge pull request #25366 from yashodha/dev-4084
(dev/core#4084) Assign participant_status_id in both edit/create modes
Tim Otten [Wed, 18 Jan 2023 03:13:35 +0000 (19:13 -0800)]
LifecycleTest - Add helper $cv->isLocal()
Eileen McNaughton [Wed, 18 Jan 2023 01:11:28 +0000 (14:11 +1300)]
Merge pull request #25249 from eileenmcnaughton/improve_add
Greenwich - Run `civix upgrade`
Seamus Lee [Tue, 17 Jan 2023 21:50:09 +0000 (08:50 +1100)]
Merge pull request #25357 from eileenmcnaughton/ext_flex
Flexmailer - Re-run civix upgrade
demeritcowboy [Tue, 17 Jan 2023 21:35:10 +0000 (16:35 -0500)]
Merge pull request #24665 from larssandergreen/replace-disabled-class-with-crm-inactive
dev/core#2542 Avoid collision with Bootstrap for .disabled links
Seamus Lee [Tue, 17 Jan 2023 21:30:34 +0000 (08:30 +1100)]
Merge pull request #25358 from eileenmcnaughton/ext_oauth
Run civix upgrade on oauth
Seamus Lee [Tue, 17 Jan 2023 21:12:26 +0000 (08:12 +1100)]
Merge pull request #25355 from seamuslee001/fix_payflow_pro
[REF][PHP8.2] Fix creation of dynamic properties in Payflow Pro exten…
Eileen McNaughton [Tue, 17 Jan 2023 21:10:39 +0000 (10:10 +1300)]
Merge pull request #25351 from braders/phpdoc
(NFC) Another batch of PHPDoc fixes
Eileen McNaughton [Tue, 17 Jan 2023 20:32:55 +0000 (09:32 +1300)]
Merge pull request #25363 from totten/master-queue-tz
Queues - Ensure that queue timings work, even with bad tzdata
Bradley Taylor [Sun, 15 Jan 2023 11:48:47 +0000 (11:48 +0000)]
(NFC) Another batch of PHPDoc fixes
demeritcowboy [Tue, 17 Jan 2023 12:59:43 +0000 (07:59 -0500)]
Merge pull request #25247 from eileenmcnaughton/assign_ref
Remove code for legacy php versions - `assign_by_ref` with an object
demeritcowboy [Tue, 17 Jan 2023 12:57:51 +0000 (07:57 -0500)]
Merge pull request #25365 from totten/master-gitlab-refs
(NFC) Cleanup Gitlab references
yashodha [Tue, 17 Jan 2023 06:15:19 +0000 (11:45 +0530)]
(dev/core#4084) Assign participant_status_id in both edit/create modes
Tim Otten [Tue, 17 Jan 2023 05:48:24 +0000 (21:48 -0800)]
(NFC) Cleanup Gitlab references
Yashodha Chaku [Tue, 17 Jan 2023 04:46:34 +0000 (10:16 +0530)]
Merge pull request #25359 from eileenmcnaughton/ext_message_admin
Civix upgrade message_admin
Yashodha Chaku [Tue, 17 Jan 2023 04:43:03 +0000 (10:13 +0530)]
Merge pull request #25262 from eileenmcnaughton/dep_query
Remove code deprecated in 2019
Eileen McNaughton [Tue, 17 Jan 2023 04:26:12 +0000 (17:26 +1300)]
Merge pull request #25364 from alifrumin/rn5.58
[NFC] First Pass 5.58 Release Notes
Tim Otten [Tue, 17 Jan 2023 03:01:01 +0000 (19:01 -0800)]
CRM_Queue_Queue_SqlTrait - Insert using epoch format
Tim Otten [Tue, 17 Jan 2023 03:00:41 +0000 (19:00 -0800)]
CRM_Queue_Queue_SqlTrait - Prefer operations using Unix epoch format
Tim Otten [Tue, 17 Jan 2023 02:52:44 +0000 (18:52 -0800)]
CRM_Queue_Queue_SqlParallel - Prefer operations using Unix epoch format
Tim Otten [Tue, 17 Jan 2023 02:52:28 +0000 (18:52 -0800)]
CRM_Queue_Queue_Sql - Prefer operations using Unix epoch format
Tim Otten [Tue, 17 Jan 2023 02:52:04 +0000 (18:52 -0800)]
Add CRM_Utils_Time::delta()
Alice Frumin [Sat, 14 Jan 2023 03:45:39 +0000 (22:45 -0500)]
[NFC] First Pass 5.58 Release Notes
Eileen McNaughton [Sun, 1 Jan 2023 01:25:04 +0000 (14:25 +1300)]
Remove code for legacy php versions - assign_by_ref with an object
Eileen McNaughton [Mon, 16 Jan 2023 23:07:35 +0000 (12:07 +1300)]
Civix upgrade on event cart
Eileen McNaughton [Mon, 16 Jan 2023 21:18:28 +0000 (10:18 +1300)]
Civix upgrade message_admin
Eileen McNaughton [Mon, 16 Jan 2023 21:08:28 +0000 (10:08 +1300)]
Run civix upgrade on oauth
Eileen McNaughton [Mon, 16 Jan 2023 21:05:50 +0000 (10:05 +1300)]
Re-run civix upgrade on flexmailer
Also see https://github.com/civicrm/civicrm-core/pull/25249
demeritcowboy [Mon, 16 Jan 2023 15:34:08 +0000 (10:34 -0500)]
Merge pull request #25349 from braders/resources-test-tidyup
(REF) Tidy up properties in CRM_Core_ResourcesTest
Eileen McNaughton [Mon, 16 Jan 2023 08:47:06 +0000 (21:47 +1300)]
Merge pull request #25356 from seamuslee001/dev_core_4081
dev/core#4081 Ensure that if using the API to update an event templat…