Bradley Taylor [Sun, 5 Nov 2023 11:14:52 +0000 (11:14 +0000)]
[REF][PHP8.2] Remove unused dynamic props
demeritcowboy [Sat, 21 Oct 2023 02:11:45 +0000 (22:11 -0400)]
Merge pull request #27870 from civicrm/5.67
5.67
Yashodha Chaku [Fri, 20 Oct 2023 18:21:32 +0000 (23:51 +0530)]
Merge pull request #27873 from mlutfy/core4704
dev/core#4704 Display 'registration is closed' only if users can register
Mathieu Lu [Fri, 20 Oct 2023 17:41:27 +0000 (13:41 -0400)]
dev/core#4704 Display 'registration is closed' only if users can register
colemanw [Fri, 20 Oct 2023 10:18:40 +0000 (06:18 -0400)]
Merge pull request #27856 from colemanw/emptyRequires
dev/core#4707 Don't error if extension has empty `requires` tag
Tim Otten [Fri, 20 Oct 2023 02:25:33 +0000 (19:25 -0700)]
Merge pull request #27869 from totten/master-oauth-links
(REF) MailSettings - Provide setup URL's through BAO (towards dev/core#4674)
colemanw [Wed, 18 Oct 2023 23:28:43 +0000 (19:28 -0400)]
Extensions - Don't accept invalid keys, include empty <requires> in test
colemanw [Wed, 18 Oct 2023 23:19:29 +0000 (19:19 -0400)]
UnitTest - Rename & reformat json file
No changes to the file content other than whitespace
colemanw [Wed, 18 Oct 2023 20:13:46 +0000 (16:13 -0400)]
dev/core#4707 Don't error if extension has empty `requires` tag
Tim Otten [Thu, 19 Oct 2023 23:47:45 +0000 (16:47 -0700)]
(dev/core#4674) MailSettings - Provide setup URL's through BAO
Seamus Lee [Thu, 19 Oct 2023 23:20:16 +0000 (10:20 +1100)]
Merge pull request #27861 from colemanw/afformDefaults
Afform - Add default values to metadata
colemanw [Thu, 19 Oct 2023 23:02:02 +0000 (19:02 -0400)]
Merge pull request #27868 from eileenmcnaughton/567-e
dev/core#4706 Custom data fix
Eileen McNaughton [Thu, 19 Oct 2023 22:07:55 +0000 (11:07 +1300)]
Merge pull request #27866 from totten/master-regen
dev/core#4710 - Regenerate `civicrm_generated.mysql`
Eileen McNaughton [Thu, 19 Oct 2023 21:39:39 +0000 (10:39 +1300)]
Merge pull request #27864 from colemanw/api4Helper
APIv4 - Add helper function and type hints
Eileen McNaughton [Thu, 19 Oct 2023 21:37:24 +0000 (10:37 +1300)]
dev/core#4706 Custom data fix
Eileen McNaughton [Thu, 19 Oct 2023 21:31:17 +0000 (10:31 +1300)]
Merge pull request #27867 from eileenmcnaughton/master
5.67 to master
Seamus Lee [Thu, 19 Oct 2023 21:30:59 +0000 (08:30 +1100)]
Merge pull request #27852 from eileenmcnaughton/main_premium
Fix unreleased regression on premium block, notices
Eileen McNaughton [Thu, 19 Oct 2023 21:29:06 +0000 (10:29 +1300)]
Merge branch '5.67' of github.com:civicrm/civicrm-core
Tim Otten [Thu, 19 Oct 2023 21:23:07 +0000 (14:23 -0700)]
Regenerate `civicrm_generated.mysql`
colemanw [Thu, 19 Oct 2023 21:20:28 +0000 (17:20 -0400)]
Merge pull request #27854 from eileenmcnaughton/567
Fix regression when searching by contact ID from quickSearch (if you hit enter quickly)
colemanw [Thu, 19 Oct 2023 21:05:40 +0000 (17:05 -0400)]
APIv4 - Add type hints
colemanw [Thu, 19 Oct 2023 19:08:38 +0000 (15:08 -0400)]
APIv4 - Add CoreUtil::isType() helper
Helper function avoids verbose coding pattern.
colemanw [Thu, 19 Oct 2023 13:24:09 +0000 (09:24 -0400)]
Afform - Add default values to metadata
Eileen McNaughton [Wed, 18 Oct 2023 23:53:41 +0000 (12:53 +1300)]
Merge pull request #27859 from totten/master-phpunit-webtest
(NFC) phpunit.xml.dist - Drop stale reference to old suite
Tim Otten [Wed, 18 Oct 2023 23:13:30 +0000 (16:13 -0700)]
(NFC) phpunit.xml.dist - Drop stale reference to old suite
Seamus Lee [Wed, 18 Oct 2023 21:42:05 +0000 (08:42 +1100)]
Merge pull request #27857 from colemanw/angularMail
Angular - Always load CiviMail modules if component is enabled
colemanw [Wed, 18 Oct 2023 20:35:54 +0000 (16:35 -0400)]
Angular - Always load CiviMail modules if component is enabled
colemanw [Wed, 18 Oct 2023 20:30:32 +0000 (16:30 -0400)]
Merge pull request #27853 from colemanw/noDefaultIsActive
APIv4 - Allow is_active field to default to '0'
colemanw [Wed, 18 Oct 2023 14:11:45 +0000 (10:11 -0400)]
APIv4 - Add unit test to ensure is_active field consitency
colemanw [Wed, 18 Oct 2023 11:54:39 +0000 (07:54 -0400)]
APIv4 - Set default value for Dashboard & Event entities
colemanw [Wed, 18 Oct 2023 17:48:21 +0000 (13:48 -0400)]
Merge pull request #27855 from colemanw/ParticipantStatusType
[REF] ParticipantStatusType - Switch to writeRecord
colemanw [Wed, 18 Oct 2023 13:06:34 +0000 (09:06 -0400)]
ParticipantStatusType - Switch to writeRecord
Eileen McNaughton [Tue, 17 Oct 2023 23:59:52 +0000 (12:59 +1300)]
Fix variable leakage between uf_group_id & contact ID
colemanw [Tue, 17 Oct 2023 23:38:29 +0000 (19:38 -0400)]
Merge pull request #27849 from mattwire/jobedit
Allow to specify API4 job entity in Edit Job form
Sandor Semsey [Thu, 21 Sep 2023 23:01:58 +0000 (01:01 +0200)]
allow is_active field to default to '0'
Eileen McNaughton [Tue, 17 Oct 2023 21:34:22 +0000 (10:34 +1300)]
Move assignment out of if
Eileen McNaughton [Tue, 17 Oct 2023 21:30:31 +0000 (10:30 +1300)]
Fix regression on premium block
Eileen McNaughton [Tue, 17 Oct 2023 21:01:07 +0000 (10:01 +1300)]
Smarty notice fixes on premium block
Matthew Wire [Tue, 17 Oct 2023 20:27:50 +0000 (21:27 +0100)]
Merge pull request #27846 from colemanw/defaultIsActive
Make civicrm_acl.is_active required and default=1
Matthew Wire [Tue, 17 Oct 2023 20:26:48 +0000 (21:26 +0100)]
Merge pull request #27847 from eileenmcnaughton/crazy_if
[REF] Extract add soft credit fields
Matthew Wire [Tue, 17 Oct 2023 20:04:33 +0000 (21:04 +0100)]
Allow to specify API4 job entity in Edit Job form
Eileen McNaughton [Tue, 17 Oct 2023 18:56:59 +0000 (07:56 +1300)]
[REF] Extract add soft credit fields
Sandor Semsey [Tue, 10 Oct 2023 09:33:26 +0000 (11:33 +0200)]
Make civicrm.is_active required and default=1
colemanw [Tue, 17 Oct 2023 14:56:11 +0000 (10:56 -0400)]
Merge pull request #27844 from colemanw/managedDelete
ManagedEntities - Recreate deleted records at discretion of update policy
colemanw [Tue, 17 Oct 2023 14:40:38 +0000 (10:40 -0400)]
Merge pull request #27845 from eileenmcnaughton/crazy_if
Clarify access of `buildComponentForm`
Eileen McNaughton [Tue, 17 Oct 2023 05:59:37 +0000 (18:59 +1300)]
Update function to refer to 'this' not form
Eileen McNaughton [Tue, 17 Oct 2023 05:54:02 +0000 (18:54 +1300)]
Clarify access of buildComponentForm
This moves the function from being public on
the parent to private on the class that uses it, after doing a universe search
Yashodha Chaku [Tue, 17 Oct 2023 03:47:10 +0000 (09:17 +0530)]
Merge pull request #27843 from colemanw/managedFn
[REF] ManagedEntities - Remove unused function
colemanw [Tue, 17 Oct 2023 01:24:05 +0000 (21:24 -0400)]
ManagedEntities - Don't recreate deleted records unless update policy is 'always'
colemanw [Tue, 17 Oct 2023 00:43:14 +0000 (20:43 -0400)]
ManagedEntities - Remove unused function
Eileen McNaughton [Mon, 16 Oct 2023 23:59:01 +0000 (12:59 +1300)]
Merge pull request #27820 from colemanw/arrayCleanupContribute
[REF] CRM/Contribute - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Mon, 16 Oct 2023 22:01:37 +0000 (18:01 -0400)]
Merge pull request #27835 from colemanw/managedSchema
Managed - Minor schema fixes
colemanw [Fri, 13 Oct 2023 23:41:54 +0000 (19:41 -0400)]
CRM/Contribute - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Sun, 15 Oct 2023 20:48:37 +0000 (16:48 -0400)]
Managed - Minor schema fixes
Increase size of 'module' column to match civicrm_extension.full_name
Makes name required and longer
Makes 'cleanup' required and declares explicitly the default value previously implied
Matthew Wire [Mon, 16 Oct 2023 20:51:42 +0000 (21:51 +0100)]
Merge pull request #27774 from eileenmcnaughton/pledge_silly
Fix recursive display of payment_reminders
Matthew Wire [Mon, 16 Oct 2023 20:45:40 +0000 (21:45 +0100)]
Merge pull request #27059 from larssandergreen/Fix-PCP-validation-error-on-Contribution-Pages-&-Events
dev/core#4488 Fix PCP validation error on Contribution Pages & Events
Matthew Wire [Mon, 16 Oct 2023 20:44:42 +0000 (21:44 +0100)]
Merge pull request #27328 from colemanw/repeatingEntityCleanup
[REF] Repeating entity form code cleanup
Matthew Wire [Mon, 16 Oct 2023 20:43:18 +0000 (21:43 +0100)]
Merge pull request #27252 from vingle/JoomlaCleanup
Removes Joomla Sidebar
Matthew Wire [Mon, 16 Oct 2023 20:41:58 +0000 (21:41 +0100)]
Merge pull request #27235 from colemanw/hidden
Add custom field type Hidden
Matthew Wire [Mon, 16 Oct 2023 20:40:10 +0000 (21:40 +0100)]
Merge pull request #27569 from totten/master-setting-admin
Setting Admin - Add mixin to autogenerate a settings form
Matthew Wire [Mon, 16 Oct 2023 20:38:25 +0000 (21:38 +0100)]
Merge pull request #27648 from colemanw/polyfill
Remove es6 polyfill
Matthew Wire [Mon, 16 Oct 2023 20:37:46 +0000 (21:37 +0100)]
Merge pull request #27752 from colemanw/tagLabel
Tags - Add label field, enable tags as Managed Entities
Matthew Wire [Mon, 16 Oct 2023 20:36:36 +0000 (21:36 +0100)]
Merge pull request #27840 from colemanw/pseudoconstantCleanup
[REF] CRM_Core_Pseudoconstant - Cleanup static arrays & functions
Matthew Wire [Mon, 16 Oct 2023 20:35:56 +0000 (21:35 +0100)]
Merge pull request #27798 from colemanw/angCheck
Angular - Noisily deprecate 'settings' in favor of 'settingsFactory'
Matthew Wire [Mon, 16 Oct 2023 20:33:01 +0000 (21:33 +0100)]
Merge pull request #27822 from colemanw/arrayCleanupCampaign
[REF] CRM/Campaign - Refactor unnecessary uses of CRM_Utils_Array::value
Matthew Wire [Mon, 16 Oct 2023 20:32:35 +0000 (21:32 +0100)]
Merge pull request #27823 from colemanw/arrayCleanupAdmin
[REF] CRM/Admin - Refactor unnecessary uses of CRM_Utils_Array::value
Matthew Wire [Mon, 16 Oct 2023 20:31:21 +0000 (21:31 +0100)]
Merge pull request #27839 from colemanw/participantCount
SearchKit - Add Event.remaining_participants calculated field
Matthew Wire [Mon, 16 Oct 2023 20:29:02 +0000 (21:29 +0100)]
Merge pull request #27836 from eileenmcnaughton/php82
Php8.x fixes on Main online contribution page
Matthew Wire [Mon, 16 Oct 2023 20:26:18 +0000 (21:26 +0100)]
Merge pull request #27838 from colemanw/participantPseudoconstantCleanup
[REF] CRM_Event_PseudoConstant - Cleanup redundant caching
Tim Otten [Mon, 16 Oct 2023 18:47:11 +0000 (11:47 -0700)]
Merge pull request #27821 from colemanw/arrayCleanupEvent
[REF] CRM/Event - Refactor unnecessary uses of CRM_Utils_Array::value
Tim Otten [Mon, 16 Oct 2023 18:43:38 +0000 (11:43 -0700)]
Merge pull request #27807 from colemanw/angLoops
[REF] AngularManager - Skip extra lookups. Document function.
colemanw [Mon, 16 Oct 2023 18:33:52 +0000 (14:33 -0400)]
CRM_Core_Pseudoconstant - Cleanup static arrays & functions
colemanw [Fri, 13 Oct 2023 13:33:43 +0000 (09:33 -0400)]
AngularManager - Simplify loops
Before - unnecessarily loops through array before just setting the entire value of the array
After - skips the unnecessary loop
colemanw [Mon, 16 Oct 2023 15:35:47 +0000 (11:35 -0400)]
CRM_Event_PseudoConstant - Cleanup redundant caching
All these functions were double-caching the output of functions that already use caching.
At best this is a dumb waste of memory.
At worst it can cause bugs when the 2 caches don't get flushed together.
colemanw [Mon, 16 Oct 2023 17:02:03 +0000 (13:02 -0400)]
APIv4 - Add Event.remaining_participants calculated field
colemanw [Mon, 16 Oct 2023 14:47:39 +0000 (10:47 -0400)]
Merge pull request #27808 from colemanw/afformCleanup
[REF] AfformScanner - Update code comments & type hints
colemanw [Mon, 16 Oct 2023 14:46:51 +0000 (10:46 -0400)]
Merge pull request #27837 from colemanw/tsEvent
Participant - Translate untranslated string
colemanw [Mon, 16 Oct 2023 13:49:16 +0000 (09:49 -0400)]
Merge pull request #27775 from eileenmcnaughton/test_fix
Smarty3 Clean up test class - remove ref to internal tplParams
colemanw [Mon, 16 Oct 2023 11:48:29 +0000 (07:48 -0400)]
Participant - Translate untranslated string
colemanw [Fri, 13 Oct 2023 23:42:35 +0000 (19:42 -0400)]
CRM/Event - Refactor unnecessary uses of CRM_Utils_Array::value
Yashodha Chaku [Mon, 16 Oct 2023 05:54:45 +0000 (11:24 +0530)]
Merge pull request #27824 from colemanw/arrayCleanupPrice
[REF] CRM/Price - Refactor unnecessary uses of CRM_Utils_Array::value
Eileen McNaughton [Sun, 15 Oct 2023 21:58:32 +0000 (10:58 +1300)]
Php8.x fixes on Main online contribution page
Eileen McNaughton [Sat, 14 Oct 2023 20:57:53 +0000 (09:57 +1300)]
Php8.x bring handling of other_amount back to relevant form
Eileen McNaughton [Sun, 15 Oct 2023 21:09:36 +0000 (10:09 +1300)]
Merge pull request #27829 from eileenmcnaughton/php82
php8.2 fix undeclared properties on backoffice contribution form
colemanw [Sun, 15 Oct 2023 05:12:19 +0000 (01:12 -0400)]
Merge pull request #27819 from colemanw/arrayCleanupUtils
[REF] CRM/Utils - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Sun, 15 Oct 2023 05:12:06 +0000 (01:12 -0400)]
Merge pull request #27817 from colemanw/arrayCleanupCore
[REF] CRM/Core - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:40:31 +0000 (19:40 -0400)]
CRM/Core - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:40:59 +0000 (19:40 -0400)]
CRM/Utils - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Sun, 15 Oct 2023 03:08:08 +0000 (23:08 -0400)]
Merge pull request #27825 from colemanw/arrayCleanupActivity
[REF] CRM/Activity - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Sun, 15 Oct 2023 00:26:11 +0000 (20:26 -0400)]
Merge pull request #27814 from colemanw/managedSortable
dev/core#4364 - Don't reset weights when updating managed entity
colemanw [Sat, 14 Oct 2023 23:00:04 +0000 (19:00 -0400)]
Merge pull request #27812 from lemniscus/nullcoalesce
CRM_Utils_Array::value - remove "todo" which we don't actually want to do
Noah Miller [Sat, 14 Oct 2023 22:02:09 +0000 (18:02 -0400)]
remove "todo" which we don't actually want to do
-- throwing this error would break a lot of things.
colemanw [Sat, 14 Oct 2023 21:54:44 +0000 (17:54 -0400)]
Merge pull request #27832 from larssandergreen/Add-hooks-for-Navigations-through-writeRecord
dev/core#4364 Use writeRecord for Navigations so menu changes for managed entities don't reset
colemanw [Sat, 14 Oct 2023 21:09:01 +0000 (17:09 -0400)]
Navigation - Add deprecation notice and remove redundant serialization
Noah Miller [Sat, 14 Oct 2023 20:51:43 +0000 (16:51 -0400)]
the experiment that @colemanw suggested: reject non-array $list param
larssandergreen [Sat, 14 Oct 2023 20:35:32 +0000 (14:35 -0600)]
Use writeRecords for Navigations
colemanw [Sat, 14 Oct 2023 20:14:50 +0000 (16:14 -0400)]
Merge pull request #27811 from eileenmcnaughton/cont_form
Stop calling `CRM_Contribute_Form_Contribution::testSubmit()`, quiet deprecation
Eileen McNaughton [Sat, 14 Oct 2023 20:07:14 +0000 (09:07 +1300)]
Merge pull request #27818 from colemanw/arrayCleanupContact
[REF] CRM/Contact - Refactor unnecessary uses of CRM_Utils_Array::value
Eileen McNaughton [Sat, 14 Oct 2023 05:11:53 +0000 (18:11 +1300)]
php8.2 fix undeclared properties on backoffice contribution form
There are just 2 properties
_payNow is distinctly internal, and easily searched in universe so I made it private
- _contributionID is specifically set for the purposes of hooks - although I expect that
was more relevant when the code was shared with the front end form. However, I have
set it up to still work for now, albeit with a deprecation notice
Eileen McNaughton [Sat, 14 Oct 2023 01:16:45 +0000 (14:16 +1300)]
Fix ContribuionFormTest to use full form flow