Eileen McNaughton [Mon, 29 Nov 2021 23:41:34 +0000 (12:41 +1300)]
Prevent settings form assigned html from being escapted
colemanw [Mon, 29 Nov 2021 23:09:03 +0000 (18:09 -0500)]
Merge pull request #22074 from eileenmcnaughton/tags
[Smarty variables] Ensure groupElementType is always set
colemanw [Mon, 29 Nov 2021 23:08:07 +0000 (18:08 -0500)]
Merge pull request #22132 from eileenmcnaughton/test_con
[Smarty variables] [contact summary] Assign variable to determine whether to show email signature field
colemanw [Mon, 29 Nov 2021 23:07:39 +0000 (18:07 -0500)]
Merge pull request #22138 from eileenmcnaughton/cust_edit
[Smarty variables] [custom data form] Template notice cleanup - make sane
colemanw [Mon, 29 Nov 2021 23:06:10 +0000 (18:06 -0500)]
Merge pull request #22147 from eileenmcnaughton/pager
[Smarty variables] [report test]Ensure smarty variables are consistently assigned in report
colemanw [Mon, 29 Nov 2021 23:05:43 +0000 (18:05 -0500)]
Merge pull request #22152 from eileenmcnaughton/n1
[Smarty variables] [Activity form] Ensure separation,tag are assigned to the template
colemanw [Mon, 29 Nov 2021 23:04:36 +0000 (18:04 -0500)]
Merge pull request #22155 from eileenmcnaughton/n4
[Smarty variables] Specify isRepeatingEntity when including ConfirmRepeatMode.tpl
colemanw [Mon, 29 Nov 2021 23:02:02 +0000 (18:02 -0500)]
Merge pull request #22160 from colemanw/navigationPermission
APIv4 - Treat navigation permissions as array, add pseudoconstant for operator
Eileen McNaughton [Mon, 29 Nov 2021 21:46:08 +0000 (10:46 +1300)]
Merge pull request #22137 from colemanw/api4SortableEntity
APIv4 - Add SortableEntity type which auto-adjusts weights
Coleman Watts [Mon, 29 Nov 2021 19:26:35 +0000 (14:26 -0500)]
APIv4 - Treat navigation permissions as array, add pseudoconstant for operator
This gives consistency in how the fields are handled in the Navigation and Dashboard entities
colemanw [Mon, 29 Nov 2021 21:12:42 +0000 (16:12 -0500)]
Merge pull request #22121 from colemanw/bridgeEntitiesGoneWild
SearchKit - enable search by case role
Eileen McNaughton [Sun, 14 Nov 2021 18:23:31 +0000 (07:23 +1300)]
Ensure groupElementType is always set
Eileen McNaughton [Sun, 28 Nov 2021 06:26:38 +0000 (19:26 +1300)]
Ensure smarty variables are consistently assigned in report
Eileen McNaughton [Mon, 29 Nov 2021 19:08:35 +0000 (08:08 +1300)]
Merge pull request #22158 from colemanw/api4DeleteOptionList
APIv4 - Delete unused OptionList trait
colemanw [Mon, 29 Nov 2021 17:20:58 +0000 (12:20 -0500)]
Merge pull request #22118 from eileenmcnaughton/notices
Fix message templates screen to work with escape enabled by default
colemanw [Mon, 29 Nov 2021 15:13:51 +0000 (10:13 -0500)]
Merge pull request #22154 from eileenmcnaughton/n3
[Smarty variables] Use always-assigned isTagSet to determine if is tagset
colemanw [Mon, 29 Nov 2021 15:13:35 +0000 (10:13 -0500)]
Merge pull request #22153 from eileenmcnaughton/n2
[Smarty variables] [Activity form] Ensure activityTypeFile is always assigned
colemanw [Mon, 29 Nov 2021 15:12:25 +0000 (10:12 -0500)]
Merge pull request #22157 from eileenmcnaughton/testit
[Test] Fix tests to use form helper
colemanw [Mon, 29 Nov 2021 15:12:14 +0000 (10:12 -0500)]
Merge pull request #22156 from eileenmcnaughton/cont_tests
[Test] Test cleanup to use full-form methods
Coleman Watts [Mon, 29 Nov 2021 13:50:03 +0000 (08:50 -0500)]
APIv4 - Delete unused OptionList trait
This trait had been added for the sake of SearchKit to determine which entities should be
searchable and which were merely supplying option lists for other entities.
However, this logic broke down quickly as some option lists *should* be searchable,
so that path was abandoned in favor of the `@searchable` annotation.
The trait now does nothing and is just taking up space and adding unnecessary complexity.
Coleman Watts [Sun, 28 Nov 2021 21:14:42 +0000 (16:14 -0500)]
APIv4 - Limit SortableEntity exports by domain
Coleman Watts [Sun, 28 Nov 2021 16:06:21 +0000 (11:06 -0500)]
APIv4 - Add SortableEntity and ManagedEntity traits to Navigation menu entity
Excludes 'weight' from managed entity calculations for references,
adds unit tests for the interaction of managed entities and sortable entities
Coleman Watts [Sat, 27 Nov 2021 00:27:24 +0000 (19:27 -0500)]
Fix test for compatability with auto-weights
Coleman Watts [Fri, 26 Nov 2021 21:48:57 +0000 (16:48 -0500)]
Fix unit tests to enable components before using them
Coleman Watts [Fri, 26 Nov 2021 01:12:32 +0000 (20:12 -0500)]
SearchKit - Use order_by from metadata to supply default sort for searchDisplays
Coleman Watts [Fri, 26 Nov 2021 00:28:56 +0000 (19:28 -0500)]
APIv4 - Add SortableEntity type which auto-adjusts weights
This entity type will manage weight columns automatically, allowing items to be
re-ordered easily.
Simply by updating the weight of one record, others will auto-adjust to make room for it.
Eileen McNaughton [Mon, 29 Nov 2021 04:03:41 +0000 (17:03 +1300)]
Fix tests to use form helper
Eileen McNaughton [Mon, 29 Nov 2021 03:59:40 +0000 (16:59 +1300)]
Merge pull request #22151 from colemanw/optionValueSearch
SearchKit - Allow searches of OptionValues, LocationTypes, CustomFields
Eileen McNaughton [Mon, 29 Nov 2021 02:52:25 +0000 (15:52 +1300)]
Test cleanup to use full-form methods
Uses full form flow - via a helper
Eileen McNaughton [Mon, 29 Nov 2021 01:49:05 +0000 (14:49 +1300)]
Specify isRepeatingEntity when including ConfirmRepeatMode.tpl
Eileen McNaughton [Mon, 29 Nov 2021 01:42:40 +0000 (14:42 +1300)]
Use always-assigned isTagSet to determine if is tagset
Eileen McNaughton [Mon, 29 Nov 2021 01:43:10 +0000 (14:43 +1300)]
Ensure activityTypeFile is always assigned
Eileen McNaughton [Mon, 29 Nov 2021 01:30:24 +0000 (14:30 +1300)]
Ensure separation,tag are assigned to the template
Coleman Watts [Mon, 29 Nov 2021 01:27:17 +0000 (20:27 -0500)]
SearchKit - Enable for CustomField, CustomGroup & LocationType
Eileen McNaughton [Tue, 23 Nov 2021 22:02:30 +0000 (11:02 +1300)]
Fix message templates screen to work with escape enabled by default
Coleman Watts [Mon, 15 Nov 2021 14:47:08 +0000 (09:47 -0500)]
SearchKit - Allow searches of OptionGroups and OptionValues
Marks the entities searchable, and adds view/edit links for OptionValues
colemanw [Sun, 28 Nov 2021 23:36:09 +0000 (18:36 -0500)]
Merge pull request #22148 from eileenmcnaughton/link
Enotice fixes - ensure a couple more variables are consistently assigned
colemanw [Sun, 28 Nov 2021 23:29:57 +0000 (18:29 -0500)]
Merge pull request #22124 from eileenmcnaughton/cust
Remove isset from custom data tpls
Eileen McNaughton [Sun, 28 Nov 2021 06:41:14 +0000 (19:41 +1300)]
Enotice fixes - ensure a couple more variables are consistently assigned
Eileen McNaughton [Sun, 28 Nov 2021 06:26:38 +0000 (19:26 +1300)]
Ensure smarty variables are consistently assigned in report
Eileen McNaughton [Wed, 24 Nov 2021 01:39:32 +0000 (14:39 +1300)]
Remove isset from custom data tpls
Eileen McNaughton [Thu, 25 Nov 2021 06:40:10 +0000 (19:40 +1300)]
Assign variable to determine whether to show email signature field
This gets us around complex 'empty checks' and allows us to avoid enotices in smarty
Eileen McNaughton [Thu, 25 Nov 2021 06:59:23 +0000 (19:59 +1300)]
Ensure formal_title is assigned to the template.
This just gets past one enotice in the great juggle
Eileen McNaughton [Fri, 26 Nov 2021 01:40:03 +0000 (14:40 +1300)]
Template notice cleanup - make sane
The CRM/Custom/Form/CustomData.tpl is called with formEdit set from
1 place - CRM/Contact/Form/Edit/CustomData.tpl - when this is the
case only 1 line of code is shared with the code path if
formEdit is not true/ passed in. This is silly & can be avoided
colemanw [Sat, 27 Nov 2021 20:33:42 +0000 (15:33 -0500)]
Merge pull request #22140 from eileenmcnaughton/cust_case
Assign cgCount in Case custom data form
demeritcowboy [Sat, 27 Nov 2021 13:44:02 +0000 (08:44 -0500)]
Merge pull request #22125 from colemanw/searchKitEditing
SearchKit - Improve UX for refresh after editing
colemanw [Sat, 27 Nov 2021 06:39:18 +0000 (01:39 -0500)]
Merge pull request #21919 from braders/deprecated-jquery-xhr-usage
[REF] Remove usage of deprecated jqXHR.error in jQuery code
colemanw [Sat, 27 Nov 2021 06:34:13 +0000 (01:34 -0500)]
Merge pull request #22014 from colemanw/apiExport
APIv4 - Add export action for managed entities
colemanw [Sat, 27 Nov 2021 06:21:14 +0000 (01:21 -0500)]
Merge pull request #22139 from eileenmcnaughton/cust_opt
Ensure custom fields properties are assigned to the template
Seamus Lee [Sat, 27 Nov 2021 05:11:01 +0000 (16:11 +1100)]
Merge pull request #22145 from civicrm/5.44
5.44
colemanw [Sat, 27 Nov 2021 02:44:19 +0000 (21:44 -0500)]
Merge pull request #22141 from eileenmcnaughton/contexty
Ensure context is always assigned
Coleman Watts [Tue, 9 Nov 2021 13:57:28 +0000 (08:57 -0500)]
APIv4 - Add export action to managed entities
This action generates an exportable array suitable for use in a .mgd.php file.
Seamus Lee [Fri, 26 Nov 2021 22:04:50 +0000 (09:04 +1100)]
Merge pull request #22144 from alifrumin/rn5.44
NFC first stab at 5.44 release notes
Alice Frumin [Mon, 22 Nov 2021 18:17:31 +0000 (13:17 -0500)]
NFC release notes 5.44
Eileen McNaughton [Fri, 26 Nov 2021 03:12:51 +0000 (16:12 +1300)]
Ensure context is always assigned
Seamus Lee [Fri, 26 Nov 2021 02:59:35 +0000 (13:59 +1100)]
Merge pull request #22127 from colemanw/afformUiTweaks
FormBuilder - Hide configuration options that do not apply to certain form types
Eileen McNaughton [Fri, 26 Nov 2021 02:51:21 +0000 (15:51 +1300)]
Assign cgCount in Case custom data form
Eileen McNaughton [Fri, 26 Nov 2021 02:46:38 +0000 (15:46 +1300)]
Ensure custom fields properties are assigned to the template
Eileen McNaughton [Fri, 26 Nov 2021 01:40:03 +0000 (14:40 +1300)]
Template notice cleanup - make sane
The CRM/Custom/Form/CustomData.tpl is called with formEdit set from
1 place - CRM/Contact/Form/Edit/CustomData.tpl - when this is the
case only 1 line of code is shared with the code path if
formEdit is not true/ passed in. This is silly & can be avoided
Seamus Lee [Fri, 26 Nov 2021 00:24:35 +0000 (11:24 +1100)]
Merge pull request #22114 from colemanw/searchKitRevertButton
SearchKit - Improve search listing UI
Seamus Lee [Thu, 25 Nov 2021 23:32:40 +0000 (10:32 +1100)]
Merge pull request #22134 from eileenmcnaughton/url
Ensure CMSPrint variables are assigned to the template
Seamus Lee [Thu, 25 Nov 2021 23:32:22 +0000 (10:32 +1100)]
Merge pull request #22135 from eileenmcnaughton/pay_test
Ensure tab headers are assigned, fix widget form test
Seamus Lee [Thu, 25 Nov 2021 23:31:26 +0000 (10:31 +1100)]
Merge pull request #22136 from mlutfy/fixEventPrepositionTs
CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition
Mathieu Lutfy [Thu, 25 Nov 2021 21:13:44 +0000 (16:13 -0500)]
CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition
Eileen McNaughton [Thu, 25 Nov 2021 08:01:47 +0000 (21:01 +1300)]
Ensure tab headers are assigned, fix widget form test
This could regress notices elsewhere but I given the difficulty of getting a combo
of fixes that pass tests I think we should only worry if there are actual test fails
since most people won't see smarty notices anyway
Eileen McNaughton [Thu, 25 Nov 2021 07:41:45 +0000 (20:41 +1300)]
Ensure CMSPrint variables are assigned to the template
Eileen McNaughton [Thu, 25 Nov 2021 06:40:10 +0000 (19:40 +1300)]
Assign variable to determine whether to show email signature field
This gets us around complex 'empty checks' and allows us to avoid enotices in smarty
Seamus Lee [Wed, 24 Nov 2021 22:19:40 +0000 (09:19 +1100)]
Merge pull request #22128 from eileenmcnaughton/cus
Ensure buildForm is called to assign values
Seamus Lee [Wed, 24 Nov 2021 21:10:27 +0000 (08:10 +1100)]
Merge pull request #22131 from civicrm/5.44
5.44
colemanw [Wed, 24 Nov 2021 19:30:00 +0000 (14:30 -0500)]
Merge pull request #22130 from colemanw/fixSearchKitHaving
SearchKit - Fix selecting HAVING operator
colemanw [Wed, 24 Nov 2021 17:47:27 +0000 (12:47 -0500)]
Merge pull request #22129 from kurund/patch-4
Update Fields.tpl
Coleman Watts [Wed, 24 Nov 2021 16:59:22 +0000 (11:59 -0500)]
SearchKit - Fix selecting HAVING operator
Fixes dev/core#2954 by gracefully handling field values when no field exists
Kurund Jalmi [Wed, 24 Nov 2021 16:00:14 +0000 (16:00 +0000)]
Update Fields.tpl
Yashodha Chaku [Wed, 24 Nov 2021 15:56:21 +0000 (21:26 +0530)]
Merge pull request #22122 from agileware/CIVICRM-1894
CiviCRM Event, remove the superfluous "Are you sure you want to delete this Event?" confirmation for the Event delete action
Eileen McNaughton [Wed, 24 Nov 2021 06:31:04 +0000 (19:31 +1300)]
Ensure buildForm is called to assign values
Seamus Lee [Wed, 24 Nov 2021 06:00:09 +0000 (17:00 +1100)]
Merge pull request #22126 from colemanw/deleteAfformHtmlExt
Update Afform & search kit info
colemanw [Wed, 24 Nov 2021 05:06:27 +0000 (00:06 -0500)]
Merge pull request #22007 from joapta/feature/add-missing-colombia-state
Add Colombia missing state
colemanw [Wed, 24 Nov 2021 05:05:35 +0000 (00:05 -0500)]
Merge pull request #22123 from eileenmcnaughton/act
Test fix - use more 'real' rendering function
colemanw [Wed, 24 Nov 2021 05:02:22 +0000 (00:02 -0500)]
Merge pull request #22116 from jensschuppe/virtualEntities/getEntityNameForTable
Use getEntityNameForTable() instead of getClassForTable(), as this might yield ambiguous results
Coleman Watts [Wed, 24 Nov 2021 03:39:10 +0000 (22:39 -0500)]
FormBuilder - Hide configuration options that do not apply to certain form types
Seamus Lee [Wed, 24 Nov 2021 03:35:00 +0000 (14:35 +1100)]
Merge pull request #21589 from agileware/CIVICRM-1804
Suppresses error logging on every page load when open_basedir restriction in effect: File(/CRM/Core/Smarty/plugins/) is not within the allowed path(s)
Coleman Watts [Wed, 24 Nov 2021 03:20:38 +0000 (22:20 -0500)]
Update afform & search kit info
jptaszynska [Mon, 8 Nov 2021 10:14:02 +0000 (11:14 +0100)]
Add Colombia missing state
colemanw [Wed, 24 Nov 2021 02:36:27 +0000 (21:36 -0500)]
Merge pull request #22087 from agileware/CIVICRM-1887
SearchKit with Form Builder when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail
Coleman Watts [Wed, 24 Nov 2021 02:25:58 +0000 (21:25 -0500)]
AllCoreTables - Fix getClassForTable in multilingual databases
Coleman Watts [Tue, 23 Nov 2021 21:02:43 +0000 (16:02 -0500)]
APIv4 - Enrich EntityBridge metadata to permit more than 2 bridge joins
This allows the RelationshipCache entity to bridge not only Contact to Contact
but also Contact to Case.
Coleman Watts [Tue, 23 Nov 2021 02:16:46 +0000 (21:16 -0500)]
SearchKit - Cleanup hardcoded references to 'Contact'
Coleman Watts [Wed, 24 Nov 2021 01:57:24 +0000 (20:57 -0500)]
SearchKit - Improve UX for refresh after editing
After bulk-editing or in-place-editing, ensures the pager count is correctly updated.
Does the update and refresh for in-place-edit in a single ajax request, without the loading placeholders.
Eileen McNaughton [Wed, 24 Nov 2021 01:28:53 +0000 (14:28 +1300)]
Test fix - use more 'real' rendering function
Justin Freeman [Wed, 24 Nov 2021 01:20:25 +0000 (12:20 +1100)]
CIVICRM-1894 CiviCRM Event, remove the superfluous "Are you sure you want to delete this Event?" confirmation for the Event delete action
Eileen McNaughton [Wed, 24 Nov 2021 01:10:44 +0000 (14:10 +1300)]
Merge pull request #22119 from eileenmcnaughton/frontpage
Bypass any default escaping for blog, getting started
Eileen McNaughton [Wed, 24 Nov 2021 01:09:46 +0000 (14:09 +1300)]
Merge pull request #22120 from eileenmcnaughton/address
Do not use default escaping on address display
Justin Freeman [Fri, 24 Sep 2021 04:12:36 +0000 (14:12 +1000)]
CIVICRM-1804 Suppresses error logging on every page load when open_basedir restriction in effect: File(/CRM/Core/Smarty/plugins/) is not within the allowed path(s)
Eileen McNaughton [Tue, 23 Nov 2021 22:53:21 +0000 (11:53 +1300)]
Do not use default escaping on address display
This has vcard html in it and so breaks if default escaping is enabled
Eileen McNaughton [Tue, 23 Nov 2021 22:34:10 +0000 (11:34 +1300)]
Bypass any default escaping for blog, getting started
This specifies that default escaping should not apply to the blog, getting started.
I added purify to the data coming from the blog - this is our blog so should be
safe but it is techically 3rd part data
demeritcowboy [Tue, 23 Nov 2021 22:32:33 +0000 (17:32 -0500)]
Merge pull request #22079 from eileenmcnaughton/options
Remove issets from Options.tpl
colemanw [Tue, 23 Nov 2021 20:56:01 +0000 (15:56 -0500)]
Merge pull request #22070 from eileenmcnaughton/test_id
Throw spaghetti
demeritcowboy [Tue, 23 Nov 2021 15:02:16 +0000 (10:02 -0500)]
Merge pull request #21944 from masetto/unit_plural
fix unit plural in contribution page
Jens Schuppe [Tue, 23 Nov 2021 12:12:16 +0000 (13:12 +0100)]
Use getEntityNameForTable() instead of getClassForTable(), as this might yield ambiguous results
Samuele Masetto [Sat, 30 Oct 2021 17:14:53 +0000 (19:14 +0200)]
fix unit plural in contribution page
style fixes for compiling check
fix a typo
fix `recur_frequency_unit` hidden field value when there is only one unit option