William Mortada [Fri, 10 Jan 2020 13:44:31 +0000 (13:44 +0000)]
Fix auto renew text
Matthew Wire [Fri, 10 Jan 2020 11:37:36 +0000 (11:37 +0000)]
Merge pull request #15306 from bhahumanists/bhahumanists-mailingID
#1253 Pass mailing id to alterMailContent hook
Matthew Wire [Fri, 10 Jan 2020 11:35:35 +0000 (11:35 +0000)]
Merge pull request #16195 from demeritcowboy/activityview-recent-items
dev/core#1507 Fix recent items for viewing Email activities from contact activities tab
Seamus Lee [Fri, 10 Jan 2020 06:30:09 +0000 (17:30 +1100)]
Merge pull request #16257 from colemanw/index
Add more functionality to the api4 $index param
Seamus Lee [Fri, 10 Jan 2020 06:29:43 +0000 (17:29 +1100)]
Merge pull request #16264 from MegaphoneJon/soft-credit-hooks
Add pre/post hooks on ContributionSoft entity
Jon Goldberg [Thu, 9 Jan 2020 22:34:13 +0000 (17:34 -0500)]
Add pre/post hooks on ContributionSoft entity
Coleman Watts [Fri, 10 Jan 2020 01:14:50 +0000 (20:14 -0500)]
Add unit test for Civi\Api4\Utils\ReflectionUtils::parseDocBlock
Coleman Watts [Thu, 9 Jan 2020 22:35:30 +0000 (17:35 -0500)]
Test fix - legacy api4 wrapper should always return id
Seamus Lee [Thu, 9 Jan 2020 22:40:28 +0000 (09:40 +1100)]
Merge pull request #15318 from jitendrapurohit/dev-1263
dev/drupal#89 - Drupal 8 - Contact Report does not load any values in…
Eileen McNaughton [Thu, 9 Jan 2020 21:31:52 +0000 (10:31 +1300)]
Merge pull request #16258 from samuelsov/i18ncountriesorder
Country/State PseudoConstant not sorted according to the locale
Eileen McNaughton [Thu, 9 Jan 2020 20:59:31 +0000 (09:59 +1300)]
Merge pull request #16148 from mattwire/contributionpayment_fullrefund
Set contribution status to refunded when it has been refunded
Matthew Wire [Thu, 9 Jan 2020 20:45:51 +0000 (20:45 +0000)]
Merge pull request #16251 from eileenmcnaughton/line_clean
[REF] Remove never-passed param from getLineItems
Matthew Wire [Thu, 9 Jan 2020 20:41:39 +0000 (20:41 +0000)]
Merge pull request #16253 from eileenmcnaughton/mem_val2
Add tax rates to metadata
Matthew Wire [Thu, 9 Jan 2020 20:38:21 +0000 (20:38 +0000)]
Merge pull request #16247 from eileenmcnaughton/dedupe4
[REF] Extract location wrangling code.
Matthew Wire [Thu, 9 Jan 2020 20:35:31 +0000 (20:35 +0000)]
Merge pull request #16254 from eileenmcnaughton/partial_pay
[REF] rename lineItem & lineItems variable
Seamus Lee [Thu, 9 Jan 2020 20:33:01 +0000 (07:33 +1100)]
Merge pull request #16240 from MegaphoneJon/core-1512
core#1512: Address ID should be exportable
Seamus Lee [Thu, 9 Jan 2020 20:32:31 +0000 (07:32 +1100)]
Merge pull request #16208 from mattwire/activitytokensfixcaseid
Fix activity.case_id token to always display the first case ID
Matthew Wire [Thu, 9 Jan 2020 20:31:49 +0000 (20:31 +0000)]
Merge pull request #16252 from eileenmcnaughton/line_items_by
[REF] Move use of priceSetID & amount_override to where they are used
Samuel Vanhove [Thu, 9 Jan 2020 17:54:51 +0000 (12:54 -0500)]
Country/Region PseudoConstant not sorted according to the locale
Jon Goldberg [Wed, 8 Jan 2020 23:01:00 +0000 (18:01 -0500)]
core#1512: Address ID should be exportable
Coleman Watts [Thu, 9 Jan 2020 16:44:39 +0000 (11:44 -0500)]
Improve civicrm_api4 docblock and use it for help display in Explorer
eileen [Thu, 2 Jan 2020 22:03:04 +0000 (11:03 +1300)]
Add tax rates to metadata
This doesn't do anything by itself but it lays the foundation for a solid fix for
https://github.com/civicrm/civicrm-core/pull/15895 - ie by having minimum_fee_with_tax as part of our
generally available metadata we get out of all the complexity of doing this in the js layer - which is
what is driving that bug
Jitendra Purohit [Thu, 9 Jan 2020 12:38:17 +0000 (18:08 +0530)]
Unit test for #16148
Matthew Wire [Mon, 23 Dec 2019 22:59:13 +0000 (22:59 +0000)]
Set contribution status to refunded when it has previously been fully paid and now payments add up to 0
eileen [Thu, 9 Jan 2020 11:55:17 +0000 (00:55 +1300)]
[REF] rename lineItem & lineItems variable
Readability fix -
=======Before========
refers to an array of lineItems, refers to a single lineItem
=======After
refers to an array of line items, refers to the single (created) line itmem
eileen [Thu, 9 Jan 2020 07:01:04 +0000 (20:01 +1300)]
Move use of priceSetID & amount_override to where they are used
The field name is misleading since it implies it is useful in general to pass in a priceSetID - however, it has
a very specific usage & meaning & ideally we would deprecate it in favour of something more readable. For now
group the code more logically & comment it
Matthew Wire [Thu, 9 Jan 2020 11:07:33 +0000 (11:07 +0000)]
Merge pull request #16059 from eileenmcnaughton/mem_val2
[REF] Cleanup CRM_Member_BAO_Membership::buildMembershipTypeValues
Seamus Lee [Thu, 9 Jan 2020 09:13:20 +0000 (20:13 +1100)]
Merge pull request #16249 from eileenmcnaughton/ex_exclosed
[REF] Remove enclosed & escaped variables
Seamus Lee [Thu, 9 Jan 2020 09:06:48 +0000 (20:06 +1100)]
Merge pull request #16248 from eileenmcnaughton/cc
[NFC] Code comments
Seamus Lee [Thu, 9 Jan 2020 09:06:04 +0000 (20:06 +1100)]
Merge pull request #16250 from eileenmcnaughton/member
[NFC] Minor cleanup in test class
Jitendra Purohit [Wed, 18 Sep 2019 07:12:51 +0000 (12:42 +0530)]
dev/core#1263 - Drupal 8 - Contact Report does not load any values in the ACL Group/Role field
eileen [Thu, 9 Jan 2020 05:33:16 +0000 (18:33 +1300)]
[REF] Remove never-passed param from getLineItems
Parameter was added to getLineItems in https://github.com/civicrm/civicrm-core/commit/
25d0c6478ee236a4ac150e8d2b39614602ca4ae8
to support invoicing. However that function no longer calls getLineItems & has not for some time (at least a year). No other functions
pass in this parameter so we can remove it
Eileen McNaughton [Thu, 9 Jan 2020 05:16:36 +0000 (18:16 +1300)]
Merge pull request #16245 from eileenmcnaughton/dedupe1
[REF] Minor code simplification in dedupe.
eileen [Thu, 9 Jan 2020 04:54:31 +0000 (17:54 +1300)]
[NFC] Minor cleanup in test class
eileen [Mon, 25 Nov 2019 03:55:54 +0000 (16:55 +1300)]
Code comments
eileen [Mon, 25 Nov 2019 04:41:47 +0000 (17:41 +1300)]
Remove enclosed variable.
Given that it can only ever be a double quote parameterizing it is only confusing
eileen [Thu, 9 Jan 2020 04:07:23 +0000 (17:07 +1300)]
[REF] Extract location wrangling code.
Note I have deliberately kept this extraction as vanilla as possible wtih the goal being to rationalise in
later iterations
Coleman Watts [Thu, 9 Jan 2020 03:22:37 +0000 (22:22 -0500)]
Support index param as array in api explorer
Coleman Watts [Thu, 9 Jan 2020 03:13:57 +0000 (22:13 -0500)]
civicrm_api4 - Extend functionality of index param
Passing an array allows you to return a single result column, with automatic handling of the select clause.
eileen [Thu, 9 Jan 2020 03:08:15 +0000 (16:08 +1300)]
[REF] Minor code simplification in dedupe.
This just tweaks readability by
1) adding a variable for a value nested fairly deeply in an array
2) removing the foundField handling in favour of a ternary since
it's kinda confusing as is
Seamus Lee [Thu, 9 Jan 2020 02:21:23 +0000 (13:21 +1100)]
Merge pull request #15475 from mecachisenros/externUrl
dev/core#1100 Add externUrl method and civicrm_alterExternUrl hook
Seamus Lee [Thu, 9 Jan 2020 02:19:08 +0000 (13:19 +1100)]
Merge pull request #16231 from mfb/imap-batch-size
Remove patch hunk now that zetacomponents/Mail#73 has been merged
Seamus Lee [Thu, 9 Jan 2020 02:11:55 +0000 (13:11 +1100)]
Merge pull request #16241 from eileenmcnaughton/sess
[REF] move sessionStart functionality to System subclass
Eileen McNaughton [Thu, 9 Jan 2020 01:21:59 +0000 (14:21 +1300)]
Merge pull request #16242 from civicrm/5.22
5.22 to master
Eileen McNaughton [Thu, 9 Jan 2020 01:19:52 +0000 (14:19 +1300)]
Merge pull request #16239 from MegaphoneJon/mailing-60-522
mailing#60: Fix regression where `is_bulkmail` flag isn't respected
Coleman Watts [Thu, 9 Jan 2020 01:11:04 +0000 (20:11 -0500)]
civicrm_api4 - auto-adjust select query when passing an index
Tim Otten [Thu, 9 Jan 2020 00:27:11 +0000 (16:27 -0800)]
Merge pull request #15778 from agh1/reminder-do-not-email-test
dev/core#1378 Scheduled reminders: do not email if do_not_email or on_hold
eileen [Wed, 8 Jan 2020 23:07:25 +0000 (12:07 +1300)]
[REF] move sessionStart functionality to System subclass
Preparatory to https://github.com/civicrm/civicrm-core/pull/15131/files
Seamus Lee [Wed, 8 Jan 2020 22:47:27 +0000 (09:47 +1100)]
Merge pull request #16105 from seamuslee001/dev_core_522_204
dev/core#522 CRM-19767 dev/core#204 Add Case Tokens to emails
Seamus Lee [Wed, 8 Jan 2020 22:44:08 +0000 (09:44 +1100)]
Merge pull request #15969 from eileenmcnaughton/utfmb8
Add utf8 to utfmb8 conversion api command
Seamus Lee [Wed, 8 Jan 2020 22:36:46 +0000 (09:36 +1100)]
Merge pull request #16234 from demeritcowboy/more-t6
dev/core#495 Make admin settings field labels translatable
Eileen McNaughton [Wed, 8 Jan 2020 22:36:25 +0000 (11:36 +1300)]
Merge pull request #16235 from demeritcowboy/more-t7
dev/core#495 Make admin settings field labels translatable
Eileen McNaughton [Wed, 8 Jan 2020 22:36:09 +0000 (11:36 +1300)]
Merge pull request #16236 from demeritcowboy/more-t8
dev/core#495 Make admin settings field labels translatable
Eileen McNaughton [Wed, 8 Jan 2020 22:35:56 +0000 (11:35 +1300)]
Merge pull request #16237 from demeritcowboy/more-t9
dev/core#495 Make admin settings field labels translatable
Seamus Lee [Wed, 8 Jan 2020 22:35:49 +0000 (09:35 +1100)]
Merge pull request #16233 from demeritcowboy/more-t5
dev/core#495 Make admin settings field labels translatable
Seamus Lee [Wed, 8 Jan 2020 22:35:38 +0000 (09:35 +1100)]
Merge pull request #16232 from demeritcowboy/more-t4
dev/core#495 Make admin settings field labels translatable
Jon Goldberg [Tue, 7 Jan 2020 18:53:52 +0000 (13:53 -0500)]
mailing#60: Fix regression where multiple bulk recipient option isn't respected
test fixes
demeritcowboy [Wed, 8 Jan 2020 20:38:20 +0000 (15:38 -0500)]
make translatable
demeritcowboy [Wed, 8 Jan 2020 20:36:40 +0000 (15:36 -0500)]
make translatable
Eileen McNaughton [Wed, 8 Jan 2020 20:35:37 +0000 (09:35 +1300)]
Merge pull request #16228 from demeritcowboy/more-t2
dev/core#495 Make admin settings field labels translatable
Eileen McNaughton [Wed, 8 Jan 2020 20:33:19 +0000 (09:33 +1300)]
Merge pull request #16229 from demeritcowboy/more-t3
dev/core#495 Make admin settings field labels translatable
demeritcowboy [Wed, 8 Jan 2020 20:30:48 +0000 (15:30 -0500)]
make translatable
demeritcowboy [Wed, 8 Jan 2020 20:19:10 +0000 (15:19 -0500)]
make translatable
demeritcowboy [Wed, 8 Jan 2020 20:13:32 +0000 (15:13 -0500)]
make translatable
demeritcowboy [Wed, 8 Jan 2020 20:06:37 +0000 (15:06 -0500)]
make translatable
mark burdett [Wed, 8 Jan 2020 17:56:18 +0000 (09:56 -0800)]
Update and remove patch hunk now that zetacomponents/Mail#73 was merged.
demeritcowboy [Wed, 8 Jan 2020 14:36:28 +0000 (09:36 -0500)]
make translatable
demeritcowboy [Wed, 8 Jan 2020 14:30:31 +0000 (09:30 -0500)]
make translatable
Matthew Wire [Wed, 8 Jan 2020 10:25:23 +0000 (10:25 +0000)]
Merge pull request #16227 from demeritcowboy/more-t
dev/core#495 Make admin settings field labels translatable
demeritcowboy [Wed, 8 Jan 2020 06:19:57 +0000 (01:19 -0500)]
make translatable
Eileen McNaughton [Tue, 7 Jan 2020 23:10:45 +0000 (12:10 +1300)]
Merge pull request #16220 from colemanw/checkmark
Change check.gif to an actual gif (was a PNG)
Eileen McNaughton [Tue, 7 Jan 2020 23:10:16 +0000 (12:10 +1300)]
Merge pull request #16222 from colemanw/importable
Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata
Eileen McNaughton [Tue, 7 Jan 2020 23:08:13 +0000 (12:08 +1300)]
Merge pull request #16226 from civicrm/5.22
5.22 to master
Eileen McNaughton [Tue, 7 Jan 2020 23:06:35 +0000 (12:06 +1300)]
Merge pull request #16225 from demeritcowboy/contribution-view-missing-status
dev/core#1508 Regression/E_NOTICE - Missing table on contribution view
Eileen McNaughton [Tue, 7 Jan 2020 23:02:29 +0000 (12:02 +1300)]
Merge pull request #16224 from eileenmcnaughton/set
dev/core#495 Add some ts tags on settings
demeritcowboy [Tue, 7 Jan 2020 21:07:25 +0000 (16:07 -0500)]
put back mistakenly removed variable
eileen [Tue, 7 Jan 2020 19:32:19 +0000 (08:32 +1300)]
dev/core#495 Add some ts tags on settings
Coleman Watts [Tue, 7 Jan 2020 18:25:05 +0000 (13:25 -0500)]
Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata
This squares up the recently added metadata with a hardcoded list in the BAO,
removing the hardcoded list in favor of metadata.
Eileen McNaughton [Tue, 7 Jan 2020 04:26:07 +0000 (17:26 +1300)]
Merge pull request #15307 from seamuslee001/dev_core_1249
dev/core#1249 Allow IPNs to be validated even if the supplied contact…
Seamus Lee [Tue, 7 Jan 2020 03:43:48 +0000 (14:43 +1100)]
Merge pull request #15670 from eileenmcnaughton/dupe_locks
dev/core#1355 Add contention handling for dedupe jobs
Seamus Lee [Tue, 7 Jan 2020 03:30:50 +0000 (14:30 +1100)]
Merge pull request #15948 from eileenmcnaughton/export_test
Revised version of test from #15725
Seamus Lee [Tue, 7 Jan 2020 02:40:51 +0000 (13:40 +1100)]
Merge pull request #16219 from seamuslee001/nfc_test_followup_16150
[NFC] Test update following PR #16150, assertEquals first param is th…
Coleman Watts [Tue, 7 Jan 2020 02:04:04 +0000 (21:04 -0500)]
Change check.gif to an actual gif (was a PNG)
Seamus Lee [Tue, 7 Jan 2020 01:36:22 +0000 (12:36 +1100)]
[NFC] Test update following PR #16150, assertEquals first param is the expected value not the current value
Seamus Lee [Tue, 7 Jan 2020 01:33:58 +0000 (12:33 +1100)]
Merge pull request #16150 from jitendrapurohit/dev-1499
dev/core#1499 - Case Resource shows contact names that are not access…
Seamus Lee [Tue, 7 Jan 2020 01:30:46 +0000 (12:30 +1100)]
Merge pull request #15855 from eileenmcnaughton/test_dep
Deprecate creating partially paid contributions, other than by partially paying a contribution.
Seamus Lee [Tue, 7 Jan 2020 01:24:03 +0000 (12:24 +1100)]
Merge pull request #16218 from seamuslee001/nfc_add_more_asserts_change_fee_selection
[NFC] Add in more assertions around the content of line items and tot…
Seamus Lee [Mon, 6 Jan 2020 23:48:21 +0000 (10:48 +1100)]
[NFC] Add in more assertions around the content of line items and total amount of the contribution record
Eileen McNaughton [Mon, 6 Jan 2020 21:14:36 +0000 (10:14 +1300)]
Merge pull request #16198 from seamuslee001/parent_fetchall
[REF] Update fetchAll function signature to match parent function
Eileen McNaughton [Mon, 6 Jan 2020 20:23:41 +0000 (09:23 +1300)]
Merge pull request #16213 from seamuslee001/error_handling_fix
Fix Error handling following DB Package upgrade
Monish Deb [Mon, 6 Jan 2020 08:21:37 +0000 (13:51 +0530)]
Merge pull request #16201 from seamuslee001/dev_core_1143_2
dev/core#1143 Support MySQL 8 by wrapping the word groups around in b…
Monish Deb [Mon, 6 Jan 2020 03:43:40 +0000 (09:13 +0530)]
Merge pull request #16202 from seamuslee001/mysql_8_information_schema
dev/core#392 Fix FTS INNDOB indexer query to work in MySQL 8 as well …
Monish Deb [Mon, 6 Jan 2020 03:03:41 +0000 (08:33 +0530)]
Merge pull request #16214 from seamuslee001/mysql_8_upgrade
dev/core#1143 Fix Upgrade tests on MySQL 8 by quoting reserved words
Seamus Lee [Mon, 6 Jan 2020 01:27:48 +0000 (12:27 +1100)]
Merge pull request #16211 from seamuslee001/wordpress_2
dev/WordPress#2 Modify the WordPress plugin version using distmaker
Seamus Lee [Sun, 5 Jan 2020 23:21:41 +0000 (10:21 +1100)]
Merge pull request #16197 from demeritcowboy/group-recent-items
dev/core#1506 Fix blank group title in recent items list when editing description inline
Seamus Lee [Sun, 5 Jan 2020 20:58:28 +0000 (07:58 +1100)]
dev/core#1143 Fix Upgrade tests on MySQL 8 by quoting reserved words
Seamus Lee [Sun, 5 Jan 2020 20:44:35 +0000 (07:44 +1100)]
Fix Error handling following DB Package upgrade
Seamus Lee [Sun, 5 Jan 2020 00:45:19 +0000 (11:45 +1100)]
Merge pull request #16210 from mattwire/caseformactivity_simplifyif
REF Simplify if statement on case activity form
Seamus Lee [Sat, 4 Jan 2020 22:27:18 +0000 (09:27 +1100)]
Modify the plugin version using distmaker
Seamus Lee [Fri, 3 Jan 2020 20:50:40 +0000 (07:50 +1100)]
dev/core#1143 Support MySQL 8 by wrapping the word groups around in backticks as it is now a reserved word