Tim Otten [Wed, 17 Aug 2022 07:05:28 +0000 (00:05 -0700)]
Extract LocaleTestTrait from CiviUnitTestCase. Add more helpers.
Tim Otten [Wed, 17 Aug 2022 03:53:25 +0000 (20:53 -0700)]
Merge pull request #24258 from seamuslee001/authx_debug_test
[NFC] Add in Further debugging to authx test to try and debug issue o…
Eileen McNaughton [Wed, 17 Aug 2022 03:03:27 +0000 (15:03 +1200)]
Merge pull request #24284 from totten/master-nfc-locale
(NFC) Mark various tests with `@group locale`
Eileen McNaughton [Wed, 17 Aug 2022 03:00:41 +0000 (15:00 +1200)]
Merge pull request #24285 from eileenmcnaughton/import_dec
Add 'Entity' to the information import parser classes provide
colemanw [Wed, 17 Aug 2022 02:52:51 +0000 (22:52 -0400)]
Merge pull request #24054 from eileenmcnaughton/msg_workflow
Update references to 'workflow' (from old 'valueName' parameter)
colemanw [Wed, 17 Aug 2022 02:11:31 +0000 (22:11 -0400)]
Merge pull request #24283 from totten/master-api4-passes
(REF) Extract compiler passes from CRM_Api4_Services
colemanw [Wed, 17 Aug 2022 02:02:10 +0000 (22:02 -0400)]
Merge pull request #24279 from eileenmcnaughton/get_part_fields
Remove now-unused addField from Participant import
colemanw [Wed, 17 Aug 2022 01:52:03 +0000 (21:52 -0400)]
Merge pull request #24275 from eileenmcnaughton/dao_prim
Update DAO to use declared primary field, do not assume...
colemanw [Wed, 17 Aug 2022 01:49:34 +0000 (21:49 -0400)]
Merge pull request #24254 from colemanw/mailingTask
SearchKit - Add contacts to mailing group in batches
colemanw [Wed, 17 Aug 2022 01:48:40 +0000 (21:48 -0400)]
Merge pull request #24186 from colemanw/groupContactPerm
APIv4 - Fix GroupContact permission to use standard ACLs
Eileen McNaughton [Wed, 17 Aug 2022 00:53:40 +0000 (12:53 +1200)]
Merge pull request #24280 from eileenmcnaughton/cust_err
Importer - Remove unused functions (`isErrorInCustomData`, `getSubtypes`, `validateCustomField`)
Eileen McNaughton [Wed, 17 Aug 2022 00:52:53 +0000 (12:52 +1200)]
Merge pull request #24281 from eileenmcnaughton/tim
(REF) I18nSubscriber - Rename parameter to be more evocative
Tim Otten [Tue, 16 Aug 2022 23:39:09 +0000 (16:39 -0700)]
Merge pull request #24274 from eileenmcnaughton/flush
AllCoreTables - Dismbiguate `init `and `flush`
Seamus Lee [Mon, 15 Aug 2022 08:16:38 +0000 (08:16 +0000)]
[NFC] Add in Further debugging to authx test to try and debug issue on php8.1
Eileen McNaughton [Tue, 16 Aug 2022 23:34:52 +0000 (11:34 +1200)]
Add 'Entity' to the information import classes provide
Tim Otten [Mon, 15 Aug 2022 23:51:00 +0000 (16:51 -0700)]
(REF) Define SpecProviderPass (extracted from CRM_Api4_Services)
The `CRM_Api4_Services` implementation has a secret behavior that applies
to all services - it detects the tag 'spec_provider' and registers
with the spec-gatherer.
This kind of behavior is often implemented as "compiler pass" and given its
own documentation.
Tim Otten [Mon, 15 Aug 2022 23:32:04 +0000 (16:32 -0700)]
(REF) Define EventScannerPass (extracted from CRM_Api4_Services)
The `CRM_Api4_Services` implementation has a secret behavior that applies
to all services - it detects the tag 'event_subscriber' and registers with
the dispatcher.
This kind of behavior is often implemented as "compiler pass" and given its
own documentation.
Tim Otten [Wed, 3 Aug 2022 05:00:23 +0000 (22:00 -0700)]
(REF) I18nSubscriber - Rename parameter to be more evocative
Eileen McNaughton [Tue, 16 Aug 2022 20:40:16 +0000 (08:40 +1200)]
Remove getSubTypes
Eileen McNaughton [Tue, 16 Aug 2022 20:36:50 +0000 (08:36 +1200)]
Remove further unused function
Eileen McNaughton [Tue, 16 Aug 2022 20:34:18 +0000 (08:34 +1200)]
Remove function only called from unittest
Eileen McNaughton [Tue, 16 Aug 2022 20:23:31 +0000 (08:23 +1200)]
Remove now-unused addField from Participant import
Tim Otten [Mon, 8 Aug 2022 09:24:33 +0000 (02:24 -0700)]
(NFC) Mark various tests with `@group locale`
Note: There seems to be some weirdness when running the full-group. But breaking down by a couple folders may help:
```
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/api/ --debug --group locale --stop-on-failure
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/CRM/ --debug --group locale --stop-on-failure
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/Civi/ --debug --group locale --stop-on-failure
```
demeritcowboy [Tue, 16 Aug 2022 15:14:27 +0000 (11:14 -0400)]
Merge pull request #24269 from eileenmcnaughton/msg
Unhide message_admin extension
colemanw [Tue, 16 Aug 2022 13:31:09 +0000 (09:31 -0400)]
Merge pull request #24273 from eileenmcnaughton/imp_has_loc
Remove last usage of `_fields` from `Import_Parser`
Eileen McNaughton [Tue, 16 Aug 2022 11:51:52 +0000 (23:51 +1200)]
Update RuleGroupTest to flush sanely
Eileen McNaughton [Tue, 16 Aug 2022 08:55:50 +0000 (20:55 +1200)]
Update DynamicAuthorizationTest to flush sanely
Eileen McNaughton [Tue, 16 Aug 2022 01:32:08 +0000 (13:32 +1200)]
Also merge in reinitializeCache
Eileen McNaughton [Tue, 16 Aug 2022 01:18:56 +0000 (13:18 +1200)]
Dismbiguate init and flush
Eileen McNaughton [Tue, 16 Aug 2022 07:34:26 +0000 (19:34 +1200)]
Update DAO to use declared primary field, do not assume...
Eileen McNaughton [Mon, 15 Aug 2022 22:40:48 +0000 (10:40 +1200)]
Rename function
Eileen McNaughton [Mon, 15 Aug 2022 22:38:54 +0000 (10:38 +1200)]
Make property private
Eileen McNaughton [Mon, 15 Aug 2022 22:36:56 +0000 (10:36 +1200)]
Remove last usage of _fields
Seamus Lee [Tue, 16 Aug 2022 04:13:36 +0000 (14:13 +1000)]
Merge pull request #24266 from demeritcowboy/case-revision-warning
dev/core#1532 - Add upgrade message about civicase activity revisions
Seamus Lee [Tue, 16 Aug 2022 04:13:22 +0000 (14:13 +1000)]
Merge pull request #24244 from colemanw/case_id
APIv4 - Add `case_id` field to Activity entity
colemanw [Tue, 16 Aug 2022 02:52:39 +0000 (22:52 -0400)]
Merge pull request #24272 from eileenmcnaughton/leg_act
Remove another three no-longer-used functions
colemanw [Tue, 16 Aug 2022 02:50:39 +0000 (22:50 -0400)]
Merge pull request #24270 from eileenmcnaughton/pseudos
Fix use of legacy pseudoConstant methods
colemanw [Tue, 16 Aug 2022 02:48:20 +0000 (22:48 -0400)]
Merge pull request #24271 from eileenmcnaughton/leg_select
Remove no-longer-used function
demeritcowboy [Tue, 16 Aug 2022 01:29:33 +0000 (21:29 -0400)]
Merge pull request #24134 from mattwire/customgroupcasesensitive
Case-insensitive match on subtypes when validating subtype by entity for custom groups
demeritcowboy [Mon, 15 Aug 2022 20:13:06 +0000 (16:13 -0400)]
add upgrade message
colemanw [Mon, 15 Aug 2022 23:58:38 +0000 (19:58 -0400)]
Merge pull request #24154 from totten/master-setting-validate
SettingsStyleTest - Stop the madness
Coleman Watts [Mon, 15 Aug 2022 23:20:57 +0000 (19:20 -0400)]
Add test for case_id token
Eileen McNaughton [Mon, 15 Aug 2022 22:29:04 +0000 (10:29 +1200)]
Finish removing refs to unused activeFields
Eileen McNaughton [Mon, 15 Aug 2022 22:25:28 +0000 (10:25 +1200)]
Remove setActiveField
Eileen McNaughton [Mon, 15 Aug 2022 22:24:04 +0000 (10:24 +1200)]
Remove another no-longer-used function
Eileen McNaughton [Mon, 15 Aug 2022 22:18:11 +0000 (10:18 +1200)]
Remove no-longer-used function
Eileen McNaughton [Mon, 15 Aug 2022 22:09:29 +0000 (10:09 +1200)]
Fix use of legacy pseudoConstant methods
Eileen McNaughton [Mon, 15 Aug 2022 21:50:54 +0000 (09:50 +1200)]
Unhide message_admin extension
colemanw [Mon, 15 Aug 2022 20:04:31 +0000 (16:04 -0400)]
Merge pull request #24217 from eileenmcnaughton/map
[Import] [Ref] Extract shared form rule code
Eileen McNaughton [Mon, 15 Aug 2022 19:42:23 +0000 (07:42 +1200)]
Remove token case_id handling
demeritcowboy [Mon, 15 Aug 2022 18:06:31 +0000 (14:06 -0400)]
Merge pull request #24262 from demeritcowboy/file-on-case
[NFC] Add test for editing activity subject to file on case
demeritcowboy [Mon, 15 Aug 2022 13:54:40 +0000 (09:54 -0400)]
add test for editing activity subject to file on case
Coleman Watts [Sat, 13 Aug 2022 18:37:22 +0000 (14:37 -0400)]
APIv4 - Support case_id param for Activity.create, add test
This moves processCaseActivity call out of APIv3 and into the BAO where it can be re-used by APIv4.
Coleman Watts [Sat, 13 Aug 2022 01:30:40 +0000 (21:30 -0400)]
APIv4 - Add `case_id` field to Activity entity
This virtual field allows an activity to be easily filed on a case,
and for cases to be looked up in SearchKit activity searches.
Eileen McNaughton [Mon, 15 Aug 2022 10:43:43 +0000 (22:43 +1200)]
Merge pull request #24253 from bjendres/patch-1
Add hint to create membership "You do not have all the permissions needed for this page" message
Seamus Lee [Mon, 15 Aug 2022 02:52:31 +0000 (12:52 +1000)]
Merge pull request #24257 from civicrm/5.53
5.53
Seamus Lee [Mon, 15 Aug 2022 02:02:26 +0000 (12:02 +1000)]
Merge pull request #24250 from demeritcowboy/set-alias
dev/core#3802 - Compatibility with symfony 6 for drupal 10 for listeners added via getSubscribedEvents
Seamus Lee [Mon, 15 Aug 2022 01:05:14 +0000 (11:05 +1000)]
Merge pull request #24256 from seamuslee001/5.53
[NFC] Convert Payment Processor ID field to payment processor in even…
demeritcowboy [Sun, 14 Aug 2022 01:08:28 +0000 (21:08 -0400)]
symfony 6 compatiblity
demeritcowboy [Sun, 14 Aug 2022 23:31:47 +0000 (19:31 -0400)]
Merge pull request #24249 from colemanw/goodbyeRevisions
dev/core#1532 - Remove civicaseActivityRevisions setting & related code
Seamus Lee [Sun, 14 Aug 2022 23:02:52 +0000 (09:02 +1000)]
[NFC] Convert Payment Processor ID field to payment processor in event create in tests
Coleman Watts [Sun, 14 Aug 2022 16:35:11 +0000 (12:35 -0400)]
SearchKit - Add contacts to mailing group in batches
For the "Email - schedule/send via CiviMail" action, this switches to
using the batch runner for adding contacts to the mailing group instead of
doing it all at once via chaining.
This prevents timeouts when creating very large mailings > 500 contacts.
colemanw [Sun, 14 Aug 2022 15:32:10 +0000 (11:32 -0400)]
Merge pull request #24252 from demeritcowboy/impossible
Remove unused impossible function in upgrade page
Coleman Watts [Sat, 13 Aug 2022 22:51:25 +0000 (18:51 -0400)]
CiviCase - Remove the civicaseActivityRevisions setting and related code
This setting has been deprecated for years, and core CiviCase doesn't respect it
anyway. Only the API was really paying attention to it. Time to get rid of that stuff
as a preamble to ripping out all of the case activity revisioning.
Björn Endres [Sun, 14 Aug 2022 14:55:04 +0000 (16:55 +0200)]
Add error hint
This exception is *also* raised, when no membership types have been configured yet, which can be very confusing. It cost me a two hours to figure out the real reason, and I have the nagging suspicion that this had happened to me before. I'm not too happy about the phrasing, but it would be good to have a reference to a potentially incomplete configuration. Thanks.
demeritcowboy [Sun, 14 Aug 2022 11:52:07 +0000 (07:52 -0400)]
unused impossible function
demeritcowboy [Sun, 14 Aug 2022 11:13:08 +0000 (07:13 -0400)]
Merge pull request #24251 from colemanw/activityCaseCleanupDoc
Fix processCaseActivity docblock
demeritcowboy [Sun, 14 Aug 2022 11:11:51 +0000 (07:11 -0400)]
Merge pull request #24247 from colemanw/activityCaseCleanup
[REF] Activity BAO - Decouple CiviCase logic from create function
Coleman Watts [Sun, 14 Aug 2022 03:40:50 +0000 (23:40 -0400)]
Fix processCaseActivity docblock
Coleman Watts [Sat, 13 Aug 2022 18:56:06 +0000 (14:56 -0400)]
Activity BAO - Decouple CiviCase logic from create function
A big chunk of civicase code was jammed into the Activity create function.
This moves it to the Case BAO.
colemanw [Sat, 13 Aug 2022 22:34:50 +0000 (18:34 -0400)]
Merge pull request #24248 from colemanw/deprecatedDaoProp
NFC - Make it possible to mark a dao field @deprecated
Coleman Watts [Sat, 13 Aug 2022 20:15:18 +0000 (16:15 -0400)]
NFC - Make it possible to mark a dao field @deprecated
colemanw [Sat, 13 Aug 2022 18:25:01 +0000 (14:25 -0400)]
Merge pull request #24246 from demeritcowboy/bool-again
Resolve existential crisis for customfield.is_active
demeritcowboy [Sat, 13 Aug 2022 12:48:39 +0000 (08:48 -0400)]
resolve existential crisis
demeritcowboy [Sat, 13 Aug 2022 12:17:08 +0000 (08:17 -0400)]
Merge pull request #24240 from civicrm/5.53
5.53
Tim Otten [Sat, 13 Aug 2022 01:16:50 +0000 (18:16 -0700)]
Merge pull request #24239 from colemanw/joinComments
APIv4 - Add comments and fix data type for contact location joins
Tim Otten [Fri, 12 Aug 2022 22:40:16 +0000 (15:40 -0700)]
Merge pull request #24238 from demeritcowboy/boo
dev/core#3799 - Fix incorrectly changed default for contact_dashboard.is_active
Tim Otten [Fri, 12 Aug 2022 22:33:49 +0000 (15:33 -0700)]
Merge pull request #24233 from demeritcowboy/zetapatookens
zetacomponents/mail - Ensure latest mail patches are included
Coleman Watts [Fri, 12 Aug 2022 21:27:09 +0000 (17:27 -0400)]
APIv4 - Add comments and fix data type for contact location joins
colemanw [Fri, 12 Aug 2022 19:46:18 +0000 (15:46 -0400)]
Merge pull request #24205 from eileenmcnaughton/obsolete
[Import-code-cleanup] Remove now-unused summary forms
colemanw [Fri, 12 Aug 2022 19:44:27 +0000 (15:44 -0400)]
Merge pull request #24226 from eileenmcnaughton/import_pledge_payment
Remove unreachable legacy code
demeritcowboy [Fri, 12 Aug 2022 17:02:57 +0000 (13:02 -0400)]
fix incorrectly changed default
demeritcowboy [Fri, 12 Aug 2022 13:25:35 +0000 (09:25 -0400)]
ensure latest mail patches are included
Seamus Lee [Thu, 11 Aug 2022 21:35:43 +0000 (07:35 +1000)]
Merge pull request #24231 from demeritcowboy/msgtpl-47
[REF] Remove unused message template upgrade code
colemanw [Thu, 11 Aug 2022 19:54:21 +0000 (15:54 -0400)]
Merge pull request #24225 from eileenmcnaughton/importable
Deprecate `BAO_Contribution::importableFields`
Eileen McNaughton [Thu, 11 Aug 2022 19:40:36 +0000 (07:40 +1200)]
Merge pull request #24191 from colemanw/civiGrantPerms
[REF] Decouple CiviGrant from core permission function
Eileen McNaughton [Thu, 11 Aug 2022 19:33:25 +0000 (07:33 +1200)]
Merge pull request #24229 from civicrm/5.53
5.53
Eileen McNaughton [Thu, 11 Aug 2022 19:28:25 +0000 (07:28 +1200)]
Merge pull request #24227 from eileenmcnaughton/mapping
Move non-shared function to private function on using class
demeritcowboy [Thu, 11 Aug 2022 14:27:13 +0000 (10:27 -0400)]
remove unused code
Eileen McNaughton [Thu, 11 Aug 2022 00:30:47 +0000 (12:30 +1200)]
Move non-shared function to private function on using class
demeritcowboy [Thu, 11 Aug 2022 12:37:09 +0000 (08:37 -0400)]
Merge pull request #24210 from eileenmcnaughton/goner
[Import-code-cleanup] Remove unused function
demeritcowboy [Thu, 11 Aug 2022 12:33:50 +0000 (08:33 -0400)]
Merge pull request #24214 from eileenmcnaughton/tpl
[Import-code-cleanup] Remove now-unused tpl
Matthew Wire [Thu, 11 Aug 2022 09:12:37 +0000 (10:12 +0100)]
Merge pull request #24194 from yashodha/dev-3141
(dev/core#3141) Membership should be listed chronologically by end da…
Seamus Lee [Thu, 11 Aug 2022 05:32:30 +0000 (15:32 +1000)]
Merge pull request #24224 from colemanw/fixSelect2AndNgOptions
CrmUi - Fix crmSelect2 to work with ngOptions
Seamus Lee [Thu, 11 Aug 2022 01:26:08 +0000 (11:26 +1000)]
Merge pull request #24165 from colemanw/afformExisting
Afform - add "Existing entity" selector
demeritcowboy [Thu, 11 Aug 2022 00:58:02 +0000 (20:58 -0400)]
Merge pull request #24223 from civicrm/5.53
5.53
demeritcowboy [Thu, 11 Aug 2022 00:51:33 +0000 (20:51 -0400)]
Merge pull request #24222 from herbdool/core-3796
dev/core#3796 include subtypes where filter > 0
colemanw [Thu, 11 Aug 2022 00:08:29 +0000 (20:08 -0400)]
Merge pull request #24216 from eileenmcnaughton/ds
Consolidate error handling on Custom data import tpl
Eileen McNaughton [Wed, 10 Aug 2022 22:03:14 +0000 (10:03 +1200)]
Remove always-the-same parameter
Seamus Lee [Wed, 10 Aug 2022 22:14:25 +0000 (08:14 +1000)]
Merge pull request #24220 from colemanw/customGroupFix
Fix regression causing custom groups to reset to 'Contact' when updated