Eileen McNaughton [Sun, 17 Feb 2019 00:53:52 +0000 (13:53 +1300)]
Merge pull request #13614 from eileenmcnaughton/cont_summary_extract1
[REF] extract calculation of mode stat
Eileen McNaughton [Sat, 16 Feb 2019 23:34:22 +0000 (12:34 +1300)]
Merge pull request #13615 from civicrm/5.11
5.11 to master
Eileen McNaughton [Sat, 16 Feb 2019 23:33:06 +0000 (12:33 +1300)]
Merge pull request #13613 from colemanw/openCampaignWidget
Auto-open campaign widget and sort by start date
colemanw [Sat, 16 Feb 2019 22:47:08 +0000 (17:47 -0500)]
Merge pull request #13373 from MegaphoneJon/core-580-2
fixes core#580 - view all groups when appropriately permissioned
Eileen McNaughton [Sat, 16 Feb 2019 22:23:22 +0000 (11:23 +1300)]
Merge pull request #13612 from colemanw/l10n.js
Move l10n.js to coreResourcesList
eileen [Fri, 15 Feb 2019 01:41:04 +0000 (14:41 +1300)]
[REF] extract calculation of mode stat
Coleman Watts [Sat, 16 Feb 2019 21:25:18 +0000 (16:25 -0500)]
Auto-open campaign widget and sort by start date
Coleman Watts [Sat, 16 Feb 2019 20:13:01 +0000 (15:13 -0500)]
Move l10n.js to coreResourcesList
This change allows core resources to be added to the list AFTER l10n variables
have been initialized. This is needed by crm.menubar.js.
Another upshot of this change is that extensions will be able to add items to the list
as fully-formed urls.
colemanw [Sat, 16 Feb 2019 19:47:37 +0000 (14:47 -0500)]
Merge pull request #13425 from mfb/utf8mb4
Add install and runtime status warnings if MySQL utf8mb4 is not supported
colemanw [Sat, 16 Feb 2019 19:21:00 +0000 (14:21 -0500)]
Merge pull request #13608 from eileenmcnaughton/cont_summary_extract1
[REF] extract calculation of basic stats
colemanw [Sat, 16 Feb 2019 19:14:48 +0000 (14:14 -0500)]
Merge pull request #13587 from eileenmcnaughton/acl_location
[REF] Move addSelectWhere-like function to be located on BAO_Contribution
Monish Deb [Sat, 16 Feb 2019 07:32:52 +0000 (13:02 +0530)]
Merge pull request #13563 from eileenmcnaughton/fn_fix_payment_by_type
[REF] Fix silly function to do less handling of non-existent scenarios
Eileen McNaughton [Sat, 16 Feb 2019 06:53:47 +0000 (19:53 +1300)]
Merge pull request #13611 from seamuslee001/exception_api
Add in Exception API to support the refactor of Dedupe Exception Page
Alok Patel [Sat, 16 Feb 2019 02:05:38 +0000 (13:05 +1100)]
Add in Exception API to support the refactor of Dedupe Exception Page
Mathieu Lu [Fri, 15 Feb 2019 16:30:39 +0000 (11:30 -0500)]
Merge pull request #13591 from mfb/683-incorrectly-encoded-state-and-country-names
fixes dev/core#683 Incorrectly encoded state and country names
eileen [Fri, 15 Feb 2019 00:57:12 +0000 (13:57 +1300)]
[REF] extract calculation of basic stats
Seamus Lee [Fri, 15 Feb 2019 06:08:27 +0000 (17:08 +1100)]
Merge pull request #13605 from eileenmcnaughton/cont_summary
dev/core#720 add unit test, remove legacy code style.
Eileen McNaughton [Fri, 15 Feb 2019 03:51:49 +0000 (16:51 +1300)]
Merge pull request #13600 from eileenmcnaughton/profile_perf
[REF] extract chunk of code to a separate function
eileen [Thu, 14 Feb 2019 22:50:56 +0000 (11:50 +1300)]
dev/core#720 add unit test, remove legacy code style.
This PR adds tests to the summaryQuery code in preparation for changes.
The one non-test change is to remove the & from summaryContribution fn.
It is only called from one place in the code & that place does not return as reference.
```
/**
* @return mixed
*/
public function getSummary() {
return $this->_query->summaryContribution($this->_context);
}
```
Yashodha Chaku [Fri, 15 Feb 2019 02:33:52 +0000 (08:03 +0530)]
Merge pull request #13432 from francescbassas/patch-16
dev/core#657 - Add filter for country on Repeat Contributions Report
eileen [Wed, 13 Feb 2019 03:45:11 +0000 (16:45 +1300)]
Move addSelectWhere-like function to be located on BAO_Contribution using correct name.
Since the contribution api uses the BAO_Query object I think it will not call this, nor reports AFAIK
However, this should cause the v4 api to apply these.
eileen [Thu, 14 Feb 2019 20:42:00 +0000 (09:42 +1300)]
[REF] extract chunk of code to a separate function
Eileen McNaughton [Thu, 14 Feb 2019 23:29:19 +0000 (12:29 +1300)]
Merge pull request #13602 from civicrm/5.11
5.11 to master
Seamus Lee [Thu, 14 Feb 2019 22:26:45 +0000 (09:26 +1100)]
Merge pull request #13599 from seamuslee001/5.11
Add in release notes for 5.10.2
Tim Otten [Thu, 14 Feb 2019 22:14:38 +0000 (14:14 -0800)]
Update 5.10.2.md
Tim Otten [Thu, 14 Feb 2019 22:14:19 +0000 (14:14 -0800)]
Update 5.10.2.md
Minor copy-edits:
* Punctuation to match other point-release docs
* Use consistent reverse-alpha in credits
* Add some more authors+reviewers from Github
Seamus Lee [Thu, 14 Feb 2019 21:45:19 +0000 (08:45 +1100)]
Merge pull request #13593 from eileenmcnaughton/acl_regression
dev/core#721 Fix regression on refreshing group_contact cache before checking acls
Eileen McNaughton [Thu, 14 Feb 2019 21:32:58 +0000 (10:32 +1300)]
Merge pull request #13592 from yashodha/dev-705
(dev/core#705) Disabling Alphabetical Pager is not respected for cont…
Seamus Lee [Thu, 14 Feb 2019 20:34:43 +0000 (07:34 +1100)]
Add in release notes for 5.10.2
Update release notes as per Eileen's comment
Add in notes on merge of dev/core#715 fix
eileen [Thu, 14 Feb 2019 05:37:14 +0000 (18:37 +1300)]
Fix regression on refreshing group_contact cache before checking acls
We seem to be checking if the cache needs a rebuild and IF SO doing 2 actions
1) rebuilding it
2) permitting access to contacts related to it
When really it should do only 1) above - this patch changes as such
This seems to be whackamole off https://github.com/civicrm/civicrm-core/pull/12344
going too far one way & https://github.com/civicrm/civicrm-core/pull/13448
fixing but adding this new variant
Eileen McNaughton [Thu, 14 Feb 2019 20:17:05 +0000 (09:17 +1300)]
Merge pull request #13561 from eileenmcnaughton/payment_conf
Add new Payment.sendconfirmation api
francescbassas [Thu, 14 Feb 2019 11:27:17 +0000 (12:27 +0100)]
Update Repeat.php
Add basic contact fields and filters on Repeat Contributions Report
Yashodha Chaku [Thu, 14 Feb 2019 11:10:27 +0000 (16:40 +0530)]
Merge pull request #13517 from alifrumin/contribsearchsoftcredit
Find Contributions columns/headers not aligned when "Contributions OR Soft Credits?" filter set to "Soft Credits Only"
yashodha [Thu, 14 Feb 2019 04:40:19 +0000 (10:10 +0530)]
(dev/core#705) Disabling Alphabetical Pager is not respected for contribution pages.
mark burdett [Thu, 14 Feb 2019 00:06:51 +0000 (16:06 -0800)]
fixes dev/core#683 Incorrectly encoded state and country names
eileen [Mon, 11 Feb 2019 03:39:55 +0000 (16:39 +1300)]
Add new Payment.sendconfirmation api
This adds a new api Payment.sendconfirmation intended to be an equivalent of
Contribution.sendconfirmation.
The key thing this needs to be able to do is to load up all
related information to assign to the template - this is not all covered in this
PR & until it is functionally equivalent to AdditionalPayment::sendEmail
we can't switch over but since it's new functionality we should be able to
merge & keep working on it.
Note that there is discussion on the PR this relates to (#13330) about what should
happen if 'Payment.create' api accepts 'is_email_receipt'. I think the most logical
outcome is that receipts would go out if it caused the contribution to be completed
(ie. we pass is_email_receipt into completetransaction api).
However, I don't feel like that is 'settled' yet - separating into a second api
(Payment.sendnotification) means we will have 2 generic function which can be called
from multiple places in the code rather than 2 functions tightly tied to the form layer.
I think it's OK if it is 2 not one
Eileen McNaughton [Wed, 13 Feb 2019 23:22:14 +0000 (12:22 +1300)]
Merge pull request #13571 from eileenmcnaughton/book
dev/report#7 fix trxn_date on bookkeeping report
Eileen McNaughton [Wed, 13 Feb 2019 22:39:42 +0000 (11:39 +1300)]
Merge pull request #13528 from jitendrapurohit/dev-684
dev/core#684 - Case Manager not updating correctly
Eileen McNaughton [Wed, 13 Feb 2019 22:26:12 +0000 (11:26 +1300)]
Merge pull request #13539 from eileenmcnaughton/email_task
dev/core#469 Fix Error on action 'Email - schedule/send via CiviMail' with multiple event names filter
Seamus Lee [Wed, 13 Feb 2019 20:33:42 +0000 (07:33 +1100)]
Merge pull request #13584 from eileenmcnaughton/user_dash_use_api
[REF} User api rather than selector for rendering contributions on user dashboard
Eileen McNaughton [Wed, 13 Feb 2019 20:26:45 +0000 (09:26 +1300)]
Merge pull request #13538 from eileenmcnaughton/dedupe_birth
dev/core#397 Dedupe for Individual Birth Date Results in Error
Eileen McNaughton [Wed, 13 Feb 2019 20:21:17 +0000 (09:21 +1300)]
Merge pull request #13557 from vingle/patch-5
Improves styling on Joomla! upgrade screen
Eileen McNaughton [Wed, 13 Feb 2019 19:30:06 +0000 (08:30 +1300)]
Merge pull request #13573 from pradpnayak/GroupInlineEdit
dev/core/issues/714, Inline edit should be disabled if user doesn't have edit group permission
eileen [Wed, 13 Feb 2019 01:21:57 +0000 (14:21 +1300)]
Switch userDashboard from using selector object to using the api to get contributions to display.
Note that preliminary tests for this were written & merged some time ago.
Reasons for the change are
1) readability - most devs are much more comfortable with reading the api code than the selector
2) performance - the contribute selector code is deeply unperformant - mostly due to the summary function which in
this case is somewhat mitigated by the limit of 12 but we are still doing something slow for no reason
3) test stability - the test for this turned out to have poor stability & hopefully this will help
4) preliminary cleanup - there are 2 existing PRs that attempt to add new buttons to this & moving towards
a cleaner tpl / php layer will help with those. In addition there is a serious performance issue to
address on the contribution summary function. Reducing use of that function should help with the cleanup effort
Eileen McNaughton [Wed, 13 Feb 2019 18:04:30 +0000 (07:04 +1300)]
Merge pull request #13523 from eileenmcnaughton/def_country
dev/core#691 Make default country optional on setting form
eileen [Wed, 13 Feb 2019 18:03:39 +0000 (07:03 +1300)]
Attempt to fix unrelated test fail
This test keeps failing on an unrelated test - perhaps ['cid'] is
being set & somehow retained - could explain other intermittents
Eileen McNaughton [Wed, 13 Feb 2019 17:51:33 +0000 (06:51 +1300)]
Merge pull request #13583 from eileenmcnaughton/user_dash
[REF] switch from (undeclared) class property to local variable.
Eileen McNaughton [Wed, 13 Feb 2019 08:09:01 +0000 (21:09 +1300)]
Merge pull request #13562 from eileenmcnaughton/payment_test
[REF] Minor readability cleanup
Eileen McNaughton [Wed, 13 Feb 2019 04:44:13 +0000 (17:44 +1300)]
Merge pull request #13342 from mattwire/activity_submitonce
Remove activitystatus js. Add submitOnce handler for activity create
eileen [Mon, 4 Feb 2019 02:06:37 +0000 (15:06 +1300)]
dev/core#691 Make default country optional on setting form
This includes removing the default of 'United States'.... ahem!
Eileen McNaughton [Wed, 13 Feb 2019 01:48:35 +0000 (14:48 +1300)]
Merge pull request #13580 from colemanw/noMoreFourTwo
Bump minimum upgradable ver to 4.2.9
Eileen McNaughton [Wed, 13 Feb 2019 01:46:33 +0000 (14:46 +1300)]
Merge pull request #13585 from civicrm/5.11
5.11 to master
Eileen McNaughton [Wed, 13 Feb 2019 01:46:07 +0000 (14:46 +1300)]
Merge pull request #13581 from colemanw/dev/core#715
dev/core#715 - Fix delete action on RelationshipType form
eileen [Wed, 13 Feb 2019 00:31:44 +0000 (13:31 +1300)]
REF minor code readability improvements
eileen [Wed, 13 Feb 2019 00:23:28 +0000 (13:23 +1300)]
[REF] switch from (undeclared) class property to local variable.
We either needed to declare the variable on the class & make it a local variable. Switching
to a local var reflects the fact it is never accessed from outside thie function & improves readability.
grepping for _userOptions returns nothing after this.
I also removed an extraneous config singleton call. I can't see a strong case that either of
these changes will affect the intermittent fails but ... maybe?
Coleman Watts [Tue, 12 Feb 2019 17:08:48 +0000 (12:08 -0500)]
dev/core#715 - Fix delete action on RelationshipType form
Eileen McNaughton [Tue, 12 Feb 2019 19:54:29 +0000 (08:54 +1300)]
Merge pull request #13577 from mattwire/codecleanup
Fix typo and space
Pradeep Nayak [Thu, 15 Nov 2018 18:20:35 +0000 (23:50 +0530)]
CRM-17238, Dedupe for Individual Birth Date Results in Error
dev/core#397 fix fatal error on birth_date dedupe
Coleman Watts [Tue, 12 Feb 2019 16:12:34 +0000 (11:12 -0500)]
Bump minimum upgradable ver to 4.2.9
Matthew Wire (MJW Consulting) [Tue, 12 Feb 2019 10:53:04 +0000 (10:53 +0000)]
Code cleanup
eileen [Mon, 11 Feb 2019 04:35:56 +0000 (17:35 +1300)]
Remove unused variable from getPartialPaymentWithType
Eileen McNaughton [Tue, 12 Feb 2019 02:23:48 +0000 (15:23 +1300)]
Merge pull request #13576 from civicrm/5.11
5.11 to master
Eileen McNaughton [Tue, 12 Feb 2019 02:23:03 +0000 (15:23 +1300)]
Merge pull request #13575 from seamuslee001/5_10_1_release_notes_11
Release notes for 5.10.1 release
Seamus Lee [Mon, 11 Feb 2019 22:46:38 +0000 (09:46 +1100)]
Merge pull request #13572 from eileenmcnaughton/cc_511
Fix regression whereby making receive_date required breaks back offic…
Seamus Lee [Mon, 11 Feb 2019 21:09:03 +0000 (08:09 +1100)]
Release notes for 5.10.1 release
eileen [Mon, 11 Feb 2019 20:19:33 +0000 (09:19 +1300)]
dev/report#7 fix trxn_date on bookkeeping report
Eileen McNaughton [Mon, 11 Feb 2019 20:50:13 +0000 (09:50 +1300)]
Merge pull request #13564 from seamuslee001/remove_free_campaign_case
Remove hurty free calls from campaign and case
eileen [Mon, 11 Feb 2019 20:16:22 +0000 (09:16 +1300)]
Fix regression whereby making receive_date required breaks back office cc
Regression from https://lab.civicrm.org/dev/core/issues/680
led to https://civicrm.stackexchange.com/questions/28410/unable-to-take-credit-card-payment-after-civi-update
Pradeep Nayak [Mon, 11 Feb 2019 20:43:23 +0000 (20:43 +0000)]
dev/core/issues/714, Inline edit should be disabled if user doesn't have edit group permission
Matthew Wire (MJW Consulting) [Fri, 21 Dec 2018 12:11:24 +0000 (12:11 +0000)]
Remove activitystatus js. Add submitOnce handler for activity create
colemanw [Mon, 11 Feb 2019 16:56:33 +0000 (11:56 -0500)]
Merge pull request #13569 from colemanw/Fix
Fix contact ID help on advanced search
Coleman Watts [Mon, 11 Feb 2019 14:42:06 +0000 (09:42 -0500)]
Fix contact ID help on advanced search
Seamus Lee [Mon, 11 Feb 2019 07:48:39 +0000 (18:48 +1100)]
Remove hurty free calls from campaign and case
Seamus Lee [Mon, 11 Feb 2019 07:46:51 +0000 (18:46 +1100)]
Merge pull request #13558 from eileenmcnaughton/balance_test
Add unit test on getContributionBalance fn (#13187)
Seamus Lee [Mon, 11 Feb 2019 05:57:17 +0000 (16:57 +1100)]
Merge pull request #13560 from seamuslee001/free_activity_member
dev/core#562 Remove free calls from Activity and Member sections of CRM
Eileen McNaughton [Mon, 11 Feb 2019 05:30:19 +0000 (18:30 +1300)]
Merge pull request #13327 from pradpnayak/SerarchView
Used buildoptions function to get all groups
Eileen McNaughton [Mon, 11 Feb 2019 05:11:15 +0000 (18:11 +1300)]
Merge pull request #13404 from pradpnayak/ReportActions
Show Add to group on create new report after refresh of result
eileen [Mon, 11 Feb 2019 04:33:47 +0000 (17:33 +1300)]
Replace call to silly confusing function with simple function.
If you dig down into CRM_Core_BAO_FinancialTrxn::getPartialPaymentWithType you find that just calling
CRM_Contribute_BAO_Contribution::getContributionBalance is all it actually does here....
eileen [Mon, 11 Feb 2019 04:27:59 +0000 (17:27 +1300)]
Add unit test on getContributionBalance fn (#13187)
Seamus Lee [Mon, 11 Feb 2019 01:20:11 +0000 (12:20 +1100)]
Remove free calls from Activity and Member sections of CRM
eileen [Mon, 11 Feb 2019 03:54:14 +0000 (16:54 +1300)]
Minor readability cleanup
Eileen McNaughton [Mon, 11 Feb 2019 00:49:16 +0000 (13:49 +1300)]
Merge pull request #13287 from mattwire/eventregister_rename
(REF) Rename variables and adjust variable definitions for Event Register form
Eileen McNaughton [Sun, 10 Feb 2019 22:14:42 +0000 (11:14 +1300)]
Merge pull request #13187 from JMAConsulting/payment_function
Optimize CRM_Core_BAO_FinancialTrxn::getTotalPayment
Nicol [Sun, 10 Feb 2019 15:25:17 +0000 (15:25 +0000)]
Preserve page padding on Joomla upgrade screen
Fixes issue where padding was removed from the main Joomla admin screen in this commit - https://github.com/civicrm/civicrm-core/commit/
6ada1cee014a8bd99e4778864c32c0c140c7a92e - removing padding on the upgrade screen.
Nicol [Sun, 10 Feb 2019 15:19:05 +0000 (15:19 +0000)]
Preserves padding on upgrade screen.
Padding was removed from the Joomla admin screen in this commit - https://github.com/civicrm/civicrm-core/commit/
6ada1cee014a8bd99e4778864c32c0c140c7a92e - which removed all padding on the upgrade screen. Fix to add padding to that screen.
colemanw [Sat, 9 Feb 2019 05:26:12 +0000 (00:26 -0500)]
Merge pull request #13555 from colemanw/loadScript
CRM.loadScript improvements
Coleman Watts [Sat, 9 Feb 2019 02:54:40 +0000 (21:54 -0500)]
Add angular util crmLoadScript
Coleman Watts [Sat, 9 Feb 2019 02:54:20 +0000 (21:54 -0500)]
Append cache-buster to dynamically loaded scripts
Seamus Lee [Fri, 8 Feb 2019 03:52:22 +0000 (14:52 +1100)]
Merge pull request #13549 from pradpnayak/Qfill
dev/core/issues/700, Show Qill when searched using contact id
colemanw [Thu, 7 Feb 2019 21:48:24 +0000 (16:48 -0500)]
Merge pull request #13333 from mattwire/buttons_submitOnce
Make submitOnce() button js into a button parameter
Monish Deb [Thu, 7 Feb 2019 13:34:26 +0000 (19:04 +0530)]
Merge pull request #13529 from greenpeace-cee/fix-api-entity-permission
dev/core#690 - Civi\API - Fix entity permission check for trusted calls
CiviCRM [Thu, 7 Feb 2019 01:49:22 +0000 (01:49 +0000)]
Set version to 5.12.alpha1
CiviCRM [Thu, 7 Feb 2019 01:44:56 +0000 (01:44 +0000)]
Set version to 5.11.beta1
Tim Otten [Thu, 7 Feb 2019 01:40:32 +0000 (20:40 -0500)]
Merge pull request #13552 from seamuslee001/master
Update 5.10.0.md
Tim Otten [Thu, 7 Feb 2019 00:30:09 +0000 (19:30 -0500)]
Update 5.10.0.md
Seamus Lee [Wed, 6 Feb 2019 22:10:40 +0000 (09:10 +1100)]
Merge pull request #13550 from civicrm/5.10
5.10
Seamus Lee [Wed, 6 Feb 2019 20:47:11 +0000 (12:47 -0800)]
Merge pull request #13494 from agh1/5.10.0-releasenotes
5.10.0 release notes
colemanw [Wed, 6 Feb 2019 18:01:47 +0000 (13:01 -0500)]
Merge pull request #13544 from pradpnayak/ContactImage
core/issues/698, send correct MIME type for .jpg files
Pradeep Nayak [Wed, 6 Feb 2019 17:50:15 +0000 (17:50 +0000)]
dev/core/issues/700, Show Qill when searched using contact id
Andrew Hunt [Wed, 6 Feb 2019 14:49:40 +0000 (09:49 -0500)]
5.10.0 release notes: late changes, credits, and last-minute fixes