colemanw [Tue, 25 Jan 2022 13:59:38 +0000 (08:59 -0500)]
Merge pull request #22618 from eileenmcnaughton/batch
Fix batch summary to use the api
Yashodha Chaku [Tue, 25 Jan 2022 13:05:08 +0000 (18:35 +0530)]
Merge pull request #22617 from eileenmcnaughton/view
Split View Relationship tpl ito own file
Yashodha Chaku [Tue, 25 Jan 2022 12:54:02 +0000 (18:24 +0530)]
Merge pull request #22548 from eileenmcnaughton/raw
Add option to display money tokens without formatting
Eileen McNaughton [Tue, 25 Jan 2022 07:39:24 +0000 (20:39 +1300)]
Fix batch summary to use the api
In looking at @colemanw's work to clean up the retrieve function it
turned out that in at least one place NULL is being passed to Batch::retrieve
Since I dug into that 1 place I fixed it to use v4 api (it is
the screen accessed after creating a new accounting batch
from contribution->accounting batches->new batch)
However, it seems safer to continue to accept NULL
Eileen McNaughton [Tue, 25 Jan 2022 04:24:44 +0000 (17:24 +1300)]
Split View Relationship tpl ito own file
The inclusion of templates/CRM/Contact/Form/Relationship.tpl simply contains a chunk
of code for the view file in a big IF - this separates that out it's own file & is
more thoughtful about the inclusion....
demeritcowboy [Tue, 25 Jan 2022 02:23:36 +0000 (21:23 -0500)]
Merge pull request #22547 from eileenmcnaughton/smart
Only format smarty aliases as money if specified
colemanw [Tue, 25 Jan 2022 01:53:34 +0000 (20:53 -0500)]
Merge pull request #22613 from eileenmcnaughton/notice
Fix smarty notices in footer files
colemanw [Tue, 25 Jan 2022 00:12:24 +0000 (19:12 -0500)]
Merge pull request #22314 from braders/core-3004-remove-fontsize-classes
Remove use of .font-size11pt and .font-size12pt
Eileen McNaughton [Mon, 17 Jan 2022 08:04:27 +0000 (21:04 +1300)]
Fix smarty notices in footer files
Eileen McNaughton [Mon, 17 Jan 2022 22:10:57 +0000 (11:10 +1300)]
Only format smarty aliases as money if specified
smarty aliases allow tokens to be assigned to the template as smarty variables. They are very new,
have only been implemented in these 2 places and are not accessible from outside of core, which
both have unit test cover.
When trying to extend it to cover another variable (totalTaxAmount) in another template I found
that a raw format is appropriate. I think it makes sense to explicitly specify.
Code comment
Co-authored-by: Tim Otten <totten@civicrm.org>
Eileen McNaughton [Mon, 24 Jan 2022 20:23:55 +0000 (09:23 +1300)]
Merge pull request #22611 from yashodha/report_cleanup
report cleanup - no functional change
Bradley Taylor [Thu, 23 Dec 2021 15:49:49 +0000 (15:49 +0000)]
Remove use of .font-size11pt and .font-size12pt
colemanw [Mon, 24 Jan 2022 13:47:25 +0000 (08:47 -0500)]
Merge pull request #20845 from herbdool/issue-899
Issue #899: don't show PCPs where the events or contribution pages are disabled or past the end date
colemanw [Mon, 24 Jan 2022 13:20:54 +0000 (08:20 -0500)]
Merge pull request #20251 from larssandergreen/change-registration-button-text
dev/core#1613 Change event registration button text based on if there are additional participants
Monish Deb [Mon, 24 Jan 2022 12:04:04 +0000 (17:34 +0530)]
Merge pull request #22604 from colemanw/searchKitOperators
SearchKit - Improve field/operator/value selection UI
yashodha [Mon, 24 Jan 2022 05:25:35 +0000 (10:55 +0530)]
report cleanup
Yashodha Chaku [Mon, 24 Jan 2022 05:00:04 +0000 (10:30 +0530)]
Merge pull request #22610 from colemanw/deprecatedUnusedFunction
Contact BAO - Deprecate unused function
colemanw [Mon, 24 Jan 2022 02:21:26 +0000 (21:21 -0500)]
Merge pull request #22605 from braders/showhideblocks-tidy
Don't pass redundent empty strings when instantiating CRM_Core_ShowHideBlocks
Coleman Watts [Mon, 24 Jan 2022 01:41:22 +0000 (20:41 -0500)]
Contact BAO - Deprecate unused function
colemanw [Mon, 24 Jan 2022 00:31:05 +0000 (19:31 -0500)]
Merge pull request #22558 from eileenmcnaughton/coleman
Fix Grant::retrieve to meet full phpcs standard
Seamus Lee [Sun, 23 Jan 2022 22:22:46 +0000 (09:22 +1100)]
Merge pull request #22607 from braders/codegen-dao-property-types
Make phpType definitions in generated DAO objects more accurate.
Coleman Watts [Sun, 23 Jan 2022 19:27:37 +0000 (14:27 -0500)]
Regenerate DAO files with improved var docblocks
Bradley Taylor [Sun, 23 Jan 2022 10:24:10 +0000 (10:24 +0000)]
Make phpType definitions in generated DAO objects more accurate.
demeritcowboy [Sun, 23 Jan 2022 20:37:41 +0000 (15:37 -0500)]
Merge pull request #22608 from colemanw/caseReadonlyField
CiviCase - Denote `created_date` as readonly
Coleman Watts [Sun, 23 Jan 2022 17:24:13 +0000 (12:24 -0500)]
CiviCase - Tag `created_date` as readonly
For better or for worse, the Case BAO does not allow this field to be updated,
so this updates getfields to reflect that fact.
demeritcowboy [Sun, 23 Jan 2022 15:14:21 +0000 (10:14 -0500)]
Merge pull request #22603 from colemanw/searchKitAdminDocs
[REF] SearchKit docblock cleanup
Bradley Taylor [Sat, 22 Jan 2022 17:43:26 +0000 (17:43 +0000)]
Don't pass redundent empty strings when instantiating CRM_Core_ShowHideBlocks
Coleman Watts [Sat, 22 Jan 2022 17:01:11 +0000 (12:01 -0500)]
SearchKit - Improve field/operator/value selection UI
Carves out yet another component to handle the logic of deciding which operators are
appropriate to which fields, and how the input values should be rendered.
Coleman Watts [Sat, 22 Jan 2022 16:54:04 +0000 (11:54 -0500)]
[REF] SearchKit docblock cleanup
colemanw [Sat, 22 Jan 2022 15:10:01 +0000 (10:10 -0500)]
Merge pull request #22552 from colemanw/searchKitConditionalCss
SearchKit - Support operators in conditional css rules
colemanw [Sat, 22 Jan 2022 14:56:45 +0000 (09:56 -0500)]
Merge pull request #22602 from braders/civi-log-warn-fix
Fix call to log method warn (should be warning)
colemanw [Sat, 22 Jan 2022 14:49:46 +0000 (09:49 -0500)]
Merge pull request #22600 from braders/bad-null-defaults-phpdoc
(NFC) Correct type hints for bad null default values
Bradley Taylor [Sat, 22 Jan 2022 12:17:29 +0000 (12:17 +0000)]
Fix call to log method warn (should be warning)
Bradley Taylor [Sat, 22 Jan 2022 11:48:26 +0000 (11:48 +0000)]
(NFC) Correct type hints for bad null default values
Seamus Lee [Sat, 22 Jan 2022 02:21:45 +0000 (13:21 +1100)]
Merge pull request #22599 from civicrm/5.46
5.46
Seamus Lee [Sat, 22 Jan 2022 00:44:35 +0000 (11:44 +1100)]
Merge pull request #22449 from mattwire/phpnotices
tpl notices and docblocks
Seamus Lee [Sat, 22 Jan 2022 00:44:18 +0000 (11:44 +1100)]
Merge pull request #22368 from yashodha/dev-3012
(dev/core#3012) Expose email on hold as filter for contribution report
Seamus Lee [Sat, 22 Jan 2022 00:40:48 +0000 (11:40 +1100)]
Merge pull request #22598 from colemanw/searchKitExtract
[REF] SearchKit - Function extraction
Seamus Lee [Sat, 22 Jan 2022 00:40:02 +0000 (11:40 +1100)]
Merge pull request #22597 from colemanw/searchKitEntityAccess
SearchKit - Fix running searches for anonymous users
Seamus Lee [Sat, 22 Jan 2022 00:39:55 +0000 (11:39 +1100)]
Merge pull request #22560 from eileenmcnaughton/fin_type
Use tokens in offline contribution receipt (new installs)
Coleman Watts [Fri, 21 Jan 2022 20:14:08 +0000 (15:14 -0500)]
SearchKit - Function extraction
Coleman Watts [Fri, 21 Jan 2022 20:00:35 +0000 (15:00 -0500)]
SearchKit - Fix loading metadata for anonymous users
The `checkPermissions` param was previously not getting copied into
`$this->savedSearch['api_params']` which caused trouble for less-
permissioned users, esp when the Run action is trying to internally
load field metadata.
Coleman Watts [Fri, 21 Jan 2022 17:08:28 +0000 (12:08 -0500)]
SearchKit - Fix `checkEntityAccess` for anonymous users
This function checks to see if a user has access to "get",
but anonymous users might not even have access to check if they have access!
colemanw [Fri, 21 Jan 2022 15:22:55 +0000 (10:22 -0500)]
Merge pull request #22594 from eileenmcnaughton/deprecated
Remove unreachable code
Yashodha Chaku [Fri, 21 Jan 2022 07:41:49 +0000 (13:11 +0530)]
Merge pull request #22593 from eileenmcnaughton/values
Pass remove-by-reference
yashodha [Tue, 4 Jan 2022 04:14:26 +0000 (09:44 +0530)]
(dev/core#3012) Expose more options for email on hold as filter for all contribution reports
Seamus Lee [Fri, 21 Jan 2022 06:46:11 +0000 (17:46 +1100)]
Merge pull request #22557 from colemanw/searckKitLinkConditions
SearchKit - Support conditional links
Tim Otten [Fri, 21 Jan 2022 06:02:57 +0000 (22:02 -0800)]
Merge pull request #22324 from totten/master-queue-table
(dev/core#1304) Queue - Add high-level tracking table
Eileen McNaughton [Fri, 21 Jan 2022 03:01:57 +0000 (16:01 +1300)]
Pass remove-by-reference
Eileen McNaughton [Fri, 21 Jan 2022 03:10:42 +0000 (16:10 +1300)]
Merge pull request #22586 from braders/checkTemplateFileExists-consistency-phpdoc
Add consistency between checkTemplateFileExists functions,
Eileen McNaughton [Fri, 21 Jan 2022 03:04:37 +0000 (16:04 +1300)]
Remove unreachable code
colemanw [Fri, 21 Jan 2022 02:30:10 +0000 (21:30 -0500)]
Merge pull request #22481 from eileenmcnaughton/deprecated
Duplicate function from deprecated utils onto calling classes & remove
Tim Otten [Fri, 21 Jan 2022 02:28:28 +0000 (18:28 -0800)]
Queue XML/DAO/BAO - Add pseudoconstant for listing available types
Eileen McNaughton [Fri, 21 Jan 2022 02:27:44 +0000 (15:27 +1300)]
Merge pull request #22585 from colemanw/pissbyref
Remove useless function
Coleman Watts [Tue, 18 Jan 2022 02:41:32 +0000 (21:41 -0500)]
SearchKit - Support conditional links
Advanced feature to conditionally show/hide links in a links/buttons/menu column,
based on user permissions or row values.
colemanw [Fri, 21 Jan 2022 01:18:02 +0000 (20:18 -0500)]
Merge pull request #22566 from eileenmcnaughton/dep
CRM_Core_Component (et al) - Deprecate unused functions
Eileen McNaughton [Fri, 21 Jan 2022 00:40:32 +0000 (13:40 +1300)]
Merge pull request #22591 from civicrm/5.46
5.46 to master
Eileen McNaughton [Fri, 21 Jan 2022 00:39:51 +0000 (13:39 +1300)]
Merge pull request #22589 from eileenmcnaughton/46
Use api for entityRole - addresses save issue on the form
Eileen McNaughton [Thu, 20 Jan 2022 23:33:57 +0000 (12:33 +1300)]
Merge pull request #22590 from eileenmcnaughton/prop
Remove param default
Eileen McNaughton [Thu, 20 Jan 2022 22:41:41 +0000 (11:41 +1300)]
Remove param default
Since value is required the default for label would never be used
Eileen McNaughton [Thu, 20 Jan 2022 22:23:23 +0000 (11:23 +1300)]
Use api for entityRole - addresses save issue on the form
Eileen McNaughton [Thu, 20 Jan 2022 20:57:04 +0000 (09:57 +1300)]
Merge pull request #22572 from yashodha/dev_3012
(dev/core#3012) Expose more options for email on hold as filter for l…
Eileen McNaughton [Thu, 20 Jan 2022 20:55:30 +0000 (09:55 +1300)]
Merge pull request #22559 from colemanw/permissionGroup
APIv4 - Make Permission 'group' discoverable in API Explorer
Eileen McNaughton [Thu, 20 Jan 2022 20:54:02 +0000 (09:54 +1300)]
Merge pull request #22554 from colemanw/searchKitOps
SearchKit - Update operator labels
colemanw [Thu, 20 Jan 2022 20:53:28 +0000 (15:53 -0500)]
Merge pull request #22581 from lemniscus/feature/issue-3037/two-digit-year-import
Use rolling window for translating 2-digit years into 4-digit years
colemanw [Thu, 20 Jan 2022 20:48:16 +0000 (15:48 -0500)]
Merge pull request #22508 from twomice/event_66_allow_dupliate_price_field_label
dev/event#66: allow duplicate price field labels
Eileen McNaughton [Thu, 20 Jan 2022 20:41:39 +0000 (09:41 +1300)]
Merge pull request #22570 from colemanw/uniqueName
DAO - Centralize logic to derive unique name from label
colemanw [Thu, 20 Jan 2022 20:22:29 +0000 (15:22 -0500)]
Merge pull request #22579 from eileenmcnaughton/api4
Simplify apiv4 conformance test
Coleman Watts [Thu, 20 Jan 2022 20:04:02 +0000 (15:04 -0500)]
Remove useless function
Bradley Taylor [Thu, 20 Jan 2022 19:45:59 +0000 (19:45 +0000)]
Add consistency between checkTemplateFileExists functions,
resolving phpdoc issues in the process.
Matthew Wire [Thu, 20 Jan 2022 18:50:09 +0000 (18:50 +0000)]
Merge pull request #21583 from mattwire/propertybagsimplebits
Add billingStateProvince and standardized property names
Matthew Wire [Mon, 10 Jan 2022 14:14:11 +0000 (14:14 +0000)]
tpl notices and docblocks
Matthew Wire [Thu, 20 Jan 2022 18:40:47 +0000 (18:40 +0000)]
Merge pull request #22561 from mattwire/jobapi3
Fix return values for API3 Job.delete
Coleman Watts [Wed, 19 Jan 2022 02:45:33 +0000 (21:45 -0500)]
DAO - Centralize logic to derive unique name from label
This function checks db indices to enforce uniqueness of "name" column
when creating a new record via the `DAO::writeRecord()` method.
Seamus Lee [Thu, 20 Jan 2022 07:19:59 +0000 (18:19 +1100)]
Merge pull request #22584 from civicrm/5.46
Merge pull request #22583 from seamuslee001/update_jquery_ui
Seamus Lee [Thu, 20 Jan 2022 07:19:34 +0000 (18:19 +1100)]
Merge pull request #22583 from seamuslee001/update_jquery_ui
[REF] Upgrade JQuery UI to 1.13.0
Seamus Lee [Thu, 20 Jan 2022 06:44:15 +0000 (17:44 +1100)]
Merge pull request #22582 from civicrm/5.46
5.46
Eileen McNaughton [Wed, 19 Jan 2022 23:34:26 +0000 (12:34 +1300)]
Simplify apiv4 conformance test
The use of services meant this test failed if you didn't do
something or other (maybe some flushing - I never did figure it
out) & is an unnecessary complexity.
Seamus Lee [Thu, 20 Jan 2022 03:46:22 +0000 (14:46 +1100)]
Merge pull request #21865 from colemanw/SearchKitTags
SearchKit - add/remove tags action for all taggable entities
Seamus Lee [Thu, 20 Jan 2022 03:45:37 +0000 (14:45 +1100)]
Merge pull request #22537 from jensschuppe/fix/typeErrorCustomFieldTokens
[dev/core#3029] Avoid risking a TypeError when evaluating tokens for non-existent custom fields
Noah Miller [Thu, 20 Jan 2022 02:32:56 +0000 (18:32 -0800)]
translate 2-digit years to 4 using rolling -95yr to +5yr window
Seamus Lee [Thu, 20 Jan 2022 01:08:33 +0000 (12:08 +1100)]
Merge pull request #22577 from braders/remove-method-getWordReplacement
Remove method getWordReplacement.
colemanw [Thu, 20 Jan 2022 00:45:08 +0000 (19:45 -0500)]
Merge pull request #22576 from seamuslee001/update_jquery_ui
[REF] Upgrade JQuery UI to 1.13.0
Tim Otten [Thu, 20 Jan 2022 00:00:34 +0000 (16:00 -0800)]
Merge pull request #22574 from braders/send_unsub_response-phpdoc
(NFC) Minor phpdoc fixes to CRM_Mailing_Event_BAO_Unsubscribe::send_unsub_response
colemanw [Wed, 19 Jan 2022 22:50:28 +0000 (17:50 -0500)]
Merge pull request #22480 from eileenmcnaughton/create_date
Add created_date & modified_date to civicrm_relationship
Bradley Taylor [Wed, 19 Jan 2022 22:31:50 +0000 (22:31 +0000)]
Remove method getWordReplacement.
It appears to have never been used since its introduction 8 years ago,
and furthermore calls functions which don't exist.
Therefore, it would be unlikely to work even if it were used.
Seamus Lee [Wed, 19 Jan 2022 22:30:49 +0000 (09:30 +1100)]
Merge pull request #22575 from braders/getGroupByFromSelectColumns-tidy
(NFC) Minor amends to getGroupByFromSelectColumns
Seamus Lee [Wed, 19 Jan 2022 22:27:36 +0000 (09:27 +1100)]
[REF] Upgrade JQuery UI to 1.13.0
Bradley Taylor [Wed, 19 Jan 2022 20:05:32 +0000 (20:05 +0000)]
(NFC) Minor amends to getGroupByFromSelectColumns
Bradley Taylor [Wed, 19 Jan 2022 19:24:16 +0000 (19:24 +0000)]
(NFC) Minor phpdoc fixes to CRM_Mailing_Event_BAO_Unsubscribe::send_unsub_response
Eileen McNaughton [Wed, 19 Jan 2022 19:03:26 +0000 (08:03 +1300)]
Merge pull request #22562 from braders/hook-preevent-docblock
(NFC) Correctly document CRM_Utils_Hook::pre to allow null ID
Eileen McNaughton [Wed, 19 Jan 2022 19:02:30 +0000 (08:02 +1300)]
Merge pull request #22573 from colemanw/componentFn
[REF] Components - Use extracted function
Coleman Watts [Tue, 18 Jan 2022 01:02:54 +0000 (20:02 -0500)]
SearchKit - Update operator labels
Coleman Watts [Wed, 19 Jan 2022 16:01:30 +0000 (11:01 -0500)]
Components - Use extracted function
Uses function extracted in #22567
colemanw [Wed, 19 Jan 2022 14:29:42 +0000 (09:29 -0500)]
Merge pull request #22458 from eileenmcnaughton/test
dev/core#2757 test to demonstrate contact delete actions were not called for v4 api
yashodha [Wed, 19 Jan 2022 10:42:10 +0000 (16:12 +0530)]
(dev/core#3012) Expose more options for email on hold as filter for lybunt report
Eileen McNaughton [Wed, 19 Jan 2022 07:59:33 +0000 (20:59 +1300)]
Merge pull request #22565 from braders/report-form-docblock
(NFC) CiviReport, etal - More phpdoc fixes
Eileen McNaughton [Wed, 19 Jan 2022 05:43:42 +0000 (18:43 +1300)]
Merge pull request #22507 from colemanw/searchImportCleanup
[REF] SearchKit - Simplify import/export popup code
Seamus Lee [Wed, 19 Jan 2022 04:53:03 +0000 (15:53 +1100)]
Merge pull request #22568 from demeritcowboy/details-wrong-name
Activity Details field on batch update via profile has wrong fieldname
Eileen McNaughton [Wed, 12 Jan 2022 03:00:59 +0000 (16:00 +1300)]
Add created_date & modified_date to civicrm_relationship
As with other tables we have done this to, knowing when we added a record to the
DB is useful (and differs from the relationship start_date).
I'm not sure yet if I will try to expose in the UI or whether search-kit
is all we need