Eileen McNaughton [Fri, 8 Dec 2023 04:53:12 +0000 (17:53 +1300)]
Merge pull request #28575 from seamuslee001/dev_core_4833
dev/core#4833 Add unit test for legacy invoice number format
Eileen McNaughton [Fri, 8 Dec 2023 04:18:11 +0000 (17:18 +1300)]
Merge pull request #28395 from eileenmcnaughton/membership_new
dev/core#4826 Attempt at adding is_new to membership status
demeritcowboy [Fri, 8 Dec 2023 04:15:59 +0000 (23:15 -0500)]
Merge pull request #28301 from ixiam/dev/core#4796
dev/core#4796 - Fix Cancel button on the "unsubscribe mailing"
colemanw [Thu, 7 Dec 2023 22:00:00 +0000 (17:00 -0500)]
Fix is_new sql in MembershipStatus
Eileen McNaughton [Fri, 8 Dec 2023 03:27:46 +0000 (16:27 +1300)]
Merge pull request #28570 from eileenmcnaughton/label
Remove unused variable
colemanw [Fri, 8 Dec 2023 02:05:41 +0000 (21:05 -0500)]
Merge pull request #28573 from eileenmcnaughton/import_ss
Fix duplicate instance of Spreadsheet import class
demeritcowboy [Fri, 8 Dec 2023 01:59:31 +0000 (20:59 -0500)]
Merge pull request #28571 from eileenmcnaughton/unused
Remove unused variable
demeritcowboy [Fri, 8 Dec 2023 01:45:53 +0000 (20:45 -0500)]
Merge pull request #28572 from eileenmcnaughton/unused_2
remove unused variable
demeritcowboy [Fri, 8 Dec 2023 01:41:45 +0000 (20:41 -0500)]
Merge pull request #28576 from eileenmcnaughton/noticey
Do not suppress appropriate notices
Eileen McNaughton [Fri, 8 Dec 2023 00:12:42 +0000 (13:12 +1300)]
Do not suppress appropriate notices
If getVar is used to get a non-existent property then emitting
a notice is the right behaviour
Seamus Lee [Thu, 7 Dec 2023 23:50:58 +0000 (10:50 +1100)]
Merge pull request #28474 from twomice/4833_x_invoice_num_alphanumeric
POC: toward dev/core#4833: this does fix the problem.
Eileen McNaughton [Thu, 7 Dec 2023 23:42:17 +0000 (12:42 +1300)]
Merge pull request #28521 from eileenmcnaughton/smarty_warn
Add system check encouraging Smarty3
Seamus Lee [Thu, 7 Dec 2023 23:11:52 +0000 (10:11 +1100)]
dev/core#4833 Add unit test for legacy invoice number format
Eileen McNaughton [Thu, 7 Dec 2023 20:23:09 +0000 (09:23 +1300)]
Fix duplicate instance of Spreadsheet import class
When I revisited this code & prepared for PR I thought I had lost the Spreadsheet class,
not realising I put it in the civiimport - this consolidates the 2 versions into
the extension.
Note that I am on the fence on whether this should be in the extension
or with the others, reflected in the fact I put it in 2 different places on
2 different occasions. I got some support for the extension on chat
so consolidated there
https://chat.civicrm.org/civicrm/pl/xfp4cytepir7jk7axis7aftqye
Eileen McNaughton [Thu, 7 Dec 2023 19:45:15 +0000 (08:45 +1300)]
remove unused variable
Eileen McNaughton [Thu, 7 Dec 2023 19:42:56 +0000 (08:42 +1300)]
Remove unused variable
Eileen McNaughton [Thu, 7 Dec 2023 19:38:38 +0000 (08:38 +1300)]
Remove unused variable
Eileen McNaughton [Thu, 7 Dec 2023 19:09:10 +0000 (08:09 +1300)]
Merge pull request #28484 from 19ATF72/mailing-searchkit-afform
Add searchkit and afform display
Tim Otten [Thu, 7 Dec 2023 17:25:29 +0000 (17:25 +0000)]
Tweak Smarty messaging
Rich Lott [Thu, 7 Dec 2023 18:39:40 +0000 (18:39 +0000)]
Merge pull request #28563 from artfulrobot/artfulrobot-fix-docblock
Fix docblock for loadUser()
Rich Lott / Artful Robot [Thu, 7 Dec 2023 16:34:05 +0000 (16:34 +0000)]
Fix docblock for loadUser - parameter is a string
The dockblock says the user is an object, but it seems all implementations
provide a string, some adding explicit declarations as a string.
Allen Shaw [Mon, 4 Dec 2023 18:38:23 +0000 (12:38 -0600)]
Fix for dev/core#4833: Old-style Authorize.net ARB webhooks failing on x_invoice_num mismatch.
Matthew Wire [Thu, 7 Dec 2023 15:43:37 +0000 (15:43 +0000)]
Merge pull request #28561 from kcristiano/wputfix
add Query to AssetBuilder test to fix WP E2E test failures
Matthew Wire [Thu, 7 Dec 2023 15:42:26 +0000 (15:42 +0000)]
Merge pull request #28562 from vinay-osseed/typo-fixes
[NFC] Fix typo in `Localization.tpl` file.
colemanw [Thu, 7 Dec 2023 15:36:29 +0000 (10:36 -0500)]
Merge pull request #28538 from mattwire/ufmatch
Add unique constraint on ufmatch user ID+domain ID
Matthew Wire [Wed, 6 Dec 2023 12:14:22 +0000 (12:14 +0000)]
Add unique constraint on ufmatch user ID
vinay-osseed [Thu, 7 Dec 2023 14:06:24 +0000 (19:36 +0530)]
typo fix in `Localization.tpl` file.
Rich Lott [Thu, 7 Dec 2023 11:40:42 +0000 (11:40 +0000)]
Merge pull request #28532 from wmortada/standalone-user-delete
Standalone - prevent users from deleting own user
William Mortada [Wed, 6 Dec 2023 00:12:51 +0000 (00:12 +0000)]
Standalone - prevent users from deleting own user
Kevin Cristiano [Thu, 7 Dec 2023 11:36:55 +0000 (11:36 +0000)]
add Query to AssetBuilder test to fix WP failures
Signed-off-by: Kevin Cristiano <kcristiano@kcristiano.com>
Rich Lott [Thu, 7 Dec 2023 09:27:04 +0000 (09:27 +0000)]
Merge pull request #28471 from artfulrobot/artfulrobot-cleanup-standalone-tpls
Standalone: clean up styling on login/reset password
Rich Lott / Artful Robot [Mon, 4 Dec 2023 15:12:00 +0000 (15:12 +0000)]
standalone: clean up styling on login/reset password
Matthew Wire [Thu, 7 Dec 2023 08:07:53 +0000 (08:07 +0000)]
Merge pull request #28552 from eileenmcnaughton/uf_group_dao
Fix UFGroup add to call writeRecord
demeritcowboy [Thu, 7 Dec 2023 05:59:28 +0000 (00:59 -0500)]
Merge pull request #28554 from eileenmcnaughton/map_field
Fix test to not do weird form-trait sharing thing
Eileen McNaughton [Thu, 7 Dec 2023 03:10:14 +0000 (16:10 +1300)]
Fix test to not do weird form-trait sharing thing
Tim Otten [Thu, 7 Dec 2023 00:22:16 +0000 (00:22 +0000)]
Merge pull request #28551 from totten/master-regen
Regen
Eileen McNaughton [Wed, 6 Dec 2023 23:36:31 +0000 (12:36 +1300)]
Merge pull request #28543 from vingle/patch-15
Fixes Advanced Search regression in #28418
Tim Otten [Wed, 6 Dec 2023 23:27:57 +0000 (23:27 +0000)]
Merge pull request #28496 from eileenmcnaughton/master_import
dev/core#4447 fix inability to import to master_id
Eileen McNaughton [Wed, 6 Dec 2023 23:18:19 +0000 (12:18 +1300)]
Fix UFGroup add to call writeRecord
Tim Otten [Wed, 6 Dec 2023 23:16:51 +0000 (23:16 +0000)]
Regen
Matthew Wire [Wed, 6 Dec 2023 21:56:41 +0000 (21:56 +0000)]
Merge pull request #28546 from aydun/searchui_labelformats
SearchUI - Updates to Label Format display
Rich Lott [Wed, 6 Dec 2023 21:51:17 +0000 (21:51 +0000)]
Merge pull request #28541 from vingle/accordion-css
Accordions css – tidies up / bug fixes / simplifies theming / adds two utility classes
Matthew Wire [Wed, 6 Dec 2023 21:48:06 +0000 (21:48 +0000)]
Merge pull request #28495 from eileenmcnaughton/import
Add support for spreadsheet format in imports
Seamus Lee [Wed, 6 Dec 2023 21:46:24 +0000 (08:46 +1100)]
Merge pull request #28548 from civicrm/5.68
5.68
Matthew Wire [Wed, 6 Dec 2023 21:43:59 +0000 (21:43 +0000)]
Merge pull request #27107 from kurund/afform-email-confirmation
dev/core#4232 Afform: Allow manual processing of submission
Nicol [Wed, 6 Dec 2023 21:30:34 +0000 (21:30 +0000)]
removes change to common.js
Nicol [Wed, 6 Dec 2023 21:29:26 +0000 (21:29 +0000)]
Merge branch 'civicrm:master' into patch-15
Eileen McNaughton [Wed, 6 Dec 2023 03:27:49 +0000 (16:27 +1300)]
Test-notice-fix
Eileen McNaughton [Wed, 6 Dec 2023 03:01:23 +0000 (16:01 +1300)]
Adapt test to still have 2 same-address & 1 different address contacts
The BAO change meant the 2 addresses that were meant to be different,
but were shared, became the same, so I had to tweak the test
data to create the 2 same & 1 different scenario
Eileen McNaughton [Tue, 5 Dec 2023 06:25:39 +0000 (19:25 +1300)]
dev/core#4447 fix inability to import to master_id
Eileen McNaughton [Wed, 6 Dec 2023 21:12:09 +0000 (10:12 +1300)]
Merge pull request #28497 from eileenmcnaughton/pledge
Sample data fixes for contribution pages
Nicol [Wed, 6 Dec 2023 21:03:33 +0000 (21:03 +0000)]
Restores 'active' display script function that was lost during <details> conversion
Nicol [Wed, 6 Dec 2023 21:01:58 +0000 (21:01 +0000)]
Tightens targeting of AccordionToggle JS
Nicol [Wed, 6 Dec 2023 21:00:30 +0000 (21:00 +0000)]
Targets the crmAccordionToggle more tightly
So as to not hide the <details> content.
Nicol [Wed, 6 Dec 2023 20:59:31 +0000 (20:59 +0000)]
Merge branch 'civicrm:master' into patch-15
Seamus Lee [Wed, 6 Dec 2023 20:53:17 +0000 (07:53 +1100)]
Merge pull request #28547 from alifrumin/5.68rnlate
[NFC] 5.68 release note late changes
Eileen McNaughton [Wed, 6 Dec 2023 20:26:14 +0000 (09:26 +1300)]
Merge pull request #28504 from yashodha/report-fixess
Add filter on archived in Mailing Summary report
Eileen McNaughton [Wed, 6 Dec 2023 20:25:13 +0000 (09:25 +1300)]
Merge pull request #28545 from aydun/labelformat_metadata
Munge paths for labelFormats
Nicol [Wed, 6 Dec 2023 20:18:57 +0000 (20:18 +0000)]
Opens first three regions
Matches behavior of old Advanced Search.
Nicol [Wed, 6 Dec 2023 20:10:30 +0000 (20:10 +0000)]
Keeps main Advanced Searchd details always open
Nicol [Wed, 6 Dec 2023 20:09:14 +0000 (20:09 +0000)]
Merge branch 'civicrm:master' into patch-15
Eileen McNaughton [Wed, 6 Dec 2023 20:03:09 +0000 (09:03 +1300)]
Merge pull request #28544 from aydun/premiums_metadata
Premiums metadata
Eileen McNaughton [Wed, 6 Dec 2023 20:02:39 +0000 (09:02 +1300)]
Merge pull request #28534 from pradpnayak/mappingseaechkit
Use the action definded in DAO for Mapping
Alice Frumin [Wed, 6 Dec 2023 19:54:55 +0000 (14:54 -0500)]
[NFC] 5.68 release note late changes
Aidan Saunders [Wed, 6 Dec 2023 19:03:04 +0000 (19:03 +0000)]
Updates to Label Format display
Aidan Saunders [Wed, 6 Dec 2023 18:21:03 +0000 (18:21 +0000)]
Munge paths for labelFormats
Nicol [Wed, 6 Dec 2023 18:17:27 +0000 (18:17 +0000)]
Removes accordion body border when there shouldn't be one
Civi has two styles of accordions: with a border around it and without. This commit removes a third style – a border around half which isn't intentional and is a byproduct of the new html.
demeritcowboy [Wed, 6 Dec 2023 18:07:29 +0000 (13:07 -0500)]
Merge pull request #28468 from jaapjansma/timezone
dev/core#4410: fixed timezone support for standalone
Aidan Saunders [Wed, 6 Dec 2023 18:06:15 +0000 (18:06 +0000)]
Merge pull request #28513 from wyde22/newuiLabelFormat-dewy
searchui : new screen label format
Nicol [Wed, 6 Dec 2023 18:05:09 +0000 (18:05 +0000)]
Merge branch 'civicrm:master' into accordion-css
Aidan Saunders [Wed, 6 Dec 2023 17:25:20 +0000 (17:25 +0000)]
Regen
Aidan Saunders [Wed, 6 Dec 2023 17:24:07 +0000 (17:24 +0000)]
Path mangling for managePremiums
Nicol [Wed, 6 Dec 2023 17:36:52 +0000 (17:36 +0000)]
Fixes UI regression in #28418
Some advanced search accordion regions have a close button on the right – clicking this 'deactivites' the region from the search, and with the recent changes it also makes the expanded region hidden.
This removes the line of JS responsible for that.
Kurund Jalmi [Wed, 6 Dec 2023 16:06:58 +0000 (16:06 +0000)]
contact token test fixes
Tim Otten [Wed, 6 Dec 2023 15:44:14 +0000 (15:44 +0000)]
Merge pull request #28525 from totten/master-pw-rst
standaloneusers - Fix tokens+docblocks for "Password reset" email
Kurund Jalmi [Wed, 6 Dec 2023 15:33:37 +0000 (15:33 +0000)]
managetest fixes
Nicol [Wed, 6 Dec 2023 15:22:45 +0000 (15:22 +0000)]
Jenkins error fixes
'superfluous spaces'
Nicol [Wed, 6 Dec 2023 14:31:02 +0000 (14:31 +0000)]
accordion css fixes
Removes double icon from safari, simple nested accordion handling.
Nicol [Wed, 6 Dec 2023 14:10:29 +0000 (14:10 +0000)]
Adds utility class: .crm-accordion-light
A style to match Civi's transparent background, non-bold accordion header.
Commit also adds hover states and comments.
Nicol [Wed, 6 Dec 2023 14:02:06 +0000 (14:02 +0000)]
Adds hover state for accordion-bold
Nicol [Wed, 6 Dec 2023 13:57:44 +0000 (13:57 +0000)]
Adds utility class: .crm-accordion-bold
This allows new details/summary elements to be styled the same as the colour-bg crm-accordion-wrapper style. It also fixes a minor issue with border-radius changing on expand/collapse.
Nicol [Wed, 6 Dec 2023 13:23:59 +0000 (13:23 +0000)]
Applies theme expand/close icon to details/summary
Details/summary has a browser-generated expand/close caret. This PR restores Greenwich's FontAwesome caret/triangle - and provides the class names themers would need to include to make their choice of expand/close icons & animations apply to details/summary.
Matthew Wire [Wed, 6 Dec 2023 12:11:41 +0000 (12:11 +0000)]
Merge pull request #28528 from wmortada/standalone-users
Standalone - Improve administer user screen
colemanw [Wed, 6 Dec 2023 11:35:28 +0000 (11:35 +0000)]
Fix typo in smarty system check
Tim Otten [Tue, 5 Dec 2023 22:20:27 +0000 (22:20 +0000)]
standaloneusers - Fix tokens+docblocks for password-reset email
Tim Otten [Wed, 6 Dec 2023 11:01:55 +0000 (11:01 +0000)]
Merge pull request #28535 from eileenmcnaughton/master_test
Test-notice-fix affecting all tests
Eileen McNaughton [Wed, 6 Dec 2023 03:27:49 +0000 (16:27 +1300)]
Test-notice-fix
Eileen McNaughton [Wed, 6 Dec 2023 01:38:31 +0000 (14:38 +1300)]
Merge pull request #28531 from civicrm/5.68
5.68
Eileen McNaughton [Tue, 5 Dec 2023 07:30:45 +0000 (20:30 +1300)]
Sample data fixes for contribution pages
Matthew Wire [Wed, 6 Dec 2023 00:30:42 +0000 (00:30 +0000)]
Merge pull request #28387 from eileenmcnaughton/membership_block_save
dev/core#3994 Update membership block on membership type save & remove the same from the Manage form
Matthew Wire [Wed, 6 Dec 2023 00:29:13 +0000 (00:29 +0000)]
Merge pull request #28344 from eileenmcnaughton/move_set
Move form specific code out of shared function
Matthew Wire [Wed, 6 Dec 2023 00:28:43 +0000 (00:28 +0000)]
Merge pull request #28388 from asmac-org/formbuilder-textarea-support-rows-cols
Formbuilder: support rows and columns values for Note (textarea) custom field type
Matthew Wire [Wed, 6 Dec 2023 00:28:06 +0000 (00:28 +0000)]
Merge pull request #28386 from eileenmcnaughton/membership_types
Use apv4 rather than V3 for cached membershipTypes retrieval
Matthew Wire [Wed, 6 Dec 2023 00:27:08 +0000 (00:27 +0000)]
Merge pull request #28487 from eileenmcnaughton/price_notice
dev/core#3083 Add a warning about price fields where non_deductible amount potentially misconfigured
Matthew Wire [Wed, 6 Dec 2023 00:26:33 +0000 (00:26 +0000)]
Merge pull request #28493 from eileenmcnaughton/invoice
Consolidate invoice determination
Matthew Wire [Wed, 6 Dec 2023 00:26:08 +0000 (00:26 +0000)]
Merge pull request #28491 from eileenmcnaughton/dep
Update CustomField default_value to NULL instead of '' for floats
Matthew Wire [Wed, 6 Dec 2023 00:25:28 +0000 (00:25 +0000)]
Merge pull request #28483 from pradpnayak/dateprefAfform
Added DatePreference admin UI
Pradeep Nayak [Wed, 6 Dec 2023 00:25:02 +0000 (00:25 +0000)]
Use the action definded in DAO for Mapping
Matthew Wire [Wed, 6 Dec 2023 00:24:38 +0000 (00:24 +0000)]
Merge pull request #28482 from pradpnayak/datePrefAPI
Adding PreferencesDate API
Matthew Wire [Wed, 6 Dec 2023 00:23:52 +0000 (00:23 +0000)]
Merge pull request #28479 from eileenmcnaughton/add_payment_more
Clean up parameters in add payment form