Jitendra Purohit [Mon, 23 Sep 2019 04:55:46 +0000 (10:25 +0530)]
fix warning message on import contribution
colemanw [Sun, 22 Sep 2019 22:33:21 +0000 (18:33 -0400)]
Merge pull request #15309 from totten/master-api4
Migrate APIv4 into civicrm-core
Seamus Lee [Sun, 22 Sep 2019 22:19:29 +0000 (08:19 +1000)]
Merge pull request #15342 from seamuslee001/master
Update spelling of htmlpurifier to be correct spelling
Seamus Lee [Sun, 22 Sep 2019 21:13:20 +0000 (07:13 +1000)]
Merge pull request #15343 from colemanw/upgrader
Upgrader: handle missing obsolete extensions
Coleman Watts [Sun, 22 Sep 2019 20:50:32 +0000 (16:50 -0400)]
Remove extension-specific ts()
Coleman Watts [Sun, 22 Sep 2019 18:31:07 +0000 (14:31 -0400)]
Fix number fields in api explorer
Only use html5 number input when dealing with single valued input
Coleman Watts [Sun, 22 Sep 2019 17:49:00 +0000 (13:49 -0400)]
Upgrader: handle missing obsolete extensions
Seamus Lee [Sun, 22 Sep 2019 05:35:56 +0000 (15:35 +1000)]
Update spelling of htmlpurifier to be correct spelling
Seamus Lee [Sun, 22 Sep 2019 05:38:06 +0000 (15:38 +1000)]
Revert "Update spelling of htmlpurifier to be correct spelling"
This reverts commit
ebbfece35c3744450a591f5a59f44c469ee6d5cf.
Seamus Lee [Sun, 22 Sep 2019 05:35:56 +0000 (15:35 +1000)]
Update spelling of htmlpurifier to be correct spelling
Tim Otten [Fri, 20 Sep 2019 21:44:43 +0000 (14:44 -0700)]
api4 - Update civicrm_generated.mysql for new nav item
Seamus Lee [Fri, 20 Sep 2019 00:44:05 +0000 (10:44 +1000)]
Merge pull request #15333 from civicrm/5.18
5.18
Seamus Lee [Thu, 19 Sep 2019 23:20:38 +0000 (09:20 +1000)]
Merge pull request #15332 from agh1/5.18.0-releasenotes
5.18.0 release notes initial run
Seamus Lee [Thu, 19 Sep 2019 21:14:26 +0000 (07:14 +1000)]
Merge pull request #15331 from totten/master-api4-hush
Api3TestTrait - Only run api4 tests if api4 is present
Andrew Hunt [Thu, 19 Sep 2019 21:05:00 +0000 (17:05 -0400)]
5.18.0 release notes: added boilerplate
Andrew Hunt [Thu, 19 Sep 2019 21:01:52 +0000 (17:01 -0400)]
5.18.0 release notes: raw from script
Tim Otten [Thu, 19 Sep 2019 19:16:23 +0000 (15:16 -0400)]
Api3TestTrait - Only run api4 tests if api4 is present
Tim Otten [Wed, 18 Sep 2019 23:59:47 +0000 (19:59 -0400)]
distmaker - Remove steps to download api4 as extension
This is no longer necessary since it's part of core!
Tim Otten [Wed, 18 Sep 2019 23:54:07 +0000 (19:54 -0400)]
composer.json - Add "ignore" list for js-yaml
Seamus Lee [Wed, 18 Sep 2019 21:33:15 +0000 (07:33 +1000)]
Merge pull request #15325 from totten/master-mailing-options
Mailing API - Expose option list for `header_id` and `footer_id`
Tim Otten [Wed, 18 Sep 2019 17:15:36 +0000 (13:15 -0400)]
Mailing API - Expose option list for `header_id` and `footer_id`
colemanw [Wed, 18 Sep 2019 13:33:24 +0000 (09:33 -0400)]
Merge pull request #15320 from jitendrapurohit/dev-1264
dev/core#1264 - Fix notice error on contribution page
colemanw [Wed, 18 Sep 2019 13:22:43 +0000 (09:22 -0400)]
Merge pull request #15319 from vinuvarshith/dev-core-1262-case-status-order
dev/core#1262 - Fix case status order in case type settings page
Jitendra Purohit [Wed, 18 Sep 2019 09:26:58 +0000 (14:56 +0530)]
dev/core#1264 - Fix notice error on contribution page
varshith89 [Wed, 18 Sep 2019 07:42:24 +0000 (07:42 +0000)]
dev/core#1262 - Fix case status order in case type settings page
Coleman Watts [Tue, 17 Sep 2019 12:48:14 +0000 (08:48 -0400)]
Add api4 menu item
Seamus Lee [Tue, 17 Sep 2019 22:01:21 +0000 (08:01 +1000)]
Merge pull request #15317 from elisseck/dev/core/1259
dev/core/1259 update config checklist contribution section
Seamus Lee [Tue, 17 Sep 2019 21:30:13 +0000 (07:30 +1000)]
Merge pull request #15168 from MegaphoneJon/class-fixes
core#1225 fix Event Info and Contribution Page Settings templates
Eli Lisseck [Tue, 17 Sep 2019 17:35:59 +0000 (10:35 -0700)]
dev/core/1259 update config checklist contribution section
Coleman Watts [Mon, 16 Sep 2019 20:31:24 +0000 (16:31 -0400)]
Fix api explorer module loading
Coleman Watts [Mon, 16 Sep 2019 15:41:05 +0000 (11:41 -0400)]
Api4 generated code improvements
Ports https://github.com/civicrm/org.civicrm.api4/pull/201 to core.
Coleman Watts [Mon, 16 Sep 2019 15:00:08 +0000 (11:00 -0400)]
Update namespace for phpunit6 compat
Coleman Watts [Mon, 16 Sep 2019 12:09:05 +0000 (08:09 -0400)]
Test fixes
Tim Otten [Sun, 15 Sep 2019 19:24:57 +0000 (15:24 -0400)]
api4 - Search for entities in core (for realz)
Tim Otten [Sun, 15 Sep 2019 18:19:06 +0000 (14:19 -0400)]
api4 - Fix container cache/reload behavior
In the extension's `tests/phpunit/bootstrap.php`, it forced the container to
*never* use caching. I suspect this was because of two problems:
1. APIv4 does a directory scan for services, but it didn't inform
the container that this directory was important.
2. APIv4 registers additional services for a test environment, but the
caching system didn't allow different caches for live-vs-test env's.
Tim Otten [Sun, 15 Sep 2019 18:12:52 +0000 (14:12 -0400)]
api4 - Fix computation of core path
The `$locations` array mostly contains the paths of *extension PHP files*,
and the subsequent code filters with`dirname()` to strip them out.
Before: The path `/var/www/sites/all/modules/civicrm` was digested to
`/var/www/sites/all/modules/Civi/Api4/Subscribers`.
After: The path `/var/www/sites/all/modules/civicrm/Civi.php` is digested
`/var/www/sites/all/modules/civicrm/Civi/Api4/Subscribers`.
Tim Otten [Sun, 15 Sep 2019 17:17:38 +0000 (13:17 -0400)]
(NFC) Pass both civilint and ReflectionUtilsTest
Coleman Watts [Sun, 15 Sep 2019 14:51:54 +0000 (10:51 -0400)]
Scan core as well as extensions for api4 entities & services
colemanw [Sun, 15 Sep 2019 14:23:27 +0000 (10:23 -0400)]
Search for entity-specific actions in core
CiviCRM [Sun, 15 Sep 2019 03:48:45 +0000 (23:48 -0400)]
api4 - Update test init
CiviCRM [Sun, 15 Sep 2019 03:48:45 +0000 (23:48 -0400)]
api4 - Adjust to new name
CiviCRM [Sun, 15 Sep 2019 03:48:45 +0000 (23:48 -0400)]
api4 - Import CRM/, Civi/, templates/, ang/, css/, js/, xml/menu
colemanw [Sun, 15 Sep 2019 21:55:39 +0000 (17:55 -0400)]
Merge pull request #15310 from totten/master-api-examples
(DX) api/v3/examples - Rename *.php to *.ex.php
Tim Otten [Sun, 15 Sep 2019 18:58:48 +0000 (14:58 -0400)]
APIExplorer - Load examples from *.ex.php
Tim Otten [Sun, 15 Sep 2019 18:54:37 +0000 (14:54 -0400)]
tests/phpunit - Change hardcoded references to api/v3/examples/**.php
Tim Otten [Sun, 15 Sep 2019 18:47:06 +0000 (14:47 -0400)]
Api3DocTrait - Generate future examples as `*.ex.php`
Tim Otten [Sun, 15 Sep 2019 18:45:50 +0000 (14:45 -0400)]
api/v3/examples - Rename *.php to *.ex.php
Eileen McNaughton [Sun, 15 Sep 2019 08:53:29 +0000 (20:53 +1200)]
Merge pull request #15302 from seamuslee001/export_hook_alter_sig
Stop passing exportMode, componentTable and ids by reference in export hook
CiviCRM [Sun, 15 Sep 2019 03:48:43 +0000 (23:48 -0400)]
api4 - Enable services
CiviCRM [Sun, 15 Sep 2019 03:48:43 +0000 (23:48 -0400)]
api4 - Add civicrm_api4() and CRM.api4() entry-points
CiviCRM [Sun, 15 Sep 2019 03:48:43 +0000 (23:48 -0400)]
api4 - Port PHPUnit autoloading hacks
Seamus Lee [Sun, 15 Sep 2019 01:41:23 +0000 (11:41 +1000)]
Merge pull request #15262 from yashodha/report_cleanup
CRM-21677 - report clean up for contribution reports
Coleman Watts [Sat, 14 Sep 2019 22:45:22 +0000 (18:45 -0400)]
Handle new flattened custom field return format
Coleman Watts [Sat, 14 Sep 2019 22:39:32 +0000 (18:39 -0400)]
Obsolete api4 extension
Tim Otten [Sat, 14 Sep 2019 16:18:19 +0000 (12:18 -0400)]
Merge pull request #15295 from colemanw/jsEncode2
CRM_Utils_JS - Improve encode handling of strings
Tim Otten [Sat, 14 Sep 2019 15:59:23 +0000 (11:59 -0400)]
Merge pull request #15308 from colemanw/prioriy
[NFC] Reword event docs to clarify priority vs weight
Coleman Watts [Sat, 14 Sep 2019 14:22:03 +0000 (10:22 -0400)]
Reword event docs to clarify priority vs weight
Seamus Lee [Fri, 13 Sep 2019 20:41:34 +0000 (06:41 +1000)]
Also stop passing exportMode by reference in the hook and add deprecated function warning for if change
Eileen McNaughton [Fri, 13 Sep 2019 13:30:45 +0000 (01:30 +1200)]
Merge pull request #15303 from agileware/CIVICRM-1310
Update CiviCRM contributors.txt
Seamus Lee [Fri, 13 Sep 2019 05:49:09 +0000 (15:49 +1000)]
Merge pull request #15301 from seamuslee001/dev_core_1245_2
[NFC] Add in code comments about the column default issue with is_ema…
Justin Freeman [Fri, 13 Sep 2019 05:07:41 +0000 (15:07 +1000)]
CIVICRM-1310 Update CiviCRM contributors.txt - remove Alok and add Pengyi
Eileen McNaughton [Fri, 13 Sep 2019 04:29:01 +0000 (16:29 +1200)]
Merge pull request #15300 from civicrm/5.18
5.18
Seamus Lee [Fri, 13 Sep 2019 03:55:48 +0000 (13:55 +1000)]
[NFC] Add in code comments about the column default issue with is_email_receipt in case anyone else comes across this
Seamus Lee [Fri, 13 Sep 2019 03:52:49 +0000 (13:52 +1000)]
Stop passing componentTable and ids by reference
Tim Otten [Fri, 13 Sep 2019 03:17:07 +0000 (23:17 -0400)]
Merge pull request #15299 from seamuslee001/5.18
Add release-notes/5.17.4
Tim Otten [Fri, 13 Sep 2019 03:11:32 +0000 (23:11 -0400)]
Add release-notes/5.17.4
Tim Otten [Fri, 13 Sep 2019 03:04:03 +0000 (23:04 -0400)]
Merge pull request #15296 from eileenmcnaughton/518
dev/core#1241 : Custom field value for a new Event based on an Event …
Monish Deb [Thu, 12 Sep 2019 09:10:43 +0000 (14:40 +0530)]
dev/core#1241 : Custom field value for a new Event based on an Event Template are not checked causing false validation message and Event not to save
Coleman Watts [Fri, 13 Sep 2019 01:58:23 +0000 (21:58 -0400)]
CRM_Utils_JS - Fix backslash handling
Coleman Watts [Thu, 12 Sep 2019 16:45:20 +0000 (12:45 -0400)]
CRM_Utils_JS - Improve encode handling of strings
Eileen McNaughton [Thu, 12 Sep 2019 02:00:16 +0000 (14:00 +1200)]
Merge pull request #15290 from civicrm/5.18
5.18
Eileen McNaughton [Thu, 12 Sep 2019 01:59:27 +0000 (13:59 +1200)]
Merge pull request #15289 from colemanw/export-rc
dev/core#1246 fix fatal error on search builder if a core contact type is disabled
Eileen McNaughton [Thu, 12 Sep 2019 01:59:09 +0000 (13:59 +1200)]
Merge pull request #15287 from MegaphoneJon/core-1247-518
Fix for core#1247 - export hook doesn't work
Tim Otten [Thu, 12 Sep 2019 00:48:10 +0000 (17:48 -0700)]
Merge pull request #15285 from colemanw/jsencode
Add CRM_Utils_JS::encode function
Seamus Lee [Thu, 12 Sep 2019 00:29:36 +0000 (10:29 +1000)]
Merge pull request #15282 from christianwach/lab-1200-2
Ensure Dashboard domain ID is set even when passed as a param
eileen [Wed, 11 Sep 2019 07:13:34 +0000 (19:13 +1200)]
dev/core#1246 fix fatal error on search builder if a core contact type is disabled.
https://lab.civicrm.org/dev/core/issues/1246
Seamus Lee [Wed, 11 Sep 2019 23:33:46 +0000 (09:33 +1000)]
Merge pull request #15228 from jitendrapurohit/15094-test
Unit test for #15094 fix
Eileen McNaughton [Wed, 11 Sep 2019 23:33:12 +0000 (11:33 +1200)]
Merge pull request #15288 from seamuslee001/5.18
Add release notes for 5.17.3
Tim Otten [Wed, 11 Sep 2019 04:47:13 +0000 (21:47 -0700)]
Add release notes for 5.17.3
Jon Goldberg [Tue, 10 Sep 2019 16:15:31 +0000 (12:15 -0400)]
Fix for core#1247 - export hook doesn't work
Coleman Watts [Wed, 11 Sep 2019 21:51:47 +0000 (17:51 -0400)]
Add CRM_Utils_JS::encode function
Eileen McNaughton [Wed, 11 Sep 2019 18:22:18 +0000 (06:22 +1200)]
Merge pull request #15280 from mattwire/formatpaymentparams
REF Make the formatParamsForPaymentProcessor function more generic so it can be used more
Matthew Wire (MJW Consulting) [Tue, 10 Sep 2019 22:40:24 +0000 (23:40 +0100)]
Make the formatParamsForPaymentProcessor function more generic so it can be used more
Christian Wach [Wed, 11 Sep 2019 12:20:44 +0000 (13:20 +0100)]
Ensure Dashboard domain ID is set even when passed as a param
Eileen McNaughton [Wed, 11 Sep 2019 09:23:45 +0000 (21:23 +1200)]
Merge pull request #15094 from mattwire/devcore792_membershipcontributionfail
dev/core#792 Fix Contributions not recording if selected membership is none when using a membership priceset
Eileen McNaughton [Wed, 11 Sep 2019 07:28:50 +0000 (19:28 +1200)]
Merge pull request #15263 from JMAConsulting/financial-67
financial#67 : Check number doesn't show up if payment method name - Check changed to Cheque
Seamus Lee [Wed, 11 Sep 2019 07:13:44 +0000 (17:13 +1000)]
Merge pull request #15272 from seamuslee001/dev_financial_68
dev/financial#68 Ensure that check number is correctly passed through…
Seamus Lee [Wed, 11 Sep 2019 03:08:17 +0000 (13:08 +1000)]
Extend contribution api test to ensure that if check_number is specified in unique field it is still correctly stored
Add in a unit test to test setting check_number with original field
Eileen McNaughton [Wed, 11 Sep 2019 03:07:53 +0000 (15:07 +1200)]
Merge pull request #15270 from civicrm/5.18
5.18
Eileen McNaughton [Wed, 11 Sep 2019 03:07:33 +0000 (15:07 +1200)]
Merge pull request #15275 from eileenmcnaughton/email
Trim form values when adding LIKE operator
Eileen McNaughton [Wed, 11 Sep 2019 03:07:17 +0000 (15:07 +1200)]
Merge pull request #15276 from eileenmcnaughton/email2
Ensure filtering on email via the api looks for an exact match
Eileen McNaughton [Wed, 11 Sep 2019 01:53:41 +0000 (13:53 +1200)]
Merge pull request #15273 from eileenmcnaughton/518
Fix unreleased regression on batch merge through the UI
Eileen McNaughton [Wed, 11 Sep 2019 01:53:25 +0000 (13:53 +1200)]
Merge pull request #15274 from totten/master-deadcode
(REF) Remove unused functions, setTemplateMenuValues() and getNavigation()
eileen [Wed, 11 Sep 2019 01:49:06 +0000 (13:49 +1200)]
Ensure filtering on email via the api looks for an exact match
eileen [Wed, 11 Sep 2019 01:33:36 +0000 (13:33 +1200)]
Trim form values when adding LIKE operator
This is more consistent with previous behaviour - ie 'info@civicrm.org' AND 'info@civicrm.org ' should work.
Tim Otten [Tue, 10 Sep 2019 23:39:26 +0000 (16:39 -0700)]
(REF) Remove unused function CRM_Core_Menu::getNavigation()
I stumbled across this function while grepping to cleanup up
`userFrameworkURLVar` (dev/drupal#52). Notice the first line of the
function throws a fatal error. That line has been there since at least
CiviCRM v4.3.
https://github.com/civicrm/civicrm-core/blob/4.3/CRM/Core/Menu.php#L310
Unsurprisingly, if you grep for `getNavigation`, there are no calls to this
function.
Tim Otten [Tue, 10 Sep 2019 23:33:32 +0000 (16:33 -0700)]
(REF) Remove unused function CRM_Core_Block::setTemplateMenuValues
Note that this is a `private` function, so any hypothetical callers must be
in the same class. There don't appear to be any.
Could there be some dynamic method calls? Well, you'd expect there to be
some tell-tale such as references to `call_*()` or to a string which builds
up that method name from smaller strings ("set" or "MenuValues" or similar).
Nothing comes up.
eileen [Tue, 10 Sep 2019 23:17:33 +0000 (11:17 +1200)]
Fix unreleased regression on batch merge through the UI
We made searchLimit part of the cacheKey for found batches but in this place missed passing it in,
leading to it not picking up the relevant cached entries & skipping them. Affects 5.18 rc & master
Seamus Lee [Tue, 10 Sep 2019 23:22:02 +0000 (09:22 +1000)]
Add a unit test to ensure that check_number when submitted to the form as contribution_check_number is correctly saved into the financial Transaction
Seamus Lee [Tue, 10 Sep 2019 23:06:40 +0000 (09:06 +1000)]
dev/financial#68 Ensure that check number is correctly passed through when processing a contribution or membership batch