civicrm-core.git
10 years agoCRM-17232 - Remove reference to undefined ck
Coleman Watts [Tue, 29 Sep 2015 20:42:26 +0000 (16:42 -0400)]
CRM-17232 - Remove reference to undefined ck

10 years agoMerge pull request #6846 from colemanw/CRM-16444
colemanw [Tue, 29 Sep 2015 19:55:07 +0000 (15:55 -0400)]
Merge pull request #6846 from colemanw/CRM-16444

CRM-16444 - Cleanup CKEdior configurator to use Civi::paths()

10 years agoCRM-16444 - Cleanup CKEdior configurator to use Civi::paths()
Coleman Watts [Tue, 29 Sep 2015 19:50:56 +0000 (15:50 -0400)]
CRM-16444 - Cleanup CKEdior configurator to use Civi::paths()

10 years agoMerge pull request #6826 from eileenmcnaughton/CRM-17294
Eileen McNaughton [Tue, 29 Sep 2015 19:50:43 +0000 (08:50 +1300)]
Merge pull request #6826 from eileenmcnaughton/CRM-17294

CRM-17294 renamed fields not passed to processor

10 years agoMerge pull request #6842 from totten/master-req534
Tim Otten [Tue, 29 Sep 2015 17:28:02 +0000 (13:28 -0400)]
Merge pull request #6842 from totten/master-req534

Update minimum PHP to 5.3.4

10 years agoUpdate minimum PHP to 5.3.4
Tim Otten [Tue, 29 Sep 2015 15:34:26 +0000 (11:34 -0400)]
Update minimum PHP to 5.3.4

10 years agoMerge pull request #6839 from yashodha/CRM-17302
Yashodha Chaku [Tue, 29 Sep 2015 13:41:04 +0000 (19:11 +0530)]
Merge pull request #6839 from yashodha/CRM-17302

CRM-17302: Fix component for contribution activities

10 years agoMerge pull request #6743 from jitendrapurohit/CRM-17182
Monish Deb [Tue, 29 Sep 2015 12:15:42 +0000 (17:45 +0530)]
Merge pull request #6743 from jitendrapurohit/CRM-17182

CRM-17182 -- Renaming a price option / fee level breaks event partici…

10 years agoMerge pull request #6836 from yashodha/CRM-12675
Yashodha Chaku [Tue, 29 Sep 2015 11:42:12 +0000 (17:12 +0530)]
Merge pull request #6836 from yashodha/CRM-12675

CRM-12675: Contribution activities shown to users without permission

10 years agoMerge pull request #6840 from monishdeb/test-master
Monish Deb [Tue, 29 Sep 2015 10:50:18 +0000 (16:20 +0530)]
Merge pull request #6840 from monishdeb/test-master

CRM-17287 fix for XML Exports

10 years agoCRM-17287 fix for XML Exports
monishdeb [Tue, 29 Sep 2015 09:46:12 +0000 (15:16 +0530)]
CRM-17287 fix for XML Exports

----------------------------------------
* CRM-17287: Broken Unit Tests on master
  https://issues.civicrm.org/jira/browse/CRM-17287

10 years agoCRM-17302: Fix component for contribution activities
yashodha [Tue, 29 Sep 2015 09:36:00 +0000 (15:06 +0530)]
CRM-17302: Fix component for contribution activities

----------------------------------------
* CRM-17302: Fix component for contribution activities
  https://issues.civicrm.org/jira/browse/CRM-17302

10 years agoMerge pull request #6815 from eileenmcnaughton/CRM-17289
Eileen McNaughton [Tue, 29 Sep 2015 09:03:14 +0000 (22:03 +1300)]
Merge pull request #6815 from eileenmcnaughton/CRM-17289

CRM-17289 limit membership_type entity reference to active types

10 years agoMerge pull request #6831 from eileenmcnaughton/CRM-17176-api-add
Eileen McNaughton [Tue, 29 Sep 2015 08:04:13 +0000 (21:04 +1300)]
Merge pull request #6831 from eileenmcnaughton/CRM-17176-api-add

Crm 17176 api add navigation

10 years agoCRM-17289 add unite test for membership_type.getlist
eileenmcnaugton [Tue, 29 Sep 2015 07:59:14 +0000 (20:59 +1300)]
CRM-17289 add unite test for membership_type.getlist

10 years agotest class tidy-up
eileenmcnaugton [Tue, 29 Sep 2015 07:38:55 +0000 (20:38 +1300)]
test class tidy-up

Let's not over-do the failure tests! We brought them from v2 but they don't add much

10 years agoCRM-17289 limit membership_type entity reference to active types
eileenmcnaugton [Sun, 27 Sep 2015 21:42:58 +0000 (10:42 +1300)]
CRM-17289 limit membership_type entity reference to active types

10 years agoCRM-17176 add Navigation api
eileenmcnaugton [Tue, 29 Sep 2015 06:33:44 +0000 (19:33 +1300)]
CRM-17176 add Navigation api

Adding this was mostly to make the syntax conformance happy since adding a navigation.reset action:

10 years agoCRM-17176 add titles to navigation xml
eileenmcnaugton [Tue, 29 Sep 2015 06:30:59 +0000 (19:30 +1300)]
CRM-17176 add titles to navigation xml

10 years agoMerge pull request #6833 from eileenmcnaughton/email-test-fix
Eileen McNaughton [Tue, 29 Sep 2015 06:22:07 +0000 (19:22 +1300)]
Merge pull request #6833 from eileenmcnaughton/email-test-fix

enable Single Value Alter test for email

10 years agoenable Single Value Alter test for email
eileenmcnaugton [Tue, 29 Sep 2015 03:47:00 +0000 (16:47 +1300)]
enable Single Value Alter test for email

Conflicts:
tests/phpunit/api/v3/SyntaxConformanceTest.php

10 years agoCRM-12675: Contribution activities shown to users without permission
yashodha [Tue, 29 Sep 2015 04:52:50 +0000 (10:22 +0530)]
CRM-12675: Contribution activities shown to users without permission

----------------------------------------
* CRM-12675: Contribution activities shown to users without permission
  https://issues.civicrm.org/jira/browse/CRM-12675

10 years agoMerge pull request #6829 from davecivicrm/CRM-16086
Dave Greenberg [Tue, 29 Sep 2015 02:48:36 +0000 (22:48 -0400)]
Merge pull request #6829 from davecivicrm/CRM-16086

CRM-16086 - schema corrections.

10 years agoCRM-17294 renamed fields not passed to processor
eileenmcnaugton [Mon, 28 Sep 2015 10:48:28 +0000 (23:48 +1300)]
CRM-17294 renamed fields not passed to processor

10 years agoCRM-16086 - schema corrections.
Dave Greenberg [Tue, 29 Sep 2015 00:14:36 +0000 (20:14 -0400)]
CRM-16086 - schema corrections.

----------------------------------------
* CRM-16086: schema differences between upgrades and install
  https://issues.civicrm.org/jira/browse/CRM-16086

10 years agoMerge pull request #6828 from monishdeb/test-master
Dave Greenberg [Mon, 28 Sep 2015 23:21:56 +0000 (19:21 -0400)]
Merge pull request #6828 from monishdeb/test-master

CRM-17287 Test fix for contribution note

10 years agoformat fix
monishdeb [Mon, 28 Sep 2015 20:55:57 +0000 (02:25 +0530)]
format fix

10 years agoMerge forward miss
monishdeb [Mon, 28 Sep 2015 20:49:16 +0000 (02:19 +0530)]
Merge forward miss

10 years agoCRM-17287 Test fix for contribution note
monishdeb [Mon, 28 Sep 2015 20:24:41 +0000 (01:54 +0530)]
CRM-17287 Test fix for contribution note

----------------------------------------
* CRM-17287: Broken Unit Tests on master
  https://issues.civicrm.org/jira/browse/CRM-17287

10 years agoMerge pull request #6820 from eileenmcnaughton/master
Dave Greenberg [Mon, 28 Sep 2015 17:59:10 +0000 (13:59 -0400)]
Merge pull request #6820 from eileenmcnaughton/master

enotice fix

10 years agoMerge pull request #6825 from jitendrapurohit/CRM-17169reg
Monish Deb [Mon, 28 Sep 2015 17:55:59 +0000 (23:25 +0530)]
Merge pull request #6825 from jitendrapurohit/CRM-17169reg

CRM-17169 -- Fix upgrade conflict

10 years agoMerge pull request #6821 from davecivicrm/CRM-16274
Dave Greenberg [Mon, 28 Sep 2015 17:40:18 +0000 (13:40 -0400)]
Merge pull request #6821 from davecivicrm/CRM-16274

CRM-16274 - Change permission for Add Contacts to Groups in reports t…

10 years agoMerge pull request #6823 from colemanw/CRM-16353
colemanw [Mon, 28 Sep 2015 16:02:07 +0000 (12:02 -0400)]
Merge pull request #6823 from colemanw/CRM-16353

CRM-16353 - For tables hidden by collapsed accordions, wait

10 years agoMerge pull request #6827 from monishdeb/test-master
colemanw [Mon, 28 Sep 2015 16:01:10 +0000 (12:01 -0400)]
Merge pull request #6827 from monishdeb/test-master

CRM-17287 Legacy support for group and tag

10 years agoformat fixes
monishdeb [Mon, 28 Sep 2015 13:33:35 +0000 (19:03 +0530)]
format fixes

10 years agolegacy support for group and tag
monishdeb [Mon, 28 Sep 2015 12:49:49 +0000 (18:19 +0530)]
legacy support for group and tag

10 years agoCRM-17169 -- Fix upgrade conflict
jitendrapurohit [Mon, 28 Sep 2015 09:37:37 +0000 (15:07 +0530)]
CRM-17169 -- Fix upgrade conflict

10 years agoCRM-16353 - For tables hidden by collapsed accordions, wait
Coleman Watts [Mon, 28 Sep 2015 03:15:19 +0000 (23:15 -0400)]
CRM-16353 - For tables hidden by collapsed accordions, wait

10 years agoCRM-16274 - Change permission for Add Contacts to Groups in reports to be the same...
Dave Greenberg [Mon, 28 Sep 2015 02:19:26 +0000 (22:19 -0400)]
CRM-16274 - Change permission for Add Contacts to Groups in reports to be the same as for that task in search results.

----------------------------------------
* CRM-16274: Change the permission required for 'Add Contacts to Group' in reports to be consistent with other workflows
  https://issues.civicrm.org/jira/browse/CRM-16274

10 years agoenotice fix
eileenmcnaugton [Mon, 28 Sep 2015 01:41:46 +0000 (14:41 +1300)]
enotice fix

10 years agoMerge pull request #6819 from monishdeb/test-master
Dave Greenberg [Mon, 28 Sep 2015 00:14:26 +0000 (20:14 -0400)]
Merge pull request #6819 from monishdeb/test-master

 CRM-17287 Test fixes

10 years agoMerge pull request #6818 from totten/master-deadfunc
Tim Otten [Mon, 28 Sep 2015 00:06:29 +0000 (20:06 -0400)]
Merge pull request #6818 from totten/master-deadfunc

CRM_Contact_BAO_Contact::getRelativePath - Remove dead code

10 years agomaster Test fixes
monishdeb [Sun, 27 Sep 2015 22:30:14 +0000 (04:00 +0530)]
master Test fixes

10 years agoCRM_Contact_BAO_Contact::getRelativePath - Remove dead code
Tim Otten [Sun, 27 Sep 2015 22:29:35 +0000 (18:29 -0400)]
CRM_Contact_BAO_Contact::getRelativePath - Remove dead code

10 years agoMerge pull request #6816 from colemanw/CRM-16643
colemanw [Sun, 27 Sep 2015 22:28:16 +0000 (18:28 -0400)]
Merge pull request #6816 from colemanw/CRM-16643

CRM-16643 - Fix enableDisable when using api setvalue

10 years agoCRM-16643 - Fix enableDisable when using api setvalue
Coleman Watts [Sun, 27 Sep 2015 21:44:29 +0000 (17:44 -0400)]
CRM-16643 - Fix enableDisable when using api setvalue

10 years agoMerge pull request #6810 from davecivicrm/CRM-16643
colemanw [Sun, 27 Sep 2015 21:43:51 +0000 (17:43 -0400)]
Merge pull request #6810 from davecivicrm/CRM-16643

CRM-16643 - Revert to setvalue for inline editing of the entities who…

10 years agoMerge pull request #6808 from totten/master-config-tests
Tim Otten [Sun, 27 Sep 2015 21:36:10 +0000 (17:36 -0400)]
Merge pull request #6808 from totten/master-config-tests

CRM-16373 - CRM_Core_Config - Fix test regressions

10 years agoMerge pull request #6813 from davecivicrm/CRM-17228
Dave Greenberg [Sun, 27 Sep 2015 21:33:12 +0000 (17:33 -0400)]
Merge pull request #6813 from davecivicrm/CRM-17228

CRM-17228 - Improve help text for Profile form snippets.

10 years agoCRM-17228 - Improve help text for Profile form snippets.
Dave Greenberg [Sun, 27 Sep 2015 21:28:29 +0000 (17:28 -0400)]
CRM-17228 - Improve help text for Profile form snippets.

----------------------------------------
* CRM-17228: HTML Form snippets from profiles should use absolute URLs
  https://issues.civicrm.org/jira/browse/CRM-17228

10 years agoCRM-16643 - Revert to setvalue for inline editing of the entities whose APIs do not...
Dave Greenberg [Sun, 27 Sep 2015 20:43:02 +0000 (16:43 -0400)]
CRM-16643 - Revert to setvalue for inline editing of the entities whose APIs do not handle create as update properly.

----------------------------------------
* CRM-16643: Deprecate & remove setvalue api
  https://issues.civicrm.org/jira/browse/CRM-16643

10 years agoMerge pull request #6809 from davecivicrm/CRM-17269
Dave Greenberg [Sun, 27 Sep 2015 20:06:50 +0000 (16:06 -0400)]
Merge pull request #6809 from davecivicrm/CRM-17269

CRM-17269 - Simplify retrieval of relationship types for query, and s…

10 years agoMerge pull request #6749 from eileenmcnaughton/CRM-17144
Dave Greenberg [Sun, 27 Sep 2015 19:18:38 +0000 (15:18 -0400)]
Merge pull request #6749 from eileenmcnaughton/CRM-17144

CRM-17144 add ability for permissioned user to see report sql

10 years agoCRM_Report_Form_Contribute_DetailTest, CRM_Report_Form_TestCaseTest - Spaces
Tim Otten [Sun, 27 Sep 2015 19:14:52 +0000 (15:14 -0400)]
CRM_Report_Form_Contribute_DetailTest, CRM_Report_Form_TestCaseTest - Spaces

It appears that the content of the report CSV has changed slightly -- in certain
cases with undefined/missing info, it had returned a literal space (' ') but
now returns a empty string (''). Empty string seems a bit better, so updating
the unit-tests to match.

10 years agoCRM-17269 - Simplify retrieval of relationship types for query, and support relations...
Dave Greenberg [Sun, 27 Sep 2015 19:03:49 +0000 (15:03 -0400)]
CRM-17269 - Simplify retrieval of relationship types for query, and support relationship types on contact subtypes properly.

----------------------------------------
* CRM-17269: advanced search with custom relationship types fails
  https://issues.civicrm.org/jira/browse/CRM-17269

10 years agoCRM_Core_Config::$keyDisable - Restore property
Tim Otten [Sun, 27 Sep 2015 18:40:19 +0000 (14:40 -0400)]
CRM_Core_Config::$keyDisable - Restore property

10 years agoMerge pull request #6687 from totten/master-sched-ref
Tim Otten [Sun, 27 Sep 2015 18:20:07 +0000 (14:20 -0400)]
Merge pull request #6687 from totten/master-sched-ref

CRM-16355, CRM-13244 - Scheduled Reminders

10 years agoCRM-16373 - Fix error on $fiscalYearStart
Tim Otten [Sun, 27 Sep 2015 18:17:13 +0000 (14:17 -0400)]
CRM-16373 - Fix error on $fiscalYearStart

Error: "Indirect modification of overloaded property CRM_Core_Config::$fiscalYearStart has no effect"

10 years agoCRM-16373 - CRM_Core_BAO_ConfigSetting - Fix enableComponent
Tim Otten [Sun, 27 Sep 2015 17:49:10 +0000 (13:49 -0400)]
CRM-16373 - CRM_Core_BAO_ConfigSetting - Fix enableComponent

10 years agoMerge pull request #6802 from seamuslee001/CRM-17283
Dave Greenberg [Sun, 27 Sep 2015 17:32:06 +0000 (13:32 -0400)]
Merge pull request #6802 from seamuslee001/CRM-17283

CRM-17283 Allow for searching on partcipant registration date

10 years agoCRM-13422 - ActionScheduleTest - Loosen domain token handling
Tim Otten [Sun, 27 Sep 2015 13:53:11 +0000 (09:53 -0400)]
CRM-13422 - ActionScheduleTest - Loosen domain token handling

Discussed with a few people -- neither the contact nor the scheduled
reminder has a domain_id, so it seems hard to define a clear handling of
domain tokens.

10 years agoCRM-17038, CRM-13422 - Tokens - Adjust greeting evaluation order
Tim Otten [Fri, 4 Sep 2015 19:27:40 +0000 (12:27 -0700)]
CRM-17038, CRM-13422 - Tokens - Adjust greeting evaluation order

Following f551f7d32, replaceGreetingTokens tramples other tokens, so it has
to run at the end.

10 years agoCRM-17028 - RecipientBuilder - Forward port 3fc9bc80ee
Tim Otten [Fri, 4 Sep 2015 18:41:34 +0000 (11:41 -0700)]
CRM-17028 - RecipientBuilder - Forward port 3fc9bc80ee

10 years agoCRM-13422 - Add AbstractMappingTest. Fix soft-credit targeting.
Tim Otten [Sun, 30 Aug 2015 21:53:54 +0000 (14:53 -0700)]
CRM-13422 - Add AbstractMappingTest. Fix soft-credit targeting.

10 years agoCRM_Core_Error::debug_query_result - Don't dump hidden fields
Tim Otten [Sun, 30 Aug 2015 21:25:57 +0000 (14:25 -0700)]
CRM_Core_Error::debug_query_result - Don't dump hidden fields

10 years agoCRM_Utils_SQL_Select - Better error for malformed numbers
Tim Otten [Sun, 30 Aug 2015 21:18:58 +0000 (14:18 -0700)]
CRM_Utils_SQL_Select - Better error for malformed numbers

10 years agoCRM-13422 - ActionMappings - getRecipientTypes(), getRecipientListing()
Tim Otten [Sun, 30 Aug 2015 13:55:12 +0000 (06:55 -0700)]
CRM-13422 - ActionMappings - getRecipientTypes(), getRecipientListing()

Changes:
 * Declare getRecipientTypes() before getRecipientListing() because it's easier to read in that order.
 * Tweak docblocks
 * Split combined/legacy functions (Civi\ActionSchedule\Mapping) into simpler per-entity functions (CRM_Activity_ActionMapping, CRM_Event_ActionMapping).
 * For "Contribution Type" reminders, allow targetting to soft creditors.
 * For "Contribution Page" reminders, don't bother with soft-creditors. If someone paid through a self-service form, then I'm not sure we have soft-creditors.

10 years agoCRM-13422 - Form/ScheduleReminders - Allow role filters on custom mappings
Tim Otten [Sun, 30 Aug 2015 13:36:03 +0000 (06:36 -0700)]
CRM-13422 - Form/ScheduleReminders - Allow role filters on custom mappings

Previously, the 'Recipient Role' was only displayed if the results were
limited to 'participant_role'.  Now, the field will be displayed if the
mapping's getRecipientListing($recipientType) returns any data.

10 years agoCRM-13422 - MappingInterface::getRecipientTypes - Remove $noThanksJustKidding
Tim Otten [Sat, 29 Aug 2015 22:24:19 +0000 (15:24 -0700)]
CRM-13422 - MappingInterface::getRecipientTypes - Remove $noThanksJustKidding

This is a weird option that owes to a quirk in the UX -- where activity
roles are presented differently than other roles.  That UX quirk probably
shouldn't exist, but given that it does...  we'll push the quirk up into the
form layer (rather than in our API).

10 years agoCRM-13422 - ActionMapping - Remove gratuitous `entity_recipient`
Tim Otten [Sat, 29 Aug 2015 22:05:13 +0000 (15:05 -0700)]
CRM-13422 - ActionMapping - Remove gratuitous `entity_recipient`

This just functions an alternate-key for `entity`. It's only used
internally by the legacy `Mapping` class and does not appear in
the public interface.

10 years agoCRM-13422 - ActionSchedule - Kill getSelection() and getSelection1()
Tim Otten [Sat, 29 Aug 2015 19:52:20 +0000 (12:52 -0700)]
CRM-13422 - ActionSchedule - Kill getSelection() and getSelection1()

These are silly functions whose job is to wrap up data in a bundle using
mysterious names so that it can get immediately unwrapped.

10 years agoCRM-13422 - Consolidate extra rules for contact reminders
Tim Otten [Sat, 29 Aug 2015 19:15:01 +0000 (12:15 -0700)]
CRM-13422 - Consolidate extra rules for contact reminders

10 years agoCRM-13422 - Add MappingInterface::validateSchedule().
Tim Otten [Sat, 29 Aug 2015 18:49:13 +0000 (11:49 -0700)]
CRM-13422 - Add MappingInterface::validateSchedule().

Also: In CRM_Admin_Form_ScheduleReminders, extract parseActionSchedule()
from postProcess().  Now we can call parseActionSchedule() from both
postProcess() and formRule().

10 years agoCRM_Core_BAO_ActionSchedule::getSelection - Make it easier to trace dataflow
Tim Otten [Sat, 29 Aug 2015 15:16:18 +0000 (08:16 -0700)]
CRM_Core_BAO_ActionSchedule::getSelection - Make it easier to trace dataflow

10 years agoTokenRow - Fix docs
Tim Otten [Sat, 29 Aug 2015 14:56:34 +0000 (07:56 -0700)]
TokenRow - Fix docs

10 years agoCRM_Utils_Array::collectMethod() and ::toKeyValueRows()
Tim Otten [Sat, 29 Aug 2015 14:54:38 +0000 (07:54 -0700)]
CRM_Utils_Array::collectMethod() and ::toKeyValueRows()

10 years agoCRM-13422 - CRM_Contribute_ActionMapping_ByType
Tim Otten [Wed, 5 Aug 2015 05:23:17 +0000 (22:23 -0700)]
CRM-13422 - CRM_Contribute_ActionMapping_ByType

10 years agoCRM-13422 - CRM_Contribute_ActionMapping_ByPage
Tim Otten [Wed, 5 Aug 2015 04:59:06 +0000 (21:59 -0700)]
CRM-13422 - CRM_Contribute_ActionMapping_ByPage

10 years agoCRM-13244 - civicrm_action_schedule.mapping_id - Change int to varchar
Tim Otten [Wed, 5 Aug 2015 01:16:41 +0000 (18:16 -0700)]
CRM-13244 - civicrm_action_schedule.mapping_id - Change int to varchar

When modules define new mappings, it's easier if they can makeup their own
symbolic names rather than picking a number.

10 years agoCRM-13244 - MappingInterface - Document/cleanup getRecipient* stuff
Tim Otten [Wed, 5 Aug 2015 00:40:14 +0000 (17:40 -0700)]
CRM-13244 - MappingInterface - Document/cleanup getRecipient* stuff

10 years agoCRM-13244 - Split prepareMailingQuery() into entity-specific pieces.
Tim Otten [Tue, 4 Aug 2015 07:51:04 +0000 (00:51 -0700)]
CRM-13244 - Split prepareMailingQuery() into entity-specific pieces.

10 years agoCRM-13244 - ActionScheduleTmp - Move entity-specific parts to separate classes
Tim Otten [Tue, 4 Aug 2015 02:15:29 +0000 (19:15 -0700)]
CRM-13244 - ActionScheduleTmp - Move entity-specific parts to separate classes

10 years agoCRM-13244 - RecipientBuilder::prepareStartDateClauses - Less stringiness
Tim Otten [Tue, 4 Aug 2015 04:50:52 +0000 (21:50 -0700)]
CRM-13244 - RecipientBuilder::prepareStartDateClauses - Less stringiness

10 years agoCRM-13244 - ActionMapping - Strictly use MappingInterface
Tim Otten [Tue, 4 Aug 2015 00:10:38 +0000 (17:10 -0700)]
CRM-13244 - ActionMapping - Strictly use MappingInterface

10 years agoCRM-13244 - RecipientBuilder - Move entity-specific bits to ActionMappings
Tim Otten [Sat, 1 Aug 2015 12:45:07 +0000 (05:45 -0700)]
CRM-13244 - RecipientBuilder - Move entity-specific bits to ActionMappings

10 years agoCRM-13244 - Move buildRecipientContacts into new class. Split into smaller functions.
Tim Otten [Wed, 29 Jul 2015 10:54:16 +0000 (03:54 -0700)]
CRM-13244 - Move buildRecipientContacts into new class. Split into smaller functions.

Note: This was originally written as a series of smaller changes, but they
were squashed.  For more detailed history, check totten's repo for
alternative history leading up to, eg, 9e4d69e.

10 years agoCRM-13244 - prepareMailingQuery - Use CRM_Utils_SQL_Select
Tim Otten [Tue, 28 Jul 2015 08:49:29 +0000 (01:49 -0700)]
CRM-13244 - prepareMailingQuery - Use CRM_Utils_SQL_Select

10 years agoCRM-13244 - ActionSchedule\Mapping - Privatize various fields
Tim Otten [Wed, 29 Jul 2015 03:26:04 +0000 (20:26 -0700)]
CRM-13244 - ActionSchedule\Mapping - Privatize various fields

These fields are kind of stupid and are mostly only used within the Mapping
class.

The main external usage was for looking up a mapping record by
`entity_value`.  However, this can be made simpler now that mapping IDs are
constant.

10 years agoCRM-13244 - ActionSchedule - Externalize getMappings
Tim Otten [Wed, 29 Jul 2015 02:11:51 +0000 (19:11 -0700)]
CRM-13244 - ActionSchedule - Externalize getMappings

10 years agoCRM-13244 - ActionSchedule - Extract entity-specific logic for tokens and dropdowns.
Tim Otten [Mon, 27 Jul 2015 07:24:52 +0000 (00:24 -0700)]
CRM-13244 - ActionSchedule - Extract entity-specific logic for tokens and dropdowns.

The `ActionSchedule` BAO had a ton of duplicate, helter-skelter code for
looking up specific details about specific entities and mappings.  The
mapping class (`CRM_Core_DAO_ActionMapping`) had an anemic model.  The
mapping records could be modified in the DB, but in practice this was
pointless because they depended on so many hard-coded lookups.  And there
were some confusing variable names (sel1, sel2, sel3, etc) and
variable-shuffling.

This revision moves several entity-specific bits into new classes
(`Civi\ActionSchedule\Mapping` and `CRM_Core_ActionScheduleTmp`), abandons
the pretense of DB editing, centralizes mapping-related lookups, and replaces
various references to `CRM_Core_DAO_ActionMapping`.

This is envisioned as an intermediate step; the two classes are still a bit
heavy (mixing together logic for unrelated entities) and should be split
further.

10 years agoCRM_Core_BAO_ActionScheduleTest - Fix racy test
Tim Otten [Fri, 31 Jul 2015 23:58:06 +0000 (16:58 -0700)]
CRM_Core_BAO_ActionScheduleTest - Fix racy test

10 years agoCRM-13244 - CRM_Core_BAO_ActionScheduleTest - Add some event examples
Tim Otten [Fri, 31 Jul 2015 02:07:47 +0000 (19:07 -0700)]
CRM-13244 - CRM_Core_BAO_ActionScheduleTest - Add some event examples

10 years agoCRM-13244 - CRM_Core_BAO_ActionSchedule - Simplify `sendMailing()`
Tim Otten [Fri, 24 Jul 2015 09:34:45 +0000 (02:34 -0700)]
CRM-13244 - CRM_Core_BAO_ActionSchedule - Simplify `sendMailing()`

10 years agoCRM-13244 - CRM_Core_BAO_ActionSchedule - Use TokenProcessor instead of replaceCompon...
Tim Otten [Fri, 24 Jul 2015 07:10:23 +0000 (00:10 -0700)]
CRM-13244 - CRM_Core_BAO_ActionSchedule - Use TokenProcessor instead of replaceComponentTokens

10 years agoCRM-13244 - CRM_Core_BAO_ActionSchedule - Simplify `sendReminder`
Tim Otten [Fri, 24 Jul 2015 02:18:22 +0000 (19:18 -0700)]
CRM-13244 - CRM_Core_BAO_ActionSchedule - Simplify `sendReminder`

The old `sendReminder()` had too many responsibilities (loading token data
and processing token data and sending emails and sending SMS's), contained
lots of duplicate code, and did pointless variable shuffling.  The Smarty
and HTML parameters were enforced inconsistently, and the "From" address had
weird side-effects, ad nauseum.

This commit splits `sendReminder()` into three pieces:
 * `TokenCompatSubscriber` for filling in token data.
 * `sendReminderSms()` for sending SMS.
 * `sendReminderEmail()` for sending email.

10 years agoCRM-13244 - Civi\Token - Add new class for processing messages with tokens.
Tim Otten [Thu, 23 Jul 2015 07:11:45 +0000 (00:11 -0700)]
CRM-13244 - Civi\Token - Add new class for processing messages with tokens.

10 years agoCRM-13244 - CRM_Core_BAO_ActionSchedule - Comment about seemingly dead code
Tim Otten [Tue, 21 Jul 2015 03:39:45 +0000 (20:39 -0700)]
CRM-13244 - CRM_Core_BAO_ActionSchedule - Comment about seemingly dead code

10 years agoCRM-13244 - ActionSchedule - Normalize static references
Tim Otten [Tue, 21 Jul 2015 03:38:05 +0000 (20:38 -0700)]
CRM-13244 - ActionSchedule - Normalize static references

Some code uses "self::" and other use "CRM_Core_BAO_ActionSchedule::". It'll
be easier to reorganize if the notation is consistent.

10 years agoCRM-13244 - ActionSchedule - Extract methods from sendMailings
Tim Otten [Tue, 21 Jul 2015 03:12:46 +0000 (20:12 -0700)]
CRM-13244 - ActionSchedule - Extract methods from sendMailings

New methods
 * listMailingTokens()
 * prepareMailingQuery()
 * prepareMailingTokens()
 * createMailingActivity()

10 years agoCRM-13244 - ActionScheduleTest - Use some tokens
Tim Otten [Tue, 21 Jul 2015 05:15:03 +0000 (22:15 -0700)]
CRM-13244 - ActionScheduleTest - Use some tokens