civicrm-core.git
12 months agoCiviGrant - Fix 'View Grant' page
colemanw [Sun, 3 Dec 2023 06:40:27 +0000 (06:40 +0000)]
CiviGrant - Fix 'View Grant' page

Fixes https://lab.civicrm.org/dev/core/-/issues/4828

13 months agoMerge pull request #27749 from eileenmcnaughton/queue
Tim Otten [Tue, 24 Oct 2023 06:20:48 +0000 (23:20 -0700)]
Merge pull request #27749 from eileenmcnaughton/queue

Save mailing_id, is_test in test mode, where job is available

13 months agoMerge pull request #27858 from samuelsov/lab4703
Seamus Lee [Tue, 24 Oct 2023 02:36:38 +0000 (13:36 +1100)]
Merge pull request #27858 from samuelsov/lab4703

dev/core#4703

13 months agodev/core#4703 remove obsolete code
Samuel Vanhove [Mon, 23 Oct 2023 13:33:13 +0000 (09:33 -0400)]
dev/core#4703 remove obsolete code

13 months agodev/core#4703 edit with no parents crash
Samuel Vanhove [Wed, 18 Oct 2023 21:59:59 +0000 (17:59 -0400)]
dev/core#4703 edit with no parents crash

13 months agodev/core#4703
Samuel Vanhove [Wed, 18 Oct 2023 21:39:47 +0000 (17:39 -0400)]
dev/core#4703

13 months agoMerge pull request #27872 from agh1/5.67.0-releasenotes-initial
Eileen McNaughton [Sun, 22 Oct 2023 21:27:01 +0000 (10:27 +1300)]
Merge pull request #27872 from agh1/5.67.0-releasenotes-initial

5.67.0 release notes initial run

13 months agoMerge pull request #27878 from jitendrapurohit/pledge_delete-rc
colemanw [Sun, 22 Oct 2023 15:09:15 +0000 (11:09 -0400)]
Merge pull request #27878 from jitendrapurohit/pledge_delete-rc

REG: Fix fatal error on pledge delete

13 months agoFix fatal error on pledge delete
Jitendra Purohit [Sat, 21 Oct 2023 09:43:21 +0000 (15:13 +0530)]
Fix fatal error on pledge delete

13 months ago5.67.0 release notes: added boilerplate
Andie Hunt [Fri, 20 Oct 2023 16:25:24 +0000 (12:25 -0400)]
5.67.0 release notes: added boilerplate

13 months ago5.67.0 release notes: raw from script
Andie Hunt [Fri, 20 Oct 2023 16:21:31 +0000 (12:21 -0400)]
5.67.0 release notes: raw from script

13 months agoMerge pull request #27856 from colemanw/emptyRequires
colemanw [Fri, 20 Oct 2023 10:18:40 +0000 (06:18 -0400)]
Merge pull request #27856 from colemanw/emptyRequires

dev/core#4707 Don't error if extension has empty `requires` tag

13 months agoExtensions - Don't accept invalid keys, include empty <requires> in test
colemanw [Wed, 18 Oct 2023 23:28:43 +0000 (19:28 -0400)]
Extensions - Don't accept invalid keys, include empty <requires> in test

13 months agoUnitTest - Rename & reformat json file
colemanw [Wed, 18 Oct 2023 23:19:29 +0000 (19:19 -0400)]
UnitTest - Rename & reformat json file

No changes to the file content other than whitespace

13 months agodev/core#4707 Don't error if extension has empty `requires` tag
colemanw [Wed, 18 Oct 2023 20:13:46 +0000 (16:13 -0400)]
dev/core#4707 Don't error if extension has empty `requires` tag

13 months agoMerge pull request #27868 from eileenmcnaughton/567-e
colemanw [Thu, 19 Oct 2023 23:02:02 +0000 (19:02 -0400)]
Merge pull request #27868 from eileenmcnaughton/567-e

dev/core#4706 Custom data fix

13 months agodev/core#4706 Custom data fix
Eileen McNaughton [Thu, 19 Oct 2023 21:37:24 +0000 (10:37 +1300)]
dev/core#4706 Custom data fix

13 months agoMerge pull request #27854 from eileenmcnaughton/567
colemanw [Thu, 19 Oct 2023 21:20:28 +0000 (17:20 -0400)]
Merge pull request #27854 from eileenmcnaughton/567

Fix regression when searching by contact ID from quickSearch (if you hit enter quickly)

13 months agoFix variable leakage between uf_group_id & contact ID
Eileen McNaughton [Tue, 17 Oct 2023 23:59:52 +0000 (12:59 +1300)]
Fix variable leakage between uf_group_id & contact ID

13 months agoMerge pull request #27798 from colemanw/angCheck
Matthew Wire [Mon, 16 Oct 2023 20:35:56 +0000 (21:35 +0100)]
Merge pull request #27798 from colemanw/angCheck

Angular - Noisily deprecate 'settings' in favor of 'settingsFactory'

13 months agoAngular - Noisily deprecate 'settings' in favor of 'settingsFactory'
colemanw [Thu, 12 Oct 2023 23:44:23 +0000 (19:44 -0400)]
Angular - Noisily deprecate 'settings' in favor of 'settingsFactory'

13 months agoMerge pull request #27788 from eileenmcnaughton/567_prem
Eileen McNaughton [Wed, 11 Oct 2023 22:05:45 +0000 (11:05 +1300)]
Merge pull request #27788 from eileenmcnaughton/567_prem

Add weights to premium screen

13 months agoAdd weights to premium screen
Eileen McNaughton [Wed, 11 Oct 2023 21:05:17 +0000 (10:05 +1300)]
Add weights to premium screen

13 months agoMerge pull request #27780 from eileenmcnaughton/567_pcp
Yashodha Chaku [Wed, 11 Oct 2023 10:42:16 +0000 (16:12 +0530)]
Merge pull request #27780 from eileenmcnaughton/567_pcp

Add some weights to pcp page

13 months agoAdd some weights to pcp page
Eileen McNaughton [Wed, 11 Oct 2023 05:33:31 +0000 (18:33 +1300)]
Add some weights to pcp page

13 months agoMerge pull request #27771 from eileenmcnaughton/567
colemanw [Wed, 11 Oct 2023 01:20:22 +0000 (21:20 -0400)]
Merge pull request #27771 from eileenmcnaughton/567

Do not run financial acls if the setting it not set

13 months agoDo not run financial acls if the setting it not set
Eileen McNaughton [Wed, 11 Oct 2023 00:36:22 +0000 (13:36 +1300)]
Do not run financial acls if the setting it not set

Yeah - continues a fugly fix - but it's quick & works

13 months agoMerge pull request #27722 from colemanw/civiCaseSelectWhereClause
colemanw [Tue, 10 Oct 2023 13:09:12 +0000 (09:09 -0400)]
Merge pull request #27722 from colemanw/civiCaseSelectWhereClause

CiviCase - Fix SelectWhereClause for Activity queries

13 months agoActivityTest - Fix tearDown to prevent test leakage
colemanw [Tue, 10 Oct 2023 00:34:10 +0000 (20:34 -0400)]
ActivityTest - Fix tearDown to prevent test leakage

13 months agoFix Activity ACL clause generation
colemanw [Sat, 7 Oct 2023 17:30:12 +0000 (13:30 -0400)]
Fix Activity ACL clause generation

Regression was caused by  918e583a146876fb42932a1d959796fd710b7b74 updating DAO::getSelectWhereClause
but not CRM_Contact_BAO_Query::generatePermissionClause. Turns out the code was being duplicated and
the latter could just call the former.

13 months agoFix tests not setting permissions properly
colemanw [Fri, 6 Oct 2023 18:45:01 +0000 (14:45 -0400)]
Fix tests not setting permissions properly

13 months agoDAO - Handle OR clauses in getDynamicFkAclClauses, improve sql formatting for readability
colemanw [Thu, 5 Oct 2023 18:01:25 +0000 (14:01 -0400)]
DAO - Handle OR clauses in getDynamicFkAclClauses, improve sql formatting for readability

Follow-up to 918e583a146876fb42932a1d959796fd710b7b74 - this correctly joins sub-arrays using OR

13 months agoMerge pull request #27748 from eileenmcnaughton/register_567
colemanw [Sat, 7 Oct 2023 13:45:34 +0000 (09:45 -0400)]
Merge pull request #27748 from eileenmcnaughton/register_567

Fix rc regression on register participants action

13 months agoMerge pull request #27747 from eileenmcnaughton/567
Seamus Lee [Sat, 7 Oct 2023 03:59:29 +0000 (14:59 +1100)]
Merge pull request #27747 from eileenmcnaughton/567

Regen (rc)

13 months agoSave mailing_id, is_test in test mode, where job is available
Eileen McNaughton [Sat, 7 Oct 2023 03:05:54 +0000 (16:05 +1300)]
Save mailing_id, is_test in test mode, where job is available

13 months agoFix rc regression on register participants action
Eileen McNaughton [Sat, 7 Oct 2023 02:47:34 +0000 (15:47 +1300)]
Fix rc regression on register participants action

Fixes an rc bug where contact information was not being loaded per participant,
resulting in emails not going out

13 months agoRegen (rc)
Eileen McNaughton [Sat, 7 Oct 2023 01:52:08 +0000 (14:52 +1300)]
Regen (rc)

13 months agoMerge pull request #27728 from eileenmcnaughton/surver
colemanw [Sat, 7 Oct 2023 01:35:42 +0000 (21:35 -0400)]
Merge pull request #27728 from eileenmcnaughton/surver

Add some more weight fields

13 months agoMerge pull request #27741 from eileenmcnaughton/567_event
colemanw [Sat, 7 Oct 2023 01:34:52 +0000 (21:34 -0400)]
Merge pull request #27741 from eileenmcnaughton/567_event

Fix rc regression - balance amount missing

13 months agoFix rc regression - balance amount missing
Eileen McNaughton [Fri, 6 Oct 2023 23:15:41 +0000 (12:15 +1300)]
Fix rc regression - balance amount missing

This is pretty hard to get to (outside the test). You need to configure
an event with a pending contribution and then partially pay it
and go back & send a receipt.

Unfortunately the
Paid amount & Balance amount
 got removed from the html version by accident
and the tests didn't pick it up because they were testing
the text version - which had not had many of the recent updates
applied (it was going to be done after but we have since decided to remove the
text version).

This updates the test to check the html version, puts back the removed text
and adds it to the preview screen

13 months agoMerge pull request #27742 from eileenmcnaughton/smarty_tag
colemanw [Sat, 7 Oct 2023 00:50:06 +0000 (20:50 -0400)]
Merge pull request #27742 from eileenmcnaughton/smarty_tag

Fix missing quotes in tpl file

13 months agoFix missing quotes in tpl file
Eileen McNaughton [Sat, 7 Oct 2023 00:43:30 +0000 (13:43 +1300)]
Fix missing quotes in tpl file

This is a longstanding error rather than a regression - but it hard failes when
Smarty3 is enabled. Smarty3 is a pretty good tool for finding issues when testing
the rc it turns out (highlights variable errors in smarty)
so I'm fixing in the rc so as not to be blocked on using smarty with the rc

13 months agoMerge pull request #27736 from colemanw/afformFnError
Eileen McNaughton [Fri, 6 Oct 2023 20:27:23 +0000 (09:27 +1300)]
Merge pull request #27736 from colemanw/afformFnError

Afform - fix undefined function error

13 months agoAfform - fix undefined function error
colemanw [Fri, 6 Oct 2023 14:37:45 +0000 (10:37 -0400)]
Afform - fix undefined function error

Fixes bug from 1ff8423300d85100e026741111383cdabd5fce05

14 months agoMerge pull request #27730 from eileenmcnaughton/567
Eileen McNaughton [Fri, 6 Oct 2023 02:57:57 +0000 (15:57 +1300)]
Merge pull request #27730 from eileenmcnaughton/567

Notice fix

14 months agoNotice fix
Eileen McNaughton [Fri, 6 Oct 2023 02:11:14 +0000 (15:11 +1300)]
Notice fix

14 months agoCiviCase - Add selectWhereClause for activities
colemanw [Thu, 5 Oct 2023 02:22:53 +0000 (22:22 -0400)]
CiviCase - Add selectWhereClause for activities

14 months agoAdd some more weight fields
Eileen McNaughton [Thu, 5 Oct 2023 23:58:13 +0000 (12:58 +1300)]
Add some more weight fields

14 months agoSet version to 5.67.beta1
CiviCRM [Thu, 5 Oct 2023 05:30:14 +0000 (05:30 +0000)]
Set version to 5.67.beta1

14 months agoMerge commit '269f94546c'
Tim Otten [Thu, 5 Oct 2023 05:28:28 +0000 (22:28 -0700)]
Merge commit '269f94546c'

14 months agoMerge pull request #27725 from eileenmcnaughton/new-notice
Tim Otten [Thu, 5 Oct 2023 05:21:46 +0000 (22:21 -0700)]
Merge pull request #27725 from eileenmcnaughton/new-notice

Enotice fix

14 months agoMerge pull request #27557 from eileenmcnaughton/bulk_create
Tim Otten [Thu, 5 Oct 2023 04:41:37 +0000 (21:41 -0700)]
Merge pull request #27557 from eileenmcnaughton/bulk_create

dev/core#4567 Update code creating queue entries to save mailing_id

14 months agoEnotice fix
Eileen McNaughton [Thu, 5 Oct 2023 04:02:35 +0000 (17:02 +1300)]
Enotice fix

14 months agoMerge pull request #27720 from eileenmcnaughton/566
Tim Otten [Thu, 5 Oct 2023 03:50:37 +0000 (20:50 -0700)]
Merge pull request #27720 from eileenmcnaughton/566

Do not create new contacts during bounce processing

14 months agoAPIv4 - Don't crash if permission denied to join
colemanw [Wed, 4 Oct 2023 19:17:07 +0000 (15:17 -0400)]
APIv4 - Don't crash if permission denied to join

14 months agoMerge pull request #27721 from totten/5.66-rn0
Tim Otten [Thu, 5 Oct 2023 00:38:22 +0000 (17:38 -0700)]
Merge pull request #27721 from totten/5.66-rn0

release-notes/5.66.0.md - Add some more late-stage PRs from RC

14 months agorelease-notes/5.66.0.md - Add some more late-stage PRs from RC
Tim Otten [Wed, 4 Oct 2023 23:48:34 +0000 (16:48 -0700)]
release-notes/5.66.0.md - Add some more late-stage PRs from RC

Also: some random edits

14 months agoDo not create new contacts during bounce processing
Eileen McNaughton [Wed, 4 Oct 2023 23:15:12 +0000 (12:15 +1300)]
Do not create new contacts during bounce processing

14 months agoMerge pull request #27719 from eileenmcnaughton/regen
Eileen McNaughton [Wed, 4 Oct 2023 20:17:03 +0000 (09:17 +1300)]
Merge pull request #27719 from eileenmcnaughton/regen

Re-run regen

14 months agoMerge pull request #27716 from colemanw/endsWithPolyfill
Eileen McNaughton [Wed, 4 Oct 2023 19:24:25 +0000 (08:24 +1300)]
Merge pull request #27716 from colemanw/endsWithPolyfill

CRM_Utils_String - Deprecate startsWith and endsWith

14 months agoRe-run regen
Eileen McNaughton [Wed, 4 Oct 2023 19:23:36 +0000 (08:23 +1300)]
Re-run regen

14 months agoCRM_Utils_String - Deprecate startsWith and endsWith
colemanw [Wed, 4 Oct 2023 12:51:07 +0000 (08:51 -0400)]
CRM_Utils_String - Deprecate startsWith and endsWith

14 months agoMerge pull request #27718 from MegaphoneJon/initialize-mfg-var
colemanw [Wed, 4 Oct 2023 16:44:45 +0000 (12:44 -0400)]
Merge pull request #27718 from MegaphoneJon/initialize-mfg-var

getTree: initialize variable before it's used (PHP8 compat)

14 months agogetTree: initialize variable before it's used
Jon Goldberg [Wed, 4 Oct 2023 15:54:29 +0000 (11:54 -0400)]
getTree: initialize variable before it's used

14 months agoMerge pull request #27701 from colemanw/relTab
Aidan Saunders [Wed, 4 Oct 2023 15:45:06 +0000 (16:45 +0100)]
Merge pull request #27701 from colemanw/relTab

ContactSummary - Replace Relationships tab with SearchKit display

14 months agoMerge pull request #27715 from civicrm/5.66
Eileen McNaughton [Wed, 4 Oct 2023 08:45:48 +0000 (21:45 +1300)]
Merge pull request #27715 from civicrm/5.66

Merge forward: 5.66 RC => master

14 months agoMerge pull request #27714 from totten/5.66-srchmap-php73
Tim Otten [Wed, 4 Oct 2023 05:45:44 +0000 (22:45 -0700)]
Merge pull request #27714 from totten/5.66-srchmap-php73

SavedSearchMappingTest - Fix compat with php73

14 months agoSavedSearchMappingTest - Fix compat with php73
Tim Otten [Wed, 4 Oct 2023 03:42:57 +0000 (20:42 -0700)]
SavedSearchMappingTest - Fix compat with php73

14 months agoMerge pull request #27713 from colemanw/contactTypeAutocomplete
Seamus Lee [Wed, 4 Oct 2023 02:04:02 +0000 (13:04 +1100)]
Merge pull request #27713 from colemanw/contactTypeAutocomplete

APIv4 - Fix autocomplete for Individual,Household,Organization entities

14 months agoSearchKit - Fix nonexistant links incorrectly displaying
colemanw [Wed, 4 Oct 2023 00:22:13 +0000 (20:22 -0400)]
SearchKit - Fix nonexistant links incorrectly displaying

14 months agoContactSummary - Prevent excessive/infinite refreshing of related tabs
colemanw [Mon, 2 Oct 2023 16:05:04 +0000 (12:05 -0400)]
ContactSummary - Prevent excessive/infinite refreshing of related tabs

14 months agoSearchKit - When refreshing after a task, refresh all displays in a form
colemanw [Mon, 2 Oct 2023 05:37:14 +0000 (01:37 -0400)]
SearchKit - When refreshing after a task, refresh all displays in a form

14 months agoContactSummary - Add link to manage case in Relationships tab
colemanw [Mon, 2 Oct 2023 05:14:16 +0000 (01:14 -0400)]
ContactSummary - Add link to manage case in Relationships tab

14 months agoSearchKit - Don't crash if join entity doesn't exist
colemanw [Mon, 2 Oct 2023 05:13:35 +0000 (01:13 -0400)]
SearchKit - Don't crash if join entity doesn't exist

14 months agoCiviCase - Add "manage case" link to metadata, make cid optional
colemanw [Mon, 2 Oct 2023 04:54:28 +0000 (00:54 -0400)]
CiviCase - Add "manage case" link to metadata, make cid optional

14 months agoContactSummary - Remove old relationships tab
colemanw [Mon, 2 Oct 2023 02:41:44 +0000 (22:41 -0400)]
ContactSummary - Remove old relationships tab

14 months agoContactSummary - Add SearchKit display for relationships tab
colemanw [Mon, 2 Oct 2023 01:48:59 +0000 (21:48 -0400)]
ContactSummary - Add SearchKit display for relationships tab

14 months agoUpdate icon for relationship permission
colemanw [Sun, 1 Oct 2023 18:03:45 +0000 (14:03 -0400)]
Update icon for relationship permission

14 months agoRelationshipCache - Add 'add' metadata
colemanw [Sun, 1 Oct 2023 14:26:23 +0000 (10:26 -0400)]
RelationshipCache - Add 'add' metadata

14 months agoSearchKit - The first display in a tab gets to control the count
colemanw [Sun, 1 Oct 2023 02:41:54 +0000 (22:41 -0400)]
SearchKit - The first display in a tab gets to control the count

Fix weird tab count if > 1 search display in a tab

14 months agoAfform - Fix data type when setting entity values
colemanw [Sun, 1 Oct 2023 01:59:03 +0000 (21:59 -0400)]
Afform - Fix data type when setting entity values

14 months agoMerge pull request #27660 from eileenmcnaughton/delete
colemanw [Wed, 4 Oct 2023 00:25:28 +0000 (20:25 -0400)]
Merge pull request #27660 from eileenmcnaughton/delete

Separate delete participant form from edit participant form

14 months agoAPIv4 - Fix autocomplete for Individual,Household,Organization entities
colemanw [Tue, 3 Oct 2023 23:22:39 +0000 (19:22 -0400)]
APIv4 - Fix autocomplete for Individual,Household,Organization entities

14 months agoMerge pull request #27691 from totten/master-queue-runloop
Eileen McNaughton [Tue, 3 Oct 2023 22:11:34 +0000 (11:11 +1300)]
Merge pull request #27691 from totten/master-queue-runloop

Queue::run() - Add API for running several tasks

14 months agoMerge pull request #27693 from eileenmcnaughton/remove_math
colemanw [Tue, 3 Oct 2023 22:09:18 +0000 (18:09 -0400)]
Merge pull request #27693 from eileenmcnaughton/remove_math

Replace smarty-math with assigned value

14 months agoMerge pull request #27592 from colemanw/afformBool
colemanw [Tue, 3 Oct 2023 21:25:02 +0000 (17:25 -0400)]
Merge pull request #27592 from colemanw/afformBool

Afform - Fix display of boolean checkboxes

14 months agoRename Queue::runLoop() to Queue::run()
Tim Otten [Tue, 3 Oct 2023 21:21:16 +0000 (14:21 -0700)]
Rename Queue::runLoop() to Queue::run()

14 months ago(NFC) RunLoop - Expand docblocks
Tim Otten [Tue, 3 Oct 2023 20:56:59 +0000 (13:56 -0700)]
(NFC) RunLoop - Expand docblocks

14 months agoMerge pull request #27642 from lemniscus/sk-table-header-alignment
Eileen McNaughton [Tue, 3 Oct 2023 20:31:16 +0000 (09:31 +1300)]
Merge pull request #27642 from lemniscus/sk-table-header-alignment

SearchKit: Align column headers according to settings

14 months agoSK: Align column headers according to settings
Noah Miller [Tue, 26 Sep 2023 04:39:58 +0000 (00:39 -0400)]
SK: Align column headers according to settings

14 months agoMerge pull request #27712 from colemanw/contactTypeApi2
Eileen McNaughton [Tue, 3 Oct 2023 19:22:44 +0000 (08:22 +1300)]
Merge pull request #27712 from colemanw/contactTypeApi2

[NFC] APIv4 - Update contact type api comment

14 months agoMerge pull request #27700 from colemanw/exportDefaults
Aidan Saunders [Tue, 3 Oct 2023 16:33:19 +0000 (17:33 +0100)]
Merge pull request #27700 from colemanw/exportDefaults

APIv4 - Trim output of Export action to only non-default values

14 months agoMerge pull request #27698 from colemanw/afformShareFieldset
Aidan Saunders [Tue, 3 Oct 2023 16:10:35 +0000 (17:10 +0100)]
Merge pull request #27698 from colemanw/afformShareFieldset

SearchKit - Fix and add test for scenario where the same display is used twice on a form

14 months agoManaged - Backfill default values when reverting APIv4 entity
colemanw [Mon, 2 Oct 2023 20:04:03 +0000 (16:04 -0400)]
Managed - Backfill default values when reverting APIv4 entity

14 months agoMerge pull request #27484 from totten/master-links
colemanw [Tue, 3 Oct 2023 12:56:16 +0000 (08:56 -0400)]
Merge pull request #27484 from totten/master-links

hook_civicrm_links - Add docblocks and event-checker

14 months agoAPIv4 - Update contact type api comment
colemanw [Tue, 3 Oct 2023 12:30:39 +0000 (08:30 -0400)]
APIv4 - Update contact type api comment

14 months agoMerge pull request #27711 from civicrm/5.66
Eileen McNaughton [Tue, 3 Oct 2023 09:52:25 +0000 (22:52 +1300)]
Merge pull request #27711 from civicrm/5.66

5.66 to master

14 months agoMerge pull request #27710 from totten/5.66-links-weights
Eileen McNaughton [Tue, 3 Oct 2023 09:44:44 +0000 (22:44 +1300)]
Merge pull request #27710 from totten/5.66-links-weights

hook_civicrm_links - Add more weights

14 months agohook_civicrm_links - Add more weights:
Tim Otten [Tue, 19 Sep 2023 05:59:34 +0000 (22:59 -0700)]
hook_civicrm_links - Add more weights:

- contribution.edit.action
- file.manage.delete
- financialItem.batch.row
- Payment.edit.action

14 months agoMerge pull request #27659 from colemanw/contactTypeApi
Tim Otten [Tue, 3 Oct 2023 05:31:52 +0000 (22:31 -0700)]
Merge pull request #27659 from colemanw/contactTypeApi

APIv4 - Add Individual, Household, Organization pseudo-entities