eileen [Mon, 29 Jul 2019 07:00:39 +0000 (19:00 +1200)]
Add unit test for net_amount when fee_amount is set
This just improves testing & ensures fee_amount is used to set net amount.
I got some odd results on financial_trxn & financial_item but just adding checks for
what I found atm
Seamus Lee [Mon, 29 Jul 2019 00:34:01 +0000 (10:34 +1000)]
Merge pull request #14880 from eileenmcnaughton/cust_field_label
[Test] [Import] Add test to demonstrate bug that turns out not to exist
Eileen McNaughton [Mon, 29 Jul 2019 00:17:27 +0000 (12:17 +1200)]
Merge pull request #14899 from eileenmcnaughton/format
[NFC] reformat class
Eileen McNaughton [Sun, 28 Jul 2019 23:06:15 +0000 (11:06 +1200)]
Merge pull request #14534 from pradpnayak/EventTypeQuery
Fixed event type id fetch
eileen [Sun, 28 Jul 2019 22:14:17 +0000 (10:14 +1200)]
[NFC] reformat class
Seamus Lee [Sun, 28 Jul 2019 22:12:17 +0000 (08:12 +1000)]
Merge pull request #14870 from eileenmcnaughton/import_except
[IMPORT] [code-quality] Remove instances of CRM_Core_Error::fatal from first import form
Seamus Lee [Sun, 28 Jul 2019 21:37:10 +0000 (07:37 +1000)]
Merge pull request #14893 from eileenmcnaughton/date
Fix support for relative dates in urls
Seamus Lee [Sun, 28 Jul 2019 21:33:53 +0000 (07:33 +1000)]
Merge pull request #14885 from aydun/location_defaults
Add default location for API v3 creates of Address, IM, OpenID and Phone
Seamus Lee [Sun, 28 Jul 2019 21:29:44 +0000 (07:29 +1000)]
Merge pull request #14760 from eileenmcnaughton/unsub
dev/core#1108 [REF] use CRM_Core_DAO::executeQuery instead of ->query()
Eileen McNaughton [Sun, 28 Jul 2019 21:17:58 +0000 (09:17 +1200)]
Merge pull request #14886 from mattwire/membership_payment
Switch create MembershipPayment to use API
Eileen McNaughton [Sun, 28 Jul 2019 11:41:02 +0000 (23:41 +1200)]
Merge pull request #14620 from mattwire/entitypagetrait_defaultcontactid
EntityPageTrait: Set logged in contact ID as default if one is not specified - this allows permission checks etc. to work properly.
Matthew Wire (MJW Consulting) [Fri, 26 Jul 2019 15:30:47 +0000 (16:30 +0100)]
Switch create MembershipPayment to use API
Matthew Wire [Sun, 28 Jul 2019 09:37:44 +0000 (10:37 +0100)]
Merge pull request #14896 from eileenmcnaughton/event_count
Fix php7.x warning on count
colemanw [Sun, 28 Jul 2019 02:00:50 +0000 (22:00 -0400)]
Merge pull request #14874 from eileenmcnaughton/export_1
[REf] [Export] Remove deprecated componentPaymentFields function
colemanw [Sun, 28 Jul 2019 01:59:10 +0000 (21:59 -0400)]
Merge pull request #14875 from eileenmcnaughton/export_2
[Ref] [Export] Remove exportComponent function - it's not adding much here
eileen [Sun, 28 Jul 2019 01:41:43 +0000 (13:41 +1200)]
Fix php7.x warning on count
Fixes a warning when php 7.2 tries to count on a null value
colemanw [Sun, 28 Jul 2019 01:03:59 +0000 (21:03 -0400)]
Merge pull request #14854 from eileenmcnaughton/validate
Do not launch raw js alert jqueryValidation fails
Seamus Lee [Sat, 27 Jul 2019 21:37:38 +0000 (07:37 +1000)]
Merge pull request #14895 from mattwire/optiongroup_checkcrash
Don't let optiongroup check crash
Matthew Wire (MJW Consulting) [Sat, 27 Jul 2019 19:49:38 +0000 (20:49 +0100)]
Don't let optiongroup check crash
Aidan Saunders [Sat, 27 Jul 2019 06:09:38 +0000 (07:09 +0100)]
Small test fixes/standardisations.
eileen [Sat, 27 Jul 2019 05:21:27 +0000 (17:21 +1200)]
Fix support for relative dates in urls
This improves support for relative dates for fields that have been converted.
For example
http://dmaster.local/civicrm/contribute/search?reset=1&receive_date_relative=this.year&force=1
Now works to render donations 'This Calendar Year'
Aidan Saunders [Fri, 26 Jul 2019 10:14:03 +0000 (11:14 +0100)]
Add default location for API v3 creates of Address, IM, OpenID and Phone.
Has tests.
Default location was recently added for APIv3 Email.create
(https://github.com/civicrm/civicrm-core/pull/14489)
and for Address, Email, IM, OpenID and Phone in APIv4
(https://github.com/civicrm/org.civicrm.api4/pull/162)
so this brings consistency of behaviour for these entities between each other
and between APIv3 and APIv4
eileen [Thu, 25 Jul 2019 09:50:18 +0000 (21:50 +1200)]
Remove some static caches that are crashing tests
eileen [Thu, 25 Jul 2019 00:19:15 +0000 (12:19 +1200)]
[Test] Add test to demonstrate bug that turns out not to exist
I thought there was a bug in import handling in custom data so I wrote a test to try to capture it - tests pass & I'm off to re-check
my data & see if the bug was more of a pebkac error.
Anyway test is good
Matthew Wire [Fri, 26 Jul 2019 15:49:35 +0000 (16:49 +0100)]
Merge pull request #14879 from eileenmcnaughton/import_gender_test
[REF] [Test] Add test to cover handling of 'gender_id' on import, remove unused code.
Eileen McNaughton [Thu, 25 Jul 2019 21:00:50 +0000 (09:00 +1200)]
Merge pull request #14883 from totten/master-daotest
CRM-20455 - Allow CRM_Core_DAOTest to pass w/packages#259
Eileen McNaughton [Thu, 25 Jul 2019 21:00:13 +0000 (09:00 +1200)]
Merge pull request #14884 from mlutfy/event6
dev/event#6 Follow the 'same email' participants config setting for backend participants
Mathieu Lutfy [Thu, 25 Jul 2019 19:39:44 +0000 (15:39 -0400)]
dev/event#6 Follow the 'same email' participants config setting for backend participants
Tim Otten [Thu, 25 Jul 2019 16:53:42 +0000 (09:53 -0700)]
DAOTest - Use docblock for type
This patch is going in as part of some cleanup/refactoring in a mid-cycle
change. Using the docblock allows the type to be communicated without
breaking on mid-cycle contract change.
Tim Otten [Thu, 25 Jul 2019 05:48:47 +0000 (22:48 -0700)]
CRM-20455 - Allow CRM_Core_DAOTest w/packages#259
Eileen McNaughton [Thu, 25 Jul 2019 04:40:29 +0000 (16:40 +1200)]
Merge pull request #14672 from seamuslee001/load_smart_cache_after_deleting_group_contact_records
Invalidate smart group cache for group following deletion of group_c…
Seamus Lee [Thu, 25 Jul 2019 03:02:07 +0000 (13:02 +1000)]
Merge pull request #14882 from totten/master-query-event
CRM-20455 - Add specialized event for queries
eileen [Mon, 22 Jul 2019 07:12:18 +0000 (19:12 +1200)]
Remove the js alert message when jqueryValidation fails on frontend pages
It's really really ugly & as discussed without it
a) extensions can still opt to display the errors themselves and
b) the inline errors still appear.
Note this will have no real affect on existing code - the ugliness of this has been
a blocker to getting into front end validation & at this stage only the
omnipay extension is trying to work in this space.
https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/pull/128
I think ideally with Omnipay it DOES makes sense to display messages
near the checkout button - which might be a future step
Tim Otten [Thu, 25 Jul 2019 01:02:15 +0000 (18:02 -0700)]
CRM-20455 - Add specialized event for queries
Overview
--------
The recently merged PR for CRM-20455, https://github.com/civicrm/civicrm-packages/pull/180, uses the
GenericHookEvent for modifying all SQL queries. GHE is flexible, but it
comes with a slight performance penalty (juggling a few internal arrays).
The penalty is usually too small to care if you're firing one hook. However, with CRM-20455,
we can foresee the event firing hundreds or even thousands of times within a given page-view.
This PR adds a smaller/simpler class for use with `modifyQuery`. There will be a different PR to use it.
Before
------
* Don't have `QueryEvent`
After
-----
* Do have `QueryEvent`
eileen [Wed, 24 Jul 2019 23:24:46 +0000 (11:24 +1200)]
Add test to cover handling of 'gender_id' on import, remove unused code.
I'm just venturing into import to fix a bug & wrote this test to step through the code. Committing as it's passing.
In the process I found that it's impossible to set 'gender' as an import field & only 'gender_id' is
available as a field so removing 'gender'
Seamus Lee [Wed, 24 Jul 2019 23:38:14 +0000 (09:38 +1000)]
Merge pull request #14861 from eileenmcnaughton/anet
[test] Catch A.net exception & ignore
Tim Otten [Wed, 24 Jul 2019 22:49:43 +0000 (15:49 -0700)]
Merge pull request #14833 from seamuslee001/ids_ip_logging_improvements
Ensure that if present the HTTP_X_FORWARDED_FOR IP address is used in…
Eileen McNaughton [Wed, 24 Jul 2019 22:48:43 +0000 (10:48 +1200)]
Merge pull request #14878 from civicrm/5.16
5.16 to master
Tim Otten [Wed, 24 Jul 2019 22:44:15 +0000 (15:44 -0700)]
Merge pull request #14876 from eileenmcnaughton/is_front
dev/core#378 Determine front end pages in drupal
Eileen McNaughton [Wed, 24 Jul 2019 22:34:48 +0000 (10:34 +1200)]
Merge pull request #14718 from totten/herb-private-hier
Move log and compilation dirs from "Runtime" to "Paths"
Seamus Lee [Fri, 28 Jun 2019 22:45:42 +0000 (08:45 +1000)]
Invalidate smart group cache for group following deletion of group_contact row
Add in function to invalidate smart group cache rather than building it up again when contact removal is deleted
Remove if check
colemanw [Wed, 24 Jul 2019 13:27:08 +0000 (09:27 -0400)]
Merge pull request #14873 from eileenmcnaughton/extract
[REF] extract loadSavedMapping
eileen [Wed, 24 Jul 2019 13:11:27 +0000 (01:11 +1200)]
Determine front end pages in drupal
Alternative to https://github.com/civicrm/civicrm-drupal/pull/546/files that I think narrows the scope
since it means we are not changing an existing property
Matthew Wire [Wed, 24 Jul 2019 12:15:02 +0000 (13:15 +0100)]
Merge pull request #14862 from mlutfy/event9
dev/event#9 Event Templates: do not set the Start/End dates
eileen [Wed, 24 Jul 2019 05:24:58 +0000 (17:24 +1200)]
[REF] extract loadSavedMapping
This is a very 'untouched' extraction for simple replication. Ideally more follow up will be in subsequent PRs (now or down the track
Eileen McNaughton [Wed, 24 Jul 2019 09:01:24 +0000 (21:01 +1200)]
Merge pull request #14871 from eileenmcnaughton/import_post
[IMPORT] [code quality] [REF] Improve readability of variable assignment
Eileen McNaughton [Wed, 24 Jul 2019 09:01:06 +0000 (21:01 +1200)]
Merge pull request #14869 from eileenmcnaughton/import
[IMPORT] [code-quality] Remove usage of nullArray
Eileen McNaughton [Wed, 24 Jul 2019 09:00:50 +0000 (21:00 +1200)]
Merge pull request #14872 from eileenmcnaughton/import_mapper
[IMPORT] reduce php4 support, don't pass by ref when not required
eileen [Wed, 17 Jul 2019 04:01:33 +0000 (16:01 +1200)]
Remove exportComponent function - it's not adding much here
eileen [Wed, 17 Jul 2019 03:51:58 +0000 (15:51 +1200)]
Remove deprecated componentPaymentFields function
colemanw [Wed, 24 Jul 2019 05:35:02 +0000 (01:35 -0400)]
Merge pull request #14846 from eileenmcnaughton/ex_pos
[EXPORT] Fix unreleased regression where postal addresses are not suppressed when empty
eileen [Wed, 24 Jul 2019 05:11:21 +0000 (17:11 +1200)]
[IMPORT] reduce php4 support, don't pass by ref when not required
eileen [Wed, 24 Jul 2019 05:08:41 +0000 (17:08 +1200)]
[REF] Improve readability of variable assignment
Eileen McNaughton [Wed, 24 Jul 2019 04:53:13 +0000 (16:53 +1200)]
Merge pull request #14867 from eileenmcnaughton/mapping
[METADATA] Add titles to Mapping xml & DAOs
Eileen McNaughton [Wed, 24 Jul 2019 04:52:32 +0000 (16:52 +1200)]
Merge pull request #14868 from civicrm/5.16
5.16 to master
eileen [Wed, 24 Jul 2019 04:52:03 +0000 (16:52 +1200)]
Remove instances of CRM_Core_Error::fatal from first import form
eileen [Wed, 24 Jul 2019 04:26:56 +0000 (16:26 +1200)]
Remove usage of nullArray
colemanw [Wed, 24 Jul 2019 00:43:47 +0000 (20:43 -0400)]
Merge pull request #14860 from eileenmcnaughton/export_1
[REF] [EXPORT] Use columns from processor instead of passing them
Eileen McNaughton [Wed, 24 Jul 2019 00:02:59 +0000 (12:02 +1200)]
Merge pull request #14866 from alifrumin/5.16.0
Annotating and Sorting 5.16.0 release notes
eileen [Tue, 23 Jul 2019 23:54:57 +0000 (11:54 +1200)]
Add titles to Mapping xml & DAOs
Alice Frumin [Thu, 11 Jul 2019 14:57:48 +0000 (10:57 -0400)]
Annotating and Sorting 5.16.0 release notes
Mathieu Lutfy [Tue, 23 Jul 2019 12:46:15 +0000 (08:46 -0400)]
dev/event#9 Event Templates: do not set the Start/End dates
eileen [Tue, 23 Jul 2019 06:26:20 +0000 (18:26 +1200)]
Catch A.net exception & ignore
Hopefully we can avoid false negatives like
https://test.civicrm.org/job/CiviCRM-Core-PR/27923/testReport/junit/(root)/CRM_Core_Payment_AuthorizeNetIPNTest/testIPNPaymentRecurNoReceipt/
without losing too much
eileen [Tue, 16 Jul 2019 23:03:21 +0000 (11:03 +1200)]
Use columns from processor instead of passing them
colemanw [Tue, 23 Jul 2019 02:24:01 +0000 (22:24 -0400)]
Merge pull request #14859 from seamuslee001/nfc_audit_update
NFC Update node module versions based on npm audit fix
Seamus Lee [Tue, 23 Jul 2019 02:07:10 +0000 (12:07 +1000)]
Merge pull request #14856 from seamuslee001/atomfeeds_cache_convert
Add in Atomfeeds deprecation now that the extension has a new release…
Seamus Lee [Tue, 23 Jul 2019 00:46:39 +0000 (10:46 +1000)]
NFC Update node module versions based on npm audit fix
Seamus Lee [Mon, 22 Jul 2019 21:30:07 +0000 (07:30 +1000)]
Add in Atomfeeds deprecation now that the extension has a new release with converted cache mechanism
Fix version to match info.xml of new version
Eileen McNaughton [Tue, 23 Jul 2019 00:27:24 +0000 (12:27 +1200)]
Merge pull request #14857 from colemanw/testFormat
Autoformat /tests directory with php short array syntax
Coleman Watts [Mon, 22 Jul 2019 21:33:36 +0000 (17:33 -0400)]
Autoformat /tests directory with php short array syntax
Tim Otten [Mon, 22 Jul 2019 19:47:55 +0000 (12:47 -0700)]
Merge pull request #14855 from MikeyMJCO/patch-2
(NFC) Fixing documentation links in readme.
Mikey O'Toole [Mon, 22 Jul 2019 14:30:02 +0000 (15:30 +0100)]
Fixing documentation links in readme.
Matthew Wire [Mon, 22 Jul 2019 14:25:46 +0000 (15:25 +0100)]
Merge pull request #14639 from colemanw/i18nCleanup
Multilingual test fix and cleanup
colemanw [Mon, 22 Jul 2019 14:00:32 +0000 (10:00 -0400)]
Merge pull request #14716 from eileenmcnaughton/db
Add unit test demonstrating attaching a listener to queries
colemanw [Mon, 22 Jul 2019 13:56:11 +0000 (09:56 -0400)]
Merge pull request #14851 from eileenmcnaughton/tt
[REF] [Export] Move temp table creation function to the processor
colemanw [Mon, 22 Jul 2019 13:55:40 +0000 (09:55 -0400)]
Merge pull request #14853 from eileenmcnaughton/format
[NFC] code reformatting
Yashodha Chaku [Mon, 22 Jul 2019 12:08:08 +0000 (17:38 +0530)]
Merge pull request #14703 from eileenmcnaughton/act_search_wild
dev/core#538 fix advanced search on activity subject, detail to use wildcards like activity search does
Eileen McNaughton [Mon, 22 Jul 2019 01:08:35 +0000 (13:08 +1200)]
Merge pull request #14658 from MegaphoneJon/mail-46
mail#46 - show label, not value, on contribution custom field tokens
eileen [Tue, 2 Jul 2019 07:24:12 +0000 (19:24 +1200)]
dev/core#538 fix advanced search on activity subject, detail to use wildcards like activity search does
Eileen McNaughton [Mon, 22 Jul 2019 00:08:12 +0000 (12:08 +1200)]
Merge pull request #14735 from mattwire/deprecated_getallpermissions
Remove use of deprecated path in function `CRM_Event_BAO_Event::checkPermission()`
Eileen McNaughton [Sun, 21 Jul 2019 23:58:59 +0000 (11:58 +1200)]
Merge pull request #14843 from mattwire/priceset_to_metadatafield
Switch priceset selector to addField method
Eileen McNaughton [Sun, 21 Jul 2019 23:40:01 +0000 (11:40 +1200)]
Merge pull request #14852 from pradpnayak/SttingsTitle
Changed the title and description of profile_add_to_group_double_optin
Eileen McNaughton [Sun, 21 Jul 2019 23:04:31 +0000 (11:04 +1200)]
Merge pull request #14827 from deepak-srivastava/case-summary-report-case-type-filter
dev/core#1118 correct filteration by case type, re-use parent where()
eileen [Sun, 21 Jul 2019 22:48:25 +0000 (10:48 +1200)]
[NFC] code reformatting
Eileen McNaughton [Sun, 21 Jul 2019 22:44:14 +0000 (10:44 +1200)]
Merge pull request #14845 from colemanw/Set
Set profile greeting fields based on actual contact type
eileen [Tue, 16 Jul 2019 23:01:45 +0000 (11:01 +1200)]
Move temp table creation to the processor
Pradeep Nayak [Sun, 21 Jul 2019 17:29:44 +0000 (18:29 +0100)]
CHanged the title and description of profile_add_to_group_double_optin
Seamus Lee [Tue, 16 Jul 2019 14:39:08 +0000 (00:39 +1000)]
Ensure that if present the HTTP_X_FORWARDED_FOR IP address is used instead of the SERVER_ADDR when logging items from the IDS
Update Core IP address to match IDS Pattern
Deepak Srivastava [Sat, 20 Jul 2019 15:33:34 +0000 (16:33 +0100)]
dev/core#1118 define filter type for case_type_id
colemanw [Sat, 20 Jul 2019 07:13:26 +0000 (03:13 -0400)]
Merge pull request #14848 from eileenmcnaughton/test_fix
[REF][TEST][EXPORT] minor test cleanup & minor cleanup of code it tests
colemanw [Sat, 20 Jul 2019 07:12:42 +0000 (03:12 -0400)]
Merge pull request #14849 from eileenmcnaughton/test_up
[NFC] [TEST] code formatting in test class
colemanw [Sat, 20 Jul 2019 07:12:12 +0000 (03:12 -0400)]
Merge pull request #14850 from eileenmcnaughton/test_act
[REF] [TEST] cleanup on export activity test
colemanw [Sat, 20 Jul 2019 07:11:36 +0000 (03:11 -0400)]
Merge pull request #14838 from eileenmcnaughton/export
[REF] [Export] Stop passing exportParams & sqlColumns around
colemanw [Sat, 20 Jul 2019 04:36:18 +0000 (00:36 -0400)]
Merge pull request #14847 from eileenmcnaughton/silly_refs
[REF] Down with php4 compatibility
eileen [Sat, 20 Jul 2019 03:20:28 +0000 (15:20 +1200)]
[REF] [TEST] cleanup on export activity test
eileen [Sat, 20 Jul 2019 03:13:55 +0000 (15:13 +1200)]
[NFC] [TEST] code formatting in test class
eileen [Sat, 20 Jul 2019 03:05:44 +0000 (15:05 +1200)]
[REF][TEST][EXPORT] minor test cleanup & minor cleanup of code it tests
eileen [Sat, 20 Jul 2019 01:52:55 +0000 (13:52 +1200)]
Fix unreleased regression where postal addresses are not suppressed when empty
I had a suspicion about this as the variable showed as unused in my IDE so I upgraded the test that was failing to notice
and it started failing on this.
Bug is that the lines were not being added to the query to suppress empty addresses.
eileen [Sat, 20 Jul 2019 02:31:18 +0000 (14:31 +1200)]
Down with php4 compatibility
Removes a few more cases where parameters are needlessly passed as references
Coleman Watts [Fri, 19 Jul 2019 19:36:17 +0000 (15:36 -0400)]
Set profile greeting fields based on actual contact type