civicrm-core.git
2 years agoFix import class loading issue in entityTypes hook
Eileen McNaughton [Mon, 26 Sep 2022 21:33:43 +0000 (10:33 +1300)]
Fix import class loading issue in entityTypes hook

2 years agoMerge pull request #24615 from demeritcowboy/null-v-null
Eileen McNaughton [Mon, 26 Sep 2022 19:44:24 +0000 (08:44 +1300)]
Merge pull request #24615 from demeritcowboy/null-v-null

dev/core#3862 - Crash when creating message template

2 years agouse real null for primary keys
demeritcowboy [Mon, 26 Sep 2022 15:51:50 +0000 (11:51 -0400)]
use real null for primary keys

2 years agoextract composite key handling
demeritcowboy [Mon, 26 Sep 2022 15:51:32 +0000 (11:51 -0400)]
extract composite key handling

2 years agounit test
demeritcowboy [Mon, 26 Sep 2022 15:43:12 +0000 (11:43 -0400)]
unit test

2 years agoMerge pull request #24593 from eileenmcnaughton/regress
demeritcowboy [Sat, 24 Sep 2022 19:22:56 +0000 (15:22 -0400)]
Merge pull request #24593 from eileenmcnaughton/regress

dev/core#3826 Fix regression on contribution search tasks in search-kit

2 years agoMerge pull request #24601 from demeritcowboy/err
Eileen McNaughton [Sat, 24 Sep 2022 02:12:50 +0000 (14:12 +1200)]
Merge pull request #24601 from demeritcowboy/err

Put back exception during class scanning

2 years agocan't call log this early
demeritcowboy [Fri, 23 Sep 2022 18:56:05 +0000 (14:56 -0400)]
can't call log this early

2 years agoMerge pull request #24584 from eileenmcnaughton/import_key
demeritcowboy [Fri, 23 Sep 2022 15:15:02 +0000 (11:15 -0400)]
Merge pull request #24584 from eileenmcnaughton/import_key

Undo breakage of multi-primary key entities

2 years agodev/core#3826 Fix regression on contribution search tasks in search-kit
Eileen McNaughton [Fri, 23 Sep 2022 00:26:32 +0000 (12:26 +1200)]
dev/core#3826 Fix regression on contribution search tasks in search-kit

When switching from GET to POST calls (to support greater numbers of ids)
the fix required the qfKey to be set in search-kit. However, the
selected class name for the qfKey for contribution tasks
was wrong - leading to a validation error

2 years agoMerge pull request #24580 from eileenmcnaughton/ss_scanner
Eileen McNaughton [Thu, 22 Sep 2022 23:11:56 +0000 (11:11 +1200)]
Merge pull request #24580 from eileenmcnaughton/ss_scanner

Class scanner - do not throw runTime Exception if class not loaded

2 years agoClass scanner - do not throw runTime Exception if class not loaded
Eileen McNaughton [Wed, 21 Sep 2022 02:01:03 +0000 (14:01 +1200)]
Class scanner - do not throw runTime Exception if class not loaded

2 years agoMerge pull request #24545 from eileenmcnaughton/import_angular
colemanw [Thu, 22 Sep 2022 21:42:51 +0000 (17:42 -0400)]
Merge pull request #24545 from eileenmcnaughton/import_angular

Add angular form to civiimport extension

2 years agoMerge pull request #24588 from eileenmcnaughton/rc
Eileen McNaughton [Thu, 22 Sep 2022 06:13:09 +0000 (18:13 +1200)]
Merge pull request #24588 from eileenmcnaughton/rc

Fix warnings on upgrade when non-core message templates exist

2 years agoFix warnings on upgrade when non-core message templates exist
Eileen McNaughton [Thu, 22 Sep 2022 02:37:09 +0000 (14:37 +1200)]
Fix warnings on upgrade when non-core message templates exist

2 years agoMerge pull request #24587 from demeritcowboy/home-billing
demeritcowboy [Thu, 22 Sep 2022 02:59:29 +0000 (22:59 -0400)]
Merge pull request #24587 from demeritcowboy/home-billing

dev/core#3863 - Default email location on contact is always Billing

2 years agomake default work again
demeritcowboy [Thu, 22 Sep 2022 01:11:39 +0000 (21:11 -0400)]
make default work again

2 years agoUndo breakage of multi-primary key entities
Eileen McNaughton [Wed, 21 Sep 2022 22:14:43 +0000 (10:14 +1200)]
Undo breakage of multi-primary key entities

2 years agoAdd angular form to civiimport extension
Eileen McNaughton [Mon, 29 Aug 2022 21:40:38 +0000 (09:40 +1200)]
Add angular form to civiimport extension

2 years agoFix missing labels in preview screen
Eileen McNaughton [Tue, 20 Sep 2022 03:59:35 +0000 (15:59 +1200)]
Fix missing labels in preview screen

2 years agoMerge pull request #24574 from eileenmcnaughton/import_keys
Eileen McNaughton [Tue, 20 Sep 2022 04:36:16 +0000 (16:36 +1200)]
Merge pull request #24574 from eileenmcnaughton/import_keys

Fix some inconsistent key names, as used by civiimport

2 years agoMerge pull request #24572 from totten/5.54-joomla
Eileen McNaughton [Tue, 20 Sep 2022 04:35:52 +0000 (16:35 +1200)]
Merge pull request #24572 from totten/5.54-joomla

Add temporary file to help Joomla installers (5.54-rc)

2 years agoTurn the ghost into a skeleton
Tim Otten [Tue, 20 Sep 2022 03:01:29 +0000 (20:01 -0700)]
Turn the ghost into a skeleton

2 years agoFix some inconsistent key names, as used by civiimport
Eileen McNaughton [Tue, 20 Sep 2022 02:49:31 +0000 (14:49 +1200)]
Fix some inconsistent key names, as used by civiimport

2 years agoMerge pull request #24566 from eileenmcnaughton/import_soft
colemanw [Tue, 20 Sep 2022 01:12:00 +0000 (21:12 -0400)]
Merge pull request #24566 from eileenmcnaughton/import_soft

Remove attempt to match on soft credit header

2 years agoMerge pull request #24551 from colemanw/autocompleteFix
Eileen McNaughton [Tue, 20 Sep 2022 01:10:51 +0000 (13:10 +1200)]
Merge pull request #24551 from colemanw/autocompleteFix

Afform - Fix "Existing" autocomplete field and add tests

2 years ago(NFC) Cross-reference Joomla cleanup lists
Tim Otten [Tue, 20 Sep 2022 00:57:00 +0000 (17:57 -0700)]
(NFC) Cross-reference Joomla cleanup lists

2 years agoAdd temporary file to help Joomla installers
Eileen McNaughton [Thu, 8 Sep 2022 00:26:49 +0000 (12:26 +1200)]
Add temporary file to help Joomla installers

2 years agoMerge pull request #24570 from seamuslee001/fix_dismaker_typo
Seamus Lee [Tue, 20 Sep 2022 00:34:29 +0000 (10:34 +1000)]
Merge pull request #24570 from seamuslee001/fix_dismaker_typo

[NFC] Fix Typo in Dismaker list of core exts

2 years ago[NFC] Fix Typo in Dismaker list of core exts
Seamus Lee [Tue, 20 Sep 2022 00:32:35 +0000 (10:32 +1000)]
[NFC] Fix Typo in Dismaker list of core exts

2 years agoRemove attempt to match on soft credit header
Eileen McNaughton [Mon, 19 Sep 2022 21:48:51 +0000 (09:48 +1200)]
Remove attempt to match on soft credit header

2 years agoMerge pull request #24538 from eileenmcnaughton/import_temp_table
colemanw [Mon, 19 Sep 2022 21:44:03 +0000 (17:44 -0400)]
Merge pull request #24538 from eileenmcnaughton/import_temp_table

Stop removing Import tables during cache clearing

2 years agoMerge pull request #24546 from eileenmcnaughton/flush
colemanw [Mon, 19 Sep 2022 21:42:55 +0000 (17:42 -0400)]
Merge pull request #24546 from eileenmcnaughton/flush

Flush old user jobs

2 years agoMerge pull request #24547 from eileenmcnaughton/import_entity_no
colemanw [Mon, 19 Sep 2022 21:41:31 +0000 (17:41 -0400)]
Merge pull request #24547 from eileenmcnaughton/import_entity_no

Fix entity_id being saved to message field (only affects rc+)

2 years agoMerge pull request #24554 from totten/5.54-xdebug
Seamus Lee [Mon, 19 Sep 2022 01:47:39 +0000 (11:47 +1000)]
Merge pull request #24554 from totten/5.54-xdebug

DebugSubscriber - Fix activation check

2 years agoDebugSubscriber - Fix activation check
Tim Otten [Sun, 18 Sep 2022 23:11:53 +0000 (16:11 -0700)]
DebugSubscriber - Fix activation check

This subscriber only interjects if XDebug is configured with the suitable mode.

To see if the mode is suitable, it consults `ini_get("xdebug.mode")`, but
this is not quite right -- because the mode may be set other ways (eg
`XDEBUG_MODE`). In XDebug 3.1+, you can get the true effective-mode
by calling `xdebug_info`.

See also: https://xdebug.org/docs/all_functions#xdebug_info

2 years agoAfform - Fix "Existing" autocomplete field and add tests
Coleman Watts [Sun, 18 Sep 2022 15:36:55 +0000 (11:36 -0400)]
Afform - Fix "Existing" autocomplete field and add tests

Followup to #24165 which regressed when the action was changed.
Locks in the fix with unit tests.

2 years agoMerge pull request #24543 from eileenmcnaughton/opt
Eileen McNaughton [Sat, 17 Sep 2022 04:51:12 +0000 (16:51 +1200)]
Merge pull request #24543 from eileenmcnaughton/opt

Pass correct variable type to CRM_Core_OptionValue::getValues

2 years agoFix entity_id being saved to message field
Eileen McNaughton [Sat, 17 Sep 2022 04:47:51 +0000 (16:47 +1200)]
Fix entity_id being saved to message field

2 years agoClean up user jobs
Eileen McNaughton [Sat, 17 Sep 2022 00:18:38 +0000 (12:18 +1200)]
Clean up user jobs

2 years agoMerge pull request #24520 from eileenmcnaughton/import_configy
colemanw [Fri, 16 Sep 2022 23:47:07 +0000 (19:47 -0400)]
Merge pull request #24520 from eileenmcnaughton/import_configy

Fix import to support entity_configuration

2 years agoStop removing Import tables during cache clearing
Eileen McNaughton [Thu, 15 Sep 2022 23:24:49 +0000 (11:24 +1200)]
Stop removing Import tables during cache clearing

2 years agoPass correct variable type to CRM_Core_OptionValue::getValues
Eileen McNaughton [Fri, 16 Sep 2022 22:15:31 +0000 (10:15 +1200)]
Pass correct variable type to CRM_Core_OptionValue::getValues

2 years agoFix import to support entity_configuration
Eileen McNaughton [Thu, 15 Sep 2022 05:47:36 +0000 (17:47 +1200)]
Fix import to support entity_configuration

2 years agoMerge pull request #24532 from eileenmcnaughton/import_temp
Seamus Lee [Fri, 16 Sep 2022 01:31:32 +0000 (11:31 +1000)]
Merge pull request #24532 from eileenmcnaughton/import_temp

Remove references to old temp table names

2 years agoRemove references to old temp table names
Eileen McNaughton [Thu, 15 Sep 2022 23:07:08 +0000 (11:07 +1200)]
Remove references to old temp table names

2 years agoMerge pull request #24517 from seamuslee001/update_zetacomponents
demeritcowboy [Thu, 15 Sep 2022 11:39:24 +0000 (07:39 -0400)]
Merge pull request #24517 from seamuslee001/update_zetacomponents

[REF] Update Zetacomponents/mail to be 1.9.4

2 years ago[REF] Update Zetacomponents/mail to be 1.9.4
Seamus Lee [Thu, 15 Sep 2022 05:06:04 +0000 (15:06 +1000)]
[REF] Update Zetacomponents/mail to be 1.9.4

2 years agoMerge pull request #24515 from demeritcowboy/upmerge
Seamus Lee [Thu, 15 Sep 2022 05:03:22 +0000 (15:03 +1000)]
Merge pull request #24515 from demeritcowboy/upmerge

upmerge #24506 - got stuck in limbo between branches

2 years agoupmerge #24506
demeritcowboy [Thu, 15 Sep 2022 01:57:20 +0000 (21:57 -0400)]
upmerge #24506

2 years agoSet version to 5.54.beta1
CiviCRM [Thu, 15 Sep 2022 01:38:22 +0000 (01:38 +0000)]
Set version to 5.54.beta1

2 years agoMerge pull request #24514 from colemanw/fixWhereEquations
demeritcowboy [Wed, 14 Sep 2022 21:43:49 +0000 (17:43 -0400)]
Merge pull request #24514 from colemanw/fixWhereEquations

SearchKit - Fix arithmetic in WHERE clause

2 years agoMerge pull request #24512 from colemanw/contactTypeSearch
Eileen McNaughton [Wed, 14 Sep 2022 21:42:26 +0000 (09:42 +1200)]
Merge pull request #24512 from colemanw/contactTypeSearch

AdminUI - Add SearchKit-based screen for Administer Contact Types

2 years agoMerge pull request #24510 from eileenmcnaughton/import_default
colemanw [Wed, 14 Sep 2022 20:36:26 +0000 (16:36 -0400)]
Merge pull request #24510 from eileenmcnaughton/import_default

Add unit test & handling  for processing from UserJob configuration rather than form submitted values

2 years agoMerge pull request #24513 from demeritcowboy/null-middle
colemanw [Wed, 14 Sep 2022 20:20:24 +0000 (16:20 -0400)]
Merge pull request #24513 from demeritcowboy/null-middle

dev/core#3838 - Addressee token evaluates middle_name as literal string null

2 years agoSearchKit - Fix arithmetic in WHERE clause
Coleman Watts [Wed, 14 Sep 2022 18:51:05 +0000 (14:51 -0400)]
SearchKit - Fix arithmetic in WHERE clause

Permit SqlEquation in APIv4 WHERE clauses so it works in SearchKit.
Fixes dev/core#3845

2 years agorestore string null checks
demeritcowboy [Wed, 14 Sep 2022 16:44:35 +0000 (12:44 -0400)]
restore string null checks

2 years agoAdminUI - Add SearchKit-based screen for Administer Contact Types
Coleman Watts [Wed, 14 Sep 2022 13:23:45 +0000 (09:23 -0400)]
AdminUI - Add SearchKit-based screen for Administer Contact Types

2 years agoSearchKit - Support an "Add New" button at the top of displays
Coleman Watts [Wed, 14 Sep 2022 02:38:25 +0000 (22:38 -0400)]
SearchKit - Support an "Add New" button at the top of displays

2 years agoSearchKit - Improve metadata for ContactType & add standalone path to edit form
Coleman Watts [Tue, 13 Sep 2022 21:08:03 +0000 (17:08 -0400)]
SearchKit - Improve metadata for ContactType & add standalone path to edit form

Giving the listing page and the edit form seperate url paths allow each
to be replaced incrimentally by the civicrm_admin_ui extension.

2 years agoMerge pull request #24181 from colemanw/searchKitDate
colemanw [Wed, 14 Sep 2022 10:56:14 +0000 (06:56 -0400)]
Merge pull request #24181 from colemanw/searchKitDate

SearchKit - Allow aggreation by partial dates

2 years agoMerge pull request #24508 from yashodha/report_cleanup
Eileen McNaughton [Wed, 14 Sep 2022 07:22:21 +0000 (19:22 +1200)]
Merge pull request #24508 from yashodha/report_cleanup

report clean up templates

2 years agoAdd unit test & handling for processing from UserJob configuration rather than form...
Eileen McNaughton [Wed, 14 Sep 2022 06:00:16 +0000 (18:00 +1200)]
Add unit test & handling  for processing from UserJob configuration rather than form submitted values

2 years agoreport clean up templates
yashodha [Tue, 13 Sep 2022 14:58:45 +0000 (20:28 +0530)]
report clean up templates

2 years agoMerge pull request #24507 from eileenmcnaughton/bao
Eileen McNaughton [Wed, 14 Sep 2022 01:25:22 +0000 (13:25 +1200)]
Merge pull request #24507 from eileenmcnaughton/bao

BAO regen

2 years agoMerge pull request #24502 from eileenmcnaughton/import_dupe_soft
colemanw [Tue, 13 Sep 2022 23:38:56 +0000 (19:38 -0400)]
Merge pull request #24502 from eileenmcnaughton/import_dupe_soft

Fix unreleased regression on soft credit imports

2 years agoBAO regen
Eileen McNaughton [Tue, 13 Sep 2022 21:07:02 +0000 (09:07 +1200)]
BAO regen

2 years agoMerge pull request #24504 from yashodha/report_cleanup
demeritcowboy [Tue, 13 Sep 2022 18:47:03 +0000 (14:47 -0400)]
Merge pull request #24504 from yashodha/report_cleanup

report clean up templates

2 years agoMerge pull request #24505 from colemanw/fkFields
colemanw [Tue, 13 Sep 2022 17:42:32 +0000 (13:42 -0400)]
Merge pull request #24505 from colemanw/fkFields

SearchKit - Show other FK fields in the bridge join selector

2 years agoSearchKit - Show other FK fields in the bridge join selector
Coleman Watts [Tue, 13 Sep 2022 15:09:41 +0000 (11:09 -0400)]
SearchKit - Show other FK fields in the bridge join selector

2 years agoreport clean up templates
yashodha [Tue, 13 Sep 2022 14:55:27 +0000 (20:25 +0530)]
report clean up templates

2 years agoMerge pull request #24503 from yashodha/dev_3790
Eileen McNaughton [Tue, 13 Sep 2022 12:20:06 +0000 (00:20 +1200)]
Merge pull request #24503 from yashodha/dev_3790

report cleanup

2 years agoMerge pull request #24149 from agileware/CIVICRM-2024
Eileen McNaughton [Tue, 13 Sep 2022 12:08:39 +0000 (00:08 +1200)]
Merge pull request #24149 from agileware/CIVICRM-2024

🎁 CiviEvent, Event Dashboard, iCal links are inside the h3 styling move out and add spacing

2 years agoreport cleanup
yashodha [Tue, 13 Sep 2022 05:50:25 +0000 (11:20 +0530)]
report cleanup

2 years agoFix unreleased regression on soft credit imports
Eileen McNaughton [Tue, 13 Sep 2022 01:11:48 +0000 (13:11 +1200)]
Fix unreleased regression on soft credit imports

Fixes an unreleased regression whereby it was only permitting an email match with the same
contact type as the main contact for a soft credit import

2 years agoMerge pull request #24501 from eileenmcnaughton/import_dupe_rules
Eileen McNaughton [Tue, 13 Sep 2022 03:54:45 +0000 (15:54 +1200)]
Merge pull request #24501 from eileenmcnaughton/import_dupe_rules

Improve contribution import error handling

2 years agoImprove contribution import error handling
Eileen McNaughton [Mon, 12 Sep 2022 23:54:26 +0000 (11:54 +1200)]
Improve contribution import error handling

2 years agoMerge pull request #24448 from colemanw/searchDisplayCalcFieldFilters
colemanw [Mon, 12 Sep 2022 13:48:22 +0000 (09:48 -0400)]
Merge pull request #24448 from colemanw/searchDisplayCalcFieldFilters

SearchKit - Better support for calculated fields as Afform filters

2 years agoMerge pull request #24498 from braders/docblock-var-syntax
demeritcowboy [Mon, 12 Sep 2022 13:21:05 +0000 (09:21 -0400)]
Merge pull request #24498 from braders/docblock-var-syntax

[REF] Fix syntax of var docblocks

2 years agoCIVICRM-2024 CiviEvent, Event Dashboard, iCal links are inside the h3 styling move...
Justin Freeman [Sun, 11 Sep 2022 23:19:00 +0000 (09:19 +1000)]
CIVICRM-2024 CiviEvent, Event Dashboard, iCal links are inside the h3 styling move out and add spacing

2 years ago[REF] Fix syntax of var docblocks
Bradley Taylor [Sun, 11 Sep 2022 17:27:30 +0000 (18:27 +0100)]
[REF] Fix syntax of var docblocks

2 years agoMerge pull request #24495 from braders/phpdoc-fixes-4
demeritcowboy [Sun, 11 Sep 2022 16:17:01 +0000 (12:17 -0400)]
Merge pull request #24495 from braders/phpdoc-fixes-4

More PHPdoc fixes

2 years agoSearchKit - Better support for calculated fields as Afform filters
Coleman Watts [Fri, 2 Sep 2022 14:37:39 +0000 (10:37 -0400)]
SearchKit - Better support for calculated fields as Afform filters

Improves support for calculated fields in the Afform Admin UI, allowing them to be
configured more like real fields. This allows e.g. a SUM() aggregate to be made a
"search by range" filter.

2 years agoMore PHPdoc fixes
Bradley Taylor [Sun, 11 Sep 2022 13:33:41 +0000 (14:33 +0100)]
More PHPdoc fixes

2 years agoMerge pull request #24493 from totten/master-slashslash
demeritcowboy [Fri, 9 Sep 2022 23:16:31 +0000 (19:16 -0400)]
Merge pull request #24493 from totten/master-slashslash

(REF) SettingsMetadata - Small cleanup to prevent duplicate slashes

2 years agoMerge pull request #24492 from yashodha/dev_3790
demeritcowboy [Fri, 9 Sep 2022 23:15:11 +0000 (19:15 -0400)]
Merge pull request #24492 from yashodha/dev_3790

(dev/core#3790) Pledge status is missing on View Pledge page

2 years ago(REF) SettingsMetadata - Small cleanup to prevent duplicate slashes
Tim Otten [Fri, 9 Sep 2022 20:21:11 +0000 (13:21 -0700)]
(REF) SettingsMetadata - Small cleanup to prevent duplicate slashes

2 years agoMerge pull request #24428 from braders/financial-192
demeritcowboy [Fri, 9 Sep 2022 13:01:29 +0000 (09:01 -0400)]
Merge pull request #24428 from braders/financial-192

dev/financial#192 Fallback to custom currency object for codes which Brick\Money does not support.

2 years agoMerge pull request #24489 from shaneonabike/pr24470
demeritcowboy [Fri, 9 Sep 2022 13:01:01 +0000 (09:01 -0400)]
Merge pull request #24489 from shaneonabike/pr24470

Adding better wording to Events page for matching dates

2 years ago(dev/core#3790) Pledge status is missing on View Pledge page
yashodha [Fri, 9 Sep 2022 12:09:04 +0000 (17:39 +0530)]
(dev/core#3790) Pledge status is missing on View Pledge page

2 years agoMerge pull request #24332 from eileenmcnaughton/smarty_sig_html
colemanw [Fri, 9 Sep 2022 01:27:29 +0000 (21:27 -0400)]
Merge pull request #24332 from eileenmcnaughton/smarty_sig_html

Fix email notices on email edit block

2 years agoMerge pull request #24490 from totten/master-filescan
Tim Otten [Fri, 9 Sep 2022 01:05:21 +0000 (18:05 -0700)]
Merge pull request #24490 from totten/master-filescan

File::findFiles - Save 200 million nanoseconds

2 years agoMerge pull request #24485 from eileenmcnaughton/import_cont_soft
colemanw [Fri, 9 Sep 2022 00:57:23 +0000 (20:57 -0400)]
Merge pull request #24485 from eileenmcnaughton/import_cont_soft

dev/core#1172 Fix Contribution import to handle ContributionSoft in a storable way

2 years agoMerge pull request #24480 from totten/master-global
demeritcowboy [Fri, 9 Sep 2022 00:39:49 +0000 (20:39 -0400)]
Merge pull request #24480 from totten/master-global

ClassScanner - Fix guard for preboot cache scenario

2 years agoFile::findFiles - Save 200 million nanoseconds
Tim Otten [Thu, 8 Sep 2022 22:08:29 +0000 (15:08 -0700)]
File::findFiles - Save 200 million nanoseconds

2 years agodev/core#1172 Fix Contribution import to handle ContributionSoft in a storable way
Eileen McNaughton [Thu, 8 Sep 2022 04:59:16 +0000 (16:59 +1200)]
dev/core#1172 Fix Contribution import to handle ContributionSoft in a storable way

2 years ago[REF] Extract code to delete existing soft credit
Eileen McNaughton [Thu, 8 Sep 2022 12:05:06 +0000 (00:05 +1200)]
[REF] Extract code to delete existing soft credit

2 years agoFold importableFields back into setMetadata - per the code todo
Eileen McNaughton [Thu, 8 Sep 2022 12:12:22 +0000 (00:12 +1200)]
Fold importableFields back into setMetadata - per the code todo

2 years agoMove header handling to the Form layer in import
Eileen McNaughton [Thu, 8 Sep 2022 11:53:59 +0000 (23:53 +1200)]
Move header handling to the Form layer in import

2 years agoMerge pull request #24409 from eileenmcnaughton/notice_contribution
colemanw [Thu, 8 Sep 2022 18:49:16 +0000 (14:49 -0400)]
Merge pull request #24409 from eileenmcnaughton/notice_contribution

Fix some notices on New Contribution page (smarty)