civicrm-core.git
20 months agoMerge pull request #25918 from mlutfy/core4204
Eileen McNaughton [Sat, 25 Mar 2023 21:08:01 +0000 (10:08 +1300)]
Merge pull request #25918 from mlutfy/core4204

dev/core#4204 Show the Payment Agreement of the selected processor

20 months agoMerge pull request #25921 from braders/unused-ufmatchid
Eileen McNaughton [Sat, 25 Mar 2023 21:05:44 +0000 (10:05 +1300)]
Merge pull request #25921 from braders/unused-ufmatchid

[REF][PHP8.2] Remove unused dyanamic property

20 months ago[REF][PHP8.2] Remove unused dyanamic property
Bradley Taylor [Sat, 25 Mar 2023 16:15:12 +0000 (16:15 +0000)]
[REF][PHP8.2] Remove unused dyanamic property

20 months agodev/core#4204 Show the Payment Agreement of the selected processor
Mathieu Lutfy [Sat, 25 Mar 2023 01:12:45 +0000 (21:12 -0400)]
dev/core#4204 Show the Payment Agreement of the selected processor

20 months agoMerge pull request #25916 from civicrm/5.60
Eileen McNaughton [Sat, 25 Mar 2023 01:11:54 +0000 (14:11 +1300)]
Merge pull request #25916 from civicrm/5.60

5.60 to master

20 months agoMerge pull request #25910 from eileenmcnaughton/regression_dd
Mathieu Lu [Sat, 25 Mar 2023 00:28:33 +0000 (20:28 -0400)]
Merge pull request #25910 from eileenmcnaughton/regression_dd

dev/core#4189 Fix indiscriminate display of direct debit agreement

20 months agoMerge pull request #25900 from eileenmcnaughton/import_contact_custom_bool
colemanw [Fri, 24 Mar 2023 22:50:20 +0000 (18:50 -0400)]
Merge pull request #25900 from eileenmcnaughton/import_contact_custom_bool

dev/core#3937 Remove legacy code causing custom boolean import bug

20 months agoMerge pull request #25913 from mlutfy/flushCacheButton
Matthew Wire [Fri, 24 Mar 2023 21:30:14 +0000 (21:30 +0000)]
Merge pull request #25913 from mlutfy/flushCacheButton

UpdateConfigBackend: use api4 to flush the cache

20 months agoUpdateConfigBackend: use api4 to flush the cache
Mathieu Lutfy [Fri, 24 Mar 2023 19:36:26 +0000 (15:36 -0400)]
UpdateConfigBackend: use api4 to flush the cache

20 months agoMerge pull request #25780 from yashodha/dev-4176
demeritcowboy [Fri, 24 Mar 2023 17:20:22 +0000 (13:20 -0400)]
Merge pull request #25780 from yashodha/dev-4176

(dev/core#4176) Allow to search on participant id

20 months ago(dev/core#4176) Allow to search on participant id
yashodha [Fri, 10 Mar 2023 06:37:38 +0000 (12:07 +0530)]
(dev/core#4176) Allow to search on participant id

20 months agoMerge pull request #25876 from eileenmcnaughton/custom_number
Eileen McNaughton [Fri, 24 Mar 2023 02:43:44 +0000 (15:43 +1300)]
Merge pull request #25876 from eileenmcnaughton/custom_number

dev/core#4152 Fix custom data code to not cast to a float

20 months agoMerge pull request #25911 from eileenmcnaughton/master
Eileen McNaughton [Fri, 24 Mar 2023 01:53:36 +0000 (14:53 +1300)]
Merge pull request #25911 from eileenmcnaughton/master

5.60 to master

20 months agoMerge branch '5.60' of github.com:civicrm/civicrm-core
Eileen McNaughton [Fri, 24 Mar 2023 01:52:06 +0000 (14:52 +1300)]
Merge branch '5.60' of github.com:civicrm/civicrm-core

20 months agoMerge pull request #25897 from eileenmcnaughton/import_contact_id
colemanw [Fri, 24 Mar 2023 01:40:10 +0000 (21:40 -0400)]
Merge pull request #25897 from eileenmcnaughton/import_contact_id

Fix for issue when optional contact_id is blank importing contributions

20 months agoMerge pull request #25905 from colemanw/getSetApiValues
colemanw [Fri, 24 Mar 2023 01:30:43 +0000 (21:30 -0400)]
Merge pull request #25905 from colemanw/getSetApiValues

Api4 - Prevent developer error mixing up `addValue` with `addWhere`

20 months agodev/core#4189 Fix indiscriminate display of direct debit agreement
Eileen McNaughton [Thu, 23 Mar 2023 23:33:14 +0000 (12:33 +1300)]
dev/core#4189 Fix indiscriminate display of direct debit agreement

20 months agoMerge pull request #25909 from totten/5.60-vertest
Tim Otten [Thu, 23 Mar 2023 23:21:30 +0000 (16:21 -0700)]
Merge pull request #25909 from totten/5.60-vertest

(NFC) Version Check Test - Fix multi-user and concurrent execution

20 months agodev/core#3937 Remove legacy code causing custom boolean import bug
Eileen McNaughton [Thu, 23 Mar 2023 00:25:27 +0000 (13:25 +1300)]
dev/core#3937 Remove legacy code causing custom boolean import bug

20 months ago(NFC) Version Check Test - Fix multi-user and concurrent execution
Tim Otten [Thu, 23 Mar 2023 22:22:10 +0000 (15:22 -0700)]
(NFC) Version Check Test - Fix multi-user and concurrent execution

This is a small change to the way the tests run. It doesn't change the meaning of the test.

Before
------

* Writes example file to `/tmp/versionCheckTestFile.json`.
* File left behind at end of test.
* If two users runs the same test at different times, they could interfere with each other.
* If two processes run the same test at the same time, they could interfere with each other.

After
-----

* Writes example file to `/tmp/VersionCheck-NNNNNNN/versionCheckTestFile.json`
* Temp folder cleaned up at end
* If two users or two processes run the test, they use separate folders

20 months agoMerge pull request #25672 from colemanw/joinStuff
Joe Murray [Thu, 23 Mar 2023 21:51:02 +0000 (17:51 -0400)]
Merge pull request #25672 from colemanw/joinStuff

Note API - Fix viewing, joining to, and updating Notes

20 months agoMerge pull request #25903 from colemanw/hookCleanup
demeritcowboy [Thu, 23 Mar 2023 16:40:14 +0000 (12:40 -0400)]
Merge pull request #25903 from colemanw/hookCleanup

Code cleanup on aisle Hook

20 months agoMerge pull request #25895 from eileenmcnaughton/url
colemanw [Thu, 23 Mar 2023 16:35:05 +0000 (12:35 -0400)]
Merge pull request #25895 from eileenmcnaughton/url

Fix recently added import url

20 months agoMerge pull request #25896 from eileenmcnaughton/import_label
colemanw [Thu, 23 Mar 2023 16:33:41 +0000 (12:33 -0400)]
Merge pull request #25896 from eileenmcnaughton/import_label

Show friendlier labels when Civi-Import enabled

20 months agoMerge pull request #25898 from eileenmcnaughton/import_contact_custom
colemanw [Thu, 23 Mar 2023 16:22:05 +0000 (12:22 -0400)]
Merge pull request #25898 from eileenmcnaughton/import_contact_custom

Fix Contact Import tests custom date testing, remove duplicate handling

20 months agoApi4 - Prevent developer error mixing up the `addValue` and `addWhere` functions
Coleman Watts [Thu, 23 Mar 2023 13:05:39 +0000 (09:05 -0400)]
Api4 - Prevent developer error mixing up the `addValue` and `addWhere` functions

20 months agoCode cleanup on aisle CRM_Utils_Hook
Coleman Watts [Thu, 23 Mar 2023 12:40:21 +0000 (08:40 -0400)]
Code cleanup on aisle CRM_Utils_Hook

20 months agoMerge pull request #25902 from demeritcowboy/that
colemanw [Thu, 23 Mar 2023 11:57:36 +0000 (07:57 -0400)]
Merge pull request #25902 from demeritcowboy/that

[NFC] hulk smash

20 months agohulk smash
demeritcowboy [Thu, 23 Mar 2023 06:05:57 +0000 (02:05 -0400)]
hulk smash

20 months agoMerge pull request #25901 from colemanw/nullObject
Eileen McNaughton [Thu, 23 Mar 2023 02:47:40 +0000 (15:47 +1300)]
Merge pull request #25901 from colemanw/nullObject

Deprecate CRM_Utils_Hook::$nullObject

20 months agoDeprecate CRM_Utils_Hook::$nullObject
Coleman Watts [Thu, 23 Mar 2023 01:07:17 +0000 (21:07 -0400)]
Deprecate CRM_Utils_Hook::$nullObject

20 months agoFix Contact Import tests custom date testing, remove duplicate handling
Eileen McNaughton [Wed, 22 Mar 2023 22:28:25 +0000 (11:28 +1300)]
Fix Contact Import tests custom date testing, remove duplicate handling

All the code in the formatCommonData function is legacy contact
import handling for stuff that is already handled in the generic
metadata based code. This fixes the test so it is actually testing
it for contact and address custom date fields & removes

20 months agoMerge pull request #25894 from eileenmcnaughton/find_protected
colemanw [Wed, 22 Mar 2023 12:23:36 +0000 (08:23 -0400)]
Merge pull request #25894 from eileenmcnaughton/find_protected

Add getter for dedupeRuleGroupID

20 months agoMerge pull request #25874 from eileenmcnaughton/usage
colemanw [Wed, 22 Mar 2023 12:13:46 +0000 (08:13 -0400)]
Merge pull request #25874 from eileenmcnaughton/usage

Add handling of `usage` to `DAO` generator

20 months agoFix for issue when optional contact_id is blank
Eileen McNaughton [Wed, 22 Mar 2023 09:22:37 +0000 (22:22 +1300)]
Fix for issue when optional contact_id is blank

20 months agoShow friendlier labels when Civi-Import enabled
Eileen McNaughton [Wed, 22 Mar 2023 04:41:11 +0000 (17:41 +1300)]
Show friendlier labels when Civi-Import enabled

20 months agoFix recently added import url
Eileen McNaughton [Wed, 22 Mar 2023 03:29:54 +0000 (16:29 +1300)]
Fix recently added import url

my head hurts - every other import url follows the other
format - ie civicrm/import/contribution & is
defined in Import.xml

Consistency wishmistancy

20 months agoMerge pull request #25887 from eileenmcnaughton/dep_dn
Tim Otten [Wed, 22 Mar 2023 00:46:56 +0000 (17:46 -0700)]
Merge pull request #25887 from eileenmcnaughton/dep_dn

Remove 2021 noisily deprecated pdfCommon function

20 months agoMerge pull request #25891 from eileenmcnaughton/map_field
Tim Otten [Wed, 22 Mar 2023 00:30:19 +0000 (17:30 -0700)]
Merge pull request #25891 from eileenmcnaughton/map_field

[NFC] Add metadata about import jobs to `MapField` form

20 months agoAdd getter for dedupeRuleGroupID
Eileen McNaughton [Tue, 21 Mar 2023 23:18:01 +0000 (12:18 +1300)]
Add getter for dedupeRuleGroupID

We recently declared this with protected visibility - it turns out WMF
actually references it... I figure maybe a getter is better practice so
we still can....

20 months agoMerge pull request #25890 from eileenmcnaughton/dep_mail_format
Seamus Lee [Tue, 21 Mar 2023 21:57:54 +0000 (08:57 +1100)]
Merge pull request #25890 from eileenmcnaughton/dep_mail_format

Remove references to deprecated `preferred_mail_format` in tests

20 months ago[NFC] Add metadata about import jobs to MapField form
Eileen McNaughton [Tue, 21 Mar 2023 21:19:41 +0000 (10:19 +1300)]
[NFC] Add metadata about import jobs to MapField form

This extra metadata has been part of a whole lot of PRs & somehow always
winds up in conflict or otherwise so I'm adding it by itself, wihout any usage of it.

Note that
- this brings MapField into line with DataSource
- there is nothing calling these functions as of this PR - it's just
an attempt to get the extra metadata added to the forms/ parsers without
conflict

20 months agoRemove references to deprecated preferred_mail_format in tests
Eileen McNaughton [Tue, 21 Mar 2023 20:51:58 +0000 (09:51 +1300)]
Remove references to deprecated preferred_mail_format in tests

20 months agoMerge pull request #25889 from braders/remove-unused-print-property
Eileen McNaughton [Tue, 21 Mar 2023 19:46:24 +0000 (08:46 +1300)]
Merge pull request #25889 from braders/remove-unused-print-property

[REF][PHP8.2] Remove property which is no longer used

20 months ago[REF][PHP8.2] Remove property which is no longer used
Bradley Taylor [Tue, 21 Mar 2023 18:22:27 +0000 (18:22 +0000)]
[REF][PHP8.2] Remove property which is no longer used

20 months agoRemove 2021 noisily deprecated pdfCommon functions
Eileen McNaughton [Tue, 21 Mar 2023 06:24:24 +0000 (19:24 +1300)]
Remove 2021 noisily deprecated pdfCommon functions

20 months agoMerge pull request #25885 from totten/master-cache-unique
Eileen McNaughton [Tue, 21 Mar 2023 06:15:47 +0000 (19:15 +1300)]
Merge pull request #25885 from totten/master-cache-unique

civicrm_cache - Replace wonky index

20 months agocivicrm_cache - Add index on `expired_date`
Tim Otten [Tue, 21 Mar 2023 04:55:38 +0000 (21:55 -0700)]
civicrm_cache - Add index on `expired_date`

20 months agoUpgrader - Dedupe caches. Failsafe to ensure ugprade runs.
Tim Otten [Tue, 21 Mar 2023 01:49:28 +0000 (18:49 -0700)]
Upgrader - Dedupe caches. Failsafe to ensure ugprade runs.

20 months agocivicrm_cache - Replace wonky idx (group,path,date) with sensible idx (group,path)
Tim Otten [Tue, 21 Mar 2023 00:57:02 +0000 (17:57 -0700)]
civicrm_cache - Replace wonky idx (group,path,date) with sensible idx (group,path)

Note: On the PR, I'll give a more thorough discussion for why the old index seems nonsensical.

20 months agoMerge pull request #25855 from totten/setup-order
Tim Otten [Tue, 21 Mar 2023 03:55:12 +0000 (20:55 -0700)]
Merge pull request #25855 from totten/setup-order

CiviUnitTestCase (etal) - Resolve spooky interaction

20 months agoMerge pull request #25883 from eileenmcnaughton/mail_format
Eileen McNaughton [Tue, 21 Mar 2023 02:12:58 +0000 (15:12 +1300)]
Merge pull request #25883 from eileenmcnaughton/mail_format

Remove preferred_mail_format from tokens

20 months agoMerge pull request #25884 from lemniscus/tagset-markup
Eileen McNaughton [Tue, 21 Mar 2023 01:22:54 +0000 (14:22 +1300)]
Merge pull request #25884 from lemniscus/tagset-markup

don't create tagset markup if there's no tagset

20 months agoRemove preferred_mail_format from tokens
Eileen McNaughton [Tue, 21 Mar 2023 00:01:18 +0000 (13:01 +1300)]
Remove preferred_mail_format from tokens

This also removes the handling from action schedule - there
might be a test checking it's presence to putting up
to adapt tests

20 months agoMerge pull request #25673 from jmcclelland/transaction-lock
Tim Otten [Tue, 21 Mar 2023 00:37:25 +0000 (17:37 -0700)]
Merge pull request #25673 from jmcclelland/transaction-lock

ensure delays from transactions don't cause cache race condition

20 months agoAdd handling of usage to DAO generator
Eileen McNaughton [Mon, 20 Mar 2023 00:07:10 +0000 (13:07 +1300)]
Add handling of usage to DAO generator

20 months agodon't create tagset markup if there's no tagset
Noah Miller [Mon, 20 Mar 2023 23:54:53 +0000 (19:54 -0400)]
don't create tagset markup if there's no tagset

20 months agoMerge pull request #25877 from eileenmcnaughton/submitted
Seamus Lee [Mon, 20 Mar 2023 21:49:45 +0000 (08:49 +1100)]
Merge pull request #25877 from eileenmcnaughton/submitted

Move getSubmittedValues to `CRM_Core_Form`

20 months agoMerge pull request #25882 from lemniscus/tagset-tpl
colemanw [Mon, 20 Mar 2023 20:49:42 +0000 (16:49 -0400)]
Merge pull request #25882 from lemniscus/tagset-tpl

Skip adding script when it won't have anything to run on

20 months agoMerge pull request #25881 from colemanw/dropTable
colemanw [Mon, 20 Mar 2023 19:45:49 +0000 (15:45 -0400)]
Merge pull request #25881 from colemanw/dropTable

SchemaHandler - Add IF EXISTS to dropTable function

20 months agoskip adding script when it won't have anything to run on
Noah Miller [Mon, 20 Mar 2023 18:50:01 +0000 (14:50 -0400)]
skip adding script when it won't have anything to run on

20 months agoSchemaHandler - Add IF EXISTS to dropTable function
Coleman Watts [Mon, 20 Mar 2023 15:57:32 +0000 (11:57 -0400)]
SchemaHandler - Add IF EXISTS to dropTable function

20 months agoMerge pull request #25880 from mattwire/caseactivity
demeritcowboy [Mon, 20 Mar 2023 18:40:44 +0000 (14:40 -0400)]
Merge pull request #25880 from mattwire/caseactivity

Use API4 to create 'Assign Case Role' activity

20 months agoUse API4 to create 'Assign Case Role' activity
Matthew Wire [Wed, 22 Feb 2023 14:49:26 +0000 (14:49 +0000)]
Use API4 to create 'Assign Case Role' activity

20 months agoMerge pull request #25402 from colemanw/deprecatedActions
Matthew Wire [Mon, 20 Mar 2023 13:53:00 +0000 (13:53 +0000)]
Merge pull request #25402 from colemanw/deprecatedActions

APIv4 - Show actions as deprecated in the Explorer

20 months agoMerge pull request #25461 from mattwire/dedupepermission
colemanw [Mon, 20 Mar 2023 13:37:58 +0000 (09:37 -0400)]
Merge pull request #25461 from mattwire/dedupepermission

Afform: Fix dedupe rules for anonymous users

20 months agoMerge pull request #25779 from eileenmcnaughton/unreachable
colemanw [Mon, 20 Mar 2023 13:23:50 +0000 (09:23 -0400)]
Merge pull request #25779 from eileenmcnaughton/unreachable

Add deprecations to unreachable code in previously shared function

20 months agoMerge pull request #25878 from eileenmcnaughton/dep_individual_format
colemanw [Mon, 20 Mar 2023 13:08:03 +0000 (09:08 -0400)]
Merge pull request #25878 from eileenmcnaughton/dep_individual_format

Remove do-nothing noisily deprecated formatting code

20 months agoRemove do-nothing formatting code
Eileen McNaughton [Mon, 20 Mar 2023 06:07:05 +0000 (19:07 +1300)]
Remove do-nothing formatting code

I've been convinced that dates are already handled long before this point
(& loading from the database) so nearly a year ago I added deprecation
notices to fire if this code ever actually did anything. No reports.

It can go:

20 months agoAdd deprecations to unreachable code in previously shared function
Eileen McNaughton [Fri, 10 Mar 2023 00:22:36 +0000 (13:22 +1300)]
Add deprecations to unreachable code in previously shared function

20 months agodev/core#4152 Fix custom data code to not cast to a float
Eileen McNaughton [Mon, 20 Mar 2023 03:45:53 +0000 (16:45 +1300)]
dev/core#4152 Fix custom data code to not cast to a float

begin adding support for locale-formatted number input in custom fields

20 months agoMove getSubmittedValues to CRM_Core_Form
Eileen McNaughton [Mon, 20 Mar 2023 04:17:04 +0000 (17:17 +1300)]
Move getSubmittedValues to CRM_Core_Form

20 months agoMerge pull request #25875 from eileenmcnaughton/php82_report
Seamus Lee [Mon, 20 Mar 2023 02:58:25 +0000 (13:58 +1100)]
Merge pull request #25875 from eileenmcnaughton/php82_report

[PHP8.2] Declare outputHandler property in reports

20 months ago[PHP8.2] Declare outputHandler property
Eileen McNaughton [Mon, 20 Mar 2023 01:29:33 +0000 (14:29 +1300)]
[PHP8.2] Declare outputHandler property

I did a universe search to check private is OK

20 months agoMerge pull request #25872 from totten/master-release-mysqlver
Eileen McNaughton [Mon, 20 Mar 2023 01:13:55 +0000 (14:13 +1300)]
Merge pull request #25872 from totten/master-release-mysqlver

CiviUnitTestCase - Degrade gracefully on older DBMS

20 months agoCiviUnitTestCase - Allow relaxed enforcement on older DBMS
Tim Otten [Sun, 19 Mar 2023 22:52:08 +0000 (15:52 -0700)]
CiviUnitTestCase - Allow relaxed enforcement on older DBMS

20 months agoMerge pull request #25862 from eileenmcnaughton/dedupe_finder2
colemanw [Sun, 19 Mar 2023 22:46:55 +0000 (18:46 -0400)]
Merge pull request #25862 from eileenmcnaughton/dedupe_finder2

Post split code cleanup

20 months agoMerge pull request #25869 from eileenmcnaughton/import_contact_pre
Eileen McNaughton [Sun, 19 Mar 2023 22:05:52 +0000 (11:05 +1300)]
Merge pull request #25869 from eileenmcnaughton/import_contact_pre

[REF] Simplify import preProcess

20 months agoMerge pull request #25868 from eileenmcnaughton/import_switch
Eileen McNaughton [Sun, 19 Mar 2023 22:04:55 +0000 (11:04 +1300)]
Merge pull request #25868 from eileenmcnaughton/import_switch

Switch out the switch

20 months ago[REF] Simplify import preProcess
Eileen McNaughton [Sun, 19 Mar 2023 20:54:15 +0000 (09:54 +1300)]
[REF] Simplify import preProcess

20 months agoRemove require_onces
Eileen McNaughton [Sun, 19 Mar 2023 20:42:24 +0000 (09:42 +1300)]
Remove require_onces

20 months agoSwitch out the switch
Eileen McNaughton [Sun, 19 Mar 2023 00:46:47 +0000 (13:46 +1300)]
Switch out the switch

20 months agoMerge pull request #25866 from eileenmcnaughton/import_contribution_mapfield
colemanw [Sun, 19 Mar 2023 14:39:24 +0000 (10:39 -0400)]
Merge pull request #25866 from eileenmcnaughton/import_contribution_mapfield

[REF] Minor code simplification - extract `getHighlightedFields` in Contribution import `MapField`

20 months agoMerge pull request #25867 from eileenmcnaughton/import_unused
Seamus Lee [Sun, 19 Mar 2023 03:54:37 +0000 (14:54 +1100)]
Merge pull request #25867 from eileenmcnaughton/import_unused

[NFC] Remove some no-longer-used properties on Contribution import parser

20 months agoRemove some no-longer-used properties
Eileen McNaughton [Sun, 19 Mar 2023 00:35:33 +0000 (13:35 +1300)]
Remove some no-longer-used properties

20 months ago[REF] Minor code simplification - extract getHighlightedFields
Eileen McNaughton [Sat, 18 Mar 2023 23:09:57 +0000 (12:09 +1300)]
[REF] Minor code simplification - extract getHighlightedFields

20 months agoMerge pull request #25851 from eileenmcnaughton/pledge
Seamus Lee [Sat, 18 Mar 2023 22:42:46 +0000 (09:42 +1100)]
Merge pull request #25851 from eileenmcnaughton/pledge

dev/core#4079 Add Pledge Tokens

20 months agoRemove fake if
Eileen McNaughton [Sat, 18 Mar 2023 22:15:35 +0000 (11:15 +1300)]
Remove fake if

20 months agoRemove duplicate layer of caching
Eileen McNaughton [Sat, 18 Mar 2023 02:05:21 +0000 (15:05 +1300)]
Remove duplicate layer of caching

This is cached within a cache - the load of calling it is not
especially high and it is somewhat unlikely the cache will be populated
anyway so let's simplfiy...

20 months agoRemove last non-variable variables
Eileen McNaughton [Sat, 18 Mar 2023 01:58:37 +0000 (14:58 +1300)]
Remove last non-variable variables

20 months agoHard-code cacheKey as variables are not variable
Eileen McNaughton [Sat, 18 Mar 2023 01:57:31 +0000 (14:57 +1300)]
Hard-code cacheKey as variables are not variable

20 months agoRemove never-true if
Eileen McNaughton [Sat, 18 Mar 2023 01:55:10 +0000 (14:55 +1300)]
Remove never-true if

isProfile is always false

20 months agoStop adding field just so the calling code can strip them
Eileen McNaughton [Sat, 18 Mar 2023 01:54:13 +0000 (14:54 +1300)]
Stop adding field just so the calling code can strip them

The calling code will not use any field with no WHERE clause

20 months agoRemove handling for no contact type - it is ALWAYS passed in here
Eileen McNaughton [Sat, 18 Mar 2023 01:47:37 +0000 (14:47 +1300)]
Remove handling for no contact type - it is ALWAYS passed in here

20 months agoCopy shared ImportableFields to private function, for unravelling
Eileen McNaughton [Sat, 18 Mar 2023 01:39:07 +0000 (14:39 +1300)]
Copy shared ImportableFields to private function, for unravelling

20 months agoMerge pull request #25854 from eileenmcnaughton/test_tidy
Seamus Lee [Sat, 18 Mar 2023 22:04:02 +0000 (09:04 +1100)]
Merge pull request #25854 from eileenmcnaughton/test_tidy

[NFC] Minor tidy up in `MappingTest`

20 months agoMerge pull request #25852 from eileenmcnaughton/php82_contacttest
Seamus Lee [Sat, 18 Mar 2023 21:03:16 +0000 (08:03 +1100)]
Merge pull request #25852 from eileenmcnaughton/php82_contacttest

[Test][Php8.2] Fix undeclared properties & other housekeeping

20 months agoMerge pull request #25859 from eileenmcnaughton/dedupe_private
colemanw [Sat, 18 Mar 2023 18:49:09 +0000 (14:49 -0400)]
Merge pull request #25859 from eileenmcnaughton/dedupe_private

Make `Finder::tableQuery private`, after universe search

20 months agoMerge pull request #25864 from braders/php8.2-ParticipantPaymentTes
colemanw [Sat, 18 Mar 2023 18:48:06 +0000 (14:48 -0400)]
Merge pull request #25864 from braders/php8.2-ParticipantPaymentTes

[REF][PHP8.2] Refactor api_v3_ParticipantPaymentTest

20 months agoMerge pull request #25865 from braders/php8.2-eventid-property
colemanw [Sat, 18 Mar 2023 18:47:14 +0000 (14:47 -0400)]
Merge pull request #25865 from braders/php8.2-eventid-property

[REF][PHP8.2] Refactor getParticipantOrderParams to never write a dynamic property