Eileen McNaughton [Tue, 5 Sep 2023 04:13:11 +0000 (16:13 +1200)]
Remove unreachable page
I searched the code (including universe) and the UI for how to reach
CRM_Mailing_Page_Preview / civicrm/mailing/preview but could not find it
The alternate CRM_Mailing_Page_View civicrm/mailing/view appears to be
what is used now
colemanw [Tue, 5 Sep 2023 02:17:22 +0000 (22:17 -0400)]
Merge pull request #27300 from eileenmcnaughton/mailing_archive
Unconditionally assign smarty variable
Eileen McNaughton [Tue, 5 Sep 2023 01:44:49 +0000 (13:44 +1200)]
Merge pull request #27302 from colemanw/api4RequiredFix
APIv4 - Fix setting nullable/required/default_value field metadata
colemanw [Tue, 5 Sep 2023 01:44:34 +0000 (21:44 -0400)]
Merge pull request #27204 from eileenmcnaughton/br2nl
Pass html text through a formatter when translating it to tokens
Eileen McNaughton [Tue, 5 Sep 2023 01:07:00 +0000 (13:07 +1200)]
Merge pull request #27268 from colemanw/recontact_interval
CiviCampaign - Refactor civicrm_survey.recontact_interval
Eileen McNaughton [Tue, 5 Sep 2023 01:05:54 +0000 (13:05 +1200)]
Merge pull request #27105 from colemanw/inPlaceEdit
SearchKit - In-place edit without refreshing results
colemanw [Tue, 5 Sep 2023 00:56:17 +0000 (20:56 -0400)]
APIv4 - Fix setting nullable/required/default_value field metadata
colemanw [Tue, 5 Sep 2023 00:46:55 +0000 (20:46 -0400)]
Merge pull request #27301 from eileenmcnaughton/mailing_const
Remove unused CONST
Eileen McNaughton [Tue, 5 Sep 2023 00:00:13 +0000 (12:00 +1200)]
Remove unused CONST
I can't see any evidence flexmailer or anything else still uses it...
Eileen McNaughton [Mon, 4 Sep 2023 23:56:09 +0000 (11:56 +1200)]
Unconditionally assign smarty variable
colemanw [Mon, 4 Sep 2023 22:51:23 +0000 (18:51 -0400)]
Merge pull request #27297 from eileenmcnaughton/colon
Remove, extraneous: punctuation?
Eileen McNaughton [Mon, 4 Sep 2023 22:09:45 +0000 (10:09 +1200)]
Remove, extraneous: punctuation?
Tim Otten [Mon, 4 Sep 2023 21:42:16 +0000 (14:42 -0700)]
Merge pull request #27254 from colemanw/coreManaged
[REF] - Cleanup managed entities to all go through `hook_civicrm_managed` and deprecate unnamed entities
demeritcowboy [Mon, 4 Sep 2023 19:01:37 +0000 (15:01 -0400)]
Merge pull request #27291 from civicrm/5.65
Merge 5.65 to master
colemanw [Mon, 4 Sep 2023 18:00:57 +0000 (14:00 -0400)]
Merge pull request #27211 from colemanw/afformSubmissionLimit
Afform - Allow submissions to be disabled and limited
Kurund Jalmi [Mon, 4 Sep 2023 17:41:35 +0000 (18:41 +0100)]
Merge pull request #27270 from colemanw/fixTabCountFrRlz
SearchKit - Fix assigning searchDisplay tab count
colemanw [Sun, 3 Sep 2023 16:06:35 +0000 (12:06 -0400)]
SearchKit - Fix assigning searchDisplay tab count
Incorectly fixed with https://github.com/civicrm/civicrm-core/pull/23759, this is the correct fix.
Enables assignment of the value (because you can't assign scalar values using one-way binding)
but avoids the $compile:nonassign error by making it optional.
See https://docs.angularjs.org/api/ng/service/#-scope-
colemanw [Mon, 4 Sep 2023 15:55:23 +0000 (11:55 -0400)]
Merge pull request #27290 from kurund/file-type-custom-data-fixes
Fixes for setting defaults for custom data field of type file
colemanw [Mon, 4 Sep 2023 15:22:11 +0000 (11:22 -0400)]
Merge pull request #27283 from eileenmcnaughton/weigh_job
Add weights to scheduled jobs
colemanw [Thu, 31 Aug 2023 02:25:37 +0000 (22:25 -0400)]
Afform - Enforce submission open/closed status
colemanw [Thu, 31 Aug 2023 00:57:21 +0000 (20:57 -0400)]
Afform - Add submit_currently_open calc field
colemanw [Thu, 31 Aug 2023 00:08:23 +0000 (20:08 -0400)]
Afform - Add submission_count and submission_date calc fields
colemanw [Wed, 30 Aug 2023 19:58:35 +0000 (15:58 -0400)]
Afform - Add submit_enabled & submit_limit fields
Fixes BasicGetAction handling of default_value - it should be used to set a default value not a default where clause.
colemanw [Wed, 30 Aug 2023 18:26:35 +0000 (14:26 -0400)]
Afform - Add field titles to metadata
colemanw [Mon, 4 Sep 2023 15:10:25 +0000 (11:10 -0400)]
Merge pull request #27272 from colemanw/afformPermission
Afform - Support multiple permissions in the GUI
Kurund Jalmi [Fri, 25 Aug 2023 09:22:38 +0000 (10:22 +0100)]
Fixes for setting defaults for custom data field of type file
colemanw [Mon, 4 Sep 2023 11:58:01 +0000 (07:58 -0400)]
Merge pull request #27159 from larssandergreen/Fix-event-receipt-regression
Fix incorrect event receipt regression
colemanw [Mon, 4 Sep 2023 11:57:05 +0000 (07:57 -0400)]
Merge pull request #27150 from larssandergreen/Remove-profiles-from-offline-event-receipts
Remove unused profiles from offline event receipts
colemanw [Mon, 4 Sep 2023 11:56:32 +0000 (07:56 -0400)]
Merge pull request #27274 from eileenmcnaughton/gather
Pass specific ids rather than ids array
colemanw [Mon, 4 Sep 2023 11:53:25 +0000 (07:53 -0400)]
Merge pull request #27284 from eileenmcnaughton/weigh_multi
Add weights to links on multipleRecordFieldsListing
colemanw [Mon, 4 Sep 2023 11:52:10 +0000 (07:52 -0400)]
Merge pull request #27285 from eileenmcnaughton/test_nfc
[test] [cleanup] Move _REQUEST cleanup to tearDown
colemanw [Mon, 4 Sep 2023 11:41:53 +0000 (07:41 -0400)]
Merge pull request #27279 from eileenmcnaughton/form_test
Update further tests to additional form flow, lock in bug fix
Seamus Lee [Mon, 4 Sep 2023 07:21:20 +0000 (17:21 +1000)]
Merge pull request #27286 from civicrm/5.65
5.65
Yashodha Chaku [Mon, 4 Sep 2023 06:59:28 +0000 (12:29 +0530)]
Merge pull request #27282 from eileenmcnaughton/wei
Minor cleanup in test
Seamus Lee [Mon, 4 Sep 2023 06:47:29 +0000 (16:47 +1000)]
Merge pull request #27280 from eileenmcnaughton/565
Fix bug exposed by invalid data warning
larssandergreen [Mon, 4 Sep 2023 05:43:04 +0000 (23:43 -0600)]
Fix event receipt regression
larssandergreen [Mon, 4 Sep 2023 05:27:53 +0000 (23:27 -0600)]
Remove unused profiles from offline event receipts
Eileen McNaughton [Thu, 31 Aug 2023 05:50:03 +0000 (17:50 +1200)]
Move _REQUEST cleanup to tearDown
Eileen McNaughton [Thu, 31 Aug 2023 09:03:50 +0000 (21:03 +1200)]
Add weights to links on multipleRecordFieldsListing
Eileen McNaughton [Thu, 31 Aug 2023 11:09:31 +0000 (23:09 +1200)]
Add weights to scheduled jobs
Eileen McNaughton [Thu, 31 Aug 2023 11:19:17 +0000 (23:19 +1200)]
Add weights to event search
Eileen McNaughton [Mon, 4 Sep 2023 00:38:51 +0000 (12:38 +1200)]
Pass specific ids rather than ids array
It is unclear when we pass ids what ids we care about (& in general how many ids we are using from the
various functions). In fact 2 specific IDs are used (one from the _relatedObjects array) so pass
these in and stop passing in ids. Also stop setting an id that we never use
Eileen McNaughton [Wed, 30 Aug 2023 01:31:07 +0000 (13:31 +1200)]
Convert html to text, keeping line breaks, when using html-based tokens
Eileen McNaughton [Mon, 4 Sep 2023 04:12:14 +0000 (16:12 +1200)]
Fix bug exposed by invalid data warning
The invalid data warning exposed a bug where the email
is being sent before the line item has been fixed - so
line item data in the email would be incorrect. This is
not a regression but the potential for someone to
be aware of it is.
Eileen McNaughton [Mon, 4 Sep 2023 03:25:17 +0000 (15:25 +1200)]
Update further tests to additional form flow, lock in bug fix
colemanw [Mon, 4 Sep 2023 03:12:49 +0000 (23:12 -0400)]
Merge pull request #27277 from eileenmcnaughton/form_test
Update one of our complex confirm tests to use full form flow, fix discovered failure to send to additional participants
Eileen McNaughton [Mon, 4 Sep 2023 03:08:55 +0000 (15:08 +1200)]
Merge pull request #27140 from colemanw/groupSelectWhereClause
API - Switched to cached function for looking up pemissioned groups
colemanw [Mon, 4 Sep 2023 02:55:50 +0000 (22:55 -0400)]
Merge pull request #27276 from colemanw/trackingFieldsMsg
Add pre-upgrade message about the removed TrackingFields.tpl
colemanw [Sun, 3 Sep 2023 23:36:16 +0000 (19:36 -0400)]
Afform - Support multiple permissions in the GUI
Eileen McNaughton [Mon, 4 Sep 2023 02:29:35 +0000 (14:29 +1200)]
Merge pull request #26987 from mattwire/lineitem
Fix Financial Items incorrectly recorded when using Payment API
colemanw [Mon, 4 Sep 2023 02:19:38 +0000 (22:19 -0400)]
Merge pull request #27273 from eileenmcnaughton/no_component
Remove some unnecessary variables & pass by ref
Eileen McNaughton [Mon, 4 Sep 2023 02:19:21 +0000 (14:19 +1200)]
Update one of our complex confirm tests to use full form flow, fix discovered additional payments bug
colemanw [Thu, 31 Aug 2023 20:06:11 +0000 (16:06 -0400)]
Add pre-upgrade message about the removed TrackingFields.tpl
Eileen McNaughton [Mon, 4 Sep 2023 01:57:46 +0000 (13:57 +1200)]
Merge pull request #27197 from colemanw/getSqlFunctions
SearchKit - Expose sql functions provided by extensions
Eileen McNaughton [Mon, 4 Sep 2023 01:57:13 +0000 (13:57 +1200)]
Merge pull request #27233 from colemanw/trackingFields
Delete probably-unused TrackingFields.tpl
Eileen McNaughton [Mon, 4 Sep 2023 01:46:20 +0000 (13:46 +1200)]
Merge pull request #27275 from colemanw/isDefined
EntityLookupTrait - Add isDefined and getDefinition methods
colemanw [Mon, 4 Sep 2023 01:05:37 +0000 (21:05 -0400)]
EntityLookupTrait - Add isDefined and getDefinition methods
Eileen McNaughton [Mon, 4 Sep 2023 00:11:19 +0000 (12:11 +1200)]
Remove some unnecessary variables
Eileen McNaughton [Sun, 3 Sep 2023 23:42:44 +0000 (11:42 +1200)]
Merge pull request #27202 from colemanw/searchKitCurrency
SearchKit - Improve handling of money currency
demeritcowboy [Sun, 3 Sep 2023 21:45:51 +0000 (17:45 -0400)]
Merge pull request #27269 from colemanw/undefined
ajax.js - Fix undeclared variable
colemanw [Sun, 3 Sep 2023 18:52:19 +0000 (14:52 -0400)]
Merge pull request #27199 from colemanw/fixSkTotals
SearchKit - Fix broken totals row and query output
colemanw [Sun, 3 Sep 2023 18:51:22 +0000 (14:51 -0400)]
Merge pull request #27267 from eileenmcnaughton/form_test
Add form helper for tests
colemanw [Tue, 29 Aug 2023 18:54:25 +0000 (14:54 -0400)]
SearchKit - Fix broken totals row and query output
This regressed in ef1cbd
colemanw [Sun, 3 Sep 2023 12:22:07 +0000 (08:22 -0400)]
ajax.js - Fix undeclared variable
colemanw [Sun, 3 Sep 2023 02:24:56 +0000 (22:24 -0400)]
CiviCampaign - Move serialized contents of civicrm_survey.recontact_interval into civicrm_option_value.filter
Refactors out a thoroughly strange data structure.
Each option value associated with a survey has an associated recontact_interval, which is an integer
storing the number of days before the respondent should be recontacted.
Before: A serialized array was being stored in the survey with keys matching the option LABEL!
After: There was an unused integer column, civicrm_option_value.filter which works fine for storing
the number directly for each option_value with no messy mapping needed.
Eileen McNaughton [Fri, 1 Sep 2023 07:01:59 +0000 (19:01 +1200)]
Add form helper for tests
colemanw [Sat, 2 Sep 2023 23:23:59 +0000 (19:23 -0400)]
Merge pull request #27262 from colemanw/phpstormApi4
[NFC] PhpStorm - Add more APIv4 function argument hints
Eileen McNaughton [Sat, 2 Sep 2023 23:21:46 +0000 (11:21 +1200)]
Merge pull request #27261 from colemanw/entityLookupId
EntityLookupTrait - Skip queries when looking up id
Seamus Lee [Sat, 2 Sep 2023 22:22:06 +0000 (08:22 +1000)]
Merge pull request #27264 from mlutfy/fixExtLinks
Fix fatal on Manage Extensions caused by financialacls links
demeritcowboy [Sat, 2 Sep 2023 20:36:49 +0000 (16:36 -0400)]
Merge pull request #27263 from colemanw/quicksearchOptions
Menubar Quicksearch - Followup fixes
colemanw [Sat, 2 Sep 2023 20:32:28 +0000 (16:32 -0400)]
Merge pull request #27265 from mlutfy/standaloneLogoutFix
standaloneusers: logout function must be static
Mathieu Lutfy [Sat, 2 Sep 2023 19:52:20 +0000 (15:52 -0400)]
ext/standaloneusers: logout must be static
Mathieu Lu [Sat, 2 Sep 2023 18:02:07 +0000 (14:02 -0400)]
Fix fatal on Manage Extensions caused by financialacls links
colemanw [Sat, 2 Sep 2023 16:41:49 +0000 (12:41 -0400)]
QuickSearch - Fix 'not found' message
colemanw [Sat, 2 Sep 2023 16:36:46 +0000 (12:36 -0400)]
QuickSearch - Avoid using api4 in upgrader
colemanw [Fri, 1 Sep 2023 20:18:39 +0000 (16:18 -0400)]
Managed - Noisily deprecate unnamed managed entities
colemanw [Fri, 1 Sep 2023 20:08:27 +0000 (16:08 -0400)]
Managed - Move component managed entity declarations to component extensions
CRM_Core_Component_Info had a quasi-listener for adding managed entities; it was only used by CiviCase.
This moves it to a real listener in the civi_case extension.
colemanw [Sat, 2 Sep 2023 15:28:53 +0000 (11:28 -0400)]
PhpStorm - Add more APIv4 function argument hints
demeritcowboy [Sat, 2 Sep 2023 14:25:30 +0000 (10:25 -0400)]
Merge pull request #27251 from jmcclelland/petition-double-click
avoid double clicks on petition page
demeritcowboy [Sat, 2 Sep 2023 14:19:42 +0000 (10:19 -0400)]
Merge pull request #27260 from eileenmcnaughton/party
Fix participantTest to not use transactions
colemanw [Sat, 2 Sep 2023 13:33:27 +0000 (09:33 -0400)]
EntityLookupTrait - Skip queries when looking up id
demeritcowboy [Sat, 2 Sep 2023 13:30:59 +0000 (09:30 -0400)]
Merge pull request #26676 from colemanw/getquickGoodbye
Switch menubar search to use APIv4 & delete deprecated v3 'getquick' action
Eileen McNaughton [Sat, 2 Sep 2023 08:24:05 +0000 (20:24 +1200)]
Fix participant test to tolerant strict smarty
Eileen McNaughton [Sat, 2 Sep 2023 08:23:45 +0000 (20:23 +1200)]
Fix Participant test to not use transations
Eileen McNaughton [Sat, 2 Sep 2023 05:02:30 +0000 (17:02 +1200)]
Merge pull request #27257 from colemanw/entityLookup
Add API-based EntityLookupTrait
Eileen McNaughton [Sat, 2 Sep 2023 04:56:00 +0000 (16:56 +1200)]
Merge pull request #27256 from eileenmcnaughton/party
Further fix forms to full form flow
colemanw [Sat, 2 Sep 2023 03:27:23 +0000 (23:27 -0400)]
Add API-based EntityLookupTrait
Eileen McNaughton [Sat, 2 Sep 2023 00:09:57 +0000 (12:09 +1200)]
Further fix forms to full form flow
Eileen McNaughton [Sat, 2 Sep 2023 02:49:16 +0000 (14:49 +1200)]
Merge pull request #27231 from eileenmcnaughton/weight_fin
Add weights to membership type links
Eileen McNaughton [Thu, 31 Aug 2023 11:36:41 +0000 (23:36 +1200)]
Add weights to membership type links
This includes moving the permissioning of those links to the financialacls extension
(since there was already an affected test in that extension too).
colemanw [Fri, 1 Sep 2023 21:01:39 +0000 (17:01 -0400)]
Merge pull request #26841 from colemanw/customAutocompleteUpdate
dev/core#3049 - Update autocomplete custom fields to use APIv4
colemanw [Fri, 1 Sep 2023 18:44:57 +0000 (14:44 -0400)]
Merge pull request #27253 from colemanw/editableEntity
SearchKit - Fix autocomplete filters on in-place-edit fields
colemanw [Sun, 20 Aug 2023 21:14:39 +0000 (17:14 -0400)]
SearchKit - In-place edit without refreshing results
colemanw [Sun, 20 Aug 2023 20:24:16 +0000 (16:24 -0400)]
Update CRM.status for compatability with native js promises
Before: .done() method only works with jQuery object
After: .then() method works with both
colemanw [Fri, 1 Sep 2023 17:43:19 +0000 (13:43 -0400)]
SearchKit - Fix autocomplete filters on in-place-edit fields
colemanw [Fri, 1 Sep 2023 16:45:23 +0000 (12:45 -0400)]
Merge pull request #26993 from eileenmcnaughton/upgrade
Ensure tax_amount is not null
colemanw [Fri, 1 Sep 2023 16:43:42 +0000 (12:43 -0400)]
Merge pull request #27249 from yashodha/report_improvement
Add sorting options on Membership Details report
colemanw [Fri, 1 Sep 2023 16:34:56 +0000 (12:34 -0400)]
dev/core#3049 - Permit custom autocomplete fields on public profile forms
colemanw [Fri, 1 Sep 2023 16:35:57 +0000 (12:35 -0400)]
Merge pull request #27250 from eileenmcnaughton/party
Fix forms to call full form flow
colemanw [Sat, 15 Jul 2023 17:26:38 +0000 (13:26 -0400)]
dev/core#3049 - Update autocomplete custom fields to use APIv4