Matthew Wire [Thu, 5 Mar 2020 22:11:55 +0000 (22:11 +0000)]
Code cleanup in event cart
Matthew Wire [Thu, 5 Mar 2020 18:12:56 +0000 (18:12 +0000)]
Merge pull request #16550 from eileenmcnaughton/display
Remove additional display of buttons for events
Matthew Wire [Thu, 5 Mar 2020 18:11:32 +0000 (18:11 +0000)]
Merge pull request #16625 from seamuslee001/jquery_validation_upgrade
Upgrade jQuery validation version to v1.19.1
Matthew Wire [Thu, 5 Mar 2020 18:09:09 +0000 (18:09 +0000)]
Merge pull request #16688 from eileenmcnaughton/prior
Mark unused function as deprecated
Matthew Wire [Thu, 5 Mar 2020 13:21:22 +0000 (13:21 +0000)]
Merge pull request #14667 from hoegrammer/master
CRM-20553 Stop contact being overwritten with paypal account name
eileen [Thu, 5 Mar 2020 02:23:18 +0000 (15:23 +1300)]
Mark unused function as deprecated
CiviCRM [Thu, 5 Mar 2020 01:50:34 +0000 (01:50 +0000)]
Set version to 5.25.alpha1
CiviCRM [Thu, 5 Mar 2020 01:44:50 +0000 (01:44 +0000)]
Set version to 5.24.beta1
Seamus Lee [Thu, 5 Mar 2020 01:42:39 +0000 (12:42 +1100)]
Merge pull request #16677 from eileenmcnaughton/mem
[REF] Change function signature to support moving this off the form layer
Eileen McNaughton [Thu, 5 Mar 2020 01:41:20 +0000 (14:41 +1300)]
Merge pull request #16666 from colemanw/smarter
APIv4-based smart groups
Eileen McNaughton [Thu, 5 Mar 2020 00:16:19 +0000 (13:16 +1300)]
Merge pull request #16649 from alifrumin/copyState3
dev/core#1605 State/province not copied on shared address
eileen [Tue, 3 Mar 2020 19:54:04 +0000 (08:54 +1300)]
[REF] Change function signature to support moving this off the form layer
This is really a business logic function & belongs on the BAO. This change simply removes the
access to such that it can be moved by making it an input parameter.
Next step would be o make it static & move it to CRM_Member_BAO_Membership
Evenually this should not be called by the form as the CRM_Member_BAO_Membership
::create function will call it
Coleman Watts [Mon, 2 Mar 2020 19:25:23 +0000 (14:25 -0500)]
Fix "no such field" failure in SmartGroup upgrade
Calling api get with no return fields specified is always risky during upgrades because upgrades can add/drop columns.
Coleman Watts [Mon, 2 Mar 2020 02:36:26 +0000 (21:36 -0500)]
APIv4 Explorer - add docs for save & execute buttons
Coleman Watts [Mon, 2 Mar 2020 01:57:25 +0000 (20:57 -0500)]
APIv4-based smart groups
Coleman Watts [Thu, 13 Feb 2020 01:00:37 +0000 (20:00 -0500)]
APIv4 - Add SavedSearch entity
Coleman Watts [Tue, 11 Feb 2020 22:22:42 +0000 (17:22 -0500)]
Add columns for api_entity & api_params to civicrm_saved_search
Eileen McNaughton [Wed, 4 Mar 2020 23:52:39 +0000 (12:52 +1300)]
Merge pull request #16684 from civicrm/5.23
5.23
Eileen McNaughton [Wed, 4 Mar 2020 23:52:18 +0000 (12:52 +1300)]
Merge pull request #16686 from demeritcowboy/install-seqcreditnotes
Fix parameter format for upgrade call to install/enable sequentialcreditnotes
Seamus Lee [Wed, 4 Mar 2020 22:40:18 +0000 (09:40 +1100)]
Merge pull request #16687 from demeritcowboy/letter-h
[NFC] Add missing letter "h" in upgrade script for task description
Seamus Lee [Wed, 4 Mar 2020 22:39:57 +0000 (09:39 +1100)]
Merge pull request #16685 from mlutfy/fixSettingsYesNo
Fix SettingTrait YesNo translation
Eileen McNaughton [Wed, 4 Mar 2020 22:06:34 +0000 (11:06 +1300)]
Merge pull request #16680 from magnolia61/Contribution_Invoice_Enhancements
Style & layout clean up
Seamus Lee [Wed, 4 Mar 2020 21:54:48 +0000 (08:54 +1100)]
Merge pull request #16683 from demeritcowboy/disable-xoauth2
dev/mail#59 - Don't release 5.23 with XOAUTH2 option enabled since it isn't ready yet
demeritcowboy [Wed, 4 Mar 2020 21:19:50 +0000 (16:19 -0500)]
fix parameter format
demeritcowboy [Wed, 4 Mar 2020 21:22:28 +0000 (16:22 -0500)]
add missing letter h
Eileen McNaughton [Wed, 4 Mar 2020 21:05:54 +0000 (10:05 +1300)]
Merge pull request #16020 from mattwire/setentityid
Add setEntityId() to entityForm
Mathieu Lutfy [Wed, 4 Mar 2020 21:01:54 +0000 (16:01 -0500)]
Fix SettingTrait YesNo translation
magnolia61 [Wed, 4 Mar 2020 08:03:25 +0000 (09:03 +0100)]
Style & layout clean up
Eileen McNaughton [Wed, 4 Mar 2020 20:06:13 +0000 (09:06 +1300)]
Merge pull request #16682 from colemanw/remove
Remove deprecated function CRM_Contact_BAO_GroupContactCache::remove
Seamus Lee [Wed, 4 Mar 2020 19:52:23 +0000 (06:52 +1100)]
Update unit test now that the xoauth2 option is disabled for the time being
Seamus Lee [Wed, 4 Mar 2020 19:50:39 +0000 (06:50 +1100)]
Merge pull request #16681 from alifrumin/rn5.23secondpass
rn-5.23: adding late changes to the 5.23 release notes [nfc]
Alice Frumin [Tue, 3 Mar 2020 18:43:12 +0000 (13:43 -0500)]
add test
demeritcowboy [Wed, 4 Mar 2020 17:47:45 +0000 (12:47 -0500)]
xoauth2 isn't ready yet
Coleman Watts [Wed, 4 Mar 2020 17:10:12 +0000 (12:10 -0500)]
Remove deprecated function CRM_Contact_BAO_GroupContactCache::remove
Alice Frumin [Wed, 4 Mar 2020 16:26:37 +0000 (11:26 -0500)]
adding late changes to the 5.23 release notes
Matthew Wire [Wed, 4 Mar 2020 14:52:43 +0000 (14:52 +0000)]
Merge pull request #16675 from christianwach/lab-1628
Fix display of administrator permissions in WordPress Multisite
Christian Wach [Wed, 4 Mar 2020 10:23:01 +0000 (10:23 +0000)]
Fix display of administrator permissions in WordPress Multisite
Eileen McNaughton [Wed, 4 Mar 2020 07:23:44 +0000 (20:23 +1300)]
Merge pull request #16676 from christianwach/lab-1629
Fix synchronisation of Users to Contacts in WordPress Multisite
Seamus Lee [Wed, 4 Mar 2020 06:31:00 +0000 (17:31 +1100)]
Merge pull request #16679 from pradpnayak/priceSetSchema
added sudo constant for sms api type
Pradeep Nayak [Wed, 4 Mar 2020 01:35:48 +0000 (01:35 +0000)]
added sudo constant for sms api type
Christian Wach [Tue, 3 Mar 2020 12:04:25 +0000 (12:04 +0000)]
Fix synchronisation of Users to Contacts in WordPress Multisite
Seamus Lee [Tue, 3 Mar 2020 02:59:34 +0000 (13:59 +1100)]
Merge pull request #16672 from MegaphoneJon/core-1627
Activity Details report: fix filtering by is null/is not null
Jon Goldberg [Mon, 2 Mar 2020 23:43:09 +0000 (18:43 -0500)]
Activity Details report: fix filtering by is null/is not null
colemanw [Mon, 2 Mar 2020 17:30:34 +0000 (12:30 -0500)]
Merge pull request #16667 from eileenmcnaughton/acl
[REF] Only call getACLs when contact_id is present, remove handling
colemanw [Mon, 2 Mar 2020 16:18:26 +0000 (11:18 -0500)]
Merge pull request #16566 from eileenmcnaughton/setting_fix
Remove helper function now that contribution settings is not weirdly stored
colemanw [Mon, 2 Mar 2020 16:13:30 +0000 (11:13 -0500)]
Merge pull request #16647 from JMAConsulting/core-1623
core#1623: My Case dashlet doesn't sort by name but contact_id instead
colemanw [Mon, 2 Mar 2020 16:11:21 +0000 (11:11 -0500)]
Merge pull request #16669 from demeritcowboy/audit-tpl-2
dev/core#1366 - CRM_Case_XMLProcessor_Report::run() is never called anymore
colemanw [Mon, 2 Mar 2020 16:10:14 +0000 (11:10 -0500)]
Merge pull request #16668 from eileenmcnaughton/php
Increase php min recommended version
demeritcowboy [Mon, 2 Mar 2020 06:33:25 +0000 (01:33 -0500)]
remove unused function
Monish Deb [Fri, 28 Feb 2020 09:17:29 +0000 (14:47 +0530)]
core#1623: My Case dashlet doesn't sort by name but contact_id instead
eileen [Mon, 2 Mar 2020 04:01:39 +0000 (17:01 +1300)]
Increase php min recommended version
We seem to not be doing a good job of communicating about dropping php 7.0
but given php 7.1 is now out of support https://www.php.net/supported-versions.php
it seems pretty clear it meets no longer meets the criteria for 'minimum recommended'
https://www.php.net/supported-versions.php
eileen [Sun, 1 Mar 2020 22:50:22 +0000 (11:50 +1300)]
[REF] Only call getACLs when contact_id is present, remove handling
getACLs is called from one place in the code. Within the function there are 2 places that
handle the possibility it might be null - this moves it to the calling function
& requires contact id to be an int
Seamus Lee [Mon, 2 Mar 2020 01:53:01 +0000 (12:53 +1100)]
Merge pull request #16665 from pradpnayak/priceSetSchema
Add pseudoconstant for priceset
Eileen McNaughton [Mon, 2 Mar 2020 01:23:56 +0000 (14:23 +1300)]
Merge pull request #16664 from totten/master-ext-hidden
Extensions - Change new tag "hidden" to "mgmt:hidden"
Eileen McNaughton [Mon, 2 Mar 2020 01:23:03 +0000 (14:23 +1300)]
Merge pull request #16624 from mattwire/tokencompatsubscriber
TokenProcessor - fix greetings tokens
Pradeep Nayak [Mon, 2 Mar 2020 00:23:15 +0000 (00:23 +0000)]
Add pseudoconstant for priceset
Tim Otten [Mon, 2 Mar 2020 00:04:19 +0000 (16:04 -0800)]
Extensions - Change new tag "hidden" to "mgmt:hidden"
Overview
--------
This is follow-up from the discussion about how to name extension tags
https://github.com/civicrm/civicrm-dev-docs/pull/761
It's a follow-up #16531 (dev/financial#84) within the same 5.24.alpha1 dev cycle.
Before
------
The `sequentialcreditnotes` extension is tagged `hidden` and omitted
from display in the web UI.
After
-----
The `sequentialcreditnotes` extension is tagged `mgmt:hidden` and omitted
from display in the web UI.
Seamus Lee [Sun, 1 Mar 2020 23:44:00 +0000 (10:44 +1100)]
Merge pull request #16662 from seamuslee001/tcpdf_depreaction
[REF] Deprecate _html2pdf_tcpdf function in favour of _html2pdf_dompdf
Seamus Lee [Sun, 1 Mar 2020 23:43:54 +0000 (10:43 +1100)]
Merge pull request #16663 from eileenmcnaughton/acl
[REF] Removed unused function
Seamus Lee [Sun, 1 Mar 2020 23:43:37 +0000 (10:43 +1100)]
Merge pull request #16655 from seamuslee001/hook_uf_fields
[Feature] Add in new hook alterUFFields to allow extensions to modify…
Seamus Lee [Sun, 1 Mar 2020 22:33:59 +0000 (09:33 +1100)]
Add in code doucmentation of the format of the fields array and add in a unit test
eileen [Sun, 1 Mar 2020 22:32:31 +0000 (11:32 +1300)]
[REF] Removed unused function
I did some searches - this isn't called
Eileen McNaughton [Sun, 1 Mar 2020 21:45:45 +0000 (10:45 +1300)]
Merge pull request #16660 from demeritcowboy/audit-tpl
dev/core#1366 - Case Audit.tpl file no longer used
Seamus Lee [Sun, 1 Mar 2020 21:39:39 +0000 (08:39 +1100)]
[REF] Deprecate _html2pdf_tcpdf function in favour of _html2pdf_dompdf
Eileen McNaughton [Sun, 1 Mar 2020 20:10:14 +0000 (09:10 +1300)]
Merge pull request #15964 from mlutfy/financial109
dev/financial#109 Fix country/province assignation in the contribution invoice
Seamus Lee [Sun, 1 Mar 2020 03:51:14 +0000 (14:51 +1100)]
Merge pull request #16648 from pradpnayak/priceSetSchema
Add pseudoconstant for priceset
Seamus Lee [Sun, 1 Mar 2020 03:50:53 +0000 (14:50 +1100)]
Merge pull request #16661 from seamuslee001/typo_fix
Fix unreleaesd typo error
Seamus Lee [Sat, 29 Feb 2020 23:59:37 +0000 (10:59 +1100)]
Fix unreleaesd typo error
Seamus Lee [Sat, 29 Feb 2020 23:57:41 +0000 (10:57 +1100)]
Merge pull request #16658 from mattwire/fixtypo
Fix typo (unrelease regression)
Pradeep Nayak [Fri, 28 Feb 2020 12:14:53 +0000 (12:14 +0000)]
Add pseudoconstant for priceset
Mathieu Lutfy [Tue, 26 Nov 2019 15:26:34 +0000 (10:26 -0500)]
dev/financial#109 Fix country/province assignation in the contribution invoice
demeritcowboy [Sat, 29 Feb 2020 15:45:15 +0000 (10:45 -0500)]
remove files no longer used
Matthew Wire [Sat, 29 Feb 2020 14:15:55 +0000 (14:15 +0000)]
Fix typo (unrelease regression)
colemanw [Sat, 29 Feb 2020 13:02:12 +0000 (08:02 -0500)]
Merge pull request #16657 from mattwire/fixcomment
Fix mistake in comment
Matthew Wire [Sat, 29 Feb 2020 11:09:33 +0000 (11:09 +0000)]
Fix mistake in comment
Seamus Lee [Fri, 28 Feb 2020 23:12:05 +0000 (10:12 +1100)]
[Feature] Add in new hook alterUFFields to allow extensions to modify which fields can be added to a profile
Seamus Lee [Fri, 28 Feb 2020 23:07:37 +0000 (10:07 +1100)]
Merge pull request #16652 from UshaMakoa/patch-2
Update contributor-key.yml
Seamus Lee [Fri, 28 Feb 2020 23:07:18 +0000 (10:07 +1100)]
Merge pull request #16653 from seamuslee001/hook_pre_post_uf_field
[REF] Add in pre and post hooks to UFField Entity
Tim Otten [Fri, 28 Feb 2020 22:45:04 +0000 (14:45 -0800)]
Update TokenTest.php
Eileen McNaughton [Fri, 28 Feb 2020 22:16:03 +0000 (11:16 +1300)]
Merge pull request #16644 from seamuslee001/extension_notices
[NFC] Use insert ignore for inserts into civicrm_extension to stop warnings on duplicate entry for sequential credit notes extension
Seamus Lee [Fri, 28 Feb 2020 21:47:22 +0000 (08:47 +1100)]
[REF] Add in pre and post hooks to UFField Entity
Usha Matisson [Fri, 28 Feb 2020 21:11:43 +0000 (22:11 +0100)]
Update contributor-key.yml
Alice Frumin [Fri, 28 Feb 2020 16:06:59 +0000 (11:06 -0500)]
dev/core#1605 State/province not copied on shared address
colemanw [Fri, 28 Feb 2020 14:58:31 +0000 (09:58 -0500)]
Merge pull request #16632 from colemanw/dash
News dashboard - Code cleanup to update js & css
colemanw [Fri, 28 Feb 2020 14:51:38 +0000 (09:51 -0500)]
Merge pull request #16645 from colemanw/null
APIv4 - Correctly return null values from DAO save actions
Matthew Wire [Fri, 28 Feb 2020 11:14:01 +0000 (11:14 +0000)]
Add basic test for TokenCompatSubscriber
Coleman Watts [Fri, 28 Feb 2020 00:45:22 +0000 (19:45 -0500)]
APIv4 - Correctly return null values from DAO save actions
Make sure the value "null" is not returned as a string
Don't return null values from saved DAO objects unless it is in params or reload is set to true
Seamus Lee [Thu, 27 Feb 2020 23:26:27 +0000 (10:26 +1100)]
[NFC] Use insert ignore for inserts into civicrm_extension to stop warnings on duplicate entry for sequential credit notes extension
Seamus Lee [Thu, 27 Feb 2020 23:34:40 +0000 (10:34 +1100)]
Merge pull request #16615 from MegaphoneJon/selfsfc-refactor
[REF] Extract self-service eligibility code into its own function
Eileen McNaughton [Thu, 27 Feb 2020 22:41:49 +0000 (11:41 +1300)]
Merge pull request #16627 from seamuslee001/aug_custom_fields_fix
[REF] Apply fix for CRM-607 for when building the select section of t…
colemanw [Thu, 27 Feb 2020 22:34:05 +0000 (17:34 -0500)]
Merge pull request #16638 from UshaMakoa/patch-1
Contact Type Values with Cap in order to be well translated with ts()
colemanw [Thu, 27 Feb 2020 22:33:47 +0000 (17:33 -0500)]
Merge pull request #16643 from demeritcowboy/activity-summary-groupby
dev/core#1619 - Fatal error when grouping Activity Summary report by activity date
colemanw [Thu, 27 Feb 2020 22:33:26 +0000 (17:33 -0500)]
Merge pull request #16642 from eileenmcnaughton/ss2
[REF] simple function extraction
Eileen McNaughton [Thu, 27 Feb 2020 21:53:32 +0000 (10:53 +1300)]
Merge pull request #16595 from seamuslee001/refactor_payment_processor_radio
[REF] Refactor adding payment processor radio section onto register a…
Eileen McNaughton [Thu, 27 Feb 2020 21:46:54 +0000 (10:46 +1300)]
Merge pull request #16637 from eileenmcnaughton/ss
Remove unused columns from civicrm_saved_search
Eileen McNaughton [Thu, 27 Feb 2020 21:10:12 +0000 (10:10 +1300)]
Merge pull request #16639 from seamuslee001/dev_core_1621
[NFC] dev/core#1621 Extend unit tests to ensure that entity financial account is co…
Eileen McNaughton [Thu, 27 Feb 2020 21:09:01 +0000 (10:09 +1300)]
Merge pull request #16640 from JMAConsulting/dev-core-1158
core#1158: Unit Test to ensure primary addresses are printed on mailing label if searchPrimaryDetailsOnly is disabled
Eileen McNaughton [Thu, 27 Feb 2020 21:05:48 +0000 (10:05 +1300)]
Merge pull request #16641 from colemanw/apiError
Api4 - Display sql errors in explorer
eileen [Thu, 27 Feb 2020 20:49:18 +0000 (09:49 +1300)]
[REF] simple funnction extraction
Jon Goldberg [Fri, 21 Feb 2020 23:17:23 +0000 (18:17 -0500)]
[REF] Extract self-service eligibility code into its own function