Tim Otten [Fri, 17 Mar 2017 23:25:22 +0000 (16:25 -0700)]
CRM-20299 - CiviMail - "Location Type" requirement feels wonky
If you select a "Location Type" and then deselect it, the field changes
to "Automatic". This is the default value (which is acceptable), but the UI
flags it as erroneous.
The "Selection Method" also defaults to "Automatic". These fields are oddly
a bit different (e.g. "Automatic" translates to `location_type_id==null`
and `email_selection_method=automatic`), so the fields are a little
different, but this revision brings them closer.
Tim Otten [Fri, 17 Mar 2017 23:23:36 +0000 (16:23 -0700)]
CRM-20299 - CiviMail UI - Refresh recipient list after changing advanced options
When composing a new mailing, there are advanced options for targetting
recipients by location type (`location_type_id`, `email_selection_method`).
This ensures that the estimate recipient count updates to match the
selection.
colemanw [Thu, 16 Mar 2017 14:02:52 +0000 (10:02 -0400)]
Merge pull request #9802 from eileenmcnaughton/lower
CRM-19980, CRM-19811 - Fix slow queries due to LOWER on contact name…
Eileen McNaughton [Thu, 16 Mar 2017 03:54:34 +0000 (16:54 +1300)]
Merge pull request #9602 from eileenmcnaughton/triggers
CRM-19051 improve respect for the offline trigger setting.
Eileen McNaughton [Wed, 15 Mar 2017 21:09:26 +0000 (10:09 +1300)]
Merge pull request #9998 from eileenmcnaughton/part_fee
CRM-19273 Fix in the usage of insertedLines and added test
Klaas Eikelboom [Tue, 3 Jan 2017 10:50:39 +0000 (05:50 -0500)]
CRM-19273 Fix in the usage of insertedLines and added test
Eileen McNaughton [Wed, 15 Mar 2017 11:08:15 +0000 (00:08 +1300)]
Merge pull request #9983 from JMAConsulting/CRM-19715-3
CRM-19715 (IIDA-96), removed settings related to close accounting period and mo…
Pradeep Nayak [Wed, 15 Mar 2017 06:33:34 +0000 (12:03 +0530)]
CRM-19715, removed settings related to close accounting period and moved to an extension
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
Tim Otten [Wed, 15 Mar 2017 06:30:09 +0000 (23:30 -0700)]
Merge pull request #9982 from totten/master-zetamail
CRM-20270 - composer.lock - Fix multibyte warnings by updating ezcMail
Tim Otten [Tue, 14 Mar 2017 21:06:36 +0000 (14:06 -0700)]
CRM-20270 - composer.lock - Fix multibyte warnings by updating ezcMail
On many systems, the test suite outputs a long message which begins with:
```
PHP Warning: declare(encoding=...) ignored because Zend multibyte feature is turned off by settings in /path/to/sites/all/modules/civicrm/vendor/zetacomponents/mail/src/transports/variable/var_set.php on line 2
```
This patch addresses the warning by updating the version of ezcMail (aka `zetacomponents/mail`). See also:
* https://github.com/civicrm/zetacomponents-mail/pull/1
* http://civicrm.stackexchange.com/questions/16314/does-civicrm-have-a-recommended-setting-for-zend-multibyte
Eileen McNaughton [Tue, 14 Mar 2017 18:30:47 +0000 (07:30 +1300)]
Merge pull request #9940 from colemanw/CRM-20102
CRM-20102 - Case Activity api improvements
Coleman Watts [Tue, 14 Mar 2017 01:27:28 +0000 (21:27 -0400)]
CRM-20102 - make case_type_id required
Yashodha Chaku [Tue, 14 Mar 2017 14:55:54 +0000 (20:25 +0530)]
Merge pull request #9776 from jitendrapurohit/CRM-19741
CRM-19741: Price set and price set value label fields are inconsistan…
Eileen McNaughton [Tue, 14 Mar 2017 08:01:07 +0000 (21:01 +1300)]
Merge pull request #9978 from yashodha/CRM-20255
CRM-20255 - Add developer tabs to more reports
yashodha [Tue, 14 Mar 2017 05:44:45 +0000 (11:14 +0530)]
CRM-20255 - Add developer tabs to more reports
Tim Otten [Tue, 14 Mar 2017 05:09:16 +0000 (22:09 -0700)]
Merge pull request #9420 from eileenmcnaughton/settings
Settings
Coleman Watts [Mon, 13 Mar 2017 13:57:37 +0000 (09:57 -0400)]
Fix double-negative in function signature
Coleman Watts [Mon, 13 Mar 2017 01:59:37 +0000 (21:59 -0400)]
CRM-20102 - Tests
Coleman Watts [Wed, 8 Mar 2017 17:17:23 +0000 (12:17 -0500)]
More efficient loading of case type definition
Don't re-fetch info from the database if we already have it.
Coleman Watts [Wed, 8 Mar 2017 02:15:31 +0000 (21:15 -0500)]
CRM-20102 - Retrieve more case role info from api
Coleman Watts [Tue, 7 Mar 2017 03:49:00 +0000 (22:49 -0500)]
CRM-20102 - Return case_id from activity api
Coleman Watts [Mon, 6 Mar 2017 21:12:19 +0000 (16:12 -0500)]
CRM-20102 - Better filters for case contact_id field
Coleman Watts [Mon, 6 Mar 2017 21:02:46 +0000 (16:02 -0500)]
Use strict type checking in in_array
This php function has a bug where it incorrectly returns true if the first param is 0.
Eileen McNaughton [Tue, 14 Mar 2017 00:30:14 +0000 (13:30 +1300)]
Merge pull request #9966 from eileenmcnaughton/is_recur_template
CRM-20247 Add test & ensure $is_recur is assigned to the message_template.
Tim Otten [Mon, 13 Mar 2017 22:11:03 +0000 (15:11 -0700)]
Merge pull request #9910 from seamuslee001/CRM-19835
CRM-19835 Use host rather than server and put in port if supplied
Tim Otten [Mon, 13 Mar 2017 19:11:51 +0000 (12:11 -0700)]
CRM-19672 - Adapt TokenCompatSubscriber to new getDomain() signature
A recent commit for CRM-19672 changed the signature for `getDomain()`. It
now returns a regular object (not a reference), but this means that you
cannot pass the domain directly through to `replaceDomainTokens()`.
This manifested as a test error when running `flexmailer` on my local PHP
5.6/7.0 system.
Eileen McNaughton [Mon, 13 Mar 2017 09:07:11 +0000 (22:07 +1300)]
Merge pull request #9969 from totten/master-extbatch-cond
Civi\API\ExternalBatch - Improve test for variables_order/$_ENV
Yashodha Chaku [Mon, 13 Mar 2017 08:58:28 +0000 (14:28 +0530)]
Merge pull request #9965 from eileenmcnaughton/activity_report
CRM-20242 - Add developer Tab to Activity Detail report
Tim Otten [Mon, 13 Mar 2017 04:45:00 +0000 (21:45 -0700)]
Civi\API\ExternalBatch - Improve test for variables_order/$_ENV
The recent revision #9595 updated `ExternalBatch` to produce a more
informative error message. However, in the test environment used by
`flexmailer`, there was exactly 1 value in `$_ENV` (even if
`variables_order` was misconfigured).
This should make the test a bit harder to trip-up by affirmatively checking
for the most common environment variable.
Review note: In the known universe, the only direct references to
`ExternalBatch` are in `CiviUnitTestCase`, so this shouldn't impact any
runtime logic.
Eileen McNaughton [Mon, 13 Mar 2017 02:02:47 +0000 (15:02 +1300)]
Merge pull request #9967 from eileenmcnaughton/dummy
CRM-20248 correct hard coded payment processor type id for Dummy proc…
eileen [Sun, 12 Mar 2017 23:00:05 +0000 (12:00 +1300)]
CRM-20248 correct hard coded payment processor type id for Dummy processor
eileen [Sun, 12 Mar 2017 22:48:29 +0000 (11:48 +1300)]
CRM-20247 further removal of ignored is_recur parameter.
This variable was part of a legacy flow via the BaseIPN. Removing the variable is a good tidy up step
eileen [Sun, 12 Mar 2017 21:54:13 +0000 (10:54 +1300)]
CRM-20247 Add test & ensure $is_recur is assigned to the message_template.
eileen [Sun, 12 Mar 2017 21:03:06 +0000 (10:03 +1300)]
Remove deprecated function call from test
Eileen McNaughton [Sun, 12 Mar 2017 02:37:09 +0000 (15:37 +1300)]
Merge pull request #9836 from jmcclelland/CRM-20020
CRM-20020 - fix search with parent groups + other criteria
eileen [Sat, 11 Mar 2017 03:27:12 +0000 (16:27 +1300)]
CRM-20242 - Add developer Tab to Activity Detail report
colemanw [Fri, 10 Mar 2017 22:14:03 +0000 (17:14 -0500)]
Merge pull request #9936 from eileenmcnaughton/sig
CRM-20220 fix signature fields to be longtext
colemanw [Fri, 10 Mar 2017 21:01:35 +0000 (16:01 -0500)]
Update PaymentProcessor.php
colemanw [Fri, 10 Mar 2017 15:12:58 +0000 (10:12 -0500)]
Merge pull request #9963 from kainukempowerment/CRM-20239
CRM-20239 Extra tests for the Individual::format function
Klaas Eikelboom [Fri, 10 Mar 2017 13:15:53 +0000 (14:15 +0100)]
CRM-20239 Extra tests for the CRM_Contact_BAO_Individual::format function
Eileen McNaughton [Fri, 10 Mar 2017 07:46:50 +0000 (20:46 +1300)]
Merge pull request #9815 from WeMoveEU/CRM-19962
CRM-19962 - Wider name field for A/B mailings
Eileen McNaughton [Fri, 10 Mar 2017 07:12:03 +0000 (20:12 +1300)]
Merge pull request #9662 from JMAConsulting/CRM-19792
CRM-19792, fixed payment processor params to include email
Tim Otten [Fri, 10 Mar 2017 06:12:19 +0000 (22:12 -0800)]
Merge pull request #9948 from KarinG/CRM-19966
Fixes for CRM-19966 Unfair Double Taxation and net_amounts.
KarinG [Fri, 10 Mar 2017 03:43:58 +0000 (20:43 -0700)]
Added Test to Create Contribution -> then Edit it via BackOffice form - using default price_set.
eileen [Fri, 10 Mar 2017 03:23:17 +0000 (16:23 +1300)]
CRM-20220 fix signature fields to be longtext
colemanw [Fri, 10 Mar 2017 03:04:44 +0000 (22:04 -0500)]
Merge pull request #9961 from colemanw/Tweak
Tweak icon when expanding popup to fullscreen
Coleman Watts [Fri, 10 Mar 2017 02:47:57 +0000 (21:47 -0500)]
Tweak icon when expanding popup to fullscreen
Eileen McNaughton [Fri, 10 Mar 2017 00:40:26 +0000 (13:40 +1300)]
Merge pull request #9860 from JMAConsulting/CRM-20058
CRM-20058, added submit credit card payment link
Eileen McNaughton [Fri, 10 Mar 2017 00:38:20 +0000 (13:38 +1300)]
Merge pull request #9952 from JMAConsulting/CRM-20025
CRM-20025 [ready for review] Prevented query from fetching contacts without contributions
Tim Otten [Thu, 9 Mar 2017 23:36:35 +0000 (15:36 -0800)]
Merge pull request #9958 from seamuslee001/CRM-20023
CRM-20023 Add test showing passing in just state_province_id and coun…
Seamus Lee [Thu, 9 Mar 2017 22:40:37 +0000 (09:40 +1100)]
Use assertApproxEquals as per Tim's suggestion
Seamus Lee [Thu, 9 Mar 2017 21:17:36 +0000 (08:17 +1100)]
Fix tear down function
Seamus Lee [Thu, 9 Mar 2017 20:44:08 +0000 (07:44 +1100)]
CRM-20023 Add test showing passing in just state_province_id and country only geoloates based on country not state as well
Tim Otten [Thu, 9 Mar 2017 22:28:45 +0000 (14:28 -0800)]
Merge pull request #9959 from seamuslee001/logged_in_user_api_call
(NFC) Update API examples and add example of using user_contact_id as id fo…
Seamus Lee [Thu, 9 Mar 2017 21:40:56 +0000 (08:40 +1100)]
Update API examples and add example of using user_contact_id as id for current logged in user
Eileen McNaughton [Thu, 9 Mar 2017 21:09:13 +0000 (10:09 +1300)]
Merge pull request #9839 from fuzionnz/CRM-20023-geocode_state_province_id
CRM-20023: Do not require state_province value to use state_province_id value.
Eileen McNaughton [Thu, 9 Mar 2017 21:08:00 +0000 (10:08 +1300)]
Merge pull request #9957 from civicrm/4.7.17-rc
4.7.17 rc
Tim Otten [Thu, 9 Mar 2017 20:13:09 +0000 (12:13 -0800)]
Merge pull request #9956 from seamuslee001/master
Update to 4.7.18
Karin Gerritsen [Thu, 9 Mar 2017 16:41:46 +0000 (09:41 -0700)]
Merge pull request #3 from eileenmcnaughton/karing
Resolve immediate issues with test & add checks for mail content (sin…
colemanw [Thu, 9 Mar 2017 15:19:13 +0000 (10:19 -0500)]
Merge pull request #9655 from eileenmcnaughton/activities
CRM-19836 Enable activity create from replies to CiviMail.
Edsel [Thu, 9 Mar 2017 13:59:36 +0000 (19:29 +0530)]
CRM-20025 Added check to restrict test contributions from appearing
----------------------------------------
* CRM-20025: DB Error on email task for advanced search for contributions
https://issues.civicrm.org/jira/browse/CRM-20025
Edsel [Thu, 9 Mar 2017 13:30:47 +0000 (19:00 +0530)]
CRM-20058 Added check for backoffice credit card payment enabled
----------------------------------------
* CRM-20058: Add Credit Card Payment link for partially paid contribution
https://issues.civicrm.org/jira/browse/CRM-20058
Seamus Lee [Thu, 9 Mar 2017 08:08:03 +0000 (19:08 +1100)]
Update to 4.7.18
eileen [Thu, 9 Mar 2017 06:10:01 +0000 (19:10 +1300)]
Resolve immediate issues with test & add checks for mail content (since that function is edited
Eileen McNaughton [Thu, 9 Mar 2017 04:37:51 +0000 (17:37 +1300)]
Merge pull request #9955 from eileenmcnaughton/joe
Towards CRM-19715, Remove Close Accounting Period code
KarinG [Thu, 9 Mar 2017 04:22:40 +0000 (21:22 -0700)]
First pass at PHP Unit test for reSubmit (without priceset).
eileenmcnaugton [Sat, 6 Aug 2016 08:32:34 +0000 (20:32 +1200)]
CRM-19836 Enable activity create from replies to CiviMail.
This relies on a parameter being added to the api call:
civicrm_api3('Job', 'fetch_bounces', array('is_create_activities' => TRUE));
KarinG [Thu, 9 Mar 2017 03:10:17 +0000 (20:10 -0700)]
PHP Unit test fix: net_amount must equal total_amount minus fee_amount.
colemanw [Thu, 9 Mar 2017 03:05:50 +0000 (22:05 -0500)]
Merge pull request #9954 from colemanw/CRM-20235
CRM-20235 - Suppress annoying extension download error messages
eileen [Thu, 9 Mar 2017 02:54:30 +0000 (15:54 +1300)]
Towards CRM-19715, Remove Close Accounting Period code
Remove the Close Accounting Period form. This is a part of #9498 which is stand alone & reduces the of that PR.
There are some things in the PR that need more work, but this part can be done in isolation
colemanw [Thu, 9 Mar 2017 02:55:35 +0000 (21:55 -0500)]
Merge pull request #9769 from scardinius/crm-19958
CRM-19958 Fix invalid name of variable subtype
Coleman Watts [Thu, 9 Mar 2017 02:25:28 +0000 (21:25 -0500)]
CRM-20235 - Don't set status messages from the BAO
This function is already returning error codes. Calling functions ought to take responsibility for reporting the errors.
Eileen McNaughton [Wed, 8 Mar 2017 22:00:50 +0000 (11:00 +1300)]
Merge pull request #8807 from JMAConsulting/CRM-16189-4
[ready-for-review]CRM-16189 (IIDA-16) - Changes to Deferred Revenue report
Jamie McClelland [Wed, 8 Mar 2017 21:29:26 +0000 (16:29 -0500)]
CRM-20020 - ensure search works when both smart and regular groups are used.
Eileen McNaughton [Wed, 8 Mar 2017 21:17:55 +0000 (10:17 +1300)]
Merge pull request #9947 from davidjosephhayes/master
CRM-20232 Fix Relationship (Type) filter on Relationship report template. Any r…
Eileen McNaughton [Wed, 8 Mar 2017 21:15:35 +0000 (10:15 +1300)]
Merge pull request #9946 from lcdservices/CRM-18747
CRM-18747
KarinG [Wed, 8 Mar 2017 20:36:25 +0000 (13:36 -0700)]
Remove php unit test for function that no longer exists.
colemanw [Wed, 8 Mar 2017 16:13:27 +0000 (11:13 -0500)]
Merge pull request #9772 from jitendrapurohit/CRM-4287fix
CRM:4287 - add searchPrimaryDetailsOnly setting
colemanw [Wed, 8 Mar 2017 15:54:07 +0000 (10:54 -0500)]
Merge pull request #9912 from fuzionnz/CRM-20200-editorconfig
[WIP] CRM-20200. Add .editorconfig
colemanw [Wed, 8 Mar 2017 15:52:51 +0000 (10:52 -0500)]
Merge pull request #9951 from JKingsnorth/CRM-19993-4.7.18
CRM-19993 Fixes for ISO compliance with countries and counties
colemanw [Wed, 8 Mar 2017 15:52:32 +0000 (10:52 -0500)]
Merge pull request #9953 from agh1/release-notes-4.7.17-lastminute
Last-minute release note fixes
Andrew Hunt [Wed, 8 Mar 2017 14:58:38 +0000 (09:58 -0500)]
4.7.17 release notes: improve description per @xurizaemon's confusion
Andrew Hunt [Wed, 8 Mar 2017 14:35:51 +0000 (09:35 -0500)]
4.7.17 release notes: Aidan works for Squiffle
Eileen McNaughton [Wed, 8 Mar 2017 11:31:50 +0000 (00:31 +1300)]
Merge pull request #9670 from johanv/CRM-19869-pdf_table_header_issue
Closes CRM-19869 - table layout problem multiple page PDF.
JKingsnorth [Wed, 8 Mar 2017 11:19:39 +0000 (11:19 +0000)]
CRM-19993 Fixes for ISO compliance with countries and counties
Yashodha Chaku [Wed, 8 Mar 2017 10:55:25 +0000 (16:25 +0530)]
Merge pull request #9865 from lcdservices/CRM-20146
CRM-20146 dont hardcode check_number toggle in .tpl
Eileen McNaughton [Wed, 8 Mar 2017 10:33:30 +0000 (23:33 +1300)]
Merge pull request #9907 from eileenmcnaughton/dedupe_code
CRM-20157, CRM-20195 Dedupe code cleanup
Eileen McNaughton [Wed, 8 Mar 2017 10:32:36 +0000 (23:32 +1300)]
Merge pull request #9937 from eileenmcnaughton/kenya
CRM-20062 update Kenyan provinces
Yashodha Chaku [Wed, 8 Mar 2017 09:07:56 +0000 (14:37 +0530)]
Merge pull request #9850 from aydun/CRM-20039
CRM-20039 Add Supplemental Address lines to Advanced Search
Eileen McNaughton [Wed, 8 Mar 2017 08:18:29 +0000 (21:18 +1300)]
Merge pull request #9824 from sunilpawar/CRM-20001
CRM-20001 Tokens in Subject Not replaced
Eileen McNaughton [Wed, 8 Mar 2017 08:15:34 +0000 (21:15 +1300)]
Merge pull request #9072 from jeromelebleu/patch-19386
CRM-19386: Retrieve Activities custom fields in import parser
Eileen McNaughton [Wed, 8 Mar 2017 07:05:10 +0000 (20:05 +1300)]
Merge pull request #9920 from agh1/release-notes-4.7.17
[ready to merge] 4.7.17 release notes
Andrew Hunt [Wed, 8 Mar 2017 06:51:46 +0000 (01:51 -0500)]
4.7.17 release notes: finished descriptions
eileen [Mon, 6 Mar 2017 04:23:10 +0000 (17:23 +1300)]
CRM-20062 upgrade component of Kenyan provinces
eileen [Mon, 6 Mar 2017 04:03:27 +0000 (17:03 +1300)]
CRM-20062 update Kenyan provinces for new installs
KarinG [Wed, 8 Mar 2017 04:37:09 +0000 (21:37 -0700)]
Fixes for CRM-19966 and net_amounts.
David Hayes [Wed, 8 Mar 2017 01:55:21 +0000 (19:55 -0600)]
Fix Relationship (Type) filter on Relationship report template. Any relationship types that were the same bidirectional (eg Sibling of) were completely fitlered out of the list of possibilities on the select box on the filter.
Andrew Hunt [Tue, 7 Mar 2017 23:14:19 +0000 (18:14 -0500)]
4.7.17 release notes: updated raw run
Andrew Hunt [Tue, 7 Mar 2017 23:11:27 +0000 (18:11 -0500)]
4.7.17 release notes: update of remaining contributors
Andrew Hunt [Tue, 7 Mar 2017 22:47:55 +0000 (17:47 -0500)]
4.7.17 release notes: update of some contributors