eileen [Fri, 12 Jun 2020 22:21:57 +0000 (10:21 +1200)]
dev/financial#131 Remove legacy error handling from Paypal code.
https://lab.civicrm.org/dev/financial/-/issues/131
Seamus Lee [Thu, 11 Jun 2020 21:38:10 +0000 (07:38 +1000)]
Merge pull request #17565 from eileenmcnaughton/processor
dev/financial#131 Fix Elavon processor to throw exceptions
Eileen McNaughton [Thu, 11 Jun 2020 21:26:25 +0000 (09:26 +1200)]
Merge pull request #17531 from colemanw/customIcon
Add icons to multi-valued custom groups and display on contact tab
Eileen McNaughton [Thu, 11 Jun 2020 21:25:29 +0000 (09:25 +1200)]
Merge pull request #17576 from colemanw/emptyLeaf
APIv4 - Skip empty leaves in WHERE clause
colemanw [Thu, 11 Jun 2020 17:34:50 +0000 (13:34 -0400)]
Merge pull request #17578 from yashodha/dev_1787
(dev/core#1787) Regression : File fields export results in DB error
yashodha [Thu, 11 Jun 2020 14:09:19 +0000 (19:39 +0530)]
(dev/core#1787) Regression : File fields export results in DB error
Seamus Lee [Thu, 11 Jun 2020 06:46:27 +0000 (16:46 +1000)]
Merge pull request #17573 from seamuslee001/incorrect_use_array_key_exists
[REF] Replace incorrect usages of array_key_exists when the variable …
Seamus Lee [Wed, 10 Jun 2020 22:39:44 +0000 (08:39 +1000)]
[REF] Replace incorrect usages of array_key_exists when the variable is not an array with property_exists and also fix the parameter order for an implode statement
Seamus Lee [Thu, 11 Jun 2020 03:05:52 +0000 (13:05 +1000)]
Merge pull request #15796 from seamuslee001/dev_core_183_requirements
dev/core#183 Use CRM_Utils_SQL_TempTable for generating temp table na…
Coleman Watts [Thu, 11 Jun 2020 00:41:51 +0000 (20:41 -0400)]
APIv4 - Skip empty leaves in WHERE clause
Fixes an annoying problem with search builder
where the api gives a sql error while building your where clause.
The solution is to skip empty leaves, treating them as WIP.
Seamus Lee [Thu, 11 Jun 2020 00:29:28 +0000 (10:29 +1000)]
Merge pull request #17574 from seamuslee001/string_offsets_curly
[REF] Using {} to access string or array offsets has been deprecated …
Seamus Lee [Thu, 11 Jun 2020 00:26:52 +0000 (10:26 +1000)]
Merge pull request #17440 from eileenmcnaughton/log_summ
dev/core#1749 Fix missing parameter in link to logging detail
Eileen McNaughton [Thu, 11 Jun 2020 00:18:34 +0000 (12:18 +1200)]
Merge pull request #15422 from artfulrobot/queue-parallel
Include a new SqlParallel queue type that enables multiple queue runners to process in parallel
Seamus Lee [Wed, 10 Jun 2020 23:55:52 +0000 (09:55 +1000)]
Merge pull request #17575 from seamuslee001/php74_deprecations
[REF] Using ternary operation without nesting is deprecated and also …
Seamus Lee [Wed, 10 Jun 2020 22:46:07 +0000 (08:46 +1000)]
Merge pull request #17570 from seamuslee001/conact_type_populated
[REF] Add in upgrade step to populate missing contact_type.name field
Seamus Lee [Wed, 10 Jun 2020 22:45:53 +0000 (08:45 +1000)]
[REF] Using ternary operation without nesting is deprecated and also using methods and properly instanciate the CiviCase Info object in test
Seamus Lee [Wed, 10 Jun 2020 22:40:26 +0000 (08:40 +1000)]
[REF] Using {} to access string or array offsets has been deprecated in PHP7.4
Seamus Lee [Wed, 10 Jun 2020 11:07:08 +0000 (21:07 +1000)]
[REF] Add in upgrade step to populate missing contact_type.name field
Make changes to the other columns
Seamus Lee [Wed, 10 Jun 2020 21:05:34 +0000 (07:05 +1000)]
Merge pull request #17571 from jitendrapurohit/core-1809
dev/core#1809 - Add start/end adjustment columns to membership status…
Jitendra Purohit [Wed, 10 Jun 2020 11:58:35 +0000 (17:28 +0530)]
dev/core#1809 - Add start/end adjustment columns to membership status page
Seamus Lee [Wed, 10 Jun 2020 05:43:13 +0000 (15:43 +1000)]
Merge pull request #17548 from eileenmcnaughton/contacttype
Set ContactType.name as required in the schema.
Eileen McNaughton [Wed, 10 Jun 2020 03:25:29 +0000 (15:25 +1200)]
Merge pull request #17566 from eileenmcnaughton/dupe1
[NFC] Minor code cleanup
eileen [Mon, 8 Jun 2020 04:50:49 +0000 (16:50 +1200)]
Set ContactType.name as required in the schema.
I came across this weird WHERE clause & I'm pretty sure it's compensating for a mistake in the schema
I also set what I think are sensible defaults on is_reserved & is_active
eileen [Wed, 10 Jun 2020 01:32:15 +0000 (13:32 +1200)]
dev/financial#131 Fix Elavon processor to throw exceptions
In line with our goal of modelling 'good behaviour' in core processors
eileen [Wed, 10 Jun 2020 02:00:01 +0000 (14:00 +1200)]
[NFC] Minor code cleanup
Seamus Lee [Tue, 9 Jun 2020 12:03:12 +0000 (22:03 +1000)]
Merge pull request #17525 from mattwire/baseipnremovebillingid
Remove deprecated billingID from baseIPN
Seamus Lee [Tue, 9 Jun 2020 12:02:59 +0000 (22:02 +1000)]
Merge pull request #17556 from eileenmcnaughton/renewline
[Ref] Remove never reachable lines.
Matthew Wire [Sat, 6 Jun 2020 14:30:11 +0000 (15:30 +0100)]
Remove deprecated billingID from baseIPN
Seamus Lee [Tue, 9 Jun 2020 03:34:05 +0000 (13:34 +1000)]
Merge pull request #17559 from eileenmcnaughton/realex
dev/financial#131 Fix Realex processor to correctly throw an exception
Seamus Lee [Tue, 9 Jun 2020 01:30:41 +0000 (11:30 +1000)]
Merge pull request #17557 from ngo360/master
dev/core#1801 Fix hardcoded activity priority by label
eileen [Tue, 9 Jun 2020 01:16:55 +0000 (13:16 +1200)]
dev/financial#131 Fix Realex processor to correctly throw an exception
Seamus Lee [Tue, 9 Jun 2020 00:29:18 +0000 (10:29 +1000)]
Merge pull request #17515 from seamuslee001/replace_legacy_rebuild_module_data
[REF] Replace the deprecated system_rebuild_module_data function with…
Seamus Lee [Mon, 8 Jun 2020 23:22:21 +0000 (09:22 +1000)]
Merge pull request #17555 from seamuslee001/dev_core_560_deprecated_function_warning
dev/core#560 Add in deprecated function warning now that fatal is dep…
marcineqpol [Mon, 8 Jun 2020 22:26:13 +0000 (00:26 +0200)]
dev/core#1801 Fix hardcoded activity priority
Seamus Lee [Mon, 8 Jun 2020 22:18:36 +0000 (08:18 +1000)]
Merge pull request #17450 from mattwire/activitydefaults
dev/core#1782 Set activity_date_time and created_date to default to current_timestamp
eileen [Fri, 5 Jun 2020 05:40:09 +0000 (17:40 +1200)]
[Ref] Remove never reachable lines.
There is an early return on so updateStatusId can never be true
Seamus Lee [Mon, 8 Jun 2020 21:52:42 +0000 (07:52 +1000)]
Merge pull request #17501 from eileenmcnaughton/guzzle3
[Ref] Convert Authorize.net doDirectPayment to use guzzle & add test
Eileen McNaughton [Mon, 8 Jun 2020 21:48:27 +0000 (09:48 +1200)]
Merge pull request #17554 from alifrumin/entryFoundFlag
Fix "Undefined variable: entryFound" notice on Bookkeeping report
Eileen McNaughton [Mon, 8 Jun 2020 21:45:57 +0000 (09:45 +1200)]
Merge pull request #17506 from mattwire/propertybagremovewarning
Payment Propertybag remove warning
Seamus Lee [Mon, 8 Jun 2020 21:21:00 +0000 (07:21 +1000)]
dev/core#560 Add in deprecated function warning now that fatal is deprecated
Seamus Lee [Fri, 5 Jun 2020 23:11:13 +0000 (09:11 +1000)]
[REF] Replace the deprecated system_rebuild_module_data function with equivilant extension.list.module service function calls to be Drupal 9 compatiable
Eileen McNaughton [Mon, 8 Jun 2020 20:41:18 +0000 (08:41 +1200)]
Merge pull request #17552 from mattwire/deprecatedfunctionwarning
Support passing old method name into deprecatedFunctionWarning
Alice Frumin [Mon, 8 Jun 2020 20:04:32 +0000 (16:04 -0400)]
set flag
Eileen McNaughton [Mon, 8 Jun 2020 19:33:14 +0000 (07:33 +1200)]
Merge pull request #17553 from semseysandor/semseysandor-contributor
Update contributor-key.yml
Sandor Semsey [Mon, 8 Jun 2020 15:14:28 +0000 (17:14 +0200)]
Update contributor-key.yml
Eileen McNaughton [Mon, 8 Jun 2020 12:35:44 +0000 (00:35 +1200)]
Merge pull request #17550 from eileenmcnaughton/request
Remove last instance of CRM_Core_Error::fatal....
Eileen McNaughton [Mon, 8 Jun 2020 12:26:23 +0000 (00:26 +1200)]
Merge pull request #16610 from mattwire/settingstrait_datepicker
Allow adding datepicker to metadata based settings pages
Matthew Wire [Mon, 8 Jun 2020 11:49:30 +0000 (12:49 +0100)]
Support passing old method name into deprecatedFunctionWarning
eileen [Mon, 8 Jun 2020 05:17:50 +0000 (17:17 +1200)]
Remove last instance of CRM_Core_Error::fatal....
Eileen McNaughton [Mon, 8 Jun 2020 11:24:07 +0000 (23:24 +1200)]
Merge pull request #16514 from mattwire/phpnotice_ccparams
Fix PHP notice when we don't have credit card params
Matthew Wire [Mon, 1 Jun 2020 12:19:41 +0000 (13:19 +0100)]
Set activity_date_time and created_date to default to current_timestamp
Eileen McNaughton [Mon, 8 Jun 2020 11:12:13 +0000 (23:12 +1200)]
Merge pull request #17374 from totten/master-setlocale
CRM_Core_I18n::setLocale() - Fix bug with repeated usage
Eileen McNaughton [Mon, 8 Jun 2020 11:05:22 +0000 (23:05 +1200)]
Merge pull request #17179 from mattwire/addpaymentprocessortorecurlist
Add payment processor to details on list of recurring contributions
Eileen McNaughton [Mon, 8 Jun 2020 10:47:03 +0000 (22:47 +1200)]
Merge pull request #17512 from semseysandor/relative-date-filter
dev/core#1798 - "End of yesterday" Relative Date Filter
Eileen McNaughton [Mon, 8 Jun 2020 10:46:37 +0000 (22:46 +1200)]
Merge pull request #17523 from mattwire/customsearchzipcode
Zip code range search only supports numeric zip codes
Matthew Wire [Wed, 12 Feb 2020 15:26:37 +0000 (15:26 +0000)]
Fix PHP notice when we don't have credit card params
Seamus Lee [Mon, 8 Jun 2020 08:52:31 +0000 (18:52 +1000)]
Merge pull request #17549 from eileenmcnaughton/friend
[Ref] Remove another instance of fatal()
Seamus Lee [Mon, 8 Jun 2020 06:33:15 +0000 (16:33 +1000)]
Merge pull request #17543 from eileenmcnaughton/dummy
[Ref] Readability extraction in Dummy class
Seamus Lee [Mon, 8 Jun 2020 06:32:55 +0000 (16:32 +1000)]
Merge pull request #17546 from eileenmcnaughton/validate2
Remove isThrowException from CRM_Utils_Type::validate() signature
eileen [Mon, 8 Jun 2020 05:03:38 +0000 (17:03 +1200)]
[Ref] Remove another instance of fatal()
eileen [Mon, 8 Jun 2020 00:33:04 +0000 (12:33 +1200)]
[Ref] Readability extraction in Dummy class
Seamus Lee [Mon, 8 Jun 2020 04:37:31 +0000 (14:37 +1000)]
Merge pull request #17545 from seamuslee001/dev_core_560_fin
dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or …
eileen [Mon, 8 Jun 2020 01:21:14 +0000 (13:21 +1200)]
Remove isThrowException from CRM_Utils_Type::validate() signature
There are no instances in core where FALSE is passed
Seamus Lee [Mon, 8 Jun 2020 04:30:36 +0000 (14:30 +1000)]
Merge pull request #17544 from eileenmcnaughton/validate
Fix validateAll to no longer support unused abort param
Seamus Lee [Mon, 8 Jun 2020 01:13:26 +0000 (11:13 +1000)]
dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or Exceptions
Seamus Lee [Mon, 8 Jun 2020 02:48:30 +0000 (12:48 +1000)]
Merge pull request #17542 from eileenmcnaughton/pay_error
dev/financial#131 Fix Eway processor to throw exceptions rather than return errors
Seamus Lee [Mon, 8 Jun 2020 02:47:43 +0000 (12:47 +1000)]
Merge pull request #17533 from eileenmcnaughton/fatal
[REF] Replace some instances of fatal with thrown exceptions.
Eileen McNaughton [Mon, 8 Jun 2020 01:59:33 +0000 (13:59 +1200)]
Merge pull request #17540 from colemanw/getActionsPerm
APIv4 - filter getActions results based on user permissions
Seamus Lee [Mon, 8 Jun 2020 01:57:13 +0000 (11:57 +1000)]
Merge pull request #17491 from eileenmcnaughton/toemail
[Ref] Simplify the replacing of the email with the email from the url
Seamus Lee [Mon, 8 Jun 2020 01:54:11 +0000 (11:54 +1000)]
Merge pull request #17500 from eileenmcnaughton/renew_can
[Ref] Throw exceptions from Authorize.net rather than return errors
Seamus Lee [Mon, 8 Jun 2020 01:50:20 +0000 (11:50 +1000)]
Merge pull request #17499 from eileenmcnaughton/unhandled
[Ref] Remove calls to, and deprecate, unhandled function
Seamus Lee [Mon, 8 Jun 2020 01:49:37 +0000 (11:49 +1000)]
Merge pull request #17504 from eileenmcnaughton/renewd
[REF] Remove handling for 2 fields not on the form
eileen [Mon, 8 Jun 2020 01:11:02 +0000 (13:11 +1200)]
Fix validateAll to no longer support unused abort param
Default of TRUE is good here
Seamus Lee [Mon, 8 Jun 2020 00:53:13 +0000 (10:53 +1000)]
Merge pull request #17539 from eileenmcnaughton/fatal2
Replace calls to fatal with statusBounces
eileen [Mon, 8 Jun 2020 00:12:04 +0000 (12:12 +1200)]
dev/financial#131 Fix Eway processor to throw exceptions rather than return errors
This is part of a push to model the correct behaviour in processors we can alter. This is safe as CRM_Core_Payment
already converts these
eileen [Sun, 7 Jun 2020 04:59:24 +0000 (16:59 +1200)]
[REF] Replace some instances of fatal with thrown exceptions.
This is ongoing cleanup to consisently throw execptions. The only thing notable is in the OG class where
it turned out the exception was thrown if a never-passed-in-parameter was passed in, so I removed the
construct
Seamus Lee [Mon, 8 Jun 2020 00:39:39 +0000 (10:39 +1000)]
Merge pull request #17541 from seamuslee001/dev_core_560_third_to_last
dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions…
Seamus Lee [Sun, 7 Jun 2020 23:33:47 +0000 (09:33 +1000)]
dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions or status bounces as appropriate
Coleman Watts [Sun, 7 Jun 2020 23:11:46 +0000 (19:11 -0400)]
APIv4 - filter getActions results based on user permissions
eileen [Sun, 7 Jun 2020 23:11:38 +0000 (11:11 +1200)]
Replace calls to fatal with statusBounces
Eileen McNaughton [Sun, 7 Jun 2020 22:56:28 +0000 (10:56 +1200)]
Merge pull request #17511 from mattwire/paymentprocessoraddfrontendfunctions
Add isBackOffice, isPayLater, getPaymentMode helpers to frontendpaymentformtrait
Eileen McNaughton [Sun, 7 Jun 2020 22:53:04 +0000 (10:53 +1200)]
Merge pull request #17534 from eileenmcnaughton/fatal2
Remove instances of fatal from upgrade folder
Sandor Semsey [Sun, 7 Jun 2020 19:14:58 +0000 (21:14 +0200)]
Earlier.day test
Seamus Lee [Sun, 7 Jun 2020 10:55:33 +0000 (20:55 +1000)]
Merge pull request #17535 from eileenmcnaughton/gone
Remove unused deprecated class
Seamus Lee [Sun, 7 Jun 2020 10:55:13 +0000 (20:55 +1000)]
Merge pull request #17528 from seamuslee001/nfv_apiv3_mem_type_apiv4_test
[NFC] Update existing APIv3 MembershipType Tests to also test against…
Seamus Lee [Sun, 7 Jun 2020 10:50:44 +0000 (20:50 +1000)]
Merge pull request #17536 from eileenmcnaughton/fatal3
[Ref] Remove some instances of fatal in BAO classes
Seamus Lee [Sun, 7 Jun 2020 09:43:24 +0000 (19:43 +1000)]
Merge pull request #17538 from civicrm/5.27
5.27
Seamus Lee [Sun, 7 Jun 2020 06:27:23 +0000 (16:27 +1000)]
Merge pull request #17502 from eileenmcnaughton/first
Fix probably-unused core payment processors to throw extensions
Seamus Lee [Sun, 7 Jun 2020 06:12:20 +0000 (16:12 +1000)]
Merge pull request #17532 from totten/5.27-queue-test
QueueTest - Be more forgiving about slow execution
Eileen McNaughton [Sun, 7 Jun 2020 05:44:45 +0000 (17:44 +1200)]
Merge pull request #17510 from mattwire/paymentprocessorinstrumentnotrequired
Payment instrument ID is not required at processorform level
eileen [Sun, 7 Jun 2020 05:24:03 +0000 (17:24 +1200)]
[Ref] Remove some instances of fatal in BAO classes
eileen [Sun, 7 Jun 2020 05:10:30 +0000 (17:10 +1200)]
Remove unused deprecated class
eileen [Sun, 7 Jun 2020 05:06:38 +0000 (17:06 +1200)]
Remove instances of fatal from upgrade folder
Tim Otten [Sun, 7 Jun 2020 04:29:17 +0000 (21:29 -0700)]
QueueTest - Be more forgiving about slow execution
The `CRM_Queue_QueueTest` is producing failures with the
[TIME_FUNC](https://github.com/civicrm/civicrm-core/pull/17414) option of
`linear:500` (the value currently used in PR test runs) -- which is to say,
it fails when the system runs very slowly (with some 500ms stalling during
execution).
This gets it working under some very slow scenarios:
```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
export TIME_FUNC;
echo;
echo "TIME_FUNC=$TIME_FUNC" ;
env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Queue/QueueTest.php ;
done
```
Seamus Lee [Sun, 7 Jun 2020 03:51:35 +0000 (13:51 +1000)]
Merge pull request #17530 from civicrm/5.27
5.27
Coleman Watts [Sun, 7 Jun 2020 02:07:23 +0000 (22:07 -0400)]
Add icons to multi-valued custom groups and display on contact tab
Seamus Lee [Sun, 7 Jun 2020 02:04:26 +0000 (12:04 +1000)]
Merge pull request #17527 from colemanw/nameAndIcon
Add titles and icons to entities
Seamus Lee [Sun, 7 Jun 2020 02:01:55 +0000 (12:01 +1000)]
Merge pull request #17360 from totten/master-wp-var
WP - Change definitions of `cms.root`, `civicrm.root`
Seamus Lee [Sun, 7 Jun 2020 01:01:04 +0000 (11:01 +1000)]
Merge pull request #17529 from totten/5.27-comm-msg
CommunityMessages - Define more consistent behavior in the face of slow execution
Tim Otten [Sat, 6 Jun 2020 22:21:01 +0000 (15:21 -0700)]
CommunityMessages - Define more consistent behavior in the face of slow execution
This passes under some brutally slow scenarios:
```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
export TIME_FUNC;
echo;
echo "TIME_FUNC=$TIME_FUNC" ;
env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Core/CommunityMessagesTest.php ;
done
```