Jon Goldberg [Sat, 29 Aug 2020 15:48:11 +0000 (11:48 -0400)]
Clean money for non-deductible amount
tests
Eileen McNaughton [Mon, 31 Aug 2020 06:38:07 +0000 (18:38 +1200)]
Merge pull request #18288 from KarinG/extend_testSubmitContributionPageWithPriceSetQuantity
extend_testSubmitContributionPageWithPriceSetQuantity
Eileen McNaughton [Mon, 31 Aug 2020 02:26:26 +0000 (14:26 +1200)]
Merge pull request #18283 from aydun/class_api_tweak
Improve robustness of api/class.api.php
KarinG [Mon, 31 Aug 2020 01:01:41 +0000 (19:01 -0600)]
extend_testSubmitContributionPageWithPriceSetQuantity
Eileen McNaughton [Sun, 30 Aug 2020 23:12:13 +0000 (11:12 +1200)]
Merge pull request #18289 from MegaphoneJon/actionschedule-serialize
add serialize data to actionschedule
Eileen McNaughton [Sun, 30 Aug 2020 22:27:13 +0000 (10:27 +1200)]
Merge pull request #18285 from colemanw/contains
dev/event#37 Add CONTAINS operator for APIv4 & Search
Jon Goldberg [Sun, 30 Aug 2020 20:58:32 +0000 (16:58 -0400)]
add serialize data to actionschedule
Seamus Lee [Sun, 30 Aug 2020 20:08:22 +0000 (06:08 +1000)]
Merge pull request #17991 from eileenmcnaughton/merge_single
[REF] Extract function to get locations to merge, rename 'operation' …
Coleman Watts [Sat, 29 Aug 2020 23:19:06 +0000 (19:19 -0400)]
Search ext - Show translated labels for operators
Eileen McNaughton [Sat, 29 Aug 2020 01:08:56 +0000 (13:08 +1200)]
Merge pull request #18275 from eileenmcnaughton/linepre
dev/core#1980 Move (now tested) delete acl check from v3 api to pre delete hook
Coleman Watts [Sat, 29 Aug 2020 00:56:16 +0000 (20:56 -0400)]
APIv4 - Add CONTAINS operator and add to search extension
eileen [Fri, 28 Aug 2020 04:08:56 +0000 (16:08 +1200)]
Move (now tested) delete acl check from v3 api to pre delete hook
Eileen McNaughton [Fri, 28 Aug 2020 22:15:52 +0000 (10:15 +1200)]
Merge pull request #18280 from yashodha/drop_tables
remove dropped tables for activity target and assignment
Coleman Watts [Fri, 28 Aug 2020 17:07:08 +0000 (13:07 -0400)]
APIv4 - Move list of accepted query operators to CoreUtil
Aidan Saunders [Fri, 28 Aug 2020 14:45:59 +0000 (15:45 +0100)]
Use !empty() instead of isset() in constructor so that empty strings don't confuse the logic
Update array syntax in comments
Add test for class.api.php
yashodha [Fri, 28 Aug 2020 11:43:56 +0000 (17:13 +0530)]
remove dropped tables for activity target and assignment
Seamus Lee [Fri, 28 Aug 2020 11:05:52 +0000 (21:05 +1000)]
Merge pull request #18274 from eileenmcnaughton/linetests
Add line item acl tests
Seamus Lee [Fri, 28 Aug 2020 08:21:58 +0000 (18:21 +1000)]
Merge pull request #18276 from civicrm/5.29
5.29
Seamus Lee [Fri, 28 Aug 2020 08:21:05 +0000 (18:21 +1000)]
Merge pull request #18268 from sunilpawar/report_47
report#47 Report Bookkeeping add time field for date filter.
eileen [Fri, 28 Aug 2020 03:49:22 +0000 (15:49 +1200)]
Add line item acl tests
Seamus Lee [Fri, 28 Aug 2020 05:11:11 +0000 (15:11 +1000)]
Merge pull request #18273 from seamuslee001/master
Fix regen and update civicrm_generated
Seamus Lee [Fri, 28 Aug 2020 05:06:55 +0000 (15:06 +1000)]
Merge pull request #18271 from eileenmcnaughton/tax529
dev/core#1972 Fix tax_amount calclation on renewal form
Eileen McNaughton [Fri, 28 Aug 2020 04:19:15 +0000 (16:19 +1200)]
Merge pull request #18270 from seamuslee001/auto_dsn
[REF] Move Auto DSN Switching into a core function
Sunil Pawar [Fri, 28 Aug 2020 04:08:52 +0000 (09:38 +0530)]
added custom clause under whereClause and removed where function from bookkeeping, re-added receipt_date
Seamus Lee [Fri, 28 Aug 2020 02:44:15 +0000 (12:44 +1000)]
Fix regen and update civicrm_generated
Eileen McNaughton [Fri, 28 Aug 2020 02:32:00 +0000 (14:32 +1200)]
Merge pull request #18269 from eileenmcnaughton/finacl
Shell Financial ACLs extension
eileen [Fri, 28 Aug 2020 00:52:42 +0000 (12:52 +1200)]
dev/core#1972 Fix tax_amount calclation on renewal form
Seamus Lee [Thu, 27 Aug 2020 23:59:22 +0000 (09:59 +1000)]
[REF] Move Auto DSN Switching into a core function
eileen [Thu, 27 Aug 2020 22:49:32 +0000 (10:49 +1200)]
Shell Financial ACLs extension
This is intended as a hidden extension while we work through the process of migrating core functionality into it.
I'm expected there to be a bit of work to unravel this into hook interactions - but the core extension mechanism gives us that space
Sunil Pawar [Thu, 27 Aug 2020 17:14:31 +0000 (22:44 +0530)]
report#47 Report Bookkeeping add time field for date filter.
Eileen McNaughton [Thu, 27 Aug 2020 09:14:10 +0000 (21:14 +1200)]
Merge pull request #18266 from sunilpawar/dev_912
dev/core#912 update payment instrument of main contribution record
Matthew Wire [Thu, 27 Aug 2020 08:32:53 +0000 (09:32 +0100)]
Merge pull request #18265 from eileenmcnaughton/objects
Use already determined value for contributionRecurID
Eileen McNaughton [Thu, 27 Aug 2020 07:36:22 +0000 (19:36 +1200)]
Merge pull request #18107 from demeritcowboy/mysql-ssl-install
dev/core#1926 - Allow SSL mysql connections for civicrm-setup
Sunil Pawar [Thu, 27 Aug 2020 06:57:51 +0000 (12:27 +0530)]
fix test case warning
Sunil Pawar [Thu, 27 Aug 2020 06:29:54 +0000 (11:59 +0530)]
Remove additional line
Sunil Pawar [Thu, 27 Aug 2020 06:26:25 +0000 (11:56 +0530)]
dev/core#912 update payment instrument of main contribution record
Eileen McNaughton [Thu, 27 Aug 2020 04:52:39 +0000 (16:52 +1200)]
Merge pull request #18244 from colemanw/drop
Remove old dropped items from the schema xml
eileen [Wed, 26 Aug 2020 22:05:04 +0000 (10:05 +1200)]
Use already detemined value for contributionRecurid
Eileen McNaughton [Wed, 26 Aug 2020 21:38:42 +0000 (09:38 +1200)]
Merge pull request #18257 from eileenmcnaughton/relob
Remove 1 of 2 remaining places where relatedObjects is called in completeOrder
Eileen McNaughton [Wed, 26 Aug 2020 19:21:29 +0000 (07:21 +1200)]
Merge pull request #18252 from JKingsnorth/core-1971-fix
dev/core#1971 Caching of domain-specific option values
eileen [Tue, 25 Aug 2020 20:00:01 +0000 (08:00 +1200)]
Remove 1 or 2 remaining places where relatedObjects is called in completeOrder
If we remove this & the other place we no longer need to call loadRelatedObjects before this
function and only message related places call it
In this case the lines can go as
1) trxn_id should always be used if provided. Casting to isoDate has not been required for a few
years as the DAO now handles
Matthew Wire [Wed, 26 Aug 2020 11:22:59 +0000 (12:22 +0100)]
Merge pull request #18258 from eileenmcnaughton/refer
Remove last pass-by-reference in completeOrder signature
Seamus Lee [Tue, 25 Aug 2020 22:21:26 +0000 (08:21 +1000)]
Merge pull request #18249 from mattwire/utf8mb4moretables
Support more table names for utf8mb4 conversions and database name
John Kingsnorth [Tue, 25 Aug 2020 21:38:23 +0000 (22:38 +0100)]
dev/core#1971 Fix test breaking subsequent tests when it fails
Eileen McNaughton [Tue, 25 Aug 2020 21:08:38 +0000 (09:08 +1200)]
Merge pull request #18250 from seamuslee001/ref_entity_id_group
[REF] Ensure that the form param _id is set when adding a new group w…
Seamus Lee [Tue, 25 Aug 2020 21:03:40 +0000 (07:03 +1000)]
Merge pull request #18248 from JMAConsulting/optimise_proximity_search
Optimise proximity custom search, by reducing addGeocodingData fn call
eileen [Tue, 25 Aug 2020 20:48:12 +0000 (08:48 +1200)]
Remove last pass-by-reference in completeOrder signature
ids is now only referred to once in the function & never altered. I have assigned that value to
a param & unset ids after that to make that clear
Eileen McNaughton [Tue, 25 Aug 2020 20:30:08 +0000 (08:30 +1200)]
Merge pull request #18255 from colemanw/fieldLabel
Expose field label to APIv4 and Search creaor
Eileen McNaughton [Tue, 25 Aug 2020 20:09:38 +0000 (08:09 +1200)]
Merge pull request #18256 from colemanw/fieldTitles
Separate titles from labels in exportable fields
Coleman Watts [Tue, 25 Aug 2020 18:20:51 +0000 (14:20 -0400)]
Separate titles from labels in exportable fields
Follow-up to #18255 and #18114 - this separates field titles (used in export) from labels (used in forms and other displays).
The previous approach was to try to use the title for both, and if that didn't work, override it somewhere.
colemanw [Tue, 25 Aug 2020 17:40:07 +0000 (13:40 -0400)]
Merge pull request #18254 from pradpnayak/casetypeselection
Fix js for case type status change on load
Coleman Watts [Tue, 25 Aug 2020 15:33:09 +0000 (11:33 -0400)]
Expose field label to APIv4 and Search creaor
Pradeep Nayak [Tue, 25 Aug 2020 14:39:33 +0000 (15:39 +0100)]
Fix js for case type status change on load
John Kingsnorth [Tue, 25 Aug 2020 10:35:57 +0000 (11:35 +0100)]
dev/core#1971 Domain-specific option value caching
Matthew Wire [Wed, 22 Apr 2020 09:48:36 +0000 (10:48 +0100)]
Support more table names for utf8mb4 conversions and database name
John Kingsnorth [Tue, 25 Aug 2020 10:26:30 +0000 (11:26 +0100)]
dev/core#1971 Test for domain-specific option values
Seamus Lee [Tue, 25 Aug 2020 07:57:32 +0000 (17:57 +1000)]
[REF] Ensure that the form param _id is set when adding a new group with the newly created group id so that consumers of the hook_civicrm_postProcess can access the id
Seamus Lee [Tue, 25 Aug 2020 06:54:58 +0000 (16:54 +1000)]
Merge pull request #18235 from pradpnayak/dev-1946
Batch Update via Profile does not supply data for editing when custom fields created after participant added to event
colemanw [Mon, 24 Aug 2020 15:46:26 +0000 (11:46 -0400)]
Merge pull request #18236 from mattwire/crmregion_notyou
Wrap "not you" message in crmRegion
Monish Deb [Mon, 24 Aug 2020 12:18:25 +0000 (17:48 +0530)]
Optimise proximity custom search, by reducing addGeocodingData fn call
Matthew Wire [Mon, 24 Aug 2020 10:24:34 +0000 (11:24 +0100)]
Merge pull request #18243 from eileenmcnaughton/static
Do not pass by reference for createRelatedMemberships
Matthew Wire [Mon, 24 Aug 2020 10:21:08 +0000 (11:21 +0100)]
Merge pull request #18242 from eileenmcnaughton/dep
Remove 2019 deprecated function
Seamus Lee [Mon, 24 Aug 2020 10:18:24 +0000 (20:18 +1000)]
Merge pull request #18118 from artfulrobot/artfulrobot-msgtpl-disable-smarty
Add disable_smarty option to MessageTemplate.send API
Rich Lott / Artful Robot [Mon, 10 Aug 2020 16:33:56 +0000 (17:33 +0100)]
Add disable_smarty option to MessageTemplate.send API
Coleman Watts [Mon, 24 Aug 2020 03:16:32 +0000 (23:16 -0400)]
Remove old dropped items from the schema xml
Removes unused fields and indexes which were dropped prior to 4.4.7
which is currently the min upgradable version.
eileen [Mon, 24 Aug 2020 01:11:07 +0000 (13:11 +1200)]
Do not pass by reference for createRelatedMemberships
There are 2 parameters passed by reference to this function
1) dao - this is not altered
2) params - this IS altered but the calling function (create) does not use it again. While it's
possible a function that calls create uses it again the idea that they would want the params
to have been altered to refer to a different related relationship does not seem probable.
Tests on this are in JobTest & apiv3_MembershipTest
Eileen McNaughton [Sun, 23 Aug 2020 22:29:45 +0000 (10:29 +1200)]
Merge pull request #18229 from totten/master-patchset
distmaker - Autogenerate civicrm-*-patchset.tar.gz
eileen [Sun, 23 Aug 2020 22:22:44 +0000 (10:22 +1200)]
Remove 2019 deprecated function
We stopped using this in core & deprecated it in 5.16
Seamus Lee [Sun, 23 Aug 2020 21:32:54 +0000 (07:32 +1000)]
Merge pull request #18153 from larssg-wildsight/patch-1
dev/core#1950 Update help text and description for the profile add to groups setting
Seamus Lee [Sun, 23 Aug 2020 21:32:02 +0000 (07:32 +1000)]
Merge pull request #18221 from civicrm/eileenmcnaughton-patch-1
Remove ref to logging time
Seamus Lee [Sun, 23 Aug 2020 21:28:36 +0000 (07:28 +1000)]
Merge pull request #18240 from demeritcowboy/deprecated-RID
Replace deprecated Drupal 8 constants
Eileen McNaughton [Sun, 23 Aug 2020 21:08:55 +0000 (09:08 +1200)]
Merge pull request #18234 from pradpnayak/dedupeTrim
trim white space when checking dedupe
Seamus Lee [Sun, 23 Aug 2020 20:40:18 +0000 (06:40 +1000)]
Merge pull request #18238 from agileware/separator-not-seperator
Spelling mistake "separator" not "seperator"
Seamus Lee [Sun, 23 Aug 2020 20:23:14 +0000 (06:23 +1000)]
Merge pull request #18239 from demeritcowboy/gencode-checksum
[NFC] Some DAO checksums not updated
demeritcowboy [Sun, 23 Aug 2020 13:44:59 +0000 (09:44 -0400)]
deprecated constants
demeritcowboy [Sun, 23 Aug 2020 13:33:26 +0000 (09:33 -0400)]
checksums not updated
Justin Freeman [Sun, 23 Aug 2020 04:32:31 +0000 (14:32 +1000)]
Global spelling mistake "separator" not "seperator"
Tim Otten [Sat, 22 Aug 2020 23:28:10 +0000 (16:28 -0700)]
(NFC) distmaker - More comments
Seamus Lee [Sat, 22 Aug 2020 22:49:34 +0000 (08:49 +1000)]
Merge pull request #18231 from civicrm/5.29
5.29
Seamus Lee [Sat, 22 Aug 2020 20:29:10 +0000 (06:29 +1000)]
Merge pull request #18230 from seamuslee001/5.29
Update contributor key for Andrew
Matthew Wire [Sat, 22 Aug 2020 14:02:04 +0000 (15:02 +0100)]
Wrap not you message in crmRegion
Pradeep Nayak [Sat, 22 Aug 2020 13:53:02 +0000 (14:53 +0100)]
Batch Update via Profile does not supply data for editing when custom fields created after participant added to event
Pradeep Nayak [Sat, 22 Aug 2020 13:06:48 +0000 (14:06 +0100)]
trim white space when checking dedupe
Seamus Lee [Sat, 22 Aug 2020 09:32:19 +0000 (19:32 +1000)]
Update contributor key for Andrew
Tim Otten [Sat, 22 Aug 2020 09:32:32 +0000 (02:32 -0700)]
Merge pull request #18228 from seamuslee001/5.29
5.28.2 & 5.29.3 Release Notes
Tim Otten [Sat, 22 Aug 2020 09:08:19 +0000 (02:08 -0700)]
distmaker - Autogenerate civicrm-*-patchset.tar.gz
Tim Otten [Thu, 20 Aug 2020 05:34:44 +0000 (22:34 -0700)]
Add release-notes/5.28.2.md
Tim Otten [Sat, 22 Aug 2020 08:29:31 +0000 (01:29 -0700)]
Add release-notes/5.28.3.md
Seamus Lee [Sat, 22 Aug 2020 08:30:13 +0000 (18:30 +1000)]
Merge pull request #18226 from civicrm/5.29
5.29
Seamus Lee [Sat, 22 Aug 2020 06:46:03 +0000 (16:46 +1000)]
Merge pull request #18223 from eileenmcnaughton/529deupe
dev/core#1964 Fix regression bug on deduping contacts with dedupe_exception matches
eileen [Wed, 29 Jul 2020 06:53:51 +0000 (18:53 +1200)]
[REF] Extract function to get locations to merge, rename 'operation' to is_replace'
This is a preliminary refactor. I have a bug to fix in this code but cannot yet make sense of it. The mergeHandler class
is simply an object to refactor the functions onto. Much of this code is hard to work with as the use of static functions
necessitates a lot of compilation and compiling so the process of cleaning it up involves extracting functionns to this
new class (which may one day replace the Merger class). As it is a refactoring process the functions reflect the old code
more than the ideal code. However, it provides the change to give some documentation regarding the locBlock array
and also to rename the confusing field 'operation' to 'is_replace'
Seamus Lee [Fri, 21 Aug 2020 23:05:46 +0000 (09:05 +1000)]
Merge pull request #18222 from civicrm/5.29
5.29 to master
eileen [Fri, 21 Aug 2020 22:36:18 +0000 (10:36 +1200)]
dev/core#1964 Fix regression bug on deduping contacts with dedupe_exception matches
I want to do another pass on this & do more SELECT queries & less UPDATE queries so we are doing
less locking - but for now this should get us past the logged regression
Eileen McNaughton [Fri, 21 Aug 2020 21:54:20 +0000 (09:54 +1200)]
Merge pull request #18214 from eileenmcnaughton/dedupe
Fix dedupe regression whereby deleted contacts are found
Eileen McNaughton [Fri, 21 Aug 2020 21:49:36 +0000 (09:49 +1200)]
Merge pull request #18136 from demeritcowboy/deprecated-hook-invoke
[Test framework] - Remove test for deprecated way of calling hook invoke
Eileen McNaughton [Fri, 21 Aug 2020 21:13:37 +0000 (09:13 +1200)]
Merge pull request #18208 from mattwire/contribregister_clean
Cleanup contactID variables in event/contribution register buildQuickForm
Eileen McNaughton [Fri, 21 Aug 2020 20:54:39 +0000 (08:54 +1200)]
Merge pull request #18209 from mattwire/repeattransaction_cleanup
Remove unused variables from repeatTransaction
Seamus Lee [Fri, 21 Aug 2020 20:53:51 +0000 (06:53 +1000)]
Merge pull request #18216 from eileenmcnaughton/meta
Metadata fix in activity search
Eileen McNaughton [Fri, 21 Aug 2020 20:25:02 +0000 (08:25 +1200)]
Remove ref to logging time
The page is not anon accessible & I think we don't do this now - @joshgowans ?
Eileen McNaughton [Fri, 21 Aug 2020 19:43:05 +0000 (07:43 +1200)]
Merge pull request #18217 from mattwire/orderapicleanup
Minor code cleanup to Order API