Coleman Watts [Wed, 8 Dec 2021 13:03:21 +0000 (08:03 -0500)]
SearchKit - Rename searchList template to match controller, move "New Search" button to top
Coleman Watts [Tue, 7 Dec 2021 21:16:07 +0000 (16:16 -0500)]
SearchKit - Add Export dialog
Coleman Watts [Mon, 6 Dec 2021 16:17:27 +0000 (11:17 -0500)]
Afform - Be more forgiving about input format when saving an afform
Coleman Watts [Mon, 6 Dec 2021 03:06:49 +0000 (22:06 -0500)]
SearchKit - Faster delete/revert actions in search listing
Coleman Watts [Mon, 6 Dec 2021 02:50:30 +0000 (21:50 -0500)]
SearchKit - Use dropdown for actions in search listing
The list of actions is getting too big for a row of buttons...
colemanw [Mon, 20 Dec 2021 21:29:07 +0000 (16:29 -0500)]
Merge pull request #22276 from eileenmcnaughton/process
[REF] Duplicate & unshare processFormContribution
Eileen McNaughton [Mon, 20 Dec 2021 19:57:02 +0000 (08:57 +1300)]
Merge pull request #22282 from colemanw/cgExtends
CustomGroup - Add pseudoconstant for extends column
Coleman Watts [Mon, 20 Dec 2021 05:54:52 +0000 (00:54 -0500)]
CustomGroup - Add pseudoconstant for extends column
Yashodha Chaku [Mon, 20 Dec 2021 08:55:40 +0000 (14:25 +0530)]
Merge pull request #22265 from eileenmcnaughton/ver
dev/core#2996 Increment php recommndations
Seamus Lee [Mon, 20 Dec 2021 05:18:56 +0000 (16:18 +1100)]
Merge pull request #22275 from eileenmcnaughton/recur_test
dev/core#567 Add test shell
Seamus Lee [Mon, 20 Dec 2021 05:18:47 +0000 (16:18 +1100)]
Merge pull request #22278 from demeritcowboy/unused-function
Remove unused function CRM/Utils/Mail/EmailProcessor::cleanupDir
Seamus Lee [Mon, 20 Dec 2021 05:18:37 +0000 (16:18 +1100)]
Merge pull request #22279 from eileenmcnaughton/refs
Remove unnecessary pass-by-ref
Eileen McNaughton [Sun, 19 Dec 2021 22:40:24 +0000 (11:40 +1300)]
Remove unnecessary pass-by-ref
demeritcowboy [Sun, 19 Dec 2021 22:27:32 +0000 (17:27 -0500)]
unused function
Eileen McNaughton [Sun, 19 Dec 2021 21:56:31 +0000 (10:56 +1300)]
dev/core#567 Add test shell
Eileen McNaughton [Sun, 19 Dec 2021 22:17:57 +0000 (11:17 +1300)]
[REF] Duplicate & unshare processFormContribution
The only way I've managed to break up these big toxic functions is divide & conquer. While it seems
counter-intuitive to not doing things in more than one place in practice much of the
code is form-relevant and the the code before, during and after these functions
does a whole lot of extra work to share stuff that they don't really have in common.
This dates back pre-api when the only copy of the business logic often was on the forms....
demeritcowboy [Sun, 19 Dec 2021 17:56:05 +0000 (12:56 -0500)]
Merge pull request #22272 from eileenmcnaughton/anet
[NFC] Cleanup in Authorize.net test class
demeritcowboy [Sat, 18 Dec 2021 23:34:16 +0000 (18:34 -0500)]
Merge pull request #21927 from eileenmcnaughton/trxn
Move two more functions to financialProcessor
colemanw [Sat, 18 Dec 2021 23:33:33 +0000 (18:33 -0500)]
Merge pull request #22233 from colemanw/apiExplorerArgs
APIv4 Explorer - Make selected language and format bookmarkable
Eileen McNaughton [Sat, 18 Dec 2021 21:40:13 +0000 (10:40 +1300)]
[NFC] Cleanup in Authorize.net test class
The main goal in this update is to switch the contribution form to use the full form flow.
Other changes are just code style
Eileen McNaughton [Sat, 18 Dec 2021 21:23:38 +0000 (10:23 +1300)]
Merge pull request #22266 from eileenmcnaughton/cont_tests
Fix test to use full form flow
Eileen McNaughton [Sat, 18 Dec 2021 21:22:11 +0000 (10:22 +1300)]
Merge pull request #22269 from demeritcowboy/make-clean
[NFC] - Try to work around failing tests
Eileen McNaughton [Sat, 18 Dec 2021 21:17:30 +0000 (10:17 +1300)]
Merge pull request #22271 from civicrm/5.45
5.45
demeritcowboy [Sat, 18 Dec 2021 00:19:43 +0000 (19:19 -0500)]
Merge pull request #22270 from colemanw/relatedContactsLabel
Fix related contacts label in search kit
Coleman Watts [Fri, 17 Dec 2021 21:37:06 +0000 (16:37 -0500)]
Fix related contacts label in search kit
demeritcowboy [Fri, 17 Dec 2021 20:37:57 +0000 (15:37 -0500)]
work around previous test fails
Eileen McNaughton [Fri, 17 Dec 2021 04:50:07 +0000 (17:50 +1300)]
Fix test to use full form flow
Eileen McNaughton [Wed, 27 Oct 2021 19:55:04 +0000 (08:55 +1300)]
Move two more functions to financialProcessor
Eileen McNaughton [Thu, 16 Dec 2021 22:44:03 +0000 (11:44 +1300)]
Increment php recommndations
Tim Otten [Thu, 16 Dec 2021 21:27:49 +0000 (13:27 -0800)]
Merge pull request #22107 from demeritcowboy/test-isdir
dev/core#2927 - Avoid warnings for is_dir() when open_basedir is in effect
Tim Otten [Thu, 16 Dec 2021 21:19:29 +0000 (13:19 -0800)]
Merge pull request #22236 from mlutfy/angularCacheCodeLanguage
Resources: set language-specific cacheCode, fixes AngularJS translation with multilingual
Mathieu Lu [Thu, 16 Dec 2021 14:04:11 +0000 (09:04 -0500)]
Merge pull request #21762 from jitendrapurohit/job-alert
Add system status warning to display scheduled job failures
jitendrapurohit [Thu, 9 Dec 2021 11:23:23 +0000 (16:53 +0530)]
add ts
Eileen McNaughton [Thu, 16 Dec 2021 03:37:47 +0000 (16:37 +1300)]
Merge pull request #22261 from eileenmcnaughton/prof
[REF] Remove more params that are unused now function is not shared
Eileen McNaughton [Thu, 16 Dec 2021 01:51:42 +0000 (14:51 +1300)]
[REF] Remove more params that are unused now function is not shared
Seamus Lee [Wed, 15 Dec 2021 23:50:58 +0000 (10:50 +1100)]
Merge pull request #22260 from eileenmcnaughton/prof
Remove handling for always-truthy var being false
Seamus Lee [Wed, 15 Dec 2021 22:44:49 +0000 (09:44 +1100)]
Merge pull request #22259 from eileenmcnaughton/update
Rename protected function
Eileen McNaughton [Wed, 15 Dec 2021 22:19:50 +0000 (11:19 +1300)]
Remove handling for always truthy var being false
In a previous unshared life the code in this function supported contact being null
However, in it's unshared version contactID is always an integer (in the merge context). This strips
out the now-irrelevant code.
Further cleanup to follow ... it's not clear this function is doing
anything of value at all but some unwravelling required
Seamus Lee [Wed, 15 Dec 2021 22:02:49 +0000 (09:02 +1100)]
Merge pull request #22258 from eileenmcnaughton/prof
Remove never passed variables
Eileen McNaughton [Wed, 15 Dec 2021 20:30:43 +0000 (09:30 +1300)]
Rename protected function
This function was originally shared & hence the name made sense but in the context of dedupe
it is only used to do updates so renaming to make that clear & making required nature
of contactID clear too
Eileen McNaughton [Wed, 15 Dec 2021 20:23:39 +0000 (09:23 +1300)]
Remove never passed variables
This function is no longer shared so is only called from one place. That place doesn't use
contactDetails so don't return. Also never sets skipCustom so stop checking
(will remove the other non-passed soon)
colemanw [Wed, 15 Dec 2021 20:06:27 +0000 (15:06 -0500)]
Merge pull request #22254 from eileenmcnaughton/prof
[REF] Duplicate function to allow us to work it out of the code
colemanw [Wed, 15 Dec 2021 19:50:54 +0000 (14:50 -0500)]
Merge pull request #22257 from aydun/mr-info
(NFC) APIv4: Add help info for multi-record custom field sets
Aidan Saunders [Wed, 15 Dec 2021 15:45:12 +0000 (15:45 +0000)]
Add help info for multi-record custom field sets
colemanw [Wed, 15 Dec 2021 13:24:20 +0000 (08:24 -0500)]
Merge pull request #22183 from eileenmcnaughton/smarty9
Smarty variables] Remove another isset - deferredFinancialType
Mathieu Lu [Wed, 15 Dec 2021 12:30:14 +0000 (07:30 -0500)]
Merge pull request #22256 from eileenmcnaughton/order
Do not default-escape weight field on order
Eileen McNaughton [Wed, 15 Dec 2021 09:05:15 +0000 (22:05 +1300)]
Do not default-escape weight field on order
Seamus Lee [Wed, 15 Dec 2021 06:19:19 +0000 (17:19 +1100)]
Merge pull request #22253 from eileenmcnaughton/rel5
[REF] Minor parameter simplification
Eileen McNaughton [Wed, 15 Dec 2021 03:23:11 +0000 (16:23 +1300)]
[REF] Duplicate function to allow us to work it out of the code
demeritcowboy [Wed, 15 Dec 2021 03:53:39 +0000 (22:53 -0500)]
Merge pull request #22251 from eileenmcnaughton/rel3
[NFC] Test cleanup
Eileen McNaughton [Wed, 15 Dec 2021 01:52:58 +0000 (14:52 +1300)]
[REF] Minor parameter simplification
The only value in this array used in the function is 'custom' which should be an array. I think it woul
d only ever be an array or NULL (which would then be an array with this change) but I left
a deprecation notice in case. Pass-by-ref isn't needed
Eileen McNaughton [Wed, 15 Dec 2021 03:06:11 +0000 (16:06 +1300)]
Merge pull request #22249 from eileenmcnaughton/rel
[NFC] Minor cleanup in test class
Eileen McNaughton [Wed, 15 Dec 2021 02:37:41 +0000 (15:37 +1300)]
Merge pull request #22252 from eileenmcnaughton/escapeit
Move require_once for smarty modifier due to order issues
Eileen McNaughton [Tue, 14 Dec 2021 21:13:37 +0000 (10:13 +1300)]
[NFC] Test cleanup
This biggest part of this is relying on the tearDown to do the cleanup more. This is the right
way because if the test fails the cleanup won't happen if it is in the test itsef
colemanw [Tue, 14 Dec 2021 22:10:31 +0000 (17:10 -0500)]
Merge pull request #22243 from demeritcowboy/quickfix-reportedby
dev/core#2825 - Make source contact required for activities on the form
Eileen McNaughton [Tue, 14 Dec 2021 21:27:15 +0000 (10:27 +1300)]
Move require_once for smarty modifier due to order issues
Eileen McNaughton [Tue, 14 Dec 2021 21:07:20 +0000 (10:07 +1300)]
[NFC] Minor cleanup in test class
demeritcowboy [Tue, 14 Dec 2021 21:07:01 +0000 (16:07 -0500)]
Merge pull request #22248 from MattTrim1/patch-1
Contributor key: Add Matt Trim
demeritcowboy [Tue, 14 Dec 2021 21:06:53 +0000 (16:06 -0500)]
Merge pull request #22244 from MattTrim1/flip-default-display-custom-group-options
dev/core#2977 - For custom group creation, flip the default display settings
MattTrim1 [Tue, 14 Dec 2021 19:21:11 +0000 (19:21 +0000)]
Contributor key: Add Matt Trim
demeritcowboy [Tue, 14 Dec 2021 19:18:08 +0000 (14:18 -0500)]
Merge pull request #22246 from mattwire/money0.5
Update Brick/Money to 0.5.3
Mathieu Lu [Tue, 14 Dec 2021 18:36:16 +0000 (13:36 -0500)]
Merge pull request #22247 from mlutfy/fixConfirmRecur545
Contribution Confirm: fix wording on the recurring
Mathieu Lutfy [Tue, 14 Dec 2021 16:23:40 +0000 (11:23 -0500)]
Contribution Confirm: fix wording on the recurring
Matthew Wire [Tue, 14 Dec 2021 11:03:41 +0000 (11:03 +0000)]
Update brick/money to 0.5.3
Matt Trim [Mon, 13 Dec 2021 23:29:41 +0000 (23:29 +0000)]
For custom group creation, flip the default display settings
demeritcowboy [Mon, 13 Dec 2021 19:56:24 +0000 (14:56 -0500)]
make source contact required
Mathieu Lutfy [Thu, 9 Dec 2021 19:13:55 +0000 (14:13 -0500)]
Resources: set a cacheCode that is language-specific, fixes AngularJS translation with multilingual
Yashodha Chaku [Mon, 13 Dec 2021 05:41:46 +0000 (11:11 +0530)]
Merge pull request #22240 from colemanw/nirodaonline-master
Contact/BAO/Query.php: fix searching for whitespace
demeritcowboy [Sun, 12 Dec 2021 16:45:13 +0000 (11:45 -0500)]
avoid flooding logs when open_basedir is used
Tim Otten [Sat, 11 Dec 2021 22:37:10 +0000 (14:37 -0800)]
Merge pull request #22213 from colemanw/afformApi4
[REF] Afform - Use APIv4 for managed dashboard
nirodaonline [Fri, 12 Nov 2021 15:55:17 +0000 (16:55 +0100)]
Contact/BAO/Query.php: fix searching for whitespace
Condition was never true
Add Unit test for space wildcard replacement on sort_name
fix failing test
Tim Otten [Sat, 11 Dec 2021 04:29:43 +0000 (20:29 -0800)]
Merge pull request #22096 from yashodha/dev-2962
(dev/core#2962) get contact id for the mailing along with display nam…
Tim Otten [Sat, 11 Dec 2021 04:21:29 +0000 (20:21 -0800)]
Merge pull request #22225 from colemanw/upgradeTemplateFix
Simplify autogenerated boilerplate upgrader class
Tim Otten [Sat, 11 Dec 2021 02:51:28 +0000 (18:51 -0800)]
Merge pull request #22238 from colemanw/upgradeVerBump
Upgrade - Bump minimum upgradable version to 4.6.12
Tim Otten [Fri, 10 Dec 2021 08:39:14 +0000 (00:39 -0800)]
(NFC) CRM_Upgrade_Incremental_Base - Expand docblocks. More references.
Coleman Watts [Fri, 10 Dec 2021 14:28:06 +0000 (09:28 -0500)]
Remove unnecessary legacy version check
Now that the minimum upgradable version is > 4.6, this check is not needed.
demeritcowboy [Fri, 10 Dec 2021 14:18:48 +0000 (09:18 -0500)]
Merge pull request #22186 from eileenmcnaughton/smarty12
Smarty variables] Another isset bites the dust
Coleman Watts [Fri, 10 Dec 2021 14:14:39 +0000 (09:14 -0500)]
Bump minimum upgradable version to 4.6.12
colemanw [Fri, 10 Dec 2021 14:03:19 +0000 (09:03 -0500)]
Merge pull request #22237 from totten/master-verifydb
(REF) CRM/Upgrade - Remove unused entrypoint `verifyPreDBstate()`
Tim Otten [Fri, 10 Dec 2021 08:49:55 +0000 (00:49 -0800)]
(REF) CRM/Upgrade - Remove unused entrypoint `verifyPreDBstate()`
Overview
--------
In olden times, upgraders sometimes implemented the method `verifyPreDBstate()`. However, this appears to be unused.
Additionally, it's not clear (from the documentation) how you would use it (if you wanted to).
So... simplify the code....
Before
------
Function exists. But it does nothing. Because no subclasses implement it.
After
-----
Function does not exist. It still does nothing.
Coleman Watts [Wed, 8 Dec 2021 14:22:27 +0000 (09:22 -0500)]
Simplify autogenerated boilerplate upgrader class and clarify comments
demeritcowboy [Fri, 10 Dec 2021 00:12:48 +0000 (19:12 -0500)]
Merge pull request #22187 from eileenmcnaughton/smarty13
Smarty variables] Remove isset from batch form
Eileen McNaughton [Tue, 30 Nov 2021 21:48:44 +0000 (10:48 +1300)]
Remove isset from batch form
Affects url civicrm/financial/financialbatches?reset=1&batchStatus=1
Mathieu Lu [Thu, 9 Dec 2021 21:47:27 +0000 (16:47 -0500)]
Merge pull request #22234 from colemanw/afformDateRange
Afform - Set date-range defaults
Eileen McNaughton [Thu, 9 Dec 2021 21:45:59 +0000 (10:45 +1300)]
Merge pull request #22232 from civicrm/5.45
5.45
Mathieu Lu [Thu, 9 Dec 2021 21:40:47 +0000 (16:40 -0500)]
Merge pull request #22226 from colemanw/deleteBoilerplate
NFC - Delete boilerplate comments and empty functions from upgrade classes
colemanw [Thu, 9 Dec 2021 21:09:38 +0000 (16:09 -0500)]
Merge pull request #22193 from eileenmcnaughton/smarty18
[Smarty variables] remove isset from merge screen
Tim Otten [Thu, 9 Dec 2021 21:02:58 +0000 (13:02 -0800)]
Merge pull request #22231 from colemanw/apiDisabledComponent
dev/core#2984 - Clarify API error when component is disabled
colemanw [Thu, 9 Dec 2021 19:24:25 +0000 (14:24 -0500)]
Merge pull request #22203 from colemanw/revertContactDeletePermission
Revert "Add permission metadata to contact is_deleted field"
Coleman Watts [Thu, 9 Dec 2021 17:34:57 +0000 (12:34 -0500)]
APIv4 - Fix datePicker defaults
Ensures datepickers can select more than the current year (start and end date years were defaulting to 0)
Fixes dev/report#84
Coleman Watts [Thu, 9 Dec 2021 16:32:36 +0000 (11:32 -0500)]
APIv4 Explorer - Make selected language and format bookmarkable with url args
Prefix non-param args with an underscore to avoid conflicts with param names
demeritcowboy [Thu, 9 Dec 2021 16:24:36 +0000 (11:24 -0500)]
Merge pull request #22214 from yashodha/dev-2979
(dev/core#2979) remove the limit of 15 max values for multiple values…
yashodha [Mon, 6 Dec 2021 07:37:07 +0000 (13:07 +0530)]
change the limit
demeritcowboy [Thu, 9 Dec 2021 03:21:26 +0000 (22:21 -0500)]
Merge pull request #22194 from eileenmcnaughton/smarty19
[Smarty variables] Fix overzealous escaping with smarty default escaping
demeritcowboy [Thu, 9 Dec 2021 03:21:08 +0000 (22:21 -0500)]
Merge pull request #22195 from eileenmcnaughton/smarty20
[Smarty variables] Remove issets relating to auto_renew
Seamus Lee [Thu, 9 Dec 2021 01:42:22 +0000 (12:42 +1100)]
Merge pull request #22230 from agh1/5.45.0-releasenotes-initial
5.45.0 release notes initial run
Coleman Watts [Thu, 9 Dec 2021 00:47:38 +0000 (19:47 -0500)]
Fixes dev/core#2984 - Give clear error message when entity's component is disabled
Previously, using an API from a disabled component would fail in unexpected ways
with cryptic error messages. Now it's clearly not allowed.
Andie Hunt [Wed, 8 Dec 2021 22:16:53 +0000 (17:16 -0500)]
5.45.0 release notes: added boilerplate
Andie Hunt [Wed, 8 Dec 2021 22:11:18 +0000 (17:11 -0500)]
Contributor key: add Chris Garaffa
Andie Hunt [Wed, 8 Dec 2021 22:03:23 +0000 (17:03 -0500)]
5.45.0 release notes: raw from script