Tim Otten [Mon, 21 Jun 2021 03:56:02 +0000 (20:56 -0700)]
msgtplui - Edit.js - Status alert when adding/removing draft
Tim Otten [Mon, 21 Jun 2021 03:50:20 +0000 (20:50 -0700)]
msgtplui - Tweak tabs
Tim Otten [Mon, 21 Jun 2021 02:49:02 +0000 (19:49 -0700)]
msgtplui - EditContent - Simpler dataflow. Fix refresh bug.
Tim Otten [Mon, 21 Jun 2021 02:31:30 +0000 (19:31 -0700)]
msgtplui - Workflow.html - Hide translation widgets if there is only one locale
Tim Otten [Mon, 21 Jun 2021 02:21:48 +0000 (19:21 -0700)]
msgtplui - backlog.md
Tim Otten [Mon, 21 Jun 2021 02:21:23 +0000 (19:21 -0700)]
msgtplui - (REF) Normalize folder name
Tim Otten [Sun, 20 Jun 2021 23:07:13 +0000 (16:07 -0700)]
msgtplui - Move toolbar into heading
Tim Otten [Sun, 20 Jun 2021 22:30:00 +0000 (15:30 -0700)]
msgtplui - Use more Bootstrap styling
Tim Otten [Sun, 20 Jun 2021 22:09:38 +0000 (15:09 -0700)]
msgtplui - EditContent - Add controller. Basic tokens. Skeletal buttons.
Tim Otten [Sun, 20 Jun 2021 05:19:56 +0000 (22:19 -0700)]
msgtplui - Edit.html - Fix warning
Tim Otten [Sun, 20 Jun 2021 04:57:59 +0000 (21:57 -0700)]
msgtplui - Edit - Make the 'Subject' widget more consistent
Before: Flipped back/forth between 1-line INPUT and Monaco. The transitions were awkward.
After: Just use Monaco, but tighten the size a bit
Tim Otten [Sat, 19 Jun 2021 05:25:06 +0000 (22:25 -0700)]
msgtplui - Edit - Display "Locale" in pretty format
Tim Otten [Sat, 19 Jun 2021 05:21:51 +0000 (22:21 -0700)]
msgtplui - Edit - Use "_exists" flag. Fix initial saving of new txActive and/or txDraft records.
Tim Otten [Sat, 19 Jun 2021 01:57:53 +0000 (18:57 -0700)]
msgtplui - Implement "Add Translation" dialog
Tim Otten [Sat, 19 Jun 2021 04:17:11 +0000 (21:17 -0700)]
msgtplui - Add crmDialog helpers
Tim Otten [Fri, 18 Jun 2021 23:27:10 +0000 (16:27 -0700)]
msgtplui - (REF) ListCtrl - More consistent variable name
It's a little confusing that .html uses `$ctrl` while JS uses `ctrl`.
Just use `$ctrl` for both.# On branch master
Tim Otten [Fri, 18 Jun 2021 23:08:42 +0000 (16:08 -0700)]
msgtplui - (REF) More consistent variable name
It's a little confusing that .html uses `$ctrl` while JS uses `ctrl`.
Just use `$ctrl` for both.
Tim Otten [Fri, 18 Jun 2021 23:06:33 +0000 (16:06 -0700)]
msgtplui - Edit screen - Prettier buttons
Tim Otten [Fri, 18 Jun 2021 22:58:05 +0000 (15:58 -0700)]
msgtplui - Add workflow for transitioning between draft<=>current
Tim Otten [Wed, 16 Jun 2021 10:20:02 +0000 (03:20 -0700)]
msgtplui - Tune height of Monaco
Tim Otten [Wed, 16 Jun 2021 09:44:49 +0000 (02:44 -0700)]
msgtplui - Edit - Implement save() and delete()
Tim Otten [Wed, 16 Jun 2021 09:36:01 +0000 (02:36 -0700)]
msgtplui - Fixup msg_subject. Extract <msgtplui-monaco>
Tim Otten [Wed, 16 Jun 2021 08:30:24 +0000 (01:30 -0700)]
msgtplui - Tweak deletion prompt
Tim Otten [Wed, 16 Jun 2021 08:25:53 +0000 (01:25 -0700)]
msgtplui - Edit - Skeletal action buttons
Tim Otten [Wed, 16 Jun 2021 08:04:31 +0000 (01:04 -0700)]
msgtplui - Visually wrap long line
Tim Otten [Wed, 16 Jun 2021 07:50:47 +0000 (00:50 -0700)]
msgtplui - Move "HTML" and "Text" content into accordions. Use Monaco.
Tim Otten [Wed, 16 Jun 2021 07:27:16 +0000 (00:27 -0700)]
msgtplui - Show Current/Draft/Original with form widgets
Tim Otten [Wed, 16 Jun 2021 07:19:13 +0000 (00:19 -0700)]
msgtplui - Edit - Download real msgtpl data. Show tabs with JSON.
Tim Otten [Tue, 15 Jun 2021 22:00:44 +0000 (15:00 -0700)]
msgtplui - Always put normal MsgTpl above its translations
Tim Otten [Tue, 15 Jun 2021 09:51:32 +0000 (02:51 -0700)]
msgtplui - Simplify 'record.*' expressions. Order explicitly on (title,language).
Tim Otten [Tue, 15 Jun 2021 09:18:07 +0000 (02:18 -0700)]
msgtplui - ListCtrl - Ensure that standard records are always listed
Before: If you have a translation, then it would obscure the existence of the standard/baseline template.
After: The records for the standard/baseline templates and translations are separate.
Tim Otten [Tue, 15 Jun 2021 06:20:45 +0000 (23:20 -0700)]
msgtplui - Hide reserved/original values
Tim Otten [Tue, 15 Jun 2021 06:15:25 +0000 (23:15 -0700)]
msgtplui - On "User-Driven" tab, connect "Edit" button to old UI
Relatedly, when the user-returns, cleanup the resulting URL.
Tim Otten [Tue, 15 Jun 2021 06:03:40 +0000 (23:03 -0700)]
msgtplui - ListCtrl - Bind the filter-text to "?f=..."
Tim Otten [Tue, 15 Jun 2021 05:58:47 +0000 (22:58 -0700)]
msgtplui - Add navbar and help box
Tim Otten [Tue, 15 Jun 2021 05:07:05 +0000 (22:07 -0700)]
msgtplui - Misc - Add filter box. Cleanup some links. Consolidate list ctrls.
Tim Otten [Tue, 15 Jun 2021 01:45:40 +0000 (18:45 -0700)]
msgtplui - Add skeletal listing of msg tpls
Tim Otten [Tue, 15 Jun 2021 00:26:34 +0000 (17:26 -0700)]
msgtplui - msgtplui - Require translatable message templates
Tim Otten [Tue, 15 Jun 2021 00:26:22 +0000 (17:26 -0700)]
msgtplui - info.xml - Require afform
Tim Otten [Sat, 12 Jun 2021 23:35:14 +0000 (16:35 -0700)]
msgtplui - Skeleton
Eileen McNaughton [Thu, 23 Sep 2021 22:11:19 +0000 (10:11 +1200)]
Merge pull request #21585 from eileenmcnaughton/compat
Fix test
Seamus Lee [Thu, 23 Sep 2021 20:12:03 +0000 (06:12 +1000)]
Merge pull request #21538 from mattwire/subscriptioncleanup
Clean up UpdateBilling/UpdateSubscription/ContributionRecur to use getters
Eileen McNaughton [Thu, 23 Sep 2021 11:42:30 +0000 (23:42 +1200)]
Fix test
Fixes test logic I accidentally voided
colemanw [Thu, 23 Sep 2021 19:19:56 +0000 (15:19 -0400)]
Merge pull request #21457 from colemanw/searchDisplayAfformDelete
Fixes dev/core#2824 - Handle related Afforms when deleting Search Displays
Matthew Wire [Thu, 23 Sep 2021 17:28:04 +0000 (18:28 +0100)]
Merge pull request #21577 from jmcclelland/display-backend-recur-options
ensure recur options are present on backend cc contribution form.
Matthew Wire [Thu, 23 Sep 2021 17:24:08 +0000 (18:24 +0100)]
Merge pull request #21484 from JKingsnorth/price-field-id-css
Add unique class to price field template
Jamie McClelland [Thu, 23 Sep 2021 15:47:13 +0000 (11:47 -0400)]
remove type hint to return bool - we are no longer using the ret value.
Jamie McClelland [Wed, 22 Sep 2021 14:00:36 +0000 (10:00 -0400)]
ensure recur options are present on backend cc contribution form.
We seem to be adding an extra check to see if the given
payment processor has any credit card fields before including the
recur option on the backend contribution page. But some processors,
like Stripe, insert the fields via javascript. It should be enough
to just test for the existence of a payment processor that supports
recur to run the block.
Also, no other code is checking the return value of buildPaymentForm
so removing it.
Matthew Wire [Thu, 23 Sep 2021 10:56:13 +0000 (11:56 +0100)]
Add standardized params for billingStateProvince and billingCountry
Matthew Wire [Sun, 19 Sep 2021 10:12:52 +0000 (11:12 +0100)]
Clean up UpdateBilling/UpdateSubscription/ContributionRecur to use getters
Seamus Lee [Thu, 23 Sep 2021 07:48:07 +0000 (17:48 +1000)]
Merge pull request #21525 from eileenmcnaughton/cont_dep
dev/core#2851 Block use of legacy style contribution tokens
Eileen McNaughton [Thu, 23 Sep 2021 06:18:40 +0000 (18:18 +1200)]
Merge pull request #21580 from demeritcowboy/tokerr
dev/core#2856 - Token "filter" can be null so filter[0] doesn't exist
Tim Otten [Thu, 23 Sep 2021 04:31:03 +0000 (21:31 -0700)]
Merge pull request #21568 from eileenmcnaughton/labels
dev/core#2814 fix tokenCompat to be consistent with unresolved tokens
demeritcowboy [Thu, 23 Sep 2021 02:24:30 +0000 (22:24 -0400)]
null
Eileen McNaughton [Thu, 23 Sep 2021 01:12:38 +0000 (13:12 +1200)]
Merge pull request #21579 from eileenmcnaughton/notice
Enotice fix
Eileen McNaughton [Thu, 23 Sep 2021 00:54:43 +0000 (12:54 +1200)]
Remove old comment
Eileen McNaughton [Thu, 23 Sep 2021 00:45:15 +0000 (12:45 +1200)]
Merge pull request #21574 from colemanw/searchPrimary
Fixes dev/core#2852 - Add is_primary as a default SearchKit filter
Tim Otten [Thu, 23 Sep 2021 00:25:45 +0000 (17:25 -0700)]
(REF) TokenCompatSubscriber - Simplify expression that replaces unknown tokens
Additionally, this uses the regex from `TokenProcessor` instead of the regex from `CRM_Utils_Token`.
These differ in whether they capture the '|filter' expressions.
Tim Otten [Wed, 22 Sep 2021 23:52:47 +0000 (16:52 -0700)]
(REF) TokenProcessor::visitTokens() - Increase visibility. Refine comments+tests.
Seamus Lee [Wed, 22 Sep 2021 23:27:58 +0000 (09:27 +1000)]
Merge pull request #21564 from lcdservices/dev-core-2850
dev/core#2850 update_email_resetdate consider opt out on hold
Seamus Lee [Wed, 22 Sep 2021 23:27:23 +0000 (09:27 +1000)]
Merge pull request #21572 from colemanw/afformEvents
Afform - Add getters/setters to the AfformSubmitEvent class
Eileen McNaughton [Wed, 22 Sep 2021 23:19:08 +0000 (11:19 +1200)]
Enotice fix
Eileen McNaughton [Wed, 22 Sep 2021 22:49:59 +0000 (10:49 +1200)]
Merge pull request #21551 from colemanw/sqlEquation
APIv4 - Add support for sql equations
Eileen McNaughton [Wed, 22 Sep 2021 22:48:35 +0000 (10:48 +1200)]
Merge pull request #21569 from totten/master-datets
CRM_Utils_Date - Month and day names should match active locale
Coleman Watts [Wed, 22 Sep 2021 14:45:50 +0000 (10:45 -0400)]
Fixes dev/core#2852 - Add is_primary as a default SearchKit filter
When joining Contacts to emails, addresses, phones and IMs this will
automatically add is_primary=1 as a default search criteria.
Eileen McNaughton [Wed, 22 Sep 2021 06:18:31 +0000 (18:18 +1200)]
dev/core#2814 fix tokenCompat to be consistent with unresolved tokens
This fixes the tokenCompat subscriber to replace unresolved tokens with a
blank string in a consistent way.
Prior to this it would crash if smarty was enabled but not all tokens
were resolved & print unresolved tokens if smarty was not enabled.
The inconsistencies appear to be due to 'separate evolution' rather than '*reasons*'
Eileen McNaughton [Wed, 22 Sep 2021 22:30:56 +0000 (10:30 +1200)]
Merge pull request #21557 from eileenmcnaughton/log
Fix bug where log hook is ignored on custom field create
Tim Otten [Wed, 22 Sep 2021 06:48:46 +0000 (23:48 -0700)]
(NFC) TokenProcessorTest - When formatting dates, month and day names should be localized
Tim Otten [Wed, 22 Sep 2021 06:48:06 +0000 (23:48 -0700)]
CRM_Utils_Date - Month and day names should match active locale
colemanw [Wed, 22 Sep 2021 20:27:12 +0000 (16:27 -0400)]
Merge pull request #21531 from eileenmcnaughton/now
Add {domain.now}, supporting |crmDate
Eileen McNaughton [Wed, 22 Sep 2021 20:16:58 +0000 (08:16 +1200)]
Merge pull request #21576 from demeritcowboy/ufval
UFMatch - E_NOTICE when nonexistent uf_id
Coleman Watts [Mon, 20 Sep 2021 16:33:07 +0000 (12:33 -0400)]
APIv4 - Add support for sql equations
Eileen McNaughton [Tue, 21 Sep 2021 00:52:26 +0000 (12:52 +1200)]
Fix bug where log hook is ignored on custom field create
It is possible to specify that various tables should not
result in a log table via the `alterLogTables` hook.
This is useful for excluding tables of low information
value or tables like summary fields that are calculated
values. However, when altering custom fields this
hook's output was being ignored as it was going through
the specific path of
which did not have awareness of this hook.
This code path is the primary use for this function.
It's also called via createMissingLogTables - but in
that case the calculation is already done. It is not
elsewhere in git universe and the return value
is never used, so I removed it
Eileen McNaughton [Wed, 22 Sep 2021 19:31:22 +0000 (07:31 +1200)]
Merge pull request #21578 from civicrm/5.42
5.42 to master
Eileen McNaughton [Wed, 22 Sep 2021 19:30:30 +0000 (07:30 +1200)]
Merge pull request #21575 from agh1/5.42.0-releasenotes-initial
5.42.0 release notes initial run
demeritcowboy [Wed, 22 Sep 2021 16:39:32 +0000 (12:39 -0400)]
don't crash for nonexistent uf_id
Coleman Watts [Wed, 22 Sep 2021 13:25:15 +0000 (09:25 -0400)]
Afform - Add getters/setters to the AfformSubmitEvent class
This makes it easier for 3rd-parties to interact with the event.
Andie Hunt [Wed, 22 Sep 2021 15:45:21 +0000 (11:45 -0400)]
5.42.0 release notes: added boilerplate
Andie Hunt [Wed, 22 Sep 2021 15:44:57 +0000 (11:44 -0400)]
5.42.0 release notes: raw from script
demeritcowboy [Wed, 22 Sep 2021 13:51:02 +0000 (09:51 -0400)]
Merge pull request #21554 from eileenmcnaughton/loop
[REF] Remove illusion of looping
Brian Shaughnessy [Wed, 22 Sep 2021 12:23:51 +0000 (08:23 -0400)]
dev/core#2850 add comment
Tim Otten [Wed, 22 Sep 2021 06:30:22 +0000 (23:30 -0700)]
(NFC) TokenSmartyTest - Add some more examples, mixing token-filters and Smarty-filters
Tim Otten [Wed, 22 Sep 2021 05:09:49 +0000 (22:09 -0700)]
TokenProcessor - Filter args should require quotes (to match Smarty notation)
Eileen McNaughton [Wed, 22 Sep 2021 01:39:52 +0000 (13:39 +1200)]
Merge pull request #21563 from eileenmcnaughton/ev_toke
Initial test on event tokens
Eileen McNaughton [Wed, 22 Sep 2021 00:42:32 +0000 (12:42 +1200)]
Fix tokens to pass filters through
Tim Otten [Tue, 21 Sep 2021 10:22:03 +0000 (03:22 -0700)]
TokenProcessor - render() and addMessage() should use same regex to find tokens
Tim Otten [Tue, 21 Sep 2021 10:18:36 +0000 (03:18 -0700)]
TokenConsistencyTest - Fix assertion
This is a new/recent assertion. Not passing. Looks different from other/similar assertions.
Tim Otten [Tue, 21 Sep 2021 08:47:52 +0000 (01:47 -0700)]
TokenConsistencyTest - Use a valid timestamp
Tim Otten [Tue, 21 Sep 2021 08:47:08 +0000 (01:47 -0700)]
DomainTokens - {domain.now} should abide by mocked times
Eileen McNaughton [Sat, 18 Sep 2021 23:24:18 +0000 (11:24 +1200)]
Add now token
colemanw [Wed, 22 Sep 2021 00:23:43 +0000 (20:23 -0400)]
Merge pull request #21566 from eileenmcnaughton/render
Remove deprecated code lines
Eileen McNaughton [Tue, 21 Sep 2021 19:31:29 +0000 (07:31 +1200)]
Test cleanup
Fixes passing null to event create. Remove some tests duplicated by syntaxconformance
Matthew Wire [Tue, 21 Sep 2021 22:07:43 +0000 (23:07 +0100)]
Merge pull request #21555 from eileenmcnaughton/money
dev/core#2493 Add support for money laundry in `getSubmittedValue`
Matthew Wire [Tue, 21 Sep 2021 22:03:50 +0000 (23:03 +0100)]
Merge pull request #21430 from mattwire/flushcache
flushCaches should respect permitCacheFlushMode. Also flush caches which have a NULL cache_date
Eileen McNaughton [Tue, 21 Sep 2021 21:33:44 +0000 (09:33 +1200)]
Remove deprecated code lines
These have been deprecated for around 8 months
, are not used in core, and are in code where
5.43 will already require extra testing so let's remove
so we can simplify
Eileen McNaughton [Tue, 21 Sep 2021 09:06:13 +0000 (21:06 +1200)]
Initial test on event tokens
Note there is an issue to do with caching affecting the custom token but
it's out of scope on this test
Brian Shaughnessy [Tue, 21 Sep 2021 19:43:26 +0000 (15:43 -0400)]
dev/core#2850 update_email_resetdate consider opt out on hold
demeritcowboy [Tue, 21 Sep 2021 19:34:24 +0000 (15:34 -0400)]
Merge pull request #21553 from eileenmcnaughton/email2
[Ref] Extend email trait test, process more sanely
Tim Otten [Tue, 21 Sep 2021 10:09:11 +0000 (03:09 -0700)]
Merge pull request #21494 from eileenmcnaughton/compat
dev/core#2814 TokenCompatSubscriber - evaluate contact tokens during civi.token.eval phase
Eileen McNaughton [Tue, 21 Sep 2021 09:55:34 +0000 (21:55 +1200)]
Merge pull request #21374 from ufundo/event-custom-tokens
Fix event custom field tokens in scheduled reminders