civicrm-core.git
2 years agoMerge pull request #23993 from colemanw/searchKitJoinFix
Seamus Lee [Thu, 14 Jul 2022 09:52:49 +0000 (19:52 +1000)]
Merge pull request #23993 from colemanw/searchKitJoinFix

SearchKit - Fix adding deep joins

2 years agoMerge pull request #23998 from MegaphoneJon/net-smtp-110
Seamus Lee [Thu, 14 Jul 2022 02:19:27 +0000 (12:19 +1000)]
Merge pull request #23998 from MegaphoneJon/net-smtp-110

net_smtp upgrade to 1.10.0

2 years agonet_smtp upgrade to 1.10.0
Jon Goldberg [Thu, 14 Jul 2022 00:13:14 +0000 (20:13 -0400)]
net_smtp upgrade to 1.10.0

2 years agoSearchKit - Fix adding deep joins
Coleman Watts [Wed, 13 Jul 2022 15:54:25 +0000 (11:54 -0400)]
SearchKit - Fix adding deep joins

This fixes a UI bug that was preventing joins past a depth of 2 to be added.

2 years agoMerge pull request #23992 from civicrm/5.52
Eileen McNaughton [Wed, 13 Jul 2022 04:20:59 +0000 (16:20 +1200)]
Merge pull request #23992 from civicrm/5.52

5.52

2 years agoMerge pull request #23991 from totten/5.52-civitest
Seamus Lee [Wed, 13 Jul 2022 00:34:58 +0000 (10:34 +1000)]
Merge pull request #23991 from totten/5.52-civitest

Civi\Test - Fix leak in active module-list for headless test

2 years agoCivi\Test - Fix leak in active module-list for headless test
Tim Otten [Tue, 12 Jul 2022 02:00:59 +0000 (19:00 -0700)]
Civi\Test - Fix leak in active module-list for headless test

Steps to reproduce
------------------

Observed on a `dmaster` build while running these steps:

* Run civix's `make-example.sh`
* Or just run some subset involving a headless test, eg
   * civix generate:test --template=headless 'Civi\Civiexample\BarTest'
   * cv api extension.install key=$EXMODULE
   * phpunit8 ./tests/phpunit/Civi/Civiexample/BarTest.php

Before
------

Fatal error: Uncaught Error: Class 'Civi\Api4\SearchSegment' not found in
/home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Service/Spec/Provider/SearchSegmentExtraFieldProvider.php
on line 52

After
-----

Test runs

2 years agoMerge pull request #23984 from seamuslee001/ref_full_package_upgrades_php8_1
Eileen McNaughton [Tue, 12 Jul 2022 03:23:07 +0000 (15:23 +1200)]
Merge pull request #23984 from seamuslee001/ref_full_package_upgrades_php8_1

[REF][PHP8.1] Upgrade oauth2-client,zetacomponents/base,htmlpurfier packages …

2 years agoMerge pull request #23990 from civicrm/5.52
Seamus Lee [Tue, 12 Jul 2022 02:04:16 +0000 (12:04 +1000)]
Merge pull request #23990 from civicrm/5.52

5.52

2 years agoMerge pull request #23988 from seamuslee001/5_52_phpunit_deprecations
Seamus Lee [Tue, 12 Jul 2022 02:03:04 +0000 (12:03 +1000)]
Merge pull request #23988 from seamuslee001/5_52_phpunit_deprecations

[NFC] Restore handling for deprecations in phpunit test runs

2 years ago[NFC] Add in convertDeprecationsToExceptions='true' to core extension's phpunit.xml...
Seamus Lee [Mon, 11 Jul 2022 08:10:47 +0000 (18:10 +1000)]
[NFC] Add in convertDeprecationsToExceptions='true' to core extension's phpunit.xml.dist files

2 years ago[NFC] Convert Deprecations in tests to exceptions
Seamus Lee [Mon, 11 Jul 2022 02:26:21 +0000 (12:26 +1000)]
[NFC] Convert Deprecations in tests to exceptions

2 years agoMerge pull request #22227 from mlutfy/standalone
demeritcowboy [Mon, 11 Jul 2022 13:29:13 +0000 (09:29 -0400)]
Merge pull request #22227 from mlutfy/standalone

CiviCRM Standalone: base classes

2 years agoMerge pull request #23986 from seamuslee001/dep_exceptions_ext
demeritcowboy [Mon, 11 Jul 2022 12:03:04 +0000 (08:03 -0400)]
Merge pull request #23986 from seamuslee001/dep_exceptions_ext

[NFC] Add in convertDeprecationsToExceptions='true' to core extension…

2 years ago[NFC] Add in convertDeprecationsToExceptions='true' to core extension's phpunit.xml...
Seamus Lee [Mon, 11 Jul 2022 08:10:47 +0000 (18:10 +1000)]
[NFC] Add in convertDeprecationsToExceptions='true' to core extension's phpunit.xml.dist files

2 years agoMerge pull request #23985 from seamuslee001/nfc_deprecations
Seamus Lee [Mon, 11 Jul 2022 05:21:02 +0000 (15:21 +1000)]
Merge pull request #23985 from seamuslee001/nfc_deprecations

[NFC] Convert Deprecations in tests to exceptions

2 years ago[NFC] Convert Deprecations in tests to exceptions
Seamus Lee [Mon, 11 Jul 2022 02:26:21 +0000 (12:26 +1000)]
[NFC] Convert Deprecations in tests to exceptions

2 years agoMerge pull request #23982 from eileenmcnaughton/act_cont
Seamus Lee [Mon, 11 Jul 2022 00:46:57 +0000 (10:46 +1000)]
Merge pull request #23982 from eileenmcnaughton/act_cont

dev/core#3692 Remove hard coded activity_type_id

2 years agoMerge pull request #23981 from eileenmcnaughton/act_seq
Seamus Lee [Mon, 11 Jul 2022 00:46:46 +0000 (10:46 +1000)]
Merge pull request #23981 from eileenmcnaughton/act_seq

dev/core#3692 Remove call to deprecated function

2 years agoMerge pull request #23979 from eileenmcnaughton/act_status
Seamus Lee [Sun, 10 Jul 2022 23:42:39 +0000 (09:42 +1000)]
Merge pull request #23979 from eileenmcnaughton/act_status

dev/core#3692 Comment fixes

2 years ago[REF] Upgrade oauth2-client,zetacomponents/base,htmlpurfier packages to versions...
Seamus Lee [Sun, 10 Jul 2022 23:03:11 +0000 (09:03 +1000)]
[REF] Upgrade oauth2-client,zetacomponents/base,htmlpurfier packages to versions that support php8.1

2 years agoMerge pull request #23932 from webmaster-cses-org-uk/patch-4
Eileen McNaughton [Sun, 10 Jul 2022 22:41:12 +0000 (10:41 +1200)]
Merge pull request #23932 from webmaster-cses-org-uk/patch-4

Add support for multiple-selection of contact IDs in _civicrm_api3_custom_data_get()

2 years agoRemove hard coded activity_type_id
Eileen McNaughton [Sun, 10 Jul 2022 21:45:37 +0000 (09:45 +1200)]
Remove hard coded activity_type_id

2 years agoRemove call to deprecated function
Eileen McNaughton [Sun, 10 Jul 2022 21:42:08 +0000 (09:42 +1200)]
Remove call to deprecated function

2 years agoComment fixes
Eileen McNaughton [Sun, 10 Jul 2022 21:35:49 +0000 (09:35 +1200)]
Comment fixes

2 years agoMerge pull request #23978 from demeritcowboy/composerlock
Eileen McNaughton [Sun, 10 Jul 2022 21:04:56 +0000 (09:04 +1200)]
Merge pull request #23978 from demeritcowboy/composerlock

[NFC] fix composer.lock hash

2 years agoMerge pull request #23977 from demeritcowboy/dompdf-whitespace
Eileen McNaughton [Sun, 10 Jul 2022 21:04:37 +0000 (09:04 +1200)]
Merge pull request #23977 from demeritcowboy/dompdf-whitespace

[NFC] dompdf patch whitespace fix

2 years agoMerge pull request #20588 from mattwire/recaptcharefactor
demeritcowboy [Sun, 10 Jul 2022 20:42:29 +0000 (16:42 -0400)]
Merge pull request #20588 from mattwire/recaptcharefactor

REF dev/core#2571 Move reCAPTCHA code to extension

2 years agofix lock hash
demeritcowboy [Sun, 10 Jul 2022 15:58:42 +0000 (11:58 -0400)]
fix lock hash

2 years agoMerge pull request #22918 from demeritcowboy/guzzle7
demeritcowboy [Sun, 10 Jul 2022 15:21:23 +0000 (11:21 -0400)]
Merge pull request #22918 from demeritcowboy/guzzle7

dev/drupal#171 - Allow guzzle 7 for drupal 10

2 years agowhitespace fix
demeritcowboy [Sun, 10 Jul 2022 15:09:46 +0000 (11:09 -0400)]
whitespace fix

2 years agoMerge pull request #23946 from seamuslee001/dompdf_upgrade
demeritcowboy [Sun, 10 Jul 2022 15:07:48 +0000 (11:07 -0400)]
Merge pull request #23946 from seamuslee001/dompdf_upgrade

[REF] Upgrade DOMPDF to 2.x branch

2 years agoMerge pull request #23851 from seamuslee001/php81_deprecations
demeritcowboy [Sat, 9 Jul 2022 15:21:10 +0000 (11:21 -0400)]
Merge pull request #23851 from seamuslee001/php81_deprecations

[REF][PHP8.1] Fix a couple of deprecations in php8.1 by specifying th…

2 years agoMerge pull request #23976 from civicrm/5.52
Seamus Lee [Sat, 9 Jul 2022 08:27:06 +0000 (18:27 +1000)]
Merge pull request #23976 from civicrm/5.52

5.52

2 years agoMerge pull request #23975 from totten/5.52-skip-soaptest
Seamus Lee [Sat, 9 Jul 2022 04:31:53 +0000 (14:31 +1000)]
Merge pull request #23975 from totten/5.52-skip-soaptest

(NFC) SoapTest - Skip this test on Drupal8+ and Backdrop

2 years agoSet version to 5.53.alpha1
CiviCRM [Sat, 9 Jul 2022 02:29:00 +0000 (02:29 +0000)]
Set version to 5.53.alpha1

2 years agoSet version to 5.52.beta1
CiviCRM [Sat, 9 Jul 2022 02:24:14 +0000 (02:24 +0000)]
Set version to 5.52.beta1

2 years ago(NFC) SoapTest - Skip this test on Drupal8+ and Backdrop
Tim Otten [Sat, 9 Jul 2022 02:21:35 +0000 (19:21 -0700)]
(NFC) SoapTest - Skip this test on Drupal8+ and Backdrop

Never passed on D8+.  Has been failing for a while on Backdrop.  There's a
work-a-like extension.  No need to monitor results on these configurations.

2 years agoFix installed-fonts cache
Seamus Lee [Wed, 6 Jul 2022 02:28:10 +0000 (12:28 +1000)]
Fix installed-fonts cache

2 years ago[REF] Upgrade DOMPDF to 2.x branch
Seamus Lee [Tue, 5 Jul 2022 22:32:40 +0000 (08:32 +1000)]
[REF] Upgrade DOMPDF to 2.x branch

2 years agoMerge pull request #23971 from seamuslee001/lab_core_3676
Seamus Lee [Sat, 9 Jul 2022 00:51:33 +0000 (10:51 +1000)]
Merge pull request #23971 from seamuslee001/lab_core_3676

[REF] dev/core#3676 Add in html2text/html2text to replace usage of roundcube's version we have in packages

2 years ago[REF][PHP8.1] Fix a couple of deprecations in php8.1 by specifying that return type...
Seamus Lee [Tue, 21 Jun 2022 06:11:57 +0000 (16:11 +1000)]
[REF][PHP8.1] Fix a couple of deprecations in php8.1 by specifying that return type may change in BaseParamQuery and by ensuring that we don't pass null into function_exists in I18n class

Replace some ReturnTypeWillChange with later return types as they should be backward compatible

Dave D Fix

Completely switch to just not empty on the customTranslationFunction check

2 years agoUpdate Base Mailing System Test to match newer output format
Seamus Lee [Fri, 8 Jul 2022 22:37:15 +0000 (08:37 +1000)]
Update Base Mailing System Test to match newer output format

2 years agoMerge pull request #23968 from eileenmcnaughton/import_note
Seamus Lee [Fri, 8 Jul 2022 22:31:08 +0000 (08:31 +1000)]
Merge pull request #23968 from eileenmcnaughton/import_note

Fix import falling over when a note is included

2 years ago[REF] dev/core#3676 Add in html2text/html2text to replace usage of roundcube's versio...
Seamus Lee [Fri, 8 Jul 2022 05:52:21 +0000 (15:52 +1000)]
[REF] dev/core#3676 Add in html2text/html2text to replace usage of roundcube's version we have in packages

2 years agoAdd in necessary patch for html2text for php8.1
Seamus Lee [Fri, 8 Jul 2022 05:42:28 +0000 (15:42 +1000)]
Add in necessary patch for html2text for php8.1

2 years agoMerge pull request #23967 from colemanw/angularCleanup
Eileen McNaughton [Fri, 8 Jul 2022 02:41:32 +0000 (14:41 +1200)]
Merge pull request #23967 from colemanw/angularCleanup

REF - Remove unneeded return from private fn, add comments

2 years agoFix import falling over when a note is included
Eileen McNaughton [Thu, 7 Jul 2022 22:21:46 +0000 (10:21 +1200)]
Fix import falling over when a note is included

2 years agoREF - Remove unneeded return from private fn, add comments
Coleman Watts [Thu, 7 Jul 2022 22:19:26 +0000 (18:19 -0400)]
REF - Remove unneeded return from private fn, add comments

2 years agoMerge pull request #23965 from MegaphoneJon/contribution-view-perm-fix
Eileen McNaughton [Thu, 7 Jul 2022 21:57:01 +0000 (09:57 +1200)]
Merge pull request #23965 from MegaphoneJon/contribution-view-perm-fix

Fixes core#3725 'Access CiviContribute' can't view a single contribution

2 years agoMerge pull request #23925 from seamuslee001/type_hints_2
Tim Otten [Thu, 7 Jul 2022 21:46:38 +0000 (14:46 -0700)]
Merge pull request #23925 from seamuslee001/type_hints_2

[REF][PHP8.1] Add in type hints to fix deprecations and add in #[\Ret…

2 years agoFixes core#3725 'Access CiviContribute' can't view a single contribution
Jon Goldberg [Thu, 7 Jul 2022 18:35:27 +0000 (14:35 -0400)]
Fixes core#3725 'Access CiviContribute' can't view a single contribution

2 years agoMerge pull request #23929 from eileenmcnaughton/recur
colemanw [Thu, 7 Jul 2022 15:02:32 +0000 (11:02 -0400)]
Merge pull request #23929 from eileenmcnaughton/recur

Upgrade script for contribution_recur amount, fix loading

2 years agoMerge pull request #23809 from eileenmcnaughton/invoice_recur
colemanw [Thu, 7 Jul 2022 15:02:18 +0000 (11:02 -0400)]
Merge pull request #23809 from eileenmcnaughton/invoice_recur

Fix bug whereby editing contribution_recur.amount was not updating single-line-item-template-contributions

2 years agoMerge pull request #23964 from eileenmcnaughton/tpl_err
colemanw [Thu, 7 Jul 2022 15:00:42 +0000 (11:00 -0400)]
Merge pull request #23964 from eileenmcnaughton/tpl_err

Do not escape error message

2 years agoMerge pull request #23937 from demeritcowboy/case-activity-search-filter
Matthew Wire [Thu, 7 Jul 2022 12:38:32 +0000 (13:38 +0100)]
Merge pull request #23937 from demeritcowboy/case-activity-search-filter

dev/core#3709 - Make the activity search filter on manage case less unwieldy

2 years agoMerge pull request #23962 from eileenmcnaughton/pledge
Matthew Wire [Thu, 7 Jul 2022 12:37:26 +0000 (13:37 +0100)]
Merge pull request #23962 from eileenmcnaughton/pledge

Remove another instance of pledges using contribution option group

2 years agoMerge pull request #23963 from eileenmcnaughton/tpl
Matthew Wire [Thu, 7 Jul 2022 12:36:34 +0000 (13:36 +0100)]
Merge pull request #23963 from eileenmcnaughton/tpl

Smarty notice fix

2 years agoMerge pull request #23924 from colemanw/afformPopup
Matthew Wire [Thu, 7 Jul 2022 12:35:55 +0000 (13:35 +0100)]
Merge pull request #23924 from colemanw/afformPopup

Angular - Support popping up an afform or other ang module via ajax modal

2 years agoAlso don't escape in if context
Eileen McNaughton [Thu, 7 Jul 2022 09:13:04 +0000 (21:13 +1200)]
Also don't escape in if context

- just a bit less confusing when debugging

2 years agoAdd precautionary purify
Eileen McNaughton [Thu, 7 Jul 2022 08:58:14 +0000 (20:58 +1200)]
Add precautionary purify

2 years agoDo not escape error message
Eileen McNaughton [Thu, 7 Jul 2022 08:57:05 +0000 (20:57 +1200)]
Do not escape error message

2 years agoSmarty notice fix
Eileen McNaughton [Thu, 7 Jul 2022 08:25:32 +0000 (20:25 +1200)]
Smarty notice fix

2 years agoMerge pull request #23961 from totten/master-mgdphp-caseacttype
Seamus Lee [Thu, 7 Jul 2022 07:37:36 +0000 (17:37 +1000)]
Merge pull request #23961 from totten/master-mgdphp-caseacttype

(NFC) mgd-php@1 - Add example+assertions for new case-type

2 years agoMerge pull request #23960 from seamuslee001/fix_static_calling_trait
Seamus Lee [Thu, 7 Jul 2022 07:37:26 +0000 (17:37 +1000)]
Merge pull request #23960 from seamuslee001/fix_static_calling_trait

[REF][PHP8.1] Fix deprecations where by calling trait static function…

2 years agoMerge pull request #23959 from totten/master-casexml-acttype
Eileen McNaughton [Thu, 7 Jul 2022 06:38:04 +0000 (18:38 +1200)]
Merge pull request #23959 from totten/master-casexml-acttype

(NFC) case-xml@1 - Add example+assertions of new activity-type

2 years agoRemove another instance of pledges using contribution option group
Eileen McNaughton [Thu, 7 Jul 2022 05:22:57 +0000 (17:22 +1200)]
Remove another instance of pledges using contribution option group

2 years agoDeclare total_amount, make amount an alias
Eileen McNaughton [Thu, 7 Jul 2022 02:06:15 +0000 (14:06 +1200)]
Declare total_amount, make amount an alias

The confusion between amount & total_amount is in
multiple places - this means they are treated 'the same' if passed
into repeattransaction

2 years agoFix handling of parameters in repeattransaction
Eileen McNaughton [Thu, 7 Jul 2022 02:00:34 +0000 (14:00 +1200)]
Fix handling of parameters in repeattransaction

The function was forcing in the value from the original contribution
into amount, rather than the value from the templateContribution

2 years agoEnotice fix for when campaign is disabled
Eileen McNaughton [Wed, 6 Jul 2022 23:04:12 +0000 (11:04 +1200)]
Enotice fix for when campaign is disabled

2 years agoUpgrade script for contribution_recur amount, fix loading
Eileen McNaughton [Fri, 1 Jul 2022 21:13:07 +0000 (09:13 +1200)]
Upgrade script for contribution_recur amount, fix loading

2 years agoMerge pull request #23084 from pradpnayak/paypalipnchangemaount
Eileen McNaughton [Thu, 7 Jul 2022 05:05:27 +0000 (17:05 +1200)]
Merge pull request #23084 from pradpnayak/paypalipnchangemaount

Subscription Amount change not respected in Paypal

2 years ago[REF][PHP8.1] Fix deprecations where by calling trait static functions when not from...
Seamus Lee [Thu, 7 Jul 2022 04:23:31 +0000 (14:23 +1000)]
[REF][PHP8.1] Fix deprecations where by calling trait static functions when not from a class that implements the trait is deprecated

2 years agoMerge pull request #23958 from civicrm/5.51
Seamus Lee [Thu, 7 Jul 2022 04:14:25 +0000 (14:14 +1000)]
Merge pull request #23958 from civicrm/5.51

5.51

2 years agomgd-php@1 - Add example+assertions for new case-type (but without a real `definition`)
Tim Otten [Thu, 7 Jul 2022 03:15:14 +0000 (20:15 -0700)]
mgd-php@1 - Add example+assertions for new case-type (but without a real `definition`)

2 years agocase-xml@1 - Add example+assertions of new activity-type
Tim Otten [Thu, 7 Jul 2022 03:12:03 +0000 (20:12 -0700)]
case-xml@1 - Add example+assertions of new activity-type

2 years agoMerge pull request #23956 from agh1/5.51.0-releasenotes-final
Seamus Lee [Thu, 7 Jul 2022 01:42:59 +0000 (11:42 +1000)]
Merge pull request #23956 from agh1/5.51.0-releasenotes-final

5.51.0 release notes final changes

2 years agoMerge pull request #23933 from eileenmcnaughton/require
colemanw [Wed, 6 Jul 2022 23:02:23 +0000 (19:02 -0400)]
Merge pull request #23933 from eileenmcnaughton/require

Import fix - if there are no required fields validateRequiredFields should 'pass'

2 years agoMerge pull request #23934 from eileenmcnaughton/url_tokens
colemanw [Wed, 6 Jul 2022 22:59:52 +0000 (18:59 -0400)]
Merge pull request #23934 from eileenmcnaughton/url_tokens

dev/core#3713 Use front-end urls for event url tokens

2 years agoMerge pull request #23953 from eileenmcnaughton/imp_job
colemanw [Wed, 6 Jul 2022 22:56:36 +0000 (18:56 -0400)]
Merge pull request #23953 from eileenmcnaughton/imp_job

dev/core#3719 fix inconistent handling of job_type:label

2 years agoAfform - Close popup dialog after submitting
Coleman Watts [Wed, 6 Jul 2022 21:10:35 +0000 (17:10 -0400)]
Afform - Close popup dialog after submitting

2 years agoAfform - Use urlHash embedded in popup dialog
Coleman Watts [Wed, 6 Jul 2022 21:01:47 +0000 (17:01 -0400)]
Afform - Use urlHash embedded in popup dialog

2 years agocrmUi - Fix crmPageTitle directive to work inside a modal
Coleman Watts [Fri, 1 Jul 2022 02:12:24 +0000 (22:12 -0400)]
crmUi - Fix crmPageTitle directive to work inside a modal

2 years agoAngular - Support popping up an afform or other ang module via ajax modal
Coleman Watts [Fri, 1 Jul 2022 01:53:54 +0000 (21:53 -0400)]
Angular - Support popping up an afform or other ang module via ajax modal

Fixes the AngularLoader to work with modal dialogs via ajax.
Dedupes the already-loaded modules to only load what's needed.

2 years agoMerge pull request #23947 from totten/master-php81-global
Tim Otten [Wed, 6 Jul 2022 21:01:29 +0000 (14:01 -0700)]
Merge pull request #23947 from totten/master-php81-global

dev/core#3181 - Resolver - Compatibility fix for GLOBALS in PHP 8.1

2 years ago5.51.0 release notes: added late changes
Andie Hunt [Wed, 6 Jul 2022 19:47:53 +0000 (15:47 -0400)]
5.51.0 release notes: added late changes

2 years agoAdd release-notes/5.50.4.md
Tim Otten [Mon, 27 Jun 2022 22:35:00 +0000 (15:35 -0700)]
Add release-notes/5.50.4.md

2 years agoAdd release-notes/5.50.3.md
Tim Otten [Fri, 17 Jun 2022 06:00:57 +0000 (23:00 -0700)]
Add release-notes/5.50.3.md

2 years agoFix typo in version of Guzzle
tschuettler [Wed, 15 Jun 2022 07:36:07 +0000 (09:36 +0200)]
Fix typo in version of Guzzle

2 years agoAdd release-notes/5.50.2.md
Tim Otten [Tue, 14 Jun 2022 21:22:48 +0000 (14:22 -0700)]
Add release-notes/5.50.2.md

2 years agoAdd release-notes/5.50.1.md
Tim Otten [Fri, 3 Jun 2022 04:51:42 +0000 (21:51 -0700)]
Add release-notes/5.50.1.md

2 years agoMerge pull request #23945 from eileenmcnaughton/map
Yashodha Chaku [Wed, 6 Jul 2022 15:22:19 +0000 (20:52 +0530)]
Merge pull request #23945 from eileenmcnaughton/map

Enotice fix

2 years agoMerge pull request #23346 from mattwire/totaltaxamount
Matthew Wire [Wed, 6 Jul 2022 08:58:31 +0000 (09:58 +0100)]
Merge pull request #23346 from mattwire/totaltaxamount

Fix calculation and assignment of taxAmount on contribution page confirmation

2 years agodev/core#3719 fix inconistent handling of job_type:label
Eileen McNaughton [Wed, 6 Jul 2022 07:57:21 +0000 (19:57 +1200)]
dev/core#3719 fix inconistent handling of job_type:label

2 years agoMerge pull request #23951 from civicrm/5.51
Eileen McNaughton [Wed, 6 Jul 2022 07:42:24 +0000 (19:42 +1200)]
Merge pull request #23951 from civicrm/5.51

5.51 to master

2 years agoMerge pull request #23949 from alifrumin/rn5.51
Eileen McNaughton [Wed, 6 Jul 2022 07:23:24 +0000 (19:23 +1200)]
Merge pull request #23949 from alifrumin/rn5.51

[NFC] 5.51 Release Notes - first pass

2 years ago[NFC] 5.51 release notes
Alice Frumin [Sat, 2 Jul 2022 00:20:39 +0000 (20:20 -0400)]
[NFC] 5.51 release notes

2 years agodev/core#3181 - Resolver - Compatibility fix for GLOBALS in PHP 8.1
Tim Otten [Tue, 5 Jul 2022 23:33:17 +0000 (16:33 -0700)]
dev/core#3181 - Resolver - Compatibility fix for GLOBALS in PHP 8.1

2 years agoCRM_Utils_Array - All `pathGet()`-like methods will accept empty-path
Tim Otten [Tue, 5 Jul 2022 23:23:36 +0000 (16:23 -0700)]
CRM_Utils_Array - All `pathGet()`-like methods will accept empty-path

These two are equivalent:

  (A) $data['sub1']['sub2']['sub3']
  (B) CRM_Utils_Array::pathGet($data, ['sub1', 'sub2', 'sub3'])

But what if the list of subpaths is empty -- ie you're accessing the top-level item?

  (A) $data
  (B) CRM_Utils_Array::pathGet($data, [])

It worked correctly on `pathGet()`, but accessing the top-level using a
related methods (eg `pathSet()`) would generate a PHP error.

This commit ensures that related methods can be used to check/update the
top-level item (ie path===[]).

Note that there is some decent test-coverage already for the regular
scenarios (eg `testGetSetPathParts()`).

2 years agoEnotice fix
Eileen McNaughton [Tue, 5 Jul 2022 20:46:05 +0000 (08:46 +1200)]
Enotice fix