civicrm-core.git
5 years agoAdd 'Find Duplicates' hook to override duplicate checking when registering/contributing
Matthew Wire (MJW Consulting) [Wed, 5 Dec 2018 18:10:54 +0000 (18:10 +0000)]
Add 'Find Duplicates' hook to override duplicate checking when registering/contributing

5 years agoMerge pull request #13649 from eileenmcnaughton/payment
Monish Deb [Fri, 22 Feb 2019 11:17:11 +0000 (16:47 +0530)]
Merge pull request #13649 from eileenmcnaughton/payment

Switch additional payment form to use Payment.sendconfirmation api

5 years agoMerge pull request #13661 from eileenmcnaughton/master
Eileen McNaughton [Fri, 22 Feb 2019 00:47:16 +0000 (13:47 +1300)]
Merge pull request #13661 from eileenmcnaughton/master

5.11 to master

5 years agoMerge branch '5.11' of https://github.com/civicrm/civicrm-core
eileen [Fri, 22 Feb 2019 00:46:16 +0000 (13:46 +1300)]
Merge branch '5.11' of https://github.com/civicrm/civicrm-core

5 years agoMerge pull request #13660 from seamuslee001/5.11
Eileen McNaughton [Fri, 22 Feb 2019 00:42:32 +0000 (13:42 +1300)]
Merge pull request #13660 from seamuslee001/5.11

5.11 - merge in security

5 years agoSwitch Additional Payment to call Payment.send_confirmation api, strip out text
eileen [Wed, 20 Feb 2019 13:13:44 +0000 (02:13 +1300)]
Switch Additional Payment to call Payment.send_confirmation api, strip out text

5 years agoSwitch to greeting for better, more consistent results in tpl, remove print statement
eileen [Wed, 20 Feb 2019 12:38:46 +0000 (01:38 +1300)]
Switch to greeting for better, more consistent results in tpl, remove print statement

5 years agoAdd test for receipt output (test written to pre-change output)
eileen [Wed, 20 Feb 2019 12:05:17 +0000 (01:05 +1300)]
Add test for receipt output (test written to pre-change output)

5 years agorelease-notes/5.10.3.md - Update "Feedback" to be... closer to reality wrt SA's
Tim Otten [Thu, 21 Feb 2019 06:38:50 +0000 (22:38 -0800)]
release-notes/5.10.3.md - Update "Feedback" to be... closer to reality wrt SA's

5 years agorelease-notes/5.10.3.md - TOC should match actual headings
Tim Otten [Thu, 21 Feb 2019 06:27:09 +0000 (22:27 -0800)]
release-notes/5.10.3.md - TOC should match actual headings

5 years agoAdd in 5.10.3 Security Release Notes
Seamus Lee [Sat, 16 Feb 2019 03:59:52 +0000 (14:59 +1100)]
Add in 5.10.3 Security Release Notes

5 years agoFix file e-notice by using the correct url variables
Seamus Lee [Tue, 19 Feb 2019 01:39:50 +0000 (12:39 +1100)]
Fix file e-notice by using the correct url variables

5 years agoFix variables to match image file hash generation
Seamus Lee [Wed, 13 Feb 2019 23:33:45 +0000 (10:33 +1100)]
Fix variables to match image file hash generation

5 years agoCRM_Profile_Form - Add fcs for download link on custom field
Tim Otten [Wed, 13 Feb 2019 22:34:33 +0000 (14:34 -0800)]
CRM_Profile_Form - Add fcs for download link on custom field

5 years ago(REF) Clearer docblocks and file names
Tim Otten [Wed, 13 Feb 2019 20:58:33 +0000 (12:58 -0800)]
(REF) Clearer docblocks and file names

5 years agoFix multiple issues with file URLs. Use clearer variables and docblocks to reduce...
Tim Otten [Wed, 13 Feb 2019 20:50:02 +0000 (12:50 -0800)]
Fix multiple issues with file URLs. Use clearer variables and docblocks to reduce confusion.

5 years agoTry and use the correct variable for file id in custom field uploads and use the...
Seamus Lee [Wed, 13 Feb 2019 20:09:26 +0000 (07:09 +1100)]
Try and use the correct variable for file id in custom field uploads and use the standard checksum timout as well

5 years agogenerateFileHash() - If we can't generate a secure, then don't generate any token
Tim Otten [Tue, 12 Feb 2019 23:58:57 +0000 (15:58 -0800)]
generateFileHash() - If we can't generate a secure, then don't generate any token

Falling back to a constant negates any security benefit of using a hash.

IMHO, the edge-case where `CIVICRM_SITE_KEY` is missing should be
obscure/rare and signifies broader problems for the deployment.  It needs to
be corrected.  If you're worried that having an error-symptom here is too
obscure, then let's add a more prominent error-message via
`CRM_Utils_Check`.

NOTE: There is one pre-existing case in core where (in absence of a key) it
procedes with a constant in lieu of a `CIVICRM_SITE_KEY` .  Specifically,
`CRM_Core_Error::generateLogFileHash()`.  That is not a good example to
follow because it is qualitiatively different:

* In `generateLogFileHash`(), `CIVICRM_SITE_KEY` functions as one of
  multiple redundant security mechanisms -- e.g.  even if
  `CIVICRM_SITE_KEY` is missing, the log file remains hard-to-access because
  (1) the DSN is part of the hash and (2) the httpd protects `ConfigAndLog`.
  (Contrast: The file-hash-code is not *redundant* in the same way.)

* In the context of logging, raising any error (even if it's real error
  condition) can provoke a weird loop (because then that error needs to be
  logged).  The log needs to avoid such loops.  (Contrast:
  `generateFileHash()` is part of the normal post-boot application logic, so
  it's free to register errors normally.)

5 years agogenerateFileHash() and validateFileHash() should be colocated
Tim Otten [Tue, 12 Feb 2019 23:50:40 +0000 (15:50 -0800)]
generateFileHash() and validateFileHash() should be colocated

The two functions (`generateFileHash()` and `validateFileHash()`) are
tightly-coupled.  Most changes to one would require a matching change in the
other.  So they should be parallel.

It'd be OK to say "the hash formula is a general utility for any party using
file APIs" (so put `generateFileHash()` and `validateFileHash()` in `CRM_Core_BAO_File`).

It'd be OK to say "the hash formula is specific to the end-point/page which
serves files" (so put `generateFileHash()` and `validateFileHash()` in
`CRM_Core_Page_File`).

The former feels a bit more accurate, so I pushed it toward that.

5 years agoSwitch to Sha256 and add in a ttl
Seamus Lee [Mon, 4 Feb 2019 21:48:25 +0000 (08:48 +1100)]
Switch to Sha256 and add in a ttl

Further WHIP fixing hmac implementation now need to get it generating consistant hashes

Remove debugging

5 years agoBlock access if no Hash is supplied
Seamus Lee [Tue, 22 Jan 2019 19:11:45 +0000 (06:11 +1100)]
Block access if no Hash is supplied

5 years agosecurity/core#26 Add in a generated Hash to download files so that URLs can't just...
Seamus Lee [Fri, 18 Jan 2019 22:01:17 +0000 (09:01 +1100)]
security/core#26 Add in a generated Hash to download files so that URLs can't just be tested by annon users

5 years agoprevent timing attacks on the contact checksum validation
Seamus Lee [Fri, 8 Feb 2019 03:46:36 +0000 (14:46 +1100)]
prevent timing attacks on the contact checksum validation

5 years agoRemove support for passing a filename into civicrm/file.
eileen [Mon, 14 Jan 2019 04:03:28 +0000 (17:03 +1300)]
Remove support for passing a filename into civicrm/file.

I can find no evidence this is used & it feels like a security risk, albeit they still need
the path

5 years agoRemove unused file parameters
eileen [Mon, 14 Jan 2019 01:25:29 +0000 (14:25 +1300)]
Remove unused file parameters

5 years agosecurity/core#33 - Patch jQuery for CVE-2015-9251
Coleman Watts [Wed, 23 Jan 2019 02:14:03 +0000 (21:14 -0500)]
security/core#33 - Patch jQuery for CVE-2015-9251

See https://github.com/jquery/jquery/issues/2432#issuecomment-403761229
This will no longer be needed after upgrading to jQuery 3.x.

5 years ago(NFC) Cleanup new docblocks
Tim Otten [Tue, 15 Jan 2019 00:01:26 +0000 (16:01 -0800)]
(NFC) Cleanup new docblocks

5 years agoFollow-up security/core#25 - Consistently change interface
Tim Otten [Mon, 14 Jan 2019 23:58:53 +0000 (15:58 -0800)]
Follow-up security/core#25 - Consistently change interface

The previous commit 4c1e702f96403bdc84b6900027d1be61ea601321 expanded the
signature of `fillWithSql()` to accept a third argument, but it wasn't
consistent about whether the third argument was optional or required.

This makes it consistently optional (default `[]`).

5 years agoResolve security/core#25 Escape use of cacheKey to prevent SQLI when populating the...
Seamus Lee [Sat, 27 Oct 2018 21:44:08 +0000 (08:44 +1100)]
Resolve security/core#25 Escape use of cacheKey to prevent SQLI when populating the prevNextCache

Security #25 Update Redis implementation to match function sig of interface function

5 years agosecurity/core#16 - Smarty - Fix XSS in crmMoney plugin
Patrick Figel [Sun, 6 Jan 2019 17:30:30 +0000 (18:30 +0100)]
security/core#16 - Smarty - Fix XSS in crmMoney plugin

This fixes an XSS in the crmMoney smarty plugin by checking the
currency against the currency list and adds some basic tests.

Fixes security/core#16

5 years agosecurity/core#28 - CRM_Contact - Use uniqid() for table alias
Patrick Figel [Sun, 6 Jan 2019 21:16:40 +0000 (22:16 +0100)]
security/core#28 - CRM_Contact - Use uniqid() for table alias

5 years agosecurity/core#28 - CRM_Contact - Fix SQL injection in group/tag search
Patrick Figel [Sat, 27 Oct 2018 19:08:32 +0000 (21:08 +0200)]
security/core#28 - CRM_Contact - Fix SQL injection in group/tag search

This fixes various SQL injections in CRM_Contact_BAO_Query in the group
and tag search code. CRM_Contact_BAO_Query is used by the API and some
other core features such as the advanced contact search.

For CRM_Contact_BAO_Query::tag, the lack of input validation meant that
API syntax that would typically not work for other parameters works for
tag search, so the fix attempts to not break backwards-compatibility
for API calls like Contact.get tag="1, 2" (i.e. using a comma-separated
list with spaces).

5 years agosecurity/core#32 Fix Reflected XSS in Logging Detail report
Seamus Lee [Sun, 30 Dec 2018 01:09:45 +0000 (12:09 +1100)]
security/core#32 Fix Reflected XSS in Logging Detail report

5 years agoAlso Purify the output of the frozen entity reference and that of a select2 output...
Seamus Lee [Sat, 27 Oct 2018 04:08:25 +0000 (15:08 +1100)]
Also Purify the output of the frozen entity reference and that of a select2 output as well

5 years agoResolve #9 by purifying label of entity reference values
Seamus Lee [Tue, 3 Jul 2018 23:49:35 +0000 (09:49 +1000)]
Resolve #9 by purifying label of entity reference values

5 years agoMerge pull request #13659 from francescbassas/patch-16
Seamus Lee [Thu, 21 Feb 2019 23:55:17 +0000 (10:55 +1100)]
Merge pull request #13659 from francescbassas/patch-16

/dev/core#716 - Add decimals in Contribution Amount on Repeat Contrib…

5 years agoMerge pull request #13650 from eileenmcnaughton/order_by
Seamus Lee [Thu, 21 Feb 2019 23:50:21 +0000 (10:50 +1100)]
Merge pull request #13650 from eileenmcnaughton/order_by

[REF] minor code cleanup - do not build order var just to hurt brains

5 years ago/dev/core#716 - Add decimals in Contribution Amount on Repeat Contributions Report
francescbassas [Thu, 21 Feb 2019 22:33:32 +0000 (23:33 +0100)]
/dev/core#716 - Add decimals in Contribution Amount on Repeat Contributions Report

5 years agoMerge pull request #13656 from eileenmcnaughton/search_query
colemanw [Thu, 21 Feb 2019 14:26:14 +0000 (09:26 -0500)]
Merge pull request #13656 from eileenmcnaughton/search_query

[REF] minor cleanup of groupBy definition.

5 years ago[REF] minor cleanup of groupBy definition.
eileen [Thu, 21 Feb 2019 09:33:59 +0000 (22:33 +1300)]
[REF] minor cleanup of groupBy definition.

If you read the code the groupBy statement creation can go with 'its friends'
and the groupBy in the removed line is overwritten. I'll extract this next ....

5 years agoMerge pull request #13655 from eileenmcnaughton/payment_receipt
Monish Deb [Thu, 21 Feb 2019 08:34:46 +0000 (14:04 +0530)]
Merge pull request #13655 from eileenmcnaughton/payment_receipt

Update Payment Notification to use greeting, remove text to 'Please print this confirmation for your records.

5 years agoUpdate Payment Notification to use greeting, to not encourage printing
eileen [Thu, 21 Feb 2019 01:56:56 +0000 (14:56 +1300)]
Update Payment Notification to use greeting, to not encourage printing

These changes are consistent with other changes. I also switched the parameters for when to include
extra detail to deprecate contributeMode

5 years ago[REF] minor code cleanup - do not build order var just to hurt brains
eileen [Wed, 20 Feb 2019 13:33:13 +0000 (02:33 +1300)]
[REF] minor code cleanup - do not build order var just to hurt brains

The order var is basically orderBy prepended by Order by - which is then stripped.

Just don't

5 years agoMerge pull request #13610 from eileenmcnaughton/payment_conf2
Monish Deb [Wed, 20 Feb 2019 11:54:59 +0000 (17:24 +0530)]
Merge pull request #13610 from eileenmcnaughton/payment_conf2

Payment.sendconfirmation api - add further tpl variables.

5 years agoMerge pull request #13642 from eileenmcnaughton/atest
Seamus Lee [Wed, 20 Feb 2019 00:48:15 +0000 (11:48 +1100)]
Merge pull request #13642 from eileenmcnaughton/atest

Authorizenet test - reduce chance of intermittent fails

5 years agoAuthorizenet test - reduce chance of intermittent fails
eileen [Tue, 19 Feb 2019 23:07:26 +0000 (12:07 +1300)]
Authorizenet test - reduce chance of intermittent fails

I just saw this fail https://developer.authorize.net/api/reference/responseCodes.html?code=E00012
It seems we've already added uniqueness but we still hit a fail. Hopefully the timestamp
nature of uniqid + adding an extra degree of randomness will eliminate.

Also removed some deprecated params

5 years agoUpdate status comments
eileen [Fri, 15 Feb 2019 20:57:44 +0000 (09:57 +1300)]
Update status comments

5 years agoPayment.sendconfirmation - add tpl var for fully paid
eileen [Fri, 15 Feb 2019 20:51:51 +0000 (09:51 +1300)]
Payment.sendconfirmation - add tpl var for fully paid

5 years agoAdd thousandseparator variant to test
eileen [Fri, 15 Feb 2019 20:40:54 +0000 (09:40 +1300)]
Add thousandseparator variant to test

5 years agoAdd refund relevant fields & tests to payment.sendconfirmation
eileen [Fri, 15 Feb 2019 20:35:50 +0000 (09:35 +1300)]
Add refund relevant fields & tests to payment.sendconfirmation

5 years agoMerge pull request #13620 from eileenmcnaughton/signuptype
Seamus Lee [Tue, 19 Feb 2019 19:42:21 +0000 (06:42 +1100)]
Merge pull request #13620 from eileenmcnaughton/signuptype

[unused code cleanup] Remove unused 'signupType' url support

5 years agoMerge pull request #13609 from eileenmcnaughton/payment_conf
Monish Deb [Tue, 19 Feb 2019 08:45:55 +0000 (14:15 +0530)]
Merge pull request #13609 from eileenmcnaughton/payment_conf

Payment.sendconfirmation api - add further tpl variables.

5 years agoMerge pull request #13534 from yashodha/dev-696
Eileen McNaughton [Tue, 19 Feb 2019 06:57:28 +0000 (19:57 +1300)]
Merge pull request #13534 from yashodha/dev-696

(dev/core#696) Changes to copied event phone and email reflects in or…

5 years agoMerge pull request #13639 from civicrm/5.11
Eileen McNaughton [Tue, 19 Feb 2019 06:54:27 +0000 (19:54 +1300)]
Merge pull request #13639 from civicrm/5.11

5.11

5 years agoMerge pull request #13636 from eileenmcnaughton/strtolower
Seamus Lee [Tue, 19 Feb 2019 05:46:05 +0000 (16:46 +1100)]
Merge pull request #13636 from eileenmcnaughton/strtolower

Remove another instance of 'lower'

5 years agoMerge pull request #13637 from jitendrapurohit/core737
Seamus Lee [Tue, 19 Feb 2019 05:44:08 +0000 (16:44 +1100)]
Merge pull request #13637 from jitendrapurohit/core737

dev/core#737 - SMS not sent if 'Send Immediately' option is chosen on…

5 years agodev/core#737 - SMS not sent if 'Send Immediately' option is chosen on the last screen
Jitendra Purohit [Tue, 19 Feb 2019 04:02:20 +0000 (09:32 +0530)]
dev/core#737 - SMS not sent if 'Send Immediately' option is chosen on the last screen

5 years agoRemove another instance of 'lower'
eileen [Tue, 19 Feb 2019 03:38:41 +0000 (16:38 +1300)]
Remove another instance of 'lower'

We have removed almost all of these from the code base due to the performance cost
combined with the lack of any upside. Just found another

5 years agoMerge pull request #13630 from eileenmcnaughton/goodbye_mode_and_median_hello_speed
colemanw [Tue, 19 Feb 2019 01:36:17 +0000 (20:36 -0500)]
Merge pull request #13630 from eileenmcnaughton/goodbye_mode_and_median_hello_speed

dev/core#720 Remove median & mode stats from contribution summary in order to improve performance

5 years agoMerge pull request #13629 from eileenmcnaughton/mailing_job_test_use
colemanw [Mon, 18 Feb 2019 17:40:03 +0000 (12:40 -0500)]
Merge pull request #13629 from eileenmcnaughton/mailing_job_test_use

[Test changes] Mailing job test use

5 years agoMerge pull request #13543 from mlutfy/fixDefaultPDFFormat
colemanw [Mon, 18 Feb 2019 17:27:28 +0000 (12:27 -0500)]
Merge pull request #13543 from mlutfy/fixDefaultPDFFormat

Fix html2pdf default PDF format when multiple pdf_format are available.

5 years agoMerge pull request #13631 from colemanw/entityRefs3
Eileen McNaughton [Mon, 18 Feb 2019 07:18:43 +0000 (20:18 +1300)]
Merge pull request #13631 from colemanw/entityRefs3

 EntityRef - standardize on PascalCase for entity name and fix minor bug

5 years agoMerge pull request #13632 from colemanw/CRM_Report_Form_Event
Eileen McNaughton [Mon, 18 Feb 2019 07:18:30 +0000 (20:18 +1300)]
Merge pull request #13632 from colemanw/CRM_Report_Form_Event

[REF] Remove useless class CRM_Report_Form_Event

5 years agoRemove multiple currency handling as it seems to make it format worse
eileen [Mon, 18 Feb 2019 01:17:37 +0000 (14:17 +1300)]
Remove multiple currency handling as it seems to make it format worse

5 years agoDeprecate computeStats off to the one place that still uses it.
eileen [Mon, 18 Feb 2019 00:36:39 +0000 (13:36 +1300)]
Deprecate computeStats off to the one place that still uses it.

We MIGHT have reports calling it so to avoid a fatal we will not remove the function just yet

5 years agoRemove median & mode stats from contribution summary in order to improve performance
eileen [Mon, 18 Feb 2019 00:31:00 +0000 (13:31 +1300)]
Remove median & mode stats from contribution summary in order to improve performance

5 years agoMerge pull request #13579 from mattwire/contributionrecur_metadata
Eileen McNaughton [Mon, 18 Feb 2019 04:31:18 +0000 (17:31 +1300)]
Merge pull request #13579 from mattwire/contributionrecur_metadata

Contribution/ContributionRecur metadata updates for EntityForm

5 years agoRemove useless class CRM_Report_Form_Event
Coleman Watts [Mon, 18 Feb 2019 04:16:36 +0000 (23:16 -0500)]
Remove useless class CRM_Report_Form_Event

5 years agoUse PascalCase with CRM_Core_Form::addEntityRef
Coleman Watts [Mon, 18 Feb 2019 03:55:21 +0000 (22:55 -0500)]
Use PascalCase with CRM_Core_Form::addEntityRef

Although entityRef fields accept either snake_case or CamelCase, let's be consistent.

5 years agoEntityRef: Fix caching filter option lists
Coleman Watts [Mon, 18 Feb 2019 03:46:27 +0000 (22:46 -0500)]
EntityRef: Fix caching filter option lists

The filters objects were getting cloned instead of passed by reference,
which prevented loadEntityRefFilterOptions() from saving the list for reuse.

5 years agoEntityRef - standardize on PascalCase for entity name
Coleman Watts [Mon, 18 Feb 2019 00:56:00 +0000 (19:56 -0500)]
EntityRef - standardize on PascalCase for entity name

5 years agoChange the call used to generate recipients in unit tests
eileen [Mon, 18 Feb 2019 00:26:53 +0000 (13:26 +1300)]
Change the call used to generate recipients in unit tests

Passes in scheduled_date (as the 'real' api call would)

Part of this attempted deprecation #13627

5 years agoMerge pull request #13607 from eileenmcnaughton/cont_summary_extract
colemanw [Mon, 18 Feb 2019 00:23:43 +0000 (19:23 -0500)]
Merge pull request #13607 from eileenmcnaughton/cont_summary_extract

dev/core#720 [REF] refactor out components of contributionSummary function

5 years agoMerge pull request #13628 from colemanw/entityRefs2
Eileen McNaughton [Sun, 17 Feb 2019 23:02:23 +0000 (12:02 +1300)]
Merge pull request #13628 from colemanw/entityRefs2

Standardize format for entityRef create links

5 years agoMove output formatting to the relevant functions
eileen [Sun, 17 Feb 2019 04:16:33 +0000 (17:16 +1300)]
Move output formatting to the relevant functions

5 years agoRemove duplicate setting of variables
eileen [Fri, 15 Feb 2019 03:39:55 +0000 (16:39 +1300)]
Remove duplicate setting of variables

5 years agoMerge pull request #13624 from eileenmcnaughton/minor_pdf_utl_cleanup
Eileen McNaughton [Sun, 17 Feb 2019 22:13:19 +0000 (11:13 +1300)]
Merge pull request #13624 from eileenmcnaughton/minor_pdf_utl_cleanup

[Code cleanup] Remove unused $stationery_path parameter

5 years agoMerge pull request #13626 from eileenmcnaughton/cont_summary_extract1
Eileen McNaughton [Sun, 17 Feb 2019 22:11:23 +0000 (11:11 +1300)]
Merge pull request #13626 from eileenmcnaughton/cont_summary_extract1

[REF] extract cancelled stats to own function

5 years agoStandardize format for entityRef create links
Coleman Watts [Sun, 17 Feb 2019 21:42:26 +0000 (16:42 -0500)]
Standardize format for entityRef create links

5 years agoMerge pull request #13625 from colemanw/entityRefs
Eileen McNaughton [Sun, 17 Feb 2019 21:29:20 +0000 (10:29 +1300)]
Merge pull request #13625 from colemanw/entityRefs

[REF] Move entityRef filters into their respective BAOs

5 years ago[REF] extract cancelled stats to own function
eileen [Fri, 15 Feb 2019 03:32:47 +0000 (16:32 +1300)]
[REF] extract cancelled stats to own function

5 years agoRemove unused parameter
eileen [Sun, 17 Feb 2019 07:57:06 +0000 (20:57 +1300)]
Remove unused  parameter

5 years agoMove entityRef filters into their respective BAOs
Coleman Watts [Sun, 17 Feb 2019 19:20:09 +0000 (14:20 -0500)]
Move entityRef filters into their respective BAOs

5 years agoMerge pull request #13622 from eileenmcnaughton/cont_summary_extract1
colemanw [Sun, 17 Feb 2019 18:01:08 +0000 (13:01 -0500)]
Merge pull request #13622 from eileenmcnaughton/cont_summary_extract1

[REF] extract basic soft credit stats to separate function

5 years agoMerge pull request #13621 from eileenmcnaughton/default_wrong_declared
colemanw [Sun, 17 Feb 2019 17:59:55 +0000 (12:59 -0500)]
Merge pull request #13621 from eileenmcnaughton/default_wrong_declared

[code cleanup] Default wrong declared

5 years agoMerge pull request #13619 from eileenmcnaughton/unused_pending_param
colemanw [Sun, 17 Feb 2019 17:58:55 +0000 (12:58 -0500)]
Merge pull request #13619 from eileenmcnaughton/unused_pending_param

[REF] Remove unused function parameter

5 years agoMerge pull request #13623 from eileenmcnaughton/comment
colemanw [Sun, 17 Feb 2019 17:37:56 +0000 (12:37 -0500)]
Merge pull request #13623 from eileenmcnaughton/comment

Remove long block of commented out code from 4 years ago

5 years agoMerge pull request #13601 from alexymik/patch-1
Eileen McNaughton [Sun, 17 Feb 2019 07:39:47 +0000 (20:39 +1300)]
Merge pull request #13601 from alexymik/patch-1

Always load recaptcha JS over HTTPS

5 years agoMerge pull request #13499 from mattwire/profilecontact_nocontactid_subtype
Eileen McNaughton [Sun, 17 Feb 2019 07:34:03 +0000 (20:34 +1300)]
Merge pull request #13499 from mattwire/profilecontact_nocontactid_subtype

If a profile is used to create a contact with a subtype the contact will not have any existing subtypes

5 years agoRemove long block of commented out code from 4 years ago
eileen [Sun, 17 Feb 2019 05:26:21 +0000 (18:26 +1300)]
Remove long block of commented out code from 4 years ago

5 years ago[REF] extract basic soft credit stats to separate function
eileen [Fri, 15 Feb 2019 03:26:24 +0000 (16:26 +1300)]
[REF] extract basic soft credit stats to separate function

5 years agoAs previously commented this array is never used.
eileen [Sun, 17 Feb 2019 05:18:33 +0000 (18:18 +1300)]
As previously commented this array is never used.

I did a codebase grep on ->defaults & am pretty confident here....

5 years agoMerge pull request #13618 from eileenmcnaughton/test_info
colemanw [Sun, 17 Feb 2019 05:18:27 +0000 (00:18 -0500)]
Merge pull request #13618 from eileenmcnaughton/test_info

[Test support] Add extra output info when getsingle fails as this seems to be common  in intermittant fails

5 years agoMerge pull request #13616 from eileenmcnaughton/cont_summary_extract1
colemanw [Sun, 17 Feb 2019 05:16:36 +0000 (00:16 -0500)]
Merge pull request #13616 from eileenmcnaughton/cont_summary_extract1

[REF] extract add median to stats

5 years agoRemove unused 'signupType' url support
eileen [Sun, 17 Feb 2019 05:05:04 +0000 (18:05 +1300)]
Remove unused 'signupType' url support

The use of this was removed in https://github.com/civicrm/civicrm-core/pull/911
on the basis it didn't work.

This is just cleanup not done then.

(Note we shouldn't comment stuff out we should remove it as a rule)

5 years agoRemove unused function parameter
eileen [Sun, 17 Feb 2019 04:01:19 +0000 (17:01 +1300)]
Remove unused function parameter

The function getContributionParams was created as part of a larger refactoring/
code cleanup effort. One of those goals was to get to a point
where contributions are always created with a pending status and are later
confirmed when a payment is added.

It if only called from one place and TRUE is always passed for
so we no longer need the  parameter in this function, remove it

5 years agoAdd extra output info when getsingle fails as this seems to be common in intermittant...
eileen [Sun, 17 Feb 2019 03:41:35 +0000 (16:41 +1300)]
Add extra output info when getsingle fails as this seems to be common in intermittant fails

5 years agoMerge pull request #13617 from eileenmcnaughton/no_dead_service_tests
Eileen McNaughton [Sun, 17 Feb 2019 03:36:03 +0000 (16:36 +1300)]
Merge pull request #13617 from eileenmcnaughton/no_dead_service_tests

Remove tests that no longer work due to dead service

5 years ago[REF] extract add median to stats
eileen [Fri, 15 Feb 2019 02:03:27 +0000 (15:03 +1300)]
[REF] extract add median to stats

5 years agoRemove tests that no longer work due to dead service
eileen [Sun, 17 Feb 2019 01:42:47 +0000 (14:42 +1300)]
Remove tests that no longer work due to dead service