Coleman Watts [Thu, 14 Apr 2022 02:44:47 +0000 (22:44 -0400)]
SearchKit - Support operators, custom fields & multiple fields in a searchSegment clause.
Coleman Watts [Wed, 13 Apr 2022 23:12:21 +0000 (19:12 -0400)]
APIv4 - Pass entire Api4SelectQuery object to expression when rendering
This permits SearchSegment pseudo-fields to call $query->getField() on multiple
fields, including custom fields, while rendering.
Coleman Watts [Wed, 30 Mar 2022 12:55:00 +0000 (08:55 -0400)]
SearchKit - Fix ORDER BY calculated fields when using GROUP BY
Before: Calculated field functions were repeated verbabim in the SELECT, ORDER BY & GROUP BY clause,
this would cause mySql error when using FULL GROUP BY mode.
After: Calculated field function defined in SELECT clause, alias used in ORDER BY & GROUP BY.
No error when grouping by an ordering by the same calculated field.
Side-benefit: When selecting and ordering by RAND(), the selected random numbers will be in order,
as it's now the same random function used for both instead of a different one.
Coleman Watts [Wed, 30 Mar 2022 01:55:35 +0000 (21:55 -0400)]
SearchKit - Add basic SearchSegment functionality for numeric range groups
Coleman Watts [Tue, 29 Mar 2022 02:39:27 +0000 (22:39 -0400)]
SearchKit - Add SearchSegment entity & table
demeritcowboy [Thu, 14 Apr 2022 12:33:32 +0000 (08:33 -0400)]
Merge pull request #23194 from eileenmcnaughton/ds2
Remove unused parameter from private function
demeritcowboy [Thu, 14 Apr 2022 12:30:48 +0000 (08:30 -0400)]
Merge pull request #23200 from eileenmcnaughton/unused
Remove unused function
Monish Deb [Thu, 14 Apr 2022 08:20:50 +0000 (13:50 +0530)]
Merge pull request #23157 from eileenmcnaughton/anet
Minor readability improvement
Eileen McNaughton [Thu, 14 Apr 2022 06:42:43 +0000 (18:42 +1200)]
Merge pull request #23203 from civicrm/5.49
5.49 to master
Eileen McNaughton [Thu, 14 Apr 2022 06:41:46 +0000 (18:41 +1200)]
Merge pull request #23177 from JMAConsulting/booleanFields_1
(REF) Schema - Correct boolean fields in various tables
Seamus Lee [Thu, 14 Apr 2022 06:22:02 +0000 (16:22 +1000)]
Merge pull request #23201 from civicrm/5.49
5.49
Eileen McNaughton [Thu, 14 Apr 2022 05:12:50 +0000 (17:12 +1200)]
Merge pull request #23197 from seamuslee001/5.49
[REF] Regenerate civicrm_generated data
Eileen McNaughton [Thu, 14 Apr 2022 05:10:14 +0000 (17:10 +1200)]
Remove unused function
Monish Deb [Sat, 9 Apr 2022 02:05:54 +0000 (07:35 +0530)]
revert Menu.is_public requiredness
Monish Deb [Thu, 14 Apr 2022 04:20:53 +0000 (09:50 +0530)]
Merge pull request #23158 from eileenmcnaughton/fail
[REF] Extract getContributionRecurID
Monish Deb [Thu, 14 Apr 2022 04:10:13 +0000 (09:40 +0530)]
Merge pull request #22571 from eileenmcnaughton/trxn
Improve financial trxn spec to require required fields
Eileen McNaughton [Thu, 14 Apr 2022 04:03:44 +0000 (16:03 +1200)]
Merge pull request #23196 from civicrm/5.49
5.49 to master
Seamus Lee [Thu, 14 Apr 2022 03:31:33 +0000 (13:31 +1000)]
[REF] Regenerate civicrm_generated data
Seamus Lee [Thu, 14 Apr 2022 03:24:39 +0000 (13:24 +1000)]
Merge pull request #23192 from eileenmcnaughton/549
Fix FiveFortyNine is_public to default to 0
Eileen McNaughton [Thu, 14 Apr 2022 02:30:23 +0000 (14:30 +1200)]
Merge pull request #23189 from alifrumin/rn5.49
[NFC] First Pass at Release notes for 5.49
Eileen McNaughton [Thu, 14 Apr 2022 01:41:44 +0000 (13:41 +1200)]
Remove unused parameter from private function
Eileen McNaughton [Thu, 14 Apr 2022 01:24:22 +0000 (13:24 +1200)]
Merge pull request #23191 from twomice/3164_report_show_filter_criteria_zero
dev/core#3164 : Report Filter Statistics don't show filters with vaue of "0"
Eileen McNaughton [Wed, 19 Jan 2022 04:20:39 +0000 (17:20 +1300)]
Improve financial trxn spec to require required fields
It turns out the apiv4 conformance test only passes because it
is bypassing the BAO create method - which requires more parameters
Not this will fail :-( because it messes with the test expectations
- I don't know how to create complex valid test data for it though....
I guess we could create a contribution & pass it as entity_id
Alice Frumin [Wed, 13 Apr 2022 01:16:15 +0000 (21:16 -0400)]
[NFC] 5.49 release notes first pass
Eileen McNaughton [Wed, 13 Apr 2022 23:50:53 +0000 (11:50 +1200)]
Fix FiveFortyNine is_public to default to 0
Allen Shaw [Wed, 13 Apr 2022 23:24:21 +0000 (18:24 -0500)]
dev/core#3164 : Report Filter Statistics don't show filters with value of "0"
Eileen McNaughton [Wed, 13 Apr 2022 21:10:09 +0000 (09:10 +1200)]
Merge pull request #23139 from kurund/group-subscription-confirmation-email
send group subscription welcome email only if template is enabled
demeritcowboy [Wed, 13 Apr 2022 18:09:31 +0000 (14:09 -0400)]
Merge pull request #23188 from colemanw/jsFix
Cleanup crmMailing/Templates.js
Coleman Watts [Wed, 13 Apr 2022 16:01:59 +0000 (12:01 -0400)]
Cleanup crmMailing/Templates.js
colemanw [Wed, 13 Apr 2022 02:27:42 +0000 (22:27 -0400)]
Merge pull request #23180 from eileenmcnaughton/csv
dev/core#3172 Update phpleague/csv from 9.2 to 9.6 (supports php 8)
colemanw [Wed, 13 Apr 2022 00:24:37 +0000 (20:24 -0400)]
Merge pull request #23172 from eileenmcnaughton/import_most
Further simplify variable retrieval
Eileen McNaughton [Tue, 12 Apr 2022 23:50:31 +0000 (11:50 +1200)]
Merge pull request #23181 from civicrm/5.49
5.49 to master
Eileen McNaughton [Tue, 12 Apr 2022 23:50:08 +0000 (11:50 +1200)]
Merge pull request #23179 from totten/5.49-grant-entities
(dev/core#3161) CiviGrant - Cleanup managed entities (5.49-rc)
Eileen McNaughton [Tue, 12 Apr 2022 23:35:45 +0000 (11:35 +1200)]
dev/core#3172 Update phpleague/csv from 9.2 to 9.6 (supports php 8)
Eileen McNaughton [Tue, 12 Apr 2022 23:24:30 +0000 (11:24 +1200)]
Merge pull request #23082 from agileware/CIVICRM-1958
🪲 🪳 Bug Fix: The option "Enable multiple bulk email address for a contact" does not apply when editing a Contact, only works for inline edit of email addresses
Coleman Watts [Tue, 12 Apr 2022 15:31:02 +0000 (11:31 -0400)]
CiviGrant - Remove unused managed entities during upgrade
Removes managed entities which may have been added during the 5.47 upgrade,
to prevent the managed system from automatically deleting them.
Coleman Watts [Fri, 8 Apr 2022 13:47:51 +0000 (09:47 -0400)]
CiviGrant - Cleanup managed entities - fixes dev/core#3161
- Ensure labels are translated
- Set stricter cleanup policy for entities that should be removed on uninstall
- Make grant_status options unmanaged. They will not be updated by the system ever,
but they will be deleted on uninstall because the option group is a managed entity.
Eileen McNaughton [Tue, 12 Apr 2022 19:12:29 +0000 (07:12 +1200)]
Merge pull request #23174 from braders/nodefaults-contrib-links
Contribution dashboard links work in escape-on-output mode
Eileen McNaughton [Tue, 12 Apr 2022 19:11:12 +0000 (07:11 +1200)]
Merge pull request #23178 from civicrm/5.49
5.49 to master
Eileen McNaughton [Tue, 12 Apr 2022 19:09:58 +0000 (07:09 +1200)]
Merge pull request #23176 from agh1/5.49.0-releasenotes-initial
5.49.0 release notes initial run
Eileen McNaughton [Tue, 12 Apr 2022 19:00:55 +0000 (07:00 +1200)]
Merge pull request #23175 from pradpnayak/limitcontacts
Limit issue when printing pdf from contribution search
Andie Hunt [Tue, 12 Apr 2022 17:00:31 +0000 (13:00 -0400)]
5.49.0 release notes: added boilerplate
Andie Hunt [Tue, 12 Apr 2022 16:23:20 +0000 (12:23 -0400)]
5.49.0 release notes: raw from script
colemanw [Tue, 12 Apr 2022 15:07:30 +0000 (11:07 -0400)]
Merge pull request #23173 from braders/escape-on-output-event-links
Add smarty:nodefaults to ManageEvent page.
Pradeep Nayak [Tue, 12 Apr 2022 13:13:45 +0000 (14:13 +0100)]
Fix limit issue
Bradley Taylor [Tue, 12 Apr 2022 06:51:12 +0000 (07:51 +0100)]
Contrib dashboard links work in escape-on-output mode
Bradley Taylor [Tue, 12 Apr 2022 06:41:42 +0000 (07:41 +0100)]
Add smarty:nodefaults to ManageEvent page.
This ensures that the links render correctly in escape-on-output mode.
Eileen McNaughton [Tue, 12 Apr 2022 02:49:22 +0000 (14:49 +1200)]
Simplify more variables
Eileen McNaughton [Mon, 11 Apr 2022 23:42:04 +0000 (11:42 +1200)]
Simplify value retrieval
Eileen McNaughton [Tue, 12 Apr 2022 02:33:07 +0000 (14:33 +1200)]
Merge pull request #23171 from eileenmcnaughton/saved_map
Remove some copy & paste
Tim Otten [Tue, 12 Apr 2022 00:48:00 +0000 (17:48 -0700)]
Merge pull request #23169 from totten/master-authx-info
(NFC) authx - Update descriptions and links in `info.xml`
Eileen McNaughton [Tue, 12 Apr 2022 00:45:28 +0000 (12:45 +1200)]
Remove some copy & paste
colemanw [Mon, 11 Apr 2022 23:35:48 +0000 (19:35 -0400)]
Merge pull request #23135 from eileenmcnaughton/memm
Centralise skipColumnHeader to one function (fixes notices, cleans code)
colemanw [Mon, 11 Apr 2022 23:28:24 +0000 (19:28 -0400)]
Merge pull request #23168 from totten/master-ver-compat
(Re-)Set version to 5.50.alpha1
Eileen McNaughton [Mon, 11 Apr 2022 23:28:22 +0000 (11:28 +1200)]
Merge pull request #23166 from pradpnayak/limitcontacts
Set limit to 0 when processing send sms task
colemanw [Mon, 11 Apr 2022 23:24:38 +0000 (19:24 -0400)]
Merge pull request #23165 from eileenmcnaughton/ref
Reduce use of reference
Tim Otten [Mon, 11 Apr 2022 22:47:52 +0000 (15:47 -0700)]
(NFC) authx - Update descriptions and links in `info.xml`
Pradeep Nayak [Mon, 11 Apr 2022 20:56:30 +0000 (21:56 +0100)]
Set limit to 0 when processing send sms task
Tim Otten [Mon, 11 Apr 2022 21:42:11 +0000 (14:42 -0700)]
Set version to 5.50.alpha1
Tim Otten [Mon, 11 Apr 2022 21:44:34 +0000 (14:44 -0700)]
Merge pull request #23143 from colemanw/extVersion
Release - Set version compatibility for core extensions when updating core
Eileen McNaughton [Fri, 8 Apr 2022 00:40:07 +0000 (12:40 +1200)]
Centralise skipColumnHeader to one function
Eileen McNaughton [Mon, 11 Apr 2022 19:53:08 +0000 (07:53 +1200)]
Reduce use of reference
Reference does not make sense for objects. assign_by_ref does not make
sense when not used again in the function or returned in a reffy kinda way
Eileen McNaughton [Mon, 11 Apr 2022 19:34:44 +0000 (07:34 +1200)]
Merge pull request #23101 from MegaphoneJon/core-1836-js
core#1836 - restrict scheduled reminder 'Also Include' to non-events
Eileen McNaughton [Mon, 11 Apr 2022 19:31:46 +0000 (07:31 +1200)]
Merge pull request #23163 from mlutfy/fixTsEventSv
getSelfServiceEligibility: fix string translation
demeritcowboy [Mon, 11 Apr 2022 18:37:58 +0000 (14:37 -0400)]
Merge pull request #23155 from eileenmcnaughton/ret2
Remove-single-value-loop
demeritcowboy [Mon, 11 Apr 2022 18:30:05 +0000 (14:30 -0400)]
Merge pull request #23162 from agileware/additional-not-additonal
✍🏼 Fix spelling of "additional". Numerous uses of "additonal"
Mathieu Lutfy [Mon, 11 Apr 2022 17:58:26 +0000 (13:58 -0400)]
getSelfServiceEligibility: fix string translation
Justin Freeman [Mon, 11 Apr 2022 03:51:25 +0000 (13:51 +1000)]
Fix spelling of additional
Eileen McNaughton [Mon, 11 Apr 2022 01:33:26 +0000 (13:33 +1200)]
[REF] Extract getContributionRecurID
Eileen McNaughton [Mon, 11 Apr 2022 01:16:11 +0000 (13:16 +1200)]
Minor readability improvement
This just adds isSuccess as a function to avoid having to understand what
response code is.
I grepped & didn't find 'response_code' outside the class/test
I also confirmed that the retrieve function casts to an int (via
validate) so the triple = is correct
Eileen McNaughton [Sun, 10 Apr 2022 23:26:31 +0000 (11:26 +1200)]
Merge pull request #23141 from totten/master-mailing-verify
(dev/mail#107) CiviMail - Fix validation error (5.49)
Eileen McNaughton [Sun, 10 Apr 2022 23:21:51 +0000 (11:21 +1200)]
Merge pull request #22159 from colemanw/isCurrentDomain
APIv4 - Add `is_active` extra field to Domain entity
Eileen McNaughton [Sun, 10 Apr 2022 23:20:24 +0000 (11:20 +1200)]
Merge pull request #23144 from colemanw/noMoreSaveButtonInApiExplorer
API4 Explorer - Remove confusing "Save" button
Eileen McNaughton [Sun, 10 Apr 2022 23:12:44 +0000 (11:12 +1200)]
Remove-single-value-loop
The communicationType array only has one value. This removes the foreach, swapping
the values for the only value they could be. This resulted in 2 always-true
ifs being replaced too
Eileen McNaughton [Sun, 10 Apr 2022 23:03:26 +0000 (11:03 +1200)]
Merge pull request #23149 from colemanw/searchIcons
Add icons for SavedSearch and SearchDisplay entities
Eileen McNaughton [Sun, 10 Apr 2022 23:02:25 +0000 (11:02 +1200)]
Merge pull request #23150 from braders/deleteurl-ensure-variable
Ensure deleteURL variable for ContactImage.tpl
Eileen McNaughton [Sun, 10 Apr 2022 23:01:51 +0000 (11:01 +1200)]
Merge pull request #23153 from braders/nodefaults-default-form
Add smarty:nodefaults to default.tpl form.
demeritcowboy [Sun, 10 Apr 2022 22:39:41 +0000 (18:39 -0400)]
Merge pull request #23154 from civicrm/5.49
5.49
Seamus Lee [Sun, 10 Apr 2022 22:11:45 +0000 (08:11 +1000)]
Merge pull request #23152 from braders/row-weight-nodefaults
Don't overescape weights in default-escape mode
demeritcowboy [Sun, 10 Apr 2022 19:34:28 +0000 (15:34 -0400)]
Merge pull request #23151 from braders/financialaccount-notices
Avoid PHP notices on FinancialAccount table
demeritcowboy [Sun, 10 Apr 2022 19:17:02 +0000 (15:17 -0400)]
Merge pull request #23148 from totten/5.48-cache-ver-suffix
(dev/core#3166) "Metadata" cache - Strictly separate by version
demeritcowboy [Sun, 10 Apr 2022 19:16:10 +0000 (15:16 -0400)]
Merge pull request #22967 from eileenmcnaughton/ret2
[REF] Code cleanup on location entities for the Contact Summary screen
Bradley Taylor [Sun, 10 Apr 2022 15:19:26 +0000 (16:19 +0100)]
Add smarty:nodefaults to default.tpl form.
This allows core forms (e.g. search forms) to submit correctly,
even with CIVICRM_SMARTY_DEFAULT_ESCAPE mode.
Without this change, quote marks were turned into HTML attributes,
meaning the form essentially had no method or action.
Bradley Taylor [Sun, 10 Apr 2022 10:16:01 +0000 (11:16 +0100)]
Don't overescape weights in default-escape mode
Bradley Taylor [Sun, 10 Apr 2022 09:50:34 +0000 (10:50 +0100)]
Avoid PHP notices on FinancialAccount table
Bradley Taylor [Sun, 10 Apr 2022 08:09:06 +0000 (09:09 +0100)]
Ensure deleteURL variable for ContactImage.tpl
Coleman Watts [Sun, 10 Apr 2022 00:40:49 +0000 (20:40 -0400)]
Add icons for SavedSearch and SearchDisplay entities
CiviCRM [Sat, 9 Apr 2022 21:41:10 +0000 (21:41 +0000)]
Set version to 5.50.alpha1
CiviCRM [Sat, 9 Apr 2022 21:38:59 +0000 (21:38 +0000)]
Set version to 5.49.beta1
Tim Otten [Sat, 9 Apr 2022 20:23:56 +0000 (13:23 -0700)]
(dev/core#3166) "Metadata" cache - Strictly separate by version
This addresses some symptoms identified in the discussion of 3166.
Before
------
The "metadata" cache is always stored with the name `metadata`.
If you load a newer codebase, it still reads `metadata` from the older code base (until something explicitly clears the cache).
After
-----
The "metadata" cache is always stored with the name `metadata_{version}`, eg `metadata_5_48_0`.
If you load a newer codebase (eg `5.49.0`), it will ignore the older `metadata_5_48_0` and create a new `metadata_5_49_0`.
Comments
--------
The upgrade system also clears cache, but many users rely on navigating through the site to get to the upgrader.
The change could make sense with other caches, but I only applied the change to the `metadata` cache because there is _some_ risk;
eg if some caller bypasses the cache objects. (I was also slightly concerned about the possibility the some caller relies
on `$cache->getName()` or `$cache->getPrefix()` or similar... but I haven't been able to find any methods like that...). It seems
safer to put that sort of change into a monthly update rather than minor patch.
colemanw [Sat, 9 Apr 2022 19:03:01 +0000 (15:03 -0400)]
Merge pull request #23146 from colemanw/api4ExplorerIndex
APIv4 Explorer - Adjust 'Index' field to fit better on narrow screens
Coleman Watts [Sat, 9 Apr 2022 15:30:54 +0000 (11:30 -0400)]
api4Explorer.css style fix
colemanw [Sat, 9 Apr 2022 13:16:43 +0000 (09:16 -0400)]
Merge pull request #23145 from braders/crm-button-icon-fixes
Fix incorrect use of icon argument for crmButton function
Bradley Taylor [Sat, 9 Apr 2022 08:41:01 +0000 (09:41 +0100)]
Fix incorrect use of icon argument for crmButton function
Coleman Watts [Sat, 9 Apr 2022 02:08:34 +0000 (22:08 -0400)]
APIv4 Explorer - Adjust 'Index' field to fit better on narrow screens
Coleman Watts [Sat, 9 Apr 2022 01:49:50 +0000 (21:49 -0400)]
API4 Explorer - Remove confusing "Save" button
This button was added as a prototype for saving a smart group from the Explorer.
But since that time SearchKit has evolved with the same functionality.
Since the presence of the button in the Explorer is confusing and redundant with SearchKit,
I think it's best to remove it.
colemanw [Sat, 9 Apr 2022 01:30:57 +0000 (21:30 -0400)]
Merge pull request #23132 from eileenmcnaughton/imp
Remove unnecessary pass-by-ref
Coleman Watts [Sat, 9 Apr 2022 01:25:47 +0000 (21:25 -0400)]
Release - Set version compatibility for core extensions when updating core version
Coleman Watts [Mon, 29 Nov 2021 14:52:50 +0000 (09:52 -0500)]
APIv4 - Add `is_active` extra field to Domain entity
Tim Otten [Fri, 8 Apr 2022 22:01:31 +0000 (15:01 -0700)]
CiviMail - Fix validation error
Steps to reproduce:
- Disable Flexmailer
- Use web UI
- Create a new mailing
- Fill out fields
- Submit mailing
- Observe inaccurate error - Mailing cannot be sent. There are missing or invalid fields (subject,name,from_name,from_email,body).
See also: https://civicrm.stackexchange.com/questions/41654/after-upgrade-to-civicrm-5-48-0-all-submissions-say-mailing-cannot-be-sent-th