colemanw [Sat, 27 Aug 2022 02:22:51 +0000 (22:22 -0400)]
Merge pull request #24371 from eileenmcnaughton/import_defaults_js
Fix broken js on Contribution Import
Eileen McNaughton [Sat, 27 Aug 2022 02:09:03 +0000 (14:09 +1200)]
Merge pull request #24395 from totten/master-release-time
Queue API - Expose option for delayed tasks (`$options['release_time']`)
Eileen McNaughton [Sat, 27 Aug 2022 01:05:58 +0000 (13:05 +1200)]
Merge pull request #24392 from totten/master-nfc-list
(NFC) Autoformat big clusters of `list()` statements
Tim Otten [Fri, 26 Aug 2022 23:01:13 +0000 (16:01 -0700)]
Queues - Allow passing `$options['release_time']` for new tasks
Tim Otten [Fri, 26 Aug 2022 21:49:38 +0000 (14:49 -0700)]
(NFC) tests/ - Autoformat big clumps of `list()` statements
Based on a quick grep, these files had a lot of `list()` statements, so I let PHPStorm clean them up.
Tim Otten [Fri, 26 Aug 2022 21:46:37 +0000 (14:46 -0700)]
(NFC) Civi - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:40:19 +0000 (14:40 -0700)]
(NFC) CRM/ - Autoformat big clumps of `list()` statements
Based on a quick grep, these files had a lot of `list()` statements, so I let PHPStorm clean them up.
Tim Otten [Fri, 26 Aug 2022 21:39:10 +0000 (14:39 -0700)]
(NFC) CRM/Upgrade - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:22:40 +0000 (14:22 -0700)]
(NFC) CRM/Contact - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:16:04 +0000 (14:16 -0700)]
(NFC) CRM/Core - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:15:09 +0000 (14:15 -0700)]
(NFC) CRM/Core/BAO - Autoformat `list()` statements
Eileen McNaughton [Fri, 26 Aug 2022 20:07:43 +0000 (08:07 +1200)]
Merge pull request #23658 from kurund/mailing-bounce-type-fixes
Issue/core#3489: Increase field size for mailing bounce type
demeritcowboy [Fri, 26 Aug 2022 19:54:18 +0000 (15:54 -0400)]
Merge pull request #24383 from mattwire/oauth
OAuth fixes
Eileen McNaughton [Fri, 26 Aug 2022 19:53:48 +0000 (07:53 +1200)]
Merge pull request #24391 from colemanw/activityTask
SearchKit - Add activity task
Matthew Wire [Thu, 25 Aug 2022 14:15:22 +0000 (15:15 +0100)]
Cleanup comments / README
Coleman Watts [Fri, 26 Aug 2022 15:32:47 +0000 (11:32 -0400)]
SearchKit - Add activity task
demeritcowboy [Fri, 26 Aug 2022 12:05:01 +0000 (08:05 -0400)]
Merge pull request #24390 from eileenmcnaughton/less_params
[REF] Variable use cleanup
Seamus Lee [Fri, 26 Aug 2022 05:57:42 +0000 (15:57 +1000)]
Merge pull request #24340 from eileenmcnaughton/install
Move participant cancel tests to extension
Eileen McNaughton [Fri, 26 Aug 2022 04:41:09 +0000 (16:41 +1200)]
[REF] Variable use cleanup
colemanw [Fri, 26 Aug 2022 03:15:07 +0000 (23:15 -0400)]
Merge pull request #24377 from eileenmcnaughton/import_part
Fix participant import not to import to deleted contacts
Eileen McNaughton [Wed, 24 Aug 2022 06:33:08 +0000 (18:33 +1200)]
Simplify form name - we know what it is
Eileen McNaughton [Wed, 24 Aug 2022 06:25:41 +0000 (18:25 +1200)]
Contribution import - Sigh - ok - I fixed the broken js
Eileen McNaughton [Wed, 24 Aug 2022 05:50:35 +0000 (17:50 +1200)]
[REF] Extract function to determine defaults in Contribution.MapField
Eileen McNaughton [Wed, 24 Aug 2022 05:10:01 +0000 (17:10 +1200)]
Minor code cleaup - the form rule is in the parent function
colemanw [Fri, 26 Aug 2022 03:12:22 +0000 (23:12 -0400)]
Merge pull request #24380 from eileenmcnaughton/member_import
Membership import - Simplify contact_id validation & avoid deleted contacts
Eileen McNaughton [Fri, 26 Aug 2022 02:57:10 +0000 (14:57 +1200)]
Merge pull request #24386 from eileenmcnaughton/inst_deprecate
Deprecate horrible function + unreleased regression
Eileen McNaughton [Thu, 25 Aug 2022 23:30:56 +0000 (11:30 +1200)]
Minor code styling fixes
Eileen McNaughton [Fri, 26 Aug 2022 00:50:17 +0000 (12:50 +1200)]
Merge pull request #24385 from colemanw/dedupeRuleGroupName
Add unique index to DedupeRuleGroup.name field
Eileen McNaughton [Thu, 25 Aug 2022 23:46:43 +0000 (11:46 +1200)]
Fix unreleased regression - loadSavedMapping is protected
Eileen McNaughton [Wed, 24 Aug 2022 05:19:07 +0000 (17:19 +1200)]
Deprecate horrible function
Eileen McNaughton [Thu, 25 Aug 2022 23:27:46 +0000 (11:27 +1200)]
Mark one version of test incomplete
Its not worth getting to the bottom of why they won't both run
Eileen McNaughton [Mon, 22 Aug 2022 02:43:41 +0000 (14:43 +1200)]
Remove now-obsolete use & superficial code standard fixes
Eileen McNaughton [Mon, 22 Aug 2022 01:06:31 +0000 (13:06 +1200)]
Move participant cancel tests to extension
Coleman Watts [Thu, 25 Aug 2022 16:21:12 +0000 (12:21 -0400)]
Add unique index to DedupeRuleGroup.name field
demeritcowboy [Thu, 25 Aug 2022 16:59:00 +0000 (12:59 -0400)]
Merge pull request #24382 from kurund/case-dashboard-activity-listing
dev/core#3822 - On case dashboard sort the recently performed activities by most recent first
colemanw [Thu, 25 Aug 2022 15:39:04 +0000 (11:39 -0400)]
Merge pull request #24381 from demeritcowboy/keep
Warning popup about copy of extension in system path disappears too fast
Matthew Wire [Thu, 25 Aug 2022 14:32:36 +0000 (15:32 +0100)]
Merge pull request #24232 from mattwire/propertybagbillingcountry
Add missing country=>billingCountry to PropertyBag mapping
Matthew Wire [Thu, 25 Aug 2022 14:12:35 +0000 (15:12 +0100)]
Replace deprecated getTimeRaw with time
Matthew Wire [Thu, 25 Aug 2022 14:18:58 +0000 (15:18 +0100)]
API4 checkPermissions 0 => FALSE
Matthew Wire [Thu, 25 Aug 2022 14:18:03 +0000 (15:18 +0100)]
Force OAuth RedirectURL to always be backend URL. Otherwise it may get generated as frontend URL and fail to authenticate eg. when 'Inbound email' job run via CRON
Kurund Jalmi [Thu, 25 Aug 2022 13:45:16 +0000 (14:45 +0100)]
fix the ordering of recent activities on case dashboard
Eileen McNaughton [Thu, 25 Aug 2022 07:36:44 +0000 (19:36 +1200)]
Merge pull request #24379 from eileenmcnaughton/add_field
Finally full remove the awful addField from import
Eileen McNaughton [Thu, 25 Aug 2022 04:26:46 +0000 (16:26 +1200)]
Fix tests not to rely on 'artificial' returns from import, nfc cleanup
Eileen McNaughton [Thu, 25 Aug 2022 03:01:29 +0000 (15:01 +1200)]
Merge pull request #24345 from demeritcowboy/upgrade-msgtpl
Alternate to #24143 - Update all is_reserved message templates during upgrade and their corresponding is_default's if it hasn't been edited
Eileen McNaughton [Thu, 25 Aug 2022 01:57:33 +0000 (13:57 +1200)]
Membership import - Simplify contact_id validation & avoid deleted contacts
demeritcowboy [Thu, 25 Aug 2022 01:55:42 +0000 (21:55 -0400)]
don't disappear
demeritcowboy [Thu, 25 Aug 2022 01:18:36 +0000 (21:18 -0400)]
Merge pull request #24323 from eileenmcnaughton/balance
Add initial Event Message Template previewability
Eileen McNaughton [Thu, 25 Aug 2022 01:12:54 +0000 (13:12 +1200)]
Merge pull request #24375 from colemanw/matchParam
APIv4 - Accept `match` param for Export action
Eileen McNaughton [Thu, 25 Aug 2022 00:52:23 +0000 (12:52 +1200)]
Finally full remove the awful addField from import
Eileen McNaughton [Thu, 25 Aug 2022 00:44:32 +0000 (12:44 +1200)]
Merge pull request #24376 from eileenmcnaughton/import_add_field
Remove obsolete addField from activity import
colemanw [Thu, 25 Aug 2022 00:34:38 +0000 (20:34 -0400)]
Merge pull request #24356 from eileenmcnaughton/import_select_two-er
Convert membership Import to use select2
Eileen McNaughton [Wed, 24 Aug 2022 23:31:29 +0000 (11:31 +1200)]
Merge pull request #24378 from civicrm/5.53
5.53
demeritcowboy [Wed, 24 Aug 2022 23:26:41 +0000 (19:26 -0400)]
Merge pull request #24363 from demeritcowboy/24259-553
dev/core#3803 - backport 24259
Eileen McNaughton [Wed, 24 Aug 2022 23:07:46 +0000 (11:07 +1200)]
Remove some bits that were not removed last cleanup
Eileen McNaughton [Wed, 24 Aug 2022 23:00:54 +0000 (11:00 +1200)]
Fix participant import not to import to deleted contacts
colemanw [Wed, 24 Aug 2022 22:14:21 +0000 (18:14 -0400)]
Merge pull request #24369 from eileenmcnaughton/msg_templates
Test only fixes
Eileen McNaughton [Wed, 24 Aug 2022 21:25:39 +0000 (09:25 +1200)]
Remove obsolete addField from activity import
Coleman Watts [Wed, 24 Aug 2022 16:10:27 +0000 (12:10 -0400)]
APIv4 - Accept `match` param for Export action
This makes the Export action a little friendlier by inserting the `match`
param for you, if specified.
Eileen McNaughton [Wed, 24 Aug 2022 07:28:45 +0000 (19:28 +1200)]
Merge pull request #24373 from eileenmcnaughton/master
Merge rc to master
Eileen McNaughton [Wed, 24 Aug 2022 06:56:30 +0000 (18:56 +1200)]
Merge branch '5.53' of github.com:civicrm/civicrm-core
Eileen McNaughton [Wed, 24 Aug 2022 06:26:16 +0000 (18:26 +1200)]
Merge pull request #24366 from eileenmcnaughton/5.53
Import - fix regression on matching by contribution ID
Tim Otten [Thu, 18 Aug 2022 09:53:33 +0000 (02:53 -0700)]
MessageTemplateTest - Fix cross-test leakage
Tim Otten [Thu, 18 Aug 2022 01:22:20 +0000 (18:22 -0700)]
(NFC) Flag more tests as `@group locale`
Seamus Lee [Wed, 24 Aug 2022 04:11:34 +0000 (14:11 +1000)]
Merge pull request #24365 from alifrumin/rn5.53
[NFC] 5.53 release notes first pass
Eileen McNaughton [Wed, 24 Aug 2022 03:52:20 +0000 (15:52 +1200)]
Import - fix regression on matching by contribution ID
Alice Frumin [Fri, 19 Aug 2022 01:59:36 +0000 (21:59 -0400)]
[NFC] Release Notes 5.53 first pass
Eileen McNaughton [Wed, 24 Aug 2022 00:09:39 +0000 (12:09 +1200)]
Merge pull request #24360 from colemanw/api4CaseActivity2
APIv4 - Support updating activity.case_id
Eileen McNaughton [Wed, 24 Aug 2022 00:09:16 +0000 (12:09 +1200)]
Merge pull request #24362 from eileenmcnaughton/imp_cont
[Ref] Extract getContactFields
Eileen McNaughton [Tue, 23 Aug 2022 23:42:53 +0000 (11:42 +1200)]
Merge pull request #24361 from demeritcowboy/unused-funcs
Unused functions in CRM_Upgrade_Form
demeritcowboy [Tue, 23 Aug 2022 23:19:07 +0000 (19:19 -0400)]
backport 24259
Eileen McNaughton [Tue, 23 Aug 2022 21:43:05 +0000 (09:43 +1200)]
Merge pull request #24268 from colemanw/groupPermissions
APIv4 - Expand Group.create permissions to include CiviMail
Eileen McNaughton [Tue, 23 Aug 2022 04:31:06 +0000 (16:31 +1200)]
Remove unnecessary assign
Eileen McNaughton [Tue, 23 Aug 2022 04:29:57 +0000 (16:29 +1200)]
Simplify form rule by using shared code
Eileen McNaughton [Tue, 23 Aug 2022 04:13:07 +0000 (16:13 +1200)]
Switch Membership form to use Select two
Coleman Watts [Fri, 19 Aug 2022 19:21:20 +0000 (15:21 -0400)]
APIv4 - Support updating activity.case_id
Eileen McNaughton [Tue, 23 Aug 2022 03:49:20 +0000 (15:49 +1200)]
Deprecate getAvailableFields on parser class
It really is a form layer function, called from one place on the forms
and one on the unit tests
colemanw [Tue, 23 Aug 2022 21:37:29 +0000 (17:37 -0400)]
Merge pull request #24333 from eileenmcnaughton/location_simplify
Simplify Domain edit form to not call complete `LocationBlock::buildQuickForm`
colemanw [Tue, 23 Aug 2022 21:36:48 +0000 (17:36 -0400)]
Merge pull request #24351 from eileenmcnaughton/import_except
[REF] Simplify error handling in contribution import
Eileen McNaughton [Tue, 23 Aug 2022 03:39:25 +0000 (15:39 +1200)]
[REF] Extract getDefaults
Eileen McNaughton [Tue, 23 Aug 2022 03:38:43 +0000 (15:38 +1200)]
Remove unnecessary pass-by-reference
Eileen McNaughton [Tue, 23 Aug 2022 03:26:22 +0000 (15:26 +1200)]
Simplify Membership MapField by removing js to support non-existent options
colemanw [Tue, 23 Aug 2022 21:35:29 +0000 (17:35 -0400)]
Merge pull request #24353 from eileenmcnaughton/import_class_fold
[REF] Fold only parent class into only child class
colemanw [Tue, 23 Aug 2022 21:32:08 +0000 (17:32 -0400)]
Merge pull request #24357 from eileenmcnaughton/import_member_metadata
Deprecate `BAO_Membership::importableFields`
Eileen McNaughton [Tue, 23 Aug 2022 21:16:19 +0000 (09:16 +1200)]
[Ref] Extract getContactFields
demeritcowboy [Tue, 23 Aug 2022 20:07:05 +0000 (16:07 -0400)]
unused functions
demeritcowboy [Mon, 22 Aug 2022 20:09:31 +0000 (16:09 -0400)]
update all is_reserved templates each time
demeritcowboy [Tue, 23 Aug 2022 12:37:07 +0000 (08:37 -0400)]
Merge pull request #24338 from eileenmcnaughton/smarty_skip_title
Fix notice on skipTitle
demeritcowboy [Tue, 23 Aug 2022 12:24:40 +0000 (08:24 -0400)]
Merge pull request #24348 from totten/master-class-err
ClassScanner - Throw an exception if a class-file doesn't have the expected class
Eileen McNaughton [Tue, 23 Aug 2022 09:53:34 +0000 (21:53 +1200)]
Merge pull request #24359 from eileenmcnaughton/master
Merge branch '5.53' to master
Eileen McNaughton [Tue, 23 Aug 2022 09:51:54 +0000 (21:51 +1200)]
Merge branch '5.53' of github.com:civicrm/civicrm-core
Eileen McNaughton [Mon, 22 Aug 2022 22:13:30 +0000 (10:13 +1200)]
[REF] Simplify error handling
Update CRM/Contribute/Import/Parser/Contribution.php
Co-authored-by: Seamus Lee <seamuslee001@gmail.com>
Eileen McNaughton [Tue, 23 Aug 2022 06:47:59 +0000 (18:47 +1200)]
Merge pull request #24354 from eileenmcnaughton/import_select_two
Move `isSkipDuplicates` to shared parent
Eileen McNaughton [Tue, 23 Aug 2022 04:49:57 +0000 (16:49 +1200)]
Deprecated Membership::importableFields
Tim Otten [Tue, 23 Aug 2022 03:24:41 +0000 (20:24 -0700)]
UnitTests - Tighten class-scanning for `civicrm-core:tests/phpunit`
This addresses a bug where:
1. Class-scanning of `civicrm-core:tests/phpunit/*` works with core-test-suites
2. Class-scanning of `civicrm-core:tests/phpunit/*` fails with civiimport test-suite.
The difference is that core-tests setup class-loading for
`civicrm-core:tests/phpunit/`; `civimport` understandably doesn't.
Class-scanning is only viable if we regard the specific classes a loadable.
This further tightens it:
1. Since core-test-suites can load `civicrm-core:tests/phpunit/*`, they will scan it
2. Since civiimport test-suite cannot load it, it will not scan it.
Seamus Lee [Tue, 23 Aug 2022 03:32:55 +0000 (13:32 +1000)]
Merge pull request #24346 from eileenmcnaughton/no_proceed
Import - remove import button if it will not work
Eileen McNaughton [Tue, 23 Aug 2022 03:20:15 +0000 (15:20 +1200)]
Move isSkipDuplicates to shared parent
Eileen McNaughton [Wed, 10 Aug 2022 02:10:40 +0000 (14:10 +1200)]
Fold only parent class into only child class
Eileen McNaughton [Tue, 23 Aug 2022 02:45:23 +0000 (14:45 +1200)]
Merge pull request #24350 from eileenmcnaughton/import_cont_less
Remove do-nothing code, add test to prove
colemanw [Tue, 23 Aug 2022 02:04:38 +0000 (22:04 -0400)]
Merge pull request #24344 from eileenmcnaughton/import_cont
Fix imported statuses & contribution id storage on import job
Eileen McNaughton [Mon, 22 Aug 2022 20:52:59 +0000 (08:52 +1200)]
Import - remove import button if it will not work