civicrm-core.git
7 years agoCRM-21486: Support multiple test mail
deb.monish [Mon, 27 Nov 2017 16:57:45 +0000 (22:27 +0530)]
CRM-21486: Support multiple test mail

7 years agoMerge pull request #11324 from mattwire/CRM-21214_followup_fix_crashes
colemanw [Sat, 25 Nov 2017 11:52:12 +0000 (06:52 -0500)]
Merge pull request #11324 from mattwire/CRM-21214_followup_fix_crashes

CRM-21214 Fix crashes when 'null' string is passed in via API

7 years agoFix crashes when 'null' string is passed in via API
Matthew Wire [Fri, 24 Nov 2017 17:39:09 +0000 (17:39 +0000)]
Fix crashes when 'null' string is passed in via API

7 years agoMerge pull request #11314 from omarabuhussein/CRM-21473-adding-add-note-permission
Eileen McNaughton [Fri, 24 Nov 2017 20:26:20 +0000 (09:26 +1300)]
Merge pull request #11314 from omarabuhussein/CRM-21473-adding-add-note-permission

CRM-21473: Add new permission to add contact notes and prevent users without edit contact permission to edit or delete notes

7 years agoMerge pull request #11326 from civicrm/4.7.28-rc
Eileen McNaughton [Fri, 24 Nov 2017 20:23:09 +0000 (09:23 +1300)]
Merge pull request #11326 from civicrm/4.7.28-rc

4.7.28 rc

7 years agoMerge pull request #11320 from jitendrapurohit/CRM-21446
colemanw [Fri, 24 Nov 2017 17:07:39 +0000 (12:07 -0500)]
Merge pull request #11320 from jitendrapurohit/CRM-21446

CRM-21446 - Allow case id as well as hash in inbound email processing…

7 years agoMerge pull request #11321 from mlutfy/4.7.28-rc-crm21479
colemanw [Fri, 24 Nov 2017 17:06:30 +0000 (12:06 -0500)]
Merge pull request #11321 from mlutfy/4.7.28-rc-crm21479

CRM-21479: Syntax fix for updateContributionInvoiceNumber().

7 years agoCRM-21479: Syntax fix for updateContributionInvoiceNumber().
Mathieu Lutfy [Fri, 24 Nov 2017 15:54:13 +0000 (10:54 -0500)]
CRM-21479: Syntax fix for updateContributionInvoiceNumber().

7 years agoMerge pull request #11312 from samuelsov/CRM-21470
Mathieu Lu [Fri, 24 Nov 2017 14:34:04 +0000 (09:34 -0500)]
Merge pull request #11312 from samuelsov/CRM-21470

CRM-21470 Add support for WordPress Polylang plugin

7 years agoCRM-21446 - Allow case id as well as hash in inbound email processing to autofile...
Jitendra Purohit [Fri, 24 Nov 2017 12:31:00 +0000 (18:01 +0530)]
CRM-21446 - Allow case id as well as hash in inbound email processing to autofile emails on cases

7 years agoMerge pull request #11300 from eileenmcnaughton/towards1
Monish Deb [Fri, 24 Nov 2017 11:02:07 +0000 (16:32 +0530)]
Merge pull request #11300 from eileenmcnaughton/towards1

CRM-19273 extract code to get financial items and filter those already cancelled.

7 years agoMerge pull request #11303 from jitendrapurohit/CRM-21190
Eileen McNaughton [Thu, 23 Nov 2017 09:27:57 +0000 (22:27 +1300)]
Merge pull request #11303 from jitendrapurohit/CRM-21190

CRM-21190 - Warning message on Thankyou page on pay later membership pr…

7 years agoCRM-21190 - Warning error on Thankyou page on pay later membership priceset
Jitendra Purohit [Fri, 15 Sep 2017 14:14:02 +0000 (19:44 +0530)]
CRM-21190 - Warning error on Thankyou page on pay later membership priceset

7 years agoMerge pull request #11315 from seamuslee001/dao_participant_update
Eileen McNaughton [Thu, 23 Nov 2017 04:13:29 +0000 (17:13 +1300)]
Merge pull request #11315 from seamuslee001/dao_participant_update

NFC rerun setup.sh -dg and regen Participant DAO

7 years agoMerge pull request #11257 from mattwire/CRM-21409_contribute_pdf_letter_hooks
Eileen McNaughton [Thu, 23 Nov 2017 00:40:34 +0000 (13:40 +1300)]
Merge pull request #11257 from mattwire/CRM-21409_contribute_pdf_letter_hooks

CRM-21409 Don't bypass hooks when updating contribution receipt/thankyou date

7 years agoNFC rerun setup.sh -dg and regen Participant DAO
Seamus Lee [Wed, 22 Nov 2017 23:49:42 +0000 (10:49 +1100)]
NFC rerun setup.sh -dg and regen Participant DAO

7 years agoCRM-21473: Add new permission to add contact notes and prevent users without edit...
Omar abu hussein [Wed, 22 Nov 2017 22:59:51 +0000 (00:59 +0200)]
CRM-21473: Add new permission to add contact notes and prevent users without edit contact permission to edit or delete notes

7 years agoCRM-21470 Add support for WordPress Polylang plugin
Samuel Vanhove [Wed, 22 Nov 2017 20:11:11 +0000 (15:11 -0500)]
CRM-21470 Add support for WordPress Polylang plugin

7 years agoDon't bypass hooks when updating contribution receipt/thankyou date
Matthew Wire [Wed, 8 Nov 2017 14:10:42 +0000 (14:10 +0000)]
Don't bypass hooks when updating contribution receipt/thankyou date

7 years agoMerge pull request #11235 from clnlf/CRM-21389-UserDashBoard-Regions
Eileen McNaughton [Wed, 22 Nov 2017 02:46:47 +0000 (15:46 +1300)]
Merge pull request #11235 from clnlf/CRM-21389-UserDashBoard-Regions

CRM-21389 Added pre and post regions to each entitys userdashboard

7 years agoMerge pull request #11226 from seamuslee001/CRM-21378
Eileen McNaughton [Wed, 22 Nov 2017 00:42:51 +0000 (13:42 +1300)]
Merge pull request #11226 from seamuslee001/CRM-21378

CRM-21378 Ensure that email abuse reports are treated as bounce type …

7 years agoMerge pull request #11216 from mydropwizard/crm-21372
Mathieu Lu [Tue, 21 Nov 2017 23:28:46 +0000 (18:28 -0500)]
Merge pull request #11216 from mydropwizard/crm-21372

CRM-21372: Fix fatal error adding profile on Drupal 8

7 years agoMerge pull request #11285 from eileenmcnaughton/dupe_url
Mathieu Lu [Tue, 21 Nov 2017 23:13:06 +0000 (18:13 -0500)]
Merge pull request #11285 from eileenmcnaughton/dupe_url

[NFC] CRM-16819 improve on CRM_Utils_Request::retrieve

7 years agoCRM-21378 Ensure that email abuse reports are treated as bounce type of spam
Seamus Lee [Thu, 2 Nov 2017 00:14:26 +0000 (11:14 +1100)]
CRM-21378 Ensure that email abuse reports are treated as bounce type of spam

Move upgrade steps to .29

7 years agoMerge pull request #11267 from nbrettell/CRM-21383-master
Eileen McNaughton [Tue, 21 Nov 2017 21:35:48 +0000 (10:35 +1300)]
Merge pull request #11267 from nbrettell/CRM-21383-master

CRM-21383 - Inclusion of a directive to replace the existing select f…

7 years agoMerge pull request #11308 from civicrm/4.7.28-rc
Eileen McNaughton [Tue, 21 Nov 2017 21:19:17 +0000 (10:19 +1300)]
Merge pull request #11308 from civicrm/4.7.28-rc

4.7.28 rc

7 years agoMerge pull request #11307 from spalmstr/CRM-21001
Eileen McNaughton [Tue, 21 Nov 2017 20:39:22 +0000 (09:39 +1300)]
Merge pull request #11307 from spalmstr/CRM-21001

CRM-21001

7 years agoMerge pull request #11258 from seamuslee001/CRM-21411
Eileen McNaughton [Tue, 21 Nov 2017 20:33:50 +0000 (09:33 +1300)]
Merge pull request #11258 from seamuslee001/CRM-21411

CRM-21411 Fix issue where unsubscribe group field would not show beca…

7 years agoMerge pull request #10650 from jitendrapurohit/CRM-20861
Eileen McNaughton [Tue, 21 Nov 2017 20:19:00 +0000 (09:19 +1300)]
Merge pull request #10650 from jitendrapurohit/CRM-20861

CRM-20861 : Location type does not show for custom address fields

7 years agoCRM-21001
spalmstr [Tue, 21 Nov 2017 18:19:28 +0000 (18:19 +0000)]
CRM-21001

7 years agoCRM-19273 fix tests to actually run.
eileen [Mon, 20 Nov 2017 01:13:23 +0000 (14:13 +1300)]
CRM-19273 fix tests to actually run.

Due to being mis-named these tests have never run. When they do run they expose issues which
are addressed in PR 10962. This commits causes the part that actually works in these
tests to run.

7 years agoMinor code tidy up
eileen [Mon, 20 Nov 2017 00:26:32 +0000 (13:26 +1300)]
Minor code tidy up

7 years agoCRM-19273 very minor extraction
eileen [Sun, 19 Nov 2017 23:34:55 +0000 (12:34 +1300)]
CRM-19273 very minor extraction

7 years agoCRM-19273 extract code to get financial items and filter those already cancelled.
eileen [Sun, 19 Nov 2017 21:43:03 +0000 (10:43 +1300)]
CRM-19273 extract code to get financial items and filter those already cancelled.

This is the first of the broken-out changes in https://github.com/civicrm/civicrm-core/pull/10962 that results in
an actual functionality change. The code that retrieves the relevant financial items is separated into
it's own function. But then a php loop iterates through and eliminates any items that have
already been reversed. This is a scenario identified in the unit tests on 10962 and occurs when
the the option value has is changed and then changed again - the items from the first change
should not be re-changed.

7 years agoMerge pull request #11299 from francescbassas/patch-12
Eileen McNaughton [Tue, 21 Nov 2017 04:20:20 +0000 (17:20 +1300)]
Merge pull request #11299 from francescbassas/patch-12

CRM-21454 Add money raised on page contribution widget ajax response

7 years agoMerge pull request #11302 from totten/master-toxic-json
Eileen McNaughton [Tue, 21 Nov 2017 01:19:58 +0000 (14:19 +1300)]
Merge pull request #11302 from totten/master-toxic-json

(NFC) .toxic.json - Update list of functions which yield toxic warnings

7 years agoAdd comments
Coleman Watts [Tue, 21 Nov 2017 01:17:39 +0000 (20:17 -0500)]
Add comments

7 years ago(NFC) .toxic.json - Update list of functions which yield toxic warnings
Tim Otten [Mon, 20 Nov 2017 22:21:53 +0000 (14:21 -0800)]
(NFC) .toxic.json - Update list of functions which yield toxic warnings

The file `.toxic.json` is supposed to list egregious functions -- any change
to these functions should produce extra comments/suggestsions.

The current list is a few years old, so I've run `pdepend` and updated the list.
The list includes anything which matches one or more of these:

 * "Non Comment Lines of Code" (`ncloc`) greater than 300.
 * "[NPath](https://modess.io/npath-complexity-cyclomatic-complexity-explained/) complexity" (`npath`) greater than 1 billion.

7 years agoCRM-21454 Add money raised on page contribution widget ajax response
francescbassas [Sun, 19 Nov 2017 19:57:20 +0000 (20:57 +0100)]
CRM-21454 Add money raised on page contribution widget ajax response

7 years agoMerge pull request #11289 from kainukempowerment/CRM-21424
Eileen McNaughton [Sat, 18 Nov 2017 21:04:18 +0000 (10:04 +1300)]
Merge pull request #11289 from kainukempowerment/CRM-21424

CRM-21424 Set receipt date when downloading pdf receipt

7 years agoAdded test
Klaas Eikelboom [Sat, 18 Nov 2017 19:58:20 +0000 (19:58 +0000)]
Added test

7 years agoMerge pull request #11296 from jmcclelland/CRM-21449
Mathieu Lu [Sat, 18 Nov 2017 00:43:23 +0000 (19:43 -0500)]
Merge pull request #11296 from jmcclelland/CRM-21449

CRM-21449 - add location field to activity report.

7 years agoMerge pull request #11284 from eileenmcnaughton/towards1
Mathieu Lu [Sat, 18 Nov 2017 00:33:10 +0000 (19:33 -0500)]
Merge pull request #11284 from eileenmcnaughton/towards1

[NFC] code cleanup: split out 2 functions that are mostly unrelated.

7 years agoMerge pull request #11268 from mattwire/CRM-21421_allow_updating_existing_casecontact
colemanw [Fri, 17 Nov 2017 23:20:17 +0000 (18:20 -0500)]
Merge pull request #11268 from mattwire/CRM-21421_allow_updating_existing_casecontact

CRM-21421 Fix to allow updating an existing CaseContact record

7 years agoMerge pull request #11295 from mepps/CRM-21448
colemanw [Fri, 17 Nov 2017 23:15:27 +0000 (18:15 -0500)]
Merge pull request #11295 from mepps/CRM-21448

CRM-21448 Add a link to contact from contribution

7 years agoMerge pull request #11293 from mlutfy/crm21447
Eileen McNaughton [Fri, 17 Nov 2017 22:55:34 +0000 (11:55 +1300)]
Merge pull request #11293 from mlutfy/crm21447

CRM-21447: Relationship Report: move variable handling to beginPostProcessCommon

7 years agoMerge pull request #11297 from civicrm/4.7.28-rc
Eileen McNaughton [Fri, 17 Nov 2017 22:44:55 +0000 (11:44 +1300)]
Merge pull request #11297 from civicrm/4.7.28-rc

4.7.28 rc

7 years agoMerge pull request #11286 from jitendrapurohit/pay-later-fix
Eileen McNaughton [Fri, 17 Nov 2017 22:40:02 +0000 (11:40 +1300)]
Merge pull request #11286 from jitendrapurohit/pay-later-fix

CRM-21436 - Fix fatal error on pay later

7 years agoCRM-21449 - add location field to activity report.
Jamie McClelland [Fri, 17 Nov 2017 21:19:55 +0000 (16:19 -0500)]
CRM-21449 - add location field to activity report.

7 years agoCRM-21448 Add a link to contact from contribution
Margaret Epps [Fri, 17 Nov 2017 19:43:40 +0000 (14:43 -0500)]
CRM-21448 Add a link to contact from contribution

7 years agoCRM-21447: Contact Relationship Report: move variable handling to beginPostProcessCom...
Mathieu Lutfy [Fri, 17 Nov 2017 17:45:56 +0000 (12:45 -0500)]
CRM-21447: Contact Relationship Report: move variable handling to beginPostProcessCommon().

7 years agoremove obsolete comment
Klaas Eikelboom [Fri, 17 Nov 2017 17:42:48 +0000 (17:42 +0000)]
remove obsolete comment

7 years agoMerge pull request #11261 from JMAConsulting/CRM-21362
colemanw [Fri, 17 Nov 2017 13:03:12 +0000 (08:03 -0500)]
Merge pull request #11261 from JMAConsulting/CRM-21362

CRM-21362: followup PR which fixes duplicate mailing rows for each job

7 years agofix contribution page loading on no processor
Jitendra Purohit [Fri, 17 Nov 2017 12:56:28 +0000 (18:26 +0530)]
fix contribution page loading on no processor

7 years agoAdd unit test for CaseContact.create
Matthew Wire [Wed, 15 Nov 2017 20:50:12 +0000 (20:50 +0000)]
Add unit test for CaseContact.create

7 years agoMerge pull request #11152 from eileenmcnaughton/api
Mathieu Lu [Fri, 17 Nov 2017 05:09:00 +0000 (00:09 -0500)]
Merge pull request #11152 from eileenmcnaughton/api

CRM-21324 - Support 'null' on date fields in the api

7 years ago[NFC] code cleanup: split out 2 functions that are mostly unrelated.
eileen [Wed, 15 Nov 2017 21:06:25 +0000 (10:06 +1300)]
[NFC] code cleanup: split out 2 functions that are mostly unrelated.

The handling of line items & financial items has been munged together in a way that gains little, adds confusion,
and blocks the financial items portion from being re-usable.

This is a code cleanup preparatory to the actual changes in pr #10962

7 years agoMerge pull request #11259 from eileenmcnaughton/report
Mathieu Lu [Fri, 17 Nov 2017 04:43:55 +0000 (23:43 -0500)]
Merge pull request #11259 from eileenmcnaughton/report

CRM-21412 Do not give fatal error on report when no fields selected

7 years agoCRM-21424 Set receipt date when downloading pdf receipt
Klaas Eikelboom [Thu, 16 Nov 2017 16:38:19 +0000 (16:38 +0000)]
CRM-21424 Set receipt date when downloading pdf receipt

7 years agoCRM-16819 improve on CRM_Utils_Request::retrieve
eileen [Wed, 15 Nov 2017 23:42:07 +0000 (12:42 +1300)]
CRM-16819 improve on CRM_Utils_Request::retrieve

I'm proposing this as an improved (but not perfect) way to retrieve data from http requests.

The biggest issue IMHO with the CRM_Utils_Request::retrieve method is that the third
parameter is & - and if any of the subsequent parameters need to be passed a NULL
array must be generated. The practice of passing a specific static NULL array is known to
have caused errors due to contamination. This commit offers an alternate function without that
parameter (my suggestion is to create a new function again where we really do want  to
work but in general it seems flakey to me). I have also re-ordered the parameters as I perceive
 as being more commonly required than  (renamed from 'abort').

I have also made it so the new function will throw an exception rather than use the deprecated
fatal - as a new function I feel we can enforce this change and I have made some changes
to the error message thrown in the validate function so it returns a list of permissable
values for the  string as the existing error is hard for developers to work with, as it
can be hard to realise why 'int' is wrong (casing) or what should have been passed.

Finally I made the visibility on CRM_Utils_Retrieve::getValues protected. This function
is not called from within core & is downright unsafe as it does no validation so we should
not permit anyone to accidentally use it (I have no reason to think they have

7 years agoMerge pull request #11270 from colemanw/CRM-21421
colemanw [Wed, 15 Nov 2017 23:10:40 +0000 (18:10 -0500)]
Merge pull request #11270 from colemanw/CRM-21421

CRM-21421 - Api case update should not re-save case contacts

7 years agoMinor refactor, define as an array for readability & insertability
eileen [Wed, 15 Nov 2017 22:45:35 +0000 (11:45 +1300)]
Minor refactor, define  as an array for readability & insertability

7 years agoCRM-21412 Do not give fatal error on report when no fields selected
eileen [Wed, 8 Nov 2017 21:44:09 +0000 (10:44 +1300)]
CRM-21412 Do not give fatal error on report when no fields selected

7 years agoMerge pull request #10674 from herbdool/crm20764
Mathieu Lu [Wed, 15 Nov 2017 21:27:59 +0000 (16:27 -0500)]
Merge pull request #10674 from herbdool/crm20764

CRM-20764 Allow clean URLs with CiviCRM on Backdrop

7 years agoMerge pull request #11283 from mattwire/CRM-21432_recur_end_date_display
Mathieu Lu [Wed, 15 Nov 2017 20:57:59 +0000 (15:57 -0500)]
Merge pull request #11283 from mattwire/CRM-21432_recur_end_date_display

CRM-21432 Fix display of end date for recurring contributions

7 years agoMerge pull request #11278 from eileenmcnaughton/towards1
Mathieu Lu [Wed, 15 Nov 2017 19:59:32 +0000 (14:59 -0500)]
Merge pull request #11278 from eileenmcnaughton/towards1

[NFC] Function extraction and renaming of variable for shorter refere…

7 years agoFix display of end date for recurring contributions
Matthew Wire [Wed, 15 Nov 2017 19:42:50 +0000 (19:42 +0000)]
Fix display of end date for recurring contributions

7 years ago[NFC] Function extraction and renaming of variable for shorter reference.
eileen [Tue, 14 Nov 2017 20:09:33 +0000 (09:09 +1300)]
[NFC] Function extraction and renaming of variable for shorter reference.

This is a function extraction towards CRM-19273. I haven't changed the logic but it is apparent that
we are changing the contribution financial type to 'the financial type of the last line
item' - which is a little dubious although it might work in practice. We should expose the field &
let people choose it

7 years agoMerge pull request #9739 from nditech/CRM-19915
Mathieu Lu [Wed, 15 Nov 2017 05:19:45 +0000 (00:19 -0500)]
Merge pull request #9739 from nditech/CRM-19915

Fixes CRM-19915

7 years agoMerge pull request #11034 from ejegg/docStrings
Mathieu Lu [Wed, 15 Nov 2017 05:15:08 +0000 (00:15 -0500)]
Merge pull request #11034 from ejegg/docStrings

[NFC] Fix a bunch of docstrings

7 years agoMerge pull request #11138 from mattwire/CRM-21312_bootstrap_css_fix
Eileen McNaughton [Wed, 15 Nov 2017 04:49:24 +0000 (17:49 +1300)]
Merge pull request #11138 from mattwire/CRM-21312_bootstrap_css_fix

CRM-21312 Fix display of 'Recent Items' when using a bootstrap theme

7 years agoUpdate sendMail return type
Elliott Eggleston [Wed, 15 Nov 2017 04:43:49 +0000 (23:43 -0500)]
Update sendMail return type

7 years agoMerge pull request #11233 from seanmadsen/CRM-14343-import-error-limit
Mathieu Lu [Wed, 15 Nov 2017 03:53:21 +0000 (22:53 -0500)]
Merge pull request #11233 from seanmadsen/CRM-14343-import-error-limit

CRM-14343 - Remove limit of downloading only 250 errors during CSV import

7 years agoMerge pull request #11255 from tschuettler/CRM-21407
Mathieu Lu [Wed, 15 Nov 2017 03:10:34 +0000 (22:10 -0500)]
Merge pull request #11255 from tschuettler/CRM-21407

CRM-21407 - Fix ISO compliance for German counties

7 years agoMerge pull request #11266 from eileenmcnaughton/additional-test
Mathieu Lu [Wed, 15 Nov 2017 03:02:26 +0000 (22:02 -0500)]
Merge pull request #11266 from eileenmcnaughton/additional-test

[NFC] Additional test

7 years agoMerge pull request #11277 from mihaelmladenov/NDI-14-cancel-event-participants
colemanw [Wed, 15 Nov 2017 02:48:53 +0000 (21:48 -0500)]
Merge pull request #11277 from mihaelmladenov/NDI-14-cancel-event-participants

CRM-21426: Removed duplicate submit buttons on Cancel/Delete Event Participants

7 years agoNDI-14: Removed top submit buttons on Delete Event Participants task
Mihael Mladenov [Tue, 14 Nov 2017 21:17:42 +0000 (23:17 +0200)]
NDI-14: Removed top submit buttons on Delete Event Participants task

7 years agoNDI-14: Changed label of cancel event participants submit button
Mihael Mladenov [Tue, 14 Nov 2017 19:18:49 +0000 (21:18 +0200)]
NDI-14: Changed label of cancel event participants submit button

7 years agoMerge pull request #11273 from aydun/CRM-21422_london_timezone
Eileen McNaughton [Tue, 14 Nov 2017 19:18:47 +0000 (08:18 +1300)]
Merge pull request #11273 from aydun/CRM-21422_london_timezone

CRM-21422 - Fix handling of 0 timezone offset

7 years agoCode improvement as per Eileen's comment
Aidan Saunders [Tue, 14 Nov 2017 15:18:11 +0000 (15:18 +0000)]
Code improvement as per Eileen's comment

7 years agoNDI-14: Removed duplicate submit buttons on Cancel Event Participants page
Mihael Mladenov [Tue, 14 Nov 2017 12:23:08 +0000 (14:23 +0200)]
NDI-14: Removed duplicate submit buttons on Cancel Event Participants page

7 years agoMerge pull request #11272 from eileenmcnaughton/towards1
Monish Deb [Tue, 14 Nov 2017 10:03:48 +0000 (15:33 +0530)]
Merge pull request #11272 from eileenmcnaughton/towards1

NFC code tidy up preparatory to CRM-19273

7 years agoMerge pull request #11275 from civicrm/4.7.28-rc
Eileen McNaughton [Tue, 14 Nov 2017 08:42:50 +0000 (21:42 +1300)]
Merge pull request #11275 from civicrm/4.7.28-rc

4.7.28 rc

7 years agoCRM-21304 quash form reload message when refreshing (#11122)
Eileen McNaughton [Tue, 14 Nov 2017 07:45:07 +0000 (20:45 +1300)]
CRM-21304 quash form reload message when refreshing (#11122)

* CRM-21304 quash form reload message when refreshing

* CRM-21304 - Disable unsaved changes warning on dedupe form

----------------------------------------
* CRM-21304: Dedupe usablity, quash refresh message in more cases
  https://issues.civicrm.org/jira/browse/CRM-21304

7 years agoMerge pull request #11072 from cividesk/CRM-21265-4.7
Eileen McNaughton [Tue, 14 Nov 2017 07:33:59 +0000 (20:33 +1300)]
Merge pull request #11072 from cividesk/CRM-21265-4.7

CRM-21265: update payment status to Failed if membership transaction…

7 years agoMerge pull request #11205 from agileware/CRM-20166
Eileen McNaughton [Tue, 14 Nov 2017 06:06:26 +0000 (19:06 +1300)]
Merge pull request #11205 from agileware/CRM-20166

CRM-20166: Making CVV always required for front-end pages.

7 years agoFix fatal error on pay later
Jitendra Purohit [Tue, 14 Nov 2017 03:26:32 +0000 (08:56 +0530)]
Fix fatal error on pay later

7 years agoMerge pull request #11264 from seanmadsen/CRM-21419-activity-separation
colemanw [Tue, 14 Nov 2017 01:53:15 +0000 (20:53 -0500)]
Merge pull request #11264 from seanmadsen/CRM-21419-activity-separation

CRM-21419 Prevent users from accidentally creating a single activity when they want multiple

7 years agoMerge pull request #11269 from varshith/CRM-21041_respect_default_communication_style...
colemanw [Mon, 13 Nov 2017 23:14:13 +0000 (18:14 -0500)]
Merge pull request #11269 from varshith/CRM-21041_respect_default_communication_style_on_api_contact_create

CRM-21041: Respect default 'Communication Style' when creating a …

7 years agoclear weird character causing warnings
Vinu Varshith S [Mon, 13 Nov 2017 17:19:30 +0000 (22:49 +0530)]
clear weird character causing warnings

7 years agoMerge pull request #11254 from colemanw/CRM-21406
colemanw [Mon, 13 Nov 2017 13:47:08 +0000 (08:47 -0500)]
Merge pull request #11254 from colemanw/CRM-21406

CRM-21406 - Standalone export form

7 years agoFix handling of 0 offset
Aidan Saunders [Mon, 13 Nov 2017 13:11:12 +0000 (13:11 +0000)]
Fix handling of 0 offset

7 years agoCRM-20166: Making CVV always required for front-end contribution pages.
Alok Patel [Wed, 8 Nov 2017 07:29:29 +0000 (12:59 +0530)]
CRM-20166: Making CVV always required for front-end contribution pages.

7 years agoAdding test cases for CRM-21041
Vinu Varshith S [Mon, 13 Nov 2017 11:20:14 +0000 (16:50 +0530)]
Adding test cases for CRM-21041

7 years agoFix syntax check and remove irrelevant Ajax params
nbrettell [Mon, 13 Nov 2017 10:13:16 +0000 (10:13 +0000)]
Fix syntax check and remove irrelevant Ajax params

7 years agoNFC code tidy up, convert result to array more cleanly
eileen [Mon, 13 Nov 2017 07:57:49 +0000 (20:57 +1300)]
NFC code tidy up, convert result to array more cleanly

7 years agoNFC code tidy up preparatory to CRM-19273
eileen [Mon, 13 Nov 2017 07:18:14 +0000 (20:18 +1300)]
NFC code tidy up preparatory to CRM-19273

As part of reducing https://github.com/civicrm/civicrm-core/pull/10962/files easier to parse this makes some small
code tidy ups
1) renames functions to not use the deprecated convention of leading underscore
2) renames function to getLineItemsToAlter rather than 'to add & update'
 (later changes will cause this array to include 'to_cancel' & 'to_resurrect')
3) changes the array return format for that function to be an array of requiredChanges
4) rename function _getFinancialItemsToRecord to getReverseFinancialItemsToRecord to
reflect the fact it is generating an array of reversals to perform

7 years agoAvoid 'array_pop calling a function' situation
Vinu Varshith S [Sun, 12 Nov 2017 05:05:08 +0000 (10:35 +0530)]
Avoid 'array_pop calling a function' situation

7 years agoMerge pull request #11195 from jitendrapurohit/CRM-21349
colemanw [Sat, 11 Nov 2017 16:37:20 +0000 (11:37 -0500)]
Merge pull request #11195 from jitendrapurohit/CRM-21349

CRM-21349: Increase timeout of status message after batch merge

7 years agoCRM-21421 - Api case update should not re-save case contacts
Coleman Watts [Sat, 11 Nov 2017 16:32:04 +0000 (11:32 -0500)]
CRM-21421 - Api case update should not re-save case contacts