Eileen McNaughton [Tue, 30 Aug 2022 18:58:36 +0000 (06:58 +1200)]
Merge pull request #24337 from colemanw/fixGroupAclCheck
API - Standardize group ACL checks
demeritcowboy [Tue, 30 Aug 2022 18:18:44 +0000 (14:18 -0400)]
Merge pull request #24418 from mattwire/advancedevents
REF Code cleanup for event configuration extracted from advancedevents extension
Matthew Wire [Tue, 30 Aug 2022 12:50:42 +0000 (13:50 +0100)]
Code cleanup for event configuration extracted from advancedevents extension
Eileen McNaughton [Tue, 30 Aug 2022 06:33:08 +0000 (18:33 +1200)]
Merge pull request #24410 from eileenmcnaughton/import_cont
Remove always-true if
Eileen McNaughton [Tue, 30 Aug 2022 02:31:21 +0000 (14:31 +1200)]
Merge pull request #24412 from eileenmcnaughton/cont_form
Remove obsolete param from duplicated function
Eileen McNaughton [Mon, 29 Aug 2022 22:33:36 +0000 (10:33 +1200)]
Remove always-true if
Eileen McNaughton [Tue, 30 Aug 2022 01:01:17 +0000 (13:01 +1200)]
Merge pull request #24411 from eileenmcnaughton/import_pledge
Remove unreachable code
Eileen McNaughton [Tue, 30 Aug 2022 00:05:40 +0000 (12:05 +1200)]
Merge pull request #24389 from eileenmcnaughton/import_form_rule_a
Use shared parent formRule in custom import api
Eileen McNaughton [Tue, 30 Aug 2022 00:05:21 +0000 (12:05 +1200)]
Merge pull request #24388 from eileenmcnaughton/import_form_rule
Minor code cleaup - the form rule is in the parent function
Eileen McNaughton [Mon, 29 Aug 2022 23:22:56 +0000 (11:22 +1200)]
Remove check for pledge block id from back-office form
Eileen McNaughton [Mon, 29 Aug 2022 23:19:08 +0000 (11:19 +1200)]
Remove obsolete param from duplicated function
Eileen McNaughton [Mon, 29 Aug 2022 22:41:05 +0000 (10:41 +1200)]
Remove unreachable code
Eileen McNaughton [Mon, 29 Aug 2022 22:27:13 +0000 (10:27 +1200)]
Merge pull request #24402 from eileenmcnaughton/import_cont
Update Contribution import to use new v4 dedupe lookup
Eileen McNaughton [Mon, 29 Aug 2022 05:10:44 +0000 (17:10 +1200)]
Update Contribution import to use new v4 dedupe lookup
Eileen McNaughton [Mon, 29 Aug 2022 22:24:37 +0000 (10:24 +1200)]
Merge pull request #24401 from eileenmcnaughton/member_import
Switch Contact import to use new v4 dedupe lookup
Eileen McNaughton [Mon, 29 Aug 2022 19:34:00 +0000 (07:34 +1200)]
Merge pull request #24407 from braders/remove-misleading-comment
Remove misleading comment.
Eileen McNaughton [Mon, 29 Aug 2022 03:42:42 +0000 (15:42 +1200)]
Switch Contact import to use new v4 dedupe lookup
Eileen McNaughton [Sat, 27 Aug 2022 06:06:15 +0000 (18:06 +1200)]
Add tests for contact lookup
Eileen McNaughton [Mon, 29 Aug 2022 19:32:05 +0000 (07:32 +1200)]
Merge pull request #24384 from colemanw/api4Dedupe2
APIv4 - Add contact.getDuplicates action
Bradley Taylor [Mon, 29 Aug 2022 16:45:02 +0000 (17:45 +0100)]
Remove misleading comment.
Passing false to authenticateKey means execution doesn't actually abort,
and so the 'Failed to authenticate key' error is actually reached.
demeritcowboy [Mon, 29 Aug 2022 16:03:11 +0000 (12:03 -0400)]
Merge pull request #24406 from braders/invalid-eventid-notice
Stop PHP notice when accessing invalid event ID
demeritcowboy [Mon, 29 Aug 2022 13:12:49 +0000 (09:12 -0400)]
Merge pull request #24404 from braders/mailing_browse_tidyup
Tidy up whereClause method of mailing browse
demeritcowboy [Mon, 29 Aug 2022 13:12:23 +0000 (09:12 -0400)]
Merge pull request #24405 from braders/phpdoc-fixes2
PHPDoc comment fixes
Bradley Taylor [Mon, 29 Aug 2022 10:49:02 +0000 (11:49 +0100)]
Stop PHP notice when accessing invalid event ID
Bradley Taylor [Mon, 29 Aug 2022 10:30:22 +0000 (11:30 +0100)]
PHPDoc comment fixes
Bradley Taylor [Mon, 29 Aug 2022 10:09:32 +0000 (11:09 +0100)]
Tidy up whereClause method of mailing browse
Eileen McNaughton [Mon, 29 Aug 2022 09:23:51 +0000 (21:23 +1200)]
Merge pull request #24403 from totten/master-setlocale
(dev/translation#78) Allow partial/mixed locales. Define global `Locale` object.
Tim Otten [Mon, 29 Aug 2022 05:21:37 +0000 (22:21 -0700)]
(dev/translation#78) Locale::negotiate() - Implement true support for partial locales - More tests
Tim Otten [Mon, 29 Aug 2022 05:31:08 +0000 (22:31 -0700)]
(dev/translation#78) Civi\Core\Format - Abide by 'partial_locales' and `$locale->moneyFormat` - Fixup
Tim Otten [Thu, 25 Aug 2022 04:55:20 +0000 (21:55 -0700)]
(dev/translation#78) Locale::negotiate() - Implement true support for partial locales
Eileen McNaughton [Sat, 20 Aug 2022 01:44:29 +0000 (13:44 +1200)]
(dev/translation#78) Default nominal to expected type (string
Tim Otten [Mon, 8 Aug 2022 09:41:26 +0000 (02:41 -0700)]
(dev/translation#78) TokenProcessorTest - Test with and without 'partial_locales' support
Tim Otten [Mon, 8 Aug 2022 08:25:37 +0000 (01:25 -0700)]
(dev/translation#78) Civi\Core\Format - Abide by 'partial_locales' and `$locale->moneyFormat`
Tim Otten [Fri, 5 Aug 2022 10:02:04 +0000 (03:02 -0700)]
(dev/translation#78) I18nSubscriber - Allow partial/negotiated locales
Definitions:
* A fully-supported locale is valid in all localization services (eg
`ts()`, `Civi::format()`, `$dbLocale`).
* A "negotiated" or "mixed" locale can be used for communication, but
it is not fully supported by all other layers. Consequently, it
requires some kind of fallback or substitution.
Before:
* When an API call requests an alternate language (v3's `option.language` or
v4's `setLanguage()`), it only activates fully-supported locales.
* Specifically, it validates against the multilingual configuration -- those
are fully supported locales.) It otherwise ignores the alternate language.
After:
* When an API call requests an alternate language, it cacn activate
fully-supported locales as well as mixed locales.
* Specifically, it asks `Locale::negotiate(...)` to examine the local
configuration/resources and determine the effective locale.
Eileen McNaughton [Mon, 29 Aug 2022 02:56:00 +0000 (14:56 +1200)]
Merge pull request #24400 from totten/master-locale-pre
(REF) Tests - Misc updates in prepartion for l10n updates
Eileen McNaughton [Mon, 29 Aug 2022 00:37:34 +0000 (12:37 +1200)]
Merge pull request #24399 from totten/master-queue-ts
QueueItem - Convert DATETIME to TIMESTAMP
Tim Otten [Fri, 5 Aug 2022 10:00:29 +0000 (03:00 -0700)]
(dev/translation#78) When setting locale, track it as a `Civi\Core\Locale` instance
Tim Otten [Sun, 7 Aug 2022 23:56:51 +0000 (16:56 -0700)]
(dev/translation#78) Settings - Define partial_locales. Display on admin UI.
Tim Otten [Sun, 7 Aug 2022 23:56:14 +0000 (16:56 -0700)]
AutoClean - Add helper to temporarily modify settings
Tim Otten [Thu, 18 Aug 2022 08:10:17 +0000 (01:10 -0700)]
LocaleTestTrait - When activating 2+ locales, set languageLimit properly
Tim Otten [Fri, 26 Aug 2022 00:02:50 +0000 (17:02 -0700)]
(NFC) ContributionTest - Fix a couple more `@group`s. Fix misplaced `@group`
Tim Otten [Fri, 26 Aug 2022 20:40:11 +0000 (13:40 -0700)]
CiviUnitTestCase - Clear locale vars between all tests
Tim Otten [Sun, 28 Aug 2022 23:10:23 +0000 (16:10 -0700)]
Merge pull request #24387 from eileenmcnaughton/import_test
Minor import test cleanup
Tim Otten [Sun, 28 Aug 2022 22:27:47 +0000 (15:27 -0700)]
Merge pull request #24397 from eileenmcnaughton/run_poof
Minor readability cleanup - remove code comments about removed item, comments
Tim Otten [Sat, 27 Aug 2022 05:32:46 +0000 (22:32 -0700)]
Upgrade - Convert civicrm_queue_item (DATETIME=>TIMESTAMP; 5.54.alpha1)
Tim Otten [Sat, 27 Aug 2022 00:40:01 +0000 (17:40 -0700)]
QueueItem - Mark submit_time and release_time as TIMESTAMP
Eileen McNaughton [Sat, 27 Aug 2022 05:49:15 +0000 (17:49 +1200)]
Merge pull request #24374 from eileenmcnaughton/import_unique_cont_better
[Ref] Import cleanup code that looks up contribution in import
Eileen McNaughton [Sat, 27 Aug 2022 01:25:26 +0000 (13:25 +1200)]
Improve test error checking
colemanw [Sat, 27 Aug 2022 02:23:43 +0000 (22:23 -0400)]
Merge pull request #24343 from eileenmcnaughton/w_search
Add Saved searches to view import jobs
colemanw [Sat, 27 Aug 2022 02:22:51 +0000 (22:22 -0400)]
Merge pull request #24371 from eileenmcnaughton/import_defaults_js
Fix broken js on Contribution Import
Eileen McNaughton [Sat, 27 Aug 2022 02:09:03 +0000 (14:09 +1200)]
Merge pull request #24395 from totten/master-release-time
Queue API - Expose option for delayed tasks (`$options['release_time']`)
Eileen McNaughton [Sat, 27 Aug 2022 02:04:22 +0000 (14:04 +1200)]
Minor cleanup - remove code comments about removed item, comments
Eileen McNaughton [Sat, 27 Aug 2022 01:23:22 +0000 (13:23 +1200)]
Make validation output clearer
Eileen McNaughton [Wed, 24 Aug 2022 09:53:15 +0000 (21:53 +1200)]
[Ref] Import cleanup code that looks up contribution in import
Eileen McNaughton [Sat, 27 Aug 2022 01:05:58 +0000 (13:05 +1200)]
Merge pull request #24392 from totten/master-nfc-list
(NFC) Autoformat big clusters of `list()` statements
Tim Otten [Fri, 26 Aug 2022 23:01:13 +0000 (16:01 -0700)]
Queues - Allow passing `$options['release_time']` for new tasks
Tim Otten [Fri, 26 Aug 2022 21:49:38 +0000 (14:49 -0700)]
(NFC) tests/ - Autoformat big clumps of `list()` statements
Based on a quick grep, these files had a lot of `list()` statements, so I let PHPStorm clean them up.
Tim Otten [Fri, 26 Aug 2022 21:46:37 +0000 (14:46 -0700)]
(NFC) Civi - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:40:19 +0000 (14:40 -0700)]
(NFC) CRM/ - Autoformat big clumps of `list()` statements
Based on a quick grep, these files had a lot of `list()` statements, so I let PHPStorm clean them up.
Tim Otten [Fri, 26 Aug 2022 21:39:10 +0000 (14:39 -0700)]
(NFC) CRM/Upgrade - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:22:40 +0000 (14:22 -0700)]
(NFC) CRM/Contact - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:16:04 +0000 (14:16 -0700)]
(NFC) CRM/Core - Autoformat `list()` statements
Tim Otten [Fri, 26 Aug 2022 21:15:09 +0000 (14:15 -0700)]
(NFC) CRM/Core/BAO - Autoformat `list()` statements
Eileen McNaughton [Fri, 26 Aug 2022 20:07:43 +0000 (08:07 +1200)]
Merge pull request #23658 from kurund/mailing-bounce-type-fixes
Issue/core#3489: Increase field size for mailing bounce type
demeritcowboy [Fri, 26 Aug 2022 19:54:18 +0000 (15:54 -0400)]
Merge pull request #24383 from mattwire/oauth
OAuth fixes
Eileen McNaughton [Fri, 26 Aug 2022 19:53:48 +0000 (07:53 +1200)]
Merge pull request #24391 from colemanw/activityTask
SearchKit - Add activity task
Matthew Wire [Thu, 25 Aug 2022 14:15:22 +0000 (15:15 +0100)]
Cleanup comments / README
Coleman Watts [Fri, 26 Aug 2022 15:32:47 +0000 (11:32 -0400)]
SearchKit - Add activity task
demeritcowboy [Fri, 26 Aug 2022 12:05:01 +0000 (08:05 -0400)]
Merge pull request #24390 from eileenmcnaughton/less_params
[REF] Variable use cleanup
Seamus Lee [Fri, 26 Aug 2022 05:57:42 +0000 (15:57 +1000)]
Merge pull request #24340 from eileenmcnaughton/install
Move participant cancel tests to extension
Eileen McNaughton [Fri, 26 Aug 2022 04:41:09 +0000 (16:41 +1200)]
[REF] Variable use cleanup
Eileen McNaughton [Fri, 26 Aug 2022 04:35:28 +0000 (16:35 +1200)]
Use shared parent formRule in custom import api
Eileen McNaughton [Wed, 24 Aug 2022 05:10:01 +0000 (17:10 +1200)]
Minor code cleaup - the form rule is in the parent function
colemanw [Fri, 26 Aug 2022 03:15:07 +0000 (23:15 -0400)]
Merge pull request #24377 from eileenmcnaughton/import_part
Fix participant import not to import to deleted contacts
Eileen McNaughton [Wed, 24 Aug 2022 06:33:08 +0000 (18:33 +1200)]
Simplify form name - we know what it is
Eileen McNaughton [Wed, 24 Aug 2022 06:25:41 +0000 (18:25 +1200)]
Contribution import - Sigh - ok - I fixed the broken js
Eileen McNaughton [Wed, 24 Aug 2022 05:50:35 +0000 (17:50 +1200)]
[REF] Extract function to determine defaults in Contribution.MapField
Eileen McNaughton [Wed, 24 Aug 2022 05:10:01 +0000 (17:10 +1200)]
Minor code cleaup - the form rule is in the parent function
colemanw [Fri, 26 Aug 2022 03:12:22 +0000 (23:12 -0400)]
Merge pull request #24380 from eileenmcnaughton/member_import
Membership import - Simplify contact_id validation & avoid deleted contacts
Eileen McNaughton [Fri, 26 Aug 2022 02:57:10 +0000 (14:57 +1200)]
Merge pull request #24386 from eileenmcnaughton/inst_deprecate
Deprecate horrible function + unreleased regression
Eileen McNaughton [Thu, 25 Aug 2022 23:30:56 +0000 (11:30 +1200)]
Minor code styling fixes
Eileen McNaughton [Fri, 26 Aug 2022 00:50:17 +0000 (12:50 +1200)]
Merge pull request #24385 from colemanw/dedupeRuleGroupName
Add unique index to DedupeRuleGroup.name field
Eileen McNaughton [Wed, 6 Jul 2022 10:25:24 +0000 (22:25 +1200)]
Adapt test to form cleanup
Eileen McNaughton [Thu, 25 Aug 2022 23:46:43 +0000 (11:46 +1200)]
Fix unreleased regression - loadSavedMapping is protected
Eileen McNaughton [Wed, 24 Aug 2022 05:19:07 +0000 (17:19 +1200)]
Deprecate horrible function
Eileen McNaughton [Thu, 25 Aug 2022 23:27:46 +0000 (11:27 +1200)]
Mark one version of test incomplete
Its not worth getting to the bottom of why they won't both run
Eileen McNaughton [Mon, 22 Aug 2022 02:43:41 +0000 (14:43 +1200)]
Remove now-obsolete use & superficial code standard fixes
Eileen McNaughton [Mon, 22 Aug 2022 01:06:31 +0000 (13:06 +1200)]
Move participant cancel tests to extension
Coleman Watts [Thu, 25 Aug 2022 16:21:12 +0000 (12:21 -0400)]
Add unique index to DedupeRuleGroup.name field
demeritcowboy [Thu, 25 Aug 2022 16:59:00 +0000 (12:59 -0400)]
Merge pull request #24382 from kurund/case-dashboard-activity-listing
dev/core#3822 - On case dashboard sort the recently performed activities by most recent first
colemanw [Thu, 25 Aug 2022 15:39:04 +0000 (11:39 -0400)]
Merge pull request #24381 from demeritcowboy/keep
Warning popup about copy of extension in system path disappears too fast
Coleman Watts [Fri, 1 Oct 2021 14:17:36 +0000 (10:17 -0400)]
APIv4 - Add Contact.getDuplicates action
Matthew Wire [Thu, 25 Aug 2022 14:32:36 +0000 (15:32 +0100)]
Merge pull request #24232 from mattwire/propertybagbillingcountry
Add missing country=>billingCountry to PropertyBag mapping
Matthew Wire [Thu, 25 Aug 2022 14:12:35 +0000 (15:12 +0100)]
Replace deprecated getTimeRaw with time
Matthew Wire [Thu, 25 Aug 2022 14:18:58 +0000 (15:18 +0100)]
API4 checkPermissions 0 => FALSE
Matthew Wire [Thu, 25 Aug 2022 14:18:03 +0000 (15:18 +0100)]
Force OAuth RedirectURL to always be backend URL. Otherwise it may get generated as frontend URL and fail to authenticate eg. when 'Inbound email' job run via CRON
Kurund Jalmi [Thu, 25 Aug 2022 13:45:16 +0000 (14:45 +0100)]
fix the ordering of recent activities on case dashboard
Coleman Watts [Thu, 25 Aug 2022 12:58:33 +0000 (08:58 -0400)]
REF - Extract CRM_Utils_Array::filterByPrefix
Coleman Watts [Thu, 25 Aug 2022 12:57:50 +0000 (08:57 -0400)]
REF - Extract CRM_Contact_BAO_Contact::findDuplicates
Eileen McNaughton [Thu, 25 Aug 2022 07:36:44 +0000 (19:36 +1200)]
Merge pull request #24379 from eileenmcnaughton/add_field
Finally full remove the awful addField from import