Eileen McNaughton [Fri, 2 Feb 2024 22:50:48 +0000 (11:50 +1300)]
Merge pull request #29192 from eileenmcnaughton/570_2
Fix 5.67 regression on loading custom data defaults on contribution page
colemanw [Fri, 2 Feb 2024 22:11:57 +0000 (17:11 -0500)]
Merge pull request #29206 from colemanw/fixInvalidLinks
SearchKit - Hide invalid links and prevent error
colemanw [Fri, 2 Feb 2024 16:28:11 +0000 (11:28 -0500)]
SearchKit - Hide invalid links and prevent error
Fixes dev/core#4961
colemanw [Fri, 2 Feb 2024 20:53:53 +0000 (15:53 -0500)]
Merge pull request #29203 from eileenmcnaughton/url
dev/core#4962 Fix Smarty fatal on resource url page
eileen [Fri, 2 Feb 2024 19:12:05 +0000 (08:12 +1300)]
dev/core#4962 Fix Smarty fatal on resource url page
eileen [Fri, 2 Feb 2024 04:05:20 +0000 (17:05 +1300)]
Fix 5.67 regression on loading custom data defaults on contribution page
colemanw [Fri, 2 Feb 2024 11:57:24 +0000 (06:57 -0500)]
Merge pull request #29180 from colemanw/selectTab
SearchKit - Fix switching to nonexistent tab
Seamus Lee [Fri, 2 Feb 2024 03:37:48 +0000 (14:37 +1100)]
Merge pull request #29189 from seamuslee001/dev_ui_65
dev/user-interface#65 Remove top set of buttons which only show up in…
Seamus Lee [Fri, 2 Feb 2024 02:40:28 +0000 (13:40 +1100)]
dev/user-interface#65 Remove top set of buttons which only show up in non popup form
colemanw [Thu, 1 Feb 2024 02:22:49 +0000 (21:22 -0500)]
SearchKit - Fix switching to nonexistent tab
Tabs were recently renamed so this keeps up with the change.
Seamus Lee [Wed, 31 Jan 2024 23:15:20 +0000 (10:15 +1100)]
Merge pull request #28971 from mattwire/firebase
Fix fatal error when firebase/php-jwt library is 'replaced' in composer
Matthew Wire [Thu, 11 Jan 2024 12:46:57 +0000 (12:46 +0000)]
Fix fatal error when firebase/php-jwt library is 'replaced' in composer
Tim Otten [Wed, 31 Jan 2024 07:14:20 +0000 (23:14 -0800)]
Merge pull request #29107 from eileenmcnaughton/570_no_wiz
Remove attempt to use wizard on manage ACLs
Tim Otten [Wed, 31 Jan 2024 06:57:59 +0000 (22:57 -0800)]
Merge pull request #29092 from colemanw/getAutocompleteParams
dev/core#4937 - Fix js error in formBuilder autocompletes
Tim Otten [Wed, 31 Jan 2024 06:15:32 +0000 (22:15 -0800)]
Merge pull request #29112 from eileenmcnaughton/570_mem
dev/core#4939 Fix failure to load existing membership info on online membership page
colemanw [Tue, 30 Jan 2024 15:05:16 +0000 (10:05 -0500)]
Merge pull request #29155 from colemanw/colIndex
crmDashboard - Fix deleting item from 2nd column
colemanw [Mon, 29 Jan 2024 20:41:51 +0000 (15:41 -0500)]
crmDashboard - Fix deleting item from 2nd column
demeritcowboy [Mon, 29 Jan 2024 13:28:55 +0000 (08:28 -0500)]
Merge pull request #29143 from colemanw/excludeCaseActivities
Fix dev/core#4943 - Exclude case activities from count if appropriate
colemanw [Mon, 29 Jan 2024 04:02:38 +0000 (23:02 -0500)]
Fix dev/core#4943 - Exclude case activities from count if appropriate
colemanw [Mon, 29 Jan 2024 03:36:52 +0000 (22:36 -0500)]
Merge pull request #29118 from eileenmcnaughton/570_patrick
When auto-renew option is available, show the checkbox immediately in…
colemanw [Sun, 28 Jan 2024 22:09:48 +0000 (17:09 -0500)]
Merge pull request #29115 from eileenmcnaughton/570
dev/core#4917 Ensure total is always updated when other amount is selected
Patrick Lam [Tue, 16 Jan 2024 11:03:44 +0000 (00:03 +1300)]
When auto-renew option is available, show the checkbox immediately instead of upon clicking the price.
memTypeId was previously "undefined" after trying to read attribute
"membership-type". The DOM shows an attribute
"data-membership-type-id" and this patch modifies the attribute read
to "data-membership-type-id", which is also consistent with the
variable name in the code.
eileen [Sat, 27 Jan 2024 20:04:39 +0000 (09:04 +1300)]
Ensure total is always updated when other amount is selected
Eileen McNaughton [Sat, 27 Jan 2024 19:50:35 +0000 (08:50 +1300)]
Merge pull request #29113 from eileenmcnaughton/christian
Fix JS error and allow focus of Other Amount field
Christian Wach [Wed, 17 Jan 2024 13:41:19 +0000 (13:41 +0000)]
Fix JS error and allow focus of Other Amount field
eileen [Sat, 27 Jan 2024 06:28:22 +0000 (19:28 +1300)]
dev/core#4939 Fix failure to load existing membership info on online membership page
Eileen McNaughton [Sat, 27 Jan 2024 02:12:51 +0000 (15:12 +1300)]
Merge pull request #29097 from demeritcowboy/grouprole
dev/core#4938 - crash after saving a civireport
eileen [Sat, 27 Jan 2024 02:01:27 +0000 (15:01 +1300)]
Remove attempt to use wizard on manage ACLs
demeritcowboy [Fri, 26 Jan 2024 17:15:40 +0000 (12:15 -0500)]
the field needs null
demeritcowboy [Fri, 26 Jan 2024 16:48:50 +0000 (11:48 -0500)]
Merge pull request #29091 from wmortada/accordion
Invert logic for collapsing contact dashboard accordion
William Mortada [Fri, 26 Jan 2024 09:14:23 +0000 (09:14 +0000)]
Invert logic for accordion open
colemanw [Fri, 26 Jan 2024 15:11:43 +0000 (10:11 -0500)]
dev/core#4937 - Fix js error in formBuilder autocompletes
Due to
5071a76 this field was fetching form values during every digest cycle and in some
cases this was causing an infinite loop. Updated the field to only fetch values when needed.
colemanw [Thu, 25 Jan 2024 23:09:10 +0000 (18:09 -0500)]
Merge pull request #29086 from totten/5.70-unsub-wp
(dev/core#4641) ListUnsubscribe - Fix HTTP URL generation on WordPress
Tim Otten [Thu, 25 Jan 2024 00:07:27 +0000 (16:07 -0800)]
ListUnsubscribe - Fix HTTP URL generation on WP/J
Tim Otten [Wed, 24 Jan 2024 22:02:42 +0000 (14:02 -0800)]
Merge pull request #28964 from totten/5.70-unsub-overload
(dev/core#4641) CiviMail - Add support for One-Click unsubscribes
Eileen McNaughton [Wed, 24 Jan 2024 20:01:32 +0000 (09:01 +1300)]
Merge pull request #29080 from demeritcowboy/formprop
Avoid crash in extensions that call getVar
colemanw [Wed, 24 Jan 2024 17:02:35 +0000 (12:02 -0500)]
Merge pull request #29073 from mlutfy/core4930
dev/core#4930 Fix Activity count when contact is assigned multiple roles
demeritcowboy [Wed, 24 Jan 2024 16:39:16 +0000 (11:39 -0500)]
Merge pull request #29079 from demeritcowboy/missing-sms
dev/core#4932 - Bring back missing actions when viewing contact summary
demeritcowboy [Wed, 24 Jan 2024 16:22:22 +0000 (11:22 -0500)]
avoid crash
demeritcowboy [Wed, 24 Jan 2024 15:52:12 +0000 (10:52 -0500)]
bring back missing actions
Tim Otten [Wed, 24 Jan 2024 05:19:27 +0000 (21:19 -0800)]
ListUnsubscribe - Production sites really should use HTTPS
Tim Otten [Thu, 18 Jan 2024 05:51:18 +0000 (21:51 -0800)]
ListUnsubscribe - Ensure URL is always absolute
When delivering via unit-test or cron job, the URL came out absolute.
But when using web UI to "Send test", the URL was relative.
It should be absolute.
Tim Otten [Wed, 17 Jan 2024 22:36:55 +0000 (14:36 -0800)]
ListUnsubscribe - Fix VERP parsing (alternate separators; optional localpart-prefix)
Tim Otten [Thu, 11 Jan 2024 04:23:55 +0000 (20:23 -0800)]
(REF) Move testGitLabIssue1108() to its own class
BEFORE: `MailingSystemTest` (which extends `BaseMailingSystemTest`)
includes `testGitLabIssue1108($isMultilingual)`. This is
a transactional test (per `BaseMailingSystemTest::setUp()`).
AFTER: `MultingualSystemTest` includes `testGitLabIssue1108()`.
This is not a transactional test.
COMMENTS: This resolves some circumstantial flakiness in the tests.
* The problem appeared when adding an unrelated test `BaseMailingSystemTest` -- the
new test failed because of a conflict with `testGitLabIssue1108()`.
* You could also produce the problem in other cases by switching around the order of
`testGitLabIssue1108()` (e.g. hack data-provider `multiLingual()`)
* I believe the root problem is that `BaseMailingSystemTest` is written as
a transactional test -- but `testGitLabIssue1108()` does large-scale
schema changes (whenever it toggles multilingual), which makes it
non-transactional.
* The patch here prevents these kind of conflicts by putting
`testGitLabIssue1108()` in a separate (non-transactional) context.
Tim Otten [Thu, 11 Jan 2024 00:13:20 +0000 (16:13 -0800)]
CiviMail - Add status-check for civimail_unsubscribe_methods
Tim Otten [Tue, 9 Jan 2024 04:09:32 +0000 (20:09 -0800)]
CiviMail - Implement List-Unsubscibe=One-Click (with overloaded routing)
colemanw [Wed, 24 Jan 2024 01:31:57 +0000 (20:31 -0500)]
Merge pull request #29072 from colemanw/serviceName
Fix metadata cache clear event
colemanw [Tue, 23 Jan 2024 15:16:01 +0000 (10:16 -0500)]
Fix metadata cache clear event
Mathieu Lu [Tue, 23 Jan 2024 17:01:35 +0000 (12:01 -0500)]
dev/core#4930 Fix Activity count when contact is assigned multiple roles
Yashodha Chaku [Tue, 23 Jan 2024 07:01:37 +0000 (12:31 +0530)]
Merge pull request #29069 from seamuslee001/fix_type_error_non_quickform_price_set_membership
Fix Checking Auto renew for Non Quick Config Price Set when Membershi…
Seamus Lee [Tue, 23 Jan 2024 04:55:01 +0000 (15:55 +1100)]
Fix Checking Auto renew for Non Quick Config Price Set when Membership Type Auto renew is null
Eileen McNaughton [Sun, 21 Jan 2024 21:26:18 +0000 (10:26 +1300)]
Merge pull request #29058 from mlutfy/contactRelHelp570
Contact Relationships: alter markup for help texts
Mathieu Lu [Sun, 21 Jan 2024 20:14:29 +0000 (15:14 -0500)]
Contact Relationships: alter markup for help texts
Mathieu Lu [Fri, 19 Jan 2024 19:47:08 +0000 (14:47 -0500)]
Merge pull request #29049 from colemanw/fixRelationshipLinks
Fix missing links on contact summary relationships tab
colemanw [Fri, 19 Jan 2024 14:23:59 +0000 (09:23 -0500)]
Fix missing links on contact summary relationships tab
Seamus Lee [Wed, 17 Jan 2024 21:02:54 +0000 (08:02 +1100)]
Merge pull request #29039 from colemanw/relationshipLinkTarget
ContactSummary - Don't open new tab for links
colemanw [Wed, 17 Jan 2024 18:01:42 +0000 (13:01 -0500)]
ContactSummary - Don't open new tab for links
demeritcowboy [Tue, 16 Jan 2024 18:58:41 +0000 (13:58 -0500)]
Merge pull request #29025 from colemanw/searchKitAggregateFix
SearchKit - Fix missing transformations in UI
colemanw [Tue, 16 Jan 2024 12:28:00 +0000 (07:28 -0500)]
SearchKit - Fix missing transformations in UI
This regressed during
e3ad1ff86b89539d5f6718cb155cdd59c8a07f37
demeritcowboy [Tue, 16 Jan 2024 01:47:03 +0000 (20:47 -0500)]
Merge pull request #29016 from awestuk/other-amount-focus
dev/core#4912 Fix 'other amount' losing focus
Andrew West [Mon, 15 Jan 2024 16:29:19 +0000 (16:29 +0000)]
dev/core#4912 Fix 'other amount' losing focus
https://lab.civicrm.org/dev/core/-/issues/4912
demeritcowboy [Mon, 15 Jan 2024 19:04:36 +0000 (14:04 -0500)]
Merge pull request #29003 from MegaphoneJon/missing-subtype-custom-fields-on-create
restore custom fields for contact subtypes on create
Jon Goldberg [Sat, 13 Jan 2024 20:11:44 +0000 (15:11 -0500)]
restore custom fields for contact subtypes on create
Eileen McNaughton [Sat, 13 Jan 2024 03:14:18 +0000 (16:14 +1300)]
Merge pull request #29000 from demeritcowboy/lineitem2
fix ts
demeritcowboy [Sat, 13 Jan 2024 01:42:30 +0000 (20:42 -0500)]
fix ts
Tim Otten [Wed, 10 Jan 2024 21:54:41 +0000 (13:54 -0800)]
(REF) civicrm/mailing/unsubscribe - Add page-controller in front of form-controller
Before: `civicrm/mailing/unsubscribe` points directly to `CRM_Mailing_Form_Unsubscribe`
After: `civicrm/mailing/unsubscribe` points to `CRM_Mailing_Page_Unsubscribe`, which MAY delegate
to `CRM_Mailing_Form_Unsubscribe`
Comments:
* This is a step toward supporting one-click subscribe.
* The problem is that one-click unsubscribe MUST receive a POST on the same URL
as a user-visible form.
* In Quickform (esp `CRM_Mailing_Form_Unsubscribe`), every POST MUST give a `qfKey`.
* We need a place to process the one-click POST *without* requiring `qfKey`.
* There is a pre-existing class `CRM_Mailing_Page_Unsubscribe`. This was dead code.
The patch co-opts/re-uses the class for its own purpose.
* The old `Page` class was not referenced anywhere (by routes or other classes).
* What appears to have happened: this screen was originally a `Page`; then it was
renamed/converted to a `Form`; then shortly after, the original `Page` was re-imported
verbatim by a gsoc student. Their commit doesn't appear to make substantive use of
the `Page`. This smells like mistake in handling branches/merges/rebases.
Tim Otten [Thu, 11 Jan 2024 00:09:53 +0000 (16:09 -0800)]
Status Check Actions - Allow off-site info link ("More info"). Update docblock.
Tim Otten [Wed, 10 Jan 2024 20:43:06 +0000 (12:43 -0800)]
(NFC) Unsubscribe - Placate PhpStorm
Tim Otten [Tue, 9 Jan 2024 08:13:42 +0000 (00:13 -0800)]
LocalHttpClient - How do you make an internal/headless HTTP request?
Tim Otten [Tue, 9 Jan 2024 04:18:38 +0000 (20:18 -0800)]
CRM_Utils_System::sendResponse() - Provide copy of $response for testers
colemanw [Fri, 12 Jan 2024 21:17:58 +0000 (16:17 -0500)]
Merge pull request #28994 from demeritcowboy/lineitem
smarty3 - crash on viewing contribution
colemanw [Fri, 12 Jan 2024 20:47:48 +0000 (15:47 -0500)]
Merge pull request #28893 from eileenmcnaughton/570
Fix rc-only regression - back-office registration does not reload contact ID
colemanw [Fri, 12 Jan 2024 20:41:35 +0000 (15:41 -0500)]
Merge pull request #28966 from eileenmcnaughton/unsub
Remove possibly-unavailable job_id from unsub function
demeritcowboy [Fri, 12 Jan 2024 18:51:14 +0000 (13:51 -0500)]
fix order of operations
Eileen McNaughton [Thu, 11 Jan 2024 22:55:57 +0000 (11:55 +1300)]
Merge pull request #28959 from seamuslee001/5.70
[REF] Fix Hard Fail when loading back office add membership form with membe…
Tim Otten [Thu, 11 Jan 2024 21:37:10 +0000 (13:37 -0800)]
Merge pull request #28933 from eileenmcnaughton/570_import
dev/core#4781 Handle invalid deprecated fields with more grace
Yashodha Chaku [Thu, 11 Jan 2024 17:56:47 +0000 (23:26 +0530)]
Merge pull request #28970 from pradpnayak/cmsissue
Regression: fix CMS creation issue from profile
Pradeep Nayak [Thu, 11 Jan 2024 11:25:04 +0000 (11:25 +0000)]
fix CMS creation issue from profile
colemanw [Thu, 11 Jan 2024 12:25:36 +0000 (07:25 -0500)]
Merge pull request #28957 from colemanw/caseCrashFix
CiviCase - Fix crash when fetching status_id pseudoconstant
eileen [Thu, 11 Jan 2024 01:21:57 +0000 (14:21 +1300)]
Do not use job_id when looking up the mailin in unsubscribe table
eileen [Thu, 11 Jan 2024 01:13:40 +0000 (14:13 +1300)]
Remove possibly-unavailable job_id from unsub function
Seamus Lee [Thu, 11 Jan 2024 01:11:27 +0000 (12:11 +1100)]
Merge pull request #28962 from demeritcowboy/cancelurl
dev/core#4903 - undefined variable in New Individual on-the-fly popup
Seamus Lee [Wed, 10 Jan 2024 21:15:21 +0000 (08:15 +1100)]
Fix Hard Fail when loading back office add membership form with membership types with no minimum fee set
Switch to numeric 0
demeritcowboy [Thu, 11 Jan 2024 00:29:26 +0000 (19:29 -0500)]
undefined variable
eileen [Mon, 8 Jan 2024 03:29:10 +0000 (16:29 +1300)]
dev/core#4781 Handle invalid deprecated fields with more grace
colemanw [Wed, 10 Jan 2024 18:11:48 +0000 (13:11 -0500)]
CiviCase - Fix crash when fetching status_id pseudoconstant
Fixes crash reported in https://civicrm.stackexchange.com/q/46209
Seamus Lee [Wed, 10 Jan 2024 05:31:15 +0000 (16:31 +1100)]
Merge pull request #28952 from eileenmcnaughton/570_links
dev/core#4898 Add getLinks to Import api
eileen [Wed, 10 Jan 2024 04:15:11 +0000 (17:15 +1300)]
dev/core#4898 Add getLinks to Import api
Eileen McNaughton [Tue, 9 Jan 2024 23:23:54 +0000 (12:23 +1300)]
Merge pull request #28944 from ufundo/search-kit-action-links
dev/core#4897 Fix Search Kit row link conditions
Tim Otten [Tue, 9 Jan 2024 22:57:29 +0000 (14:57 -0800)]
Merge pull request #28928 from eileenmcnaughton/570-ev
dev/core#4893 Fix failure to send event emails on non-monetary events with no confirm page
benjamin [Tue, 9 Jan 2024 21:44:18 +0000 (21:44 +0000)]
conditional operator precedence fix
Tim Otten [Tue, 9 Jan 2024 21:36:22 +0000 (13:36 -0800)]
Merge pull request #28913 from eileenmcnaughton/570_ornery
Make fail-heavy test as ornery
Eileen McNaughton [Tue, 9 Jan 2024 21:05:40 +0000 (10:05 +1300)]
Merge pull request #28942 from seamuslee001/5.70
Bump follow-redirects from 1.14.8 to 1.15.4
dependabot[bot] [Tue, 9 Jan 2024 17:35:03 +0000 (17:35 +0000)]
Bump follow-redirects from 1.14.8 to 1.15.4
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.8 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.8...v1.15.4)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
demeritcowboy [Mon, 8 Jan 2024 14:27:12 +0000 (09:27 -0500)]
Merge pull request #28931 from eileenmcnaughton/570-weight
dev/core#4892 dev/core#4891 fix weight notices
eileen [Mon, 8 Jan 2024 00:34:56 +0000 (13:34 +1300)]
dev/core#4892 dev/core#4891 fix weight notices
eileen [Mon, 8 Jan 2024 00:07:50 +0000 (13:07 +1300)]
dev/core#4893 Fix failure to send event emails on non-monetary evetns with no confirm page
colemanw [Sun, 7 Jan 2024 23:56:45 +0000 (18:56 -0500)]
Merge pull request #28922 from colemanw/deleted-files-exclude
dev/core#4889 - Exclude tools & tests from deleted-files-list.json
colemanw [Sat, 6 Jan 2024 20:11:10 +0000 (15:11 -0500)]
Merge pull request #28907 from mlutfy/ui64
dev/user-interface#64 civicrm.css: fix cancel/done button alignment
colemanw [Sat, 6 Jan 2024 15:11:07 +0000 (10:11 -0500)]
dev/core#4889 - Exclude tools & tests from deleted-files-list.json