civicrm-core.git
21 months agoMerge pull request #25587 from herbdool/core-4127-7b
demeritcowboy [Thu, 23 Feb 2023 00:40:30 +0000 (19:40 -0500)]
Merge pull request #25587 from herbdool/core-4127-7b

dev/core#4127 move Drupal stuff in getCiviSourceStorage to Drupal useā€¦

21 months agoMerge pull request #25642 from eileenmcnaughton/uffield
demeritcowboy [Wed, 22 Feb 2023 03:36:11 +0000 (22:36 -0500)]
Merge pull request #25642 from eileenmcnaughton/uffield

Fix add version for civicrm_custom_field.fk_entity

21 months agoFix add version for civicrm_custom_field.fk_entity
Eileen McNaughton [Wed, 22 Feb 2023 01:38:15 +0000 (14:38 +1300)]
Fix add version for civicrm_custom_field.fk_entity

Per https://github.com/civicrm/civicrm-core/pull/25638#issuecomment-1439256431

21 months agoMerge pull request #25600 from eileenmcnaughton/import_sql
Eileen McNaughton [Wed, 22 Feb 2023 01:10:29 +0000 (14:10 +1300)]
Merge pull request #25600 from eileenmcnaughton/import_sql

Fix handling of invalid sql query during import

21 months agoMerge pull request #25640 from civicrm/5.59
Eileen McNaughton [Wed, 22 Feb 2023 01:08:48 +0000 (14:08 +1300)]
Merge pull request #25640 from civicrm/5.59

5.59 to master

21 months agoMerge pull request #25638 from eileenmcnaughton/upgrade_fix
Eileen McNaughton [Wed, 22 Feb 2023 01:06:07 +0000 (14:06 +1300)]
Merge pull request #25638 from eileenmcnaughton/upgrade_fix

Fix master-only regression - upgrade script is in wrong version

21 months agoMerge pull request #25633 from eileenmcnaughton/559
Tim Otten [Wed, 22 Feb 2023 00:29:23 +0000 (16:29 -0800)]
Merge pull request #25633 from eileenmcnaughton/559

PEAR Exception handling - Mitigation of scenario where an import table has been deleted and the metadata is out of date

21 months agoMerge pull request #25573 from herbdool/core-4127-3
demeritcowboy [Wed, 22 Feb 2023 00:11:06 +0000 (19:11 -0500)]
Merge pull request #25573 from herbdool/core-4127-3

dev/core#4127 move is_drupal to use userSystem logger

21 months agoFix master-only regression
Eileen McNaughton [Tue, 21 Feb 2023 23:55:05 +0000 (12:55 +1300)]
Fix master-only regression

I merged https://github.com/civicrm/civicrm-core/pull/25471 yesterday,
well after 5.60 branch forked, into master. However, it
includes upgrade script targetting 5.59 - which means that
for anyone already on 5.59 it doesn't run. This moves
it to the correct branch (5.60 aka master)

21 months agoFix fatal on datasource error
Eileen McNaughton [Tue, 21 Feb 2023 00:35:42 +0000 (13:35 +1300)]
Fix fatal on datasource error

21 months agoMerge pull request #25637 from civicrm/5.59
Seamus Lee [Tue, 21 Feb 2023 23:21:10 +0000 (10:21 +1100)]
Merge pull request #25637 from civicrm/5.59

5.59

21 months agoMerge pull request #25602 from eileenmcnaughton/import_set_path
Matthew Wire [Tue, 21 Feb 2023 22:20:25 +0000 (22:20 +0000)]
Merge pull request #25602 from eileenmcnaughton/import_set_path

Add 'SavePoint' to import to statusBounce back to

21 months agoMerge pull request #25549 from eileenmcnaughton/no_post
colemanw [Tue, 21 Feb 2023 22:17:06 +0000 (17:17 -0500)]
Merge pull request #25549 from eileenmcnaughton/no_post

Fix custom field bug on UFMatch sync

21 months agoMerge pull request #25457 from eileenmcnaughton/notice_cont_view
colemanw [Tue, 21 Feb 2023 22:12:14 +0000 (17:12 -0500)]
Merge pull request #25457 from eileenmcnaughton/notice_cont_view

Move form specific code to the form

21 months agoMerge pull request #25522 from eileenmcnaughton/dedupe
colemanw [Tue, 21 Feb 2023 22:11:12 +0000 (17:11 -0500)]
Merge pull request #25522 from eileenmcnaughton/dedupe

Make dedupe exceptions searchable in SearchKit

21 months agoMerge pull request #25612 from eileenmcnaughton/ical_notice
colemanw [Tue, 21 Feb 2023 22:09:28 +0000 (17:09 -0500)]
Merge pull request #25612 from eileenmcnaughton/ical_notice

E-notice fix Ical display

21 months agodev/core#4127 move is_drupal to use userSystem logger
Herb v/d Dool [Tue, 14 Feb 2023 21:46:37 +0000 (16:46 -0500)]
dev/core#4127 move is_drupal to use userSystem logger

21 months agoMerge pull request #25392 from eileenmcnaughton/prev_next_divide
Tim Otten [Tue, 21 Feb 2023 07:09:26 +0000 (23:09 -0800)]
Merge pull request #25392 from eileenmcnaughton/prev_next_divide

dev/core#4112 Privatise `prevNextCache` functions

21 months agoMerge pull request #25446 from lemniscus/oauth-reduce-dns-queries
Tim Otten [Tue, 21 Feb 2023 06:58:34 +0000 (22:58 -0800)]
Merge pull request #25446 from lemniscus/oauth-reduce-dns-queries

Reduce unneeded DNS queries during OAuth flow

21 months agoMerge pull request #25631 from eileenmcnaughton/poly
Eileen McNaughton [Tue, 21 Feb 2023 06:38:39 +0000 (19:38 +1300)]
Merge pull request #25631 from eileenmcnaughton/poly

composer require --dev yoast/phpunit-polyfills

21 months agoMerge pull request #25511 from eileenmcnaughton/dep_token6
Tim Otten [Tue, 21 Feb 2023 05:08:30 +0000 (21:08 -0800)]
Merge pull request #25511 from eileenmcnaughton/dep_token6

Extra deprecation for clarity on token function `convertPseudoConstantsUsingMetadata`

21 months agoMerge pull request #25598 from colemanw/PledgeAutocomplete
Eileen McNaughton [Tue, 21 Feb 2023 04:26:32 +0000 (17:26 +1300)]
Merge pull request #25598 from colemanw/PledgeAutocomplete

Add APIv4 Pledge Autocomplete

21 months agoMerge pull request #25630 from colemanw/phpQueryEncodeBug
Tim Otten [Tue, 21 Feb 2023 04:07:16 +0000 (20:07 -0800)]
Merge pull request #25630 from colemanw/phpQueryEncodeBug

Angular Coder: Fix unescaping of quotes breaking attributes

21 months agoMerge pull request #25632 from colemanw/formatCustomValue
Seamus Lee [Tue, 21 Feb 2023 02:50:31 +0000 (13:50 +1100)]
Merge pull request #25632 from colemanw/formatCustomValue

EntityRef - Format custom field display value on QuickForms

21 months agoEntityRef - Format custom field display value on QuickForms
Coleman Watts [Mon, 20 Feb 2023 23:14:38 +0000 (18:14 -0500)]
EntityRef - Format custom field display value on QuickForms

21 months agoMitigation of scenario where an import table has been deleted and the metadata is...
Eileen [Mon, 20 Feb 2023 23:04:23 +0000 (23:04 +0000)]
Mitigation of scenario where an import table has been deleted and the metadata is out of date

21 months agoAngular Coder: Fix unescaping of quotes breaking attributes
Coleman Watts [Mon, 20 Feb 2023 18:38:09 +0000 (13:38 -0500)]
Angular Coder: Fix unescaping of quotes breaking attributes

Fixes the bug described in https://github.com/civicrm/civicrm-core/pull/25471#issuecomment-1423233785

21 months agoMerge pull request #25471 from colemanw/entityReferenceField
Eileen McNaughton [Mon, 20 Feb 2023 21:29:39 +0000 (10:29 +1300)]
Merge pull request #25471 from colemanw/entityReferenceField

Add new EntityReference custom field type

21 months agocomposer require --dev yoast/phpunit-polyfills
Eileen [Mon, 20 Feb 2023 21:14:29 +0000 (21:14 +0000)]
composer require --dev yoast/phpunit-polyfills

21 months agoMerge pull request #25441 from MegaphoneJon/status-is-a-string
demeritcowboy [Mon, 20 Feb 2023 18:28:47 +0000 (13:28 -0500)]
Merge pull request #25441 from MegaphoneJon/status-is-a-string

getStatus() should be returning a string

21 months agogetStatus() should be returning a string
Jon Goldberg [Thu, 26 Jan 2023 18:18:57 +0000 (13:18 -0500)]
getStatus() should be returning a string

21 months agoCustomFields - Add EntityReference field type based on APIv4 autocomplete
Coleman Watts [Sat, 21 Jan 2023 20:42:36 +0000 (15:42 -0500)]
CustomFields - Add EntityReference field type based on APIv4 autocomplete

21 months agoMerge pull request #25444 from michaelmcandrew/dev/core#4100
demeritcowboy [Mon, 20 Feb 2023 14:33:20 +0000 (09:33 -0500)]
Merge pull request #25444 from michaelmcandrew/dev/core#4100

Add setting to disable Smarty in scheduled reminders

21 months agoMerge pull request #25616 from jitendrapurohit/parse_address_fix
Yashodha Chaku [Mon, 20 Feb 2023 05:21:01 +0000 (10:51 +0530)]
Merge pull request #25616 from jitendrapurohit/parse_address_fix

Regression: Fix DB syntax error on Parse address scheduled  job

21 months agoMerge pull request #25620 from mattwire/afformrelationship
colemanw [Mon, 20 Feb 2023 02:17:54 +0000 (21:17 -0500)]
Merge pull request #25620 from mattwire/afformrelationship

Afform: Fix broken syntax for saving reciprocal relationships

21 months agoMerge pull request #25596 from ixiam/devSK-ShowMoreButtonsAlways
colemanw [Mon, 20 Feb 2023 02:02:38 +0000 (21:02 -0500)]
Merge pull request #25596 from ixiam/devSK-ShowMoreButtonsAlways

Always show "add more buttons" dropdown in searchkit view

21 months agoMerge pull request #25622 from braders/unnecessary-entity-property
Tim Otten [Sun, 19 Feb 2023 22:29:12 +0000 (14:29 -0800)]
Merge pull request #25622 from braders/unnecessary-entity-property

[REF][PHP8.2] Remove unnecessary dynamic property

21 months agoMerge pull request #25625 from braders/deprecated-self-callables
Seamus Lee [Sun, 19 Feb 2023 20:40:32 +0000 (07:40 +1100)]
Merge pull request #25625 from braders/deprecated-self-callables

[REF][PHP8.2] Fix use of self in callables deprecation

21 months agoMerge pull request #25626 from braders/groupcontacttest
Seamus Lee [Sun, 19 Feb 2023 20:39:51 +0000 (07:39 +1100)]
Merge pull request #25626 from braders/groupcontacttest

[REF][PHP8.2] Tidy up properties on api_v3_GroupContactTest

21 months agoMerge pull request #25623 from braders/event-permissions-test
Seamus Lee [Sun, 19 Feb 2023 20:38:57 +0000 (07:38 +1100)]
Merge pull request #25623 from braders/event-permissions-test

[REF][PHP8.2] Tidy up properties in CRM_Event_BAO_EventPermissionsTest

21 months agoMerge pull request #25624 from braders/remove_dedupeRuleGroupID
Seamus Lee [Sun, 19 Feb 2023 20:37:11 +0000 (07:37 +1100)]
Merge pull request #25624 from braders/remove_dedupeRuleGroupID

(REF) Remove test reference to property which no longer exists

21 months agoAfform: Fix syntax for saving reciprocal relationships
Matthew Wire [Sat, 18 Feb 2023 23:17:45 +0000 (23:17 +0000)]
Afform: Fix syntax for saving reciprocal relationships

21 months ago[REF][PHP8.2] Tidy up properties on api_v3_GroupContactTest
Bradley Taylor [Sun, 19 Feb 2023 11:14:22 +0000 (11:14 +0000)]
[REF][PHP8.2] Tidy up properties on api_v3_GroupContactTest

21 months ago[REF][PHP8.2] Fix use of self in callables deprecation
Bradley Taylor [Sun, 19 Feb 2023 11:00:23 +0000 (11:00 +0000)]
[REF][PHP8.2] Fix use of self in callables deprecation

21 months ago(REF) Remove test reference to property which no longer exists
Bradley Taylor [Sun, 19 Feb 2023 10:42:15 +0000 (10:42 +0000)]
(REF) Remove test reference to property which no longer exists

21 months ago[REF][PHP8.2] Tidy up properties in CRM_Event_BAO_EventPermissionsTest
Bradley Taylor [Sun, 19 Feb 2023 10:24:42 +0000 (10:24 +0000)]
[REF][PHP8.2] Tidy up properties in CRM_Event_BAO_EventPermissionsTest

21 months ago[REF][PHP8.2] Remove unnecessary dynamic property
Bradley Taylor [Sun, 19 Feb 2023 10:17:21 +0000 (10:17 +0000)]
[REF][PHP8.2] Remove unnecessary dynamic property

21 months agoMerge pull request #25619 from eileenmcnaughton/php82_test
Eileen McNaughton [Sun, 19 Feb 2023 04:15:27 +0000 (17:15 +1300)]
Merge pull request #25619 from eileenmcnaughton/php82_test

Php8.2 test fix, remove one instance of undeclared property

21 months agoPhp8.2 test fix, remove one instance on undeclared parameter
Eileen McNaughton [Sat, 18 Feb 2023 23:17:49 +0000 (12:17 +1300)]
Php8.2 test fix, remove one instance on undeclared parameter

21 months agoMerge pull request #25617 from eileenmcnaughton/matt_dep
Matthew Wire [Sat, 18 Feb 2023 23:42:00 +0000 (23:42 +0000)]
Merge pull request #25617 from eileenmcnaughton/matt_dep

Stop loading unused `relatedObjects`

21 months agoMerge pull request #25610 from eileenmcnaughton/doc_block
demeritcowboy [Sat, 18 Feb 2023 23:13:44 +0000 (18:13 -0500)]
Merge pull request #25610 from eileenmcnaughton/doc_block

[NFC] doc block fix

21 months agoUnset ids for clarity
Eileen McNaughton [Sat, 18 Feb 2023 22:08:23 +0000 (11:08 +1300)]
Unset ids for clarity

21 months agoStop loaded unused relatedObjects
Eileen McNaughton [Sat, 18 Feb 2023 22:03:53 +0000 (11:03 +1300)]
Stop loaded unused relatedObjects

21 months ago[NFC] doc block fix
Eileen McNaughton [Sat, 18 Feb 2023 00:50:11 +0000 (13:50 +1300)]
[NFC] doc block fix

21 months agoMerge pull request #25586 from herbdool/core-4127-6
demeritcowboy [Sat, 18 Feb 2023 14:39:16 +0000 (09:39 -0500)]
Merge pull request #25586 from herbdool/core-4127-6

dev/core#4127 move mailing workflow check to userSystem

21 months agoMerge pull request #25615 from eileenmcnaughton/matt_dep
Matthew Wire [Sat, 18 Feb 2023 09:51:32 +0000 (09:51 +0000)]
Merge pull request #25615 from eileenmcnaughton/matt_dep

Remove function deprecated a year ago

21 months agoFix DB syntax error on Parse address sched job
jitendrapurohit [Sat, 18 Feb 2023 06:13:59 +0000 (11:43 +0530)]
Fix DB syntax error on Parse address sched job

21 months agoRemove function deprecated a year ago
Eileen McNaughton [Sat, 18 Feb 2023 06:04:06 +0000 (19:04 +1300)]
Remove function deprecated a year ago

21 months agoE-notice fix Ical display
Eileen McNaughton [Sat, 18 Feb 2023 03:30:00 +0000 (16:30 +1300)]
E-notice fix Ical display

21 months agoMerge pull request #25608 from eileenmcnaughton/test_fix
Eileen McNaughton [Sat, 18 Feb 2023 00:54:44 +0000 (13:54 +1300)]
Merge pull request #25608 from eileenmcnaughton/test_fix

Fix test to test the thing it was written to test

21 months agoMerge pull request #25607 from eileenmcnaughton/prop
Eileen McNaughton [Sat, 18 Feb 2023 00:54:23 +0000 (13:54 +1300)]
Merge pull request #25607 from eileenmcnaughton/prop

[NFC] php8.2 support in test class `ActivitySearchTest`

21 months agoMerge pull request #25599 from totten/5.59-patchset-wp
Tim Otten [Sat, 18 Feb 2023 00:05:41 +0000 (16:05 -0800)]
Merge pull request #25599 from totten/5.59-patchset-wp

distmaker - Fix export of WordPress patches

21 months agoFix test to test the thing it was written to test
Eileen McNaughton [Fri, 17 Feb 2023 23:41:40 +0000 (12:41 +1300)]
Fix test to test the thing it was written to test

Per https://github.com/civicrm/civicrm-core/pull/23929 the point of the test was
to check that any override coming from parameters or the recurring contribution
record would be respected.

Also see
https://issues.civicrm.org/jira/browse/CRM-16397

However, the test did not explicity change the recurring contribution record amount
field, having been written after a hook was added that was changing the recurring amount
based on the received payment. So it was not testing it's goal - that where they differed
then, for single line item contributions, the recurring record took precedence.

This fixes to specifically alter them to be different, thus testing the override works
and does not rely on the hook (which is likely to change it's behaviour)

21 months agoMerge pull request #25604 from eileenmcnaughton/parse_private
Tim Otten [Fri, 17 Feb 2023 23:33:31 +0000 (15:33 -0800)]
Merge pull request #25604 from eileenmcnaughton/parse_private

Make private function private

21 months agophp8.2 support in test class ActivitySearchTest
Eileen McNaughton [Fri, 17 Feb 2023 23:10:06 +0000 (12:10 +1300)]
php8.2 support in test class ActivitySearchTest

21 months agoMerge pull request #25550 from totten/master-abbr2
Eileen McNaughton [Fri, 17 Feb 2023 22:42:16 +0000 (11:42 +1300)]
Merge pull request #25550 from totten/master-abbr2

Disambiguate `Address.state_province_id:abbr`

21 months agoMake private function private
Eileen McNaughton [Fri, 17 Feb 2023 21:56:35 +0000 (10:56 +1300)]
Make private function private

21 months agoMerge pull request #25570 from kurund/profile-api-fixes
Yashodha Chaku [Fri, 17 Feb 2023 10:41:25 +0000 (16:11 +0530)]
Merge pull request #25570 from kurund/profile-api-fixes

update entity mapping logic for profile fields to include contact subtypes

21 months agoMerge pull request #25445 from lemniscus/oauth-allow-client-to-set-redirect-uri
Tim Otten [Fri, 17 Feb 2023 07:59:22 +0000 (23:59 -0800)]
Merge pull request #25445 from lemniscus/oauth-allow-client-to-set-redirect-uri

Allow OAuth redirect URI to be overridden in client or provider config

21 months agoMerge pull request #25322 from braders/unused-params-contribution-soft-test
Eileen McNaughton [Fri, 17 Feb 2023 07:53:17 +0000 (20:53 +1300)]
Merge pull request #25322 from braders/unused-params-contribution-soft-test

(REF) Tidy up unused params in api_v3_ContributionSoftTest

21 months agoDisambiguate `Address.state_province_id:abbr` (MySQL; simpler version)
Tim Otten [Fri, 10 Feb 2023 22:40:55 +0000 (14:40 -0800)]
Disambiguate `Address.state_province_id:abbr` (MySQL; simpler version)

Consider `ContactJoinTest::testCreateWithPrimaryAndBilling` which writes the value:

  'address_billing.state_province_id:abbr' => 'AK',

The symbol 'AK' can map to three places: Akwa Ibom (Nigeria), Atakora
(Benin), and Alaska (USA).  This is an ambiguous choice.  It should be
resolved in a consistent way.

One flavor of ambiguity comes from MySQL.  When loading abbreviations, Civi
queries with `ORDER BY abbreviation`.  This is a *typically* stable, but it
has no *guaranteed* resolution.  Adding a secondary sort key makes the
outcome clear/unambiguous.

21 months agoMerge pull request #25595 from totten/master-api4-cast
Tim Otten [Fri, 17 Feb 2023 06:44:19 +0000 (22:44 -0800)]
Merge pull request #25595 from totten/master-api4-cast

APIv4 - Limited support for casting

21 months agoMerge pull request #25601 from eileenmcnaughton/import_constants
Tim Otten [Fri, 17 Feb 2023 06:43:04 +0000 (22:43 -0800)]
Merge pull request #25601 from eileenmcnaughton/import_constants

Remove unused constants left over from import cleanup

21 months agoMerge pull request #25589 from lemniscus/api4-explorer-cv-syntax-short-boolean
Tim Otten [Fri, 17 Feb 2023 03:57:30 +0000 (19:57 -0800)]
Merge pull request #25589 from lemniscus/api4-explorer-cv-syntax-short-boolean

api4 explorer: make boolean params work in cv (short syntax)

21 months agocastTypeSoftly() - Support magic floats and magic ints
Tim Otten [Fri, 17 Feb 2023 00:43:46 +0000 (16:43 -0800)]
castTypeSoftly() - Support magic floats and magic ints

21 months agoMerge pull request #25552 from totten/master-abbr-php
Eileen McNaughton [Fri, 17 Feb 2023 02:56:20 +0000 (15:56 +1300)]
Merge pull request #25552 from totten/master-abbr-php

Disambiguate `Address.state_province_id:abbr` (PHP asort)

21 months agoUse provided params not POST
Eileen McNaughton [Fri, 10 Feb 2023 04:49:06 +0000 (17:49 +1300)]
Use provided params not POST

21 months agoAdd 'SavePoint' to import to statusBounce back to
Eileen McNaughton [Fri, 17 Feb 2023 02:17:00 +0000 (15:17 +1300)]
Add 'SavePoint' to import to statusBounce back to

21 months agoRemove unused constants left over from import cleanup
Eileen McNaughton [Fri, 17 Feb 2023 02:09:27 +0000 (15:09 +1300)]
Remove unused constants left over from import cleanup

21 months agodistmaker - Fix generation of WordPress patches
Tim Otten [Fri, 17 Feb 2023 01:18:15 +0000 (17:18 -0800)]
distmaker - Fix generation of WordPress patches

In `cividist`, the conventional name of the civicrm-wordpress folder is `$SRC/WordPress` not `$SRC/wordpress`.

21 months ago(REF) Move test for APIv4 casting. Make it easier to mock different types.
Tim Otten [Thu, 16 Feb 2023 23:51:23 +0000 (15:51 -0800)]
(REF) Move test for APIv4 casting. Make it easier to mock different types.

21 months agoAdd APIv4 Pledge Autocomplete
Coleman Watts [Thu, 16 Feb 2023 23:12:58 +0000 (18:12 -0500)]
Add APIv4 Pledge Autocomplete

Fixes dev/core#4131

21 months agoMerge pull request #25568 from eileenmcnaughton/search_display_expires
colemanw [Thu, 16 Feb 2023 22:50:24 +0000 (17:50 -0500)]
Merge pull request #25568 from eileenmcnaughton/search_display_expires

Filter expired searches from search kit results

21 months agodev/core#4127 move mailing workflow check to userSystem
Herb v/d Dool [Wed, 15 Feb 2023 17:46:41 +0000 (12:46 -0500)]
dev/core#4127 move mailing workflow check to userSystem

21 months agoAdd setting to disable Smarty in scheduled reminders dev/core#4100
Michael McAndrew [Fri, 27 Jan 2023 15:24:43 +0000 (15:24 +0000)]
Add setting to disable Smarty in scheduled reminders dev/core#4100

21 months agoMerge pull request #25569 from masetto/master
demeritcowboy [Thu, 16 Feb 2023 15:07:11 +0000 (10:07 -0500)]
Merge pull request #25569 from masetto/master

Fix empty values of Note on Import contribution

21 months agoMerge pull request #25594 from eileenmcnaughton/dep
demeritcowboy [Thu, 16 Feb 2023 14:47:03 +0000 (09:47 -0500)]
Merge pull request #25594 from eileenmcnaughton/dep

Deprecate unused `CRM_Core_BAO_UFField::copy()` function

21 months agoalways show "add more buttons" dropdown in searchkit view
Luciano Spiegel [Thu, 16 Feb 2023 10:14:30 +0000 (11:14 +0100)]
always show "add more buttons" dropdown in searchkit view

21 months agoAPIv4 - Limited support for casting
Tim Otten [Thu, 16 Feb 2023 06:58:19 +0000 (22:58 -0800)]
APIv4 - Limited support for casting

Before
------

* `setCheckPermissions(0)` casts the `0` to `false`.
     * This is because it's a concrete setter with explict typing.
* `setUseTrash(0)` does not.
     * This is because it's a magic setter with no typing.

After
-----

* Both `setCheckPermissions(0)` and `setUseTrash(0)` cast the `0` to `false`

Technical Details
-----------------

I initially drafted in a way where `setUseTrash()` performed exactly the same casting
as `setCheckPermissions()`, but there was a countervailing test to assert that
`setDebug('debug')` is invalid, and that seemed fair.

21 months agoMerge pull request #25572 from herbdool/core-4127-2
Eileen McNaughton [Thu, 16 Feb 2023 05:38:29 +0000 (18:38 +1300)]
Merge pull request #25572 from herbdool/core-4127-2

dev/core#4127 move ipAddress to userSystem

21 months agoDeprecate unused CRM_Core_BAO_UFField::copy() function
Eileen McNaughton [Thu, 16 Feb 2023 05:36:11 +0000 (18:36 +1300)]
Deprecate unused CRM_Core_BAO_UFField::copy() function

21 months agoMerge pull request #25593 from eileenmcnaughton/dao
Eileen McNaughton [Thu, 16 Feb 2023 05:04:55 +0000 (18:04 +1300)]
Merge pull request #25593 from eileenmcnaughton/dao

Fix more schema checks to use mysql DATABASE() function, deprecate php function

21 months agodev/core#4127 move ipAddress to userSystem
Herb v/d Dool [Tue, 14 Feb 2023 19:43:13 +0000 (14:43 -0500)]
dev/core#4127 move ipAddress to userSystem

21 months agoMerge pull request #25592 from eileenmcnaughton/import_empty
Tim Otten [Thu, 16 Feb 2023 04:37:07 +0000 (20:37 -0800)]
Merge pull request #25592 from eileenmcnaughton/import_empty

Remove empty function

21 months agoMerge pull request #25302 from eileenmcnaughton/smarty-notice
Tim Otten [Thu, 16 Feb 2023 04:32:17 +0000 (20:32 -0800)]
Merge pull request #25302 from eileenmcnaughton/smarty-notice

Fix Contact import e-notice on preview screen

21 months agoFix more schema checks to use mysql DATABASE() function, deprecate php function
Eileen McNaughton [Thu, 16 Feb 2023 03:50:40 +0000 (16:50 +1300)]
Fix more schema checks to use mysql DATABASE() function, deprecate php function

21 months agoMerge pull request #25571 from herbdool/core-4127-1
Eileen McNaughton [Thu, 16 Feb 2023 03:23:39 +0000 (16:23 +1300)]
Merge pull request #25571 from herbdool/core-4127-1

dev/core#4127 use userSystem method to check for Views

21 months agoRemove empty function
Eileen McNaughton [Wed, 10 Aug 2022 03:28:11 +0000 (15:28 +1200)]
Remove empty function

21 months agoMerge pull request #25591 from seamuslee001/master
Eileen McNaughton [Thu, 16 Feb 2023 01:34:29 +0000 (14:34 +1300)]
Merge pull request #25591 from seamuslee001/master

[REF] Fix undefined variable notice in WordPress tests

21 months ago[REF] Fix undefined variable notice in WordPress tests
Seamus Lee [Wed, 15 Feb 2023 23:15:34 +0000 (10:15 +1100)]
[REF] Fix undefined variable notice in WordPress tests

Remove reference to  as not need