civicrm-core.git
2 years agoMerge pull request #22708 from braders/feature/priceset-notice-fix
demeritcowboy [Sat, 5 Feb 2022 14:22:00 +0000 (09:22 -0500)]
Merge pull request #22708 from braders/feature/priceset-notice-fix

Enotice fix with priceset template

2 years agoEnotice fix with priceset template
Bradley Taylor [Sat, 5 Feb 2022 12:10:58 +0000 (12:10 +0000)]
Enotice fix with priceset template

2 years agoMerge pull request #22704 from braders/remove-invalidprofiles-template-variable
Eileen McNaughton [Sat, 5 Feb 2022 00:51:17 +0000 (13:51 +1300)]
Merge pull request #22704 from braders/remove-invalidprofiles-template-variable

Remove unused invalidProfiles variable, and simplify template.

2 years agoRemove unused invalidProfiles variable, and simplify template.
Bradley Taylor [Fri, 4 Feb 2022 19:39:03 +0000 (19:39 +0000)]
Remove unused invalidProfiles variable, and simplify template.
As well as simplifying things, this avoids PHP notices.

2 years agoMerge pull request #22697 from eileenmcnaughton/cont
demeritcowboy [Fri, 4 Feb 2022 14:55:44 +0000 (09:55 -0500)]
Merge pull request #22697 from eileenmcnaughton/cont

Enotic fixes

2 years agoMerge pull request #22696 from civicrm/dependabot/npm_and_yarn/follow-redirects-1...
Seamus Lee [Fri, 4 Feb 2022 02:49:02 +0000 (13:49 +1100)]
Merge pull request #22696 from civicrm/dependabot/npm_and_yarn/follow-redirects-1.14.7

Bump follow-redirects from 1.11.0 to 1.14.7

2 years agoMerge pull request #22695 from civicrm/dependabot/npm_and_yarn/engine.io-4.1.2
Seamus Lee [Thu, 3 Feb 2022 23:17:25 +0000 (10:17 +1100)]
Merge pull request #22695 from civicrm/dependabot/npm_and_yarn/engine.io-4.1.2

Bump engine.io from 4.1.1 to 4.1.2

2 years agoEnotic fixes
Eileen McNaughton [Thu, 3 Feb 2022 22:49:50 +0000 (11:49 +1300)]
Enotic fixes

2 years agoMerge pull request #22693 from civicrm/dependabot/npm_and_yarn/ansi-regex-5.0.1
Seamus Lee [Thu, 3 Feb 2022 22:33:54 +0000 (09:33 +1100)]
Merge pull request #22693 from civicrm/dependabot/npm_and_yarn/ansi-regex-5.0.1

Bump ansi-regex from 5.0.0 to 5.0.1

2 years agoBump follow-redirects from 1.11.0 to 1.14.7
dependabot[bot] [Thu, 3 Feb 2022 22:31:23 +0000 (22:31 +0000)]
Bump follow-redirects from 1.11.0 to 1.14.7

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.11.0 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.11.0...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years agoMerge pull request #22694 from civicrm/dependabot/npm_and_yarn/log4js-6.4.1
Eileen McNaughton [Thu, 3 Feb 2022 22:30:32 +0000 (11:30 +1300)]
Merge pull request #22694 from civicrm/dependabot/npm_and_yarn/log4js-6.4.1

Bump log4js from 6.3.0 to 6.4.1

2 years agoMerge pull request #22654 from colemanw/optionGroupName
Seamus Lee [Thu, 3 Feb 2022 22:11:56 +0000 (09:11 +1100)]
Merge pull request #22654 from colemanw/optionGroupName

[REF] Switch OptionGroup BAO to use new centralized logic to make name from title

2 years agoBump engine.io from 4.1.1 to 4.1.2
dependabot[bot] [Thu, 3 Feb 2022 20:42:55 +0000 (20:42 +0000)]
Bump engine.io from 4.1.1 to 4.1.2

Bumps [engine.io](https://github.com/socketio/engine.io) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md)
- [Commits](https://github.com/socketio/engine.io/compare/4.1.1...4.1.2)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years agoBump log4js from 6.3.0 to 6.4.1
dependabot[bot] [Thu, 3 Feb 2022 20:42:55 +0000 (20:42 +0000)]
Bump log4js from 6.3.0 to 6.4.1

Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)

---
updated-dependencies:
- dependency-name: log4js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years agoBump ansi-regex from 5.0.0 to 5.0.1
dependabot[bot] [Thu, 3 Feb 2022 20:42:50 +0000 (20:42 +0000)]
Bump ansi-regex from 5.0.0 to 5.0.1

Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](https://github.com/chalk/ansi-regex/compare/v5.0.0...v5.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years agoMerge pull request #22692 from demeritcowboy/composer
Seamus Lee [Thu, 3 Feb 2022 20:42:25 +0000 (07:42 +1100)]
Merge pull request #22692 from demeritcowboy/composer

Update composer.json for composer 2.2 allow-plugins

2 years agoupdate for composer 2.2 allow-plugins
demeritcowboy [Thu, 3 Feb 2022 18:32:14 +0000 (13:32 -0500)]
update for composer 2.2 allow-plugins

2 years agoMerge pull request #22691 from demeritcowboy/ckeditor-uninstall
demeritcowboy [Thu, 3 Feb 2022 16:29:51 +0000 (11:29 -0500)]
Merge pull request #22691 from demeritcowboy/ckeditor-uninstall

Fix typo preventing uninstalling ckeditor4

2 years agofix typo
demeritcowboy [Thu, 3 Feb 2022 14:20:41 +0000 (09:20 -0500)]
fix typo

2 years agoMerge pull request #22685 from eileenmcnaughton/finacl
Monish Deb [Thu, 3 Feb 2022 02:13:05 +0000 (07:43 +0530)]
Merge pull request #22685 from eileenmcnaughton/finacl

Move permission access handling for civicrm/admin/financial/financialType?reset=1 to extension

2 years agoMore permission access handling for civicrm/admin/financial/financialType?reset=1...
Eileen McNaughton [Thu, 13 Jan 2022 04:56:44 +0000 (17:56 +1300)]
More permission access handling for civicrm/admin/financial/financialType?reset=1 to extension

(works for browse & edit)

2 years agoMerge pull request #22675 from colemanw/customGroupNameIndex
colemanw [Wed, 2 Feb 2022 20:38:56 +0000 (15:38 -0500)]
Merge pull request #22675 from colemanw/customGroupNameIndex

CustomGroup - Ensure 'name' is always unique

2 years agoMerge pull request #22609 from colemanw/contactCleanup
Eileen McNaughton [Wed, 2 Feb 2022 20:29:23 +0000 (09:29 +1300)]
Merge pull request #22609 from colemanw/contactCleanup

[REF] - Cleanup Contact BAO variables

2 years agoMerge pull request #22681 from totten/master-queue-cleanup
Eileen McNaughton [Wed, 2 Feb 2022 20:06:42 +0000 (09:06 +1300)]
Merge pull request #22681 from totten/master-queue-cleanup

(REF) Queues - Expand docblocks. Extract SQL trait.

2 years agoCustomGroup - Ensure 'name' is always unique
Coleman Watts [Tue, 1 Feb 2022 20:03:37 +0000 (15:03 -0500)]
CustomGroup - Ensure 'name' is always unique

Previously, unique 'name' was only enforced in tandem with 'extends'
Now it is required to be unique unconditionally.

2 years agoMerge pull request #22657 from totten/master-queue-facade-c
colemanw [Wed, 2 Feb 2022 15:12:43 +0000 (10:12 -0500)]
Merge pull request #22657 from totten/master-queue-facade-c

Queues - Add support for using persistent queues

2 years agoMerge pull request #22662 from colemanw/softDeleteEntity
demeritcowboy [Wed, 2 Feb 2022 14:34:16 +0000 (09:34 -0500)]
Merge pull request #22662 from colemanw/softDeleteEntity

[REF] APIv4 - Rename trait 'SoftDelete' to 'SoftDeleteEntity'

2 years agoMerge pull request #22647 from mlutfy/translation38ml
demeritcowboy [Wed, 2 Feb 2022 13:48:44 +0000 (08:48 -0500)]
Merge pull request #22647 from mlutfy/translation38ml

dev/translation#38 Fix multilingual triggers for when fields default to an empty string

2 years agoMerge pull request #22632 from eileenmcnaughton/msg_send
demeritcowboy [Wed, 2 Feb 2022 13:48:10 +0000 (08:48 -0500)]
Merge pull request #22632 from eileenmcnaughton/msg_send

dev/core#2866 Generate text version of message at send time if not present

2 years agoCivi::queue() - Tweak prioritization of fields per discussion
Tim Otten [Wed, 2 Feb 2022 10:56:19 +0000 (02:56 -0800)]
Civi::queue() - Tweak prioritization of fields per discussion

2 years ago(REF) CRM_Queue_Queue_Sql* - Dedupe `createItem()` function
Tim Otten [Wed, 2 Feb 2022 06:43:10 +0000 (22:43 -0800)]
(REF) CRM_Queue_Queue_Sql* - Dedupe `createItem()` function

Consolidate duplicate implementations. Move to trait.

2 years agodev/core#2866 Generate text version of message at send time if not present
Eileen McNaughton [Wed, 26 Jan 2022 23:00:19 +0000 (12:00 +1300)]
dev/core#2866 Generate text version of message at send time if not present

2 years ago(REF) CRM_Queue_Queue_Sql* - Extract trait for common functions
Tim Otten [Wed, 2 Feb 2022 01:38:42 +0000 (17:38 -0800)]
(REF) CRM_Queue_Queue_Sql* - Extract trait for common functions

Most of the methods in CRM/Queue/Queue/Sql.php and CRM/Queue/Queue/SqlParallel.php are
identical. Move them to a common trait so that they're easier to patch.

2 years ago(NFC) CRM_Queue_Runner - Expand on comments. Tweak layout.
Tim Otten [Tue, 1 Feb 2022 23:39:52 +0000 (15:39 -0800)]
(NFC) CRM_Queue_Runner - Expand on comments. Tweak layout.

2 years ago(NFC) CRM_Queue_Task - Fix docblock
Tim Otten [Tue, 1 Feb 2022 23:05:48 +0000 (15:05 -0800)]
(NFC) CRM_Queue_Task - Fix docblock

2 years agoMerge pull request #22676 from civicrm/5.46
Seamus Lee [Wed, 2 Feb 2022 01:29:48 +0000 (12:29 +1100)]
Merge pull request #22676 from civicrm/5.46

5.46

2 years agoMerge pull request #22235 from kurund/contribution-import
demeritcowboy [Tue, 1 Feb 2022 23:17:40 +0000 (18:17 -0500)]
Merge pull request #22235 from kurund/contribution-import

dev/core#2989 - validate campaign id for contribution import

2 years agoMerge pull request #22678 from alifrumin/rn5.46
Seamus Lee [Tue, 1 Feb 2022 23:10:34 +0000 (10:10 +1100)]
Merge pull request #22678 from alifrumin/rn5.46

[NFC] 5.46 release notes first pass

2 years ago[NFC] 5.46 release notes first pass
Alice Frumin [Tue, 1 Feb 2022 22:20:00 +0000 (17:20 -0500)]
[NFC] 5.46 release notes first pass

2 years agoCivi::queue() - Optionally accept more `array $params` to auto-initialize queue
Tim Otten [Tue, 1 Feb 2022 01:14:20 +0000 (17:14 -0800)]
Civi::queue() - Optionally accept more `array $params` to auto-initialize queue

2 years agoMerge pull request #22642 from colemanw/fixManagedCrash
Seamus Lee [Tue, 1 Feb 2022 21:23:39 +0000 (08:23 +1100)]
Merge pull request #22642 from colemanw/fixManagedCrash

(dev/core#3045) ManagedEntities - Fix crash during upgrade

2 years agoMerge pull request #22674 from braders/api3-docblock-types
Seamus Lee [Tue, 1 Feb 2022 21:22:08 +0000 (08:22 +1100)]
Merge pull request #22674 from braders/api3-docblock-types

Ensure all api3 functions have documented types

2 years agoEnsure all api3 functions have documented types
Bradley Taylor [Tue, 1 Feb 2022 19:36:08 +0000 (19:36 +0000)]
Ensure all api3 functions have documented types

2 years agoMerge pull request #22673 from agileware/CIVICRM-1924
colemanw [Tue, 1 Feb 2022 12:43:52 +0000 (07:43 -0500)]
Merge pull request #22673 from agileware/CIVICRM-1924

Fix spelling mistake in function name, addMembershipToRealtedContacts should be addMembershipToRelatedContacts

2 years agoMerge pull request #22672 from agileware/CIVICRM-1923
colemanw [Tue, 1 Feb 2022 12:16:29 +0000 (07:16 -0500)]
Merge pull request #22672 from agileware/CIVICRM-1923

Manage Contribution page, the link to "Online Contribution (Test-drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agoCIVICRM-1924 Fix spelling mistake in function name, addMembershipToRealtedContacts...
Justin Freeman [Tue, 1 Feb 2022 06:58:18 +0000 (17:58 +1100)]
CIVICRM-1924 Fix spelling mistake in function name, addMembershipToRealtedContacts should be addMembershipToRelatedContacts

2 years agoCIVICRM-1923 Contribution, the link to "Online Contribution (Test-drive)" is an admin...
Justin Freeman [Tue, 1 Feb 2022 06:47:55 +0000 (17:47 +1100)]
CIVICRM-1923 Contribution, the link to "Online Contribution (Test-drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agoMerge pull request #22648 from colemanw/removeApiv4PreSaveSubscriber
Seamus Lee [Tue, 1 Feb 2022 02:39:21 +0000 (13:39 +1100)]
Merge pull request #22648 from colemanw/removeApiv4PreSaveSubscriber

[REF] APIv4 - Deprecate and stop using PreSaveSubscriber

2 years agoCivi::queue(string $name) - Add facade to load queue by name. Add test.
Tim Otten [Sat, 29 Jan 2022 06:35:30 +0000 (22:35 -0800)]
Civi::queue(string $name) - Add facade to load queue by name. Add test.

The test includes coverage for a couple flows - eg creating the queue
via traditional `CRM_Queue_Service` or with the newer Civi\Api4\Queue.

2 years agoCRM_Queue_Service - Add support for persistent queues
Tim Otten [Sat, 29 Jan 2022 06:17:45 +0000 (22:17 -0800)]
CRM_Queue_Service - Add support for persistent queues

Before:

* `CRM_Queue_Service::create()` traditionally provided support for
  instantiating queue objects.
* `civicrm_queue` was recently added for tracking persistent
  metadata about queues.

After:

* `CRM_Queue_Service::create()` works as before, and it also accepts
   parameters `is_persistent` and `is_autorun`.

2 years agoMerge pull request #22666 from braders/avoid-php-notices-activity-form
colemanw [Tue, 1 Feb 2022 00:31:28 +0000 (19:31 -0500)]
Merge pull request #22666 from braders/avoid-php-notices-activity-form

Avoid PHP notices on activity form

2 years agoMerge pull request #22671 from civicrm/5.46
colemanw [Tue, 1 Feb 2022 00:30:12 +0000 (19:30 -0500)]
Merge pull request #22671 from civicrm/5.46

5.46

2 years ago[REF] - Cleanup Contact BAO variables
Coleman Watts [Sun, 23 Jan 2022 22:29:50 +0000 (17:29 -0500)]
[REF] - Cleanup Contact BAO variables

2 years agoMerge pull request #22619 from demeritcowboy/wrong-tz
Seamus Lee [Mon, 31 Jan 2022 22:37:20 +0000 (09:37 +1100)]
Merge pull request #22619 from demeritcowboy/wrong-tz

dev/core#2122 - Manage event online registration page doesn't determine timezone correctly

2 years agoMerge pull request #22670 from agh1/5.46.0-releasenotes-initial
Seamus Lee [Mon, 31 Jan 2022 22:09:59 +0000 (09:09 +1100)]
Merge pull request #22670 from agh1/5.46.0-releasenotes-initial

5.46.0 release notes initial run

2 years agoMerge pull request #22538 from masetto/pdfletter
Eileen McNaughton [Mon, 31 Jan 2022 22:04:23 +0000 (11:04 +1300)]
Merge pull request #22538 from masetto/pdfletter

add `contact_id` to email params in `emailLetter` function

2 years agoAvoid PHP notices on activity form
Bradley Taylor [Sun, 30 Jan 2022 10:44:07 +0000 (10:44 +0000)]
Avoid PHP notices on activity form

2 years ago5.46.0 release notes: added boilerplate
Andie Hunt [Mon, 31 Jan 2022 16:38:18 +0000 (11:38 -0500)]
5.46.0 release notes: added boilerplate

2 years ago5.46.0 release notes: initial run
Andie Hunt [Mon, 31 Jan 2022 16:29:20 +0000 (11:29 -0500)]
5.46.0 release notes: initial run

2 years agoMerge pull request #22587 from colemanw/apiNull
Monish Deb [Mon, 31 Jan 2022 15:10:16 +0000 (20:40 +0530)]
Merge pull request #22587 from colemanw/apiNull

APIv4 - Use empty string instead of 'null' to pass null values to the db

2 years agoMerge pull request #22634 from eileenmcnaughton/pre_message
Yashodha Chaku [Mon, 31 Jan 2022 13:38:02 +0000 (19:08 +0530)]
Merge pull request #22634 from eileenmcnaughton/pre_message

dev/core#2866 add pre-upgrade warning

2 years agoMerge pull request #22652 from civicrm/5.46
demeritcowboy [Mon, 31 Jan 2022 05:34:00 +0000 (00:34 -0500)]
Merge pull request #22652 from civicrm/5.46

5.46

2 years agoMerge pull request #22669 from agileware/CIVICRM-1921
demeritcowboy [Mon, 31 Jan 2022 05:32:32 +0000 (00:32 -0500)]
Merge pull request #22669 from agileware/CIVICRM-1921

CiviCRM Event, the link to "On-line Registration (Test Drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agoMerge pull request #22668 from braders/profile-preview-template-formatting
colemanw [Sun, 30 Jan 2022 20:32:56 +0000 (15:32 -0500)]
Merge pull request #22668 from braders/profile-preview-template-formatting

[REF] Tidy up group.tpl

2 years agoTidy up group.tpl
Bradley Taylor [Sun, 30 Jan 2022 16:44:59 +0000 (16:44 +0000)]
Tidy up group.tpl

This rationalises the indentation, and removes an extra closing </div> which was causing issues in some contexts.

2 years agoMerge pull request #22653 from colemanw/searchKitOperatorFixes
colemanw [Sat, 29 Jan 2022 21:38:38 +0000 (16:38 -0500)]
Merge pull request #22653 from colemanw/searchKitOperatorFixes

SearchKit - Fix selecting operators and values in clauses

2 years agoMerge pull request #22663 from braders/manage-event-listing-default-values
colemanw [Sat, 29 Jan 2022 21:13:37 +0000 (16:13 -0500)]
Merge pull request #22663 from braders/manage-event-listing-default-values

Set default values to avoid notices when rendering (event templates screen)

2 years agoSwitch OptionGroup BAO to use new centralized logic to make name from title
Coleman Watts [Fri, 28 Jan 2022 18:16:47 +0000 (13:16 -0500)]
Switch OptionGroup BAO to use new centralized logic to make name from title

Switches APIv4 to use writeRecords for the OptionGroup entity;
keeps v3 the same for backward-compatability.

2 years agoMerge pull request #22660 from braders/membership-dashboard-smarty-notices
colemanw [Sat, 29 Jan 2022 18:35:44 +0000 (13:35 -0500)]
Merge pull request #22660 from braders/membership-dashboard-smarty-notices

Fix smarty notices in membership dashboard

2 years agoMerge pull request #22661 from braders/contributionpage-php-notice
colemanw [Sat, 29 Jan 2022 18:35:21 +0000 (13:35 -0500)]
Merge pull request #22661 from braders/contributionpage-php-notice

Avoid PHP notice on 'Manage Contribution Pages' screen

2 years agoSet default values to avoid notices when rendering
Bradley Taylor [Sat, 29 Jan 2022 18:25:42 +0000 (18:25 +0000)]
Set default values to avoid notices when rendering

2 years agoAPIv4 - Rename 'SoftDelete' trait => 'SoftDeleteEntity'
Coleman Watts [Sat, 29 Jan 2022 16:25:20 +0000 (11:25 -0500)]
APIv4 - Rename 'SoftDelete' trait => 'SoftDeleteEntity'

2 years agoAvoid PHP notice on 'Manage Contribution Pages' screen
Bradley Taylor [Sat, 29 Jan 2022 15:54:19 +0000 (15:54 +0000)]
Avoid PHP notice on 'Manage Contribution Pages' screen

2 years agoFix smarty notices in membership dashboard
Bradley Taylor [Sat, 29 Jan 2022 12:14:18 +0000 (12:14 +0000)]
Fix smarty notices in membership dashboard

2 years agoMerge pull request #22658 from braders/phpdoc-fixes-3
colemanw [Sat, 29 Jan 2022 15:14:30 +0000 (10:14 -0500)]
Merge pull request #22658 from braders/phpdoc-fixes-3

Another set of PHPdoc corrections

2 years agoMerge pull request #22659 from braders/const-type-hints
colemanw [Sat, 29 Jan 2022 15:12:49 +0000 (10:12 -0500)]
Merge pull request #22659 from braders/const-type-hints

Correctly document types for class consts

2 years agoAnother set of PHPdoc corrections
Bradley Taylor [Sat, 29 Jan 2022 11:46:55 +0000 (11:46 +0000)]
Another set of PHPdoc corrections

2 years agoCorrectly document types for class consts
Bradley Taylor [Sat, 29 Jan 2022 11:56:12 +0000 (11:56 +0000)]
Correctly document types for class consts

2 years ago(NFC) QueueTest - Extra cleanups and assertions.
Tim Otten [Sat, 29 Jan 2022 06:34:46 +0000 (22:34 -0800)]
(NFC) QueueTest - Extra cleanups and assertions.

2 years ago(NFC) CRM_Queue_Service - Fix docblock examples
Tim Otten [Sat, 29 Jan 2022 06:06:18 +0000 (22:06 -0800)]
(NFC) CRM_Queue_Service - Fix docblock examples

2 years agoMerge pull request #22656 from seamuslee001/5.46
Seamus Lee [Fri, 28 Jan 2022 23:30:54 +0000 (10:30 +1100)]
Merge pull request #22656 from seamuslee001/5.46

5.45.1 & 5.45.2 Release Notes

2 years agoAdd release-notes/5.45.2.md
Tim Otten [Fri, 28 Jan 2022 23:23:05 +0000 (15:23 -0800)]
Add release-notes/5.45.2.md

2 years agoAdd release-notes/5.45.1.md
Tim Otten [Tue, 11 Jan 2022 19:34:54 +0000 (11:34 -0800)]
Add release-notes/5.45.1.md

2 years agoSearchKit - Fix selecting operators and values in clauses
Coleman Watts [Fri, 28 Jan 2022 14:54:34 +0000 (09:54 -0500)]
SearchKit - Fix selecting operators and values in clauses

Fixes dev/core#3046 which was caused by incomplete refactoring in
https://github.com/civicrm/civicrm-core/pull/22604

2 years agoMerge pull request #22358 from colemanw/searchKitNotNull
colemanw [Fri, 28 Jan 2022 15:13:32 +0000 (10:13 -0500)]
Merge pull request #22358 from colemanw/searchKitNotNull

SearchKit - Improve editable UX by not allowing required fields to be left blank

2 years agoMerge pull request #22650 from totten/5.46-greeting
demeritcowboy [Fri, 28 Jan 2022 14:46:26 +0000 (09:46 -0500)]
Merge pull request #22650 from totten/5.46-greeting

dev/core#3028 - For invalid greetings, return '' instead of failing

2 years agoCIVICRM-1921 Event, the link to "On-line Registration (Test Drive)" is an admin-only...
Justin Freeman [Fri, 28 Jan 2022 06:48:40 +0000 (17:48 +1100)]
CIVICRM-1921 Event, the link to "On-line Registration (Test Drive)" is an admin-only URL to register in the backend, should be a frontend URL

2 years agodev/core#3028 - For invalid greetings, return '' instead of failing
Eileen McNaughton [Fri, 28 Jan 2022 05:58:07 +0000 (21:58 -0800)]
dev/core#3028 - For invalid greetings, return '' instead of failing

2 years agoMerge pull request #22649 from colemanw/api4CustomDateFormat
colemanw [Fri, 28 Jan 2022 03:36:26 +0000 (22:36 -0500)]
Merge pull request #22649 from colemanw/api4CustomDateFormat

APIv4 - Correctly return date-only custom field values without the time

2 years agoAPIv4 - Correctly return date-only custom field values without the time
Coleman Watts [Fri, 28 Jan 2022 01:23:33 +0000 (20:23 -0500)]
APIv4 - Correctly return date-only custom field values without the time

2 years agoAPIv4 - Deprecate and stop using PreSaveSubscriber
Coleman Watts [Thu, 27 Jan 2022 21:09:08 +0000 (16:09 -0500)]
APIv4 - Deprecate and stop using PreSaveSubscriber

The PreSaveSubscriber allowed APIs to tweak inputs before saving a record,
but it was unreliable because:
- It would run for Create and Update but not Save actions
- It would run before pseudoconstant suffixes had been resolved
- It would run before any formatting or internal processing had taken place

Meanwhile, a new pattern of overriding the create/save/update actions and sharing a trait
has become more common and while a bit more cumbersome to implement, it does not share
those limitations.

This removes all uses of PreSaveSubscriber, refactors those bits into Save traits, and
adds a deprecation warning in case any extension in the Universe happens to have implemented it.

2 years agoMerge pull request #22646 from braders/feature/tasktrait-issingle-docblock
Eileen McNaughton [Thu, 27 Jan 2022 21:44:51 +0000 (10:44 +1300)]
Merge pull request #22646 from braders/feature/tasktrait-issingle-docblock

Resolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait

2 years agoMerge pull request #22645 from demeritcowboy/event-default-tz
Eileen McNaughton [Thu, 27 Jan 2022 21:44:22 +0000 (10:44 +1300)]
Merge pull request #22645 from demeritcowboy/event-default-tz

dev/core#2122 - Add an event timezone for sample data

2 years agoMerge pull request #22644 from demeritcowboy/fix-add-version
Seamus Lee [Thu, 27 Jan 2022 20:42:03 +0000 (07:42 +1100)]
Merge pull request #22644 from demeritcowboy/fix-add-version

dev/core#2122 - Fix "add" version for event timezone dao field

2 years agotranslation#38 - test for multilingual custom fields
Jon Goldberg [Fri, 2 Jul 2021 19:48:08 +0000 (15:48 -0400)]
translation#38 - test for multilingual custom fields

2 years agodev/translation#38 Fix multilingual triggers for when fields default to an empty...
Mathieu Lutfy [Thu, 27 Jan 2022 20:00:01 +0000 (15:00 -0500)]
dev/translation#38 Fix multilingual triggers for when fields default to an empty string

2 years agoResolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait
Bradley Taylor [Thu, 27 Jan 2022 19:42:42 +0000 (19:42 +0000)]
Resolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait

2 years agodefault event timezone for sample data
demeritcowboy [Thu, 27 Jan 2022 19:19:42 +0000 (14:19 -0500)]
default event timezone for sample data

2 years agofix add version
demeritcowboy [Thu, 27 Jan 2022 19:09:11 +0000 (14:09 -0500)]
fix add version

2 years agoManagedEntities - Fix crash during upgrade
Coleman Watts [Thu, 27 Jan 2022 17:19:08 +0000 (12:19 -0500)]
ManagedEntities - Fix crash during upgrade

This prevents a potential crash when trying to update a column before it has been added by the upgrader

Fixes dev/core#3045